Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-05 Thread Chamikara Jayalath
Ok. Let's cherry-pick this and David's change and re-build then :) On Wed, Dec 5, 2018 at 10:41 AM Ahmet Altay wrote: > Hi Cham, > > Could we merge https://github.com/apache/beam/pull/7210 into the release > branch (PR is the cherry-pick PR), before cutting RC1? The use of conscrypt > SSL is

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-05 Thread Ahmet Altay
Hi Cham, Could we merge https://github.com/apache/beam/pull/7210 into the release branch (PR is the cherry-pick PR), before cutting RC1? The use of conscrypt SSL is resulting in stuck pipelines, I would like to change the default back to the default SSL provider. This change only affects Dataflow

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-05 Thread Chamikara Jayalath
Thank you! I hope to get RC1 email out tomorrow. On Wed, Dec 5, 2018, 2:07 AM David Morávek I don’t think it is a blocker. If you already did RC cut, please ignore > this. > > Thanks, > D. > > Sent from my iPhone > > On 5 Dec 2018, at 11:03, Chamikara Jayalath wrote: > > Hi David, > > I have

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-05 Thread David Morávek
I don’t think it is a blocker. If you already did RC cut, please ignore this. Thanks, D. Sent from my iPhone > On 5 Dec 2018, at 11:03, Chamikara Jayalath wrote: > > Hi David, > > I have already build the RC1 and started running some tests. > > Do you think this is a blocker ? If not, I

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-05 Thread Chamikara Jayalath
Hi David, I have already build the RC1 and started running some tests. Do you think this is a blocker ? If not, I think we should hold it till 2.10 (approx. 4 - 6 weeks). If you think it's a blocker I can build the candidate again and run tests. Thanks, Cham On Wed, Dec 5, 2018 at 1:37 AM

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-05 Thread David Morávek
Would it be possible to cherry pick this patch into 2.9? It removes forgotten kryo dependency from Euphoria DSL, which we don't want user to start depending on, unless *beam-sdks-java-extension-kryo* dependency is explicitly used. https://github.com/apache/beam/pull/7195 Thanks, D. On Tue, Dec

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-03 Thread Chamikara Jayalath
I've been running tests on the existing branch. Will try to cut a candidate today. Seems like this is a small fix that fixes a flake. So feel free to send a cherry-pick. Thanks, Cham On Mon, Dec 3, 2018 at 4:28 AM Maximilian Michels wrote: > How far are we with the release? If the release

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-12-03 Thread Maximilian Michels
How far are we with the release? If the release branch hasn't been frozen, I'd like to cherry-pick https://github.com/apache/beam/pull/7171/files Thanks, Max On 30.11.18 04:17, Lukasz Cwik wrote: I got to thank Steve Niemitz for double checking my work and pointing out an error which helped

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-29 Thread Lukasz Cwik
I got to thank Steve Niemitz for double checking my work and pointing out an error which helped narrow down the BEAM-6102 issue. On Thu, Nov 29, 2018 at 2:05 PM Chamikara Jayalath wrote: > Blockers were resolved and fixes were cherry-picked to the release branch. > I'll continue the release

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-29 Thread Chamikara Jayalath
Blockers were resolved and fixes were cherry-picked to the release branch. I'll continue the release process. Thanks, Cham On Mon, Nov 26, 2018 at 10:50 AM Lukasz Cwik wrote: > I'm working on BEAM-6102 and after 12 hours on the issue I have not made > much real progress. I initially suspected

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-26 Thread Lukasz Cwik
I'm working on BEAM-6102 and after 12 hours on the issue I have not made much real progress. I initially suspected its a shading issue with the Dataflow worker jar but can't reproduce the issue without running a full Dataflow pipeline. Any help would be appreciated, context of what I have tried is

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-26 Thread Chamikara Jayalath
Hi All, Currently there are two blockers for the 2.9.0 release. * Dataflow cannot deserialize DoFns - https://issues.apache.org/jira/browse/BEAM-6102 * [SQL] Nexmark 5, 7 time out - https://issues.apache.org/jira/browse/BEAM-6082 We'll postpone cutting the release candidate till these issues

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-21 Thread Kenneth Knowles
You could `git checkout -b release-2.9.0 `. But cherrypicking fixes is also easy. Kenn On Wed, Nov 21, 2018 at 1:06 PM Chamikara Jayalath wrote: > I went through Jenkins test suites and failures seems to be known issues > with JIRAs that are release blockers. So we'll cherry-pick fixes to

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-21 Thread Chamikara Jayalath
I went through Jenkins test suites and failures seems to be known issues with JIRAs that are release blockers. So we'll cherry-pick fixes to these. In general though I think it might be hard to pick an exact "green" time for cutting the release just by eyeballing since different test suites run at

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-21 Thread Chamikara Jayalath
Release branch was cut: https://github.com/apache/beam/tree/release-2.9.0 Please cherry-pick fixes to 2.9.0 blockers to this branch. Thanks, Cham On Tue, Nov 20, 2018 at 9:00 PM Jean-Baptiste Onofré wrote: > Hi Cham, > > it sounds good to me. > > I'm resuming some works on IOs but nothing

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-20 Thread Jean-Baptiste Onofré
Hi Cham, it sounds good to me. I'm resuming some works on IOs but nothing blocker. Regards JB On 21/11/2018 03:59, Chamikara Jayalath wrote: > Hi All, > > Looks like there are three blockers in the burndown list but they are > actively being worked on. > > If there's no objection I'll create

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-20 Thread Chamikara Jayalath
Hi All, Looks like there are three blockers in the burndown list but they are actively being worked on. If there's no objection I'll create the release branch tomorrow morning. We can cherry-pick fixes to the blockers before building the first RC hopefully on Monday. Thanks, Cham On Sat, Nov

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-17 Thread Kenneth Knowles
On Fri, Nov 16, 2018, 18:25 Thomas Weise > > On Thu, Nov 15, 2018 at 10:53 PM Charles Chen wrote: > >> +1 >> >> Note that we need to temporarily revert >> https://github.com/apache/beam/pull/6683 before the release branch cut >> per the discussion at >>

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-17 Thread Chamikara Jayalath
On Fri, Nov 16, 2018 at 8:25 PM Ahmet Altay wrote: > > > On Fri, Nov 16, 2018 at 8:16 PM, Thomas Weise wrote: > >> >> >> On Fri, Nov 16, 2018 at 8:02 PM Ahmet Altay wrote: >> >>> >>> >>> On Fri, Nov 16, 2018 at 6:25 PM, Thomas Weise wrote: >>> On Thu, Nov 15, 2018 at 10:53 PM

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-16 Thread Ahmet Altay
On Fri, Nov 16, 2018 at 8:16 PM, Thomas Weise wrote: > > > On Fri, Nov 16, 2018 at 8:02 PM Ahmet Altay wrote: > >> >> >> On Fri, Nov 16, 2018 at 6:25 PM, Thomas Weise wrote: >> >>> >>> >>> On Thu, Nov 15, 2018 at 10:53 PM Charles Chen wrote: >>> +1 Note that we need to

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-16 Thread Thomas Weise
On Fri, Nov 16, 2018 at 8:02 PM Ahmet Altay wrote: > > > On Fri, Nov 16, 2018 at 6:25 PM, Thomas Weise wrote: > >> >> >> On Thu, Nov 15, 2018 at 10:53 PM Charles Chen wrote: >> >>> +1 >>> >>> Note that we need to temporarily revert >>> https://github.com/apache/beam/pull/6683 before the

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-16 Thread Ahmet Altay
On Fri, Nov 16, 2018 at 6:25 PM, Thomas Weise wrote: > > > On Thu, Nov 15, 2018 at 10:53 PM Charles Chen wrote: > >> +1 >> >> Note that we need to temporarily revert https://github.com/apache/ >> beam/pull/6683 before the release branch cut per the discussion at >>

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-16 Thread Thomas Weise
On Thu, Nov 15, 2018 at 10:53 PM Charles Chen wrote: > +1 > > Note that we need to temporarily revert > https://github.com/apache/beam/pull/6683 before the release branch cut > per the discussion at >

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-16 Thread Łukasz Gajowy
+1 Thanks, Łukasz pt., 16 lis 2018, 12:00: Maximilian Michels napisał(a): > +1 for starting the release process in time > > > Note that we need to temporarily revert > https://github.com/apache/beam/pull/6683 before the release branch cut > per the discussion > > +1 > > Thanks, > Max > > On

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-16 Thread Maximilian Michels
+1 for starting the release process in time > Note that we need to temporarily revert https://github.com/apache/beam/pull/6683 before the release branch cut per the discussion +1 Thanks, Max On 16.11.18 07:53, Charles Chen wrote: +1 Note that we need to temporarily revert

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-15 Thread Charles Chen
+1 Note that we need to temporarily revert https://github.com/apache/beam/pull/6683 before the release branch cut per the discussion at https://lists.apache.org/thread.html/78fe33dc41b04886f5355d66d50359265bfa2985580bb70f79c53545@%3Cdev.beam.apache.org%3E On Thu, Nov 15, 2018 at 9:18 PM Tim

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-15 Thread Tim
Thanks Cham +1 > On 16 Nov 2018, at 05:30, Thomas Weise wrote: > > +1 > > >> On Thu, Nov 15, 2018 at 4:34 PM Ahmet Altay wrote: >> +1 Thank you. >> >>> On Thu, Nov 15, 2018 at 4:22 PM, Kenneth Knowles wrote: >>> SGTM. Thanks for keeping track of the schedule. >>> >>> Kenn >>> On

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-15 Thread Thomas Weise
+1 On Thu, Nov 15, 2018 at 4:34 PM Ahmet Altay wrote: > +1 Thank you. > > On Thu, Nov 15, 2018 at 4:22 PM, Kenneth Knowles wrote: > >> SGTM. Thanks for keeping track of the schedule. >> >> Kenn >> >> On Thu, Nov 15, 2018 at 1:59 PM Chamikara Jayalath >> wrote: >> >>> Hi All, >>> >>>

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-15 Thread Ahmet Altay
+1 Thank you. On Thu, Nov 15, 2018 at 4:22 PM, Kenneth Knowles wrote: > SGTM. Thanks for keeping track of the schedule. > > Kenn > > On Thu, Nov 15, 2018 at 1:59 PM Chamikara Jayalath > wrote: > >> Hi All, >> >> According to the release calendar [1] branch cut date for Beam 2.9.0 >> release is

Re: [PROPOSAL] Prepare Beam 2.9.0 release

2018-11-15 Thread Kenneth Knowles
SGTM. Thanks for keeping track of the schedule. Kenn On Thu, Nov 15, 2018 at 1:59 PM Chamikara Jayalath wrote: > Hi All, > > According to the release calendar [1] branch cut date for Beam 2.9.0 > release is 11/21/2018. Since previous release branch was cut close to the > respective calendar

[PROPOSAL] Prepare Beam 2.9.0 release

2018-11-15 Thread Chamikara Jayalath
Hi All, According to the release calendar [1] branch cut date for Beam 2.9.0 release is 11/21/2018. Since previous release branch was cut close to the respective calendar date I'd like to propose cutting release branch for 2.9.0 on 11/21/2018. Next week is Thanksgiving holiday in US and possibly