Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-21 Thread Kenneth Knowles
This discussion veered into territory reserved for priv...@beam.apache.org [1]. But the PMC has agreed that an update is deserved here: We are taking it very seriously that you have placed faith in Beam and that you need to be able to effectively continue development of Euphoria. We are actively

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-17 Thread David Morávek
That's great news. Thank you! D. On Tue, Oct 16, 2018 at 6:06 PM Thomas Weise wrote: > Congrats to the Euphoria team! > > On Tue, Oct 16, 2018 at 8:51 AM Kenneth Knowles wrote: > >> Merged. Welcome to the repo :-) >> >> Kenn >> >> On Thu, Oct 11, 2018 at 10:06 AM Kenneth Knowles wrote: >>

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-16 Thread Thomas Weise
Congrats to the Euphoria team! On Tue, Oct 16, 2018 at 8:51 AM Kenneth Knowles wrote: > Merged. Welcome to the repo :-) > > Kenn > > On Thu, Oct 11, 2018 at 10:06 AM Kenneth Knowles wrote: > >> I've filed the IP Clearance. I'll report back here. >> >> Kenn >> >> On Wed, Oct 10, 2018 at 3:33 PM

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-16 Thread Kenneth Knowles
Merged. Welcome to the repo :-) Kenn On Thu, Oct 11, 2018 at 10:06 AM Kenneth Knowles wrote: > I've filed the IP Clearance. I'll report back here. > > Kenn > > On Wed, Oct 10, 2018 at 3:33 PM David Morávek > wrote: > >> >> >> Anton: >> All of the points are be correct, with one minor

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-16 Thread Robert Bradshaw
Ideally one (or all) of you can become committers [1], which I think should be the goal. While for the time being this would involve the overhead of getting existing committers to sign off on PRs (which can be reviewed by others as well), this can actually be beneficial as it will be a forcing

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-15 Thread Reuven Lax
There isn't currently a concept of a partial committer - you are either a committer or you aren't. Figuring out the best way forward here is a question for the wider community. Reuven On Sun, Oct 14, 2018 at 2:41 AM David Morávek wrote: > Thanks Kenn and Reuven! > > This brings up the

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-14 Thread David Morávek
Thanks Kenn and Reuven! This brings up the question, how should we proceed with the further development? Up until now, we did all changes in our own repository, which was very flexible as we could do code reviews and PR merges by ourselves. We would love to take a full responsibility for the

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-11 Thread Kenneth Knowles
I've filed the IP Clearance. I'll report back here. Kenn On Wed, Oct 10, 2018 at 3:33 PM David Morávek wrote: > > > Anton: > All of the points are be correct, with one minor exception. We are > currently moving our production workloads from Euphoria > to

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread David Morávek
Anton: All of the points are be correct, with one minor exception. We are currently moving our production workloads from Euphoria to Beam (using the DSL), but we are hitting scalability issues of the current spark runner, so it is not technically used in

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread Kenneth Knowles
I just glanced through it to make sure things are in the right place and build set up right and that all LGTM. We need to file the IP Clearance to finish the process that Davor started. Please fill the XML template at

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread Anton Kedin
I think the code looks good and we should probably just merge it (unless there are other blockers, e.g. formal approvals), considering: - it has been reviewed; - it is tested and used in production; - it was discussed on the list and there were no objections to having it as part of Beam; - it

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread David Morávek
Hello Max, It would be great if you can do more of a "general" review, the code base is fairly large, well tested and it was already reviewed internally by several people. We would like to have the overall approach and design decisions validated by the community and get some inputs on what could

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread Maximilian Michels
That is a huge PR! :) Euphoria looks great. Especially for people coming from Flink/Spark. I'll check out the documentation. Do you have any specific code parts which you want to have reviewed? Thanks, Max On 10.10.18 10:30, Jean-Baptiste Onofré wrote: Hi, Thanks for all the work you are

Re: [Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread Jean-Baptiste Onofré
Hi, Thanks for all the work you are doing on this DSL ! I tried to follow the features branch for a while. I'm still committed to move forward on that front, but more reviewers would be great. Regards JB On 10/10/2018 10:26, Plajt, Vaclav wrote: > Hello Beam devs, > we finished our main

[Proposal] Euphoria DSL - looking for reviewers

2018-10-10 Thread Plajt, Vaclav
Hello Beam devs, we finished our main goals in development of Euphoria DSL. It is Easy to use Java 8 API build on top of the Beam's Java SDK. API provides a high-level abstraction of data transformations, with focus on the Java 8 language features (e.g. lambdas and streams). It is fully