Build failed in Jenkins: brooklyn-master-windows #57

2016-04-06 Thread Apache Jenkins Server
See -- [...truncated 37423 lines...] [INFO] Brooklyn Common Utilities .. SUCCESS [ 25.826 s] [INFO] Brooklyn API ... SUCCESS [ 3.790 s]

[GitHub] brooklyn-server pull request: Fixed command for installing python ...

2016-04-06 Thread jongyoul
GitHub user jongyoul opened a pull request: https://github.com/apache/brooklyn-server/pull/105 Fixed command for installing python via apt-get and yum by using sudo When I use a "Template 2: Bash Web Server" with non-root user and password-less sudo, I've got a error because I

Build failed in Jenkins: brooklyn-master-windows #55

2016-04-06 Thread Apache Jenkins Server
See -- [...truncated 28941 lines...] at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203) at

[VOTE] Release Apache Brooklyn 0.9.0 [rc3]

2016-04-06 Thread Richard Downer
This is to call for a vote for the release of Apache Brooklyn 0.9.0 [rc3]. This release comprises of a source code distribution, and a corresponding binary distribution, RPM packages, Vagrant environment package, and Maven artifacts. The source and binary distributions, including signatures,

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Richard Downer
Thanks Aled. I'm kicking off rc3 just now. Richard. On 6 April 2016 at 20:43, Aled Sage wrote: > I've reviewed and tested John's brooklyn-dist PR #31: looks good, so merged > into master and 0.9.0. > > --- > As discussed offline, in the vote email we'll want to include

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage
I've reviewed and tested John's brooklyn-dist PR #31: looks good, so merged into master and 0.9.0. --- As discussed offline, in the vote email we'll want to include checksums of the individual brooklyn-client artifacts. This is because we want to include them as individually downloadable

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-dist/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755945 --- Diff: vagrant/src/main/vagrant/servers.yaml --- @@ -41,7 +41,9 @@ servers: box: ubuntu/wily64 ram: 2048 cpus: 4 -

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755772 --- Diff: vagrant/src/main/vagrant/servers.yaml --- @@ -41,7 +41,9 @@ servers: box: ubuntu/wily64 ram: 2048 cpus: 4 -

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755124 --- Diff: vagrant/src/main/vagrant/servers.yaml --- @@ -41,7 +41,9 @@ servers: box: ubuntu/wily64 ram: 2048 cpus: 4 -

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748964 --- Diff: vagrant/src/main/vagrant/servers.yaml --- @@ -41,7 +41,9 @@ servers: box: ubuntu/wily64 ram: 2048 cpus: 4 -

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread aledsage
Github user aledsage commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748556 --- Diff: vagrant/src/main/vagrant/servers.yaml --- @@ -41,7 +41,9 @@ servers: box: ubuntu/wily64 ram: 2048 cpus: 4 -

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage
Thanks Sam, That is now cherry-picked into 0.9.0. Agree it is low-risk and worth including. --- Can someone please review and test John's https://github.com/apache/brooklyn-dist/pull/31? It looks low risk and simple. Aled On 06/04/2016 17:29, Sam Corbett wrote: If I've not missed the

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread John McCabe
Likewise can https://github.com/apache/brooklyn-dist/pull/31 be considered for inclusion. /John On Wed, 6 Apr 2016 at 17:29 Sam Corbett wrote: > If I've not missed the cutoff I'd like > https://github.com/apache/brooklyn-server/pull/99 to be included. > > On 6

[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-dist/pull/31#issuecomment-206465976 fyi @neykov this is related to you comment about the web console url not being correct for Vagrant. --- If your project is set up for it, you can reply to

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206456324 We will probably have to cheat as the textarea is hidden by CodeMirror. AFAIK, we can still bound to those events but from the CodeMirror container rather than the

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206451829 My thinking was binding to the dragenter / dragover / dragleave events from the textarea assuming the codemirror code propagates said events. Then

[jira] [Resolved] (BROOKLYN-173) WinRM executeScript failed: httplib.BadStatusLine: ''

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-173. Resolution: Fixed Fix Version/s: 0.9.0 Has not been seen since we upgraded to the new

Jenkins build is back to normal : brooklyn-ui-master #10

2016-04-06 Thread Apache Jenkins Server
See

[jira] [Resolved] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-249. Resolution: Fixed Assignee: Aled Sage Fix Version/s: 0.9.0 > errors using

[jira] [Resolved] (BROOKLYN-246) Unable to add byon locations

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-246. Resolution: Fixed Fix Version/s: 0.9.0 > Unable to add byon locations >

[jira] [Resolved] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-248. Resolution: Fixed Assignee: Aled Sage Fix Version/s: 0.9.0 > Incorrect name in

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206447871 The drag & drop feature is provided by CodeMirror. I'm not sure it can be customised, I'll need to check that. That being said, the content of the file is

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Richard Downer
On 6 April 2016 at 17:17, Aled Sage wrote: > I believe that Richard is discussing which Geoff about which brooklyn-client > platform artifacts are required. Once that is agreed and sorted, then I > think we are good to go. I've checked Geoff's PR and it's nice and simple:

[jira] [Resolved] (BROOKLYN-245) Deadlock from ControlledDynamicWebAppCluster, plus thread modifying attribute

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-245. Resolution: Fixed Assignee: Aled Sage Fix Version/s: 0.9.0 > Deadlock from

[jira] [Resolved] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aled Sage resolved BROOKLYN-244. Resolution: Fixed Fix Version/s: 0.9.0 > Blueprint Composer: text disappears after few

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage
Thanks Mark for reviewing brooklyn-ui PR #24. That is now merged into master and cherry-picked into 0.9.0. (I completely agree with Mark's comments in #24, which can be addressed in a future PR just in master). --- I believe that Richard is discussing which Geoff about which brooklyn-client

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-ui/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206444894 LGTM **MINOR** * Might be worth adding styling for dragover * Might be worth verifying the type of the dropped file --- If your project is set

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Geoff Macartney
That's fine by me. cheers Geoff Gnu PGP key - http://is.gd/uI > On 6 Apr 2016, at 16:58, Aled Sage wrote: > > Hi Geoff, > > I think we should *not* include it in the 0.9.0 release. It improves the > build process, but does not change the final

[GitHub] brooklyn-server pull request: Support removal of catalog entries f...

2016-04-06 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/100#discussion_r58729416 --- Diff: core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java --- @@ -100,54 +103,82 @@ public ManagementContext

[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-client/pull/16#issuecomment-206434349 LGTM :: Warnings are gone :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Build failed in Jenkins: brooklyn-ui-master #9

2016-04-06 Thread Apache Jenkins Server
See Changes: [thomas.bouron] BROOKLYN-244: Fix blueprint composer loading issue [thomas.bouron] BROOKLYN-244: Add error handling if the applications' fetch fails -- [...truncated 1072

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Thomas Bouron
I also have two candidates to include: https://github.com/apache/brooklyn-ui/pull/23 and https://github.com/apache/brooklyn-ui/pull/24 Thoughts? On Wed, 6 Apr 2016 at 15:51 Geoff Macartney < geoff.macart...@cloudsoftcorp.com> wrote: > Would it be worth including CLI Go vendoring - >

[jira] [Commented] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228438#comment-15228438 ] ASF GitHub Bot commented on BROOKLYN-244: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206420422 @aledsage +1 to including in the 0.9.0 release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-client/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-client/pull/16#issuecomment-206419694 Looks good and builds cleanly. Even the warning is gone now. Merging. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419817 Great, thank @aledsage! If it gets into 0.9.0, you might also want #24 --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228429#comment-15228429 ] ASF GitHub Bot commented on BROOKLYN-244: - Github user aledsage commented on the pull request:

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419417 Thanks @tbouron and @m4rkmckenna Merging now. Sounds like something to get into the next 0.9.0 release candidate. --- If your project is set up for it,

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/24 Update editor placeholder The text now makes it clear that users can use drag & drop to add text files' content into the editor ![brooklyn js rest

Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage
Hi all, Svet: agree with brooklyn-client/pull/14 and brooklyn-client/pull/15. I've cherry-picked those. We have reviewed and incorporated the following fixes into master and the 0.9.0 branch, ready for the next release candidate: * BROOKLYN-249:

[GitHub] brooklyn-dist pull request: Add Debian packaning

2016-04-06 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-dist/pull/28#issuecomment-206402275 Looks good, apart from some minor comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228327#comment-15228327 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395613 thanks @johnmccabe, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228324#comment-15228324 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user neykov commented on the pull request:

[GitHub] brooklyn-dist pull request: Add Debian packaning

2016-04-06 Thread neykov
Github user neykov commented on a diff in the pull request: https://github.com/apache/brooklyn-dist/pull/28#discussion_r58713891 --- Diff: deb-packaging/src/deb/control/control --- @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228323#comment-15228323 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user johnmccabe commented on the pull request:

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228322#comment-15228322 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user johnmccabe commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395204 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395066 @aledsage looks like something messed up my side... it works as expected now. Previously I was deleting then pulling the pr into a branch on

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206390410 @aledsage I've deleted my PR branch and am rebuilding again (I'd rebuilt earlier to sanity check my observations... third time lucky) --- If your project

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228304#comment-15228304 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user johnmccabe commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206389822 @johnmccabe your example works for me when I build and run brooklyn locally. I don't have any files not committed or anything like that. --- If your project

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228302#comment-15228302 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user aledsage commented on the pull request:

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228252#comment-15228252 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user neykov commented on the pull request:

[jira] [Commented] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228246#comment-15228246 ] ASF GitHub Bot commented on BROOKLYN-244: - Github user m4rkmckenna commented on the pull

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228247#comment-15228247 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user neykov commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206376601 LGTM, merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request: https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206376464 LGTM Tested with a simulated 50 kb/s connection ... worked as expected --- If your project is set up for it, you can reply to this email and have your

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228240#comment-15228240 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user johnmccabe commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206374347 I pulled and built a few minutes ago and tried with this catalog: ``` brooklyn.catalog: version: 0.1.2 items: - id: loc-common-base

[GitHub] brooklyn-docs pull request: Cli doc updates

2016-04-06 Thread geomacy
Github user geomacy commented on a diff in the pull request: https://github.com/apache/brooklyn-docs/pull/25#discussion_r58702996 --- Diff: guide/ops/cli/index.md --- @@ -6,7 +6,25 @@ children: - cli-usage-guide.md --- -{% include list-children.html %}

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228221#comment-15228221 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user aledsage commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206365759 Good to review and merge now (assuming jenkins doesn't find any problems). --- If your project is set up for it, you can reply to this email and have your

[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread geomacy
GitHub user geomacy opened a pull request: https://github.com/apache/brooklyn-client/pull/16 Use Go 1.6 vendoring instead of Godep. Uses current version of dependencies, just moving them to the vendor directory. You can merge this pull request into a Git repository by running:

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228216#comment-15228216 ] Aled Sage commented on BROOKLYN-248: For the short/medium term fix, I've put in location-specific

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228159#comment-15228159 ] Aled Sage commented on BROOKLYN-248: Edited my original code snippet to remove the duplicate

[jira] [Comment Edited] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228068#comment-15228068 ] Aled Sage edited comment on BROOKLYN-248 at 4/6/16 12:05 PM: - I've been

Build failed in Jenkins: brooklyn-master-windows #54

2016-04-06 Thread Apache Jenkins Server
See -- [...truncated 19639 lines...] 2016-04-06 12:53:49,674 INFO TESTNG INVOKING: "Surefire test" - org.apache.brooklyn.core.location.geo.HostGeoInfoTest.testCustomLocationChildCoordinates()

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread John McCabe (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228150#comment-15228150 ] John McCabe commented on BROOKLYN-248: -- How would it be used for a real location use case? I'd have

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228146#comment-15228146 ] ASF GitHub Bot commented on BROOKLYN-248: - Github user aledsage commented on the pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206331907 STILL DO NOT MERGE. I've added more test cases, and reverted the change to `CampResolver`, because that broke things for entities. But the new tests for a app

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/104#issuecomment-206318007 DO NOT MERGE: although this fixes it for the location test case, it breaks the expected behaviour for locations (see failing jenkins test). --- If your

[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request: https://github.com/apache/brooklyn-ui/pull/23 BROOKLYN-244: Fix blueprint composer loading issue This load straight away CodeMirror when launching the composer for the composer tab, removing the requirement on loading the full list of

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228072#comment-15228072 ] ASF GitHub Bot commented on BROOKLYN-249: - Github user sjcorbett commented on a diff in the pull

[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/103#discussion_r58682355 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java --- @@ -0,0 +1,139 @@

Build failed in Jenkins: brooklyn-master-windows #53

2016-04-06 Thread Apache Jenkins Server
See -- [...truncated 33779 lines...] [INFO] Exclude: **/*.json [INFO] Exclude: **/*.plxarc [INFO] Exclude:

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228071#comment-15228071 ] ASF GitHub Bot commented on BROOKLYN-249: - Github user sjcorbett commented on a diff in the pull

[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request: https://github.com/apache/brooklyn-server/pull/103#discussion_r58681822 --- Diff: camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java --- @@ -0,0 +1,139 @@

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228070#comment-15228070 ] ASF GitHub Bot commented on BROOKLYN-248: - GitHub user aledsage opened a pull request:

[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
GitHub user aledsage opened a pull request: https://github.com/apache/brooklyn-server/pull/104 BROOKLYN-248: fix location displayName inheritance You can merge this pull request into a Git repository by running: $ git pull https://github.com/aledsage/brooklyn-server

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228068#comment-15228068 ] Aled Sage commented on BROOKLYN-248: I've been looking into this and written a unit test. The

Build failed in Jenkins: brooklyn-server-master #41

2016-04-06 Thread Apache Jenkins Server
See Changes: [aled.sage] BROOKLYN-249: JcloudsLocation resolves external config [aled.sage] Trim publicKeyData [aled.sage] BROOKLYN-249: fix location rebind for external config [aled.sage] BROOKLYN-249: test JcloudsLocation

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228036#comment-15228036 ] ASF GitHub Bot commented on BROOKLYN-249: - Github user asfgit closed the pull request at:

[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/brooklyn-server/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228013#comment-15228013 ] ASF GitHub Bot commented on BROOKLYN-249: - Github user aledsage commented on the pull request:

[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request: https://github.com/apache/brooklyn-server/pull/103#issuecomment-206257277 Existing tests include `ExternalConfigYamlTest.testExternalisedLocationConfigReferencedFromYaml` and

[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread neykov
Github user neykov commented on the pull request: https://github.com/apache/brooklyn-server/pull/103#issuecomment-206219546 Looks good. Are the external properties in locations already covered by tests (don't see related changes in last commit)? --- If your project is set up for it,