Build failed in Jenkins: brooklyn-master-windows #57

2016-04-06 Thread Apache Jenkins Server
See 

--
[...truncated 37423 lines...]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 25.826 s]
[INFO] Brooklyn API ... SUCCESS [  3.790 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.480 s]
[INFO] CAMP Base .. SUCCESS [  4.647 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.605 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  3.095 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.522 s]
[INFO] CAMP Server  SUCCESS [  8.792 s]
[INFO] CAMP Server Jersey . SUCCESS [  8.505 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.836 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.247 s]
[INFO] Brooklyn Core .. SUCCESS [04:22 min]
[INFO] Brooklyn Policies .. SUCCESS [01:25 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [  9.316 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 10.488 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  0.937 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 24.313 s]
[INFO] Brooklyn Software Base . SUCCESS [01:21 min]
[INFO] Brooklyn CAMP REST API . SUCCESS [05:18 min]
[INFO] Brooklyn Hazelcast Storage . SUCCESS [  5.353 s]
[INFO] Brooklyn Launcher Common ... SUCCESS [  5.038 s]
[INFO] Brooklyn REST API .. SUCCESS [ 10.494 s]
[INFO] Brooklyn REST Resources  FAILURE [ 56.751 s]
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn REST Server with Jersey dependencies .. SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] hello-world-webapp Maven Webapp  SKIPPED
[INFO] hello-world-sql-webapp Maven Webapp  SKIPPED
[INFO] Brooklyn Simple Web Cluster Example  SKIPPED
[INFO] Brooklyn Global Web Fabric Example . SKIPPED
[INFO] Brooklyn Simple Messaging Publish-Subscribe Example  SKIPPED
[INFO] Brooklyn NoSQL Cluster Examples  SKIPPED
[INFO] Brooklyn Downstream Project Parent . SKIPPED
[INFO] Brooklyn Dist Root . SKIPPED
[INFO] Brooklyn All Things  SKIPPED
[INFO] Brooklyn Distribution .. SKIPPED
[INFO] Brooklyn Vagrant Getting Started Environment ... SKIPPED
[INFO] Brooklyn Quick-Start Project Archetype . SKIPPED
[INFO] Brooklyn Root .. SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 16:51 min
[INFO] Finished at: 2016-04-07T02:49:44+01:00
[INFO] Final Memory: 117M/463M
[INFO] 

[GitHub] brooklyn-server pull request: Fixed command for installing python ...

2016-04-06 Thread jongyoul
GitHub user jongyoul opened a pull request:

https://github.com/apache/brooklyn-server/pull/105

Fixed command for installing python via apt-get and yum by using sudo

When I use a "Template 2: Bash Web Server" with non-root user and 
password-less sudo, I've got a error because I don't have any python installed. 
We should use sudo command for installing python.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/brooklyn-server python-install

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/105.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #105


commit a0341a4c5d9cb2111d875caa8f1d7a1af9a058e4
Author: Jongyoul Lee 
Date:   2016-04-05T03:20:41Z

Fixed command for installing python via apt-get and yum by using sudo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-master-windows #55

2016-04-06 Thread Apache Jenkins Server
See 

--
[...truncated 28941 lines...]
at 
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
at 
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
at 
org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)


Results :

Failed tests: 
  
SoftwareProcessPersisterInMemorySizeIntegrationTest>BrooklynMementoPersisterInMemorySizeIntegrationTest.testPersistenceVolumeFastNoTrigger:67->BrooklynMementoPersisterInMemorySizeIntegrationTest.doTestPersistenceVolume:83
 should have written fewer than 80 files, wrote 80 expected [true] but found 
[false]

Tests run: 155, Failures: 1, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [01:22 min]
[INFO] Brooklyn Server Root ... SUCCESS [  0.381 s]
[INFO] Brooklyn Parent Project  SUCCESS [ 12.306 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [ 11.055 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  1.059 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 40.407 s]
[INFO] Brooklyn API ... SUCCESS [  4.878 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.920 s]
[INFO] CAMP Base .. SUCCESS [  6.557 s]
[INFO] Brooklyn Test Support .. SUCCESS [  3.447 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  4.211 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.730 s]
[INFO] CAMP Server  SUCCESS [ 12.430 s]
[INFO] CAMP Server Jersey . SUCCESS [ 12.248 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.911 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.493 s]
[INFO] Brooklyn Core .. SUCCESS [08:51 min]
[INFO] Brooklyn Policies .. SUCCESS [02:32 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [ 15.307 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 19.363 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  1.555 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 44.356 s]
[INFO] Brooklyn Software Base . FAILURE [02:18 min]
[INFO] Brooklyn CAMP REST API . SKIPPED
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn REST Server with Jersey dependencies .. SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] 

[VOTE] Release Apache Brooklyn 0.9.0 [rc3]

2016-04-06 Thread Richard Downer
This is to call for a vote for the release of Apache Brooklyn 0.9.0 [rc3].

This release comprises of a source code distribution, and a
corresponding binary distribution, RPM packages, Vagrant environment
package, and Maven artifacts.

The source and binary distributions, including signatures, digests,
etc. can be found at:
https://dist.apache.org/repos/dist/dev/brooklyn/apache-brooklyn-0.9.0-rc3

The artifact SHA-256 checksums are as follows:
65e3438c81c76d47f98e637554e4b80c8c869ff482c18ca9b2d838778268a56b
*apache-brooklyn-0.9.0-rc3-1.noarch.rpm
1a1235c10962371f52240f7fcb1c89f1d066cbb55715c493f4fdffc0a6927da0
*apache-brooklyn-0.9.0-rc3-bin.tar.gz
f95a566d5bb086906d8a4657029757b08a90d2483ef00a7eae0ddd55832b0f4c
*apache-brooklyn-0.9.0-rc3-bin.zip
bbceefda7444a0235527d9830230acb6a3d9f9c6280f36bccc59486a3ee80db8
*apache-brooklyn-0.9.0-rc3-client-cli-linux.tar.gz
7a1cabc5d96be11cbd538a202c1712f9bd053be18f37dc533c543004b247a802
*apache-brooklyn-0.9.0-rc3-client-cli-linux.zip
51ecff55d2c7308efc7f215cc5ab4bdfd8db8d2588fde3346b3c5ad53cf9d396
*apache-brooklyn-0.9.0-rc3-client-cli-macosx.tar.gz
cce8cf9819cb57b1c0bbbdbef76da43fb8142ed2f0a6b9cb613850e2188081d6
*apache-brooklyn-0.9.0-rc3-client-cli-macosx.zip
6d5f1ca2d9550048c80cdf951f00c780c3766d09960f15a47585c37e44c16926
*apache-brooklyn-0.9.0-rc3-client-cli-windows.tar.gz
d0d021f17efe389558b5d12141694179f3245acd9d016bd9de03917fc6b9fa4c
*apache-brooklyn-0.9.0-rc3-client-cli-windows.zip
b993253273280027c45adb4d6899493e8df0301080128d6c8bc10148da3c1a74
*apache-brooklyn-0.9.0-rc3-src.tar.gz
f9e4396ab123b650fe02675e0e753f819c4a5bcbf8ed48fd5fa925a6ba93e149
*apache-brooklyn-0.9.0-rc3-src.zip
052412c38707152b01117ccf504aa75d742495743b134f2d328dd4725f19ee4e
*apache-brooklyn-0.9.0-rc3-vagrant.tar.gz
4a9cc996b827342c11176257bd1663ecb572913f2d3f3dc1f2d43b54be62aa52
*apache-brooklyn-0.9.0-rc3-vagrant.zip

The Nexus staging repositories for the Maven artifacts are located at:
https://repository.apache.org/content/repositories/orgapachebrooklyn-1018
https://repository.apache.org/content/repositories/orgapachebrooklyn-1019

All release artifacts are signed with the following key:
https://people.apache.org/keys/committer/richard.asc

KEYS file available here:
https://dist.apache.org/repos/dist/release/brooklyn/KEYS

The artifacts were built from these Git commit IDs:
brooklyn: acc8ff1930d243d2a5fae1ad2f1a1ef17ca4a19c
brooklyn-client: bc8593a933fcb76327ae4a511643e39d25a87ba2
brooklyn-dist: f08bddf201ab02a4f7066bfa3bcacf01bb430b99
brooklyn-docs: 12430d193e1891b87a677d6b45a3b17861c83518
brooklyn-library: 2565e6eb2868468ec2528df74fe85efdb887b6d2
brooklyn-server: 718aea7d27ce21835860d2de6a31d0e9474bee85
brooklyn-ui: 34d196678a8ae37804c698413d4ef19b86719a8f
All of the above have been tagged as "apache-brooklyn-0.9.0-rc3".


Please download the artifacts, test, and vote on releasing this
package as Apache Brooklyn 0.9.0.

The vote will be open for at least 72 hours.
[ ] +1 Release this package as Apache Brooklyn 0.9.0 (please describe
the tests you have performed)
[ ] +0 no opinion
[ ] -1 Do not release this package (please describe why not)

Thanks


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Richard Downer
Thanks Aled. I'm kicking off rc3 just now.

Richard.


On 6 April 2016 at 20:43, Aled Sage  wrote:
> I've reviewed and tested John's brooklyn-dist PR #31: looks good, so merged
> into master and 0.9.0.
>
> ---
> As discussed offline, in the vote email we'll want to include checksums of
> the individual brooklyn-client artifacts. This is because we want to include
> them as individually downloadable artifacts, so that someone visiting [1]
> can download the specific cli binary for their platform (rather than having
> to download the zip of all of them, unzip it, and then get the right
> artifact).
>
> Richard: over to you to make sure we comply with Apache for this, and to
> produce the next release candidate.
>
> Aled
>
> [1] http://brooklyn.apache.org/download/index.html
>
>
>
> On 06/04/2016 18:31, Aled Sage wrote:
>>
>> Thanks Sam,
>>
>> That is now cherry-picked into 0.9.0. Agree it is low-risk and worth
>> including.
>>
>> ---
>> Can someone please review and test John's
>> https://github.com/apache/brooklyn-dist/pull/31? It looks low risk and
>> simple.
>>
>> Aled
>>
>>
>> On 06/04/2016 17:29, Sam Corbett wrote:
>>>
>>> If I've not missed the cutoff I'd like
>>> https://github.com/apache/brooklyn-server/pull/99 to be included.
>>>
>>> On 6 April 2016 at 17:19, Richard Downer  wrote:
>>>
 On 6 April 2016 at 17:17, Aled Sage  wrote:
>
> I believe that Richard is discussing which Geoff about which

 brooklyn-client
>
> platform artifacts are required. Once that is agreed and sorted, then I
> think we are good to go.

 I've checked Geoff's PR and it's nice and simple: Mac 64bit, Windows
 and Linux 32bit. The 32bit executables execute on 64bit machines so
 there's no benefit to 64bit artifacts. To the best of my knowledge
 there has never been a 32-bit Intel-based Mac, and even if there was,
 it's obsolete.

 So it's ready to go IMO.

>>
>


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage
I've reviewed and tested John's brooklyn-dist PR #31: looks good, so 
merged into master and 0.9.0.


---
As discussed offline, in the vote email we'll want to include checksums 
of the individual brooklyn-client artifacts. This is because we want to 
include them as individually downloadable artifacts, so that someone 
visiting [1] can download the specific cli binary for their platform 
(rather than having to download the zip of all of them, unzip it, and 
then get the right artifact).


Richard: over to you to make sure we comply with Apache for this, and to 
produce the next release candidate.


Aled

[1] http://brooklyn.apache.org/download/index.html


On 06/04/2016 18:31, Aled Sage wrote:

Thanks Sam,

That is now cherry-picked into 0.9.0. Agree it is low-risk and worth 
including.


---
Can someone please review and test John's 
https://github.com/apache/brooklyn-dist/pull/31? It looks low risk and 
simple.


Aled


On 06/04/2016 17:29, Sam Corbett wrote:

If I've not missed the cutoff I'd like
https://github.com/apache/brooklyn-server/pull/99 to be included.

On 6 April 2016 at 17:19, Richard Downer  wrote:


On 6 April 2016 at 17:17, Aled Sage  wrote:

I believe that Richard is discussing which Geoff about which

brooklyn-client
platform artifacts are required. Once that is agreed and sorted, 
then I

think we are good to go.

I've checked Geoff's PR and it's nice and simple: Mac 64bit, Windows
and Linux 32bit. The 32bit executables execute on 64bit machines so
there's no benefit to 64bit artifacts. To the best of my knowledge
there has never been a 32-bit Intel-based Mac, and even if there was,
it's obsolete.

So it's ready to go IMO.







[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-dist/pull/31


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755945
  
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
 box: ubuntu/wily64
 ram: 2048
 cpus: 4
-ip: 10.10.10.100
--- End diff --

As the doc update is to the website that shouldn't block release.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755772
  
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
 box: ubuntu/wily64
 ram: 2048
 cpus: 4
-ip: 10.10.10.100
--- End diff --

@aledsage I've committed a change that enables `autocorrect`, vagrant will 
attempt to remap the port if it can - it doesn't work for me (I'll need to have 
a deeper look at why Vagrant refuses to map the port for me), instead throwing 
a warning that you're trying to bind to a port that's already in use - see the 
commit for more information on what happens.

I'm inclined to leave it as-is, and just fix the doc reference to the 
webconsole url 
[here](http://brooklyn.apache.org/v/0.9.0-SNAPSHOT/start/running.html#control-apache-brooklyn)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/31#discussion_r58755124
  
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
 box: ubuntu/wily64
 ram: 2048
 cpus: 4
-ip: 10.10.10.100
--- End diff --

Omitting the IP is what switches to host only networking, if you specify an 
address here it results in Virtualbox creating a new virtual subnet to put the 
guest on.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748964
  
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
 box: ubuntu/wily64
 ram: 2048
 cpus: 4
-ip: 10.10.10.100
+forwarded_ports:
+ - guest: 8081
+   host: 8081
--- End diff --

If it's a process running in userspace then it will override the mapped 
port which will become accessible if the overriding process is halted.
Give me a second and I'll check the output from `:auto_correct`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread aledsage
Github user aledsage commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/31#discussion_r58748556
  
--- Diff: vagrant/src/main/vagrant/servers.yaml ---
@@ -41,7 +41,9 @@ servers:
 box: ubuntu/wily64
 ram: 2048
 cpus: 4
-ip: 10.10.10.100
+forwarded_ports:
+ - guest: 8081
+   host: 8081
--- End diff --

If someone has another process listening on port 8081, then presumably 
`vagrant up brooklyn` will fail with a nice message? Is that ok to assume they 
won't have anything else running there? I think yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage

Thanks Sam,

That is now cherry-picked into 0.9.0. Agree it is low-risk and worth 
including.


---
Can someone please review and test John's 
https://github.com/apache/brooklyn-dist/pull/31? It looks low risk and 
simple.


Aled


On 06/04/2016 17:29, Sam Corbett wrote:

If I've not missed the cutoff I'd like
https://github.com/apache/brooklyn-server/pull/99 to be included.

On 6 April 2016 at 17:19, Richard Downer  wrote:


On 6 April 2016 at 17:17, Aled Sage  wrote:

I believe that Richard is discussing which Geoff about which

brooklyn-client

platform artifacts are required. Once that is agreed and sorted, then I
think we are good to go.

I've checked Geoff's PR and it's nice and simple: Mac 64bit, Windows
and Linux 32bit. The 32bit executables execute on 64bit machines so
there's no benefit to 64bit artifacts. To the best of my knowledge
there has never been a 32-bit Intel-based Mac, and even if there was,
it's obsolete.

So it's ready to go IMO.





Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread John McCabe
Likewise can https://github.com/apache/brooklyn-dist/pull/31 be considered
for inclusion.
/John
On Wed, 6 Apr 2016 at 17:29 Sam Corbett 
wrote:

> If I've not missed the cutoff I'd like
> https://github.com/apache/brooklyn-server/pull/99 to be included.
>
> On 6 April 2016 at 17:19, Richard Downer  wrote:
>
> > On 6 April 2016 at 17:17, Aled Sage  wrote:
> > > I believe that Richard is discussing which Geoff about which
> > brooklyn-client
> > > platform artifacts are required. Once that is agreed and sorted, then I
> > > think we are good to go.
> >
> > I've checked Geoff's PR and it's nice and simple: Mac 64bit, Windows
> > and Linux 32bit. The 32bit executables execute on 64bit machines so
> > there's no benefit to 64bit artifacts. To the best of my knowledge
> > there has never been a 32-bit Intel-based Mac, and even if there was,
> > it's obsolete.
> >
> > So it's ready to go IMO.
> >
>


[GitHub] brooklyn-dist pull request: use host only networking for brooklyn ...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/31#issuecomment-206465976
  
fyi @neykov this is related to you comment about the web console url not 
being correct for Vagrant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206456324
  
We will probably have to cheat as the textarea is hidden by CodeMirror. 
AFAIK, we can still bound to those events but from the CodeMirror container 
rather than the textarea.

I'll investigate more tomorrow


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206451829
  
My thinking was binding to the dragenter / dragover / dragleave events from 
the textarea assuming the codemirror code propagates said events.

Then adding / removing a class from the textarea OR changing the drag icon 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Resolved] (BROOKLYN-173) WinRM executeScript failed: httplib.BadStatusLine: ''

2016-04-06 Thread Aled Sage (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aled Sage resolved BROOKLYN-173.

   Resolution: Fixed
Fix Version/s: 0.9.0

Has not been seen since we upgraded to the new winrm4j (that does not use 
pywinrm).

> WinRM executeScript failed: httplib.BadStatusLine: ''
> -
>
> Key: BROOKLYN-173
> URL: https://issues.apache.org/jira/browse/BROOKLYN-173
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
>Reporter: Aled Sage
> Fix For: 0.9.0
>
>
> When deploying a simple Windows 7zip app to a vcloud-director environment 
> (over NAT), the install command failed: {{httplib.BadStatusLine: ''}}
> After this error, I tested executing another batch command over the same 
> WinrmMachineLocation+VanillaWindowsProcess, and that worked:
> {noformat}
> mgmt.getEntityManager().getEntity("wV0Kbv2T").getLocations()[0].executeScript("powershell
>  -command \"C:install7zip.ps1\"").getStdOut()
> {noformat}
> The error was:
> {noformat}
> Failed after 44.2s: failed to execute shell script, 10 errors including: 
> Traceback (most recent call last):
>   File "__pyclasspath__/winrm/__init__.py", line 42, in run_cmd
>   File "__pyclasspath__/winrm/protocol.py", line 310, in 
> get_command_output
>   File "__pyclasspath__/winrm/protocol.py", line 328, in 
> _raw_get_command_output
>   File "__pyclasspath__/winrm/protocol.py", line 190, in send_message
>   File "__pyclasspath__/winrm/transport.py", line 82, in send_message
>   File "__pyclasspath__/winrm/transport.py", line 82, in send_message
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 127, in urlopen
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 410, in open
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 522, in http_response
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 442, in error
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 382, in _call_chain
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 896, in http_error_401
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 872, in http_error_auth_reqed
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 885, in retry_http_basic_auth
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 404, in open
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 421, in _open
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 382, in _call_chain
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 1214, in http_open
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 1187, in do_open
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 1187, in do_open
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/httplib.py",
>  line 1045, in getresponse
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/httplib.py",
>  line 409, in begin
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/httplib.py",
>  line 373, in _read_status
> httplib.BadStatusLine: ''
> org.apache.brooklyn.util.exceptions.CompoundRuntimeException: failed to 
> execute shell script, 10 errors including: Traceback (most recent call last):
>   File "__pyclasspath__/winrm/__init__.py", line 42, in run_cmd
>   File "__pyclasspath__/winrm/protocol.py", line 310, in 
> get_command_output
>   File "__pyclasspath__/winrm/protocol.py", line 328, in 
> _raw_get_command_output
>   File "__pyclasspath__/winrm/protocol.py", line 190, in send_message
>   File "__pyclasspath__/winrm/transport.py", line 82, in send_message
>   File "__pyclasspath__/winrm/transport.py", line 82, in send_message
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 127, in urlopen
>   File 
> "/home/amp/cloudsoft-amp-3.0.0-rc2/lib/amp/jython-standalone-2.7-b3.jar/Lib/urllib2.py",
>  line 410, in open
>   File 
> 

Jenkins build is back to normal : brooklyn-ui-master #10

2016-04-06 Thread Apache Jenkins Server
See 



[jira] [Resolved] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread Aled Sage (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aled Sage resolved BROOKLYN-249.

   Resolution: Fixed
 Assignee: Aled Sage
Fix Version/s: 0.9.0

> errors using external config for JcloudsLocation
> 
>
> Key: BROOKLYN-249
> URL: https://issues.apache.org/jira/browse/BROOKLYN-249
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>Assignee: Aled Sage
> Fix For: 0.9.0
>
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using 
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and 
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included 
> the external config in the location (it tried to coerce the 
> {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (BROOKLYN-246) Unable to add byon locations

2016-04-06 Thread Aled Sage (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aled Sage resolved BROOKLYN-246.

   Resolution: Fixed
Fix Version/s: 0.9.0

> Unable to add byon locations
> 
>
> Key: BROOKLYN-246
> URL: https://issues.apache.org/jira/browse/BROOKLYN-246
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
>Reporter: John McCabe
>Priority: Blocker
> Fix For: 0.9.0
>
>
> Running both the most recent 0.9.0-SNAPSHOT dist from maven and a freshly 
> build 0.10.0-SNAPSHOT from master I'm seeing the following behaviour.
> 1. Attempting to add a BYON location via jsgui is rejected with the following 
> error:
> {code}
> Could not resolve item 'testingid': Transformer for Brooklyn OASIS CAMP 
> interpreter gave an error creating this plan: No class or resolver found for 
> location type byon
> {code}
> 2. Trying the the generated JSON via the composer also fails:
> {code}
> brooklyn.catalog:
>   version: 0.0.1
>   items:
>   - id: testingid
> itemType: location
> item:
>   type: byon
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
> hosts:
> - 10.10.10.102
> {code}
> 3. *BUT* this works:
> {code}
> brooklyn.catalog:
>   version: 0.0.1
>   items:
>   - id: testingid
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aled Sage resolved BROOKLYN-248.

   Resolution: Fixed
 Assignee: Aled Sage
Fix Version/s: 0.9.0

> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>Assignee: Aled Sage
> Fix For: 0.9.0
>
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206447871
  
The drag & drop feature is provided by CodeMirror. I'm not sure it can be 
customised, I'll need to check that.

That being said, the content of the file is inserted where your cursor / 
mouse cursor drop the file, so having a classic overlay "drop file here" won't 
work here.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Richard Downer
On 6 April 2016 at 17:17, Aled Sage  wrote:
> I believe that Richard is discussing which Geoff about which brooklyn-client
> platform artifacts are required. Once that is agreed and sorted, then I
> think we are good to go.

I've checked Geoff's PR and it's nice and simple: Mac 64bit, Windows
and Linux 32bit. The 32bit executables execute on 64bit machines so
there's no benefit to 64bit artifacts. To the best of my knowledge
there has never been a 32-bit Intel-based Mac, and even if there was,
it's obsolete.

So it's ready to go IMO.


[jira] [Resolved] (BROOKLYN-245) Deadlock from ControlledDynamicWebAppCluster, plus thread modifying attribute

2016-04-06 Thread Aled Sage (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aled Sage resolved BROOKLYN-245.

   Resolution: Fixed
 Assignee: Aled Sage
Fix Version/s: 0.9.0

> Deadlock from ControlledDynamicWebAppCluster, plus thread modifying attribute
> -
>
> Key: BROOKLYN-245
> URL: https://issues.apache.org/jira/browse/BROOKLYN-245
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>Assignee: Aled Sage
> Fix For: 0.9.0
>
>
> With master (i.e. would also affect 0.9.0)...
> When running {{org.apache.brooklyn.qa.load.LoadTest}} several times, I hit 
> the deadlock below.
> The test deploys several apps concurrently, each using 
> {{ControlledDynamicWebAppCluster}} (via the Java-app 
> {{SimulatedTheeTierApp}}). This deadlock could happen in other uses of 
> {{ControlledDynamicWebAppCluster}}, or in other entities depending if/when 
> they synchronize on the entity themselves.
> {noformat}
> Java stack information for the threads listed above:
> ===
> "brooklyn-execmanager-H7Adif6C-157":
> at 
> org.apache.brooklyn.core.sensor.AttributeMap.asMap(AttributeMap.java:92)
> - waiting to lock <0x0007d3504b60> (a 
> java.util.Collections$SynchronizedMap)
> at 
> org.apache.brooklyn.core.entity.AbstractEntity$BasicSensorSupport.getAll(AbstractEntity.java:1129)
> at 
> org.apache.brooklyn.core.entity.AbstractEntity.getAllAttributes(AbstractEntity.java:1003)
> at 
> org.apache.brooklyn.core.mgmt.rebind.dto.MementosGenerators.newEntityMementoBuilder(MementosGenerators.java:194)
> at 
> org.apache.brooklyn.core.mgmt.rebind.BasicEntityRebindSupport.getMementoWithProperties(BasicEntityRebindSupport.java:69)
> at 
> org.apache.brooklyn.core.mgmt.rebind.BasicEntityRebindSupport.getMemento(BasicEntityRebindSupport.java:61)
> at 
> org.apache.brooklyn.core.mgmt.rebind.BasicEntityRebindSupport.getMemento(BasicEntityRebindSupport.java:1)
> at 
> org.apache.brooklyn.core.mgmt.rebind.PeriodicDeltaChangeListener.persistNowInternal(PeriodicDeltaChangeListener.java:417)
> at 
> org.apache.brooklyn.core.mgmt.rebind.PeriodicDeltaChangeListener.persistNowSafely(PeriodicDeltaChangeListener.java:352)
> at 
> org.apache.brooklyn.core.mgmt.rebind.PeriodicDeltaChangeListener.persistNowSafely(PeriodicDeltaChangeListener.java:346)
> at 
> org.apache.brooklyn.core.mgmt.rebind.PeriodicDeltaChangeListener$1$1.call(PeriodicDeltaChangeListener.java:215)
> at 
> org.apache.brooklyn.core.mgmt.rebind.PeriodicDeltaChangeListener$1$1.call(PeriodicDeltaChangeListener.java:1)
> at 
> org.apache.brooklyn.util.core.task.BasicExecutionManager$ScheduledTaskCallable$1.call(BasicExecutionManager.java:436)
> at 
> org.apache.brooklyn.util.core.task.BasicExecutionManager$SubmissionCallable.call(BasicExecutionManager.java:519)
> at java.util.concurrent.FutureTask.run(FutureTask.java:262)
> at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
> at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
> at java.lang.Thread.run(Thread.java:745)
> "brooklyn-execmanager-H7Adif6C-16":
> at 
> org.apache.brooklyn.core.entity.AbstractEntity$BasicSubscriptionSupport.getSubscriptionContext(AbstractEntity.java:1488)
> - waiting to lock <0x0007d34abc20> (a 
> org.apache.brooklyn.entity.webapp.ControlledDynamicWebAppClusterImpl)
> at 
> org.apache.brooklyn.core.entity.AbstractEntity$BasicSensorSupport.emitInternal(AbstractEntity.java:1164)
> at 
> org.apache.brooklyn.core.entity.AbstractEntity.emitInternal(AbstractEntity.java:2021)
> at 
> org.apache.brooklyn.core.sensor.AttributeMap.update(AttributeMap.java:133)
> at 
> org.apache.brooklyn.core.sensor.AttributeMap.modify(AttributeMap.java:162)
> - locked <0x0007d3504b60> (a 
> java.util.Collections$SynchronizedMap)
> at 
> org.apache.brooklyn.core.entity.AbstractEntity$BasicSensorSupport.modify(AbstractEntity.java:1106)
> at 
> org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogic.updateMapSensorEntry(ServiceStateLogic.java:150)
> at 
> org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogic.clearMapSensorEntry(ServiceStateLogic.java:102)
> at 
> org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogic$ComputeServiceIndicatorsFromChildrenAndMembers.updateMapSensor(ServiceStateLogic.java:558)
> at 
> org.apache.brooklyn.core.entity.lifecycle.ServiceStateLogic$ComputeServiceIndicatorsFromChildrenAndMembers.onUpdated(ServiceStateLogic.java:477)
> at 
> 

[jira] [Resolved] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread Aled Sage (JIRA)

 [ 
https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aled Sage resolved BROOKLYN-244.

   Resolution: Fixed
Fix Version/s: 0.9.0

> Blueprint Composer: text disappears after few seconds
> -
>
> Key: BROOKLYN-244
> URL: https://issues.apache.org/jira/browse/BROOKLYN-244
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
> Fix For: 0.9.0
>
>
> On Brooklyn 0.9.0-SNAPSHOT...
> When I open the Blueprint Composer and start typing (particularly if I've 
> pasted a blueprint), then sometimes a few seconds later the text all 
> disappears leaving me with a blank text area.
> I suspect (talking briefly to Thomas) that it could be refreshing after the 
> catalog has finished loading - the longer the catalog takes to be retrieved, 
> then the longer the delay before any text is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage
Thanks Mark for reviewing brooklyn-ui PR #24. That is now merged into 
master and cherry-picked into 0.9.0.
(I completely agree with Mark's comments in #24, which can be addressed 
in a future PR just in master).


---
I believe that Richard is discussing which Geoff about which 
brooklyn-client platform artifacts are required. Once that is agreed and 
sorted, then I think we are good to go.


Last chance before the RC: any more bugs that need addressed or PRs that 
you think need merged/cherry-picked?


Aled


On 06/04/2016 17:03, Aled Sage wrote:

Thanks Thomas.

I've cherry-picked PR #23.

---
The change in #24 looks sensible (without it, no-one would know that 
drag-and-drop of text-files is possible in the Blueprint Composer).


Can someone please review and comment on the PR, and let us know if 
you agree it's low-risk for including in 0.9.0.


Aled


On 06/04/2016 16:13, Thomas Bouron wrote:

I also have two candidates to include:
https://github.com/apache/brooklyn-ui/pull/23 and
https://github.com/apache/brooklyn-ui/pull/24

Thoughts?

On Wed, 6 Apr 2016 at 15:51 Geoff Macartney <
geoff.macart...@cloudsoftcorp.com> wrote:


Would it be worth including CLI Go vendoring -
https://github.com/apache/brooklyn-client/pull/16? <
https://github.com/apache/brooklyn-client/pull/16?> Simplifies the 
build

for the CLI (no need for extra tool apart from Go itself).



Gnu PGP key - http://is.gd/uI



On 6 Apr 2016, at 15:47, Aled Sage  wrote:

Hi all,

Svet: agree with brooklyn-client/pull/14 and brooklyn-client/pull/15.

I've cherry-picked those.

We have reviewed and incorporated the following fixes into master and

the 0.9.0 branch, ready for the next release candidate:

* BROOKLYN-249:
   https://github.com/apache/brooklyn-server/pull/103
* BROOKLYN-248:
   https://github.com/apache/brooklyn-server/pull/104
* BROOKLYN-246:
   https://github.com/apache/brooklyn-server/pull/102
* https://github.com/apache/brooklyn-client/pull/14
* https://github.com/apache/brooklyn-client/pull/15

Anything else that needs done before the next 0.9.0 release candidate?

Aled


On 06/04/2016 09:45, Svetoslav Neykov wrote:

+1 to include 102 & 103.

Also suggest including [1] - cuts down on the number of cli binaries
substantially and fixes the name on Windows. Shaves off close to 
20mb from

the release. [2] is minor but good to have (documents the go 1.6
requirement).

Svet.


[1] https://github.com/apache/brooklyn-client/pull/14 <

https://github.com/apache/brooklyn-client/pull/14>

[2] https://github.com/apache/brooklyn-client/pull/15 <

https://github.com/apache/brooklyn-client/pull/15>




On 5.04.2016 г., at 20:10, Aled Sage  wrote:

Thanks all.

John has fixed this [1]. I'll review, merge, and cherry-pick to the

0.9.0 branch.

Given we are producing another release candidate anyway, can we

include the fix for BROOKLYN-249 (see [2,3]). Can someone please review
that and give their opinion for whether it should be included in the 
0.9.0

release?

Aled

[1] https://github.com/apache/brooklyn-server/pull/102
[2] https://issues.apache.org/jira/browse/BROOKLYN-249
[3] https://github.com/apache/brooklyn-server/pull/103


On 05/04/2016 10:30, John McCabe wrote:

Note that it also breaks the add location wizard in jsgui.

On Tue, 5 Apr 2016 at 10:26 Richard Downer 

wrote:
After discussing with John, I agree that BROOKLYN-246 is a 
blocker.

The catalog file that the Brooklyn Vagrant distributable uses is

using

the broken format, so it won't work - and we really don't want our
simplest-possible-get-started to require manual modifications 
before
it'll work. It also breaks the documented way of using BYON[1] 
so we

are at high risk of breaking user's working configurations.

Therefore due to this critical bug, I am cancelling the vote.

Richard.

[1]

https://brooklyn.apache.org/v/latest/ops/locations/index.html#byon

On 4 April 2016 at 18:11, John McCabe  wrote:

@all, I hit an issue with location handling while following up on

@svets

comments - https://issues.apache.org/jira/browse/BROOKLYN-246

Looks like a blocker.

On Mon, 4 Apr 2016 at 14:35 John McCabe 

wrote:

@svet, latest isn't required, 1.8+ should suffice.

On Mon, 4 Apr 2016 at 12:53 Svetoslav Neykov <
svetoslav.ney...@cloudsoftcorp.com> wrote:


+1 binding

* Tested the .zip & .tar.gz dists
* Tested CLI
* Tried a simple blueprint
* Tested the vagrant artifact - "vagrant up" *fails* because 
it's

looking

at the release url

https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz 


<

https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz 


.

Once released should work.
Unrelated, but do we require the absolute latest vagrant

version on

purpose? Can we relax this version requirement?

Svet.



On 

[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-ui/pull/24


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/24#issuecomment-206444894
  
LGTM

**MINOR**
* Might be worth adding styling for dragover
* Might be worth verifying the type of the dropped file


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Geoff Macartney
That's fine by me.

cheers
Geoff



Gnu PGP key - http://is.gd/uI


> On 6 Apr 2016, at 16:58, Aled Sage  wrote:
> 
> Hi Geoff,
> 
> I think we should *not* include it in the 0.9.0 release. It improves the 
> build process, but does not change the final artifacts. I think for rc3 we 
> should stick to just cherry-picking bug fixes.
> 
> If anyone disagrees then please shout out.
> 
> Aled
> 
> 
> On 06/04/2016 15:50, Geoff Macartney wrote:
>> Would it be worth including CLI Go vendoring - 
>> https://github.com/apache/brooklyn-client/pull/16? 
>>   Simplifies the build 
>> for the CLI (no need for extra tool apart from Go itself).
>> 
>> 
>> 
>> Gnu PGP key - http://is.gd/uI
>> 
>> 
>>> On 6 Apr 2016, at 15:47, Aled Sage  wrote:
>>> 
>>> Hi all,
>>> 
>>> Svet: agree with brooklyn-client/pull/14 and brooklyn-client/pull/15. I've 
>>> cherry-picked those.
>>> 
>>> We have reviewed and incorporated the following fixes into master and the 
>>> 0.9.0 branch, ready for the next release candidate:
>>> 
>>> * BROOKLYN-249:
>>>   https://github.com/apache/brooklyn-server/pull/103
>>> * BROOKLYN-248:
>>>   https://github.com/apache/brooklyn-server/pull/104
>>> * BROOKLYN-246:
>>>   https://github.com/apache/brooklyn-server/pull/102
>>> * https://github.com/apache/brooklyn-client/pull/14
>>> * https://github.com/apache/brooklyn-client/pull/15
>>> 
>>> Anything else that needs done before the next 0.9.0 release candidate?
>>> 
>>> Aled
>>> 
>>> 
>>> On 06/04/2016 09:45, Svetoslav Neykov wrote:
 +1 to include 102 & 103.
 
 Also suggest including [1] - cuts down on the number of cli binaries 
 substantially and fixes the name on Windows. Shaves off close to 20mb from 
 the release. [2] is minor but good to have (documents the go 1.6 
 requirement).
 
 Svet.
 
 
 [1] https://github.com/apache/brooklyn-client/pull/14 
 
 [2] https://github.com/apache/brooklyn-client/pull/15 
 
 
 
 
> On 5.04.2016 г., at 20:10, Aled Sage  wrote:
> 
> Thanks all.
> 
> John has fixed this [1]. I'll review, merge, and cherry-pick to the 0.9.0 
> branch.
> 
> Given we are producing another release candidate anyway, can we include 
> the fix for BROOKLYN-249 (see [2,3]). Can someone please review that and 
> give their opinion for whether it should be included in the 0.9.0 release?
> 
> Aled
> 
> [1] https://github.com/apache/brooklyn-server/pull/102
> [2] https://issues.apache.org/jira/browse/BROOKLYN-249
> [3] https://github.com/apache/brooklyn-server/pull/103
> 
> 
> On 05/04/2016 10:30, John McCabe wrote:
>> Note that it also breaks the add location wizard in jsgui.
>> 
>> On Tue, 5 Apr 2016 at 10:26 Richard Downer  wrote:
>> 
>>> After discussing with John, I agree that BROOKLYN-246 is a blocker.
>>> The catalog file that the Brooklyn Vagrant distributable uses is using
>>> the broken format, so it won't work - and we really don't want our
>>> simplest-possible-get-started to require manual modifications before
>>> it'll work. It also breaks the documented way of using BYON[1] so we
>>> are at high risk of breaking user's working configurations.
>>> 
>>> Therefore due to this critical bug, I am cancelling the vote.
>>> 
>>> Richard.
>>> 
>>> [1]https://brooklyn.apache.org/v/latest/ops/locations/index.html#byon
>>> 
>>> On 4 April 2016 at 18:11, John McCabe  wrote:
 @all, I hit an issue with location handling while following up on 
 @svets
 comments - https://issues.apache.org/jira/browse/BROOKLYN-246
 
 Looks like a blocker.
 
 On Mon, 4 Apr 2016 at 14:35 John McCabe  wrote:
 
> @svet, latest isn't required, 1.8+ should suffice.
> 
> On Mon, 4 Apr 2016 at 12:53 Svetoslav Neykov <
> svetoslav.ney...@cloudsoftcorp.com> wrote:
> 
>> +1 binding
>> 
>> * Tested the .zip & .tar.gz dists
>> * Tested CLI
>> * Tried a simple blueprint
>> * Tested the vagrant artifact - "vagrant up" *fails* because it's
>>> looking
>> at the release url
>> 
>>> https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz
>> <
>> 
>>> https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz
 .
>> Once released should work.
>>Unrelated, but do we require the absolute latest vagrant version 

[GitHub] brooklyn-server pull request: Support removal of catalog entries f...

2016-04-06 Thread geomacy
Github user geomacy commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/100#discussion_r58729416
  
--- Diff: 
core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogBomScanner.java
 ---
@@ -100,54 +103,82 @@ public ManagementContext getManagementContext() {
 return managementContext;
 }
 
+/**
+ * Scans the bundle being added for a catalog.bom file and adds 
any entries in it to the catalog.
+ *
+ * @param bundle The bundle being added to the bundle context.
+ * @param bundleEvent The event of the addition.
+ *
+ * @return The items added to the catalog; these will be tracked 
by the {@link BundleTracker} mechanism
+ * and supplied to the {@link #removedBundle(Bundle, 
BundleEvent, Iterable)} method.
+ */
 @Override
-public Long addingBundle(Bundle bundle, BundleEvent bundleEvent) {
+public Iterable> addingBundle(Bundle 
bundle, BundleEvent bundleEvent) {
+return scanForCatalog(bundle);
+}
 
-final BundleContext bundleContext = 
FrameworkUtil.getBundle(CatalogBomScanner.class).getBundleContext();
-if (bundleContext == null) {
-LOG.info("Bundle context not yet established for bundle {} 
{} {}", bundleIds(bundle));
-return null;
-}
 
-scanForCatalog(bundle);
+@Override
+public void removedBundle(Bundle bundle, BundleEvent bundleEvent, 
Iterable> items) {
+if (!items.iterator().hasNext()) {
+return;
+}
+LOG.debug("Unloading catalog BOM entries from {} {} {}", 
bundleIds(bundle));
+List exceptions = MutableList.of();
+final BrooklynCatalog catalog = 
getManagementContext().getCatalog();
+for (CatalogItem item : items) {
+LOG.debug("Unloading {} {} from catalog", 
item.getSymbolicName(), item.getVersion());
+
+try {
+catalog.deleteCatalogItem(item.getSymbolicName(), 
item.getVersion());
+} catch (Exception e) {
+LOG.warn("Caught {} unloading {} {} from catalog", new 
String [] {
+e.getMessage(), item.getSymbolicName(), 
item.getVersion()
+});
+exceptions.add(e);
+}
+}
 
-return bundle.getBundleId();
+if (0 < exceptions.size()) {
+throw new CompoundRuntimeException(
--- End diff --

Hm, I guess I have been assuming that this will just result in a message 
being logged by Karaf as opposed to it causing a failure - I will have to test 
that out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request:

https://github.com/apache/brooklyn-client/pull/16#issuecomment-206434349
  
LGTM :: Warnings are gone :+1:


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-ui-master #9

2016-04-06 Thread Apache Jenkins Server
See 

Changes:

[thomas.bouron] BROOKLYN-244: Fix blueprint composer loading issue

[thomas.bouron] BROOKLYN-244: Add error handling if the applications' fetch 
fails

--
[...truncated 1072 lines...]
text!tpl/editor/page.html
text!tpl/editor/location-alert.html






text!tpl/apps/tree-item.html
text!tpl/apps/tree-empty.html

text!tpl/apps/summary.html


text!tpl/apps/config.html
text!tpl/apps/config-name.html





text!tpl/apps/sensors.html
text!tpl/apps/sensor-name.html



text!tpl/apps/effector-modal.html
text!tpl/apps/param.html
text!tpl/apps/param-list.html

text!tpl/apps/effector.html
text!tpl/apps/effector-row.html



text!tpl/apps/policy-parameter-config.html

text!tpl/apps/policy-new.html

text!tpl/apps/policy.html
text!tpl/apps/policy-row.html
text!tpl/apps/policy-config-row.html


text!tpl/apps/activity-details.html
text!tpl/apps/activity-table.html

text!tpl/apps/activities.html
text!tpl/apps/activity-row-details.html
text!tpl/apps/activity-row-details-main.html
text!tpl/apps/activity-full-details.html

text!tpl/apps/advanced.html
text!tpl/apps/change-name-modal.html

text!tpl/apps/add-child-modal.html



Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Thomas Bouron
I also have two candidates to include:
https://github.com/apache/brooklyn-ui/pull/23 and
https://github.com/apache/brooklyn-ui/pull/24

Thoughts?

On Wed, 6 Apr 2016 at 15:51 Geoff Macartney <
geoff.macart...@cloudsoftcorp.com> wrote:

> Would it be worth including CLI Go vendoring -
> https://github.com/apache/brooklyn-client/pull/16? <
> https://github.com/apache/brooklyn-client/pull/16?>  Simplifies the build
> for the CLI (no need for extra tool apart from Go itself).
>
>
> 
> Gnu PGP key - http://is.gd/uI
>
>
> > On 6 Apr 2016, at 15:47, Aled Sage  wrote:
> >
> > Hi all,
> >
> > Svet: agree with brooklyn-client/pull/14 and brooklyn-client/pull/15.
> I've cherry-picked those.
> >
> > We have reviewed and incorporated the following fixes into master and
> the 0.9.0 branch, ready for the next release candidate:
> >
> > * BROOKLYN-249:
> >   https://github.com/apache/brooklyn-server/pull/103
> > * BROOKLYN-248:
> >   https://github.com/apache/brooklyn-server/pull/104
> > * BROOKLYN-246:
> >   https://github.com/apache/brooklyn-server/pull/102
> > * https://github.com/apache/brooklyn-client/pull/14
> > * https://github.com/apache/brooklyn-client/pull/15
> >
> > Anything else that needs done before the next 0.9.0 release candidate?
> >
> > Aled
> >
> >
> > On 06/04/2016 09:45, Svetoslav Neykov wrote:
> >> +1 to include 102 & 103.
> >>
> >> Also suggest including [1] - cuts down on the number of cli binaries
> substantially and fixes the name on Windows. Shaves off close to 20mb from
> the release. [2] is minor but good to have (documents the go 1.6
> requirement).
> >>
> >> Svet.
> >>
> >>
> >> [1] https://github.com/apache/brooklyn-client/pull/14 <
> https://github.com/apache/brooklyn-client/pull/14>
> >> [2] https://github.com/apache/brooklyn-client/pull/15 <
> https://github.com/apache/brooklyn-client/pull/15>
> >>
> >>
> >>
> >>> On 5.04.2016 г., at 20:10, Aled Sage  wrote:
> >>>
> >>> Thanks all.
> >>>
> >>> John has fixed this [1]. I'll review, merge, and cherry-pick to the
> 0.9.0 branch.
> >>>
> >>> Given we are producing another release candidate anyway, can we
> include the fix for BROOKLYN-249 (see [2,3]). Can someone please review
> that and give their opinion for whether it should be included in the 0.9.0
> release?
> >>>
> >>> Aled
> >>>
> >>> [1] https://github.com/apache/brooklyn-server/pull/102
> >>> [2] https://issues.apache.org/jira/browse/BROOKLYN-249
> >>> [3] https://github.com/apache/brooklyn-server/pull/103
> >>>
> >>>
> >>> On 05/04/2016 10:30, John McCabe wrote:
>  Note that it also breaks the add location wizard in jsgui.
> 
>  On Tue, 5 Apr 2016 at 10:26 Richard Downer 
> wrote:
> 
> > After discussing with John, I agree that BROOKLYN-246 is a blocker.
> > The catalog file that the Brooklyn Vagrant distributable uses is
> using
> > the broken format, so it won't work - and we really don't want our
> > simplest-possible-get-started to require manual modifications before
> > it'll work. It also breaks the documented way of using BYON[1] so we
> > are at high risk of breaking user's working configurations.
> >
> > Therefore due to this critical bug, I am cancelling the vote.
> >
> > Richard.
> >
> > [1]
> https://brooklyn.apache.org/v/latest/ops/locations/index.html#byon
> >
> > On 4 April 2016 at 18:11, John McCabe  wrote:
> >> @all, I hit an issue with location handling while following up on
> @svets
> >> comments - https://issues.apache.org/jira/browse/BROOKLYN-246
> >>
> >> Looks like a blocker.
> >>
> >> On Mon, 4 Apr 2016 at 14:35 John McCabe 
> wrote:
> >>
> >>> @svet, latest isn't required, 1.8+ should suffice.
> >>>
> >>> On Mon, 4 Apr 2016 at 12:53 Svetoslav Neykov <
> >>> svetoslav.ney...@cloudsoftcorp.com> wrote:
> >>>
>  +1 binding
> 
>  * Tested the .zip & .tar.gz dists
>  * Tested CLI
>  * Tried a simple blueprint
>  * Tested the vagrant artifact - "vagrant up" *fails* because it's
> > looking
>  at the release url
> 
> >
> https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz
>  <
> 
> >
> https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz
> >> .
>  Once released should work.
> Unrelated, but do we require the absolute latest vagrant
> version on
>  purpose? Can we relax this version requirement?
> 
>  Svet.
> 
> 
> > On 4.04.2016 г., at 13:14, Sam Corbett <
> > sam.corb...@cloudsoftcorp.com>
>  wrote:
> > +1 binding
> >
> > I have:
> > * Verified release signatures
> > * Built from 

[jira] [Commented] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228438#comment-15228438
 ] 

ASF GitHub Bot commented on BROOKLYN-244:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-ui/pull/23


> Blueprint Composer: text disappears after few seconds
> -
>
> Key: BROOKLYN-244
> URL: https://issues.apache.org/jira/browse/BROOKLYN-244
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> On Brooklyn 0.9.0-SNAPSHOT...
> When I open the Blueprint Composer and start typing (particularly if I've 
> pasted a blueprint), then sometimes a few seconds later the text all 
> disappears leaving me with a blank text area.
> I suspect (talking briefly to Thomas) that it could be refreshing after the 
> catalog has finished loading - the longer the catalog takes to be retrieved, 
> then the longer the delay before any text is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206420422
  
@aledsage +1 to including in the 0.9.0 release


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-client/pull/16


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread neykov
Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-client/pull/16#issuecomment-206419694
  
Looks good and builds cleanly. Even the warning is gone now. Merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread tbouron
Github user tbouron commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419817
  
Great, thank @aledsage!

If it gets into 0.9.0, you might also want #24 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228429#comment-15228429
 ] 

ASF GitHub Bot commented on BROOKLYN-244:
-

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419417
  
Thanks @tbouron and @m4rkmckenna 

Merging now. Sounds like something to get into the next 0.9.0 release 
candidate.


> Blueprint Composer: text disappears after few seconds
> -
>
> Key: BROOKLYN-244
> URL: https://issues.apache.org/jira/browse/BROOKLYN-244
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> On Brooklyn 0.9.0-SNAPSHOT...
> When I open the Blueprint Composer and start typing (particularly if I've 
> pasted a blueprint), then sometimes a few seconds later the text all 
> disappears leaving me with a blank text area.
> I suspect (talking briefly to Thomas) that it could be refreshing after the 
> catalog has finished loading - the longer the catalog takes to be retrieved, 
> then the longer the delay before any text is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206419417
  
Thanks @tbouron and @m4rkmckenna 

Merging now. Sounds like something to get into the next 0.9.0 release 
candidate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: Update editor placeholder

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request:

https://github.com/apache/brooklyn-ui/pull/24

Update editor placeholder

The text now makes it clear that users can use drag & drop to add text 
files' content into the editor

![brooklyn js rest 
client](https://cloud.githubusercontent.com/assets/2082759/14321019/5cc569c2-fc0f-11e5-9205-3d819f90e002.png)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tbouron/brooklyn-ui feature/drag-and-drop

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-ui/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #24


commit fc4e814a99925966c5b85e92d8d821176b64c36b
Author: Thomas Bouron 
Date:   2016-04-06T14:49:40Z

Update placeholder text to make clear that users can use drag & drop to add 
text files' content into the editor




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: [CANCEL][VOTE] Release Apache Brooklyn 0.9.0 [rc2]

2016-04-06 Thread Aled Sage

Hi all,

Svet: agree with brooklyn-client/pull/14 and brooklyn-client/pull/15. 
I've cherry-picked those.


We have reviewed and incorporated the following fixes into master and 
the 0.9.0 branch, ready for the next release candidate:


 * BROOKLYN-249:
   https://github.com/apache/brooklyn-server/pull/103
 * BROOKLYN-248:
   https://github.com/apache/brooklyn-server/pull/104
 * BROOKLYN-246:
   https://github.com/apache/brooklyn-server/pull/102
 * https://github.com/apache/brooklyn-client/pull/14
 * https://github.com/apache/brooklyn-client/pull/15

Anything else that needs done before the next 0.9.0 release candidate?

Aled


On 06/04/2016 09:45, Svetoslav Neykov wrote:

+1 to include 102 & 103.

Also suggest including [1] - cuts down on the number of cli binaries 
substantially and fixes the name on Windows. Shaves off close to 20mb from the 
release. [2] is minor but good to have (documents the go 1.6 requirement).

Svet.


[1] https://github.com/apache/brooklyn-client/pull/14 

[2] https://github.com/apache/brooklyn-client/pull/15 





On 5.04.2016 г., at 20:10, Aled Sage  wrote:

Thanks all.

John has fixed this [1]. I'll review, merge, and cherry-pick to the 0.9.0 
branch.

Given we are producing another release candidate anyway, can we include the fix 
for BROOKLYN-249 (see [2,3]). Can someone please review that and give their 
opinion for whether it should be included in the 0.9.0 release?

Aled

[1] https://github.com/apache/brooklyn-server/pull/102
[2] https://issues.apache.org/jira/browse/BROOKLYN-249
[3] https://github.com/apache/brooklyn-server/pull/103


On 05/04/2016 10:30, John McCabe wrote:

Note that it also breaks the add location wizard in jsgui.

On Tue, 5 Apr 2016 at 10:26 Richard Downer  wrote:


After discussing with John, I agree that BROOKLYN-246 is a blocker.
The catalog file that the Brooklyn Vagrant distributable uses is using
the broken format, so it won't work - and we really don't want our
simplest-possible-get-started to require manual modifications before
it'll work. It also breaks the documented way of using BYON[1] so we
are at high risk of breaking user's working configurations.

Therefore due to this critical bug, I am cancelling the vote.

Richard.

[1]https://brooklyn.apache.org/v/latest/ops/locations/index.html#byon

On 4 April 2016 at 18:11, John McCabe  wrote:

@all, I hit an issue with location handling while following up on @svets
comments - https://issues.apache.org/jira/browse/BROOKLYN-246

Looks like a blocker.

On Mon, 4 Apr 2016 at 14:35 John McCabe  wrote:


@svet, latest isn't required, 1.8+ should suffice.

On Mon, 4 Apr 2016 at 12:53 Svetoslav Neykov <
svetoslav.ney...@cloudsoftcorp.com> wrote:


+1 binding

* Tested the .zip & .tar.gz dists
* Tested CLI
* Tried a simple blueprint
* Tested the vagrant artifact - "vagrant up" *fails* because it's

looking

at the release url


https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz

<


https://www.apache.org/dyn/closer.lua?action=download=brooklyn/apache-brooklyn-0.9.0/apache-brooklyn-0.9.0-bin.tar.gz

.

Once released should work.
Unrelated, but do we require the absolute latest vagrant version on
purpose? Can we relax this version requirement?

Svet.



On 4.04.2016 г., at 13:14, Sam Corbett <

sam.corb...@cloudsoftcorp.com>

wrote:

+1 binding

I have:
* Verified release signatures
* Built from the source archive
* Generated a project from the archetype
* Verified all subsequent archetype instructions were correct
* Verified a simple application deployed to AWS.
* Given the CLI a work out.


On 01/04/2016 16:58, Richard Downer wrote:

This is to call for a vote for the release of Apache Brooklyn 0.9.0

[rc2].

This release comprises of a source code distribution, and a
corresponding binary distribution, RPM packages, Vagrant environment
package, and Maven artifacts.

The source and binary distributions, including signatures, digests,
etc. can be found at:


https://dist.apache.org/repos/dist/dev/brooklyn/apache-brooklyn-0.9.0-rc2

The artifact SHA-256 checksums are as follows:
426ca93aad28ac8281b2015fc0ea419cd6db19c3ed87ffd11910a6baf2e9e3ab
*apache-brooklyn-0.9.0-rc2-1.noarch.rpm
b2a65642fb86198b9fd9992ef3464025d9b41c453c4dd5366699d569a65709c6
*apache-brooklyn-0.9.0-rc2-bin.tar.gz
999fd6f1d21417278ffe153fc1f0346d44235dfbbd39f200815f61cea82edbe5
*apache-brooklyn-0.9.0-rc2-bin.zip
00e0a76775775957e92498d0b5ea3e13f844155eda3251a8ead05cf4b4a4455b
*apache-brooklyn-0.9.0-rc2-src.tar.gz
c7a9a286993b1d520ae6a32e25c0dd3bef7227290d59347256bd96480b70a02b
*apache-brooklyn-0.9.0-rc2-src.zip
907267c5d2e7c1622e11f2bc57b6afe12ddf2136d82bad63661e43570aaa78fa
*apache-brooklyn-0.9.0-rc2-vagrant.tar.gz
0ae8384426d6b7197ca3d194c1e8032b85c5bb80671157c274487220d3ba65e9

[GitHub] brooklyn-dist pull request: Add Debian packaning

2016-04-06 Thread neykov
Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-dist/pull/28#issuecomment-206402275
  
Looks good, apart from some minor comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228327#comment-15228327
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/104


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread neykov
Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395613
  
thanks @johnmccabe, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228324#comment-15228324
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395613
  
thanks @johnmccabe, merging.


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-dist pull request: Add Debian packaning

2016-04-06 Thread neykov
Github user neykov commented on a diff in the pull request:

https://github.com/apache/brooklyn-dist/pull/28#discussion_r58713891
  
--- Diff: deb-packaging/src/deb/control/control ---
@@ -0,0 +1,25 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+# 
+#  http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+Package: apache-brooklyn
+Version: [[version]]
+Section: misc
+Priority: optional
+Architecture: all
+Depends: jdk (>= 1.5)
--- End diff --

Brooklyn requires 7+


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228323#comment-15228323
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395204
  
LGTM :+1: 


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228322#comment-15228322
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395066
  
@aledsage looks like something messed up my side... it works as expected 
now.

Previously I was deleting then pulling the pr into a branch on 
brooklyn-server, doing a `mvn clean install` both there and brooklyn-dist.

This time I deleting the pr branch and pulled it again, and instead built 
from the uber brooklyn project.

Sorry for the false alarm.


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395204
  
LGTM :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206395066
  
@aledsage looks like something messed up my side... it works as expected 
now.

Previously I was deleting then pulling the pr into a branch on 
brooklyn-server, doing a `mvn clean install` both there and brooklyn-dist.

This time I deleting the pr branch and pulled it again, and instead built 
from the uber brooklyn project.

Sorry for the false alarm.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206390410
  
@aledsage I've deleted my PR branch and am rebuilding again (I'd rebuilt 
earlier to sanity check my observations... third time lucky)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228304#comment-15228304
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206390410
  
@aledsage I've deleted my PR branch and am rebuilding again (I'd rebuilt 
earlier to sanity check my observations... third time lucky)


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206389822
  
@johnmccabe your example works for me when I build and run brooklyn 
locally. I don't have any files not committed or anything like that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228302#comment-15228302
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206389822
  
@johnmccabe your example works for me when I build and run brooklyn 
locally. I don't have any files not committed or anything like that.


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228252#comment-15228252
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206377038
  
oops, just saw @johnmccabe's comment. Can you retest as this was updated 
minutes ago as well. Tests suggest your case should be working.


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-244) Blueprint Composer: text disappears after few seconds

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228246#comment-15228246
 ] 

ASF GitHub Bot commented on BROOKLYN-244:
-

Github user m4rkmckenna commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206376464
  
LGTM

Tested with a simulated 50 kb/s connection ... worked as expected


> Blueprint Composer: text disappears after few seconds
> -
>
> Key: BROOKLYN-244
> URL: https://issues.apache.org/jira/browse/BROOKLYN-244
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> On Brooklyn 0.9.0-SNAPSHOT...
> When I open the Blueprint Composer and start typing (particularly if I've 
> pasted a blueprint), then sometimes a few seconds later the text all 
> disappears leaving me with a blank text area.
> I suspect (talking briefly to Thomas) that it could be refreshing after the 
> catalog has finished loading - the longer the catalog takes to be retrieved, 
> then the longer the delay before any text is lost.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228247#comment-15228247
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206376601
  
LGTM, merging.


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread neykov
Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206376601
  
LGTM, merging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread m4rkmckenna
Github user m4rkmckenna commented on the pull request:

https://github.com/apache/brooklyn-ui/pull/23#issuecomment-206376464
  
LGTM

Tested with a simulated 50 kb/s connection ... worked as expected


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228240#comment-15228240
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206374347
  
I pulled and built a few minutes ago and tried with this catalog:
```
brooklyn.catalog:
  version: 0.1.2
  items:
  - id: loc-common-base
name: Base Location
itemType: location
item:
  type: localhost
  brooklyn.config:
privateKeyFile: some common private key file
privateKeyPassphrase: password
  - id: loc-based-on-common-base
name: Derived Location
itemType: location
item:
  type: loc-common-base
  brooklyn.config:
user: user-who-inherits-private-key-values
password: password
```
And I still see both locations `loc-common-base` and `loc-common-base` 
display with the name `Base Location`

I also tried adding `displayName:  Location` to each in 
`brooklyn.config` but see the same behaviour.

On a slight tangent, building up locations from other locations lends 
itself to adding base locations that aren't useable by themselves, for example 
a base that only sets common private keys - currently those building-block locs 
show up in the list of locations via the jsgui - it'd be nice to have some way 
of flagging whether a location gets presented to a user in the UI - either a 
param or naming convention. Worth considering as a future enhancement?


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread johnmccabe
Github user johnmccabe commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206374347
  
I pulled and built a few minutes ago and tried with this catalog:
```
brooklyn.catalog:
  version: 0.1.2
  items:
  - id: loc-common-base
name: Base Location
itemType: location
item:
  type: localhost
  brooklyn.config:
privateKeyFile: some common private key file
privateKeyPassphrase: password
  - id: loc-based-on-common-base
name: Derived Location
itemType: location
item:
  type: loc-common-base
  brooklyn.config:
user: user-who-inherits-private-key-values
password: password
```
And I still see both locations `loc-common-base` and `loc-common-base` 
display with the name `Base Location`

I also tried adding `displayName:  Location` to each in 
`brooklyn.config` but see the same behaviour.

On a slight tangent, building up locations from other locations lends 
itself to adding base locations that aren't useable by themselves, for example 
a base that only sets common private keys - currently those building-block locs 
show up in the list of locations via the jsgui - it'd be nice to have some way 
of flagging whether a location gets presented to a user in the UI - either a 
param or naming convention. Worth considering as a future enhancement?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-docs pull request: Cli doc updates

2016-04-06 Thread geomacy
Github user geomacy commented on a diff in the pull request:

https://github.com/apache/brooklyn-docs/pull/25#discussion_r58702996
  
--- Diff: guide/ops/cli/index.md ---
@@ -6,7 +6,25 @@ children:
 - cli-usage-guide.md
 ---
 
-{% include list-children.html %}
 
-**NOTE:** These documents are for using the Brooklyn Client CLI to access 
a running Brooklyn Server.  For 
+**NOTE:** These documents are for using the Brooklyn Client CLI tool to 
access a running Brooklyn Server.  For
 information on starting on a Brooklyn Server, refer to [Server CLI 
Reference](../server-cli-reference.html).
+
+## Obtaining the CLI tool
+
+The CLI tool, `br`,  is included in the Apache Brooklyn distribution, in 
bin/brooklyn-client-cli-0.9.0-SNAPSHOT.
+The tool is an executable binary (written in Go), and is distributed in a 
number of builds for a variety of platforms
+and architectures, each build in its own subdirectory:
+
+darwin.386freebsd.386linux.386netbsd.386 openbsd.386   
 windows.386
+darwin.amd64  freebsd.amd64  linux.amd64  netbsd.amd64   openbsd.amd64 
 windows.amd64
--- End diff --

Updated build to just create the 32 bit versions of linux/windows, and the 
(64 bit) Mac:

https://github.com/apache/brooklyn-client/pull/14

(Just 32 bit for linux/windows as it keeps releases smaller, the 32 bit 
version should be fine for each.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228221#comment-15228221
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206365759
  
Good to review and merge now (assuming jenkins doesn't find any problems).


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206365759
  
Good to review and merge now (assuming jenkins doesn't find any problems).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-client pull request: Use Go 1.6 vendoring instead of Gode...

2016-04-06 Thread geomacy
GitHub user geomacy opened a pull request:

https://github.com/apache/brooklyn-client/pull/16

Use Go 1.6 vendoring instead of Godep.

Uses current version of dependencies, just moving them to the vendor 
directory.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/geomacy/brooklyn-client vendoring

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-client/pull/16.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #16


commit 3fa12d48772eb3d86825e12b44d10806adb1c37c
Author: Geoff Macartney 
Date:   2016-04-06T13:03:18Z

Use Go 1.6 vendoring instead of Godep.

Uses current version of dependencies, just moving them to the vendor 
directory.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228216#comment-15228216
 ] 

Aled Sage commented on BROOKLYN-248:


For the short/medium term fix, I've put in location-specific behaviour to fix 
this issue. I've added more thorough test cases, marking two as "WIP" in 
{{ApplicationYamlTest}}.

The behaviour shown in {{CatalogYamlLocationTest.testNamePrecedence()}} also 
needs further thought and attention. Do we just tell people to not define the 
name in multiple places (which would seem reasonable)? Or do we try to support 
this so that it always respects the most specific value (which is what happens 
for entities currently)?

> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228159#comment-15228159
 ] 

Aled Sage commented on BROOKLYN-248:


Edited my original code snippet to remove the duplicate {{itemType: location}}.

> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228068#comment-15228068
 ] 

Aled Sage edited comment on BROOKLYN-248 at 4/6/16 12:05 PM:
-

I've been looking into this and written a unit test.

The problem is at {{CampResolver.createSpecFromFull}}. At the end of that 
method, it only sets the spec's displayName to the name defined in the catalog 
metadata if the spec does not already have a name. For {{test-location-2}} in 
the example, it already has a displayName because it has inherited all the 
config etc from {{test-location-1}}.

We could change this code to always set the display name:

{noformat}
if (Strings.isNonBlank(item.getDisplayName())) {
((AbstractBrooklynObjectSpec)spec).displayName(item.getDisplayName());
}
{noformat}

It's not clear whether we should simply override the value. The problem then 
would be the name defined in the catalog would override a name defined in the 
item.

I tried the test case below, but with the original and the proposed new code, 
it always gave the name "My name in items" rather than "My name in item". Not 
sure what we want to do about that.

{noformat}
brooklyn.catalog:
  version: 0.1.2
  itemType: location
  name: My name in top-level
  items:
  - id: loc1
name: My name in items
item:
  type: localhost
  name: My name in item
{noformat}


was (Author: aled.sage):
I've been looking into this and written a unit test.

The problem is at {{CampResolver.createSpecFromFull}}. At the end of that 
method, it only sets the spec's displayName to the name defined in the catalog 
metadata if the spec does not already have a name. For {{test-location-2}} in 
the example, it already has a displayName because it has inherited all the 
config etc from {{test-location-1}}.

We could change this code to always set the display name:

{noformat}
if (Strings.isNonBlank(item.getDisplayName())) {
((AbstractBrooklynObjectSpec)spec).displayName(item.getDisplayName());
}
{noformat}

It's not clear whether we should simply override the value. The problem then 
would be the name defined in the catalog would override a name defined in the 
item.

I tried the test case below, but with the original and the proposed new code, 
it always gave the name "My name in items" rather than "My name in item". Not 
sure what we want to do about that.

{noformat}
brooklyn.catalog:
  version: 0.1.2
  itemType: location
  name: My name in top-level
  items:
  - id: loc1
name: My name in items
itemType: location
item:
  type: localhost
  name: My name in item
{noformat}

> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: brooklyn-master-windows #54

2016-04-06 Thread Apache Jenkins Server
See 

--
[...truncated 19639 lines...]
2016-04-06 12:53:49,674 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.core.location.geo.HostGeoInfoTest.testCustomLocationChildCoordinates()
2016-04-06 12:53:49,675 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.core.location.geo.HostGeoInfoTest.testCustomLocationChildCoordinates()
 finished in 1 ms
2016-04-06 12:53:49,874 INFO  TESTNG 
===
Surefire test
Tests run: 1668, Failures: 1, Skips: 1
===
2016-04-06 12:53:49,874 INFO  BrooklynLeakListener.onFinish attempting to 
terminate all extant ManagementContexts: name=Surefire test; includedGroups=[]; 
excludedGroups=[Integration, Live-sanity, Acceptance, Live, Broken, WIP]; 
suiteName=Surefire suite; 
outDir=F:\hudson\hudson-slave\workspace\brooklyn-master-windows\brooklyn-server\core\target\surefire-reports\Surefire
 suite: no org.apache.brooklyn.core.management.internal.LocalManagementContext 
available, so skipped
SUREFIRE-859: [GC 532726K->287214K(778048K), 0.0227417 secs]
2016-04-06 12:53:50,848 WARN  Task 
Task[LSM.publish(Application[huVlSpby].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=I3MkSDwz} @ 
1459943629396);[subscription-delivery-entity-huVlSpby[Application[huVlSpby@o1OAkDFO
 is being finalized before completion
2016-04-06 12:53:50,851 WARN  Task 
Task[LSM.publish(Application[huVlSpby].Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1459943629396 / Wed Apr 06 12:53:49 BST 2016 @ 
1459943629396);[subscription-delivery-entity-huVlSpby[Application[huVlSpby@pW0n8JvX
 is being finalized before completion
2016-04-06 12:53:50,851 WARN  Task 
Task[LSM.publish(Application[bL3rDtld].Sensor: service.state.expected 
(org.apache.brooklyn.core.entity.lifecycle.Lifecycle$Transition)=stopped @ 
1459943629557 / Wed Apr 06 12:53:49 BST 2016 @ 
1459943629557);[subscription-delivery-entity-bL3rDtld[Application[bL3rDtld@bLMHFQIQ
 is being finalized before completion
2016-04-06 12:53:50,851 WARN  Task 
Task[LSM.publish(Application[bL3rDtld].Sensor: entity.children.removed 
(org.apache.brooklyn.api.entity.Entity)=TestEntityImpl{id=REUbxA7Z} @ 
1459943629557);[subscription-delivery-entity-bL3rDtld[Application[bL3rDtld@Mkffxtki
 is being finalized before completion
SUREFIRE-859: [GC 531788K->288136K(778112K), 0.0222190 secs]
Tests run: 1668, Failures: 1, Errors: 0, Skipped: 1, Time elapsed: 210.444 sec 
<<< FAILURE! - in TestSuite
testFeedContinuesWhenPollerThrows(org.apache.brooklyn.core.feed.PollerTest)  
Time elapsed: 0.273 sec  <<< FAILURE!
org.apache.brooklyn.util.exceptions.PropagatedRuntimeException: failed 
succeeds-eventually, 8 attempts, 104ms elapsed: AssertionError: 
entity=FeedExceptionEntityImpl{id=rsSgapFf}; attribute=Sensor: flag 
(java.lang.Boolean) expected [true] but found [false]
at org.apache.brooklyn.test.Asserts.fail(Asserts.java:721)
at org.apache.brooklyn.test.Asserts.failNotEquals(Asserts.java:114)
at org.apache.brooklyn.test.Asserts.assertEquals(Asserts.java:436)
at 
org.apache.brooklyn.core.entity.EntityAsserts.assertAttributeEquals(EntityAsserts.java:54)
at 
org.apache.brooklyn.core.entity.EntityAsserts$1.run(EntityAsserts.java:70)
at 
org.apache.brooklyn.test.Asserts$RunnableAdapter.call(Asserts.java:1277)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:930)
at org.apache.brooklyn.test.Asserts.succeedsEventually(Asserts.java:854)
at 
org.apache.brooklyn.core.entity.EntityAsserts.assertAttributeEqualsEventually(EntityAsserts.java:67)
at 
org.apache.brooklyn.core.feed.PollerTest.testFeedContinuesWhenPollerThrows(PollerTest.java:69)

2016-04-06 12:53:52,810 INFO  Brooklyn shutdown: stopping entities 
[TestEntityImpl{id=B7HuJ45x}, TestEntityImpl{id=f235OAGd}, 
BlockingEntityImpl{id=NsmlMzXs}]

Results :

Failed tests: 
org.apache.brooklyn.core.feed.PollerTest.testFeedContinuesWhenPollerThrows(org.apache.brooklyn.core.feed.PollerTest)
  Run 1: PASS
  Run 2: PollerTest.testFeedContinuesWhenPollerThrows:69 » PropagatedRuntime 
failed suc...


Tests run: 1667, Failures: 1, Errors: 0, Skipped: 1

[JENKINS] Recording test results
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 49.314 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.266 s]
[INFO] Brooklyn Parent Project  SUCCESS [  3.845 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  6.218 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  1.140 s]
[INFO] Brooklyn Common Utilities 

[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread John McCabe (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228150#comment-15228150
 ] 

John McCabe commented on BROOKLYN-248:
--

How would it be used for a real location use case? I'd have expected to see the 
name defined only at the {code} name: My name in items{code} level, also having 
the top level {code}itemType: location{code} sees odd in conjunction with the 
items (where it makes sense).

> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228146#comment-15228146
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206331907
  
STILL DO NOT MERGE. I've added more test cases, and reverted the change to 
`CampResolver`, because that broke things for entities. But the new tests for a 
app catalog type extending an existing catalog type fail (and same for 
locations): it uses the name from the super-type.


> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206331907
  
STILL DO NOT MERGE. I've added more test cases, and reverted the change to 
`CampResolver`, because that broke things for entities. But the new tests for a 
app catalog type extending an existing catalog type fail (and same for 
locations): it uses the name from the super-type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/104#issuecomment-206318007
  
DO NOT MERGE: although this fixes it for the location test case, it breaks 
the expected behaviour for locations (see failing jenkins test).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-ui pull request: BROOKLYN-244: Fix blueprint composer loa...

2016-04-06 Thread tbouron
GitHub user tbouron opened a pull request:

https://github.com/apache/brooklyn-ui/pull/23

BROOKLYN-244: Fix blueprint composer loading issue

This load straight away CodeMirror when launching the composer for the 
composer tab, removing the requirement on loading the full list of applications 
contained within the catalog.

When coming from the catalog (editing a catalog item YAML), it will 
temporarily disable the editor, add an overlay displaying `Loading item...` 
until the item is full loaded from the REST server and added to the editor. At 
that point, the overlay will fade out and the editor enable again.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tbouron/brooklyn-ui fix/brooklyn-244

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-ui/pull/23.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #23


commit 38e89a53f9335994cff9293b57d5164c380f1d6e
Author: Thomas Bouron 
Date:   2016-04-06T11:01:32Z

BROOKLYN-244: Fix blueprint composer loading issue




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228072#comment-15228072
 ] 

ASF GitHub Bot commented on BROOKLYN-249:
-

Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/103#discussion_r58682355
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java
 ---
@@ -0,0 +1,139 @@
+package org.apache.brooklyn.camp.brooklyn;
--- End diff --

I'll just push a fix to master.


> errors using external config for JcloudsLocation
> 
>
> Key: BROOKLYN-249
> URL: https://issues.apache.org/jira/browse/BROOKLYN-249
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using 
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and 
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included 
> the external config in the location (it tried to coerce the 
> {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/103#discussion_r58682355
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java
 ---
@@ -0,0 +1,139 @@
+package org.apache.brooklyn.camp.brooklyn;
--- End diff --

I'll just push a fix to master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Build failed in Jenkins: brooklyn-master-windows #53

2016-04-06 Thread Apache Jenkins Server
See 

--
[...truncated 33779 lines...]
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.plxarc
[INFO] Exclude: 
**/src/test/resources/org/apache/brooklyn/entity/software/base/template_with_extra_substitutions.txt
[INFO] Exclude: **/src/main/resources/banner.txt
[INFO] Exclude: **/src/test/resources/ssl/certs/localhost/info.txt
[INFO] Exclude: **/src/main/history/dependencies.xml
[INFO] Exclude: **/sandbox/examples/src/main/scripts/amis.txt
[INFO] Exclude: docs/**
[INFO] 148 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 1 unknown: 1 generated: 0 
approved: 147 licence.
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn REST JavaScript Web GUI ... SUCCESS [ 42.559 s]
[INFO] Brooklyn Server Root ... SUCCESS [  0.248 s]
[INFO] Brooklyn Parent Project  SUCCESS [  4.416 s]
[INFO] Brooklyn Test Support Utilities  SUCCESS [  6.387 s]
[INFO] Brooklyn Logback Includable Configuration .. SUCCESS [  1.456 s]
[INFO] Brooklyn Common Utilities .. SUCCESS [ 25.694 s]
[INFO] Brooklyn API ... SUCCESS [  3.713 s]
[INFO] CAMP Server Parent Project . SUCCESS [  0.645 s]
[INFO] CAMP Base .. SUCCESS [  3.851 s]
[INFO] Brooklyn Test Support .. SUCCESS [  2.415 s]
[INFO] Brooklyn REST Swagger Apidoc Utilities . SUCCESS [  2.562 s]
[INFO] Brooklyn Logback Configuration . SUCCESS [  0.893 s]
[INFO] CAMP Server  SUCCESS [  8.304 s]
[INFO] CAMP Server Jersey . SUCCESS [ 10.879 s]
[INFO] Brooklyn Felix Runtime . SUCCESS [  4.217 s]
[INFO] Brooklyn Groovy Utilities .. SUCCESS [  1.367 s]
[INFO] Brooklyn Core .. SUCCESS [04:21 min]
[INFO] Brooklyn Policies .. SUCCESS [01:22 min]
[INFO] Brooklyn WinRM Software Entities ... SUCCESS [  9.445 s]
[INFO] Brooklyn Secure JMXMP Agent  SUCCESS [ 12.085 s]
[INFO] Brooklyn JMX RMI Agent . SUCCESS [  0.923 s]
[INFO] Brooklyn Jclouds Location Targets .. SUCCESS [ 24.109 s]
[INFO] Brooklyn Software Base . SUCCESS [01:20 min]
[INFO] Brooklyn CAMP REST API . FAILURE [05:10 min]
[INFO] Brooklyn Hazelcast Storage . SKIPPED
[INFO] Brooklyn Launcher Common ... SKIPPED
[INFO] Brooklyn REST API .. SKIPPED
[INFO] Brooklyn REST Resources  SKIPPED
[INFO] Brooklyn REST Server ... SKIPPED
[INFO] Brooklyn Launcher .. SKIPPED
[INFO] Brooklyn Command Line Interface  SKIPPED
[INFO] Brooklyn REST Client ... SKIPPED
[INFO] Brooklyn REST Server with Jersey dependencies .. SKIPPED
[INFO] Brooklyn Test Framework  SKIPPED
[INFO] Brooklyn OSGi init . SKIPPED
[INFO] Brooklyn Karaf . SKIPPED
[INFO] Jetty config fragment .. SKIPPED
[INFO] Brooklyn Karaf Features  SKIPPED
[INFO] Brooklyn Karaf Distro .. SKIPPED
[INFO] Brooklyn Karaf Shell Commands .. SKIPPED
[INFO] Brooklyn Karaf pax-exam itest .. SKIPPED
[INFO] Brooklyn Library Root .. SKIPPED
[INFO] Brooklyn CM SaltStack .. SKIPPED
[INFO] Brooklyn CM Ansible  SKIPPED
[INFO] Brooklyn CM Integration Root ... SKIPPED
[INFO] Brooklyn Network Software Entities . SKIPPED
[INFO] Brooklyn OSGi Software Entities  SKIPPED
[INFO] Brooklyn Database Software Entities  SKIPPED
[INFO] Brooklyn Web App Software Entities . SKIPPED
[INFO] Brooklyn Messaging Software Entities ... SKIPPED
[INFO] Brooklyn NoSQL Data Store Software Entities  SKIPPED
[INFO] Brooklyn Monitoring Software Entities .. SKIPPED
[INFO] Brooklyn QA  SKIPPED
[INFO] Brooklyn Examples Aggregator Project ... SKIPPED
[INFO] Brooklyn Examples Aggregator Project - Webapps . SKIPPED
[INFO] hello-world-webapp Maven Webapp  SKIPPED
[INFO] hello-world-sql-webapp Maven Webapp  SKIPPED

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228071#comment-15228071
 ] 

ASF GitHub Bot commented on BROOKLYN-249:
-

Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/103#discussion_r58681822
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java
 ---
@@ -0,0 +1,139 @@
+package org.apache.brooklyn.camp.brooklyn;
--- End diff --

This is missing the ASF license header.


> errors using external config for JcloudsLocation
> 
>
> Key: BROOKLYN-249
> URL: https://issues.apache.org/jira/browse/BROOKLYN-249
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using 
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and 
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included 
> the external config in the location (it tried to coerce the 
> {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread sjcorbett
Github user sjcorbett commented on a diff in the pull request:

https://github.com/apache/brooklyn-server/pull/103#discussion_r58681822
  
--- Diff: 
camp/camp-brooklyn/src/test/java/org/apache/brooklyn/camp/brooklyn/JcloudsRebindWithExternalConfigTest.java
 ---
@@ -0,0 +1,139 @@
+package org.apache.brooklyn.camp.brooklyn;
--- End diff --

This is missing the ASF license header.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228070#comment-15228070
 ] 

ASF GitHub Bot commented on BROOKLYN-248:
-

GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/104

BROOKLYN-248: fix location displayName inheritance



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server fix/BROOKLYN-248

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit fd64e22599ba3ed6e18d1d07118563c8d20631af
Author: Aled Sage 
Date:   2016-04-06T10:09:45Z

BROOKLYN-248: fix location displayName inheritance




> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: BROOKLYN-248: fix location displayNa...

2016-04-06 Thread aledsage
GitHub user aledsage opened a pull request:

https://github.com/apache/brooklyn-server/pull/104

BROOKLYN-248: fix location displayName inheritance



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/aledsage/brooklyn-server fix/BROOKLYN-248

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/brooklyn-server/pull/104.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #104


commit fd64e22599ba3ed6e18d1d07118563c8d20631af
Author: Aled Sage 
Date:   2016-04-06T10:09:45Z

BROOKLYN-248: fix location displayName inheritance




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-248) Incorrect name in derived locations

2016-04-06 Thread Aled Sage (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228068#comment-15228068
 ] 

Aled Sage commented on BROOKLYN-248:


I've been looking into this and written a unit test.

The problem is at {{CampResolver.createSpecFromFull}}. At the end of that 
method, it only sets the spec's displayName to the name defined in the catalog 
metadata if the spec does not already have a name. For {{test-location-2}} in 
the example, it already has a displayName because it has inherited all the 
config etc from {{test-location-1}}.

We could change this code to always set the display name:

{noformat}
if (Strings.isNonBlank(item.getDisplayName())) {
((AbstractBrooklynObjectSpec)spec).displayName(item.getDisplayName());
}
{noformat}

It's not clear whether we should simply override the value. The problem then 
would be the name defined in the catalog would override a name defined in the 
item.

I tried the test case below, but with the original and the proposed new code, 
it always gave the name "My name in items" rather than "My name in item". Not 
sure what we want to do about that.

{noformat}
brooklyn.catalog:
  version: 0.1.2
  itemType: location
  name: My name in top-level
  items:
  - id: loc1
name: My name in items
itemType: location
item:
  type: localhost
  name: My name in item
{noformat}

> Incorrect name in derived locations
> ---
>
> Key: BROOKLYN-248
> URL: https://issues.apache.org/jira/browse/BROOKLYN-248
> Project: Brooklyn
>  Issue Type: Bug
>Affects Versions: 0.9.0
> Environment: OSX
>Reporter: Duncan Godwin
>
> The following location displays "Test Location 1" for both "Test Location 1" 
> and "Test Location 2" when you use it to launch an application.
> See the screenshot here: 
> https://s3.amazonaws.com/drigodwin-misc/brooklyn-248-ss.png
> {code}
> brooklyn.catalog:
>   version: 0.2.0
>   items:
>   - id: test-location-1
> name: "Test Location 1"
> itemType: location
> item:
>   type: byon:(hosts="10.10.10.102")
>   brooklyn.config:
> displayName: testingdisplayName
> user: testinguser
> password: testingpassword
> privateKeyFile: testingprivateKeyFile
> privateKeyPassphrase: testingprivateKeyPassphrase
>   - id: test-location-2
> name: "Test Location 2"
> itemType: location
> item:
>   type: test-location-1
>   brooklyn.config:
> displayName: testingdisplayName2
> user: testinguser2
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Build failed in Jenkins: brooklyn-server-master #41

2016-04-06 Thread Apache Jenkins Server
See 

Changes:

[aled.sage] BROOKLYN-249: JcloudsLocation resolves external config

[aled.sage] Trim publicKeyData

[aled.sage] BROOKLYN-249: fix location rebind for external config

[aled.sage] BROOKLYN-249: test JcloudsLocation external config

[aled.sage] BROOKLYN-249: Adds JcloudsRebindWithExternalConfigTest

--
[...truncated 32401 lines...]
2016-04-06 10:00:33,310 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@BeforeMethod org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.setUp() 
finished in 1096 ms
2016-04-06 10:00:33,310 INFO  TESTNG INVOKING: "Surefire test" - 
org.apache.brooklyn.camp.brooklyn.catalog.CatalogYamlPolicyTest.testLaunchApplicationWithCatalogReferencingOtherCatalog()
2016-04-06 10:00:33,449 INFO  Started application 
BasicApplicationImpl{id=OiKc6NEJ}
2016-04-06 10:00:33,450 INFO  TESTNG PASSED: "Surefire test" - 
org.apache.brooklyn.camp.brooklyn.catalog.CatalogYamlPolicyTest.testLaunchApplicationWithCatalogReferencingOtherCatalog()
 finished in 140 ms
2016-04-06 10:00:33,450 INFO  TESTNG INVOKING CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.tearDown()
2016-04-06 10:00:33,452 INFO  Stopping application 
BasicApplicationImpl{id=OiKc6NEJ}
2016-04-06 10:00:33,453 INFO  Stopped application 
BasicApplicationImpl{id=OiKc6NEJ}
2016-04-06 10:00:33,485 INFO  TESTNG PASSED CONFIGURATION: "Surefire test" - 
@AfterMethod org.apache.brooklyn.camp.brooklyn.AbstractYamlTest.tearDown() 
finished in 35 ms
2016-04-06 10:00:33,551 INFO  TESTNG 
===
Surefire test
Tests run: 284, Failures: 0, Skips: 1
===
2016-04-06 10:00:33,552 INFO  BrooklynLeakListener.onFinish attempting to 
terminate all extant ManagementContexts: name=Surefire test; includedGroups=[]; 
excludedGroups=[Integration, Live-sanity, Acceptance, Live, Broken, WIP]; 
suiteName=Surefire suite; 
outDir=
 suite: no org.apache.brooklyn.core.management.internal.LocalManagementContext 
available, so skipped
Tests run: 284, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 383.219 sec - 
in TestSuite

Results :

Tests run: 283, Failures: 0, Errors: 0, Skipped: 0

[JENKINS] Recording test results
[INFO] 
[INFO] --- maven-jar-plugin:2.6:jar (default-jar) @ brooklyn-camp ---
[INFO] Building jar: 

[INFO] 
[INFO] --- maven-site-plugin:3.4:attach-descriptor (attach-descriptor) @ 
brooklyn-camp ---
[INFO] 
[INFO] --- maven-jar-plugin:2.6:test-jar (test-jar-creation) @ brooklyn-camp ---
[INFO] Building jar: 

[INFO] 
[INFO] --- apache-rat-plugin:0.11:check (default) @ brooklyn-camp ---
[INFO] 51 implicit excludes (use -debug for more details).
[INFO] Exclude: sandbox/**
[INFO] Exclude: release/**
[INFO] Exclude: README.md
[INFO] Exclude: **/nbactions.xml
[INFO] Exclude: **/nb-configuration.xml
[INFO] Exclude: **/.git/**
[INFO] Exclude: **/.gitignore
[INFO] Exclude: **/.repository/**
[INFO] Exclude: **/.idea/**
[INFO] Exclude: **/*.iml
[INFO] Exclude: **/.classpath/**
[INFO] Exclude: **/.project
[INFO] Exclude: **/.settings/**
[INFO] Exclude: **/*.log
[INFO] Exclude: **/brooklyn*.log.*
[INFO] Exclude: **/target/**
[INFO] Exclude: ignored/**
[INFO] Exclude: LICENSE.md
[INFO] Exclude: **/src/main/license/**
[INFO] Exclude: **/src/test/license/**
[INFO] Exclude: **/MANIFEST.MF
[INFO] Exclude: **/test-output/**
[INFO] Exclude: **/*.pem.pub
[INFO] Exclude: **/*.pem
[INFO] Exclude: **/*_rsa.pub
[INFO] Exclude: **/*_rsa
[INFO] Exclude: **/*.svg
[INFO] Exclude: **/*.crt
[INFO] Exclude: **/*.csr
[INFO] Exclude: **/*.key
[INFO] Exclude: **/*.key.org
[INFO] Exclude: **/*.psd
[INFO] Exclude: **/*.json
[INFO] Exclude: **/*.plxarc
[INFO] Exclude: 
**/src/test/resources/org/apache/brooklyn/entity/software/base/template_with_extra_substitutions.txt
[INFO] Exclude: **/src/main/resources/banner.txt
[INFO] Exclude: **/src/test/resources/ssl/certs/localhost/info.txt
[INFO] Exclude: **/src/main/history/dependencies.xml
[INFO] Exclude: **/sandbox/examples/src/main/scripts/amis.txt
[INFO] Exclude: docs/**
[INFO] 148 resources included (use -debug for more details)
[INFO] Rat check: Summary of files. Unapproved: 1 unknown: 1 generated: 0 
approved: 147 licence.
[INFO] 
[INFO] Reactor Summary:
[INFO] 
[INFO] Brooklyn Server Root ... SUCCESS [  2.357 s]
[INFO] Brooklyn Parent Project  SUCCESS [  4.881 s]
[INFO] Brooklyn Test Support Utilities 

[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228036#comment-15228036
 ] 

ASF GitHub Bot commented on BROOKLYN-249:
-

Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/103


> errors using external config for JcloudsLocation
> 
>
> Key: BROOKLYN-249
> URL: https://issues.apache.org/jira/browse/BROOKLYN-249
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using 
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and 
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included 
> the external config in the location (it tried to coerce the 
> {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/brooklyn-server/pull/103


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (BROOKLYN-249) errors using external config for JcloudsLocation

2016-04-06 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/BROOKLYN-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15228013#comment-15228013
 ] 

ASF GitHub Bot commented on BROOKLYN-249:
-

Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/103#issuecomment-206257277
  
Existing tests include 
`ExternalConfigYamlTest.testExternalisedLocationConfigReferencedFromYaml` and 
`testExternalisedLocationConfigSetViaProvisioningPropertiesReferencedFromYaml`.

We could do with more tests for other specific types of location. For 
example, I worry that a BYON won't correctly resolve external config.


> errors using external config for JcloudsLocation
> 
>
> Key: BROOKLYN-249
> URL: https://issues.apache.org/jira/browse/BROOKLYN-249
> Project: Brooklyn
>  Issue Type: Bug
>Reporter: Aled Sage
>
> Using 0.10.0-SNAPSHOT (also affecting 0.9.0-rc2), I hit problems using 
> external config with JcloudsLocation.
> First it failed to resolve the external config for the ssh publicKeyData and 
> privateKeyData.
> After fixing that, it failed to rebind to my persisted state that included 
> the external config in the location (it tried to coerce the 
> {{DeferredSupplier}} to a String).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread aledsage
Github user aledsage commented on the pull request:

https://github.com/apache/brooklyn-server/pull/103#issuecomment-206257277
  
Existing tests include 
`ExternalConfigYamlTest.testExternalisedLocationConfigReferencedFromYaml` and 
`testExternalisedLocationConfigSetViaProvisioningPropertiesReferencedFromYaml`.

We could do with more tests for other specific types of location. For 
example, I worry that a BYON won't correctly resolve external config.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] brooklyn-server pull request: Fix BROOKLYN-249

2016-04-06 Thread neykov
Github user neykov commented on the pull request:

https://github.com/apache/brooklyn-server/pull/103#issuecomment-206219546
  
Looks good. Are the external properties in locations already covered by 
tests (don't see related changes in last commit)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---