GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/553
MultimapSerializer works with non-String keys
MultimapSerializer works with non-String keys
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r97337170
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java
---
@@ -444,15
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/532
Looks good to me. Anything more to come @neykov?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/527
Looks good. Would be nice to be able to make an assertion on the effect of
the effector, but perhaps that's one for another time.
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/505
@aledsage could you rebase on master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-ui/pull/36
@bostko could you revisit Alex and Svet's comments?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97603990
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -625,6 +630,30 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r97610554
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -2607,24 +2522,32 @@ public boolean
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/505#discussion_r97524799
--- Diff:
core/src/main/java/org/apache/brooklyn/core/internal/BrooklynProperties.java ---
@@ -181,6 +181,7 @@ public static Builder
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/505
Looks good; will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/497
@neykov I've updated again. Took a little reworking due to the uncertainty
introduced about when the executor was allowed to shut down. Resorted to having
each call to `tryReachable` use
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/520
@neykov looks good. I'm going to merge this. Could I ask you to add a
couple of lines describing the new feature to the section on latches in the
docs (https://brooklyn.apache.org/v
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/88
@neykov could you rebase master once #87 is merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/541
Thanks @aledsage, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-docs/pull/146
Thanks @neykov, looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/91#discussion_r102723143
--- Diff: examples/webapps/hello-world-sql/src/main/webapp/redis.jsp ---
@@ -0,0 +1,80 @@
+<%@ page import="java.util.List" %&g
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/91
@justinThompson looks good thanks. I've left a couple of minor comments.
Will test the feature out before merging.
---
If your project is set up for it, you can reply to this email
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-library/pull/91#discussion_r102722987
--- Diff: examples/webapps/hello-world-sql/src/main/webapp/redis.jsp ---
@@ -0,0 +1,80 @@
+<%@ page import="java.util.List" %&g
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/93
Rename jboss_logo.png jboss-logo.png.
Fixes various references to the file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r101047658
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java
---
@@ -625,6 +630,30 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/529#discussion_r101334570
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BasicLocationNetworkInfoCustomizer.java
---
@@ -0,0 +1,472
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r97568128
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java
---
@@ -69,86 +65,113 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r97567977
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java
---
@@ -69,86 +65,113 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r97561966
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/ReachableSocketFinder.java
---
@@ -69,86 +65,113 @@ public
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r96612584
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsUtil.java
---
@@ -354,30 +355,60 @@ public static String
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/497
@aledsage @neykov I have updated this pull request to hopefully get the
best of both worlds. The point of contention was waiting the full timeout for a
response when another check had
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/497#discussion_r96614971
--- Diff:
locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsUtil.java
---
@@ -354,30 +355,60 @@ public static String
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/526
Looks sensible. It would be good to see some tests for SecurityGroupEditor
in a subsequent pull request.
---
If your project is set up for it, you can reply to this email and have your
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r96844228
--- Diff:
core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolverIterator.java
---
@@ -0,0 +1,173 @@
+package
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r96848337
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java
---
@@ -169,7
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/520
Compilation fails for me with the following error:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.3:testCompile
(default-testCompile
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/520
The bulk of these changes look good. It would help me if you gave some
context for 112269ae484dcc5283d9cabc8de2e987f013e79f.
---
If your project is set up for it, you can reply
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r96845410
--- Diff:
core/src/main/java/org/apache/brooklyn/core/sensor/MaxConcurrencySensor.java ---
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/524#discussion_r96843229
--- Diff:
rest/rest-server/src/main/java/org/apache/brooklyn/rest/filter/BrooklynPropertiesSecurityFilter.java
---
@@ -148,8 +148,11 @@ protected
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/524
Misc improvements
A bunch of things I've found useful.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-server
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/529
LocationNetworkInfoCustomizer
`LocationNetworkInfoCustomizer` is a special customiser used by
`JcloudsLocation` to determine the address and credentials with which a
location should
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/520
Jenkins is failing on `SoftwareProcessEntityLatchTest.testConcurrency` and
`testReleaseableLatchBlocks`
By the way, can we get rid of `maxConcurrentChildCommands` when
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/87
You need to update `ChefLifecycleEffectorTasks`, `ChefPostgreSqlLifecycle`
and
`org.apache.brooklyn.entity.software.base.test.mysql.DynamicToyMySqlEntityBuilder.MySqlEntityInitializer
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/520#discussion_r97049449
--- Diff:
software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessDriverLifecycleEffectorTasks.java
---
@@ -169,7
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/304#discussion_r75483563
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/SshCommandMembershipTrackingPolicy.java
---
@@ -25,7 +25,9 @@
import
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/572
wip: debug ReachableSocketFinderTest.getReachableSockets
Don't merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/572
@geomacy @neykov could you review this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett closed the pull request at:
https://github.com/apache/brooklyn-server/pull/318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/318
Delete most deprecated methods from PortForwardManager
They've been deprecated since 0.7.0.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/317
@grkvlt @Graeme-Miller I am not happy for this to be merged before you have
confirmed or we have at least discussed what happens to the `brooklyn-tosca`
dist.
---
If your project is set
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/318#discussion_r78008532
--- Diff:
core/src/main/java/org/apache/brooklyn/core/location/access/PortForwardManagerImpl.java
---
@@ -83,9 +83,6 @@
private
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/317
@ahgittin another downstream project has a dependency on
https://github.com/fabric8io/kubernetes-client which requires the later version.
---
If your project is set up for it, you can
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/317
@geomacy did you use the dist tgz that brooklyn-tosca builds? I will also
test shortly.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/317
Can you test that `brooklyn-tosca` works with this change please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-docs/pull/106#discussion_r78152257
--- Diff: guide/ops/troubleshooting/deployment.md ---
@@ -40,9 +40,12 @@ means there was some problem obtaining or connecting to
the machine
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/369
DynamicGroup filters entities in its app, not the management context
I think this would be the expected behaviour.
The current behaviour would cause entities like
[brooklyn-dns
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/369
The build timed out building the Camp API:
```
[INFO] Brooklyn CAMP REST API . FAILURE [33:24
min]
```
---
If your project is set up for it, you
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/326
Merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/327
Looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/342#discussion_r80077697
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/LocalUsageManagerTest.java
---
@@ -16,67 +16,77 @@
* specific language
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/342
Load usage listeners from bundles
And JcloudsLocation's image choosers.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/370#discussion_r82679003
--- Diff:
core/src/test/java/org/apache/brooklyn/core/effector/ProxyEffectorTest.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/375
Looks good to me. Are there any new guidelines test writers should follow?
If yes it would be helpful to record them in documentation or on the mailing
list.
---
If your project is set
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/370
@geomacy thanks for your comments. I've resolved the comments that I didn't
reply to. Is there anything you'd like to follow up on?
---
If your project is set up for it, you can reply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/369
@geomacy thanks. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/422
SshCommandEffector + shell.env
SshCommandEffector resolves shell.env against the target entity rather than
always resolving it against the entity the effector is attached to. This also
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/409
I also have integration test failures on this branch:
```
SshjToolIntegrationTest.testAsyncExecAbortsIfProcessFails:273 expected
[false] but found [true
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/429
BasicJcloudsLocationCustomizer is an EntityInitializer
Repeats https://github.com/apache/brooklyn-server/pull/168 but puts the
location customizers into the entity's provisioning
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-docs/pull/116
Correct typo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sjcorbett/brooklyn-docs typo
Alternatively you can review and apply
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/319
@bostko there are four test failures:
```
org.apache.brooklyn.location.jclouds.networking.SharedLocationSecurityGroupCustomizerTest.testInboundIcmpAddedToPermissions
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/382
I will merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/335
Looks good. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/386
Add AbstractInvokeEffectorPolicy
Supports tracking the number of effector tasks that are ongoing and
publishing that as an "is busy" sensor on the entity the policy i
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/384
Looks good. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/319#discussion_r83863239
--- Diff:
utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java ---
@@ -241,7 +241,12 @@ public static void checkPortsValid(Map
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/319
LGTM. Will wait for Jenkins to complete before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/393#discussion_r84863480
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/stock/BasicStartableImpl.java ---
@@ -51,6 +53,7 @@
public void start(Collection
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/386#discussion_r84946013
--- Diff:
core/src/main/java/org/apache/brooklyn/policy/AbstractInvokeEffectorPolicy.java
---
@@ -0,0 +1,110 @@
+/*
+ * Licensed
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/386
@aledsage thanks for your comments. I've replaced `TASK_COUNTER` with a
field and have added a test for the sensor to
`InvokeEffectorOnCollectionSensorChangeTest`.
---
If your project
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/393
Lifecycle fixes
Fixes a handful of surprising behaviours in AbstractApplication,
DynamicGroup and BasicStartable.
You can merge this pull request into a Git repository by running
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-client/pull/30
br app only outputs location details when the app has a location
Fixes https://issues.apache.org/jira/browse/BROOKLYN-230.
You can merge this pull request into a Git repository by running
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/393
One possibly surprising new behaviour from 1e44522 involves the status of a
`BasicStartable` when its children restart. I'll use this blueprint as an
example:
```yaml
location
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-server/pull/439
Add Suppliers.incrementingSupplier
A simple useful class. I have a pull request coming for brooklyn-library
that makes proper use of this.
You can merge this pull request into a Git
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/464#discussion_r89767445
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/EntityExecutionManagerTest.java
---
@@ -82,18 +83,33 @@ public void
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/464#discussion_r89765709
--- Diff:
core/src/test/java/org/apache/brooklyn/core/mgmt/internal/EntityExecutionManagerTest.java
---
@@ -68,6 +68,7 @@
import
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/443#discussion_r89785111
--- Diff:
core/src/test/java/org/apache/brooklyn/entity/group/DynamicClusterTest.java ---
@@ -1225,4 +1235,93 @@ private void
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/443#discussion_r89813930
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java ---
@@ -1040,14 +1077,81 @@ protected void discardNode
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/78
https://github.com/apache/brooklyn-library/pull/79 is a follow up to this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/75
The build failed because it's missing the dependencies mentioned in
brooklyn-server.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/429
@neykov thanks for your comments. I've removed `params` and added a test
that confirms that the initialiser is applied to cluster members. Can you
clarify what you meant when you said
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/436
Looks good. Will merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/429#discussion_r88222541
--- Diff:
locations/jclouds/src/test/java/org/apache/brooklyn/location/jclouds/BasicJcloudsLocationCustomizerTest.java
---
@@ -0,0 +1,81
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/424
Looks good to me, happy to merge as-is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/443
Jenkins did its job. I had forgotten to `submit` a task so
`stopAndRemoveNode` blocked forever.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/443#discussion_r88712700
--- Diff:
core/src/test/java/org/apache/brooklyn/entity/group/DynamicClusterRebindTest.java
---
@@ -0,0 +1,54 @@
+/*
+ * Licensed
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/443#discussion_r88712272
--- Diff:
core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java ---
@@ -183,6 +183,14 @@
ConfigKey CLUSTER_MEMBER_ID
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-dist/pull/59
I think this has triggered the rat plugin:
```
[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.11:check
(default) on project brooklyn-dist-root: Too many files
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/74
Rat again: [ERROR] Failed to execute goal
org.apache.rat:apache-rat-plugin:0.11:check (default) on project
brooklyn-library: Too many files with unapproved license: 1 See RAT report
GitHub user sjcorbett opened a pull request:
https://github.com/apache/brooklyn-library/pull/75
ZooKeeper ensemble fixes
* Fixes ZooKeeper ensembles by ensuring that each node has a different id.
* Improves live tests to test that data can be written and read back
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/75
These changes depend on https://github.com/apache/brooklyn-server/pull/439.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/393
@neykov I've updated per your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/386
@neykov I've pushed some updates that extend the 'more updates coming'
notion to `InvokeEffectorOnSensorChange`. I'd appreciate you casting your eye
over `AbstractInvokeEffectorPolicy
Github user sjcorbett commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/382#discussion_r83262396
--- Diff:
core/src/main/java/org/apache/brooklyn/policy/InvokeEffectorOnSetChange.java ---
@@ -0,0 +1,203 @@
+/*
+ * Licensed
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-server/pull/382
@neykov thank you for your comments. I've addressed everything I didn't
comment on. I've also renamed the policy to
`InvokeEffectorOnCollectionSensorChange` to be consistent
101 - 200 of 289 matches
Mail list logo
