Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1276
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-172181356
Ping @remibergsma
LGTM, please proceed with merge.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email a
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-170902066
tested on a two kvm, as in the bubble, setup:
```
# less /tmp/MarvinLogs/test_vpc_vpn_Q1BTHP/results.txt
Test Site 2 Site VPN Across redundant VPCs .
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-170863132
ping @sanju1010 @wido @terbolous
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-170636254
ping @DaanHoogland
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-170543474
just ran the test again after adding the validateList method:
command:
```
osetests --with-marvin
--marvin-config=/data/shared/marvin/mct-zo
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r49317967
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port,
private_port, public_ip
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r49099622
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port,
private_port, public_ip
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48463624
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port,
private_port, public_ip, netw
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48463596
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port,
private_port, public_ip, netw
Github user sanju1010 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48463512
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -494,9 +526,411 @@ def create_natrule(self, vpc, vm, public_port,
private_port, public_ip, netw
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48382355
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services,
retries):
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48350750
--- Diff: test/integration/smoke/test_vpc_vpn.py ---
@@ -468,7 +500,7 @@ def get_ssh_client(self, virtual_machine, services,
retries):
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-166714201
As for:
> Is there a timing issue possible where both routers would be in the same
state? If so, it might be good to > throw an exception before doi
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48290122
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void updateSite2SiteVpnCo
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48288107
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void updateSite2SiteVpnCo
Github user michaelandersen commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48286045
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void updateSite2SiteVpnCo
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1276#discussion_r48278591
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -916,6 +916,9 @@ protected void updateSite2SiteVpnConnectionSt
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-166675193
Good to see additional tests created. I would suggest adding a test that
turns one of the routers off, and then seeing if the VPN connection works
correctly. I quickl
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-18278
Did a code review on this PR and also talked to @michaelandersen on Slack
about switching the MASTER router off. With the changes he applied on the Java
fil
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1276#issuecomment-17779
Jenkins error is not related:
---
21 matches
Mail list logo
