Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-141135958
Hi there @rafaelweingartner,
No hard feelings, dude.
Long story short:
* we are going through a critical phase with ACS - release
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-141142775
@wilderrodrigues,
Of course no hard feelings.
I understand the pain that you feel when you stabilize everything and
people come and breaking
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140645340
Hi @rafaelweingartner ,
I understood that @pedro-martins went through a hard time checking class by
class, but I would not discuss credits and that
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140645427
I will add the same comment to the opened PR instead. I believe is better
to follow up overt here.
---
If your project is set up for it, you can reply to
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140648456
Hi @rafaelweingartner ,
Master was broken yesterday when a file containing the wrong imports was
merged. I reverted about 5 minutes after the merge.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140658135
All,
Given the current blocker issues we have to fix on master in order to
release 4.6.0 and the fact that those changes don't really improve the
Github user rafaelweingartner closed the pull request at:
https://github.com/apache/cloudstack/pull/778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140729409
Dear @wilderrodrigues, As I said I get your point and the moment that you
guys are on closing a version.
A mistake was made, the moment I noticed
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140487166
@rafaelweingartner Thanks for the time you spent on this. The commit header
is indeed better. It now conveys what is being done. If you happen to have to
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140493836
I do agree that prepending "s_" to static variables is a waste of
characters. Modern IDEs will signal static variables for you. It's a bit like
prepending
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140491359
Actually, the ticket is as simple as that.
It was just an exercise to an intern that is working with me in my thesis.
We are doing few very small
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140424617
Maybe the compiler is overworked and just did a cursory glance and reported
back "LGTM." ;)
---
If your project is set up for it, you can reply to this
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140423615
I completely agree with you in this Mike. We should stop churning in
features when we don't even have a proper build that prevents **syntax** errors!
---
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140360164
@mike-tutkowski @DaanHoogland @karuturi @miguelaferreira @rafaelweingartner
@pedro-martins
First of all let me just get one thing clear: Rafael
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140365763
@wilderrodrigues I commented: "travis timeouts are unrelated. analysis
passes, LGTM". So it was compiled otherwise the analysis would not have passed.
What I
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140366106
@karuturi @remibergsma @rafaelweingartner @DaanHoogland @miguelaferreira
Please, before proceeding with this PR see my comments on the previous
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140367124
Hi @DaanHoogland, what I don't understand is how travis compiled and 15
days ago @rafaelweingartner said that he forgot to push 1 file.
Looking at
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140366714
@rafaelweingartner do you think "Re-pushing the PR 714" is a good commit
header?
I mean when someone goes thought the commit list looking for something,
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140368629
and later we see:
We now found a
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140423091
@wilderrodrigues conflicts solved, I tried to do a maven install, to run
all tests and compile everything, but that did not work, hence there is a class
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140527418
I do agree with you that removing duplicated code, reducing cyclomatic
complexity and writing test case is much better. However, those tasks require
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140402029
I could say this again, but it doesn't seem like it's a popular opinion
with regards to CloudStack development:
If we are really "late in the game"
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140403471
@mike-tutkowski **we** don't have an awesome suite of regression tests
because **we** don't write them. And if so, we should not rely on the builds we
have,
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140403964
@rafaelweingartner I totally understand. Inspiration is not something that
always comes when needed. Please do take your time.
---
If your project is set
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140404617
Right, Miguel (as you and I were discussing for that other PR with regards
to tests).
My point then is we especially should not be putting in this
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140392192
"In this particular case, how is possible to get 2 LGTM without even
compiling the project locally?"
I was depending on the info Daan refers to and,
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140379362
@wilderrodrigues I got your point, and I also hate when projects that I
work start breaking as a consequence of bad/poor code. Here goes an explanation
in
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-140380153
@wilderrodrigues thanks for your comments, I have just answered your
comments on PR 714. I will work on a rebase today and push it again.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/778#issuecomment-137957748
@karuturi Can you have a look please and maybe check the noredist build?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-136390913
@karuturi, I was just reviewing my commit, I am really sorry.
I indeed forgot to commit the removal of the static keyword in that method.
It was right
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-136366153
Hi @karuturi, If you take a look at here:
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-136274140
jenkins noredist build failed with the below error. Reverting this PR
```
[ERROR] Failed to execute goal
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135968372
travis timeouts are unrelated. analysis passes, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135972829
Thanks for the hard work on reviewing this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135662629
I saw it a branch I am working on
https://github.com/karuturi/cloudstack/blob/CLOUDSTACK-8647/utils/src/com/cloud/utils/log/CglibThrowableRenderer.java
---
If
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135697615
@karuturi i noticed that while cleaning up my PR and I thought I had
reverted that change. I will put that file back, and make a new PR
---
If your project
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135708224
@karuturi @pedro-martins file is restored in PR #758
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135694810
looks like it is removed from this commit
83fd8f60f3c503cf6fda7833b0f45c23a215f559
@miguelaferreira, tests from âcloud-plugin-network-nvpâ project are
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135761564
Thanks @miguelaferreira
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135940383
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135612199
@RajaniKaruturi
Are you sure that the class âCglibThrowableRendererâ is in cloud-utils?
I have just got the master version from the git
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-135142435
Hi folks,
Sorry the double post, I replyed an asf bot mail and it seems tha the
message was not properly relayed.
I am getting an error with a
Hi folks,
I am getting an error with a Travis build of a PR that we have done:
log4j:ERROR Could not create the ThrowableRenderer. Reported error follows.
java.lang.ClassNotFoundException: com.cloud.utils.log.CglibThrowableRenderer
at
The class is in cloud-utils package.
~Rajani
On 26-Aug-2015, at 11:18 pm, Rafael Weingärtner rafaelweingart...@gmail.com
wrote:
Hi folks,
I am getting an error with a Travis build of a PR that we have done:
log4j:ERROR Could not create the ThrowableRenderer. Reported error follows.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-134380116
I think that the best way to merge this PR is for us to create it over a
head version. We have a script that changes almost everything automatically.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-133686898
@DaanHoogland commits squashed.
I noticed that some checks failed (in pretty fast glance at the log, it
seems that was not cause by our commits). I
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-133633062
As the system won't be build with just the first commit applied can you
squash those two commits?
---
If your project is set up for it, you can reply to this
GitHub user pedro-martins reopened a pull request:
https://github.com/apache/cloudstack/pull/714
Changed variable s_logger to non-static and fixed its name in
âcom.cloud.utils.component.ComponentLifecycleBaseâ and its subclasses
Hi guys,
We have noticed that every single
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-133544774
Hi @DaanHoogland, after we opened the Jira Ticket, someone ended up
assigning them to us!? So, we decided to take a lead and analyzed the impact
that the
Github user pedro-martins closed the pull request at:
https://github.com/apache/cloudstack/pull/714
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132654938
@DaanHoogland I agree with your considerations. My first commit was not
performed properly. Sadly, the eclipse ended up formatting classes I touched,
and that
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132662044
@pedro-martins your motivation makes sense to me, can you create a jira
ticket and cp it there? then use that as a tag for any commits (including
Github user pedro-martins commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132698414
Got your comments, sadly we have not analyzed which classes are singleton
or not.
We have opened a jira ticket to that:
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-132335229
@pedro-martins s_logger is a standard name for the variables and in each
class it gets the class.class as its log category. I fail to see how you
change
GitHub user pedro-martins opened a pull request:
https://github.com/apache/cloudstack/pull/714
Changed variable s_logger to non-static and fixed its name in
âcom.cloud.utils.component.ComponentLifecycleBaseâ and its subclasses
Hi guys,
We have noticed that every single
56 matches
Mail list logo
