everybody, I will LGTM PR #714 [1] and I would like to have more then one
extra pair of eyes this time. Some group of folks, I know there is at least
three of them, have decided to invest in cleaning some code in CS and I
think their work deserves full attention. they worked on refactoring some
of
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-133633062
As the system won't be build with just the first commit applied can you
squash those two commits?
---
If your project is set up for it, you can reply to this
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-133369723
@remibergsma https://builds.apache.org is available, maybe
https://builds.apache.org/job/cloudstack-pull-requests/1001/ got removed from
the server as it was
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37623820
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software
GitHub user koushik-das opened a pull request:
https://github.com/apache/cloudstack/pull/725
CLOUDSTACK-8754: VM migration triggered by dynamic scaling is failing
This is caused by serialization failure for VmWorkMigrateForScale object.
Replaced DeployDestination member present in
Github user nitt10prashant commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/724#discussion_r37625731
--- Diff: test/integration/component/test_escalations_routers.py ---
@@ -0,0 +1,189 @@
+# Licensed to the Apache Software Foundation (ASF)
GitHub user shwetaag opened a pull request:
https://github.com/apache/cloudstack/pull/729
CLOUDSTACK-8757:FTP modules are not loaded in VR
check bug 8757 for more details .
You can merge this pull request into a Git repository by running:
$ git pull
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133397841
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133399200
@remibergsma @karuturi Please review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133449560
You mention replacing deployDestination with something serializable but I
don't see it,
Why is a simple (de)serialization test not usefull? it will
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133451646
@DaanHoogland check the base class
The test cannot catch a new addition to the class which may break
serialization.
Suppose a new non-serializable member
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/723#issuecomment-133398506
LGTM
Keep them coming!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37628373
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to the
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/730
Replace some profiler.getDuration with profiler.getDurationInMillis fter
commit 5557ad55
We got a lot of debugging information in management server log because of
this.
You can merge this
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133399741
Although I think the code is good and I want to give a LGTM, I'm just not
100% sure about this one.
---
If your project is set up for it, you can reply to this email
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37628668
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to the
GitHub user shwetaag opened a pull request:
https://github.com/apache/cloudstack/pull/728
CLOUDSTACK-8756:Incorrect guest os mapping in CCP 4.2.1-6 for CentOS 5.9
Check the bug 8756 for more details
You can merge this pull request into a Git repository by running:
$ git pull
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133406706
LGTM. lets wait for travis and other jenkins verifications.
In future, can you club all refactoring work in a branch and merge them
together? That way, we
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/723
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Thanks.
On Fri, Aug 21, 2015 at 5:19 PM, Simon Weller swel...@ena.com wrote:
Zaeem,
Nicara (VMWare-NSX-MH) and Nuage both work with XenServer. Reading the
Nuage VSP plugin jira ticket, they only claim support for XenServer right
now, and none for KVM.
- Si
We use it with hundreds of XenServers (currently 6.2) and KVM hypervisors on
CentOS 7. Open vSwitch does the magic. We did upgrade ovs to a more recent
version, though.
Regards, Remi
Sent from my iPhone
On 21 Aug 2015, at 14:04, Zaeem Arshad zaeem.ars...@gmail.com wrote:
How does that
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/723#issuecomment-133407414
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-133407337
@DaanHoogland in addition to failing to convey the intention of the action,
the open then close pattern is incredibly expensive due to rapid, unnecessary
churn on
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/725#discussion_r37642249
--- Diff: engine/orchestration/src/com/cloud/vm/VmWorkMigrateForScale.java
---
@@ -18,30 +18,18 @@
import
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133457425
Maybe a little out of scope for this PR, I have been looking a bit at the
hierarchy. It contains a lot of primitives. somewhat related to our gson
problem
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133398943
Tested it in a new environment. The nics are correctly put in the db again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37628774
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to the
Zaeem,
Nicara (VMWare-NSX-MH) and Nuage both work with XenServer. Reading the Nuage
VSP plugin jira ticket, they only claim support for XenServer right now, and
none for KVM.
- Si
From: Zaeem Arshad zaeem.ars...@gmail.com
Sent: Friday, August 21,
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133408184
@karuturi I came to that conclusion in the previous pr. I will stack all
refactoring work in a branch. And send a PR when done.
---
If your project is set up
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/725#discussion_r37640687
--- Diff: engine/orchestration/src/com/cloud/vm/VmWorkMigrateForScale.java
---
@@ -18,30 +18,18 @@
import
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133467580
@borisroman Thanks! I'll run some tests later tonight. Travis is green,
didn't see an Apache build reporting results (yet?).
---
If your project is set up for
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133546545
cloudstack-pull-analysis 296 failed due to: `Expected exactly 2 but it took
more than 3 microseconds between 2 consecutive calls to System.nanoTime().`
Seems
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-133547422
@shwetaag Can you please add more details? The Jira issue only has a title.
Are you submitting a test so in case the modules are not loaded, alarms go off?
Or
GitHub user pedro-martins reopened a pull request:
https://github.com/apache/cloudstack/pull/714
Changed variable s_logger to non-static and fixed its name in
âcom.cloud.utils.component.ComponentLifecycleBaseâ and its subclasses
Hi guys,
We have noticed that every single
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-133544774
Hi @DaanHoogland, after we opened the Jira Ticket, someone ended up
assigning them to us!? So, we decided to take a lead and analyzed the impact
that the
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133544954
LGTM Verified that a new cloud deployment had working system VMs again.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/728#issuecomment-133548095
@shwetaag Please add more details on the actual problem (also in Jira) and
what you want to achieve by adding this test. Both CentOS 5 and CCP 4.2.1seem
very
H Rafael, I saw Rajani assigning the ticket to Pedro and as he created it I
thought he would be informed of it so he can undo if needed.
Thanks for the report. Due to the extensiveness I can not determine the
full implication but as it seems the largest part (132/167) are spring
instantiated
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/716#issuecomment-13354
@borisroman I suggest you close this PR and do all the refactor work in a
separate branch, as discussed. Thanks!
---
If your project is set up for it, you can
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133552003
analysisfailures are unrelated to the changes AFAICT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133552422
I think we have to disable this test, enlarging the period even more beats
every intention of its use. not related indeed
---
If your project is set up for
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-ec2stack/pull/1#issuecomment-133505244
testing comment notification, DISCARD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133567102
Check, as far as I can tell everything is OK. And since master is broken
now anyway, I think it's time to merge this to fix it.
---
If your project is set up
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133567885
hm, you shouldt merge anything to a broken master that isn't hellbound on
fixing it.
---
If your project is set up for it, you can reply to this email and
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133570169
@DaanHoogland It does fix the problem, I just feel a bit blind sometimes by
the builds that seem less reliable lately so then it's hard to be sure.
But
Github user shwetaag closed the pull request at:
https://github.com/apache/cloudstack/pull/724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37627680
--- Diff: engine/schema/src/com/cloud/usage/dao/UsageDaoImpl.java ---
@@ -469,4 +478,25 @@ public void removeOldUsageRecords(int days) {
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37627808
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java ---
@@ -0,0 +1,72 @@
+//Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37627849
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,64 @@
+//Licensed to the Apache
How does that integrate with a XenServer based environment?
Regards
Zaeem
On Fri, Aug 21, 2015 at 1:17 AM, Remi Bergsma rberg...@schubergphilis.com
wrote:
Hi Simon,
At Schuberg Philis we use Nicira (which nowadays is called VMware NSX-MH)
in production since 2012. It works well for us. The
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/726
Fix for the NicVO.java regression.
Renamed set*() methods to correct naming.
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user shwetaag opened a pull request:
https://github.com/apache/cloudstack/pull/727
CLOUDSTACK-8755: xs-tools.iso missing from ISOs in CCP GUI
updated the automation for correct verification in case of listing default
isos
You can merge this pull request into a Git
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37628117
--- Diff:
plugins/database/quota/src/org/apache/cloudstack/api/response/QuotaResponseBuilderImpl.java
---
@@ -0,0 +1,419 @@
+//Licensed to the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/726#issuecomment-133395038
The updateBuilder will check if the DAO has changed based on the set*()
methods. When it can't resolve one, it won't update. After learning this I
changed the
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#discussion_r37615562
--- Diff: source/plugins/quota.rst ---
@@ -0,0 +1,189 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#discussion_r37615769
--- Diff: source/plugins/quota.rst ---
@@ -0,0 +1,189 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37616481
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaCreditsDaoImpl.java ---
@@ -0,0 +1,72 @@
+//Licensed to the Apache Software
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37616523
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaEmailTemplatesDaoImpl.java
---
@@ -0,0 +1,64 @@
+//Licensed to the Apache
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-133351307
Daan,
Thanks for reviewing the document, the observations are incorporated.
---
If your project is set up for it, you can reply
Github user abhinandanprateek commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-133352253
Where ever there is a DB change the pattern is use. The plain switch is
used where it is db readonly.
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/698#issuecomment-133358938
Can't currently check the output of Apache Build Jenkins as it returns 404.
Wanted to double check the UNSTABLE state. Holding on for now..
---
If your project
GitHub user shwetaag opened a pull request:
https://github.com/apache/cloudstack/pull/724
Customer escalations
Automated two test cases and modified one testcase
First one is to verify correct guest os mapping in vmware for CentOS 5.9
and above
Step1 :Register an
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#discussion_r37615907
--- Diff: source/plugins/quota.rst ---
@@ -0,0 +1,189 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/689#issuecomment-15452
I saw @jburwell his remarks coming by. I trust him to be thorough. I will
review when I see unit and integration tests.
try using more try with resource
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#discussion_r37615956
--- Diff: source/plugins/quota.rst ---
@@ -0,0 +1,189 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#discussion_r37615671
--- Diff: source/plugins/quota.rst ---
@@ -0,0 +1,189 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#discussion_r37615635
--- Diff: source/plugins/quota.rst ---
@@ -0,0 +1,189 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-12732
remarks made but LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
69 matches
Mail list logo
