Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Daan Hoogland
Jeff, I am definitely not god amongst maven users so I have to start guessing now. It might be that you need to do magic in the pom for this to work. or in MAVEN_OPTS. (what are the mirrors for? these are mirrors of your local repo, right?) On Tue, Nov 10, 2015 at 4:47 PM, Jeff Hair

Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Daan Hoogland
Jeff, kicking in an open door: did you edit your .m2/settings.xml? On Tue, Nov 10, 2015 at 3:27 PM, Jeff Hair wrote: > Also, mirroring is probably not the best term. We are not mirroring the > build artifacts from the official build servers. We are attempting to > deploy

[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1057 Cwe 190 coverity warnings of this type adressed. Some where dismissed and maybe with reason but it seemed possible to remove them and hence obligatory ;p You can merge this pull request

infra ticket

2015-11-10 Thread Daan Hoogland
Please every body review https://issues.apache.org/jira/browse/INFRA-10703 and vote for it. The builders ubuntu-[2456] are constantly failing with segv in java and make our live harder. -- Daan

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155468243 @rafaelweingartner after randomly oredering and limiting output to 1 the next step is looping over all (1) results and retrieving all hosts one by one

Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Well, the mirrors point to the same place. We started with using the element instead of the element. It probably doesn't make sense to have both. On Tue, Nov 10, 2015 at 3:54 PM, Daan Hoogland wrote: > Jeff, I am definitely not god amongst maven users so I have to

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Boris Schrijver
Hi, I've build the DEB packages for Ubuntu Trusty Tahr (14.04). They are available here: https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-agent_4.6.0_all.deb https://cloudstack.o.auroraobjects.eu/trusty/cloudstack-cli_4.6.0_all.deb

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-155456551 @wido Running org.apache.cloudstack.networkoffering.CreateNetworkOfferingTest # # A fatal error has been detected by the Java Runtime Environment:

Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Yes. It's like this. Not all of this may make sense as I don't normally have a custom MVN repo set up. * Edited settings.xml to have a new element which points to archiva releases repo and archiva snapshots repo. * Added mirrors for both the releases and snapshots repo. * Deployed a built version

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Remi Bergsma
FYI: Jenkins was so kind to build us some packages, should we want to use them: CentOS 7 packages http://jenkins.buildacloud.org/view/parameterized/job/cloudstack-rpm-packages-with-branch-parameter-centos7/3/ CentOS 6 packages

[GitHub] cloudstack pull request: Metrics views for CloudStack UI

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1038#issuecomment-155462713 Nice logo @bhaisaab :-) ![screen shot 2015-11-10 at 16 54

[VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Remi Bergsma
Hi all, I've created a 4.6.0 release candidate, with the following artifacts up for a vote: Git Branch and Commit SH: https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=shortlog;h=4.6.0-RC20151110T1545 Commit: e31ade03c66368c64f0cd66cb7b0b754cddfb79d Source release (checksums and

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155485478 @miguelaferreira @rafaelweingartner you guys care to discuss this further? (this as in this case but also this as in this pattern) --- If your project is set

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-155444641 "Apache CloudStack Server" has failed says Jenkins. I don't see a failed test though? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9048: Fix typo for public netw...

2015-11-10 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1051#issuecomment-155444948 LGTM Trivial fix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155451132 @miguelaferreira @rafaelweingartner I totally agree with you that this can be dealt with better. I didn't want to give it a second thought as my intention is

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155535685 Are we already migrating to Java 8? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[DISCUSS] Shared Networks on Nicira NVP Plugin

2015-11-10 Thread Nicolás Vázquez
Hi all, I'm working on supporting Shared Networks on the Nicira NVP Plugin. I see *nicira_nvp_router_map* table has a unique index on *logicalrouter_uuid*, but changes I'm working on will allow shared networks to connect to the same router, so I'll need to remove that index. (ALTER TABLE

[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1057#issuecomment-155517568 @DaanHoogland, pretty good job, you created the test cases and removed the return null cases. I just have one question, why you use a cast for the

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155536608 Optionals are great whether we need to handle or not, right? Especially in this one level case. I was thinking it would get more complicated in some cases.

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155541260 yeah, you had me at 'Are we'. I am now building with 1.8. change in the pom and et the java_home should be all --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155515107 @ DaanHoogland, I noticed that the select is limiting the RS in one element. That is actually my point, if the register does not matter, I would rather

Re: cloudstack vulnerable by COLLECTIONS-580?

2015-11-10 Thread John Kinsella
Thanks for sending this, Rene. In the future, please send issues like this to secur...@cloudstack.apache.org. We’re looking things over, and will have further comments after review. John On Nov 10, 2015, at 6:07 AM, Rene Moser

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Wilder Rodrigues
Will start testing now. Back with results + vote tomorrow. Cheers, Wilder > On 10 Nov 2015, at 17:22, Boris Schrijver wrote: > > Hi, > > I've build the DEB packages for Ubuntu Trusty Tahr (14.04). They are available > here: > >

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155525984 If there will be no error recovery for the exception thrown on host == null, then you will probably be better off with using Optional. It's in Java8, but

[GitHub] cloudstack pull request: Shuffling the password to avoid having a ...

2015-11-10 Thread nnesic
GitHub user nnesic opened a pull request: https://github.com/apache/cloudstack/pull/1058 Shuffling the password to avoid having a subset of characters in fixed positions. Related to CLOUDSTACK-9052. I am shuffling the characters in the password, to avoid having a certain

RE: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Raja Pullela
BVT ran this morning - but, don't think I have picked up this latest build, so, will report again later tomorrow... BVTs are almost at 100% on KVM and XS both Adv/Basic. Failed cases were all test related... hope to do a +1 tomorrow! -

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155538342 That is great if we can use Java 8. However, I checked the maven compiler configuration, and it is using Java 1.7 --- If your project is set up for it,

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-13509 @rafaelweingartner I think the method configures the host to have the right storage endpoint. It is kind of an obfuscated side effect but I think the call to

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155565847 @rafaelweingartner the compile of cloudstack with 1.8 completes but not with unit tests. I think we need to work hard for this. --- If your project is set up

[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1057#issuecomment-155577386 @rafaelweingartner the cast was the reason for starting this. Coverity complained about a 32 bit shift on an integer (31 bit + sign) --- If your project is

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155545730 Got it. Shouldn’t we create a PR changing the Java compilation level to 1.8? @DaanHoogland, I still have a doubt about the need of that

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155595167 @DaanHoogland, sorry if I am being stubborn, but I really do not see what the method “endPointSelector.selectHypervisorHost” is used for; at the end

[GitHub] cloudstack pull request: Cwe 190

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1057#issuecomment-155595924 Got it @DaanHoogland. What about using () to surround the “(long) 0x” in lines 885, 925 and 931 as you did in 779. --- If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155356678 Just tested and managed to deploy the management server without issues. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155357693 @davidamorimfaria Thanks, will retest soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/1054#issuecomment-155353598 Pylint result: ``` Global evaluation - Your code has been rated at 6.48/10 (previous run: 6.48/10, +0.00) ``` I also

[GitHub] cloudstack pull request: CLOUDSTACK-8818: Use MySQL native connect...

2015-11-10 Thread wido
GitHub user wido opened a pull request: https://github.com/apache/cloudstack/pull/1054 CLOUDSTACK-8818: Use MySQL native connector with Python MySQLdb has been deprecated and is also not supported in Python 3. mysql.connector is a connector written in Python which talks the

[GitHub] cloudstack-docs-install pull request: include argument for tomcat7...

2015-11-10 Thread davidamorimfaria
GitHub user davidamorimfaria opened a pull request: https://github.com/apache/cloudstack-docs-install/pull/24 include argument for tomcat7 servlet container include argument for tomcat7 servlet container during management server setup You can merge this pull request into a Git

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155368243 validated the build and install with centos7. validation on centos6 started --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1046 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155381911 Ping @PaulAngus to have a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-9047 rename enums

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1049#issuecomment-155381918 I will build this PR locally to make sure Maven runs the unit tests successfully. Cheers, Wilder --- If your project is set up for it, you

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155383672 @wilderrodrigues Please see attachment ![image](https://cloud.githubusercontent.com/assets/3204966/11060199/f9a00d5a-879e-11e5-92fe-044acdd3a2f7.png) ---

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155384967 @davidamorimfaria Please squash the commits, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: New PMC member: Erik Weber

2015-11-10 Thread Paul Angus
Congratulations Erik. Regards, Paul Angus VP Technology/Cloud Architect S: +44 20 3603 0540 | M: +447711418784 | T: CloudyAngus paul.an...@shapeblue.com -Original Message- From: Jayapal Reddy Uradi [mailto:jayapalreddy.ur...@citrix.com] Sent: 10 November 2015 05:09 To:

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155371923 added pr for docs-install https://github.com/apache/cloudstack-docs-install/pull/24 --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155375779 @ustcweizhou and what about the ACL button? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: CLOUDSTACK-9044: Add RBD Primary Storage ...

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1046#issuecomment-155378548 Ping @remibergsma @borisroman This PR LGTM :+1: I reviewed the code and read the comments in the PR, also looking at the tests

[GitHub] cloudstack pull request: squashed commit for dockerfiles part#2 in...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/999 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155381433 LGTM, Tested on CentOS7 with Tomcat 7. The package builds fine: ``` + exit 0 RPM Build Done ``` Install also works:

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread ustcweizhou
Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155352944 @remibergsma @karuturi For the isolated network and shared network, the guest NIC of VR is listed at the top of NIC tab. However, for VPC VR, the guest

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1055#issuecomment-155403829 did a mvn build on the pr and manually verified the api call. the private key isn't logged anymore. before ``` 2015-11-10 17:13:18,462 DEBUG

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155404689 Verified RPM build after squash to be sure: ``` + exit 0 RPM Build Done ``` --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1056 CID-1338387: paranoia null checking You can merge this pull request into a Git repository by running: $ git pull https://github.com/DaanHoogland/cloudstack CID-1338387

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1052 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155409591 Wouldn't it be better to make sure `endPointSelector.selectHypervisorHost(...)` never returns null? --- If your project is set up for it, you can reply to

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155410755 It was put in there explicitely (return null;) so i trusted the intention. a review of the architecture could be justified. --- If your project is set up for

[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1053 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1055#issuecomment-155412998 @DaanHoogland sent me the below patch the other day and I run some tests on it. Just FYI the results (he rebased later and made a PR). The commit hash

Re: [GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread Daan Hoogland
sure On Tue, Nov 10, 2015 at 1:47 PM, miguelaferreira wrote: > Github user miguelaferreira commented on the pull request: > > https://github.com/apache/cloudstack/pull/1056#issuecomment-155411442 > > That intention opens up an entire category of errors, null >

"Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
Issue while adding XS host, I get this "Unable to add the host" in the UI. I am have pool and pool master configured, XS is with local storage, CS logs is as follows, am I missing something? WARN [c.c.a.d.ParamGenericValidationWorker] (615054626@qtp-36819918-8:ctx-1a6ba54a ctx-73611d66)

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
In more recent versions of CloudStack, you have to add the XenServer host to its Resource Pool before adding it to its CloudStack cluster. Were you trying to do it that way? On Tue, Nov 10, 2015 at 6:23 PM, B Prakash wrote: > Issue while adding XS host, I get this "Unable to

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
Thanks Mike. I have added the host to its resource pool with the same host as pool master. I am able to ping XS host and the machine running CS. But when I try to configuring the XS host in CS, it doesnt identify the host ip. Thanks, Prakash. From:

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Which versions of XS and CloudStack are you running? On Tue, Nov 10, 2015 at 7:00 PM, B Prakash wrote: > Thanks Mike. I have added the host to its resource pool with the same > host as pool master. I am able to ping XS host and the machine running > CS. But when I try to

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
I am running XS 6.5 and CS 4.6. XS is on virtualbox. CS 4.6 is built/run on windows 10. From: Mike Tutkowski Sent: Tuesday, November 10, 2015 9:14 PM To: dev@cloudstack.apache.org Subject: Re: "Unable to add the host"

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Are you adding this host to a cluster in a basic zone? If so, have you run this command on your XS host? xe-switch-network-backend bridge On Tue, Nov 10, 2015 at 7:22 PM, B Prakash wrote: > I am running XS 6.5 and CS 4.6. XS is on virtualbox. CS 4.6 is built/run > on

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155386360 Thanks, @ustcweizhou ... this PR LGTM :+1: @remibergsma, I believe it's ready to be merged. Cheers, Wilder --- If your project is

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1055#issuecomment-155391693 LGTM, based on a set of tests that I run on this branch (which I rebased myself first): ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland opened a pull request: https://github.com/apache/cloudstack/pull/1055 CLOUDSTACK-9023 filtering privatekey info from logging tested off-line but rebased afterwards! You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1034 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread DaanHoogland
GitHub user DaanHoogland reopened a pull request: https://github.com/apache/cloudstack/pull/1055 CLOUDSTACK-9023 filtering privatekey info from logging tested off-line but rebased afterwards! You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-155396401 @nvazquez I've built and tested your PR in our environment and the functionality we have tests for remains stable. :+1: What I did: 1.

[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-10 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1053#issuecomment-155398572 verified in spanish and english that that UI loads fine. did not see any js errors in spanish. LGTM :+1: --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread davidamorimfaria
Github user davidamorimfaria commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155389434 squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request: Fix some small UI bugs

2015-11-10 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/1034#issuecomment-155389974 Thanks @ustcweizhou LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [Proposal] Template for CloudStack API Reference Pages

2015-11-10 Thread Daejuan Jacobs
I assume by "Format" you mean data type. But I think this looks good. It's simple, yet it manages to nail all the points you need when developing on a software's API. On Tue, Nov 10, 2015 at 8:33 AM Rajsekhar K wrote: > Hi, All, > > This is the proposal for a new

Re: [VOTE] Apache CloudStack 4.6.0 (round 2)

2015-11-10 Thread Wilder Rodrigues
Morning all, First round of tests - KVM - went fine. I will now test XenServer 6.2. Please, find my test report. Cheers, Wilder :: Summary :: * Tests executes: 74 * Successfull tests: 73 * Skipped tests: 1(*) * Failed tests: 0 :: Environment 1 :: * Hardware required: TRUE * Management

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155694568 @miguelaferreira Optional is very clear indeed. So is exception handling. When you need to handle a possible null return one level deep optional is fine.

[GitHub] cloudstack pull request: CID-1338387: handle unknown storage endpo...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155679945 We don't need Java 8 to use optional. And yes, optional is meant for expressing that a value may be present or not. The API is quite clear, I don't see the

Re: Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Also, mirroring is probably not the best term. We are not mirroring the build artifacts from the official build servers. We are attempting to deploy artifacts produced by our build system into Archiva. On Tue, Nov 10, 2015 at 2:23 PM, Jeff Hair wrote: > Hi, > > We are

[Proposal] Template for CloudStack API Reference Pages

2015-11-10 Thread Rajsekhar K
Hi, All, This is the proposal for a new template for CloudStack API reference pages. This template is based on the reference page templates for REST APIs. Please find attached the following documents for your review: - Template for normal and asynchronous CloudStack API references. -

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1055 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155405695 Executed a few tests just to see if it actually does something: ``` Test advanced zone virtual router ... === TestName: test_advZoneVirtualRouter |

[GitHub] cloudstack pull request: CLOUDSTACK-9049: fix Centos7 with Tomcat7...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1052#issuecomment-155406515 Verified with @dahn that `cloudstack-management` started on CentOS 6 as well and that he was able to use the UI. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: Fix the new line bug (invalid char on UI)...

2015-11-10 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1053#issuecomment-155410386 going to trust the translator: lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1055#issuecomment-155410264 I'm testing this PR with a 2 KVM host setup to run a set of basic Marvin tests. Will also grep the logs for the private key. --- If your project is set up

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155411442 That intention opens up an entire category of errors, null dereferencing). In addition forces defensive coding, just like what you introduce in this PR.

cloudstack vulnerable by COLLECTIONS-580?

2015-11-10 Thread Rene Moser
Hi This security issue came to my attention: https://issues.apache.org/jira/browse/COLLECTIONS-580 See http://foxglovesecurity.com/2015/11/06/what-do-weblogic-websphere-jboss-jenkins-opennms-and-your-application-have-in-common-this-vulnerability/ for more background information. I am not sure

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1055#issuecomment-155431369 JVM died: ``` Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.324 sec - in org.apache.cloudstack.privategw.AclOnPrivateGwTest

Mirroring CloudStack to internal MVN repository

2015-11-10 Thread Jeff Hair
Hi, We are setting up an internal Maven repository to speed up our inhouse builds that depend on CloudStack on the 4.5 branch (which contains 4.5.3-SNAPSHOT right now). It's mostly working, but we are running into something very strange with the checkstyle dependency. After uploading all

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Remi Bergsma
Make sure management server can talk to the xenserver (xapi) over port 443 (firewalls?). Right now it says it cannot due to a timeout: Failed to read server's response: connect timed out @mike From the logs this seems the first host to be added to this zone. Sent from my iPhone > On 11 Nov

[GitHub] cloudstack-docs-install pull request: include argument for tomcat7...

2015-11-10 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack-docs-install/pull/24#issuecomment-155416905 LGTM, we need to update the doc for 4.6.0 this PR must be in the 4.6 branch of the doc and master. --- If your project is set up for it, you can

[GitHub] cloudstack pull request: CLOUDSTACK-9023 filtering privatekey info...

2015-11-10 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1055#issuecomment-155426180 Jenkins error seems unrelated: ``` [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.18.1:test (default-test) on

[GitHub] cloudstack pull request: CID-1338387: paranoia null checking

2015-11-10 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/1056#issuecomment-155415964 @DaanHoogland I agree with @miguelaferreira. I have looked that code. The select it runs is the following: select h.id from host h where

[GitHub] cloudstack pull request: CLOUDSTACK-8956: NSX/Nicira Plugin does n...

2015-11-10 Thread nvazquez
Github user nvazquez commented on the pull request: https://github.com/apache/cloudstack/pull/935#issuecomment-155418071 @wilderrodrigues Thanks a lot Wilder! @miguelaferreira Thanks for following this PR and testing it! --- If your project is set up for it, you can reply to

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
There are two more exceptions printed in vmops.log as follows; 2015-11-10 19:12:55,075 DEBUG [c.c.a.ApiServlet] (1034892751@qtp-1967400458-7:ctx-23ec1109) ===START=== 0:0:0:0:0:0:0:1 -- POST command=addHost=json 2015-11-10 19:12:55,124 WARN [c.c.a.d.ParamGenericValidationWorker]

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread B Prakash
I am adding this host to cluster in basic zone. I had bridge adapter for network, I also ran this command. My CS still doesnt identify XS host ip. From: Mike Tutkowski Sent: Tuesday, November 10, 2015 9:39 PM To:

Re: "Unable to add the host" error, CS host XS

2015-11-10 Thread Mike Tutkowski
Are there several exceptions printed out in vmops.log or just the one you posted in your original e-mail? On Tue, Nov 10, 2015 at 8:15 PM, B Prakash wrote: > I am adding this host to cluster in basic zone. I had bridge adapter for > network, I also ran this command. My CS

  1   2   >