[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[koushik-das]

Github user koushik-das commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@abhinandanprateek In latest master the sequence of event described above 
only happens when the host has been determined as 'Down'. Refer to the below 
code. So the bug described won't happen. Earlier even when host state was 
'Alert' the same sequence used to get triggered which possibly killed healthy 
VMs.

> if (host != null && host.getStatus() == Status.Down) {
> _haMgr.scheduleRestartForVmsOnHost(host, true);
> }

In case there is still a possibility of healthy VMs getting killed then the 
scenario needs to be clearly identified. If we need to fix anything, the first 
thing would be look at improving the VM investigators rather than changing the 
existing fencing logic.

If we go ahead with the above fix then I can think of the following 
scenario that is broken. In case of a genuine host down scenario non-HA VMs 
continue to remain in 'Running' state and no operations can be done on it. 
Currently non-HA VMs are marked as 'Stopped' after fencing is successful and 
they can be manually started on another host.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

[lmrv]

Github user lmrv commented on the issue:

https://github.com/apache/cloudstack/pull/1637
  
Hi Resmo,

Correct. Most net commands are now replace by the ip command.

ip link set dev eth0 up
ip route
ip add
etc.

In our case, the ifconfig is not used by cloudstack-setup-agent, but the 
route one is. This cause the setup-agent to crash if route is not installed 
before. 

Making the change can help deployment on CentOS7 and should work on CentOS6 
out of the box.
 
Lots of changes have been made regardings the net on CentOS7. You should 
now use nmtui in replacement of the system-config-network-tui by example.

Regards.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[karuturi]

Github user karuturi commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@jburwell No I didnt. As I said in the other PR, I only have a xenserver 
environment(my test run was only to see it didnt cause any regressions). If you 
can get a KVM environment running, which can run the test suite, that would be 
great. 




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@jburwell @koushik-das @marcaurele When MS is unable to determine the state 
of the VM, Or it thinks VM requires a HA operation then it issues a stop 
command as part of fence operation.
The affect of this is to clean up the resources on the MS and keep the 
resource book keeping on MS in tack. This has the potential to kill a healthy 
VM in some boundary cases. We need to fix these boundary cases.
In case this cleanup/fence operation does not happen on MS then the 
resource allocation on MS will be not in sync with the actual capacity causes 
further complications and issues.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
@abhinandanprateek I believe Github now allows you to modify a PR to point 
to another target branch.  @rhtyd is my recollection correct?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[abhinandanprateek]

Github user abhinandanprateek commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
@jburwell should i open a new PR for 4.8 branch ? I think it should be easy 
and good for 4.8 too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Upcoming 4.8, 4.9, and master Freeze

[John Burwell]

All,

The 4.8.2.0 and 4.9.1.0 releases have taken more time than expected to 
finalize.  Per our original schedule [1], 4.9.2.0 and 4.10.0.0 were scheduled 
to freeze yesterday (18 September 2016).  I propose the following schedule and 
end-of-life (EOL) changes:

* 4.8.2.0 is still open, but 4.8 EOL is scheduled for 19 September 2016.  I 
propose freezing the 4.8 branch this Sunday, 25 Sept 2016, and extending the 
EOL to 31 October 2016.  This extension will provide 4.8 users with a slightly 
longer support period to compensate the schedule delays.  With one week to test 
and one week for RC voting, the 4.10.0.0 release date would be pushed out to 10 
October 2016.
* Since we are still working to close out 4.9.1.0, I am proposing that we 
combine 4.9.1.0 and 4.9.2.0 into the 4.9.1.0 release, and extend the freeze 
date to 25 Sept 2016 in order to close out open issues.  With one week to test 
and one week for RC voting, the 4.10.0.0 release date would be pushed out to 10 
October 2016.
* Extend the 4.10.0.0 freeze date by one (1) week to this Sunday, 25 Sept 
2016.  With one week to test and one week for RC voting, the 4.10.0.0 release 
date would be pushed out to 10 October 2016.

Assuming these changes are acceptable, i will update the release schedule [1] 
to reflect the new dates and cascade the changes out to future releases by COB 
Monday (19 Sept 2016).

I have captured a list of open PRs and JIRA tickets to target for 4.8.2.0, 
4.9.1.0, and 4.10.0.0 in a Google Sheet [2].  Please review and let me know if 
any additional items should be added.  Of note, we have two potential blockers 
for all three (3) releases — CLOUDSTACK-9489 [3] and CLOUDSTACK-9497 [4].  
Finally, except for blockers, these are best effort targets.  If they are not 
closed out by 25 Sept 2016, the release branches will be frozen and any open 
PRs will be deferred to the next release cycle.

Thanks,
-John

[1]: 
https://cwiki.apache.org/confluence/display/CLOUDSTACK/%5BPROPOSAL%5D+2016-2017+Release+Cycle+and+Calendar
[2]: 
https://docs.google.com/spreadsheets/d/1N9Mrg-RQZRch3x2BoRutGQKija_TnQC5tnaNOWy0IuY/edit?usp=sharing
[3]: https://issues.apache.org/jira/browse/CLOUDSTACK-9489
[4]: https://issues.apache.org/jira/browse/CLOUDSTACK-9497


john.burw...@shapeblue.com 
www.shapeblue.com
53 Chandos Place, Covent Garden, London VA WC2N 4HSUK
@shapeblue
  
 

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

[mike-tutkowski]

Github user mike-tutkowski commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
@jburwell Let me provide a bit of additional background for this PR.

As noted in the initial comment, it was possible to spin up system VMs on 
managed storage prior to this PR.

This PR adds three items:

1) There are a couple checks added when creating a system offering that 
uses managed storage. For example, it doesn't really make sense to allow 
"custom IOPS" and now we prevent that if you try to create a system offering as 
such.

2) If you transition managed storage into maintenance mode and system VMs 
were running on that managed storage, the host-side clustered file systems (SRs 
on XenServer) were not removed. This is not a big issue since putting a managed 
storage like a SAN in maintenance mode is not too likely.

I added a call to a method that removes these client-side file systems, if 
you're using managed storage. In the event of any failure here, I catch the 
exception, print an error message to the log, and allow the storage-cleanup 
thread to continue its tasks.

3) I added an extensive set of tests with regards to system VMs on managed 
storage.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...

[kiwiflyer]

Github user kiwiflyer commented on the issue:

https://github.com/apache/cloudstack/pull/1644
  
@jburwell We found an issue on Friday related to a use case related to 
snapshot to template. We're working on it. More soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1673#discussion_r79316781
  
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -285,9 +286,15 @@ private void init(Map configs) {
 s_logger.info(scheme + " is not a valid protocol for 
external statistics. No statistics will be send.");
--- End diff --

I realize it is out of scope for this PR, but would mind changing the log 
level to ``WARN`` for this message?  It is clearly a user intent that is not 
going to be carried through due to bad configuration data.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1644: Honors the snapshot.backup.rightafter configuration ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1644
  
@kiwiflyer could you please post the detailed test results included the 
environment specification?  

@nathanejohnson have you had a chance to investigate the failures from the 
@bvbharatk's test tun?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1650
  
@PaulAngus this issue seems to affect 4.8+.  Since we have one more 4.8 
(4.8.2.0) release, it would be nice to have this fix for those test runs.  
Therefore, could you re-point it to the 4.8 branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1642: System VMs on Managed Storage

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1642
  
@mike-tutkowski @karuturi it seems like this PR should have all smoke tests 
+ system VM integration test suites (SSVM, CPVM, and VR) + the new test 
integration test suite added for this PR run on XenServer.  Additionally, all 
smoke tests + system VM integration test suites (SSVM, CPVM, and VR) should be 
run on VMware and KVM as a regression test.  These tests do not have to be run 
in the same environment or person.  I would just like see results for all of 
these scenarios from posted to this PR.  Does that make sense?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1645: On snapshot backup, this converts the rbd raw format...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1645
  
@karuturi was this PR tested on KVM?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1664: CLOUDSTACK-8676 Deploy user instance from vm snapsho...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1664
  
@sateesh-chodapuneedi have you @nitt10prashant worked out combining the 
Marvin tests with this PR?  Also, please investigate the Travis CI failures.  
Finally, have you had a chance to address @rhtyd's feedback regarding large 
methods and unit tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails for 12 m...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/798
  
This bug would be a good fix to include for LTS.  Therefore, it should be 
re-targeted to the 4.9 branch.

@nvazquez are you planning to pick up this PR?  If not, I can get someone 
to pick it up in the next 1-2 weeks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/798#discussion_r79315858
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
 private static String getVolumeRelativeDirInSecStroage(long volumeId) {
 return "volumes/" + volumeId;
 }
+
+/**
+ * This method is to check if a given TaskInfo Object is valid( and 
has name and entity name assigned).It return true if TaskInfo Object is valid 
and false otherwise.
+ *
+ * @param TaskInfo
+ *info
+ * @return boolean(true or false)
+ **/
+private boolean isvalidTaskInfoObj(TaskInfo info){
+return !(info == null || info.getEntityName() == null || 
info.getName() == null);
+}
+
+/**
+ * This method waits for tasks running on vm to complete
+ *
+ * @param vmNameName of the vm
+ * @param taskName  Name of the task
+ * @param context   Task context object
+ * 
+ * @return boolean(true or false)   True if it waited for tasks to 
finish and false when there are no tasks running on the Vm.
+ **/
+ 
+private boolean waitForRunningTaskOnVM(String vmName, String taskName, 
VmwareContext context) throws Exception {
+try {
+ManagedObjectReference taskmgr = 
context.getServiceContent().getTaskManager();
+List tasks = 
context.getVimClient().getDynamicProperty(taskmgr, "recentTask");
+
+for (ManagedObjectReference taskMor : tasks) {
+TaskInfo info = 
(TaskInfo)(context.getVimClient().getDynamicProperty(taskMor, "info"));
+
+if (!isvalidTaskInfoObj(info)) {
+continue;
+}
+
+if (info.getEntityName().equals(vmName) && 
info.getName().equalsIgnoreCase(taskName)) {
+if (!(info.getState().equals(TaskInfoState.SUCCESS) || 
info.getState().equals(TaskInfoState.ERROR))) {
+s_logger.debug("There is already a task: " + 
taskName + " running for VM: " + vmName + ", wait for it");
+// wait if there is already similar VM task running
+context.getVimClient().waitForTask(taskMor);
+return true;
+}
+}
+}
+
+return false;
+} catch (Exception e) {
--- End diff --

Why are all checked and unchecked exceptions being caught here?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/798#discussion_r79315873
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
 private static String getVolumeRelativeDirInSecStroage(long volumeId) {
 return "volumes/" + volumeId;
 }
+
+/**
+ * This method is to check if a given TaskInfo Object is valid( and 
has name and entity name assigned).It return true if TaskInfo Object is valid 
and false otherwise.
+ *
+ * @param TaskInfo
+ *info
+ * @return boolean(true or false)
+ **/
+private boolean isvalidTaskInfoObj(TaskInfo info){
+return !(info == null || info.getEntityName() == null || 
info.getName() == null);
+}
+
+/**
+ * This method waits for tasks running on vm to complete
+ *
+ * @param vmNameName of the vm
+ * @param taskName  Name of the task
+ * @param context   Task context object
+ * 
+ * @return boolean(true or false)   True if it waited for tasks to 
finish and false when there are no tasks running on the Vm.
+ **/
+ 
+private boolean waitForRunningTaskOnVM(String vmName, String taskName, 
VmwareContext context) throws Exception {
+try {
+ManagedObjectReference taskmgr = 
context.getServiceContent().getTaskManager();
+List tasks = 
context.getVimClient().getDynamicProperty(taskmgr, "recentTask");
+
+for (ManagedObjectReference taskMor : tasks) {
+TaskInfo info = 
(TaskInfo)(context.getVimClient().getDynamicProperty(taskMor, "info"));
+
+if (!isvalidTaskInfoObj(info)) {
+continue;
+}
+
+if (info.getEntityName().equals(vmName) && 
info.getName().equalsIgnoreCase(taskName)) {
+if (!(info.getState().equals(TaskInfoState.SUCCESS) || 
info.getState().equals(TaskInfoState.ERROR))) {
+s_logger.debug("There is already a task: " + 
taskName + " running for VM: " + vmName + ", wait for it");
+// wait if there is already similar VM task running
+context.getVimClient().waitForTask(taskMor);
+return true;
+}
+}
+}
+
+return false;
+} catch (Exception e) {
+String msg = "Failed to check running task: " + taskName + " 
for vm: " + vmName + " due to " + e.getMessage();
+s_logger.error(msg, e);
+throw new Exception(msg);
--- End diff --

`Exception` is a generic type, and, generally, should not be thrown.  I 
would recommend `IllegalStateException` here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/798#discussion_r79315898
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
 private static String getVolumeRelativeDirInSecStroage(long volumeId) {
 return "volumes/" + volumeId;
 }
+
+/**
+ * This method is to check if a given TaskInfo Object is valid( and 
has name and entity name assigned).It return true if TaskInfo Object is valid 
and false otherwise.
+ *
+ * @param TaskInfo
+ *info
+ * @return boolean(true or false)
+ **/
+private boolean isvalidTaskInfoObj(TaskInfo info){
+return !(info == null || info.getEntityName() == null || 
info.getName() == null);
+}
+
+/**
+ * This method waits for tasks running on vm to complete
+ *
+ * @param vmNameName of the vm
+ * @param taskName  Name of the task
+ * @param context   Task context object
+ * 
+ * @return boolean(true or false)   True if it waited for tasks to 
finish and false when there are no tasks running on the Vm.
+ **/
+ 
+private boolean waitForRunningTaskOnVM(String vmName, String taskName, 
VmwareContext context) throws Exception {
+try {
+ManagedObjectReference taskmgr = 
context.getServiceContent().getTaskManager();
+List tasks = 
context.getVimClient().getDynamicProperty(taskmgr, "recentTask");
+
+for (ManagedObjectReference taskMor : tasks) {
+TaskInfo info = 
(TaskInfo)(context.getVimClient().getDynamicProperty(taskMor, "info"));
+
+if (!isvalidTaskInfoObj(info)) {
+continue;
+}
+
+if (info.getEntityName().equals(vmName) && 
info.getName().equalsIgnoreCase(taskName)) {
+if (!(info.getState().equals(TaskInfoState.SUCCESS) || 
info.getState().equals(TaskInfoState.ERROR))) {
+s_logger.debug("There is already a task: " + 
taskName + " running for VM: " + vmName + ", wait for it");
--- End diff --

Please wrap this statement in an `if (s_logger.isDebugEnabled())` check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/798#discussion_r79315948
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
 private static String getVolumeRelativeDirInSecStroage(long volumeId) {
 return "volumes/" + volumeId;
 }
+
+/**
+ * This method is to check if a given TaskInfo Object is valid( and 
has name and entity name assigned).It return true if TaskInfo Object is valid 
and false otherwise.
+ *
+ * @param TaskInfo
+ *info
+ * @return boolean(true or false)
+ **/
+private boolean isvalidTaskInfoObj(TaskInfo info){
--- End diff --

Why is this method necessary?  It is a one line boolean result that is 
called from one place.  It seems to obfuscate more than clarify.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/798#discussion_r79315938
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
 private static String getVolumeRelativeDirInSecStroage(long volumeId) {
 return "volumes/" + volumeId;
 }
+
+/**
+ * This method is to check if a given TaskInfo Object is valid( and 
has name and entity name assigned).It return true if TaskInfo Object is valid 
and false otherwise.
+ *
+ * @param TaskInfo
+ *info
+ * @return boolean(true or false)
+ **/
+private boolean isvalidTaskInfoObj(TaskInfo info){
+return !(info == null || info.getEntityName() == null || 
info.getName() == null);
--- End diff --

Please check `info.getEntityName()` and `info.getName()` with 
StringUtils.isBlank() rather than a simple `null` check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #798: CLOUDSTACK-8830 - [Vmware] VM snapshot fails f...

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/798#discussion_r79315920
  
--- Diff: 
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/manager/VmwareStorageManagerImpl.java
 ---
@@ -1464,4 +1448,55 @@ private String deleteDir(String dir) {
 private static String getVolumeRelativeDirInSecStroage(long volumeId) {
 return "volumes/" + volumeId;
 }
+
+/**
+ * This method is to check if a given TaskInfo Object is valid( and 
has name and entity name assigned).It return true if TaskInfo Object is valid 
and false otherwise.
+ *
+ * @param TaskInfo
+ *info
+ * @return boolean(true or false)
+ **/
+private boolean isvalidTaskInfoObj(TaskInfo info){
+return !(info == null || info.getEntityName() == null || 
info.getName() == null);
+}
+
+/**
+ * This method waits for tasks running on vm to complete
+ *
+ * @param vmNameName of the vm
+ * @param taskName  Name of the task
+ * @param context   Task context object
+ * 
+ * @return boolean(true or false)   True if it waited for tasks to 
finish and false when there are no tasks running on the Vm.
+ **/
+ 
+private boolean waitForRunningTaskOnVM(String vmName, String taskName, 
VmwareContext context) throws Exception {
--- End diff --

Throwing `Exception` is an anti-pattern and should be avoided.  Either 
throw a custom checked exception with contextual information and transform all 
checked exceptions to unchecked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1602: CLOUDSTACK-9422: Granular 'vmware.create.full.clone'...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1602
  
@serg38 @nvazquez I will merge this PR when I get into the office on Monday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

[resmo]

Github user resmo commented on the issue:

https://github.com/apache/cloudstack/pull/1637
  
speaking about things not available per default on CentOS 7 --> `ifconfig`. 
Found 1 or 2 of these as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

[lmrv]

Github user lmrv commented on the issue:

https://github.com/apache/cloudstack/pull/1637
  
I will need your help John.
Ok for JIRA ticket but I don't know how to squash my commits, how to 
retarget my pull request.
I am not confortable at all with github.
And for Jenkis, no more skill...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

[lmrv]

Github user lmrv commented on the issue:

https://github.com/apache/cloudstack/pull/1637
  
Hi John,
I just create the JIRA ISSUE : 
https://issues.apache.org/jira/browse/CLOUDSTACK-9501


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Replacing the VR

[Will Stevens]

At this point in the discussion, I don't think we should rule anything out.
I think it makes sense to explore all the options and then isolate some
front runners in terms of software and architecture.

On Sep 18, 2016 1:08 AM, "ilya"  wrote:

> Our options become much better if we consider BSD based routers.
>
> Would that be on the table?
>
> https://en.wikipedia.org/wiki/List_of_router_and_firewall_distributions
>
>
> On 9/16/16 12:04 PM, Will Stevens wrote:
> > Ya, your points are all valid Simon.  The lack of standard libraries to
> > handle a lot of the details is a problem.  I don't think it is an
> > unsolvable problem, but if we spend the time to do that, will we have
> > something that will work for us for the next 5 years?  This may be the
> > shortest path to getting us where we need to be for the time being.
> >
> > What is the best case scenario for the VR going forward which will last
> us
> > the next 5 years?  Maybe we just clean up what we have to do a major
> > restructuring of the pieces and how they are implemented.  We need to
> keep
> > in mind how maintainable this implementation is because that is going to
> be
> > key going forward IMO.
> >
> >
> >
> > *Will STEVENS*
> > Lead Developer
> >
> > *CloudOps* *| *Cloud Solutions Experts
> > 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6
> > w cloudops.com *|* tw @CloudOps_
> >
> > On Fri, Sep 16, 2016 at 2:29 PM, Simon Weller  wrote:
> >
> >> I think our other option is to take a real look at what it would take to
> >> fix the VR. In my opinion, a lot of the problems are related to the
> >> monolithic python code base and the fact nothing is actually separated.
> >>
> >> Secondly, the python scripts (and bash scripts) don't use any
> established
> >> libraries to complete tasks and instead shell out and run commands that
> are
> >> both hard to track and hard to parse on return.
> >>
> >>
> >> If we daemonized this, used a real api for Agent to VR communication,
> used
> >> common already existing libraries for the system service and network
> >> interactions and spent a bit of time separating out code into distinct
> >> modules, everything would behave a lot better.
> >>
> >>
> >> The pain and suffering is due to years and years of patches and constant
> >> shelling out to complete tasks in my opinion. If we spend time to
> rethink
> >> how we interact with the VR in general and we abstract the systems and
> >> networking stuff and use well known and stable libraries to do the work,
> >> the VR would be much easier to maintain.
> >>
> >>
> >> - Si
> >>
> >>
> >>
> >>
> >> 
> >> From: Marty Godsey 
> >> Sent: Friday, September 16, 2016 12:24 PM
> >> To: dev@cloudstack.apache.org
> >> Subject: RE: [DISCUSS] Replacing the VR
> >>
> >> So based upon this discussion would it be prudent to wait on VyOS 2.0?
> The
> >> current VR is giving us issues but would the time invested in another
> >> "solution" be wasted especially if by the time another option is chose,
> >> then coded, then tested, then implemented and right as that time
> happened
> >> to be when VyOS 2.0 is released.  Of course you said they are just in
> the
> >> scoping range so this could still be a year or more out.
> >>
> >> Thoughts?
> >>
> >> Regards,
> >> Marty Godsey
> >> nSource Solutions
> >>
> >> -Original Message-
> >> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On
> >> Behalf Of Will Stevens
> >> Sent: Friday, September 16, 2016 10:31 AM
> >> To: dev@cloudstack.apache.org
> >> Cc: dan...@baturin.org
> >> Subject: Re: [DISCUSS] Replacing the VR
> >>
> >> I just had a quick chat with a couple of the guys over on the VyOS chat.
> >> I have CC'ed one of them in case we have more licensing questions.
> >>
> >> So here is the status with the license "the code inherited from Vyatta
> and
> >> our modifications from it is GPLv2 (strict, not v2+). The config reading
> >> library is GPLv2 too, so anything that links to is is GPLv2.
> >> Some auxiliary components we made after the fork are more permissive,
> >> LGPLv2+ or MIT."
> >>
> >> They are currently in the process of scoping a redesign (VyOS 2.0), "we
> >> are planning a clean rewrite that will solve issues of the current
> config
> >> system".
> >> This will include the ability to configure via the API.
> >>
> >> If we have more questions for VyOS, they are very friendly and
> responsive,
> >> so we should be able to get answers.
> >>
> >> *Will STEVENS*
> >> Lead Developer
> >>
> >> *CloudOps* *| *Cloud Solutions Experts
> >> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw
> >> @CloudOps_
> >>
> >> On Fri, Sep 16, 2016 at 9:37 AM, Syed Ahmed 
> wrote:
> >>
> >>> I agree with Will Ilya. There are so many problems with the VR right
> now.
> >>> Most of the outages we've had recently have somehow involved the VR.
> >>> We set custom iptables rules on 

[GitHub] cloudstack issue #1643: CLOUDSTACK-9460: For long running transactions, if t...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1643
  
@abhinandanprateek this fix seems like it would also be beneficial for 
4.8.2.0.  How difficult would it be to re-target it to the 4.8 branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1640: CLOUDSTACK-9458: Fix HA bug when VMs are stopped on ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1640
  
@abhinandanprateek @koushik-das @marcaurele have you been able to come to 
agreement about the correct functionality for this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1659: CLOUDSTACK-9339 Virtual Routers don't handle Multipl...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1659
  
@murali-reddy what is the status of addressing the review feedback.  Also, 
have addressed the VPC-related issues as well?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1591: Updating Alert codes

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1591
  
@rhtyd have you had a chance to analyze?  I would like to include this 
change in 4.9.1.0 and 4.10.0.0 for which we are planning to cut RCs on 25 Sept 
2016.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1606: Allow CGN (RFC6598) to be used within a VPC

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1606
  
@leprechau I would like to get this fix into 4.8.2.0, 4.9.1.0, and 
4.10.0.0.  Have you had a chance to add the unit tests requested?  Also, is 
there a JIRA ticket for this bug?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1623: CLOUDSTACK-9317: Enable/disable static NAT associate...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1623
  
@ProjectMoon I am extending the date for 4.8 to 25 Sept 2016.  Therefore, 
if we can get the test failure fixed, we can get it into 4.8.2.0, 4.9.1.0, and 
4.10.0.0.  Also, could you please investigate the Travis and Jenkins build 
failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1624: Fixes regarding VOLUME_DELETE events resulting from ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1624
  
@ProjectMoon I want to get this PR into 4.8.2.0, 4.9.1.0, and 4.10.0.0 for 
which we will be cutting RCs on 25 Sept 2016.  Tests should be the entire 
Marvin smoke test suite against VMware, KVM, and XenServer, as well as, the 
`test_account` component test.

Also, is it possible to automate the test procedure described in the 
description?  Given the amount of change in the project, we want to keep manual 
testing to an absolute minimum.

Finally, is there a JIRA ticket for this bug?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1637
  
@lmrv I would like to include this PR in the upcoming 4.8.2.0, 4.9.1.0, and 
4.10.0.0 releases.  In order to merge it, the following items need to be 
addressed:

* [ ] Squash commits
* [ ] Investigate/fix Jenkins build failures
* [ ] Re-target this PR to the 4.8 branch.  It will be forward merged to 
4.9 and master as part of the PR merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

RE: [DISCUSS] Replacing the VR

[Marty Godsey]

On this note I also mentioned pfsense earlier.

www.pfsense.org


Regards,
Marty Godsey

-Original Message-
From: ilya [mailto:ilya.mailing.li...@gmail.com] 
Sent: Sunday, September 18, 2016 1:09 AM
To: dev@cloudstack.apache.org
Subject: Re: [DISCUSS] Replacing the VR

Our options become much better if we consider BSD based routers.

Would that be on the table?

https://en.wikipedia.org/wiki/List_of_router_and_firewall_distributions


On 9/16/16 12:04 PM, Will Stevens wrote:
> Ya, your points are all valid Simon.  The lack of standard libraries 
> to handle a lot of the details is a problem.  I don't think it is an 
> unsolvable problem, but if we spend the time to do that, will we have 
> something that will work for us for the next 5 years?  This may be the 
> shortest path to getting us where we need to be for the time being.
> 
> What is the best case scenario for the VR going forward which will 
> last us the next 5 years?  Maybe we just clean up what we have to do a 
> major restructuring of the pieces and how they are implemented.  We 
> need to keep in mind how maintainable this implementation is because 
> that is going to be key going forward IMO.
> 
> 
> 
> *Will STEVENS*
> Lead Developer
> 
> *CloudOps* *| *Cloud Solutions Experts
> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw 
> @CloudOps_
> 
> On Fri, Sep 16, 2016 at 2:29 PM, Simon Weller  wrote:
> 
>> I think our other option is to take a real look at what it would take 
>> to fix the VR. In my opinion, a lot of the problems are related to 
>> the monolithic python code base and the fact nothing is actually separated.
>>
>> Secondly, the python scripts (and bash scripts) don't use any 
>> established libraries to complete tasks and instead shell out and run 
>> commands that are both hard to track and hard to parse on return.
>>
>>
>> If we daemonized this, used a real api for Agent to VR communication, 
>> used common already existing libraries for the system service and 
>> network interactions and spent a bit of time separating out code into 
>> distinct modules, everything would behave a lot better.
>>
>>
>> The pain and suffering is due to years and years of patches and 
>> constant shelling out to complete tasks in my opinion. If we spend 
>> time to rethink how we interact with the VR in general and we 
>> abstract the systems and networking stuff and use well known and 
>> stable libraries to do the work, the VR would be much easier to maintain.
>>
>>
>> - Si
>>
>>
>>
>>
>> 
>> From: Marty Godsey 
>> Sent: Friday, September 16, 2016 12:24 PM
>> To: dev@cloudstack.apache.org
>> Subject: RE: [DISCUSS] Replacing the VR
>>
>> So based upon this discussion would it be prudent to wait on VyOS 
>> 2.0? The current VR is giving us issues but would the time invested 
>> in another "solution" be wasted especially if by the time another 
>> option is chose, then coded, then tested, then implemented and right 
>> as that time happened to be when VyOS 2.0 is released.  Of course you 
>> said they are just in the scoping range so this could still be a year or 
>> more out.
>>
>> Thoughts?
>>
>> Regards,
>> Marty Godsey
>> nSource Solutions
>>
>> -Original Message-
>> From: williamstev...@gmail.com [mailto:williamstev...@gmail.com] On 
>> Behalf Of Will Stevens
>> Sent: Friday, September 16, 2016 10:31 AM
>> To: dev@cloudstack.apache.org
>> Cc: dan...@baturin.org
>> Subject: Re: [DISCUSS] Replacing the VR
>>
>> I just had a quick chat with a couple of the guys over on the VyOS chat.
>> I have CC'ed one of them in case we have more licensing questions.
>>
>> So here is the status with the license "the code inherited from 
>> Vyatta and our modifications from it is GPLv2 (strict, not v2+). The 
>> config reading library is GPLv2 too, so anything that links to is is GPLv2.
>> Some auxiliary components we made after the fork are more permissive,
>> LGPLv2+ or MIT."
>>
>> They are currently in the process of scoping a redesign (VyOS 2.0), 
>> "we are planning a clean rewrite that will solve issues of the 
>> current config system".
>> This will include the ability to configure via the API.
>>
>> If we have more questions for VyOS, they are very friendly and 
>> responsive, so we should be able to get answers.
>>
>> *Will STEVENS*
>> Lead Developer
>>
>> *CloudOps* *| *Cloud Solutions Experts
>> 420 rue Guy *|* Montreal *|* Quebec *|* H3J 1S6 w cloudops.com *|* tw 
>> @CloudOps_
>>
>> On Fri, Sep 16, 2016 at 9:37 AM, Syed Ahmed  wrote:
>>
>>> I agree with Will Ilya. There are so many problems with the VR right now.
>>> Most of the outages we've had recently have somehow involved the VR.
>>> We set custom iptables rules on the VR which can and have easily 
>>> gone
>> wrong.
>>> Openswan is broken, Strongswan replacement still needs to be tested.
>>> VVRP with redundant router still needs work, and not to mention the 
>>> 

[GitHub] cloudstack issue #1639: CLOUDSTACK-9453: WIP : Marvin optimizations and fixe...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1639
  
@abhinandanprateek ping regarding the Travis and Jenkins failures.  I would 
like to include this PR in the upcoming 4.8.2.0, 4.9.1.0, and 4.10.0.0 releases 
for which we plan to cut an RC on 25 Sept 2016.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1560: CLOUDSTACK-9386: DS template copies don’t get dele...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1560
  
@serg38 @nvazquez I just noticed that this bug was merged to master, but it 
should also be included in LTS  My thinking is that we rollback this commit 
from master, re-open this PR against the 4.9 release branch, and then re-merge 
it.  Does this make sense?  If so, @serg38 would you be able to quickly re-test 
it against 4.9?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1655: Fix ajaxviewer.js to solve console on Firefox

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1655
  
@lygutas I would like to get this PR into the upcoming 4.8 (4.8.2.0), 4.9 
(4.9.1.0), and 4.10 (4.10.0.0) for which we will be cutting RCs in a week (25 
Sept 2016).  I see the following minor items that need to be addressed in order 
to include this PR:

* [ ] Fix Jenkins build failures
* [ ] Create a JIRA bug ticket
* [ ] Re-target this PR to the 4.8 branch
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1666: fix egress rule incorrect behavior

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1666
  
@murali-reddy have you had a chance to investigate the Jenkins failure(s) 
and the test failures identified by @karuturi?  

Does this PR address 
[CLOUDSTACK-9480](https://issues.apache.org/jira/browse/CLOUDSTACK-9480)?  If 
so, please amend the commit message to reflect this association?  Otherwise, 
which JIRA ticket should be associated with this issue?

In terms of release target, this issue seems to affect 4.8 as well?  How 
much effort would it be to re-target it to 4.8 for pending 4.8.2.0 release?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1511: 4.9/master bountycastle changes

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1511
  
@rhtyd given that we have one more release of 4.8 in the pipeline, would it 
make sense to re-target this PR to 4.8 and forward merge to 4.9 and master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1611: marvin: deploy clusters in separate threads

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1611
  
@rhtyd this enhancement/fix seems like it would be useful for on-going 
testing of LTS.  Therefore, could you please re-target this PR to the 4.9 
release branch?  Also, could you please investigate the Jenkins failures?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1611: marvin: deploy clusters in separate threads

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1611#discussion_r79303367
  
--- Diff: tools/marvin/marvin/deployDataCenter.py ---
@@ -224,6 +225,15 @@ def createClusters(self, clusters, zoneId, podId, 
vmwareDc=None):
podId,
clusterId)
 
+threads = []
+for cluster in clusters:
+t = threading.Thread(target=createCluster, args=(cluster,))
--- End diff --

Would it make sense to create a fix sized thread pool and use a 
producer-consumer queue to enqueue work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1546: [WIP][4.10+/long-term] Moving towards Java8 and Spri...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1546
  
@rhtyd Can we close this PR in favor of #1638?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1650: fix macchinina template specificied for vmware in Ma...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1650
  
@PaulAngus @abhinandanprateek could you investigate the VMware issue 
described by @serg38?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1651: Marvin Tests: fix expected return string for success...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1651
  
@serg38 @PaulAngus has been on vacation for the past week.  Since this 
problem is present in 4.8 and 4.9, could you please retarget this PR to the 4.8 
release branch?  Also, as @serg38 suggests, please squash your commits.  We 
plan to cut the 4.8.2.0, 4.9.1.0, and 4.10.0.0 PRs on 25 Sept 2016,  Therefore, 
I would like to get this change merged in time for testing of these RCs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1652
  
@PaulAngus following up on PR feedback.  @fmaximus did you apply this patch 
in another PR?  If so, could you please provide a reference?

If this patch has not been addressed elsewhere, I would like to get this 
fix into the upcoming 4.9.10 and 4.10.0.0 releases for which RCs will be cut on 
25 Sept 2016.  Assuming this issue is also present in 4.9, could you please 
re-target the PR and investigate the Jenkins failure.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1662: Fix bug juniper srx

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1662
  
@digitalgust following up on @rhtyd's feedback.  I see the following items 
to be addressed in order to get this PR merged:

   * [ ] Squash commits
   * [ ] Re-point the PR to the 4.8 release branch -- the change will be 
merged forward to 4.9 and master as part of the PR merge
   * [ ] Create a JIRA ticket describing the bug and update the commit 
comments to reference it

Since we are going to have one more 4.8 release, this fix seems like it 
would be good for the as well.  Therefore, I adjusted to the target of this PR 
to the 4.8 branch.  We are going to be cutting RCs for 4.8.2.0, 4.9.1.0, and 
4.10.0.0 in on 25 Sept 2016.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack issue #1673: CLOUDSTACK-9071: Properly parse stats.output.uri in ...

[jburwell]

Github user jburwell commented on the issue:

https://github.com/apache/cloudstack/pull/1673
  
@wido this fix seems like it would be good for 4.8 and 4.9 as well.  Would 
you mind re-pointing this PR to the 4.8 branch?

Also, could you investigate the cause of the Jenkins failure?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] cloudstack pull request #1673: CLOUDSTACK-9071: Properly parse stats.output....

[jburwell]

Github user jburwell commented on a diff in the pull request:

https://github.com/apache/cloudstack/pull/1673#discussion_r79302819
  
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -285,9 +286,15 @@ private void init(Map configs) {
 s_logger.info(scheme + " is not a valid protocol for 
external statistics. No statistics will be send.");
 }
 
-externalStatsHost = uri.getHost();
+if (!StringUtils.isEmpty(uri.getHost())) {
+externalStatsHost = uri.getHost();
+}
+
 externalStatsPort = uri.getPort();
-externalStatsPrefix = uri.getPath().substring(1);
+
+if (!StringUtils.isEmpty(uri.getPath())) {
+externalStatsPrefix = uri.getPath().substring(1);
+}
 
 /* Append a dot (.) to the prefix if it is set */
 if (externalStatsPrefix != null && 
!externalStatsPrefix.equals("")) {
--- End diff --

I realize it's not in the scope of this PR, but would you consider changing 
this `if` block to use `StringUtils.isEmpty`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---