Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1773
@priyankparihar I agree with @ustcweizhou regarding the default value of
`forced` in terms of backwards compatibility.
Also, why we permit deletion of a template when it is associated
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1888
@rhtyd most Java-based systems do not specific a particular JDK/JRE as a
dependency in their packages in order to allow administrators to pick the
implementation they prefer (e.g. OpenJDK, Sun
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r95035212
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -790,6 +791,18 @@ private String validateConfigurationValue(final
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r95034972
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r95035623
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1883#discussion_r95034912
--- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java ---
@@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long
networkId
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95033850
--- Diff: ui/scripts/storage.js ---
@@ -54,6 +54,12 @@
label: 'label.vm.display.name
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95034584
--- Diff: ui/scripts/ui/widgets/listView.js ---
@@ -1922,7 +1922,14 @@
// List view header actions
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95034385
--- Diff: ui/scripts/system.js ---
@@ -17309,7 +17325,12
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95033188
--- Diff: test/integration/smoke/test_global_settings.py ---
@@ -63,6 +63,33 @@ def test_UpdateConfigParamWithScope(self):
self.assertEqual
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95032496
--- Diff:
api/test/org/apache/cloudstack/api/command/test/ListCapabilitiesCmdTest.java ---
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95034302
--- Diff: ui/scripts/system.js ---
@@ -14088,6 +14093,12
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95034357
--- Diff: ui/scripts/system.js ---
@@ -15581,7 +15592,12
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95033034
--- Diff:
api/test/org/apache/cloudstack/api/command/test/ListCapabilitiesCmdTest.java ---
@@ -0,0 +1,80 @@
+// Licensed to the Apache Software
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95034175
--- Diff: ui/scripts/system.js ---
@@ -7851,9 +7851,14 @@
data: zoneObjs
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1884#discussion_r95034635
--- Diff: ui/scripts/ui/widgets/listView.js ---
@@ -1922,7 +1922,14 @@
// List view header actions
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1763
@sudhansu7 could you please create a Marvin test case with the tests
outlined in your
[comment](https://github.com/apache/cloudstack/pull/1763#issuecomment-265221113)?
When it is available
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1804
@rhtyd looks like the Travis build is failing due to a timeout. Do you
have any ideas what could be causing this timeout?
@nitin-maharana are their existing Marvin tests that verify
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@murali-reddy @rhtyd is there an ETA on the
`test_create_volume_under_domain` fix? The current Travis build is failing on
the following test cases:
* `test_volumes
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1797
@sudhansu7 could you please either add or update an existing a Marvin test
case to verify this change?
Also, this change seems like it would be useful for LTS users. Could you
please
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r90589284
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1719,6 +1719,7 @@ public boolean storagePoolHasEnoughSpace(List
volumes
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r90589240
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1746,10 +1747,10 @@ public boolean
storagePoolHasEnoughSpace(List volumes
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1802
Coupled with @rhtyd's explanation, we can merge this PR if the current
blueorganutan run comes up clean.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1765
@abhinandanprateek could you please rebase this PR to pick up the fixes to
the broken tests? I want to make sure that this PR doesn't introduce any
side-effects that break the test runs
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@blueorangutan test matrix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@murali-reddy @rhtyd can you investigate the Travis failures?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1763
@rhtyd can you investigate why the fix for this issue in 4.5 was not pulled
forward? For traceability purposes, it would be preferable to forward merge
the fix than commit a new version
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1786#discussion_r90487461
--- Diff:
plugins/network-elements/netscaler/src/com/cloud/network/element/NetscalerElement.java
---
@@ -260,7 +264,7 @@ public boolean applyLBRules
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1776
@priyankparihar could you please provide further explanation as to how this
fix addresses the issue of `concurrent.snapshots.threshold.perhost` not being
validated?
Also
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1773#discussion_r90480678
--- Diff: server/src/com/cloud/template/TemplateManagerImpl.java ---
@@ -1176,6 +1176,23 @@ public boolean deleteTemplate(DeleteTemplateCmd cmd
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1773#discussion_r90481980
--- Diff:
api/src/org/apache/cloudstack/api/command/user/template/DeleteTemplateCmd.java
---
@@ -52,6 +52,9 @@
@Parameter(name
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@murali-reddy agreed that it is extremely unlikely that the code change
impacts that test case. However, we know that a failure to cleanup between
tests can cause failures when they are run
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1799
@rhtyd the Travis build failed due a timeout on one of the workers. Could
you please do a force push to trigger a new build?
---
If your project is set up for it, you can reply to this email
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1804#discussion_r90476049
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -3092,8 +3092,12 @@ public Vlan createVlanAndPublicIpRange(final long
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@pdion891 this
[blog](https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/)
is good description of squash process.
---
If your project is set up for it, you can reply
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1802
@murali-reddy I see failures in the `test_router_dhcp_opts` test case. Was
this PR rebased to get the fix from #1801? If not, I would like to rebase and
re-run the tests. Otherwise, we may
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1659
@blueorangutan test centos7 xenserver-65sp1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1659
Tests look good on KVM. However, it seems like a Good Thing(tm) to test on
KVM and XenServer as well.
@blueorangutan test centos7 vmware-55u3
@blueorangutan test centos7 xenserver
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1675
@abhinandanprateek ping re: closing this PR in favor of #1639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90457477
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90454905
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspRequestWrapper.java
---
@@ -0,0 +1,78 @@
+//
+// Licensed
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455598
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90452488
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -255,7 +284,30 @@ public void reserve
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90456898
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451456
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,43
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90452834
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -317,20 +368,28 @@ private void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451924
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -387,41 +400,39 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450632
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455612
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450815
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
---
@@ -0,0 +1,63 @@
+//
+// Licensed
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455401
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90455021
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspRequestWrapper.java
---
@@ -0,0 +1,78 @@
+//
+// Licensed
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450669
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450606
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451522
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,43
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90453536
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -339,34 +398,63 @@ private void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90458374
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90453232
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/guru/NuageVspGuestNetworkGuru.java
---
@@ -339,34 +398,63 @@ private void
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451818
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -387,41 +400,39 @@ public boolean
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451387
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/UpdateNuageVspDeviceCommand.java
---
@@ -0,0 +1,43
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90457155
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90457877
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/resource/NuageVspResourceConfiguration.java
---
@@ -0,0 +1,310
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90451135
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
---
@@ -0,0 +1,63 @@
+//
+// Licensed
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450578
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/network/element/NuageVspElement.java
---
@@ -128,6 +135,26 @@
private static
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r90450802
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/agent/api/manager/CleanUpDomainCommand.java
---
@@ -0,0 +1,63 @@
+//
+// Licensed
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@rhtyd agreed. I apologize for being unclear -- I would like to get this
PR into 4.9.1.0, but it is not a release blocker.
---
If your project is set up for it, you can reply to this email
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@prashanthvarma agreed regarding the most common causes of failures.
@murali-reddy @borisstoyanov and @abhinandanprateek have been working to
address these issues as they are encountered
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@PaulAngus @rhtyd what are your thoughts on automating the testing of the
Docker container?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@pdion891 can you please investigate the Jenkins failure?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1435
@pdion891 if possible, I would like to get this merged for 4.9.1.0. How
does this PR relate to #1789? Also, could you please investigate the Jenkins
failure and create JIRA ticket
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1784
@murali-reddy is internal DNS service impacted by having multiple NICs?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90380293
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90380262
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90380120
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90380926
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90380579
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1784#discussion_r90380041
--- Diff: test/integration/smoke/test_router_dnsservice.py ---
@@ -0,0 +1,268 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1798
@marcaurele there appear to be Travis failures. Could you please check
into them?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1798#discussion_r90372709
--- Diff:
api/src/org/apache/cloudstack/api/command/user/affinitygroup/UpdateVMAffinityGroupCmd.java
---
@@ -96,6 +96,10 @@ public Long getId
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1711
@syed yes, you will add the changes to `schema-4910to4920` for the `4.9`
port. This will cover anyone upgrading from a version >= 4.9.1.0 to 4.9.2.0.
I do not plan to automatically forw
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90342302
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90342459
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1803
@nitin-maharana could you please add screen shots of the change to the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90341780
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90340642
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90341157
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90341463
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90341553
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90340513
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90341649
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90339611
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90315044
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90310924
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90315713
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -180,16 +185,16 @@ public void deleteSslCert(DeleteSslCertCmd
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90338425
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -240,68 +245,71 @@ public void deleteSslCert(DeleteSslCertCmd
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90313790
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -245,48 +245,48 @@ public void runUploadSslCertSelfSignedNoPassword
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90315176
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -111,37 +116,37 @@ public CertServiceImpl() {
@DB
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90309869
--- Diff:
utils/src/main/java/com/cloud/utils/security/CertificateHelper.java ---
@@ -40,123 +46,122 @@
import java.util.ArrayList;
import
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90314823
--- Diff: server/test/org/apache/cloudstack/network/lb/CertServiceTest.java
---
@@ -125,48 +125,48 @@ public void runUploadSslCertWithCAChain() throws
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1799#discussion_r90339460
--- Diff: server/src/org/apache/cloudstack/network/lb/CertServiceImpl.java
---
@@ -339,190 +348,182 @@ public SslCertResponse createCertResponse
1 - 100 of 1850 matches
Mail list logo
