Re: Renaming CordovaWebView CordovaWebInterface

2015-01-13 Thread Josh Soref
I'm not an Android developer, but I recently ‎saw how the getPluginManager() - pluginManager change can be handled. I also know that it's possible to build wrappers for interface changes.  I wouldn't be opposed to this change.  I'd probably ask for sample transition code so that people who

[GitHub] cordova-plugin-camera pull request: CB-7667 iOS8: Handle case wher...

2015-01-13 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-69861487 I cleaned up the merge conflict, and I believe it's now working again. I had a bunch of issues upgrading my plugin (CDVCamera.m seemed to drop off the

RE: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-13 Thread Sergey Grebnov (Akvelon)
+1 Could someone also take a look on the following pending PR and merge it before starting release if possible CB-8201 Add support for auth dialogs into Cordova Android https://github.com/apache/cordova-android/pull/143 Thx! Sergey -Original Message- From: agri...@google.com

[GitHub] cordova-lib pull request: Generate apk name

2015-01-13 Thread fabiomontefuscolo
GitHub user fabiomontefuscolo opened a pull request: https://github.com/apache/cordova-lib/pull/147 Generate apk name After update the phonegap for my app, the build always generate an APK file named CordovaApp.apk. Is this a good way to solve this? You can merge this pull request

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Joe Bowser
Agreed. That would mean that 3.7.x would be the last release where we support Android 2.3.x. I don't think that MozillaView is in a good enough state for us to recommend that path to users. At this point, I can say that the owners of these 78 million phones should buy a new phone. It's not

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Joe Bowser
So, where are these numbers coming from? Can we get a breakdown by region? On Tue Jan 13 2015 at 3:30:23 AM Marcel Kinard cmarc...@gmail.com wrote: Another stat: Forbes estimates that the existing number of Android phones is 1.56 billion. Five percent of that is 78 million. On Jan 13,

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Michal Mocny
Does it really matter? I think Joe summarized it best, we can only claim to support what is actually being supported (aka actively tested, actively maintained). Market share doesn't impact that. Not that we should not actively break 2.3 support, but with 3.7 on the horizon, and big changes

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Brian LeRoux
I agree, we're not really supporting these devices, and it is disingenuous of the project to advertise that we do. Any apps concerning themselves with privacy/security won't be targeting or testing on those devices either. I think a clean break w/ the message 4.x === 4.x, coupled with many

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-13 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/143#discussion_r22919310 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Joe Bowser
Those are the exact people the Android One program is meant to target. I rounded up when I stated the price of these devices. On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa sosah.vic...@gmail.com wrote: Well... Not trying to create a polemic here, but you can ask that to persons who earn

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-13 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/143#discussion_r22887338 --- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java --- @@ -0,0 +1,30 @@ +/* + Licensed to the Apache Software

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-13 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/143#discussion_r22890349 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {

[GitHub] cordova-lib pull request: CB-8168 --list support for cordova-lib

2015-01-13 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/145#discussion_r22883426 --- Diff: cordova-lib/src/cordova/targets.js --- @@ -0,0 +1,65 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +

Re: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-13 Thread Andrew Grieve
Left some comments On Tue, Jan 13, 2015 at 12:49 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: +1 Could someone also take a look on the following pending PR and merge it before starting release if possible CB-8201 Add support for auth dialogs into Cordova Android

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-13 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/143#discussion_r22890354 --- Diff: framework/src/org/apache/cordova/HttpAuthRequestHandler.java --- @@ -0,0 +1,30 @@ +/* + Licensed to the Apache Software

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Michal Mocny
Victor, I don't disagree with your observation that those phones serve a purpose. But we aren't telling those individuals that they cannot use their phones, we are telling developers that want to create new applications for that target to either build mobile web, packaged native, or just stick to

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-13 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/143#discussion_r22887157 --- Diff: framework/src/org/apache/cordova/CordovaActivity.java --- @@ -147,6 +147,17 @@ public void setAuthenticationToken(AuthenticationToken

[GitHub] cordova-mobile-spec pull request: CB-8295 Enable CSP for mobile sp...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Renaming CordovaWebView CordovaWebInterface

2015-01-13 Thread Joe Bowser
So, this was something that was brought up numerous times, but I think we should probably discuss this at least one more time before we move to finish off 4.0.x. Given that we're breaking the API for CordovaWebView already, would it make sense for us to call it a CordovaWebInterface instead? The

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: Introduction

2015-01-13 Thread Andrew Grieve
Welcome Nikhil! On Tue, Jan 13, 2015 at 4:59 PM, Steven Gill stevengil...@gmail.com wrote: Welcome Nikhil! On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Hi, I am an engineering manager at Microsoft leading a team working on Cordova. I have been

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22911133 --- Diff: node_modules/.bin/shjs --- @@ -1 +1,15 @@ -../shelljs/bin/shjs --- End diff -- This is done automagically by node on

Re: Renaming CordovaWebView CordovaWebInterface

2015-01-13 Thread Andrew Grieve
Looking at our core plugins, several of them would break if we renamed this file. For that reason, I think keep it as-is for now. Here's my grep: http://pastebin.com/dqvyiMLS On Tue, Jan 13, 2015 at 7:30 PM, Josh Soref jso...@blackberry.com wrote: I'm not an Android developer, but I recently

[GitHub] cordova-js pull request: CB-8300 Added CI configuration files

2015-01-13 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-js/pull/100 CB-8300 Added CI configuration files Jira issue: https://issues.apache.org/jira/browse/CB-8300 You can merge this pull request into a Git repository by running: $ git pull

Re: [DISCUSS] Plugins Release

2015-01-13 Thread Maxim Ermilov
Hi, Could someone review following changes before release? https://github.com/apache/cordova-plugin-media-capture/pull/30 https://github.com/apache/cordova-plugin-camera/pull/62 -Maxim On Tue, Jan 13, 2015 at 6:12 AM, Andrew Grieve agri...@chromium.org wrote: Only concern is:

[GitHub] cordova-cli pull request: CB-8301 Added CI configuration files

2015-01-13 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-cli/pull/206 CB-8301 Added CI configuration files JIRA Issue: https://issues.apache.org/jira/browse/CB-8301 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-camera pull request: ubuntu: use content hub on dev...

2015-01-13 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/62 ubuntu: use content hub on device You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-camera master

[GitHub] cordova-plugin-media-capture pull request: ubuntu: use content hub...

2015-01-13 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/30 ubuntu: use content hub on device You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-media-capture

[GitHub] cordova-js pull request: CB-8300 Added CI configuration files

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Marcel Kinard
Another stat: Forbes estimates that the existing number of Android phones is 1.56 billion. Five percent of that is 78 million. On Jan 13, 2015, at 1:14 AM, Ally Ogilvie aogil...@wizcorp.jp wrote: moar stats: https://mixpanel.com/trends/#report/android_os_adoption/from_date:-365,to_date:0

[GitHub] cordova-lib pull request: CB-8208 Made CI systems to get cordova-j...

2015-01-13 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-lib/pull/146 CB-8208 Made CI systems to get cordova-js dependency from gihub JIRA issue: https://issues.apache.org/jira/browse/CB-8208 You can merge this pull request into a Git repository by running:

[GitHub] cordova-cli pull request: CB-8301 Added CI configuration files

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8208 Made CI systems to get cordova-j...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/146 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Cordova-Android 3.7.0 Release

2015-01-13 Thread Andrew Grieve
+1 On Mon, Jan 12, 2015 at 6:04 PM, Shazron shaz...@gmail.com wrote: +1 On Mon, Jan 12, 2015 at 12:15 PM, Steven Gill stevengil...@gmail.com wrote: Do it! +1 On Mon, Jan 12, 2015 at 10:44 AM, Joe Bowser bows...@gmail.com wrote: Hey How do people feel about releasing 3.7.0 this

RE: platforms/plugins save and restore from config.xml

2015-01-13 Thread Treggiari, Leo
I agree with always saving and automatically re-fetching sources and platforms when needed. With regards to the other conversation going on re: automatic add of a platform, I think the CLI should automatically do things when it is reasonably unambiguous what the user wants - e.g. if they

[GitHub] cordova-plugin-file-transfer pull request: CB-8296 add check at re...

2015-01-13 Thread eymorale
GitHub user eymorale opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/57 CB-8296 add check at removeTargetFile to see if file exists You can merge this pull request into a Git repository by running: $ git pull

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Victor Sosa
Well... Not trying to create a polemic here, but you can ask that to persons who earn $10USD a day, and yes, many of these persons have a very-old-yet-cheap smartphone 2015-01-13 12:33 GMT-06:00 Joe Bowser bows...@gmail.com: Agreed. That would mean that 3.7.x would be the last release where we

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Joe Bowser
On Tue Jan 13 2015 at 10:42:38 AM Victor Sosa sosah.vic...@gmail.com wrote: Well... Not trying to create a polemic here, but you can ask that to persons who earn $10USD a day, and yes, many of these persons have a very-old-yet-cheap smartphone 2015-01-13 12:33 GMT-06:00 Joe Bowser

Re: proposed utility

2015-01-13 Thread Staci Cooper
When I was implementing this I initially did add it as a '--local / -l' option to the cli. My concern was that it requires the developer to have a global installation of Cordova even if all they want is the local command. And assuming the user's global and local installs have different version

[GitHub] cordova-android pull request: CB-8201 Add support for auth dialogs...

2015-01-13 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/143#discussion_r22887184 --- Diff: framework/src/org/apache/cordova/CordovaWebViewClient.java --- @@ -89,6 +97,15 @@ public void setWebView(CordovaWebView view) {

[GitHub] cordova-plugin-globalization pull request: CB-7972 Add cordova-plu...

2015-01-13 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/31#issuecomment-69810429 thank you @purplecabbage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Josh Soref
Michal Mocny wrote: ... we aren't telling those individuals that they cannot use their phones, we are telling developers that want to create new applications for that target to either build mobile web, packaged native, or just stick to existing versions of cordova if really needed. I do not buy

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-13 Thread Joe Bowser
Firefox works on 2.3, and Chrome does not. It also depends on the device On Tue, Jan 13, 2015, 12:20 PM Josh Soref jso...@blackberry.com wrote: Michal Mocny wrote: ... we aren't telling those individuals that they cannot use their phones, we are telling developers that want to create new

[GitHub] cordova-js pull request: Cleanup unused stuff. CB-8057

2015-01-13 Thread purplecabbage
Github user purplecabbage closed the pull request at: https://github.com/apache/cordova-js/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-browser/pull/6 CB-8206: Browser platform: Add support for update This change add supports for updating the browser platform. I ended up deleting a couple of log messages from create as there is no way to

Re: Introduction

2015-01-13 Thread Steven Gill
Welcome Nikhil! On Tue, Jan 13, 2015 at 1:56 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Hi, I am an engineering manager at Microsoft leading a team working on Cordova. I have been following some of the discussions on the dev mailing list and love the energy of this project. I have

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22899820 --- Diff: node_modules/.bin/shjs --- @@ -1 +1,15 @@ -../shelljs/bin/shjs --- End diff -- this change looks like you replaced a *nix

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-lib/pull/148#issuecomment-69831696 please ensure there's a PR to update: https://github.com/apache/cordova-cli/blob/38dd67242841dd2ec254f7f9f402f495f7a28f5b/doc/platform.txt#L20 --- If your

[GitHub] cordova-mobile-spec pull request: CB-8295 Enable CSP for mobile sp...

2015-01-13 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/115 CB-8295 Enable CSP for mobile spec - Uses a javascript include file to document.write a CSP meta tag on page - Minor changes to test pages where need to comply with CSP (e.g. remove

Introduction

2015-01-13 Thread Nikhil Khandelwal
Hi, I am an engineering manager at Microsoft leading a team working on Cordova. I have been following some of the discussions on the dev mailing list and love the energy of this project. I have already signed and submitted the Apache ICLA. I have my first pull request for the browser platform

[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22899370 --- Diff: bin/lib/update.js --- @@ -0,0 +1,59 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22899501 --- Diff: bin/lib/create.js --- @@ -26,14 +26,11 @@ var fs = require('fs'), ROOT= path.join(__dirname, '..', '..'), check_reqs =

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/148 CB-8239 Add support for git urls to 'cordova platform add' CB-8239 Add support for git urls to 'cordova platform add' These changes allow the following scenarios: *users can

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r22900311 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -354,22 +359,94 @@ describe('add function', function () { }); });

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r22900366 --- Diff: cordova-lib/src/cordova/platform.js --- @@ -76,97 +77,94 @@ function add(hooksRunner, projectRoot, targets, opts) { }

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-13 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r22904360 --- Diff: cordova-lib/spec-cordova/platform.spec.js --- @@ -354,22 +359,94 @@ describe('add function', function () { }); });

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22905021 --- Diff: bin/lib/create.js --- @@ -26,14 +26,11 @@ var fs = require('fs'), ROOT= path.join(__dirname, '..', '..'), check_reqs =

[GitHub] cordova-browser pull request: CB-8206: Browser platform: Add suppo...

2015-01-13 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/6#discussion_r22905187 --- Diff: bin/lib/update.js --- @@ -0,0 +1,59 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

2015-01-13 Thread whitecolor
Github user whitecolor commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-69843977 Any comments? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

RE: platforms/plugins save and restore from config.xml

2015-01-13 Thread Mefire O .
This PR adds support for git-urls to 'cordova platform add' : https://github.com/apache/cordova-lib/pull/148 Please, review. Thanks, Mefire -Original Message- From: Treggiari, Leo [mailto:leo.treggi...@intel.com] Sent: Tuesday, January 13, 2015 8:18 AM To: dev@cordova.apache.org