Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-cli/pull/224#issuecomment-147536916
:+1: :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/314#issuecomment-145741275
It only impacts the `cordova run browser` command (which already runs on a
local node server) - it has no impact on how users might deploy their app when
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/314#issuecomment-145742256
No problem :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/96#discussion_r34224410
--- Diff: template/cordova/lib/package.js ---
@@ -130,58 +145,47 @@ module.exports.findDevice = function (target) {
};
// returns
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119813107
Heh, I wasn't wanting to start a semantics argument, just after consistency.
My understanding is that the usual terminology is simulator for iOS
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/35#issuecomment-119804386
Should this be Emulator rather than Simulator (that's the terminology
used elsewhere in Cordova, isn't it? And the typical terminology for Android
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-browser/pull/14
CB-9350 'cordova run browser' throws an exception.
The `run` command in `cordova-browser` was using an old (never released)
API for `cordova-serve` (I clearly checked in the wrong version
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-browser/pull/15
Adds LICENSE and NOTICE files.
Also updates license in package.json to be in SPDX format.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/98#issuecomment-120820494
Looks good to me.
Have you verified no changes need to be made to
`cordova-lib/src/util/windows/jsprojManager.js` (adding/removing plugins that
use
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/291
CB-9559 Adding a plugin with caret in version results in an error
When Cordova used `npm 1.3.x` internally, we had to process caret
versions since `npm 1.3.x` didn't understand them. As part
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-coho/pull/93
CB-9585 Support globs with 'coho verify-archive' command.
This adds supports for globs to the `coho verify-archive` command, so you
can pass wildcards such as:
coho verify
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/297#issuecomment-138394389
LGTM. I've merged it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c#commitcomment-13037479
Hey Vlad - with this change in I get the following error trying to add the
`browser` platform to a project
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/295
CB-9604 Fix error adding browser platform with PlatformApi polyfill.
Don't try to create `ConfigParser()` in `PlatformApiPoly` constructor,
since we may not have copied the `config.xml` file
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/295#issuecomment-137297111
@vladimir-kotikov - does this fix look right to you?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/293#issuecomment-137282883
Seems reasonable. One minor concern... The check for the `cordova`
directory doesn't really validate that this is a `browser` platform directory.
Not sure
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-139157987
It seems like an ok fix for the immediate problem, but it does raise a
concern in my mind - before the Platform API changes, we didn't call `prepare`
when adding
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/304#discussion_r39388053
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -283,6 +283,31 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-140217724
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-browser/pull/17
CB-9658 Improve 'cordova run browser' when browser not installed
Catches error and outputs the error message.
You can merge this pull request into a Git repository by running:
$ git
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-browser/pull/16
CB-9654 'cordova run browser' -> duplicate 'CTRL + C' messages.
Utilize *cordova-serve*'s `noServerInfo` flag to prevent it from displaying
this info, since *cordova-browser* wa
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/314
Refactor cordova-serve to use Express.
This simplifies a lot of code, but more importantly provides a more
standardized and modular way to customize the server (via Express middleware
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-coho/pull/95#issuecomment-145105221
+1 to `* text eol=lf` in `.gitattributes` - most commonly used tools on
Windows (other than notepad :smile:) should handle Unix line endings fine.
---
If your
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/commit/932ad578589d1c825fa57f330dafd3092f193e3c#commitcomment-13603467
Hey @vladimir-kotikov - you should probably bump version in master to
`5.3.3-dev`, right?
---
If your project is set up
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#discussion_r46821107
--- Diff: www/isChrome.js ---
@@ -0,0 +1,26 @@
+/*
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/132#issuecomment-162867249
Generally looks fine to me apart from some misplaced "Android" references I
mention inline. Also, it concerns me that `ConsoleLogger` is duplica
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/349#issuecomment-161826181
Thanks - LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/349#discussion_r46494465
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,54 @@ function toCamelCase(str) {
}).join
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708771
@omefire - no, I don't think so. I think feature detection is more
appropriate for the intent of this code. Also, my goal wasn't to change the
existing
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/152#issuecomment-162708869
Moved `isChrome` to be browser specific (we only ever call it either from
browser specific code, or after verifying we're running on browser platform
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/294#discussion_r46228904
--- Diff: cordova-lib/src/plugman/platforms/ubuntu.js ---
@@ -29,6 +29,51 @@ function toCamelCase(str) {
}).join
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-android/pull/230#issuecomment-157950628
Just an FYI - The node 4.x.x dependency in `node-parser` has just been
fixed and the fix released, so we can move to `0.3.1` safely if ever there is a
reason
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-windows/pull/139#issuecomment-177957240
I've taken a look too, and I agree this seems the best approach. Changes
look good to me, except I agree with your comment @sgrebnov that we should use
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179503770
Yeah, and in fact, for consistency maybe "installed platforms" should also
be separated by line breaks rather than commas:
```
Installed
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179498720
I like the idea, but find the list is starting to get a bit confusing (to
see the actual platform names. We need to make sure the platform names a very
easy
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/375#issuecomment-179513568
:+1: Thanks Vladimir.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/376#issuecomment-179511413
Looks great! Just one comment: I think just a couple of spaces would look
better than a tab.
Also, looks like there is a test that is sensitive
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/154#issuecomment-178404256
Ah sorry @fattalgazi - I just fixed this and missed that you already had a
PR open. Fixed now in #161.
---
If your project is set up for it, you can
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-178412993
Thanks for this @aliokan. I've tweaked the commit a bit to store the magic
number in a constant, and I'll merge it.
---
If your project is set up
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/161
CB-10502 Fix camera plugin exception in Chrome when click capture.
The `MediaStream.stop()` method has been deprecated as of Chrome 47. We
were using it, and it was generating
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/commit/3b9face5187857d354d85f3e3f4316cbace100db#commitcomment-16237620
Hey @vladimir-kotikov - this fix causes a crash when adding the browser
platform (maybe any platform that doesn't have
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/363#issuecomment-187701057
Other than one small remaining question, looks great! Thanks @riknoll!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188545978
A simpler fix might be: since all we're looking for is the project's `id`,
why not fall back on the main Cordova project's `config.xml` if we don't find
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/398#discussion_r54079611
--- Diff: cordova-lib/src/plugman/platforms/common.js ---
@@ -22,7 +22,39 @@ var shell = require('shelljs'),
fs= require('fs
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/398#issuecomment-188730806
Thanks @vladimir-kotikov - looks good. Just a couple of suggestions.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/398#discussion_r54079687
--- Diff: cordova-lib/src/plugman/platforms/browser.js ---
@@ -31,25 +29,7 @@ module.exports = {
return path.join(project_dir, 'www
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/387#discussion_r52976299
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -132,10 +132,14 @@ function fetchPlugin(plugin_src, plugins_dir,
options
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/388#issuecomment-184563301
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52984062
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/384#discussion_r52993992
--- Diff: cordova-lib/src/cordova/build.js ---
@@ -17,22 +17,26 @@
under the License.
*/
-var cordovaUtil = require
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-184676141
Thanks @vladimir-kotikov. Looks good on a quick look through. Will take a
closer look in the morning.
---
If your project is set up for it, you can reply
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/387#issuecomment-185005103
Thanks @bso-intel. I've merged this in
https://github.com/apache/cordova-lib/commit/87d8e171, but I rebased on forgot
to add "This closes #387" to t
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53297519
--- Diff: cordova-lib/src/cordova/platform.js ---
@@ -492,17 +492,13 @@ function list(hooksRunner, projectRoot, opts) {
var platforms_on_fs
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298645
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53298695
--- Diff: cordova-lib/src/cordova/util.js ---
@@ -185,6 +187,31 @@ function listPlatforms(project_dir) {
});
}
+function
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53299072
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300134
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300300
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53300652
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301382
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53301932
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53302711
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304649
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53304887
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305319
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305710
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -154,6 +135,38 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305804
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53305903
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/384#issuecomment-185719821
Oops, sorry :smile: ... LGTM. There's nowhere we call these directly
internally and expect an actual value in return?
---
If your project is set up for it, you
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/393#issuecomment-185729885
Yep, that looks right to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r53536875
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -507,3 +527,117 @@ function versionString(version) {
return null
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-browser/pull/10#issuecomment-191031984
@amikula - this PR was closed by a commit made to `cordova-firefoxos`,
which was probably done by mistake.
But regarding this problem specifically
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54809830
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54817429
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54819210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54834210
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722038
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722073
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54722281
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54723579
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -305,6 +289,49 @@ module.exports = function plugin(command, targets,
opts
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54726389
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727324
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54726540
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/363#discussion_r54727968
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -512,3 +543,219 @@ function versionString(version) {
return null
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-docs/pull/531
Rewrite of storage guide.
* Provides more details about each of the options.
* Provides examples.
* Describes pros and cons of each approach.
You can merge this pull request
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-windows/pull/188
Merged in 2d7d219fc1864fa22f87cebadac173fd41091351.
Sorry @jicongw, I forgot to tag this PR in the modified commit, so you will
have to close the PR manually.
---
If your
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/623#discussion_r72483583
--- Diff: www/_posts/2016-07-27-cordova-windows-4.4.2.md ---
@@ -0,0 +1,33 @@
+---
+layout: post
+author:
+name: Vladimir Kotikov
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-docs/pull/623
Couple of comments. Other than that looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/188#discussion_r71791061
--- Diff: template/cordova/lib/MSBuildTools.js ---
@@ -93,6 +93,20 @@ module.exports.findAllAvailableVersions = function
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-windows/pull/188
Thanks @jicongw - I just had one comment, plus fixing the commit message as
I mentioned offline.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/498
CB-11985 Check if cached platform/plugin exists before 'npm cache'
### What does this PR do?
Before calling `npm cache add` when installing a platform or plugin, look
for an existing
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/498#discussion_r82566198
--- Diff: cordova-lib/src/util/npm-helper.js ---
@@ -72,4 +75,53 @@ function restoreSettings() {
}
}
+/**
+ * Fetches
Github user TimBarham commented on the issue:
https://github.com/apache/cordova-lib/pull/498
@brodybits - that hasn't changed. At the point where we're looking for a
cached version, we have already determined the latest version that matches the
requested range (for both platforms
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/498#discussion_r82568768
--- Diff: cordova-lib/src/plugman/registry/registry.js ---
@@ -114,19 +113,11 @@ function initThenLoadSettingsWithRestore(promises
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/512
CB-12284 Include project root as additional root for static router
### Platforms affected
All
### What does this PR do?
With this change, cordova-serve includes the project
201 - 295 of 295 matches
Mail list logo
