[GitHub] [drill] paul-rogers commented on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration

2019-10-21 Thread GitBox
paul-rogers commented on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#issuecomment-544797392 To answer my other comment; about the lack of ease-of-use with the current session options related to file format

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337321627 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FormatSelection.java ## @@ -63,6 +6

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337321743 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/ZipCodec.java ## @@ -0,0 +1,141 @@

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337322969 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/package-info.java ## @@ -16,7 +1

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337322300 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetFormatPlugin.java ## @@

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337321942 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/ZipCodec.java ## @@ -0,0 +1,141 @@

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337321291 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSelection.java ## @@ -386,17 +3

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337321551 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java ## @@ -57,7 +

[GitHub] [drill] paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879#discussion_r337322883 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngFormatPlugin.java ## @@ -4

[GitHub] [drill] paul-rogers commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#discussion_r337311938 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl

[GitHub] [drill] paul-rogers commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#discussion_r337312721 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/Off

[GitHub] [drill] paul-rogers edited a comment on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
paul-rogers edited a comment on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#issuecomment-544779743 Thanks much for the review! Made requested changes. Rebased on master. Squashed commits. Once

[GitHub] [drill] paul-rogers commented on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
paul-rogers commented on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#issuecomment-544779743 Made requested changes. Rebased on master. Squashed commits. Once this is merged, I'll update the two new PR

[GitHub] [drill] paul-rogers commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
paul-rogers commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#discussion_r337308769 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/validate/

[jira] [Created] (DRILL-7417) Test Task

2019-10-21 Thread Sorabh Hamirwasia (Jira)
Sorabh Hamirwasia created DRILL-7417: Summary: Test Task Key: DRILL-7417 URL: https://issues.apache.org/jira/browse/DRILL-7417 Project: Apache Drill Issue Type: Task Reporter:

[GitHub] [drill] arina-ielchiieva opened a new pull request #1879: DRILL-5674: Support ZIP compression

2019-10-21 Thread GitBox
arina-ielchiieva opened a new pull request #1879: DRILL-5674: Support ZIP compression URL: https://github.com/apache/drill/pull/1879 1. Added ZipCodec implementation which can read / write single file. 2. Revisited Drill plugin formats to ensure 'openPossiblyCompressedStream' method is

[jira] [Created] (DRILL-7416) Updates required to dependencies to resolve potential security vulnerabilities

2019-10-21 Thread Bradley Parker (Jira)
Bradley Parker created DRILL-7416: - Summary: Updates required to dependencies to resolve potential security vulnerabilities Key: DRILL-7416 URL: https://issues.apache.org/jira/browse/DRILL-7416 Proje

[jira] [Resolved] (DRILL-3850) Execute multiple commands from sqlline -q

2019-10-21 Thread Arina Ielchiieva (Jira)
[ https://issues.apache.org/jira/browse/DRILL-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arina Ielchiieva resolved DRILL-3850. - Resolution: Fixed Fixed in the scope of DRILL-7401. > Execute multiple commands from sql

Re: Drill fails for postgress if you use a Foreign Tables

2019-10-21 Thread Igor Guzenko
Hello everyone, I have created ticket to track the issue (DRILL-7415 [1]) and I'll fix it in scope of Calcite's update ticket [2]. [1] https://issues.apache.org/jira/browse/DRILL-7415 [2] https://issues.apache.org/jira/browse/DRILL-7406 Thanks, Igor On Sun, Oct 20, 2019 at 6:14 PM Charles Givre

[jira] [Created] (DRILL-7415) Information schema query fails for postgres foreign tables

2019-10-21 Thread Igor Guzenko (Jira)
Igor Guzenko created DRILL-7415: --- Summary: Information schema query fails for postgres foreign tables Key: DRILL-7415 URL: https://issues.apache.org/jira/browse/DRILL-7415 Project: Apache Drill

[GitHub] [drill] asfgit closed pull request #1874: DRILL-7405: Avoiding download of TPC-H data

2019-10-21 Thread GitBox
asfgit closed pull request #1874: DRILL-7405: Avoiding download of TPC-H data URL: https://github.com/apache/drill/pull/1874 This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [drill] asfgit closed pull request #1875: DRILL-7401: Upgrade to SqlLine 1.9.0

2019-10-21 Thread GitBox
asfgit closed pull request #1875: DRILL-7401: Upgrade to SqlLine 1.9.0 URL: https://github.com/apache/drill/pull/1875 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [drill] asfgit closed pull request #1876: DRILL-7412: Minor unit test improvements

2019-10-21 Thread GitBox
asfgit closed pull request #1876: DRILL-7412: Minor unit test improvements URL: https://github.com/apache/drill/pull/1876 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [drill] asfgit closed pull request #1872: DRILL-7402: Suppress batch dumps for expected failures in tests

2019-10-21 Thread GitBox
asfgit closed pull request #1872: DRILL-7402: Suppress batch dumps for expected failures in tests URL: https://github.com/apache/drill/pull/1872 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#discussion_r336972303 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#discussion_r336971442 ## File path: exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/write

[GitHub] [drill] arina-ielchiieva commented on issue #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

2019-10-21 Thread GitBox
arina-ielchiieva commented on issue #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#issuecomment-544478701 @paul-rogers mostly looks good, one minor concern about if need to update the comment after code change. ---

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1878: DRILL-7414: EVF incorrectly sets buffer writer index after rollover URL: https://github.com/apache/drill/pull/1878#discussion_r336972303 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet

[GitHub] [drill] arina-ielchiieva edited a comment on issue #1877: DRILL-7413: Test and fix scan operator vectors

2019-10-21 Thread GitBox
arina-ielchiieva edited a comment on issue #1877: DRILL-7413: Test and fix scan operator vectors URL: https://github.com/apache/drill/pull/1877#issuecomment-544476885 LGTM, +1 This is an automated message from the Apache Git

[GitHub] [drill] arina-ielchiieva commented on issue #1877: DRILL-7413: Test and fix scan operator vectors

2019-10-21 Thread GitBox
arina-ielchiieva commented on issue #1877: DRILL-7413: Test and fix scan operator vectors URL: https://github.com/apache/drill/pull/1877#issuecomment-544476885 +1 This is an automated message from the Apache Git Service. To r

[GitHub] [drill] arina-ielchiieva commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data

2019-10-21 Thread GitBox
arina-ielchiieva commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data URL: https://github.com/apache/drill/pull/1874#issuecomment-544476019 +1 This is an automated message from the Apache Git Service. To resp

[GitHub] [drill] arina-ielchiieva commented on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
arina-ielchiieva commented on issue #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#issuecomment-544475715 @paul-rogers sorry could not merge this commit, since there a couple of minor comments. Mostly I am worried a

[GitHub] [drill] arina-ielchiieva commented on issue #1876: DRILL-7412: Minor unit test improvements

2019-10-21 Thread GitBox
arina-ielchiieva commented on issue #1876: DRILL-7412: Minor unit test improvements URL: https://github.com/apache/drill/pull/1876#issuecomment-544475117 +1 This is an automated message from the Apache Git Service. To respond

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#discussion_r336966265 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/vali

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#discussion_r336966111 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/vali

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1871: DRILL-7403: Validate batch checks, vector integretity in unit tests URL: https://github.com/apache/drill/pull/1871#discussion_r336965873 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/vali

[GitHub] [drill] arina-ielchiieva commented on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration

2019-10-21 Thread GitBox
arina-ielchiieva commented on issue #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#issuecomment-544469217 @paul-rogers thanks for the code review, addressed code review comments, force-pushed since there were minor

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#discussion_r336918266 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/w

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#discussion_r336918266 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/easy/text/w

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1873: DRILL-6096: Provide mechanism to configure text writer configuration URL: https://github.com/apache/drill/pull/1873#discussion_r336916683 ## File path: exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.ja

[jira] [Resolved] (DRILL-5183) Drill doesn't seem to handle array values correctly in Parquet files

2019-10-21 Thread Igor Guzenko (Jira)
[ https://issues.apache.org/jira/browse/DRILL-5183?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Guzenko resolved DRILL-5183. - Resolution: Fixed Fixed in DRILL-7268. > Drill doesn't seem to handle array values correctly in

[jira] [Resolved] (DRILL-1999) Drill should expose the Parquet logical schema rather than the physical schema

2019-10-21 Thread Igor Guzenko (Jira)
[ https://issues.apache.org/jira/browse/DRILL-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Igor Guzenko resolved DRILL-1999. - Resolution: Fixed Fixed in scope of DRILL-7268. > Drill should expose the Parquet logical schem

[GitHub] [drill] vvysotskyi commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data

2019-10-21 Thread GitBox
vvysotskyi commented on issue #1874: DRILL-7405: Avoiding download of TPC-H data URL: https://github.com/apache/drill/pull/1874#issuecomment-544422550 @paul-rogers, yes, these files are used in unit tests mostly in the `java-exec` module. Currently, `contrib/data/tpch-sample-data` is built

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336901086 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ###

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1749: DRILL-7177: Format Plugin for Excel Files URL: https://github.com/apache/drill/pull/1749#discussion_r336900967 ## File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java ###

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336899443 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin

2019-10-21 Thread GitBox
arina-ielchiieva commented on a change in pull request #1858: DRILL-4303: ESRI Shapefile (shp) Format Plugin URL: https://github.com/apache/drill/pull/1858#discussion_r336899443 ## File path: contrib/format-esri/src/main/java/org/apache/drill/exec/store/esri/ShpBatchReader.java ##