Github user asfgit closed the pull request at:
https://github.com/apache/drill/pull/1059
---
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r163045737
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinProbeTemplate.java
---
@@ -136,7 +136,9 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162292084
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java
---
@@ -38,13 +37,16 @@
import
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162292571
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -19,19 +19,17 @@
package
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162293231
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -535,4 +541,8 @@ public void close() {
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162289830
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162292685
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -19,20 +19,22 @@
package
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162293578
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java
---
@@ -228,4 +228,20 @@ public WritableBatch
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r162294377
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/JoinTestBase.java
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r161510606
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
---
@@ -354,9 +354,9 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r161510835
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +339,55 @@ public void
Github user vdiravka commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r161512862
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +165,19 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r160542798
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +339,55 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r160542923
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +339,55 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r160540854
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java
---
@@ -228,4 +228,20 @@ public WritableBatch
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158992589
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -305,11 +307,15 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593827
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java
---
@@ -253,4 +259,52 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593774
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,51 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593930
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +341,74 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593845
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +341,74 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593830
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +341,74 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593922
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +341,74 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593808
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java
---
@@ -253,4 +259,52 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593785
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,51 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593793
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,51 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593956
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -305,11 +307,15 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158593969
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -65,11 +65,18 @@ protected boolean
Github user HanumathRao commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r158356421
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
---
@@ -323,8 +323,6 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939344
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/MergeJoinBatch.java
---
@@ -152,7 +152,10 @@ public void buildSchema()
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939440
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,75 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155938557
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -535,4 +537,25 @@ public void close() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939428
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,75 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939350
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/NestedLoopJoinBatch.java
---
@@ -418,4 +418,15 @@ protected void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939472
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +342,96 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939506
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestNullInputMiniPlan.java
---
@@ -323,8 +323,6 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939424
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,75 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939358
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractBinaryRecordBatch.java
---
@@ -65,11 +65,20 @@ protected boolean
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939417
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestHashJoinAdvanced.java
---
@@ -160,4 +166,75 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939449
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestMergeJoinAdvanced.java
---
@@ -253,4 +259,75 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939459
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/join/TestNestedLoopJoin.java
---
@@ -333,4 +342,96 @@ public void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155938551
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -535,4 +537,25 @@ public void close() {
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/AbstractRecordBatch.java
---
@@ -228,4 +228,20 @@ public WritableBatch
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939354
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/union/UnionAllRecordBatch.java
---
@@ -97,6 +97,14 @@ protected void
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/1059#discussion_r155939311
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/join/HashJoinBatch.java
---
@@ -535,4 +537,25 @@ public void close() {
GitHub user HanumathRao opened a pull request:
https://github.com/apache/drill/pull/1059
DRILL-5851: Empty table during a join operation with a non empty tablâ¦
â¦e produces cast exception.
These code changes handle the cases where either of the table in a join is
empty
45 matches
Mail list logo
