Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193132
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193243
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193061
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127192939
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193358
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193028
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193228
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127193320
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the
*Blockers*
DRILL-5659 - problem is identified, Parth is working on the fix.
*Not blockers*
DRILL-5660 - Vitalii
DRILL-5468 - Jinfeng
*Possible blockers*
DRILL-5669 - Boaz Ben-Zvi / Paul
NPE on CSV - Paul
Kind regards
Arina
On Thu, Jul 13, 2017 at 1:28 AM, Paul Rogers wrote:
> I withdraw my s
GitHub user bitblender opened a pull request:
https://github.com/apache/drill/pull/875
DRILL-5671 Set secure ACLs (Access Control List) for Drill ZK nodes in a
secure cluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bit
GitHub user parthchandra opened a pull request:
https://github.com/apache/drill/pull/876
DRILL-5659: Fix error code checking in reading from socket
Check if errorcode is set before checking if the error code is EINTR. Also,
check for error first thing after making the read_some or w
To debug Drill in Eclipse, I ran *./drillbit.sh debug* and copied the VM
args and environment variables into a launcher. This worked fine for months.
Obviously now I messed things up in a way and I can't debug Drill in
Eclipse anymore. I'm facing the following error:
Exception in thread "main"
or
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/876
+1 LGTM
Thanks a lot for catching and fixing this!. I will test it with SASL
encryption case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user superbstreak commented on the issue:
https://github.com/apache/drill/pull/876
Thanks, @parthchandra!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishe
Hi Muhammad,
There are several issues here.
First, the problem you describe is not related to Eclipse. Second, several of
us do use Eclipse and it works fine. Third, there are far easier ways to debug
Drill in Eclipse then building Drill and doing remote debugging.
First the error. The problem
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127295586
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -112,7 +112,8 @@ drill.exec: {
retry: {
count: 7200,
Github user adityakishore commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127295205
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKSecureACLProvider.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Ap
Github user laurentgo commented on the issue:
https://github.com/apache/drill/pull/876
I tested non-SASL case and confirm it fixes the issue. Unfortunately I
don't have any handy SASL-ready setup for now.
Thanks @parthchandra
---
If your project is set up for it, you can re
GitHub user vdiravka opened a pull request:
https://github.com/apache/drill/pull/877
DRILL-5660: Drill 1.10 queries fail due to Parquet Metadata "corruptiâ¦
â¦on" from DRILL-3867
- bump up metadata file version to v3_1;
- ignoring of unknown metadata version (for examp
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127322815
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -658,11 +657,21 @@ private boolean tableModified(Lis
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127323200
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127321352
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127322298
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127320876
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127321261
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127324951
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -139,13 +139,13 @@ public static ParquetTableMetadat
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127324232
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -557,7 +556,7 @@ private void readBlockMeta(String p
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127322605
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1377,7 +1386,7 @@ public void serialize(ColumnMetad
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127324650
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize
Github user arina-ielchiieva commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127324972
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -537,13 +537,12 @@ private void writeFile(ParquetTab
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123845357
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -177,7 +226,7 @@ public RecordBatchSizer(Record
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123839714
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -139,14 +184,16 @@ public String toString() {
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123814368
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -19,117 +19,162 @@
import java.util.
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127345763
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/RepeatedListVector.java
---
@@ -435,20 +438,18 @@ public void copyEntry(int toIndex,
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124437209
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -97,24 +215,43 @@
private
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124106839
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -189,30 +238,29 @@ public RecordBatchSizer(Vect
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124121514
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSortTemplate.java
---
@@ -92,8 +93,9 @@ public void setup(final FragmentCon
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123844716
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -19,117 +19,162 @@
import java.util.
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124428100
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -19,7 +19,125 @@
import com
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124436676
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -19,7 +19,125 @@
import com
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124122190
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/MergeSortWrapper.java
---
@@ -147,7 +147,7 @@ private MSorter create
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127077314
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
@@ -100,10 +102,12 @@ private Pr
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127061135
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/SmartAllocationHelper.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache S
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124122920
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
@@ -82,7 +84,7 @@ private Priori
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123834281
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -19,117 +19,162 @@
import java.util.
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124435170
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -312,52 +488,66 @@ private void adjust
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124909795
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SorterWrapper.java
---
@@ -83,10 +83,9 @@ private SingleBatchSorter
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127344297
--- Diff: exec/vector/src/main/codegen/templates/VariableLengthVectors.java
---
@@ -247,27 +249,26 @@ public void copyEntry(int toIndex, ValueVector from,
in
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127346284
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/RepeatedMapVector.java
---
@@ -598,7 +604,8 @@ public void clear() {
}
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r123838906
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/RecordBatchSizer.java
---
@@ -19,117 +19,162 @@
import java.util.
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127345692
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/ListVector.java
---
@@ -323,12 +325,15 @@ public void setValueCount(int valueCount)
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124430031
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -19,7 +19,125 @@
import com
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127067063
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/SmartAllocationHelper.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache S
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127345445
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/complex/BaseRepeatedValueVector.java
---
@@ -210,13 +212,15 @@ protected void replaceDataVec
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127071648
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/SmartAllocationHelper.java
---
@@ -0,0 +1,156 @@
+/*
+ * Licensed to the Apache S
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124132387
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/PriorityQueueCopierWrapper.java
---
@@ -245,29 +250,35 @@ private Ba
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r124904394
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/managed/SortMemoryManager.java
---
@@ -391,84 +601,93 @@ public MergeTask(Me
[
https://issues.apache.org/jira/browse/DRILL-5445?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Rogers resolved DRILL-5445.
Resolution: Done
> Assertion Error in Managed External Sort when dealing with repeated maps
> --
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127351398
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -239,9 +239,7 @@ drill.exec: {
external: {
// Drill uses the managed E
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127358527
--- Diff:
exec/vector/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java ---
@@ -26,14 +26,16 @@ public static void allocate(ValueVector v, int
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127357111
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClientFixture.java ---
@@ -231,4 +236,120 @@ public void setControls(String controls) {
pu
Github user Ben-Zvi commented on a diff in the pull request:
https://github.com/apache/drill/pull/860#discussion_r127360560
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
@@ -413,7 +419,12 @@ public SpillSet(DrillConfig config, F
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127366251
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/store/parquet/TestParquetMetadataCache.java
---
@@ -446,10 +447,25 @@ public void testMetada
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127365605
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize(Stri
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127365148
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize(Stri
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127365808
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -723,19 +723,20 @@ private void init(MetadataCont
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127363955
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -557,7 +556,7 @@ private void readBlockMeta(String path,
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127364840
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -1851,9 +1860,81 @@ private static String relativize(Stri
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127364108
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/Metadata.java
---
@@ -658,11 +657,21 @@ private boolean tableModified(List
di
Github user paul-rogers commented on a diff in the pull request:
https://github.com/apache/drill/pull/877#discussion_r127365973
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -723,19 +723,20 @@ private void init(MetadataCont
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127367354
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -112,7 +112,8 @@ drill.exec: {
retry: {
count: 7200,
del
Github user bitblender commented on a diff in the pull request:
https://github.com/apache/drill/pull/875#discussion_r127367344
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKSecureACLProvider.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apach
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127383363
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache So
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127383370
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache So
Github user cgivre commented on a diff in the pull request:
https://github.com/apache/drill/pull/865#discussion_r127383405
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/CryptoFunctions.java
---
@@ -0,0 +1,389 @@
+/*
+ * Licensed to the Apache So
75 matches
Mail list logo
