[GitHub] [drill] vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357837735 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ## @@ -406,8

[GitHub] [drill] vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357837603 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ## @@ -406,8

[GitHub] [drill] vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357838630 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/decoder/Packet.java ## @@ -183,6

[GitHub] [drill] cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357836096 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ## @@ -406,8

[GitHub] [drill] cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357835838 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapEVFReader.java ## @@ -99,4

[GitHub] [drill] cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
cgivre commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357835774 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapEVFReader.java ## @@ -99,4

[GitHub] [drill] cgivre opened a new pull request #1934: DRILL-7484 Malware found in the Drill test folder

2019-12-13 Thread GitBox
cgivre opened a new pull request #1934: DRILL-7484 Malware found in the Drill test folder URL: https://github.com/apache/drill/pull/1934 This PR replaces the `attack-trace.pcap` file with `http.pcap` and rewrites accordingly the unit tests for the TCP Sessionization feature.

Re: [ANNOUNCE] New PMC member: Ihor Guzenko

2019-12-13 Thread Pritesh Maker
Congrats Ihor!! On Fri, Dec 13, 2019 at 10:36 AM Paul Rogers wrote: > Congratulations Ihor! > - Paul > > > > On Friday, December 13, 2019, 05:39:14 AM PST, Volodymyr Vysotskyi < > volody...@apache.org> wrote: > > I am pleased to announce that Drill PMC invited Ihor Guzenko to > the PMC and

Re: [ANNOUNCE] New PMC member: Ihor Guzenko

2019-12-13 Thread Paul Rogers
Congratulations Ihor! - Paul On Friday, December 13, 2019, 05:39:14 AM PST, Volodymyr Vysotskyi wrote: I am pleased to announce that Drill PMC invited Ihor Guzenko to the PMC and he has accepted the invitation. Congratulations Ihor and welcome! - Vova (on behalf of Drill PMC)

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357720732 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapEVFReader.java ##

[GitHub] [drill] KazydubB opened a new pull request #1933: DRILL-7473: Parquet reader failed to get field of repeated map

2019-12-13 Thread GitBox
KazydubB opened a new pull request #1933: DRILL-7473: Parquet reader failed to get field of repeated map URL: https://github.com/apache/drill/pull/1933 Jira - [DRILL-7473](https://issues.apache.org/jira/browse/DRILL-7473)

Re: [CANCEL] [VOTE] Release Apache Drill 1.17.0 - rc0

2019-12-13 Thread Vova Vysotskyi
If the PR will be ready to be merged before other blocking Jiras are resolved, we can include it. Kind regards, Volodymyr Vysotskyi On Fri, Dec 13, 2019 at 5:42 PM Charles Givre wrote: > One more thing... > Do you think we could include DRILL-6332 ( > https://github.com/apache/drill/pull/1931

Re: [CANCEL] [VOTE] Release Apache Drill 1.17.0 - rc0

2019-12-13 Thread Charles Givre
One more thing... Do you think we could include DRILL-6332 (https://github.com/apache/drill/pull/1931 )? This seems like a very minor change that could have a significant impact on potential users. I'll get DRILL-7484 and DRILL-7485 cleaned up and

Re: [CANCEL] [VOTE] Release Apache Drill 1.17.0 - rc0

2019-12-13 Thread Volodymyr Vysotskyi
Hi Charles, Yes, I think we can also include this one. Thanks for finding this issue and submitting the fix! Kind regards, Volodymyr Vysotskyi On Fri, Dec 13, 2019 at 5:13 PM Charles Givre wrote: > Hi Volodymyr, > I'm going to get DRILL-7484 resolved over the weekend, but when I started >

[GitHub] [drill] vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357699970 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/store/pcap/PcapBatchReader.java ## @@ -406,8

[GitHub] [drill] vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932#discussion_r357700882 ## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/pcap/TestPcapEVFReader.java ## @@

[GitHub] [drill] vvysotskyi commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-13 Thread GitBox
vvysotskyi commented on issue #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#issuecomment-565482352 @paul-rogers, moving the discussion into another place is a good idea. Perhaps we can continue it in a Jira to

[GitHub] [drill] vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#discussion_r357692806 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#discussion_r357693121 ## File path:

[GitHub] [drill] vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#discussion_r357686862 ## File path:

[GitHub] [drill] cgivre opened a new pull request #1932: DRILL-7485: NPE on PCAP Batch Reader

2019-12-13 Thread GitBox
cgivre opened a new pull request #1932: DRILL-7485: NPE on PCAP Batch Reader URL: https://github.com/apache/drill/pull/1932 The Drill PCAP reader was throwing a NPE if it encountered a packet with a null IP address. This phenomenon can occur in ARP packets before IP addresses are

[GitHub] [drill] vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues

2019-12-13 Thread GitBox
vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial fixes for metadata parameterized type issues URL: https://github.com/apache/drill/pull/1923#discussion_r357679019 ## File path:

[CANCEL] [VOTE] Release Apache Drill 1.17.0 - rc0

2019-12-13 Thread Volodymyr Vysotskyi
Hi all, The vote for Apache Drill 1.17.0 - rc0 was canceled. Thanks to all who voted. A new release will be tagged as 1.17.0-rc1 and will be available after the following jiras are resolved: - DRILL-7473 - Parquet reader failed to get field of

Re: [ANNOUNCE] New PMC member: Ihor Guzenko

2019-12-13 Thread Bohdan Kazydub
Congratulations, well deserved! On Fri, Dec 13, 2019 at 3:50 PM Anton Gozhiy wrote: > Congratulations, well deserved! > > On Fri, Dec 13, 2019 at 3:42 PM Arina Yelchiyeva < > arina.yelchiy...@gmail.com> > wrote: > > > Congratulations, Ihor! > > > > > On Dec 13, 2019, at 3:38 PM, Volodymyr

Re: [ANNOUNCE] New PMC member: Ihor Guzenko

2019-12-13 Thread Anton Gozhiy
Congratulations, well deserved! On Fri, Dec 13, 2019 at 3:42 PM Arina Yelchiyeva wrote: > Congratulations, Ihor! > > > On Dec 13, 2019, at 3:38 PM, Volodymyr Vysotskyi > wrote: > > > > I am pleased to announce that Drill PMC invited Ihor Guzenko to > > the PMC and he has accepted the

Re: [ANNOUNCE] New PMC member: Ihor Guzenko

2019-12-13 Thread Arina Yelchiyeva
Congratulations, Ihor! > On Dec 13, 2019, at 3:38 PM, Volodymyr Vysotskyi wrote: > > I am pleased to announce that Drill PMC invited Ihor Guzenko to > the PMC and he has accepted the invitation. > > Congratulations Ihor and welcome! > > - Vova > (on behalf of Drill PMC)

[ANNOUNCE] New PMC member: Ihor Guzenko

2019-12-13 Thread Volodymyr Vysotskyi
I am pleased to announce that Drill PMC invited Ihor Guzenko to the PMC and he has accepted the invitation. Congratulations Ihor and welcome! - Vova (on behalf of Drill PMC)

[GitHub] [drill] cgivre commented on issue #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
cgivre commented on issue #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#issuecomment-565435846 @j-4 Thanks for the contribution and welcome to Drill!

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#discussion_r357632967 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ##

[GitHub] [drill] arina-ielchiieva commented on issue #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
arina-ielchiieva commented on issue #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#issuecomment-565433401 @j-4 overrall looks good, please address code review comments and update commit message (should be the same as PR

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#discussion_r357633489 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#discussion_r357632967 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#discussion_r357633880 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ##

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1931: DRILL-6332: Allow to provide two-component Kerberos principals URL: https://github.com/apache/drill/pull/1931#discussion_r357633347 ## File path: common/src/main/java/org/apache/drill/common/KerberosUtil.java ##

[GitHub] [drill] j-4 opened a new pull request #1931: Fixes DRILL-6332 by allowing to provide two-component principals

2019-12-13 Thread GitBox
j-4 opened a new pull request #1931: Fixes DRILL-6332 by allowing to provide two-component principals URL: https://github.com/apache/drill/pull/1931 Currently drill only allows for three-component kerberos principals `primary/instance@REALM` I had the requirement to deal with two-part

[jira] [Created] (DRILL-7488) Complex queries on INFORMATION_SCHEMA fail when `planner.slice_target`is small

2019-12-13 Thread Arina Ielchiieva (Jira)
Arina Ielchiieva created DRILL-7488: --- Summary: Complex queries on INFORMATION_SCHEMA fail when `planner.slice_target`is small Key: DRILL-7488 URL: https://issues.apache.org/jira/browse/DRILL-7488

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1925: DRILL-7472: Fix ser / de for sys and information_schema schemas queries

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1925: DRILL-7472: Fix ser / de for sys and information_schema schemas queries URL: https://github.com/apache/drill/pull/1925#discussion_r357612979 ## File path:

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1928: DRILL-7486: Refactor row set reader builders

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1928: DRILL-7486: Refactor row set reader builders URL: https://github.com/apache/drill/pull/1928#discussion_r357611309 ## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/HyperRowIndex.java

[GitHub] [drill] arina-ielchiieva commented on a change in pull request #1928: DRILL-7486: Refactor row set reader builders

2019-12-13 Thread GitBox
arina-ielchiieva commented on a change in pull request #1928: DRILL-7486: Refactor row set reader builders URL: https://github.com/apache/drill/pull/1928#discussion_r357611175 ## File path: