Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99256160
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java
---
@@ -89,14 +89,42 @@ public MessageLite
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99257662
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/BitConnectionConfigImpl.java
---
@@ -0,0 +1,121 @@
+/**
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99257059
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataClient.java ---
@@ -75,27 +85,106 @@ public MessageLite getResponseDefaultInstance
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99261445
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -88,22 +129,183 @@ public void submitQuery(UserResultsListener
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99265626
--- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99260686
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/plain/PlainServer.java
---
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99257914
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionManager.java
---
@@ -21,30 +21,28 @@
import
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99247679
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ConnectionManagerRegistry.java
---
@@ -32,24 +29,19 @@
private final
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99256832
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControllerImpl.java
---
@@ -39,36 +39,33 @@
static final org.slf4j.Logger
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99261692
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserClient.java ---
@@ -88,22 +129,183 @@ public void submitQuery(UserResultsListener
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99257539
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/DataConnectionCreator.java
---
@@ -37,40 +37,28 @@
static final org.slf4j.Logger
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r99678863
--- Diff: contrib/native/client/src/clientlib/saslAuthenticatorImpl.cpp ---
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r102336171
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/package-info.java
---
@@ -60,14 +62,26 @@
* The mode is one of the supported
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r102362622
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java
---
@@ -109,7 +121,37 @@ public MockSchema(MockStorageEngine
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r102320948
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockStorageEngine.java
---
@@ -89,14 +85,30 @@ public boolean supportsRead
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r102294277
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/BooleanGen.java
---
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r102298318
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/fn/interp/ExpressionInterpreterTest.java
---
@@ -124,7 +125,7 @@ public void interpreterDateTest
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/752#discussion_r102360734
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/mock/MockGroupScanPOP.java
---
@@ -75,20 +76,50 @@
*/
private boolean
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102610181
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102603020
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102589695
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102584427
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102613259
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102618884
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102612813
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -42,44 +48,207 @@
public class ProfileParser
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102581476
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -295,8 +396,96 @@ public void close() throws Exception
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102369640
--- Diff: common/src/test/java/org/apache/drill/test/DrillTest.java ---
@@ -69,6 +71,25 @@
@Rule public TestName TEST_NAME = new TestName
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102587851
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ClusterFixture.java ---
@@ -99,33 +111,83 @@
// behavior. Production default
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102600191
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ExampleTest.java ---
@@ -0,0 +1,243 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r102607033
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/752
Thanks for the change. LGTM. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/753
Apart from fixing regex in ProfileParser.java, changes looks good to me.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r103052237
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/753#discussion_r103052249
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/ProfileParser.java ---
@@ -138,9 +414,208 @@ public long getMetric(int id
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/578
Just one last comment regarding moving BitConnectionConfig file. Apart from
that LGTM.
+1 from my side.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r100907447
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/data/BitConnectionConfig.java
---
@@ -0,0 +1,106 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r101175920
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -435,9 +427,14 @@ public synchronized boolean reconnect
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96785327
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/LogFixture.java ---
@@ -0,0 +1,255 @@
+/*
+ * Licensed to the Apache Software Foundation
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96785539
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -57,20 +166,36 @@
private final int records;
private
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/710#discussion_r96785470
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/test/QueryBuilder.java ---
@@ -49,6 +57,107 @@
public class QueryBuilder
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/710
+1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/565#discussion_r82102648
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/server/BootStrapContext.java
---
@@ -53,6 +54,8 @@ public BootStrapContext(DrillConfig config
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/628
DRILL-4964: Drill fails to connect to hive metastore after hive metasâ¦
â¦tore is restarted unless drillbits are restarted also
Changes: For certain methods
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/628
@jinfengni - Can you please help to review ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user sohami reopened a pull request:
https://github.com/apache/drill/pull/628
DRILL-4964: Drill fails to connect to hive metastore after hive metasâ¦
â¦tore is restarted unless drillbits are restarted also
Changes: For certain methods
Github user sohami closed the pull request at:
https://github.com/apache/drill/pull/628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/648
@kkhatua - The unit test I have written is just for validating the newly
introduced "populateEndpointsList" method. I am not actually connecting to the
drillbit from within the test.
-
GitHub user sohami opened a pull request:
https://github.com/apache/drill/pull/648
DRILL-5015: Randomly select the drillbit from the list provided by user in
connection string
@sudheeshkatkam - Please help to review the changes
You can merge this pull request into a Git repository
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87551861
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/InvalidConnectionInfoException.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87551816
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +224,94 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87551857
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/InvalidConnectionInfoException.java
---
@@ -0,0 +1,35 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351921
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351874
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351905
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351696
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351650
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientSystemTest.java
---
@@ -73,4 +77,90 @@ public void testSubmitPlanTwoNodes
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351621
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientSystemTest.java
---
@@ -73,4 +77,90 @@ public void testSubmitPlanTwoNodes
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351912
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351935
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351880
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351662
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -245,14 +291,15 @@ public synchronized void connect(String connect
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87120245
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351891
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351670
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -245,14 +291,15 @@ public synchronized void connect(String connect
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351913
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351895
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r87351682
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +223,65 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86646115
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/fragment/TestLocalAffinityFragmentParallelizer.java
---
@@ -0,0 +1,476
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86605131
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/LocalAffinityFragmentParallelizer.java
---
@@ -0,0 +1,165
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86602221
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/planner/fragment/TestLocalAffinityFragmentParallelizer.java
---
@@ -0,0 +1,476
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/626#discussion_r84428172
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZKClusterCoordinator.java
---
@@ -245,33 +242,29 @@ public DrillbitEndpoint
apply
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/652#discussion_r88072322
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -151,15 +152,11 @@ public WorkspaceSchemaFactory
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/652#discussion_r88072130
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/WorkspaceSchemaFactory.java
---
@@ -151,15 +152,11 @@ public WorkspaceSchemaFactory
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/652
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/633#discussion_r85557510
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/WorkManager.java ---
@@ -295,7 +295,7 @@ public FragmentExecutor getFragmentRunner(final
Github user sohami closed the pull request at:
https://github.com/apache/drill/pull/628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sohami commented on the issue:
https://github.com/apache/drill/pull/628
@jinfengni - Thanks for review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86057320
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -822,10 +838,103 @@ private void getFiles(String path
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86057156
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/EndpointAffinity.java
---
@@ -75,6 +78,7 @@ public EndpointAffinity(final
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86057298
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -530,6 +534,7 @@ public RowGroupInfo(@JsonProperty
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86062215
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/schedule/AssignmentCreator.java
---
@@ -146,6 +153,32 @@ private AssignmentCreator(List
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86060309
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -822,10 +838,103 @@ private void getFiles(String path
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/639#discussion_r86060362
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetGroupScan.java
---
@@ -822,10 +838,103 @@ private void getFiles(String path
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r90091315
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/InvalidConnectionInfoException.java
---
@@ -0,0 +1,29 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91821466
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/ConnectTriesPropertyTestClusterBits.java
---
@@ -0,0 +1,244 @@
+/**
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r91822093
--- Diff:
exec/jdbc/src/test/java/org/apache/drill/jdbc/test/JdbcConnectTriesTestEmbeddedBits.java
---
@@ -0,0 +1,162 @@
+/**
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/679#discussion_r92296665
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -357,10 +357,53 @@ protected void afterExecute(final Runnable r
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/693#discussion_r92462112
--- Diff: pom.xml ---
@@ -423,21 +423,23 @@
maven-surefire-plugin
2.17
--Xms512m -Xmx3g
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/693#discussion_r92472636
--- Diff: exec/memory/base/pom.xml ---
@@ -40,10 +40,21 @@
-
+
+
+
+
--- End
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/693#discussion_r92457956
--- Diff: pom.xml ---
@@ -423,21 +423,23 @@
maven-surefire-plugin
2.17
--Xms512m -Xmx3g
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r90090906
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientTest.java
---
@@ -0,0 +1,258 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r89928539
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -245,14 +327,15 @@ public synchronized void connect(String connect
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r89928643
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/client/DrillClientSystemTest.java
---
@@ -17,11 +17,15 @@
*/
package
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r90089781
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +224,100 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r90089750
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -223,19 +224,100 @@ public void connect(Properties props) throws
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/648#discussion_r89929966
--- Diff:
exec/rpc/src/main/java/org/apache/drill/exec/rpc/InvalidConnectionInfoException.java
---
@@ -0,0 +1,29 @@
+/**
+ * Licensed to the Apache
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r94867052
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/TestKerberosSaslAuthentication.java
---
@@ -0,0 +1,239
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r94701486
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserServer.java ---
@@ -246,28 +163,78 @@ protected void handle(UserClientConnectionImpl
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r94700422
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/user/UserAuthenticationUtil.java
---
@@ -0,0 +1,255 @@
+/**
+ * Licensed
Github user sohami commented on a diff in the pull request:
https://github.com/apache/drill/pull/578#discussion_r94880411
--- Diff: contrib/native/client/src/clientlib/drillClientImpl.hpp ---
@@ -522,6 +534,13 @@ class DrillClientImpl : public DrillClientImplBase{
exec
1 - 100 of 569 matches
Mail list logo
