[GitHub] drill pull request: DRILL-3749: Upgrade Hadoop to 2.7.1

2015-10-14 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/203#issuecomment-148210343 Can you check if we need to update (override new methods) the DrillFileSystem and/or DrillFsDataInputStream which are decorators around hadoop FileSystem

[GitHub] drill pull request: DRILL-3893: Change Hive metadata cache invalid...

2015-10-20 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/212 DRILL-3893: Change Hive metadata cache invalidation policy to "1 min after last write" You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] drill pull request: DRILL-3921: Initialize the underlying record r...

2015-10-13 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/197#issuecomment-147882293 Updated patch LGTM. One thing we could test is whether the ScanBatch is receiving two RecordReaders, so we are sure that we are lazily initializing the second RR

[GitHub] drill pull request: DRILL-3746: Get Hive partition values from Met...

2015-09-10 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/151#discussion_r39177644 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/planner/sql/HivePartitionDescriptor.java --- @@ -62,7 +62,7 @@ public

[GitHub] drill pull request: DRILL-3746: Get Hive partition values from Met...

2015-09-09 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/151 DRILL-3746: Get Hive partition values from MetaStore instead of from … …parsing the partition location path 1) Added a partition with custom location to test Hive table. Existing

[GitHub] drill pull request: Fix for DRILL-3869

2015-09-30 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/178#issuecomment-144545927 I think we can check how SqlLine is trimming the ; at the end and follow the same procedure. --- If your project is set up for it, you can reply to this email

[GitHub] drill pull request: DRILL-3884: Fix lower parallelization issues w...

2015-10-01 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/185 DRILL-3884: Fix lower parallelization issues with Hive's native scan. @amansinha100 Could you please review the patch? You can merge this pull request into a Git repository by running: $ git

[GitHub] drill pull request: DRILL-3884: Fix lower parallelization issues w...

2015-10-01 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/185#discussion_r40982402 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveScan.java --- @@ -319,16 +319,12 @@ public ScanStats getScanStats

[GitHub] drill pull request: DRILL-4159: Use test framework in TestCsvHeade...

2015-12-03 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/289#issuecomment-161794179 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-3938: Support reading from Hive tables t...

2015-12-01 Thread vkorukanti
Github user vkorukanti closed the pull request at: https://github.com/apache/drill/pull/211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-3893: Change Hive metadata cache invalid...

2015-12-01 Thread vkorukanti
Github user vkorukanti closed the pull request at: https://github.com/apache/drill/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: Drill 4127: Reduce Hive metastore client API c...

2015-12-07 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/286#issuecomment-162705796 Have some minor comments on the DRILL-4127. LGTM, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...

2015-12-14 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/300 DRILL-4198: Enhance StoragePlugin interface to expose logical space r… …ules for planning purpose Also move Hive partition pruning rules to logical storage plugin rulesets. You can

[GitHub] drill pull request: DRILL-4198: Enhance StoragePlugin interface to...

2015-12-14 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/300#issuecomment-164601256 @jinfengni Could you please review the patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] drill pull request: DRILL-4194: Improve the performance of metadat...

2015-12-14 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/301 DRILL-4194: Improve the performance of metadata fetch operation in HiveScan + Use the stats (numRows) stored in Hive metastore whenever available to calculate the costs for planning purpose

[GitHub] drill pull request: DRILL-4169: Upgrade Hive storage plugin to wor...

2015-12-15 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/302 DRILL-4169: Upgrade Hive storage plugin to work with Hive 1.2.1 + HadoopShims.setTokenStr is moved to Utils.setTokenStr. There is no change in functionality. + Disable binary partitions

[GitHub] drill pull request: DRILL-3739: (part 2) Fix issues in reading Hiv...

2015-12-29 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/312 DRILL-3739: (part 2) Fix issues in reading Hive tables with StorageHa… …ndler configuration (eg. Hive-HBase tables) Same issue (StorageHandler based tables don't store InputFormat

[GitHub] drill pull request #524: DRILL-4724: Improvements to InfoSchema RecordGenera...

2016-06-15 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/524 DRILL-4724: Improvements to InfoSchema RecordGenerator needed for DRILL-4714 1. Add support for pushing the filter on following fields into InfoSchemaRecordGenerator: - CATALOG_NAME

[GitHub] drill issue #524: DRILL-4725: Improvements to InfoSchema RecordGenerator nee...

2016-06-16 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/524 Updated patch addresses the review comment. Separated the binary and ternary into separate cases with proper variable names. --- If your project is set up for it, you can reply to this email

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-06-20 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/530 DRILL-4729: Add support for prepared statement implementation on server side + Add following APIs for Drill Java client - DrillRpcFuture createPreparedStatement(final String query

[GitHub] drill pull request #532: DRILL-4732: Update JDBC driver to use the new prepa...

2016-06-21 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/532 DRILL-4732: Update JDBC driver to use the new prepared statement APIs in DrillClient Changes specific to DRILL-4732 are in last commit. You can merge this pull request into a Git repository

[GitHub] drill issue #527: DRILL-4728: Add support for new metadata fetch APIs

2016-06-18 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/527 @amansinha100 I am targeting this for 1.8. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-06-17 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/527 DRILL-4728: Add support for new metadata fetch APIs + Protobuf messages - GetCatalogsReq -> GetCatalogsResp - GetSchemasReq -> GetSchemasResp - GetTablesReq -> GetT

[GitHub] drill pull request: DRILL-4256: Create HiveConf per HiveStoragePlu...

2016-01-18 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/329 DRILL-4256: Create HiveConf per HiveStoragePlugin and reuse it wherev… …er needed. Creating new instances of HiveConf() are very costly, we should avoid creating new ones as much

[GitHub] drill pull request: DRILL-4354: Remove sessions in anonymous (auth...

2016-02-04 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/360 DRILL-4354: Remove sessions in anonymous (auth disabled) WebUI access You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill DRILL

[GitHub] drill pull request: DRILL-4322: Add underlying exception message w...

2016-01-28 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/344#issuecomment-176360941 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] drill pull request: DRILL-4328: Fix backward compatibility regress...

2016-01-29 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/348 DRILL-4328: Fix backward compatibility regression caused by DRILL-4198 You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill

[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...

2016-02-24 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/390#issuecomment-188531968 Not sure of the policy around changing public APIs, but I think it is better to keep the method around to avoid breaking existing storage plugins until next major

[GitHub] drill pull request: DRILL-4354: Remove sessions in anonymous (auth...

2016-02-26 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/360#discussion_r54273230 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/DrillRestServer.java --- @@ -102,4 +112,34 @@ public void dispose

[GitHub] drill pull request: DRILL-4354: Remove sessions in anonymous (auth...

2016-02-26 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/360#discussion_r54273249 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/auth/DrillUserPrincipal.java --- @@ -60,13 +63,21 @@ public String getName

[GitHub] drill pull request: DRILL-4434: Deprecate GroupScan.enforceWidth A...

2016-02-24 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/390 DRILL-4434: Deprecate GroupScan.enforceWidth API You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill DRILL-4434 Alternatively

[GitHub] drill pull request: DRILL-4410: ListVector should initialize bits ...

2016-02-18 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/380#discussion_r53366855 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/vector/complex/writer/TestComplexTypeReader.java --- @@ -241,4 +252,49 @@ public void

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-03-11 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/425 DRILL-1328: Support table statistics Patch attached to the JIRA is seems to be useful for generating table stats and using them for query planning. I rebased the patch to latest master, fixed

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58759667 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58751970 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58757405 --- Diff: exec/java-exec/src/test/java/org/apache/drill/TestJoinNullable.java --- @@ -407,11 +342,94 @@ public void

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58753354 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[GitHub] drill pull request: DRILL-4593: Remove OldAssignmentCreator in Fil...

2016-04-07 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/473 DRILL-4593: Remove OldAssignmentCreator in FileSystemPlugin + Remove dead code in ParquetGroupScan You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-05 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/462 DRILL-4539: Add support for Null Equality Joins @amansinha100 @jacques-n Could you please review the patches? You can merge this pull request into a Git repository by running: $ git pull

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58617109 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,56 @@ public String

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r58616976 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/AbstractSchema.java --- @@ -194,4 +195,26 @@ public void dropTable(String tableName

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-04-12 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/403#issuecomment-209094651 Updated patch, Addressed review comments and also added couple of negative tests. --- If your project is set up for it, you can reply to this email and have

[GitHub] drill pull request: DRILL-4527: remove DrillAvgVarianceConvertlet

2016-04-12 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/441#issuecomment-209095889 LGTM, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58741416 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58742546 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillRelOptUtil.java --- @@ -169,4 +176,223 @@ private static boolean

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-06 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r58742916 --- Diff: exec/java-exec/src/main/codegen/templates/ComparisonFunctions.java --- @@ -215,6 +192,36 @@ public void eval

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-03-22 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/425#discussion_r57026410 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java --- @@ -0,0 +1,295

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-03-26 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/425#issuecomment-201911246 @amansinha100 Thanks for reviewing, I haven't tested when the table has parquet metadata cache and stats. I will test it before posting the updated patch

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

2016-03-03 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54979630 --- Diff: exec/java-exec/src/test/java/org/apache/drill/exec/rpc/user/security/testing/UserAuthenticatorToTestDelegation.java --- @@ -0,0 +1,72

[GitHub] drill pull request: DRILL-4281: Support authorized users to delega...

2016-03-03 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/400#discussion_r54980440 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/util/UserDelegationUtil.java --- @@ -0,0 +1,147 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-04 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/403#issuecomment-192332765 Patch update. + Address review comments including unittest for HardAffinityFragmentParallelizer + Fix Limit0 issue when one of the GroupScans in limit0 query

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-03-02 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/403 DRILL-4446: Support mandatory work assignment to endpoint requirements of operators You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] drill pull request: DRILL-4354: Remove sessions in anonymous (auth...

2016-03-07 Thread vkorukanti
Github user vkorukanti closed the pull request at: https://github.com/apache/drill/pull/360 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4483: Fix text plan regression in query ...

2016-03-07 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/411 DRILL-4483: Fix text plan regression in query profiles You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill profile_fix

[GitHub] drill pull request: DRILL-3745: Hive CHAR not supported

2016-03-01 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/399#issuecomment-190757236 LGTM, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4544: Improve error messages for REFRESH...

2016-03-31 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/448#discussion_r58144615 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/handlers/RefreshMetadataHandler.java --- @@ -64,6 +65,11 @@ public PhysicalPlan

[GitHub] drill pull request: DRILL-4550: Add support more time units in ext...

2016-03-29 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/453 DRILL-4550: Add support more time units in extract function Calcite changes are pending in CALCITE-1177 You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] drill pull request: DRILL-4603: Refactor FileSystem plugin code to...

2016-04-13 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/476 DRILL-4603: Refactor FileSystem plugin code to allow customizations - Add a FileSystemPluginImplementationProvider to allow customizing: - Configuration - WorkspaceSchemaFactory lists

[GitHub] drill pull request: DRILL-4603: Refactor FileSystem plugin code to...

2016-04-21 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/476#discussion_r60631846 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPluginImplementationProvider.java --- @@ -0,0 +1,141

[GitHub] drill pull request: DRILL-4603: Refactor FileSystem plugin code to...

2016-04-21 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/476#issuecomment-213052943 Updated patch: - Add optional Hadoop configuration override for WorkspaceConfig - Rename FormatSelect to FileSystemReadEntry. An additional entry

[GitHub] drill pull request: DRILL-4577: Construct a specific path for quer...

2016-04-26 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/461#discussion_r61177455 --- Diff: contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/schema/HiveDatabaseSchema.java --- @@ -72,4 +80,76 @@ public String

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-05-18 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/425#issuecomment-220124783 Updated patch. Also added a brief design and usage doc to JIRA. Waiting for CALCITE-1241. --- If your project is set up for it, you can reply to this email and have

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-05-18 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/425#discussion_r63805497 --- Diff: exec/jdbc-all/pom.xml --- @@ -441,7 +441,7 @@ This is likely due to you adding new dependencies to a java-exec

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-05-18 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/425#issuecomment-220186692 Just want to clarify. There are TODOs and somethings may not work in certain cases. Consider this patch as alpha feature. Needs more work to make it a full fledged

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-05-18 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/425#discussion_r63806827 --- Diff: exec/jdbc-all/pom.xml --- @@ -441,7 +441,7 @@ This is likely due to you adding new dependencies to a java-exec

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-05-18 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/425#issuecomment-220101853 Tested with parquet metadata cache. Currently if you do a count(*) on parquet table having metadata cache, we get that count from cache. For rowcount in planning

[GitHub] drill pull request: DRILL-1328: Support table statistics

2016-05-18 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/425#discussion_r63745018 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/StatisticsAggrFunctions.java --- @@ -0,0 +1,295

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-15 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/462#issuecomment-210546147 Updated PR to handle mixed EQUALS and IS NOT DISTINCT FROM in same join condition. @amansinha100 Could you please review the latest commit in the PR? --- If your

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-15 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/462#discussion_r59943901 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/common/HashTableConfig.java --- @@ -22,25 +22,36 @@ import

[GitHub] drill pull request: DRILL-4459: SchemaChangeException while queryi...

2016-04-18 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/431#issuecomment-211483421 Updated PR LGTM, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request: DRILL-4613: Skip the plugin if it throws error...

2016-04-18 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/483 DRILL-4613: Skip the plugin if it throws errors when registering schemas You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-14 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/462#issuecomment-210244225 It seems like mixed condition of EQUALS and IS NOT DISTINCT FROM in the same join condition can be supported few changes. Here are the WIP changes [1]. Need to test

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-14 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/462#issuecomment-209836956 Added few more tests: ```SELECT * FROM t1, t2, t3 WHERE t1.a = t2.a OR (t1.b is null and t3.b is null)``` to test it throws CannotPlanException ```SELECT

[GitHub] drill pull request: DRILL-4446: Support mandatory work assignment ...

2016-04-13 Thread vkorukanti
Github user vkorukanti closed the pull request at: https://github.com/apache/drill/pull/403 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill pull request: DRILL-4562: Fix bug with nested union expressi...

2016-04-13 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/455#issuecomment-209641593 LGTM, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] drill pull request: DRILL-4539: Add support for Null Equality Join...

2016-04-14 Thread vkorukanti
Github user vkorukanti commented on the pull request: https://github.com/apache/drill/pull/462#issuecomment-210056992 I haven't tried this, but wondering whether this is sufficient to handle mix of EQUALS and IS NOT DISTINCT FROM cases. Maintain a list (one for each join condition

[GitHub] drill pull request #548: DRILL-4785: Avoid checking for hard affinity scans ...

2016-07-18 Thread vkorukanti
GitHub user vkorukanti opened a pull request: https://github.com/apache/drill/pull/548 DRILL-4785: Avoid checking for hard affinity scans in limit 0 shortcut cases You can merge this pull request into a Git repository by running: $ git pull https://github.com/vkorukanti/drill

[GitHub] drill pull request #548: DRILL-4785: Avoid checking for hard affinity scans ...

2016-07-19 Thread vkorukanti
Github user vkorukanti closed the pull request at: https://github.com/apache/drill/pull/548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] drill issue #548: DRILL-4785: Avoid checking for hard affinity scans in limi...

2016-07-19 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/548 Merged as 34ca63ba188e593c961e0b665ac44cd3de2b6b22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill issue #543: DRILL-4768: Fix leaking hive meta store connection in Dril...

2016-07-11 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/543 Change seems reasonable to me. One thing: is the reconnect() call not closing the existing connection? If yes why are we leaking the connections? I think there is one more place we need

[GitHub] drill issue #543: DRILL-4768: Fix leaking hive meta store connection in Dril...

2016-07-12 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/543 LGTM, +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73767987 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -411,6 +420,98 @@ public void runQuery(QueryType type, List

[GitHub] drill issue #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/527 Rebased the patch and addressed review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73769636 --- Diff: exec/jdbc-all/pom.xml --- @@ -441,7 +441,7 @@ This is likely due to you adding new dependencies to a java-exec

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73769668 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/MetadataProvider.java --- @@ -0,0 +1,451 @@ +/** + * Licensed

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73767470 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java --- @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73764733 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/ops/QueryContext.java --- @@ -97,7 +94,7 @@ public QueryContext(final UserSession session

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73767170 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/pojo/PojoRecordReader.java --- @@ -47,24 +46,30 @@ import

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73769951 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/MetadataProvider.java --- @@ -0,0 +1,451 @@ +/** + * Licensed

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/530#discussion_r73929975 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java --- @@ -0,0 +1,419 @@ +/** + * Licensed

[GitHub] drill issue #530: DRILL-4729: Add support for prepared statement implementat...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/530 Added option for changing the timeout. Also added a new RequestStatus type `TIMEOUT`. @parthchandra New changes are in a separate commit. I will create a JIRA for adding cancel. --- If your

[GitHub] drill issue #530: DRILL-4729: Add support for prepared statement implementat...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on the issue: https://github.com/apache/drill/pull/530 pushed the squashed commit that contains the review changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] drill pull request #532: DRILL-4732: Update JDBC driver to use the new prepa...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/532#discussion_r73940855 --- Diff: exec/jdbc/src/main/java/org/apache/drill/jdbc/impl/DrillConnectionImpl.java --- @@ -362,12 +364,33 @@ public PreparedStatement prepareStatement

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/530#discussion_r73944827 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java --- @@ -0,0 +1,427 @@ +/** + * Licensed

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/530#discussion_r73944776 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java --- @@ -0,0 +1,427 @@ +/** + * Licensed

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/530#discussion_r73944757 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java --- @@ -512,6 +526,61 @@ public void runQuery(QueryType type, List

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-08-08 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/530#discussion_r73945771 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java --- @@ -0,0 +1,427 @@ +/** + * Licensed

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-05 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73767387 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/store/SchemaTreeProvider.java --- @@ -0,0 +1,105 @@ +/** + * Licensed to the Apache

[GitHub] drill pull request #527: DRILL-4728: Add support for new metadata fetch APIs

2016-08-07 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/527#discussion_r73807725 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/metadata/MetadataProvider.java --- @@ -0,0 +1,451 @@ +/** + * Licensed

[GitHub] drill pull request #530: DRILL-4729: Add support for prepared statement impl...

2016-08-07 Thread vkorukanti
Github user vkorukanti commented on a diff in the pull request: https://github.com/apache/drill/pull/530#discussion_r73822639 --- Diff: exec/java-exec/src/main/java/org/apache/drill/exec/work/prepare/PreparedStatementProvider.java --- @@ -0,0 +1,419 @@ +/** + * Licensed

  1   2   >