Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184585775
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184585959
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184586222
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1237
IMO, it is better not to report memory usage at all compared to reporting a
wrong number. In case incoming batches are accumulated in a queue, they should
be reported as owned by a receiver. Taking
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184589826
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184554299
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184558425
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184554436
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -149,25 +149,32 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1237#discussion_r184559429
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/unorderedreceiver/UnorderedReceiverBatch.java
---
@@ -201,6 +208,11 @@ public
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1224#discussion_r185225979
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillConformance.java
---
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1235
My take is that "append" is more common for classes with the similar
functionality, see for example `ToStringBuilder`. As there is no added benefit
of using "print" vs "a
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1236
LGTM. Please squash commits.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1013#discussion_r147443404
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
---
@@ -57,17 +57,17 @@ private
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1013#discussion_r147445561
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
---
@@ -57,17 +57,17 @@ private
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1012
@vvysotskyi It is a major version change of the dependency, but except for
the pom file changes, there are no other changes. It will be good to understand
what triggered a major version change (do
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1013#discussion_r147466798
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/security/ClientAuthenticatorProvider.java
---
@@ -57,17 +57,17 @@ private
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1012
@vvysotskyi OK, thanks. Currently, gis unit tests only work with CSV
geo-spacial data. It sounds that JSON format is also supported and is not
covered by the gis unit tests. Can you confirm if JSON
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1058#discussion_r158416355
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/cache/VectorSerializer.java
---
@@ -62,27 +72,65 @@ public Writer write(VectorAccessible va
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1058
@paul-rogers Please review
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1069
@MitchelLabonte @arina-ielchiieva I don't think that Drill needs that many
threads/acceptors to handle HTTP(s) requests as it is not a real web (REST API)
server. For proper resource utilization
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1069
@MitchelLabonte My proposal is to limit the number of acceptors instead of
allowing to increase the max number of threads in the connection pool. If the
number of acceptors is limited, the number
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1058#discussion_r161842736
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/spill/SpillSet.java
---
@@ -104,9 +107,17 @@
* nodes provide
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1090
LGTM, please rebase + squash to resolve conflicts.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r164040082
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSortImpl.java
---
@@ -466,10 +469,10 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r164015707
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSortImpl.java
---
@@ -466,10 +469,10 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1099#discussion_r164165401
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java ---
@@ -94,7 +94,7 @@ private String getStringProperty(String name
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r163999199
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java
---
@@ -31,8 +31,9 @@
private int length
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1099#discussion_r164010865
--- Diff:
contrib/storage-hive/core/src/main/codegen/templates/ObjectInspectors.java ---
@@ -169,9 +169,9 @@ public Boolean getPrimitiveJavaObject(Object o
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1099#discussion_r164010530
--- Diff:
contrib/storage-hbase/src/test/java/org/apache/drill/hbase/TestOrderedBytesConvertFunctions.java
---
@@ -54,7 +54,7 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1099#discussion_r164012734
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/ssl/SSLConfigClient.java ---
@@ -94,7 +94,7 @@ private String getStringProperty(String name
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164519147
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache Software
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1099
Travis CI failed due to a known issue
`TestSortImpl.testLargeBatch:502->runJumboBatchTest:475->runLargeSortTest:454
Value of 1:0 expected:<0> but was:<1>` unrelated to the SS
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1099
LGTM, please squash.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1099
What was the reason to revert the change in SSLConfigClient.java?
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164520611
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -703,7 +703,18 @@ protected void _setLong(int index, long value
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164600674
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache Software
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r164506523
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/util/MemoryUtils.java ---
@@ -0,0 +1,186 @@
+/**
+ * Licensed to the Apache Software
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1099
@reudismam For drill, merging/squashing on github is not an option (due to
the way how Apache Drill git is setup). Please rebase and squash.
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1099
@reudismam Travis fails in other PRs as well. See #1105.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1060#discussion_r165552608
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -703,7 +703,18 @@ protected void _setLong(int index, long value
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1090
+1
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1113
DRILL-5902: Regression: Queries encounter random failure due to RPC
connection timed out
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1113
@arina-ielchiieva Please review
---
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1113
@ilooner DRILL-6143 is not related to DRILL-5902. DRILL-6143 requires a
separate RCA. See DRILL-5902 for details.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166838809
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +512,49 @@ public static boolean
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166832638
--- Diff: common/pom.xml ---
@@ -45,6 +45,7 @@
org.apache.calcite
calcite-core
+ ${calcite.version}
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166832879
--- Diff: contrib/storage-hive/core/pom.xml ---
@@ -58,6 +58,10 @@
commons-codec
commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166842824
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167089878
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java
---
@@ -55,10 +56,10 @@
public RETURN
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167092037
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/TestSortSpillWithException.java
---
@@ -59,6 +59,7 @@ public static void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167088606
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/PrelVisitor.java
---
@@ -35,7 +38,9 @@
public RETURN visitScan
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167091413
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java
---
@@ -0,0 +1,58 @@
+/**
+ * Licensed
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167090991
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java
---
@@ -0,0 +1,58 @@
+/**
+ * Licensed
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166513403
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166510396
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +510,52 @@ public static boolean
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166512235
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +510,52 @@ public static boolean
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166513525
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166507937
--- Diff: common/pom.xml ---
@@ -45,6 +45,7 @@
org.apache.calcite
calcite-core
+ ${calcite.version}
--- End diff
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166513062
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166508479
--- Diff: contrib/storage-hive/core/pom.xml ---
@@ -58,6 +58,10 @@
commons-codec
commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166508171
--- Diff: contrib/storage-hive/core/pom.xml ---
@@ -101,6 +105,7 @@
org.apache.calcite
calcite-core
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r166512379
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/HiveUtilities.java
---
@@ -507,5 +510,52 @@ public static boolean
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1119#discussion_r167312527
--- Diff: exec/java-exec/src/main/resources/drill-module.conf ---
@@ -413,6 +413,7 @@ drill.exec.options: {
# to start at least 2 partitions
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167589289
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/HashToRandomExchangePrel.java
---
@@ -112,6 +120,73 @@ public RelWriter
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167616026
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167626024
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/ExchangePrel.java
---
@@ -34,4 +37,14 @@ public ExchangePrel(RelOptCluster
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167587159
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167625240
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/OrderedMuxExchange.java
---
@@ -0,0 +1,64 @@
+/**
+ * Licensed
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167586208
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractExchange.java
---
@@ -119,7 +119,7 @@ public final void setupReceivers
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1119
LGTM
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167960149
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/UnorderedMuxExchange.java
---
@@ -37,14 +37,8 @@ public UnorderedMuxExchange
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167954543
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/UnorderedMuxExchange.java
---
@@ -37,14 +37,8 @@ public UnorderedMuxExchange
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167956002
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/physical/visitor/InsertLocalExchangeVisitor.java
---
@@ -20,133 +20,41 @@
import
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167953826
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/AbstractMuxExchange.java
---
@@ -90,6 +92,24 @@ public Sender getSender(int
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1110#discussion_r167988964
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/AbstractMuxExchange.java
---
@@ -92,24 +92,19 @@ public Sender getSender(int
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1110
LGTM, please squash two last commits.
---
GitHub user vrozov opened a pull request:
https://github.com/apache/drill/pull/1122
DRILL-6164: Heap memory leak during parquet scan and OOM
@parthchandra Please take a look
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1122
The functional test failure is fixed. Please merge.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1113#discussion_r168935308
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryStateProcessor.java
---
@@ -125,20 +125,17 @@ public void cancel
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169351388
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
---
@@ -143,7 +143,7 @@ private void init
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169354613
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -34,28 +34,47 @@
hive-exec
compile
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169360386
--- Diff: contrib/storage-hive/hive-exec-shade/pom.xml ---
@@ -39,23 +39,28 @@
log4j
- commons-codec
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/#discussion_r169348315
--- Diff:
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/readers/HiveAbstractReader.java
---
@@ -86,7 +86,7 @@
protected
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1113#discussion_r168599100
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/work/foreman/QueryStateProcessor.java
---
@@ -125,20 +125,17 @@ public void cancel
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1122
One of the functional tests fails. I am looking into it, please don't merge
yet.
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1070#discussion_r158331061
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/fn/impl/XXHash.java ---
@@ -166,9 +164,7 @@ public static long hash64(double val, long seed
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1070#discussion_r158335955
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/BoundsChecking.java
---
@@ -17,19 +17,92 @@
*/
package
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1070#discussion_r158334992
--- Diff:
exec/memory/base/src/main/java/org/apache/drill/exec/memory/BoundsChecking.java
---
@@ -17,19 +17,92 @@
*/
package
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1075
@paul-rogers Please review
---
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r161384235
--- Diff: exec/memory/base/src/main/java/io/netty/buffer/DrillBuf.java ---
@@ -851,48 +851,52 @@ public void print(StringBuilder sb, int indent,
Verbosity
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r163093794
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSortImpl.java
---
@@ -466,10 +469,10 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r162772482
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java
---
@@ -100,8 +101,8 @@ public boolean next
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r163093639
--- Diff:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/xsort/managed/TestSortImpl.java
---
@@ -466,10 +469,10 @@ public void
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1090#discussion_r162771968
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/record/selection/SelectionVector4.java
---
@@ -31,8 +31,9 @@
private int length
Github user vrozov commented on the issue:
https://github.com/apache/drill/pull/1105
@ilooner @arina-ielchiieva How `innerNext()` and `close()` can execute
concurrently? Does not `FragmentExecutor.hasCloseoutThread` ensure that either
`close()` is called on the `run()` thread or `run
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172678483
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/control/ControlClient.java
---
@@ -103,6 +96,23 @@ protected void handle(ControlConnection
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172718426
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -69,6 +74,11 @@
private final IdlePingHandler pingHandler
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172642452
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -371,17 +376,20 @@ protected void afterExecute(final Runnable r
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172667685
--- Diff:
exec/java-exec/src/main/java/org/apache/drill/exec/client/DrillClient.java ---
@@ -312,6 +312,11 @@ public synchronized void connect(String connect
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/drill/pull/1145#discussion_r172678133
--- Diff: exec/rpc/src/main/java/org/apache/drill/exec/rpc/BasicClient.java
---
@@ -182,6 +196,66 @@ public boolean isActive() {
protected
101 - 200 of 342 matches
Mail list logo
