Java script engine to be removed

http://openjdk.java.net/jeps/335 https://bugs.openjdk.java.net/browse/JDK-8202786 The javascript Nashorn engine is deprecated and slated to be removed in the next long term support release of Java. https://github.com/apache/incubator-druid/issues/5589 is the ticket for maintaining future java

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522407 ## File path: processing/src/main/java/io/druid/query/topn/TopNMapFn.java ## @@ -56,14

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522331 ## File path: processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522870 ## File path: sql/src/main/java/io/druid/sql/calcite/rel/DruidSemiJoin.java ## @@ -294,7

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522236 ## File path: processing/src/main/java/io/druid/query/filter/ValueGetter.java ## @@

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522408 ## File path: processing/src/main/java/io/druid/query/topn/TopNMapFn.java ## @@ -56,14

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522877 ## File path: sql/src/main/java/io/druid/sql/calcite/planner/DruidRexExecutor.java ## @@

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r20250 ## File path: processing/src/main/java/io/druid/query/filter/SelectorDimFilter.java ##

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522796 ## File path:

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522163 ## File path:

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522677 ## File path:

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522841 ## File path: sql/src/main/java/io/druid/sql/calcite/planner/Calcites.java ## @@ -107,6

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522346 ## File path: processing/src/main/java/io/druid/query/groupby/orderby/DefaultLimitSpec.java

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522880 ## File path: sql/src/main/java/io/druid/sql/calcite/rel/DruidSemiJoin.java ## @@

[GitHub] leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling

leventov commented on a change in pull request #5958: Part 2 of changes for SQL Compatible Null Handling URL: https://github.com/apache/incubator-druid/pull/5958#discussion_r202522124 ## File path: common/src/main/java/io/druid/math/expr/ExprEval.java ## @@ -245,36

[GitHub] asdf2014 commented on issue #5980: Various changes about a few coding specifications

asdf2014 commented on issue #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#issuecomment-405040192 Sorry, i didn't notice it. I will fix it. Thanks for your comments. @leventov

[GitHub] asdf2014 commented on a change in pull request #5980: Various changes about a few coding specifications

asdf2014 commented on a change in pull request #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r202521455 ## File path: services/src/main/java/io/druid/cli/CliCoordinator.java ## @@ -255,6 +255,6

[GitHub] pdeva commented on issue #3151: Add a "druid" deep storage.

pdeva commented on issue #3151: Add a "druid" deep storage. URL: https://github.com/apache/incubator-druid/issues/3151#issuecomment-405033630 bump This is an automated message from the Apache Git Service. To respond to the

[GitHub] leventov commented on a change in pull request #5980: Various changes about a few coding specifications

leventov commented on a change in pull request #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r202515505 ## File path: services/src/main/java/io/druid/cli/CliInternalHadoopIndexer.java ## @@

[GitHub] leventov commented on a change in pull request #5980: Various changes about a few coding specifications

leventov commented on a change in pull request #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r202515372 ## File path: services/src/main/java/io/druid/cli/CliCoordinator.java ## @@ -255,6 +255,6

[GitHub] leventov commented on a change in pull request #5980: Various changes about a few coding specifications

leventov commented on a change in pull request #5980: Various changes about a few coding specifications URL: https://github.com/apache/incubator-druid/pull/5980#discussion_r202515329 ## File path: server/src/test/java/io/druid/initialization/InitializationTest.java ## @@