Hi, lan
Agree with you.
It's great for shorter, cleaner, more efficient logic optimizing. So I suggest
that modifications including grammar sugar purposed for shorter, cleaner or
more efficient are great but not just rewriting with another form. I surely
will not object it, too.
But pay
Jason,
Totally agree with you on this point. We should focus less on grammar sugar
but focus more on make the code clean, for say: divide long method into
shorter methods, better naming, or better doc, or even better design.
But on the other hand, if someone from the community shows enthusiasm
good idea. It'd be even better if you could group all ideas backed by
issues into a dedicated project.
Thanks,
-Ian.
On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet wrote:
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in
Hi,
On Tue, Jan 29, 2019 at 11:00 AM Jason Joo wrote:
>
> Hi, Huxing & LiZhen
>
> Things like diamond is something called grammar SUGAR.
> Tasted good for developers but the same on byte code.
>
> So in my opinion we should not take it as a kind of "policy correct".
> we can make the changes in
Bravo.
On Sun, Jan 27, 2019 at 8:19 PM Mercy Ma wrote:
> Hello Dubbo Community,
>
> I'm glad to announce that Apache Dubbo(Incubator) Spring Boot 0.2.1 and
> 0.1.2 have been released and are now available from Maven Central.
>
> Release Notes:
> 0.2.1:
>
>
Good plan. For anyone who's reading this thread, if you have anything you
feel it should be included in 2.6.6 release, pls. reply the email and let
Minxuan know it.
Thanks,
-Ian.
On Fri, Jan 25, 2019 at 2:45 PM Minxuan Zhuang wrote:
> Hi all:
> in Dubbo 2.6.6 i'm planning to include the
Hi, @lizhen
Your pr seems to have some problems, so I have already commented below and
explained that please resubmit a pr. If you can solve this problem directly
on your branch, you can tell me, of course I will reopen your pr. But
before that, I didn't think that reviewing 30,000 lines of code
Hi, Huxing & LiZhen
Things like diamond is something called grammar SUGAR.
Tasted good for developers but the same on byte code.
So in my opinion we should not take it as a kind of "policy correct".
we can make the changes in the code of recent PRs but not for all the code.
Think about there
I don't know why he showed that the entire file was modified, even though
he only modified one line. You can check it.
yuhang xiu 于2019年1月29日周二 上午10:43写道：
> Your pr has modified more than 30,000 lines of code, and most of them are
> modifications of the entire file.
> What is the meaning of
Your pr has modified more than 30,000 lines of code, and most of them are
modifications of the entire file.
What is the meaning of your pr? Why do I need to keep it open?
If you need to discuss, issues and mailing lists are good choices, why do
you need to discuss pr?
Who can review this pr[1]
Yes, we can create a project to manage it, and we can talk about it. like:
Should we used Diamond Operator replace explicit type? Use Lambda?
Let's discuss the two pull requests above instead of closed it immediately.
Huxing Zhang 于2019年1月29日周二 上午9:58写道：
> Hi,
>
> Nice suggestion!
>
>
yes, it's licensed under apache license 2.0:
https://github.com/dubbo/dubbo-metrics/blob/master/LICENSE
On Mon, Jan 28, 2019 at 10:51 PM Ian Luo wrote:
> +1 to put it under dubbo group for now. One minor question, is the source
> code compliance to apache software license v2?
>
> Thanks,
>
Hi,
Nice suggestion!
Shall we can create a project to manage it?
On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet wrote:
>
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming in the code. And there are some
> code that can use the
+1 to put it under dubbo group for now. One minor question, is the source
code compliance to apache software license v2?
Thanks,
-Ian.
On Thu, Jan 24, 2019 at 11:48 AM Minxuan Zhuang wrote:
> Hi all:
> I'm planning to open source a metrics sdk implemented in java, and
> use it as the
Congratulations.
On Fri, Jan 25, 2019 at 11:40 AM Huxing Zhang wrote:
> Hi Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Xianjun Ke,
> a.k.a. kexianjun[1], has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Xianjun,
+1 for Nanjing. I think any weekend in March sounds fine to me.
Thanks,
-Ian.
On Mon, Jan 28, 2019 at 5:12 PM Huxing Zhang wrote:
> Hi,
>
> On Mon, Jan 28, 2019 at 11:19 AM 王蓉(涂南) wrote:
>
> > Hi guys,
> >
> > Last week meetup in Guangzhou was so much fun.
> > We have total 400+ registrations
Agree, we should consider seriously both HTTP/2 and rsocket.
Thanks,
-Ian.
On Thu, Jan 24, 2019 at 10:59 AM Taosheng, Wei
wrote:
> Lan,
> Yes, I think http2 and some new protocols such as rsocket can be
> considered.
> I will spend some time to study this issue.
>
>
> Warm regards,
> Taosheng
@beiwei, @yuhang
1. https://github.com/apache/incubator-dubbo/pull/3344
SkipFailbackWrapperException is added at 2012-07-13 , but never used ,I
think it should be added when it is needed。
2.https://github.com/apache/incubator-dubbo/pull/3371
Diamond Operator is a feature in jdk7.
Hi,
On Mon, Jan 28, 2019 at 11:19 AM 王蓉(涂南) wrote:
> Hi guys,
>
> Last week meetup in Guangzhou was so much fun.
> We have total 400+ registrations and more than 200 attendees, another 4k
> people watched our live streaming!
>
> I think we should start to prepare next meetup in Nanjing ASAP. As
19 matches
Mail list logo
