Re: [Discuss] About Clean Code Plan

[Jason Joo]

Hi, lan

Agree with you.

It's great for shorter, cleaner, more efficient logic optimizing. So I suggest 
that modifications including grammar sugar purposed for shorter, cleaner or 
more efficient are great but not just rewriting with another form. I surely 
will not object it, too.

But pay attention to some features or new styles that will generate more 
objects.

I think it would be more simple and easy we organize these as a kind of issue. 
Focused and small PRs are easy to review after all.

best regards,

Jason

> On Jan 29, 2019, at 14:38, Ian Luo  wrote:
> 
> Jason,
> 
> Totally agree with you on this point. We should focus less on grammar sugar
> but focus more on make the code clean, for say: divide long method into
> shorter methods, better naming, or better doc, or even better design.
> 
> But on the other hand, if someone from the community shows enthusiasm for
> updating code with new sugar, I will not object to the effort as long as it
> doesn't hurt readability, after all it is low hanging fruit :)
> 
> What I propose is we should gather all possible ideas and group them in one
> project on GitHub [1], like I said in my previous email. It is critical to
> make the code clean as much as possible in my opinion. It deserves one
> dedicated project to track all ideas. By doing this, the community can also
> understand the current focuses are.
> 
> So my question is, should we init a project focusing on clean code, while
> the purpose doesn't limit to grammar sugar?
> 
> Regards,
> -Ian.
> 
> 1. https://github.com/apache/incubator-dubbo/projects
> 
> On Tue, Jan 29, 2019 at 11:00 AM Jason Joo  wrote:
> 
>> Hi, Huxing & LiZhen
>> 
>> Things like diamond is something called grammar SUGAR.
>> Tasted good for developers but the same on byte code.
>> 
>> So in my opinion we should not take it as a kind of "policy correct".
>> we can make the changes in the code of recent PRs but not for all the
>> code. Think about there may be more sugars in future JVM.
>> 
>> best regards,
>> 
>> Jason
>> 
>>> On Jan 29, 2019, at 10:42, yuhang xiu  wrote:
>>> 
>>> Your pr has modified more than 30,000 lines of code, and most of them are
>>> modifications of the entire file.
>>> What is the meaning of your pr? Why do I need to keep it open?
>>> 
>>> If you need to discuss, issues and mailing lists are good choices, why do
>>> you need to discuss pr?
>>> 
>>> Who can review this pr[1] and tell me what this pr is going to do?
>>> 
>>> [1] https://github.com/apache/incubator-dubbo/pull/3371
>>> 
>>> LiZhenNet  于2019年1月29日周二 上午10:29写道：
>>> 
 Yes, we can create a project to manage it, and we can talk about it.
>> like:
 Should we used Diamond Operator replace  explicit type? Use Lambda?
 Let's discuss the two pull requests above instead of closed it
>> immediately.
 
 
 
 
 
 Huxing Zhang  于2019年1月29日周二 上午9:58写道：
 
> Hi,
> 
> Nice suggestion!
> 
> Shall we can create a project to manage it?
> 
> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
 wrote:
>> 
>> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
 unused
>> methods ,unused logic , nonstandard naming  in the code. And there are
> some
>> code that can use the new features of java to make the code more
 concise
>> and understandable. like Lambda , Diamond Operator and so on.These are
> easy
>> to find and fixed because of the tips of the idea .We should do it
 before
>> completing the incubation.
> 
> 
> 
> --
> Best Regards！
> Huxing
> 
 
>> 
>> 

Re: [Discuss] About Clean Code Plan

[Ian Luo]

Jason,

Totally agree with you on this point. We should focus less on grammar sugar
but focus more on make the code clean, for say: divide long method into
shorter methods, better naming, or better doc, or even better design.

But on the other hand, if someone from the community shows enthusiasm for
updating code with new sugar, I will not object to the effort as long as it
doesn't hurt readability, after all it is low hanging fruit :)

What I propose is we should gather all possible ideas and group them in one
project on GitHub [1], like I said in my previous email. It is critical to
make the code clean as much as possible in my opinion. It deserves one
dedicated project to track all ideas. By doing this, the community can also
understand the current focuses are.

So my question is, should we init a project focusing on clean code, while
the purpose doesn't limit to grammar sugar?

Regards,
-Ian.

1. https://github.com/apache/incubator-dubbo/projects

On Tue, Jan 29, 2019 at 11:00 AM Jason Joo  wrote:

> Hi, Huxing & LiZhen
>
> Things like diamond is something called grammar SUGAR.
> Tasted good for developers but the same on byte code.
>
> So in my opinion we should not take it as a kind of "policy correct".
> we can make the changes in the code of recent PRs but not for all the
> code. Think about there may be more sugars in future JVM.
>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 10:42, yuhang xiu  wrote:
> >
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet  于2019年1月29日周二 上午10:29写道：
> >
> >> Yes, we can create a project to manage it, and we can talk about it.
> like:
> >> Should we used Diamond Operator replace  explicit type? Use Lambda?
> >> Let's discuss the two pull requests above instead of closed it
> immediately.
> >>
> >>
> >>
> >>
> >>
> >> Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> >>
> >>> Hi,
> >>>
> >>> Nice suggestion!
> >>>
> >>> Shall we can create a project to manage it?
> >>>
> >>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> >> wrote:
> 
>  Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >> unused
>  methods ,unused logic , nonstandard naming  in the code. And there are
> >>> some
>  code that can use the new features of java to make the code more
> >> concise
>  and understandable. like Lambda , Diamond Operator and so on.These are
> >>> easy
>  to find and fixed because of the tips of the idea .We should do it
> >> before
>  completing the incubation.
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>
>
>

Re: [Discuss] About Clean Code Plan

[Ian Luo]

good idea. It'd be even better if you could group all ideas backed by
issues into a dedicated project.

Thanks,
-Ian.

On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet  wrote:

> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming  in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.
>

Re: [Discuss] About Clean Code Plan

[Huxing Zhang]

Hi,

On Tue, Jan 29, 2019 at 11:00 AM Jason Joo  wrote:
>
> Hi, Huxing & LiZhen
>
> Things like diamond is something called grammar SUGAR.
> Tasted good for developers but the same on byte code.
>
> So in my opinion we should not take it as a kind of "policy correct".
> we can make the changes in the code of recent PRs but not for all the code. 
> Think about there may be more sugars in future JVM.

I think any changes should be "reviewable".
I don't think we can change all the things in one pull request.
Instead, we should divide it into small ones and make it easy to be reviewed.
Recently I've seen several pull requests doing things like this. I
think they are very good examples.


>
> best regards,
>
> Jason
>
> > On Jan 29, 2019, at 10:42, yuhang xiu  wrote:
> >
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet  于2019年1月29日周二 上午10:29写道：
> >
> >> Yes, we can create a project to manage it, and we can talk about it. like:
> >> Should we used Diamond Operator replace  explicit type? Use Lambda?
> >> Let's discuss the two pull requests above instead of closed it immediately.
> >>
> >>
> >>
> >>
> >>
> >> Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> >>
> >>> Hi,
> >>>
> >>> Nice suggestion!
> >>>
> >>> Shall we can create a project to manage it?
> >>>
> >>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> >> wrote:
> 
>  Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> >> unused
>  methods ,unused logic , nonstandard naming  in the code. And there are
> >>> some
>  code that can use the new features of java to make the code more
> >> concise
>  and understandable. like Lambda , Diamond Operator and so on.These are
> >>> easy
>  to find and fixed because of the tips of the idea .We should do it
> >> before
>  completing the incubation.
> >>>
> >>>
> >>>
> >>> --
> >>> Best Regards！
> >>> Huxing
> >>>
> >>
>


-- 
Best Regards！
Huxing

Re: [Release] Apache Dubbo(Incubator) Spring Boot 0.2.1 and 0.1.2 are available

[Ian Luo]

Bravo.

On Sun, Jan 27, 2019 at 8:19 PM Mercy Ma  wrote:

> Hello Dubbo Community,
>
> I'm glad to announce that Apache Dubbo(Incubator) Spring Boot 0.2.1 and
> 0.1.2  have been released and are now available from Maven Central.
>
> Release Notes:
> 0.2.1:
>
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.2.1
> 0.1.2:
>
> https://github.com/apache/incubator-dubbo-spring-boot-project/releases/tag/0.1.2
>
> If you have trouble with Dubbo Spring Boot, please discuss with Dubbo
> community at issues
> .
> Kind regards,
> Mercy Ma
>

Re: Prepare for release of dubbo-2.6.6

[Ian Luo]

Good plan. For anyone who's reading this thread, if you have anything you
feel it should be included in 2.6.6 release, pls. reply the email and let
Minxuan know it.

Thanks,
-Ian.


On Fri, Jan 25, 2019 at 2:45 PM Minxuan Zhuang  wrote:

> Hi all:
> in Dubbo 2.6.6 i'm planning to include the features below:
>
> Enhancements / Features:
>   [#3029] make netty4 default(
> https://github.com/apache/incubator-dubbo/issues/3029)
>   [#3065] import tag router to 2.6.x(
> https://github.com/apache/incubator-dubbo/pull/3065)
>   [#3296]Merge and enhancement dubbo-registry-nacos(
> https://github.com/apache/incubator-dubbo/issues/3296)
>  [#3275] uncaptured exception in ReferenceBeanInvocationHandler invoke
> proxy
> (https://github.com/apache/incubator-dubbo/issues/3275)
>   [#3251] @Service support the hierarchical interface(
> https://github.com/apache/incubator-dubbo/issues/3251)
> [#3193]Change the default behavior of @EnableDubboConfig.multiple()(
> https://github.com/apache/incubator-dubbo/issues/3193)
>
> Bugfixes：
> [#3315] remove duplicate SPI definitions(
> https://github.com/apache/incubator-dubbo/pull/3315)
> [#3295] Fix unregister when client destroyed (
> https://github.com/apache/incubator-dubbo/pull/3295)
> [#2178] supporting Java 8 Date/Time type when serializing with Kryo (
> https://github.com/apache/incubator-dubbo/issues/2178)
>
> for more, please check milestone:
> https://github.com/apache/incubator-dubbo/milestone/22
>

Re: [Discuss] About Clean Code Plan

[yuhang xiu]

Hi, @lizhen

Your pr seems to have some problems, so I have already commented below and
explained that please resubmit a pr. If you can solve this problem directly
on your branch, you can tell me, of course I will reopen your pr. But
before that, I didn't think that reviewing 30,000 lines of code was
necessary, and your pr could not be merged before you solved the problem,
so I turned it off.

Also, if you need to discuss anything, use an issue to track instead of
using pr to track, even if your pr is your purpose. That is a better
approach.

LiZhenNet  于2019年1月29日周二 上午10:58写道：

> I don't know why he showed that the entire file was modified, even though
> he only modified one line. You can check it.
>
> yuhang xiu  于2019年1月29日周二 上午10:43写道：
>
> > Your pr has modified more than 30,000 lines of code, and most of them are
> > modifications of the entire file.
> > What is the meaning of your pr? Why do I need to keep it open?
> >
> > If you need to discuss, issues and mailing lists are good choices, why do
> > you need to discuss pr?
> >
> > Who can review this pr[1] and tell me what this pr is going to do?
> >
> > [1] https://github.com/apache/incubator-dubbo/pull/3371
> >
> > LiZhenNet  于2019年1月29日周二 上午10:29写道：
> >
> > > Yes, we can create a project to manage it, and we can talk about it.
> > like:
> > > Should we used Diamond Operator replace  explicit type? Use Lambda?
> > > Let's discuss the two pull requests above instead of closed it
> > immediately.
> > >
> > >
> > >
> > >
> > >
> > > Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> > >
> > > > Hi,
> > > >
> > > > Nice suggestion!
> > > >
> > > > Shall we can create a project to manage it?
> > > >
> > > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> > > wrote:
> > > > >
> > > > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > > unused
> > > > > methods ,unused logic , nonstandard naming  in the code. And there
> > are
> > > > some
> > > > > code that can use the new features of java to make the code more
> > > concise
> > > > > and understandable. like Lambda , Diamond Operator and so on.These
> > are
> > > > easy
> > > > > to find and fixed because of the tips of the idea .We should do it
> > > before
> > > > > completing the incubation.
> > > >
> > > >
> > > >
> > > > --
> > > > Best Regards！
> > > > Huxing
> > > >
> > >
> >
>

Re: [Discuss] About Clean Code Plan

[Jason Joo]

Hi, Huxing & LiZhen

Things like diamond is something called grammar SUGAR.
Tasted good for developers but the same on byte code.

So in my opinion we should not take it as a kind of "policy correct".
we can make the changes in the code of recent PRs but not for all the code. 
Think about there may be more sugars in future JVM.

best regards,

Jason

> On Jan 29, 2019, at 10:42, yuhang xiu  wrote:
> 
> Your pr has modified more than 30,000 lines of code, and most of them are
> modifications of the entire file.
> What is the meaning of your pr? Why do I need to keep it open?
> 
> If you need to discuss, issues and mailing lists are good choices, why do
> you need to discuss pr?
> 
> Who can review this pr[1] and tell me what this pr is going to do?
> 
> [1] https://github.com/apache/incubator-dubbo/pull/3371
> 
> LiZhenNet  于2019年1月29日周二 上午10:29写道：
> 
>> Yes, we can create a project to manage it, and we can talk about it. like:
>> Should we used Diamond Operator replace  explicit type? Use Lambda?
>> Let's discuss the two pull requests above instead of closed it immediately.
>> 
>> 
>> 
>> 
>> 
>> Huxing Zhang  于2019年1月29日周二 上午9:58写道：
>> 
>>> Hi,
>>> 
>>> Nice suggestion!
>>> 
>>> Shall we can create a project to manage it?
>>> 
>>> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
>> wrote:
 
 Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
>> unused
 methods ,unused logic , nonstandard naming  in the code. And there are
>>> some
 code that can use the new features of java to make the code more
>> concise
 and understandable. like Lambda , Diamond Operator and so on.These are
>>> easy
 to find and fixed because of the tips of the idea .We should do it
>> before
 completing the incubation.
>>> 
>>> 
>>> 
>>> --
>>> Best Regards！
>>> Huxing
>>> 
>> 

Re: [Discuss] About Clean Code Plan

[LiZhenNet]

I don't know why he showed that the entire file was modified, even though
he only modified one line. You can check it.

yuhang xiu  于2019年1月29日周二 上午10:43写道：

> Your pr has modified more than 30,000 lines of code, and most of them are
> modifications of the entire file.
> What is the meaning of your pr? Why do I need to keep it open?
>
> If you need to discuss, issues and mailing lists are good choices, why do
> you need to discuss pr?
>
> Who can review this pr[1] and tell me what this pr is going to do?
>
> [1] https://github.com/apache/incubator-dubbo/pull/3371
>
> LiZhenNet  于2019年1月29日周二 上午10:29写道：
>
> > Yes, we can create a project to manage it, and we can talk about it.
> like:
> > Should we used Diamond Operator replace  explicit type? Use Lambda?
> > Let's discuss the two pull requests above instead of closed it
> immediately.
> >
> >
> >
> >
> >
> > Huxing Zhang  于2019年1月29日周二 上午9:58写道：
> >
> > > Hi,
> > >
> > > Nice suggestion!
> > >
> > > Shall we can create a project to manage it?
> > >
> > > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> > wrote:
> > > >
> > > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> > unused
> > > > methods ,unused logic , nonstandard naming  in the code. And there
> are
> > > some
> > > > code that can use the new features of java to make the code more
> > concise
> > > > and understandable. like Lambda , Diamond Operator and so on.These
> are
> > > easy
> > > > to find and fixed because of the tips of the idea .We should do it
> > before
> > > > completing the incubation.
> > >
> > >
> > >
> > > --
> > > Best Regards！
> > > Huxing
> > >
> >
>

Re: [Discuss] About Clean Code Plan

[yuhang xiu]

Your pr has modified more than 30,000 lines of code, and most of them are
modifications of the entire file.
What is the meaning of your pr? Why do I need to keep it open?

If you need to discuss, issues and mailing lists are good choices, why do
you need to discuss pr?

Who can review this pr[1] and tell me what this pr is going to do?

[1] https://github.com/apache/incubator-dubbo/pull/3371

LiZhenNet  于2019年1月29日周二 上午10:29写道：

> Yes, we can create a project to manage it, and we can talk about it. like:
> Should we used Diamond Operator replace  explicit type? Use Lambda?
> Let's discuss the two pull requests above instead of closed it immediately.
>
>
>
>
>
> Huxing Zhang  于2019年1月29日周二 上午9:58写道：
>
> > Hi,
> >
> > Nice suggestion!
> >
> > Shall we can create a project to manage it?
> >
> > On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet 
> wrote:
> > >
> > > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of
> unused
> > > methods ,unused logic , nonstandard naming  in the code. And there are
> > some
> > > code that can use the new features of java to make the code more
> concise
> > > and understandable. like Lambda , Diamond Operator and so on.These are
> > easy
> > > to find and fixed because of the tips of the idea .We should do it
> before
> > > completing the incubation.
> >
> >
> >
> > --
> > Best Regards！
> > Huxing
> >
>

Re: [Discuss] About Clean Code Plan

[LiZhenNet]

Yes, we can create a project to manage it, and we can talk about it. like:
Should we used Diamond Operator replace  explicit type? Use Lambda?
Let's discuss the two pull requests above instead of closed it immediately.





Huxing Zhang  于2019年1月29日周二 上午9:58写道：

> Hi,
>
> Nice suggestion!
>
> Shall we can create a project to manage it?
>
> On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet  wrote:
> >
> > Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> > methods ,unused logic , nonstandard naming  in the code. And there are
> some
> > code that can use the new features of java to make the code more concise
> > and understandable. like Lambda , Diamond Operator and so on.These are
> easy
> > to find and fixed because of the tips of the idea .We should do it before
> > completing the incubation.
>
>
>
> --
> Best Regards！
> Huxing
>

Re: about to open source a metrics sdk

[Minxuan Zhuang]

yes,  it's licensed under apache license 2.0:
https://github.com/dubbo/dubbo-metrics/blob/master/LICENSE

On Mon, Jan 28, 2019 at 10:51 PM Ian Luo  wrote:

> +1 to put it under dubbo group for now. One minor question, is the source
> code compliance to apache software license v2?
>
> Thanks,
> -Ian.
>
>
> On Thu, Jan 24, 2019 at 11:48 AM Minxuan Zhuang 
> wrote:
>
> > Hi all:
> > I'm planning to open source a metrics sdk implemented in java,
> and
> > use it as the default metrics implementation for dubbo. since it's an
> > initial version, I want to put it under dubbo group for now.
> >
>

Re: [Discuss] About Clean Code Plan

[Huxing Zhang]

Hi,

Nice suggestion!

Shall we can create a project to manage it?

On Fri, Jan 25, 2019 at 11:25 AM LiZhenNet  wrote:
>
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming  in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.



-- 
Best Regards！
Huxing

Re: about to open source a metrics sdk

[Ian Luo]

+1 to put it under dubbo group for now. One minor question, is the source
code compliance to apache software license v2?

Thanks,
-Ian.


On Thu, Jan 24, 2019 at 11:48 AM Minxuan Zhuang  wrote:

> Hi all:
> I'm planning to open source a metrics sdk implemented in java, and
> use it as the default metrics implementation for dubbo. since it's an
> initial version, I want to put it under dubbo group for now.
>

Re: [ANN] Welcome new committer: Xianjun Ke

[Ian Luo]

Congratulations.

On Fri, Jan 25, 2019 at 11:40 AM Huxing Zhang  wrote:

> Hi Community,
>
> On behalf of the Dubbo PPMC, I am pleased to announce that Xianjun Ke,
> a.k.a. kexianjun[1], has been voted in as a new Dubbo committer.
>
> Please join me to say congratulations to him!
>
> Xianjun, would you please briefly introduce yourself to the community?
>
> [1] https://github.com/kexianjun
>
> --
> Best Regards！
> Huxing
>

Re: 回复：[DISCUSS] Next Dubbo meetup

[Ian Luo]

+1 for Nanjing. I think any weekend in March sounds fine to me.

Thanks,
-Ian.

On Mon, Jan 28, 2019 at 5:12 PM Huxing Zhang  wrote:

> Hi,
>
> On Mon, Jan 28, 2019 at 11:19 AM 王蓉(涂南)  wrote:
>
> > Hi guys,
> >
> > Last week meetup in Guangzhou was so much fun.
> > We have total 400+ registrations and more than 200 attendees, another 4k
> > people watched our live streaming!
> >
> > I think we should start to prepare next meetup in Nanjing ASAP. As the
> > Chinese New Year is approaching.
> >
>
> We need to first discuss with the community about:
> - where should next meetup be held?
> - when should it be held?
>
> As discussed in the previous threads, based on the vote result, I think
> Nanjing is a good candidate for the next meetup.
> +1 for Nanjing!
>
>
>
> >
> > What about March 9th?If March 9th is OK, the Call for Talks will be
> closed
> > on Feb 15th. That will give us plenty of time to prepare.
> >
>
> March 9th is a Saturday, which looks good to me.
> Feb 15th looks too early to me, because the Chinese new year festival is
> Feb 4th to Feb 10th. There is only one week after the vacation, and it is
> possible some of us would have extra days-off after the vacation.
> Is is possible to close the Call for talks one week later? say Feb 22nd.
>
>
> >
> > Amber
> > BR
> >
> >
> > --
> > 发件人：Huxing Zhang 
> > 发送时间：2018年12月11日(星期二) 15:15
> > 收件人：dev 
> > 主 题：Re: 回复：[DISCUSS] Next Dubbo meetup
> >
> > Hi,
> >
> > I think Guangzhou and Nanjing are the cities we all should go to. It is
> > just about who is the first.
> >
> > On Tue, Dec 11, 2018 at 2:07 PM Mercy  wrote:
> >
> > > I vote twice, one is Nanjing, another is Guangzhou :D
> > >
> > >
> > > Kind regards,
> > >
> > > Mercy Ma
> > >
> > >
> > > 在 2018/12/11 下午1:47, 王蓉(涂南) 写道:
> > > > Folks, so far we have received 40 votes.
> > > >
> > > > Looks like Guangzhou is where we're gonna meet on Jan 19th.
> > > >
> > > >
> > > >   广州  12
> > > >   南京  10
> > > >   北京  4
> > > >   深圳  4
> > > >   上海  4
> > > >   厦门  2
> > > >   武汉  1
> > > >   西安  1
> > > >   重庆  1
> > > >   大连  1
> > > >
> > > >
> > > > --
> > > > 发件人：jun liu 
> > > > 发送时间：2018年12月7日(星期五) 23:52
> > > > 收件人：dev 
> > > > 主 题：Re: [DISCUSS] Next Dubbo meetup
> > > >
> > > > I prefer Nanjing for the next Meetup city.
> > > >
> > > > Jun
> > > >
> > > >> On Dec 4, 2018, at 10:06 PM, Huxing Zhang 
> wrote:
> > > >>
> > > >> In the link[1] provided, there are 3 options:
> > > >>
> > > >> * Nanjing
> > > >> * Guangzhou
> > > >> * Other
> > > >>
> > > >> I prefer to a new city where we haven't been there before.
> > > >> According to a survey, the number of users who is using Dubbo in
> > > Guangzhou
> > > >> ranks 5th in China, only secondary to Beijing, Shanghai, Shenzhen,
> > > Hangzhou.
> > > >> So I am going to vote +1 for Guangzhou. :)
> > > >>
> > > >> [1] http://sc-meetup.mikecrm.com/7hZFeTl <
> > > http://sc-meetup.mikecrm.com/7hZFeTl>
> > > >>
> > > >> On Tue, Dec 4, 2018 at 4:08 PM 王蓉(涂南)  > > > wrote:
> > > >>
> > > >>> Hi guys,
> > > >>>
> > > >>> I'm Amber, organizer of Dubbo meetup.
> > > >>>
> > > >>> Since 2018, Dubbo community has been touring around China!
> > > >>> We have been to Beijing, Chengdu, Shenzhen, Shanghai, and Hangzhou.
> > > >>> More than 30K developers have either come to the meetup or watched
> > our
> > > >>> live streaming videos.
> > > >>> What a wonderful journey!
> > > >>>
> > > >>> Now you got to choose where our 2019 first meetup is going to be
> > held!
> > > >>> We're planning to hold another meetup on Jan 19th.
> > > >>> Let us know your thoughts!
> > > >>>
> > > >>> Ballot here ‍http://sc-meetup.mikecrm.com/7hZFeTl
> > > >>> Deadline for this ballot is Dec.14.
> > > >>>
> > > >>> --
> > > >>> Best Regards！
> > > >>> Huxing
> > >
> > >
> >
> > --
> > Best Regards！
> > Huxing
> >
>
>
> --
> Best Regards！
> Huxing
>

Re: [DISCUSS]: Some thoughts on What Dubbo 3.0 is, we really should start it ASAP

[Ian Luo]

Agree, we should consider seriously both HTTP/2 and rsocket.

Thanks,
-Ian.


On Thu, Jan 24, 2019 at 10:59 AM Taosheng, Wei 
wrote:

> Lan,
> Yes, I think http2 and some new protocols such as rsocket can be
> considered.
> I will spend some time to study this issue.
>
>
> Warm regards,
> Taosheng
>
>
>
>
> -- Original --
> From: Ian Luo 
> Date: Thu,Jan 24,2019 9:58 AM
> To: dev 
> Subject: Re: [DISCUSS]: Some thoughts on What Dubbo 3.0 is, we really
> should start it ASAP
>
>
>
> Taosheng,
>
> In this scenario, it looks like we should use http2 to transport the
> payload, what do you think?
>
> Thanks,
> -Ian.
>
> On Wed, Jan 23, 2019 at 10:35 PM Taosheng Wei 
> wrote:
>
> > I think we can find a binary protocol with strong potential to be a
> public
> > application protocol like http, and extend it with security function. Or
> if
> > there aren't such suitable protocols, we can try to formulate a new
> > protocol. Then make Dubbo support it.
> > In my opinion, this way may not only solve the security problems, but
> also
> > solve the cross-language RPC with Dubbo.
> >
> > zhi_guang_...@163.com  于2019年1月23日周三 下午5:47写道：
> >
> > > I have a similar Question as this mail:
> > > Is Dubbo designed for use on internet?
> > > I have just join a company last year and our business is all around the
> > > world.
> > > So we have servers on US and ASIA and EU.
> > > In this condition we use dubbo on internet and keep security by
> security
> > > rules that only allow the servers connect to each other.
> > >
> > > I think this is not a  pretty useage of dubbo，but I cann't find Strong
> > > evidences to change the situation.
> > >
> > > Can any one help me to answer this questions? Thanks a lot.
> > >
> > >
> > >
> > > --
> > > 您的朋友：刘志广
> > >
> > >
> > > *From:* Yuhao Bi 
> > > *Date:* 2019-01-22 22:55
> > > *To:* dev 
> > > *Subject:* Re: [DISCUSS]: Some thoughts on What Dubbo 3.0 is, we really
> > > should start it ASAP
> > > Hi lan and community,
> > >
> > > Although I have already heard "Dubbo" a few years ago,
> > > but I just started to learn dubbo after the meetup last year in Chengdu
> > > after it became the Apache Dubbo.
> > > Maybe I'm not such that familiar with the underlying details, but after
> > > the continuous participated
> > > I feel like a part of the community, and free to share my opinion.
> > >
> > > So, here is my question and also consider it my suggestion:
> > > Should we care more about Security? How can we prevent from
> unauthorized
> > > remote call?
> > > - Should we support Authentication and Authorization
> > > - Should we add Spring Security or Active Directory Service support at
> > the
> > > framework level
> > >
> > > Thanks,
> > > Yuhao
> > >
> > >
> > > jun liu  于2019年1月22日周二 下午5:50写道：
> > >
> > > > > I think the online integration test and performance test
> environment
> > > > should
> > > > > be set up for the new features.
> > > >
> > > > Agree!  We should start as soon as possible, from 2.7.x.
> > > >
> > > > Jun
> > > >
> > > > > On Jan 22, 2019, at 5:43 PM, Xin Wang 
> > > wrote:
> > > > >
> > > > > I think the online integration test and performance test
> environment
> > > > should
> > > > > be set up for the new features.
> > > > >
> > > > > Ian Luo  于2019年1月22日周二 下午3:04写道：
> > > > >
> > > > >> Yuhao, good idea.
> > > > >>
> > > > >> BTW, do you have any thought on what Dubbo 3.0 should be?
> > > > >>
> > > > >> Thanks,
> > > > >> -Ian.
> > > > >>
> > > > >>
> > > > >> On Tue, Jan 22, 2019 at 2:39 PM Yuhao Bi 
> wrote:
> > > > >>
> > > > >>> Once we have decided what to do in the next.
> > > > >>> Should we have a website page to publish it? e.g. [1]
> > > > >>>
> > > > >>> [1]. https://phoenix.apache.org/roadmap.html
> > > > >>>
> > > > >>> yuneng xie  于2019年1月22日周二 下午2:25写道：
> > > > >>>
> > > >  Hi Ian Luo,
> > > > 
> > > >  OK, i'd start to work on it soon.
> > > > 
> > > >  Ian Luo  于2019年1月17日周四 下午2:01写道：
> > > > 
> > > > > Hi Yuneng,
> > > > >
> > > > > Sounds interesting. I am especially interested in reactive
> > > > >> programming
> > > > > support. Pls. go ahead to try implement it on 3.x branch.
> > > > >
> > > > > Thanks,
> > > > > -Ian.
> > > > >
> > > > > On Thu, Jan 17, 2019 at 11:03 AM yuneng xie <
> xieyun...@gmail.com
> > >
> > > > >>> wrote:
> > > > >
> > > > >> Hi folks,
> > > > >>
> > > > >> I agreed with Ian Luo on the improvement list. I also got some
> > > idea
> > > > >>> in
> > > >  my
> > > > >> mind.  I'd just share with you two points below in detail
> which
> > > i'm
> > > >  most
> > > > >> interested in right now.
> > > > >>
> > > > >> 1. Upgrade  the core abstraction "Invoker", which works in
> sync
> > > > >> mode,
> > > >  to
> > > > > an
> > > > >> abstraction works in async mode. then we can construct
> > > > >> InvocationChain/FilterChain that works in 

Re: Re: [Discuss] About Clean Code Plan

[LiZhenNet]

@beiwei, @yuhang

1. https://github.com/apache/incubator-dubbo/pull/3344
SkipFailbackWrapperException is added at 2012-07-13 , but never used ,I
think it should be added when it is needed。

2.https://github.com/apache/incubator-dubbo/pull/3371
Diamond Operator  is a feature in jdk7.








KimmKing  于2019年1月26日周六 上午1:51写道：

>
>
>
> >> like Lambda , Diamond Operator
>
>
> Since dubbo only support jdk8+, it should be an important task for us.
>
>
>
>
> At 2019-01-25 12:18:56, "zhi_guang_...@163.com" 
> wrote:
>
> |
> +1
> Agree with youre opinion!
>
>
> 您的朋友：刘志广
>
>
>
> From: LiZhenNet
> Date: 2019-01-25 11:24
> To: dev
> Subject: [Discuss] About Clean Code Plan
> Now ,Dubbo has 167 contributors , 3125 commits. There are a lot of unused
> methods ,unused logic , nonstandard naming  in the code. And there are some
> code that can use the new features of java to make the code more concise
> and understandable. like Lambda , Diamond Operator and so on.These are easy
> to find and fixed because of the tips of the idea .We should do it before
> completing the incubation.
> |

Re: 回复：[DISCUSS] Next Dubbo meetup

[Huxing Zhang]

Hi,

On Mon, Jan 28, 2019 at 11:19 AM 王蓉(涂南)  wrote:

> Hi guys,
>
> Last week meetup in Guangzhou was so much fun.
> We have total 400+ registrations and more than 200 attendees, another 4k
> people watched our live streaming!
>
> I think we should start to prepare next meetup in Nanjing ASAP. As the
> Chinese New Year is approaching.
>

We need to first discuss with the community about:
- where should next meetup be held?
- when should it be held?

As discussed in the previous threads, based on the vote result, I think
Nanjing is a good candidate for the next meetup.
+1 for Nanjing!



>
> What about March 9th?If March 9th is OK, the Call for Talks will be closed
> on Feb 15th. That will give us plenty of time to prepare.
>

March 9th is a Saturday, which looks good to me.
Feb 15th looks too early to me, because the Chinese new year festival is
Feb 4th to Feb 10th. There is only one week after the vacation, and it is
possible some of us would have extra days-off after the vacation.
Is is possible to close the Call for talks one week later? say Feb 22nd.


>
> Amber
> BR
>
>
> --
> 发件人：Huxing Zhang 
> 发送时间：2018年12月11日(星期二) 15:15
> 收件人：dev 
> 主 题：Re: 回复：[DISCUSS] Next Dubbo meetup
>
> Hi,
>
> I think Guangzhou and Nanjing are the cities we all should go to. It is
> just about who is the first.
>
> On Tue, Dec 11, 2018 at 2:07 PM Mercy  wrote:
>
> > I vote twice, one is Nanjing, another is Guangzhou :D
> >
> >
> > Kind regards,
> >
> > Mercy Ma
> >
> >
> > 在 2018/12/11 下午1:47, 王蓉(涂南) 写道:
> > > Folks, so far we have received 40 votes.
> > >
> > > Looks like Guangzhou is where we're gonna meet on Jan 19th.
> > >
> > >
> > >   广州  12
> > >   南京  10
> > >   北京  4
> > >   深圳  4
> > >   上海  4
> > >   厦门  2
> > >   武汉  1
> > >   西安  1
> > >   重庆  1
> > >   大连  1
> > >
> > >
> > > --
> > > 发件人：jun liu 
> > > 发送时间：2018年12月7日(星期五) 23:52
> > > 收件人：dev 
> > > 主 题：Re: [DISCUSS] Next Dubbo meetup
> > >
> > > I prefer Nanjing for the next Meetup city.
> > >
> > > Jun
> > >
> > >> On Dec 4, 2018, at 10:06 PM, Huxing Zhang  wrote:
> > >>
> > >> In the link[1] provided, there are 3 options:
> > >>
> > >> * Nanjing
> > >> * Guangzhou
> > >> * Other
> > >>
> > >> I prefer to a new city where we haven't been there before.
> > >> According to a survey, the number of users who is using Dubbo in
> > Guangzhou
> > >> ranks 5th in China, only secondary to Beijing, Shanghai, Shenzhen,
> > Hangzhou.
> > >> So I am going to vote +1 for Guangzhou. :)
> > >>
> > >> [1] http://sc-meetup.mikecrm.com/7hZFeTl <
> > http://sc-meetup.mikecrm.com/7hZFeTl>
> > >>
> > >> On Tue, Dec 4, 2018 at 4:08 PM 王蓉(涂南)  > > wrote:
> > >>
> > >>> Hi guys,
> > >>>
> > >>> I'm Amber, organizer of Dubbo meetup.
> > >>>
> > >>> Since 2018, Dubbo community has been touring around China!
> > >>> We have been to Beijing, Chengdu, Shenzhen, Shanghai, and Hangzhou.
> > >>> More than 30K developers have either come to the meetup or watched
> our
> > >>> live streaming videos.
> > >>> What a wonderful journey!
> > >>>
> > >>> Now you got to choose where our 2019 first meetup is going to be
> held!
> > >>> We're planning to hold another meetup on Jan 19th.
> > >>> Let us know your thoughts!
> > >>>
> > >>> Ballot here ‍http://sc-meetup.mikecrm.com/7hZFeTl
> > >>> Deadline for this ballot is Dec.14.
> > >>>
> > >>> --
> > >>> Best Regards！
> > >>> Huxing
> >
> >
>
> --
> Best Regards！
> Huxing
>


-- 
Best Regards！
Huxing