Re: Getting started on Fineract CN

Hi Myrle, Thank you for the trust. Will endeavor to do more in the coming days. At Your Service, Isaac Kamga. On Fri, Mar 16, 2018 at 12:01 PM, Myrle Krantz wrote: > Hi Isaac, > > My apologies for the long response time. I had intended to test > compilation of each pull

Re: Getting started on Fineract CN

Okay, I see that you've merged PRs on fineract-cn-lang, fineract-cn-api, fineract-cn-cassandra, fineract-cn-mariadb and fineract-cn-async. Yes please, I would like to update each PR on the repositories which you haven't merged yet ( viz fineract-cn-command, fineract-cn-test,... ) during the

Re: Getting started on Fineract CN

: o) Did you want to do just the ones I haven't merged yet? If so, I'll hold up and wait. Greets, Myrle On Mon, Mar 5, 2018 at 1:49 PM, Isaac Kamga wrote: > Hi Myrle, > > Thanks for taking time out to review. > > About those 2 last lines of code, I could update all

Re: Getting started on Fineract CN

Hi Myrle, Thanks for taking time out to review. About those 2 last lines of code, I could update all pull requests by removing the ext.name and ext.year variables but you already started merging some... ;-). Cheers, Isaac Kamga. On Mon, Mar 5, 2018 at 12:57 PM, Myrle Krantz

Re: Getting started on Fineract CN

Hey Isaac, I'm reviewing your pull requests bit-by-bit, but I'm not going to be able to get through them all today, because I've got some other stuff I have to work on. What I've seen so far looks great though, so I've been merging them, once I've tested the build on my local machine. One tiny

Re: Getting started on Fineract CN

Please disregard the above email. Reimporting the fineract-cn-permitted-feign-client project once more into IDE fixed the issue. I'm continue updating copyright information onwards from permitted-feign-client. Cheers, Isaac Kamga. On Fri, Mar 2, 2018 at 6:49 PM, Isaac Kamga

Re: Getting started on Fineract CN

Hi Myrle, You may have observed the pull requests I just created on api, cassandra, etc. I ran into an issue when working on the permitted-feign-client repository. `./gradlew publishToMavenLocal` and `./gradlew licenseFormat` work fine but `./gradlew prepareForTest` fails because `import

Re: Getting started on Fineract CN

Thanks a million Myrle and Phil. I followed your instructions and have updated the Pull Request with a new commit. At Your Service, Isaac Kamga. On Thu, Mar 1, 2018 at 7:49 PM, Myrle Krantz wrote: > Oops. Do what Phil says. He knows better. > > Greets, > Myrle > > On Thu 1.

Re: Getting started on Fineract CN

Oops. Do what Phil says. He knows better. Greets, Myrle On Thu 1. Mar 2018 at 19:43 Phil Steitz wrote: > On 3/1/18 10:34 AM, Myrle Krantz wrote: > > Hey Isaac, > > > > At a first glance, it looks good. May I ask though why you removed > > the license parameter

Re: Getting started on Fineract CN

On Thu 1. Mar 2018 at 19:37 Isaac Kamga wrote: > Hi Myrle, > > On Thu, Mar 1, 2018 at 6:34 PM, Myrle Krantz wrote: > > > Hey Isaac, > > > > At a first glance, it looks good. May I ask though why you removed > > the license parameter strictCh > > > My

Re: Getting started on Fineract CN

On 3/1/18 10:34 AM, Myrle Krantz wrote: > Hey Isaac, > > At a first glance, it looks good. May I ask though why you removed > the license parameter strictCheck? > > Regards, > Myrle The copyright statement should be removed entirely from the source header files and placed instead in NOTICE.txt.

Re: Getting started on Fineract CN

Hi Myrle, On Thu, Mar 1, 2018 at 6:34 PM, Myrle Krantz wrote: > Hey Isaac, > > At a first glance, it looks good. May I ask though why you removed > the license parameter strictCheck? > > My bad ! Do I update PR with new commit or close this and send in another ? > Regards,

Re: Getting started on Fineract CN

Hey Isaac, At a first glance, it looks good. May I ask though why you removed the license parameter strictCheck? Regards, Myrle On Thu, Mar 1, 2018 at 5:27 PM, Isaac Kamga wrote: > Hi Myrle, > > I've just updated copyright information in fineract-cn-lang and created a >

Re: Getting started on Fineract CN

Hi Myrle, I've just updated copyright information in fineract-cn-lang and created a new pull request . I patiently await your review and possible merger. At Your Service, Isaac Kamga. On Thu, Mar 1, 2018 at 5:05 PM, Isaac Kamga

Re: Getting started on Fineract CN

Hi Myrle, Thanks a million for your advice and guidance on this. I've closed the Pull Request, will do appropriate changes and send in another for review. At Your Service, Isaac Kamga. On Thu, Mar 1, 2018 at 4:56 PM, Myrle Krantz wrote: > Hey Isaac, > > Replies inline: > >

Re: Getting started on Fineract CN

Hey Isaac, Replies inline: On Thu, Mar 1, 2018 at 1:20 PM, Isaac Kamga wrote: > I have just updated the copyright information and package name on the > fineract-cn-lang repository and sent in another pull request > for

Re: Getting started on Fineract CN

Hi Myrle, Thanks for taking out some time to review and merge the Pull Request. I have just updated the copyright information and package name on the fineract-cn-lang repository and sent in another pull request for review. On a related note,

Re: Getting started on Fineract CN

Hi Myrle, +Awasum Thanks for all the awesomeness ! @Myrle, While awaiting your review of the PR, I'll be on those tasks. @Awasum, thanks for the dependency graph, it's definitely very helpful. At Your Service, Isaac Kamga. On Tue, Feb 27, 2018 at 7:55 PM, Awasum Yannick

Re: Getting started on Fineract CN

Hey Isaac, On Tue, Feb 27, 2018 at 3:38 PM, Isaac Kamga wrote: >> Other places are: >> * the package names >> * a couple of variables in build scripts >> * the copyright notice headers in the source files. >> > > Can I take on these tasks viz updating other places in the

Re: Getting started on Fineract CN

Hi Myrle, On Mon, Feb 26, 2018 at 6:48 PM, Myrle Krantz wrote: > Hey Phil, > > Thanks for the feedback. I've just updated the artifact ids to apache > fineract. It's not the only place we need to replace Mifos with > Apache Fineract though. > > Other places are: > * the

Fwd: Re: Getting started on Fineract CN

Forgot to copy the list... Forwarded Message Subject:Re: Getting started on Fineract CN Date: Mon, 26 Feb 2018 16:38:56 -0700 From: Phil Steitz <phil.ste...@gmail.com> To: Myrle Krantz <my...@apache.org> On 2/26/18 2:01 PM, Myrle Krantz wrote

Re: Getting started on Fineract CN

Hey Phil, On Mon, Feb 26, 2018 at 8:13 PM, Phil Steitz wrote: > We should replace the source headers with standard headers. The SGA > entitles us to do that. We *can* include copyright notices citing > the original authors in NOTICE.txt, but should only do so if that >

Re: Getting started on Fineract CN

On 2/26/18 10:48 AM, Myrle Krantz wrote: > Hey Phil, > > Thanks for the feedback. I've just updated the artifact ids to apache > fineract. It's not the only place we need to replace Mifos with > Apache Fineract though. > > Other places are: > * the package names > * a couple of variables in

Re: Getting started on Fineract CN

Thanks Phil for taking that on. Now that the code is out there and stable, a number of volunteers in their community are working to improve the documentation and configuration scripts available. Your contributions are gladly welcomed! Cheers, Ed On Mon, Feb 26, 2018 at 9:25 AM, Phil Steitz

Re: Getting started on Fineract CN

On 2/26/18 12:52 AM, Markus Geiss wrote: > Hey Phil, > > given all repos got pushed as is, I guess one of the first tasks is to > rename > all packages and projects to fit into the Apache layout. > > If you just want to get started now, you need to call > > ./gradelw publishToMavenLocal

Re: Getting started on Fineract CN

Hey Phil, given all repos got pushed as is, I guess one of the first tasks is to rename all packages and projects to fit into the Apache layout. If you just want to get started now, you need to call ./gradelw publishToMavenLocal (assuming a *nix OS) for every project. You should be able to

Getting started on Fineract CN

I would like to start contributing to CN.  I have cloned all of the repos and thought it would be a good first step to build the demo-server.  The readme for that component says that as a precondition, "All Mifos I/O projects must be published to your local Maven repository."  I assume that now