Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, So you would then understand that it may take a day or two to get things done. The first email was at 9am my time, your email was at 5pm my time, during those hours I have a day job, and I while I may respond to email I generally don't work on Flex during 9-5 while on day job. Have you

Re: [FlexJS] Removing PasswordInputBead has no effect

Neither do I. > On Jun 8, 2017, at 9:58 AM, Justin Mclean wrote: > > Hi, > > I did say I would do it in my last email. Please remember I don't work full > time on Apache Flex and I’m in a different time zone. > > Thanks, > Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, I did say I would do it in my last email. Please remember I don't work full time on Apache Flex and I’m in a different time zone. Thanks, Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

This is simply insanity. Discussing a simple change ad nuaseum is a colossal waste of time. Instead of perpetuating this discussion, I just made the change myself. Use the new PasswordInputRemovableBead if you want to remove password input functionality. Let’s move on. Harbs > On Jun 8,

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > That wont be breaking PAYG. The basic idea is to avoid loading/running > unnecessary code during runtime. Altering a class support subclassing > should be fine. Which the modified version does and would comply with that definition of PAYG - unless you think a single null check is anti

Re: [FlexJS] Removing PasswordInputBead has no effect

On Wed, Jun 7, 2017 at 3:41 PM, Justin Mclean wrote: > HI, > > > "It can't be done in a subclass with > > an override of the strand setter? > > Probably not without altering the original bead which may also be not PAYG. > That wont be breaking PAYG. The basic idea

Re: [FlexJS] Removing PasswordInputBead has no effect

HI, > "It can't be done in a subclass with > an override of the strand setter? Probably not without altering the original bead which may also be not PAYG. Thanks, Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

This will make the 38th post on this thread. It is a link to the 4th post on this thread: https://lists.apache.org/thread.html/8f561b811d2e662769f204200eabe8bc706d97 b19f8859fe74ee9b3b@%3Cdev.flex.apache.org%3E "It can't be done in a subclass with an override of the strand setter?

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

I actually added VerticalLayoutWithPaddingAndGap recently. I didn't want to set margins because a gap property is much more convenient in many situations. :) - Josh On Wed, Jun 7, 2017 at 7:15 AM, Peter Ent wrote: > If you look at the layouts, you can see these

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

We have never really discussed the use of delegates. Its not something that ties in that well with FlexJS I think. But using a delegate to off-load some of the work, just when that work is needed, might be another solution. ‹peter On 6/7/17, 2:36 AM, "Harbs" wrote:

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

If you look at the layouts, you can see these questions for real. Take VerticalLayout. The idea is to stack children of some component vertically. Those children can be given a) no explicit size, b) an explicit size as pixel values, c) a percentage size. You know what the VerticalLayout is

Re: [FlexJS] Removing PasswordInputBead has no effect

Om, You mean subclass current bead and have new functionality in the other ? If yes I'm OK. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has-no-effect

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, And nothing is broken in develop and a new release (after this one) is a long way away so there’s no huge urgency here. I do intended to correct it once the discussion has died down and PAYG is clearly documented. Thanks, Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

It seems subclass is the way to go here. Anyone disagree with that? Thanks, Om On Jun 7, 2017 1:57 AM, "Justin Mclean" wrote: > Hi, > > I'm still awaiting answers from Alex and further discussion on what PAYG > is and isn’t and will resolve in accordance to that. > >

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, I'm still awaiting answers from Alex and further discussion on what PAYG is and isn’t and will resolve in accordance to that. Thanks, Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

Agree with Om. I also do not wanna to leave this thread without any action. In whatever direction it will go. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has

Re: [FlexJS] Removing PasswordInputBead has no effect

Justin, Do you now have sufficient info on the PAYG paradigm to resolve this issue? When you re-read Alex and Harbs' suggestions now, does it make sense? I suggest we fix this issue and move on, please. Thanks, Om On Jun 6, 2017 5:22 PM, "Justin Mclean" wrote: Hi,

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

That’s not what I’m suggesting at all. If utility classes (or utility functions) are bloated with lots of functionality then they are not done right. Utilities should be reserved for well defined functionality. A good example of this is AnimationUtil. Imagine you have two animation beads which

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

is message in context: http://apache-flex-development.247.n4.nabble.com/Beads-and-DRY-was-Re-FlexJS-Removing-PasswordInputBead-has-no-effect-tp62177p62209.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, > Personally I prefer this approach even if it is more code. I assume you mean subclassing over utility functions? Thanks, Justin

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, Personally I prefer this approach even if it is more code. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Beads-and-DRY-was-Re-FlexJS-Removing-PasswordInputBead-has-no-effect-tp62177p62204.html

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

tion.outlook.com/?url=http%3A%2F%2Fapache-fle >x-development.247.n4.nabble.com%2FBeads-and-DRY-was-Re-FlexJS-Removing >-PasswordInputBead-has-no-effect-tp62177p62199.html=02%7C01%7C%7C0468 >ec58ff8646d727ca08d4ad645e4e%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C >63632409399233320

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

le.com/Beads-and-DRY-was-Re-FlexJS-Removing-PasswordInputBead-has-no-effect-tp62177p62199.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

On Tue, Jun 6, 2017 at 5:29 PM, Justin Mclean wrote: > Hi, > > > In FlexJS we have a preference towards utility classes. > > So say we have existing bead A and we want to add some functionality to > to. In order to use utility classes we would need to modify bead A and

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, > In FlexJS we have a preference towards utility classes. So say we have existing bead A and we want to add some functionality to to. In order to use utility classes we would need to modify bead A and pull out some of the code into a utility class so bead B can use it. This will increase

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, > This is achieved through composition (the classical OOP paradigm) The document pointed to yesterday suggests to avoid inheritance and prefer composition. Is that just for components and it’s OK to use were needed in beads? Thanks, Justin.

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Actually I will have definitely looked through this early on, but I'd have to > say it is quite 'light' on what PAYG actually means beyond the general sense > that I had. I’d go further as say the definition as it is stated there seem to be perhaps too wide? > But I can see that the

Re: [FlexJS] Removing PasswordInputBead has no effect

That would be great. Harbs > On Jun 6, 2017, at 10:24 PM, Greg Dove wrote: > > If no-one else volunteers to wiki-fy the contents of the new thread at its > conclusion, I will give it a shot over the coming weekend.

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

There’s actually two ways of adhering to DRY: 1. Subclassing 2. Utility classes. In FlexJS we have a preference towards utility classes. (and I’d like to see even more) Besides very often doing a better job than subclasses in terms of avoiding code-repeat, it’s also more geared towards

Re: [FlexJS] Removing PasswordInputBead has no effect

Alex, and Harbs, Thanks for pointing that out. Actually I will have defifintely looked through this early on, but I'd have to say it is quite 'light' on what PAYG actually means beyond the general sense that I had. It does have some more detail about beads which is great and I could have

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

In an attempt to simplify the pattern, can we say: Strands = components Beads = functionalities All components dont need all functionalities. We add functionalities to components on a Pay As You Go (PAYG) basis. This is achieved through composition (the classical OOP paradigm) That is, a

Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

I agree we have to be concerned about DRY. Research into optimal patterns for creating common flavors of beads would be very helpful. The compiler might be able to help as well. -Alex On 6/6/17, 6:52 AM, "Josh Tynjala" wrote: >The way that beads work means that we will

Re: [FlexJS] Removing PasswordInputBead has no effect

The way that beads work means that we will frequently "violate" DRY, as I understand it. FlexJS is designed to have multiple beads that implement the same thing in different ways. The simplest bead will be designed to be never removed and it probably won't include any properties to configure its

Re: [FlexJS] Removing PasswordInputBead has no effect

-Removing-PasswordInputBead-has-no-effect-tp62092p62158.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > What’s not clear once you read that doc? It’s unclear to me why the code I checked in isn’t PAYG as it fits with the definition of PAYG in that document. Thanks, Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

The definition is fine. The fact that it’s 4 years old is irrelevant. What’s not clear once you read that doc? Please just revert your changes and make a new bead. There’s no reason to have so much discussion on this… > On Jun 6, 2017, at 11:18 AM, Justin Mclean

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Imposing your different opinion in others is not the Apache Way. How am I’m imposing anything here Alex? It is you that's instating that just in time code that follows the PAYG principal as documented and that has zero practical overhead is not PAYG. From my understanding several

Re: [FlexJS] Removing PasswordInputBead has no effect

I didn't say it was my project. Just my vision. And for the past 4 years, others seem to share it. I believe that is consensus. Bertrand advised us many years ago to make things modular, which FlexJS is, so folks with different opinions can go implement their opinion in a different module.

Re: [FlexJS] Removing PasswordInputBead has no effect

let's implement!" - Maybe discuss my concerns in the other thread please. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has-no-effect-tp62092p62146.html

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Unless something is functionality that you would (virtually) always need, > it’s a separate bead. So for CCS we have border, does everyone need borders? Why do we only a sub set of the font attributes included? Some people are not going to use all of them or in fact any of them and

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > The wiki from 4 years ago is very helpful in understanding architectural > decisions: > https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype > >

Re: [FlexJS] Removing PasswordInputBead has no effect

This was first published in 2012. https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype PAYG and avoiding just-in-case code is mentioned in that document. As are Beads. Thanks, -Alex On 6/5/17, 11:33 PM, "Greg Dove" wrote: >Harbs, a quick comment from

Re: [FlexJS] Removing PasswordInputBead has no effect

The wiki from 4 years ago is very helpful in understanding architectural decisions: https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype If you have suggestions to make things clearer then by all

Re: [FlexJS] Removing PasswordInputBead has no effect

Harbs, a quick comment from the sidelines on: "PAYG is already well understood" I don't really think that is the case, at least it has not been for me. I had a more general notion of PAYG that was nothing to do with beads at all, and was limited to guesswork/my own interpretation of it at the

Re: [FlexJS] Removing PasswordInputBead has no effect

We’ve all already been implementing things as Alex states. He architected the framework and it’s a good architecture. No need to change things. We need consistent architecture. We can’t have a free-for-all... Percentage of code really has nothing to do with it. Unless something is

Re: [FlexJS] Removing PasswordInputBead has no effect

bead which has everything what Justin add. Would it be satisfactory ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has-no-effect-tp62092p62129.html Sent from

Re: [FlexJS] Removing PasswordInputBead has no effect

+1 for documenting it and stick with it. - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has-no-effect-tp62092p62128.html Sent from the Apache Flex Development mailing list

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > If you have a different vision, you can execute that vision in another > component set or fork FlexJS entirely. Please do not impose your vision > on my vision. Since when is this your project Alex or that the project has to only include your vision? That is not the Apache way. I would

Re: [FlexJS] Removing PasswordInputBead has no effect

something in my component. The question is: Can you extract this part of code into separate class ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Removing-PasswordInputBead-has-no-effect-tp62092p62116

Re: [FlexJS] Removing PasswordInputBead has no effect

On 6/4/17, 9:46 PM, "Justin Mclean" wrote: >Hi, > >Sorry autocorrect seems to have got the better of me - correcting: > >I think you are forgetting the optimisation that goes on, yes the source >code has a few more lines of code, but hardly double the size. > >Perhaps

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Both the original version and my JS compile down to to same size of 92 bytes. > The unzipped versions differ by 2% with my version being slighter larger. The > AS versions are identical. Even with simple optimisation (i.e. no code optimised out or renamed) the size increase is 7%.

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, Sorry autocorrect seems to have got the better of me - correcting: I think you are forgetting the optimisation that goes on, yes the source code has a few more lines of code, but hardly double the size. Perhaps we can come up with some rules/guildlines to what PAYG actually is? Say no

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > The removal code doubles the practical size of the bead. Definitely not PAYG. I think you are forging the optimisation that goes so, yes the source code has a few moraines of code, but hardly double the size. So sorry to say that that an exaggeration and frankly incorrect. Both the

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Actually, the fix can probably be simplified to replacing the original: > e.type = 'password’; > with > e.type = value ? 'password' : 'text’; Not quite as in one case e is derived from the the TextInput passed in, the other it’s derived from the existing stand as null is passed in.

Re: [FlexJS] Removing PasswordInputBead has no effect

Actually, the fix can probably be simplified to replacing the original: e.type = 'password’; with e.type = value ? 'password' : 'text’; I’m personally ok with keeping that change in the original bead. > On Jun 5, 2017, at 7:15 AM, Harbs wrote: > > The removal code

Re: [FlexJS] Removing PasswordInputBead has no effect

The removal code doubles the practical size of the bead. Definitely not PAYG. Subclassing the bead and overidding set strand on JS or creating a new one is definitely the way to go. Harbs > On Jun 5, 2017, at 6:55 AM, Justin Mclean wrote: > > Hi, > >> I would

Re: [FlexJS] Removing PasswordInputBead has no effect

It can't be done in a subclass with an override of the strand setter? -Alex On 6/4/17, 8:55 PM, "Justin Mclean" wrote: >Hi, > >> I would recommend handling removal in an enhanced bead, maybe call it >> RemovablePasswordInputBead. Not everybody will need to remove the

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > I would recommend handling removal in an enhanced bead, maybe call it > RemovablePasswordInputBead. Not everybody will need to remove the bead so > PAYG would say to offer folks the original and your version. I’d prefer not to. There is no extra PAYG cost on the AS side and a null check

Re: [FlexJS] Removing PasswordInputBead has no effect

I would recommend handling removal in an enhanced bead, maybe call it RemovablePasswordInputBead. Not everybody will need to remove the bead so PAYG would say to offer folks the original and your version. Thanks, -Alex On 6/4/17, 8:25 PM, "Justin Mclean" wrote: >Hi,

[FlexJS] Removing PasswordInputBead has no effect

Hi, I just run into an issue with removing the PasswordInputBead when removed the text in the input field was still stared out / hidden. The way to fix is is the set the strand to null on removing the bead and then having the PasswordInputBead reset the input type to “text" when null is passed