Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Justin Mclean
Hi, +1 and I’ll go further to suggest if a checkin break a number of applications out their in the wild we considering reverting it if it can’t be corrected quickly. Thanks, Justin

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread Christofer Dutz
Hi Yishay, Well I would guess that everyone is having the same problem. Due to latest refactoring things are broken and not even the Jenkins build is working. Even if it is providing new versions of the Framework libraries, these currently can’t be used to build applications till the issues are

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Harbs
I still have not managed to get maven setup correctly. > On Mar 28, 2017, at 12:46 PM, Christofer Dutz > wrote: > > Hi Harbs, > (this time replying to the right name ;-) ) > > I usually simply make sure I update my repos and do the full maven build with > tests and

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread yishayw
To be fair, I don't see a lot of instances where changes are pushed into dev, knowing they will break things. I agree this should be avoided. I'm still not sure how our current problem could have been avoided. It'll be clearer once we've figured out what actually happened. -- View this message

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
I forgot to add that "align-items:center" is not supported on the SWF side yet. The Flexbox has a number of properties that I still have to implement on the flex side. On 3/28/17, 8:11 AM, "Peter Ent" wrote: >The HorizontalLayout and VerticalLayout do not center their content

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Harbs
I do think that development should be done almost exclusively on feature branches. If the build status for a feature branch can be verified on the server (like you set it up) that’s ideal because it does not require using specifically ant or maven locally. > On Mar 28, 2017, at 12:59 PM,

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread yishayw
My mistake, the problem is not with event but with goog.events.Event being undefined but with org.apache.flex.core.Application being undefined. So it looks like the same problem Harbs was having [1] [1] http://apache-flex-development.247.n4.nabble.com/Falcon-build-failing-td60790.html --

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Christofer Dutz
Hi Harbs, On a system that you can build with Ant all you should need to do, is to download Maven in a recent version, unpack is somewhere and add the “bin” directory to your systems path. I made sure that the one environment variable the build requires is the same as for Ant. Regarding the

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
I just built another test where I nested Panels in Panels in Panels (since they are compound components) and found some of the layouts still not working right on the JS side. It looks to me like the problem is not setting the style attributes right using Flexbox. While I spent a good deal of time

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
The HorizontalLayout and VerticalLayout do not center their content because the equivalent code on the JS side does not do that (at least it did not do that for me in the tests I ran). I think setting margin:auto is supposed to help with that. On the other hand, you can switch to

[DISCUSS] Changing our general mode of development?

2017-03-28 Thread Christofer Dutz
Hi, For the last months, we have seen a huge increase in people working on the FlexJS and people working on first applications using FlexJS. I think we should discuss how we can make sure we don’t have interruptions like the current one in the future. One point that has been causing pain in

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Harbs
+1. I think it’s OK to develop however we might be comfortable on a feature branch, but we definitely want an approved procedure which must be done before committing to the develop branch. Harbs > On Mar 28, 2017, at 12:29 PM, Christofer Dutz > wrote: > > Hi, >

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Carlos Rovira
+1 to all of this. For people looking at the other's work it more easy to follow git graphs if people make it's own branch. I suscribe all Chris's email and agree with all. So hope folks embrace the maven way of building and abandone ANT since there's no benefit at all in that build system.

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread Christofer Dutz
Hi Yishay, The Ant build doesn’t build a single Application so I would say if you build with Maven without examples this will succeed too, but that doesn’t mean that the build is correct. (See the DISCUSS thread I just opened for details) Chris Am 28.03.17, 11:21 schrieb "Harbs"

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Christofer Dutz
Hi Harbs, (this time replying to the right name ;-) ) I usually simply make sure I update my repos and do the full maven build with tests and examples locally before pushing … I guess this is sufficient protection against most problems. In IntelliJ that’s two clicks and a cup of coffee or

Re: Falcon build failing

2017-03-28 Thread Harbs
Yes. That’s what happened, and I got past that problem. My problem now is not related to the tests. I’m having two problems: 1. org.apache.flex.core.Application is not being added as a dependency to the main app. 2. Any app which uses BinaryData fails to compile. This app:

Re: Falcon build failing

2017-03-28 Thread Greg Dove
Harbs, I saw that error a short while ago, but I am not sure it is related to the native classes. Dependencies calculated for 'org.apache.flex.states.SetProperty' org.apache.flex.states.SetProperty depends on org.apache.flex.core.IDocument was all the appeared immediately before I saw it. If you

Re: Falcon build failing

2017-03-28 Thread Christofer Dutz
Just an edjucated guess from my side … There is a cycle in the dependencies. Maven has problems with this and simply fails to start. Ant doesn’t do this sort of check. If you do a wipe all, eventually the prerequisites of your test get wiped and therefore you can’t run the test so you would

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread yishayw
Stack trace reveals that in org.apache.flex.events.Event.js in line 33: goog.inherits(org.apache.flex.events.Event, goog.events.Event); goog.events.Event is undefined, even though line 13 is goog.require('goog.events.Event'); -- View this message in context:

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread Harbs
The ant build of the framework is working. > On Mar 28, 2017, at 12:11 PM, Christofer Dutz > wrote: > > Hi Yishay, > > Well I would guess that everyone is having the same problem. Due to latest > refactoring things are broken and not even the Jenkins build is

[FlexJX][FalconJX]

2017-03-28 Thread Greg Dove
Hi Alex, if you have time, perhaps you can shed some light on this? I have an mxml component using states, that implements an Interface, IFormSequence. the generated CLASS_INFO looks like this: FLEXJS_CLASS_INFO = { names: [{ name: 'ActionForm', qName: 'components.forms.ActionForm', kind:

[FlexJS] Simple App Not Running

2017-03-28 Thread yishayw
After updating falcon this [1] app, gives the following error: Uncaught TypeError: Cannot read property 'prototype' of undefined at Object.goog.inherits (base.js:2408) at a_project.js:106 base.js:2408 looks like this: tempCtor.prototype = parentCtor.prototype; and parentCtor is

Re: Falcon build failing

2017-03-28 Thread Harbs
It was Josh’s tests that were tripping me up. The build fails after doing a wipe-all. I’ve been having other problems with Falcon, and the latest logging seems to shed some light on what’s wrong: [java] Dependencies calculated for 'org.apache.flex.states.SetProperty' [java]

Re: Falcon build failing

2017-03-28 Thread Harbs
It’s really weird: I can’t see anything in my app which relies on Uint8Array and Uint32Array, and I’m still getting this error. :-( > On Mar 28, 2017, at 11:21 AM, Harbs wrote: > > It was Josh’s tests that were tripping me up. The build fails after doing a > wipe-all.

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread yishayw
Same problem with a fresh nightly. I anyone else getting this? -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Simple-App-Not-Running-tp60825p60826.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [FlexJS] Summary of Changes

2017-03-28 Thread piotrz
Peter, Could you look into TourJS, maybe there you also found some issue with layout there. I'm really interesting how to resolve it there. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: Falcon build failing

2017-03-28 Thread Josh Tynjala
I have moved my new tests into the Ant integration tests, so they should no longer block you. - Josh On Tue, Mar 28, 2017 at 1:21 AM, Harbs wrote: > It was Josh’s tests that were tripping me up. The build fails after doing > a wipe-all. > > I’ve been having other

Re: Falcon build failing

2017-03-28 Thread Harbs
Thanks, but I’m having bigger problems. Hopefully Alex will look into the other issues… > On Mar 28, 2017, at 4:55 PM, Josh Tynjala wrote: > > I have moved my new tests into the Ant integration tests, so they should no > longer block you. > > - Josh > > On Tue, Mar 28,

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
I just pushed a change to the tour code. It should be better. We should be able to do this with the regular horizontal and vertical layouts with % sizing, I think, and not just with Flexbox layouts. One thing I changed was to remove the grow="1" on the layouts. I put that in there to make it easy

Re: [FlexJS] Summary of Changes

2017-03-28 Thread Peter Ent
Here is a link to a Pasteboard [1] that should help. It is a set of nested Panels. If you run this on both SWF and HTML, you'll see differences due to the fact that the SWF side does not yet handle all of the CSS. The HTML should be a nesting of hideously colored boxes with their content

Re: Falcon build failing

2017-03-28 Thread Alex Harui
Hmm. Looks like I broke something. Even DataBindingExample didn't run. I just pushed a change to fix DataBindingExample and hopefully all other apps. Please pull flex-falcon and try again. Sorry about the delay, -Alex On 3/28/17, 7:13 AM, "Harbs" wrote: >Thanks, but

Re: [FlexJS] Simple App Not Running

2017-03-28 Thread Alex Harui
Should be fixed with the latest change to flex-falcon. Please sync up and try again. Thanks, -Alex On 3/28/17, 2:37 AM, "yishayw" wrote: >My mistake, the problem is not with event but with goog.events.Event being >undefined but with org.apache.flex.core.Application

Re: [FlexJS, Maven] Local build failing occasionally

2017-03-28 Thread Alex Harui
Hi Piotr, In this log, on line 2247 is the first error. After that, everything is broken. I haven't looked at the Graphics build since the PixelBender features were added, but I'm not clear that the .pbj files should be compiled. HTH, -Alex On 3/28/17, 11:56 AM, "piotrz"

Re: [FlexJX][FalconJX]

2017-03-28 Thread Greg Dove
Thanks, this was used in a local Log utility which is used for indirect prefixing with info/warn etc. iirc I could not simply use trace cross-platform for this approach, I think there were problems with trace.apply for js (I would need to check, but this is what I recall) so I ended up referencing

Re: Falcon build failing

2017-03-28 Thread Harbs
Looking at you change, I doubt it’ll fix my problem because I WAS using remove-circulars, but I’m trying anyway… > On Mar 28, 2017, at 6:50 PM, Alex Harui wrote: > > Hmm. Looks like I broke something. Even DataBindingExample didn't run. > I just pushed a change to fix

Re: Falcon build failing

2017-03-28 Thread Alex Harui
There are lots of issues being dealt with so I don't know which one you are referring to. I'm still working on the exception in getListOfFiles. -Alex On 3/28/17, 9:42 AM, "Harbs" wrote: >Looking at you change, I doubt it’ll fix my problem because I WAS using

Re: Falcon build failing

2017-03-28 Thread Alex Harui
OK. I think I've fixed the getListOfFiles problem. The Maven examples build seems to be turning on remove-circulars where the Ant build doesn't. That might need to be fixed up, but actually it helps test the code paths in the dependency management. -Alex On 3/28/17, 9:54 AM, "Alex Harui"

Re: [FlexJX][FalconJX]

2017-03-28 Thread Alex Harui
On 3/28/17, 12:59 AM, "Greg Dove" wrote: >Hi Alex, if you have time, perhaps you can shed some light on this? > >I have an mxml component using states, that implements an Interface, >IFormSequence. > >the generated CLASS_INFO looks like this: >FLEXJS_CLASS_INFO = { names:

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread OmPrakash Muppirala
The general approach should be to first merge dev branch into the feature branch and test if any examples are broken. Then ask for volunteers to test the feature branch and report issues. After a reasonable amount of time, the feature branch can ne merged into dev. This will not solve all the

Re: [FlexJS] MDL - Project is failing to compile, help!

2017-03-28 Thread Alex Harui
Hi Santanu, Nobody else has reported your problem recently. Again, I think it is time for you to learn to build the repos and do your development that way so you are not blocked when things get unstable. Then you could roll back as far as you need to. Thanks, -Alex On 3/28/17, 9:17 PM,

Re: Falcon build failing

2017-03-28 Thread Alex Harui
Yep, but I just added it about 10 minutes ago. -Alex On 3/28/17, 9:50 PM, "Harbs" wrote: >I’m getting this with a different project: >No GoogDep for NaN > >I guess NaN needs to be added too? > >> On Mar 28, 2017, at 8:49 PM, Harbs wrote: >> >>

Re: [FlexJS] Anyone working on the build problems?

2017-03-28 Thread Alex Harui
I have disabled the ListExample and made a few other fixes and the Maven build is now building the framework and other examples and is now failing in the IntegrationTests with a Selenium version mismatch error. Hopefully Christofer or someone else can figure that out. I'm going off to do other

Re: Falcon build failing

2017-03-28 Thread Harbs
OK. Why is this happening now? > On Mar 29, 2017, at 7:52 AM, Alex Harui wrote: > > Yep, but I just added it about 10 minutes ago. > > -Alex > > On 3/28/17, 9:50 PM, "Harbs" wrote: > >> I’m getting this with a different project: >> No GoogDep for NaN

Re: Falcon build failing

2017-03-28 Thread Harbs
Can I assume that any types in external swcs will not have this issue? > On Mar 29, 2017, at 8:11 AM, Alex Harui wrote: > > > > On 3/28/17, 9:58 PM, "Harbs" wrote: > >> OK. Why is this happening now? > > In order to handle the reordering of

Re: Falcon build failing

2017-03-28 Thread Alex Harui
On 3/28/17, 10:40 PM, "Harbs" wrote: >Can I assume that any types in external swcs will not have this issue? Don't know. I don't think I've had to add anything like that so far. If you are running into that, then I need to adjust the logic. -Alex > >> On Mar 29,

Re: Falcon build failing

2017-03-28 Thread Harbs
I’m getting this with a different project: No GoogDep for NaN I guess NaN needs to be added too? > On Mar 28, 2017, at 8:49 PM, Harbs wrote: > > Progress! > > It looks like the only problem I now have is the missing dependency on > org.apache.flex.core.Application >

Re: Falcon build failing

2017-03-28 Thread Alex Harui
On 3/28/17, 9:58 PM, "Harbs" wrote: >OK. Why is this happening now? In order to handle the reordering of dependencies, I needed to collect types used in static initializers. The code is throwing a big net over all sorts of identifiers. I suppose I need to make it

Re: git commit: [flex-asjs] [refs/heads/develop] - disable ListExample for now

2017-03-28 Thread Piotr Zarzycki
Alex, I just tried to fix ListExample and I was able to get it build, but for some reason I have report in JS that something is missing. [1] I will be looking into more. [1] https://paste.apache.org/wWrN Piotr 2017-03-29 6:30 GMT+02:00 : > Repository: flex-asjs > Updated

Re: [FlexJS] MDL - Project is failing to compile, help!

2017-03-28 Thread sankar
Hi, I see some other build problem posts came up lately.. I am not sure if the problem I described are similar to the problems others faced in those posts, though. But I'm almost out of business! This latest source really ruin the whole development here. Can I get any archive copy of these

Re: Falcon build failing

2017-03-28 Thread Harbs
Progress! It looks like the only problem I now have is the missing dependency on org.apache.flex.core.Application > On Mar 28, 2017, at 8:00 PM, Alex Harui wrote: > > OK. I think I've fixed the getListOfFiles problem. > > The Maven examples build seems to be turning on

Re: git commit: [flex-falcon] [refs/heads/develop] - Try to fix getListOfFiles exception. If you get this error and the log says 'No GoogDep for xxx' and 'xxx' is a native Javascript type, add it to N

2017-03-28 Thread Harbs
Do we need to also add Map and WeakMap, etc.? > On Mar 28, 2017, at 7:59 PM, aha...@apache.org wrote: > > Repository: flex-falcon > Updated Branches: > refs/heads/develop fce80f5f4 -> 639c5f2c6 > > > Try to fix getListOfFiles exception. If you get this error and the log says > 'No GoogDep

[FlexJS, Maven] Local build failing occasionally

2017-03-28 Thread piotrz
Hi All, I'm struggling with FlexJS Maven build "failing". It's about 80% for me. Errors which I'm getting look like related with build of Graphics - once I get this stacktrace [1] in the other modules I'm getting warnings and errors, [2] even that overall compilation indicates that everythings

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Peter Ent
+1 to this. Having pushed my changes to develop and causing a bit of mayhem, using a feature branch would have been the right thing to do. I'm currently trying to get the Charts package to work which will entail a little bit more change to HTML project, and I will put this into a features branch

Re: [FlexJS, Maven] Local build failing occasionally

2017-03-28 Thread Alex Harui
Hi Piotr, These links don't seem to be to full logs. Both seem to indicate a problem earlier in the log. Please check the full log for errors. I think sometimes the compiler doesn't get Maven to stop. -Alex On 3/28/17, 11:35 AM, "piotrz" wrote: >Hi All, > >I'm

Re: Falcon build failing

2017-03-28 Thread piotrz
Hi, I think I have same problem but with TourJS and Maven build. [1] :) [1] https://paste.apache.org/JWPJ Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Falcon-build-failing-tp60790p60861.html Sent

Re: [FlexJS, Maven] Local build failing occasionally

2017-03-28 Thread piotrz
Hi Alex, Pasting full log [1]. I see earlier some warning, but not sure whether they can cause such fail. I'm going through this logs one by one. 1805 bytes written to D:\flex_sdk\Sources\flex-asjs\frameworks\projects\XML\target\XML-0.8.0-SNAPSHOT.swc in 2.009 seconds

Re: [DISCUSS] Changing our general mode of development?

2017-03-28 Thread Alex Harui
Hi Christofer, Thanks for bringing up this topic. Yes, we should be working in branches more. To me, the problem is in getting folks to try your branch. The "dual" branch has been out there for weeks now. How many of you have tried it? Right now, it seems like the only way to get people to

Re: [FlexJX][FalconJX]

2017-03-28 Thread Greg Dove
Thanks Alex, I confirm this fixed things with the problem I described. I rebuilt Falcon using maven, and after that, compiling without remove-circulars does not have the issue I experienced prior. It was important to clean the local project first (I only mention this because I often forget to do

Re: [FlexJX][FalconJX]

2017-03-28 Thread Alex Harui
On 3/28/17, 12:12 PM, "Greg Dove" wrote: > >FWIW I tried with remove-circulars again but that broke on 'No GoogDep for >console' this time, but I guess you are still working on this. Actually, I would prefer that folks who hit "No GoogDep" fix it themselves by adding what

Re: [FlexJX][FalconJX]

2017-03-28 Thread Alex Harui
Sounds good. Thanks. -Alex On 3/28/17, 12:58 PM, "Greg Dove" wrote: >Thanks, this was used in a local Log utility which is used for indirect >prefixing with info/warn etc. iirc I could not simply use trace >cross-platform for this approach, I think there were problems

Re: [FlexJS, Maven] Local build failing occasionally

2017-03-28 Thread Alex Harui
I believe that Maven runs several COMPCs in parallel, so you will see mixed output which can be hard to understand. My guess is that the PBJ files that are downloaded with the new PixelBender dependency are seen by Maven as a source file to build. I think they should be skipped. -Alex On

Re: [FlexJS, Maven] Local build failing occasionally

2017-03-28 Thread piotrz
I was going farther by that, but I don't really understand why errors in this logs, are around XML module not in Graphics. Graphics need ByteArray. Maybe Harbs or Yishay shed some light on this one. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: