Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, Personally I prefer this approach even if it is more code. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Beads-and-DRY-was-Re-FlexJS-Removing-PasswordInputBead-has-no-effect-tp62177p62204.html

Re: [2/2] git commit: [flex-asjs] [refs/heads/release0.8.0] - fix event types for valuechange. Otherwise Binding would break. Events are global and should be compatible for any given event type

On 6/6/17, 10:27 PM, "Justin Mclean" wrote: >Hi, > >> I agree that there could be a even smaller bead that doesn't track >>changes >> as you move the thumb. Something to do in the next release, IMO. > >Could be or must be? Again just trying to understand why PAYG

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

I'm not sure there is one right way. Some features are "cross-cutting", some build on other features. The first is done in some languages via multiple inheritance, which AS doesn't support, so utility functions (I would like to see our utility classes broken into utility functions) or even beads

Re: [2/2] git commit: [flex-asjs] [refs/heads/release0.8.0] - fix event types for valuechange. Otherwise Binding would break. Events are global and should be compatible for any given event type

Hi, > I agree that there could be a even smaller bead that doesn't track changes > as you move the thumb. Something to do in the next release, IMO. Could be or must be? Again just trying to understand why PAYG wasn’t followed in this case. Was this just an accidental design omission that no

Re: [2/2] git commit: [flex-asjs] [refs/heads/release0.8.0] - fix event types for valuechange. Otherwise Binding would break. Events are global and should be compatible for any given event type

Actually, I was just trying to eliminate an exception so we can ship a release. I agree that there could be a even smaller bead that doesn't track changes as you move the thumb. Something to do in the next release, IMO. But I also saw that I hadn't quite implemented the change correctly, so

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

OmPrakash Muppirala wrote > Bead A supports feature X > Bead B needs to support feature X and Y Theoretically Bead B could support just feature Y, and the strand would choose to add both A and B or just A. -- View this message in context:

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

On Tue, Jun 6, 2017 at 5:29 PM, Justin Mclean wrote: > Hi, > > > In FlexJS we have a preference towards utility classes. > > So say we have existing bead A and we want to add some functionality to > to. In order to use utility classes we would need to modify bead A and

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, > In FlexJS we have a preference towards utility classes. So say we have existing bead A and we want to add some functionality to to. In order to use utility classes we would need to modify bead A and pull out some of the code into a utility class so bead B can use it. This will increase

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

Hi, > This is achieved through composition (the classical OOP paradigm) The document pointed to yesterday suggests to avoid inheritance and prefer composition. Is that just for components and it’s OK to use were needed in beads? Thanks, Justin.

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Actually I will have definitely looked through this early on, but I'd have to > say it is quite 'light' on what PAYG actually means beyond the general sense > that I had. I’d go further as say the definition as it is stated there seem to be perhaps too wide? > But I can see that the

Re: [2/2] git commit: [flex-asjs] [refs/heads/release0.8.0] - fix event types for valuechange. Otherwise Binding would break. Events are global and should be compatible for any given event type

Hi, I see you've added code to handle binding / values changes to RangeModel.as and RangeModelExtended.as. Is there any reason the value change code is not in another classes called for instance ValueChangeRangeModel? It seem to me that this model it trying to do more than one thing i.e.

Re: git commit: [flex-asjs] [refs/heads/release0.8.0] - Fix for FLEX-35322: NumericStepper layout.

Hi, Not 100% sure and I probably not understanding what these methods are doing but perhaps the issue is in isHeightSizedToContent / isWidthSizedToContent. Does the last line of each function look suspect to anyone else? return (left === undefined || right === undefined); return (top ===

AW: [FlexJS] [Typedefs] [Maven] build issues

Nope … don’t have any issues on a Mac. I wouldn’t say that I am really happy with the patching and all, the way it’s done today. We are relying on an external executable. As you might have noticed, I don’t like executing Things outside the VM and like to have Things inside the Java world and

[FlexJS] [Typedefs] [Maven] build issues

I have had a few issues with maven build of typedefs (in develop) over recent times. I think others may have experienced this also, at least I have seen similar things mentioned previously. For me this seems to be related to patches being applied when the content that is being downloaded is

Re: [FlexJS] Removing PasswordInputBead has no effect

That would be great. Harbs > On Jun 6, 2017, at 10:24 PM, Greg Dove wrote: > > If no-one else volunteers to wiki-fy the contents of the new thread at its > conclusion, I will give it a shot over the coming weekend.

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

There’s actually two ways of adhering to DRY: 1. Subclassing 2. Utility classes. In FlexJS we have a preference towards utility classes. (and I’d like to see even more) Besides very often doing a better job than subclasses in terms of avoiding code-repeat, it’s also more geared towards

Re: [FlexJS] Removing PasswordInputBead has no effect

Alex, and Harbs, Thanks for pointing that out. Actually I will have defifintely looked through this early on, but I'd have to say it is quite 'light' on what PAYG actually means beyond the general sense that I had. It does have some more detail about beads which is great and I could have

Re: Finding tools in the toolbox

I'm not sure what is possible in Flash Builder. I honestly don't use code-hinting in FB because I know the APIs pretty well. If FB with the regular Flex SDK can offer allowed values for properties, then it should be possible to offer allowed values for the bead property, although I think that is

Re: Finding tools in the toolbox

Here’s what I’m after: 1. In mxml, I’d like to markup and then be given a list of valid beads for the current component. What’s the easiest way for tooling to get such a list? 2. With a bead selected, I’d like tooling to allow refactor and give a list of beads which can replace the current one

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Looking forward to it! :) - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p62184.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

OK, Maven is building, NumericStepper seems to be working and ASDoc is working. Sounds like we are good to go. I will prepare an RC tonight. Thanks everyone! -Alex On 6/6/17, 12:41 AM, "piotrz" wrote: >Yep. It should. I did fix yesterday and monitoring it all the

Re: Finding tools in the toolbox

You are welcome to add a new tag. Could be something like @workswith classOrInterface Or maybe @knownstrands. I'm not sure what you visualize for "display hierarchy" and "code hinting". Fundamentally, we have raw data in .json files and you can write code to process and visualize that data.

Re: Finding tools in the toolbox

It seems like there should be a mechanism to add arbitrary tags that include references to acceptable components. Maybe use interfaces to indicate swap-ability? What format would be best for tooling to display hierarchy and code hinting? Should there be a manifest file, or is the ASDoc enough

Re: Finding tools in the toolbox

View beads have @viewbead ASDoc tag Top-level components have @toplevel ASDoc tag. All tags are output to tags.json and the ASDoc example could implement any sort of filtering based on those tags. New tags I think can be added by just adding them to the ASDoc and maybe telling the compiler to

Re: Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

In an attempt to simplify the pattern, can we say: Strands = components Beads = functionalities All components dont need all functionalities. We add functionalities to components on a Pay As You Go (PAYG) basis. This is achieved through composition (the classical OOP paradigm) That is, a

Re: Finding tools in the toolbox

What do the annotations look like? Maybe there should be some kind of manifest that documents beads and their relationships? > On Jun 6, 2017, at 5:46 PM, Alex Harui wrote: > > Definitely needs more. > > In the ASDoc example, there is a checkbox to see just view

Beads and DRY (was Re: [FlexJS] Removing PasswordInputBead has no effect)

I agree we have to be concerned about DRY. Research into optimal patterns for creating common flavors of beads would be very helpful. The compiler might be able to help as well. -Alex On 6/6/17, 6:52 AM, "Josh Tynjala" wrote: >The way that beads work means that we will

Re: Finding tools in the toolbox

Definitely needs more. In the ASDoc example, there is a checkbox to see just view beads. I have added ASDoc annotations to the view beads so they show up when that filter is on. I'm sure view beads may have been added since I first did that, and maybe the annotation accidentally got copied into

Re: [FlexJS] Layout of NumericStepper is broken

I found the problem: the NumericStepper's sizeChange handler was not being called when the NS appears in this simpler test case. It is being called when it is displayed in the FlexJSStore, for example. The more complex app with nested containers and layouts is setting the right conditions so the

Re: [FlexJS] Removing PasswordInputBead has no effect

The way that beads work means that we will frequently "violate" DRY, as I understand it. FlexJS is designed to have multiple beads that implement the same thing in different ways. The simplest bead will be designed to be never removed and it probably won't include any properties to configure its

Re: [FlexJS] Layout of NumericStepper is broken

OK, thanks. I'm looking at this now (as soon as my sync of Alex's changes completes). ‹peter On 6/6/17, 3:17 AM, "piotrz" wrote: >Peter, > >I just raised jira -> >https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.ap

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

It sounds like a micro-optimization, but it saves some bytes and doesn’t look like a functional change, so go knock yourself out… ;-) > On Jun 6, 2017, at 1:43 PM, Justin Mclean wrote: > > Hi, > > Just profiled these with a variety of inputs and the first is around 3

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

I think it would be great! Let see what Alex thing. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

True. else if (strpixels.length == 0) should probably be: else if (strpixels === “”) > On Jun 6, 2017, at 1:01 PM, Justin Mclean wrote: > > Hi, > >> Language.as() is not being called (@flexjsignorecoercion is being used). > > And it will still throw an RTE if

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Changed. > On Jun 6, 2017, at 1:37 PM, Harbs wrote: > > True. > > else if (strpixels.length == 0) > > should probably be: > else if (strpixels === “”) > >> On Jun 6, 2017, at 1:01 PM, Justin Mclean wrote: >> >> Hi, >> >>> Language.as() is

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, Just profiled these with a variety of inputs and the first is around 3 times as fast as the second. I added a null check to stop the RTE, if the null check is not needed it can be removed from both. public function test(str:String):Number { var pixels:Number = NaN; if (str !==

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, > var strpixels:String = element.style.width as String; > if (strpixels.indexOf('%') === -1) > > We may have still RTE ? Yep it would also RTE if strpixels was null. So perhaps this instead? > if (strpixels !== null && strpixels.indexOf('%') === -1) Justin

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

I think it would be good to change all those with your proposition. For me it's cleaner, but with this one from you: var strpixels:String = element.style.width as String; if (strpixels.indexOf('%') === -1) We may have still RTE ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com --

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, > You propose changing whole this part [1] with yours ? Or something similar / along those line that was off the top of my head and had not been tested. Perhaps if null is never passed in then it doesn’t need to be checked for and the code may not RTE? Thanks, Justin

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Justin, You propose changing whole this part [1] with yours ? [1] https://paste.apache.org/L1Mq Just wanted to understand. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, > Language.as() is not being called (@flexjsignorecoercion is being used). And it will still throw an RTE if strpixels is null. > if (strpixels !== null && strpixels.indexOf('%') != -1) will be false > else if (strpixels.length == 0) throws RTE Thanks, Justin

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Language.as() is not being called (@flexjsignorecoercion is being used). > On Jun 6, 2017, at 12:50 PM, Justin Mclean wrote: > > Hi, > > In more detail the issue is that the property is likely to default to > undefined and casting that to String in JS like so >

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, In more detail the issue is that the property is likely to default to undefined and casting that to String in JS like so org.apache.flex.utils.Language.as(undefined, String)) will set the value to null and strpixels.length with throw a RTE. So it’s likely this change in will cause all

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, in fact this code will throw a RTE is width / strpixels is null so you may want to reconsider the implementation. Justin

Re: [2/4] git commit: [flex-asjs] [refs/heads/release0.8.0] - looks like we get '' (empty string) sometimes which coerces to 0. We want it to be NaN

Hi, This is probably a simpler / less costly way of doing the same thing: var pixels:Number = NaN; var strpixels:String = element.style.width as String; if (strpixels.indexOf('%') === -1) pixels = parseFloat(strpixels); Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

I think because this bead after your changes is doing two things and you can split responsibility to the other class. - Is it enough reasonable ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > What’s not clear once you read that doc? It’s unclear to me why the code I checked in isn’t PAYG as it fits with the definition of PAYG in that document. Thanks, Justin

Re: [FlexJS] Removing PasswordInputBead has no effect

The definition is fine. The fact that it’s 4 years old is irrelevant. What’s not clear once you read that doc? Please just revert your changes and make a new bead. There’s no reason to have so much discussion on this… > On Jun 6, 2017, at 11:18 AM, Justin Mclean

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Imposing your different opinion in others is not the Apache Way. How am I’m imposing anything here Alex? It is you that's instating that just in time code that follows the PAYG principal as documented and that has zero practical overhead is not PAYG. From my understanding several

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Yep. It should. I did fix yesterday and monitoring it all the time. :) I would also be against if Maven build is not working. :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Chris, But my understanding was that is not working in develop branch and when we merge release to it - should work. Am I wrong? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Ok … just saw that it seems to be working again … Chris Am 06.06.17, 09:42 schrieb "Christofer Dutz" : Well I’d say as long as the Maven build doesn’t work, that’s a no-go from my side. Chris Am 06.06.17, 09:19 schrieb "Alex Harui"

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Well I’d say as long as the Maven build doesn’t work, that’s a no-go from my side. Chris Am 06.06.17, 09:19 schrieb "Alex Harui" : I think Accordion is now working. Folks have seen their code work with Dual. Is there anything else that is stop-ship?

Re: [FlexJS] Layout of NumericStepper is broken

Peter, I just raised jira -> https://issues.apache.org/jira/browse/FLEX-35322 Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Layout-of-NumericStepper-is-broken-tp62108p62149.html Sent from the

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Jira raised for NumericStepper -> https://issues.apache.org/jira/browse/FLEX-35322 - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p62150.html Sent from the

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Alex, Yes I think problem with NumericStepper should be fixed [1], cause component is unusable in that way. [1] http://apache-flex-development.247.n4.nabble.com/FlexJS-Layout-of-NumericStepper-is-broken-td62108.html Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this

Re: [FlexJS] Removing PasswordInputBead has no effect

I didn't say it was my project. Just my vision. And for the past 4 years, others seem to share it. I believe that is consensus. Bertrand advised us many years ago to make things modular, which FlexJS is, so folks with different opinions can go implement their opinion in a different module.

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi Justin, Agree with you that we may not everywhere applying in PAYG manner, probably you will find more examples, but there is no point to do this. I think you can just try to fix that, cause that's what for we are here I think. :) I'm done with those discussion in case of changes with that

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I think Accordion is now working. Folks have seen their code work with Dual. Is there anything else that is stop-ship? Otherwise I will start the RC process tomorrow. -Alex On 6/1/17, 2:29 AM, "piotrz" wrote: >Thanks Alex! We are blue again [1] :) > >[1]

Re: [FlexJS] Accordion broken

I just pushed changes that make Accordion look ok to me on both SWF and JS. This is the test case I used. https://paste.apache.org/ELvN -Alex On 6/5/17, 10:57 PM, "yishayw" wrote: >Not sure I understand. Is release Accordion working with the example I >posted >[1]?

RE: [FlexJS] DataBinding Problem

It will work for you, but your raised bug is more general thing. Almost each component has model - what if I would like to change that model on the fly ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

RE: [FlexJS] DataBinding Problem

It looks like Alex is modifying Panel to fix the problem in Accordion. I’m good with that. From: piotrz Sent: Tuesday, June 6, 2017 10:10 AM To: dev@flex.apache.org Subject: Re: [FlexJS] DataBinding Problem I think we can make it as

Re: [FlexJS] DataBinding Problem

I think we can make it as feature request and Yishay probably need to handle "modelChanged" event on your own to have such code working on the fly. What do you think Yishay ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > Unless something is functionality that you would (virtually) always need, > it’s a separate bead. So for CCS we have border, does everyone need borders? Why do we only a sub set of the font attributes included? Some people are not going to use all of them or in fact any of them and

Re: [FlexJS] Removing PasswordInputBead has no effect

Hi, > The wiki from 4 years ago is very helpful in understanding architectural > decisions: > https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype > >

Re: [FlexJS] Removing PasswordInputBead has no effect

This was first published in 2012. https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype PAYG and avoiding just-in-case code is mentioned in that document. As are Beads. Thanks, -Alex On 6/5/17, 11:33 PM, "Greg Dove" wrote: >Harbs, a quick comment from

Re: [FlexJS] Removing PasswordInputBead has no effect

The wiki from 4 years ago is very helpful in understanding architectural decisions: https://cwiki.apache.org/confluence/display/FLEX/Alex's+FlexJS+Prototype If you have suggestions to make things clearer then by all

Re: [FlexJS] DataBinding Problem

I have local changes that fixes Binding in Accordion by changing the lifecycle of the underlying Panel that AccordionItemRenderer subclasses. I'll push them before I shut down for the day. I want to try to fix the TitleBar height issue on JS first. The reasoning is that ItemRenderers are

Re: [FlexJS] DataBinding Problem

Alex, I was thinking about that more and more. I think the way how MXMLBeadViewDataBinding decided what binding has been chosen in case of TitleBarView is ok. - We probably shouldn't change anything in that matter. Exchange model - That's more global thing - cause if we allow for this in case of

Re: [FlexJS] Removing PasswordInputBead has no effect

Harbs, a quick comment from the sidelines on: "PAYG is already well understood" I don't really think that is the case, at least it has not been for me. I had a more general notion of PAYG that was nothing to do with beads at all, and was limited to guesswork/my own interpretation of it at the

Re: [FlexJS] DataBinding Problem

It's actually MXMLBeadViewDataBinding. The simplest solution may be to avoid using binding in TitleBarView and explicitly listen to TitleBar's "modelChanged" event and TitleBarModel's "titleChange" event. But any other solution is fine by me. -- View this message in context:

Re: [FlexJS] Accordion broken

Not sure I understand. Is release Accordion working with the example I posted [1]? I just fetched and logged flex-asjs and couldn't see any accordion related changes. Can you send a commit id? Thanks. [1] https://paste.apache.org/QUj1 -- View this message in context: