Re: git commit: [flex-asjs] [refs/heads/develop] - Added support for JS upload progress events

Not really. I wrote the original code and I was making these changes anyway and some of the lines were really long. > On Jul 15, 2017, at 4:34 AM, Justin Mclean wrote: > > Hi, > > I notice in this check in you changed all of the event contestants to hard > coded strings i.e. HTTPConstants.STA

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

I was thinking of doing it in feature, but I did not know if it made sense. I’m not opposed to doing so. > On Jul 16, 2017, at 10:31 AM, piotrz wrote: > > Hi Harbs, > > Is it possible move this branch to existing folder feature? Once you do this > I can creat same bra

[FlexJS] Debugging package

that? missing.js? Harbs

Re: [FlexJS] Debugging package

Yes. Will do when I’m done. > On Jul 16, 2017, at 12:18 PM, piotrz wrote: > > Harbs, > > It would be great if you could creat Example project which demonstrate how > to use those functions. > Maybe additionally confluence page. > > Thanks, > Piotr >

Re: [FlexJS] Falcon AsJS Mismatch?

Is this with Alex’s latest changes? These backslash escapes seem really difficult to get right… :-( > On Jul 16, 2017, at 2:41 PM, yishayw wrote: > > Looks like falcon is incompatible with TabStopsPropety.as in TLF. When > initializing that file I'm getting the following RTE: > > Uncaught syn

Re: [FlexJS] Debugging package

That import should have been commented out in CoreClasses and it should not be compiled. Does Maven work differently? > On Jul 16, 2017, at 3:02 PM, piotrz wrote: > > Harbs, > > I just tried compile FlexJS by Maven and got following error in core: > > conditionalBreak.a

Re: [FlexJS] Debugging package

I just added an example project (maybe it should have gone into manual tests?). Interesting to note: Adding a number of callLater() calls resulted in only the first one being called in JS. I did not try as a SWF. > On Jul 16, 2017, at 12:24 PM, piotrz wrote: > > Thank you! :) And I really lik

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

I renamed the branch. > On Jul 16, 2017, at 12:11 PM, piotrz wrote: > > You are doing core changes. Monitoring it on jenkins would be great. Apart of > that I can check some examples without building it locally. > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > Vie

FYI: React appears to be a no-no

The incompatibility of React’s license is potentially significant for FlexJS.[1] [1]https://issues.apache.org/jira/browse/LEGAL-319

Re: [FlexJS] Debugging package

Because it’s not being imported by CoreClasses. What is making Maven import it? > On Jul 16, 2017, at 6:25 PM, piotrz wrote: > > Let's create jira for that. I'm surprise that Ant build is not complaining > about that. Why? > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.co

Re: [FlexJS] Debugging package

to pause in the debugger. > > - Josh > > > On Jul 16, 2017 2:07 AM, "Harbs" wrote: > > I just added a debugging package to FlexJS. There are two things I don’t > know how to do: > > 1. The debugging functions should disappear in a release build of JS, bu

Re: [FlexJS] Falcon AsJS Mismatch?

I wasn’t complaining. I was sympathizing. If I knew how, I’d help. Harbs > On Jul 16, 2017, at 6:30 PM, Alex Harui wrote: > > Someone else is welcome to take over. This stuff is not something I enjoy > doing at all. > > -Alex > > On 7/16/17, 5:17 AM, "Harbs&qu

Re: [FlexJS] Debugging package

What needs to be modified? Does it need to be added to NativeJSType enums? Somewhere else? I’m really not clear on when things to be added to that and when they need to be in typedefs. > On Jul 16, 2017, at 6:51 PM, Harbs wrote: > >> The compiler needs to be modified to support

Re: [FlexJS] Debugging package

lated to > appropriate bytecode to call enterDebugger(). > > - Josh > > On Jul 16, 2017 8:56 AM, "Harbs" wrote: > >> What needs to be modified? Does it need to be added to NativeJSType enums? >> Somewhere else? >> >> I’m really not clear on

[FlexJS] Avoiding Language.closure (was Re: [FlexJS] Debugging package)

tly to: "setTimeout(makeCalls, 0);", it works like I’d expect it to. Thanks, Harbs > On Jul 16, 2017, at 3:46 PM, Harbs wrote: > > Interesting to note: > > Adding a number of callLater() calls resulted in only the first one being > called in JS. I did not try as a SWF.

Re: [FlexJS] Avoiding Language.closure (was Re: [FlexJS] Debugging package)

as well: [mxmlc] Jul 16, 2017 7:26:08 PM com.google.javascript.jscomp.LoggerErrorManager println [mxmlc] WARNING: /Users/harbs/Documents/ApacheFlex/flex-asjs/examples/flexjs/DebuggingExample/bin/js-debug/org/apache/flex/utils/callLater.js:35: WARNING - dangerous use of this in static

Re: FYI: React appears to be a no-no

No. I just thought this was newsworthy. > On Jul 17, 2017, at 10:27 AM, Alex Harui wrote: > > I"m not following. Do we currently have a required dependency on React? > > -Alex > > On 7/16/17, 6:19 AM, "Harbs" wrote: > >> The incompatibility

Re: FYI: React appears to be a no-no

ook/react/issues/10191#issuecomment-315707719> > On Jul 17, 2017, at 1:09 PM, Yishay Weiss wrote: > > Does that rule out a reactjs component set (ala createjs)? > > From: Harbs<mailto:harbs.li...@gmail.com> > Sent: Monday, July 17, 2017 12:47 PM > To: dev@flex.apac

[FlexJS XML] for each

= foreachiter57_target[foreachiter57]; Bracket access to XMLList returns an XML object. 3. Add a new function to use instead of child() (i.e. getChild()). Thoughts? Harbs

[Falcon] operand stack underflow?

I just updated flex-falcon and flex-asjs. After rebuilding everything, I’m getting the following error when compiling my app: https://paste.apache.org/3wBr <https://paste.apache.org/3wBr> This is a new one for me… Suggestions? Harbs

Re: [Falcon] operand stack underflow?

The previous error was what I got when using asconfigc in VS Code. Here’s the stack trace when building using Ant: https://paste.apache.org/Sy93 <https://paste.apache.org/Sy93> > On Jul 17, 2017, at 3:09 PM, Harbs wrote: > > I just updated flex-falcon and flex-asjs. After rebuil

Re: [FlexJS XML] for each

something like that) where it would return an XML element if it’s a single and throw an error otherwise. Then anytime there is an XMLList assignment to XML, the compiler could add .toXML(). Harbs > On Jul 17, 2017, at 7:11 PM, Alex Harui wrote: > > IMO, this points out a generic problem

Re: [FlexJS XML] for each

changing ForEachEmitter.java. > > For the general problem, we should probably just use the XML() top-level > function to "coerce" XMLList to XML. > > My 2 cents, > -Alex > > On 7/17/17, 9:23 AM, "Harbs" wrote: > >> That is a fourth option. >> &

Re: [Falcon] operand stack underflow?

x-asjs >> call ant super-clean >> git pull >> ant clean all >> >> >> I am however getting a runtime error because of the following line in >> PortedPrintUI.js: >> >> function() {this["border"] = ; >> >> Which probably come

Re: [FlexJS XML] for each

of it. (i.e. if an XMLList is fed to the XML constructor, call toXML() on the XMLList and return that.) Harbs > On Jul 17, 2017, at 10:08 PM, Alex Harui wrote: > > I thought we (you) already wrote one. If not, we won't we need one? > > -Alex > > On 7/17/17

Re: [FlexJS XML] for each

I just tried to see if it might work, but I get an error. Obviously that’s a no-no... [java] /Users/harbs/Documents/ApacheFlex/flex-asjs/frameworks/projects/XML/src/main/flex/XML.as(317): col: 13 A return value is not allowed in a constructor. [java] [java

Re: [FlexJS] Avoiding Language.closure (was Re: [FlexJS] Debugging package)

y assignment in the function > body. I just pushed changes to reflect that. > > -Alex > > On 7/16/17, 11:41 PM, "Alex Harui" wrote: > >> Seems reasonable to add a check to see if the function body is for a >> static method. >> >> -Alex >&g

Re: [FlexJS] Falcon AsJS Mismatch?

> -Alex > > On 7/16/17, 8:52 AM, "Harbs" <mailto:harbs.li...@gmail.com>> wrote: > >> I wasn’t complaining. I was sympathizing. >> >> If I knew how, I’d help. >> >> Harbs >> >>> On Jul 16, 2017, at 6:30 PM, Alex Ha

Re: [FlexJS] Avoiding Language.closure (was Re: [FlexJS] Debugging package)

rning and I’m curious as to why it’s being output. > On Jul 17, 2017, at 10:36 PM, Harbs wrote: > > I’m not going to claim I understand what you just wrote. ;-) > > I’ll see if I can understand the output… > > Thanks. > >> On Jul 17, 2017, at 10:33 PM, Alex Har

Re: [FlexJS XML] for each

the compiler catch the top-level function call and redirect it to > that conversion function. > > Thoughts? > -Alex > > http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/package. > html#XML() > > On 7/17/17, 12:32 PM, "Harbs" wrote: >

Re: [FlexJS] Falcon AsJS Mismatch?

should I try tomorrow? (Shutting down for the night.) > On Jul 18, 2017, at 12:42 AM, Alex Harui wrote: > > Harbs, the log indicates that the last person in that code was you and you > commented out the test that would have caught this. What was the reason > for that? > > Se

Re: [FlexJS XML] for each

> > I'm going to figure out why your standalone functions like callLater, > assert, etc, aren't handled correctly then we should seriously think about > finding a volunteer to break up these utility classes into utility > functions since that would be more PAYG. >

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

Not surprised. I still have quite a bit to do before I’d expect it to build. > On Jul 18, 2017, at 7:20 AM, piotrz wrote: > > Hi Harbs, > > I've created pipelines for your strand-work branch. Just run the build and > it failed [1]. > > [1] > https://builds.a

Re: [FlexJS] technical debt

expect some rules to be changed. Thanks, Harbs > On Jul 18, 2017, at 8:50 AM, Justin Mclean wrote: > > Hi, > > So more than a week has gone by and I’ve received little feedback on [1]. > Given that I’ll gone ahead and implement the rules as discussed in the > document

Re: git commit: [flex-asjs] [refs/heads/develop] - Added support for JS upload progress events

> On Jul 18, 2017, at 5:41 AM, Justin Mclean wrote: > > Hi, > > I can see these event name changes haven’t been reverted yet. Do you want me > to do that for you? No. The consensus was that the compiler needs improvement to replace static constants with string literals and for now to not enf

Re: git commit: [flex-asjs] [refs/heads/develop] - Added support for JS upload progress events

It’s kind of low on my priority list right now… ;-) > On Jul 18, 2017, at 8:53 AM, piotrz wrote: > > Harbs, > > If there is no jira around there about that - please raise one once you get > a chance. > > Thanks, > Piotr > > > > - > A

Re: [FlexJS] technical debt

around for no reason. Thanks, Harbs > On Jul 18, 2017, at 9:09 AM, piotrz wrote: > > Hi Justin, > > Do you mean by this one > > "It looks to me that FielEventError, FileEvent, ContextMenuEvent and Focus > event are missing close methods and probably require them

Re: [FlexJS] technical debt

Sure. But for which events? You seem to have missed my point. > On Jul 18, 2017, at 10:35 AM, Justin Mclean wrote: > >> How often is clone really used? > > I’ve used it in just about every single application I've ever written in Flex > and I assume most applications will need it.

Re: [FlexJS XML] for each

fence about objects. I’m leaning toward always throwing an error if the argument is an object. Thoughts? Harbs [1]http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/package.html#XML() <http://help.adobe.com/en_US/FlashPlatform/reference/actionscript/3/package.html#XML()>

Re: [FlexJS XML] for each

errors. > On Jul 18, 2017, at 11:07 AM, Harbs wrote: > > I discovered that the documentation on the top level functions is wrong. > > According to the docs[1] the only valid expressions for XML and XMLList are: > XML, XMLList, Boolean, Number and String. Anything else is suppo

Re: [FlexJS] String.match()

The same issue applies to String.search(), although it might make sense to replace String.search() with String.indexOf() if the parameter is a string. > On Jul 18, 2017, at 12:36 PM, yishayw wrote: > > In flash String.match() can take either a string or a regex. In JS it's > always considered t

Re: [FlexJS XML] for each

eally want to cast on object to a string, you can always call toString(). Fixing such code should be really easy. In terms of implementation, it’s not really harder one way or the other. > My 2 cents, > -Alex > > On 7/18/17, 1:29 AM, "Harbs" <mailto:harbs.li...@gmail.

Re: [FlexJS] String.match()

that using strings is not recommended. Harbs > On Jul 18, 2017, at 6:37 PM, Alex Harui wrote: > > This feels like something that the compiler should just call > Language.stringMatch and Language.stringSearch (or standalone > equivalents). I'm not clear that we should alwa

Re: [FlexJS] String.match()

Here seems to be the explanation for that: new RegExp("?”) In Flash, this creates a RegExp object. In JS, it throws an “Invalid regular expression” error. > On Jul 18, 2017, at 9:38 PM, Harbs wrote: > > The “?” case seems to be an outlier.

[FlexJS] stopImmediatePropagation

thrown. If you’re still reading, thanks for bearing with me… :-) Thoughts? Comments? Corrections? Harbs [1]https://developer.mozilla.org/en-US/docs/Web/API/Event/stopImmediatePropagation <https://developer.mozilla.org/en-US/docs/Web/API/Event/stopImmediatePropagation>

Re: [FlexJS] stopImmediatePropagation

I just created a branch with some of these ideas. > On Jul 19, 2017, at 12:14 PM, Harbs wrote: > > This is kind of long, so please bear with me… ;-) > > I’m not sure what the “right” way to deal with my issue is, so I’m looking > for input. > > Curr

Re: [FlexJS] String.match()

I added the utility functions. I think they can be very simple. > On Jul 19, 2017, at 9:30 AM, Alex Harui wrote: > > Unless we are absolutely sure that everybody will need the code generated > by the compiler, having the compiler call a framework function makes it > easier for an app developer t

Re: [FlexJS] stopImmediatePropagation

I temporarily worked around our issues by using a try/catch in the code that calls the handler. I’d like to hear what Alex and Peter have to say about this. > On Jul 19, 2017, at 3:05 PM, yishayw wrote: > > I don't see what we would lose by making your changes and it would solve the > issue we'

Re: [FlexJS] stopImmediatePropagation

easily with the KeyboardEvent change than with BrowserEvents. I don’t know why. I’m going to leave the browser-event branch until I either figure it out or get some feedback on this… > On Jul 19, 2017, at 3:25 PM, piotrz wrote: > > Yishay, Harbs, > > Are you using MDL in your pro

Re: [FlexJS] String.match()

lex Harui wrote: > > It looks like they just trace a warning instead of trying to convert to a > RegExp. Is that what we want to do? Or should we add code that converts > a string to regex? > > Thoughts? > -Alex > > On 7/19/17, 4:32 AM, "Harbs" wrote: >

Re: [FlexJS] Debugging package

I don’t think there were any responses to this. As it stands, the debugging functions will exist in release versions of swfs. Harbs > On Jul 16, 2017, at 12:07 PM, Harbs wrote: > > 1. The debugging functions should disappear in a release build of JS, but I’m > not sure how to m

Re: [FlexJS] String.match()

Yes. trace is stripped out in release. (We still need to remove the dead code, but that will happen too.) > On Jul 20, 2017, at 9:37 AM, piotrz wrote: > > Hi Harbs, > > I'm not so convinced by the trace. Maybe something from your debugger to > have everything in debug.

Re: [FlexJS] stopImmediatePropagation

it might not be a bad idea to patch (or rewrite) the goog Event code, but I have bigger fish to fry at this point. Thanks, Harbs > On Jul 20, 2017, at 3:30 AM, Alex Harui wrote: > > I haven't had time to dig into it, but IIRC, because we are using Google &g

Re: [8/8] flex-asjs git commit: stopPropogation on the goog BrowserEvent is needed. I don’t know if the stopImmediatePropagation on the real browser event actually does anything and I don’t know how t

Yes. > On Jul 20, 2017, at 10:14 AM, Piotr Zarzycki > wrote: > > Harbs, > > Did it help with your problem on loosing focus when you are using > KeyboardEvent ? > > Thanks, Piotr > > 2017-07-20 9:05 GMT+02:00 : > >> stopPropogation on the goog Brow

Re: [FlexJS] Debugging package

It might be possible extend that code to > remove other things. > > -Alex > > On 7/19/17, 11:47 PM, "Harbs" wrote: > >> I don’t think there were any responses to this. >> >> As it stands, the debugging functions will exist in release versions of

Re: [FlexJS] stopImmediatePropagation

No hurry at all. I don’t need these code changes. > On Jul 20, 2017, at 10:29 AM, piotrz wrote: > > Harbs, > > If you are not in a hurry I may look into your branch on Sunday evening and > check whether our app is not breaking up. Can you wait with this one till > then

Re: [FlexJS] stopImmediatePropagation

have the same way of finding the > element wrapper. > > -Alex > > On 7/20/17, 12:15 AM, "Harbs" <mailto:harbs.li...@gmail.com>> wrote: > >> Yes. This appears to be it. I did not step through the code, but >> re-adding in wrappe

Re: [FlexJS] Debugging package

Hard code what? For any function in the org.apache.flex.debugging package it would not output to release SWF? > On Jul 20, 2017, at 11:00 AM, Alex Harui wrote: > > For now, I would just hard code it. > > On 7/20/17, 12:55 AM, "Harbs" wrote: > >> Coo

Re: [8/8] flex-asjs git commit: stopPropogation on the goog BrowserEvent is needed. I don’t know if the stopImmediatePropagation on the real browser event actually does anything and I don’t know how t

gt;> .apache.org%2Frepos%2Fasf%2Fflex-asjs%2Fdiff%2Fc14db8d7&data=02%7C01%7C%7C >> b5625927d26d4a41b6e008d4cf3daa2a%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C >> 0%7C636361311137863712&sdata=A7OBs%2F1%2Fv%2B5AfVH7iPQmDt0%2FeNYHqeoVEtjN% >>

Re: [FlexJS] Debugging package

We also need to modify the output for trace in JS to put the goog.DEBUG check at the very start of the function and to not output the @export tag. The rest of the debugging functions need to lose the @export tag as well. Should I put all this in a JIRA? > On Jul 20, 2017, at 11:16 AM, Ha

Re: [FlexJS] String.match()

7C636361488561328745&sdata=CbWB8sk4vOv1vId9aT7 >> WkDjQrkqarHU2aAAoWw9UBNA%3D&reserved=0() >> >> From: Harbs<mailto:harbs.li...@gmail.com> >> Sent: Thursday, July 20, 2017 9:40 AM >> To: dev@flex.apache.org<mailto:dev@flex.apache.org> >> Subje

Re: [FlexJS] String.match()

earch(foo)//-1 "baz".search(foo)//0 It results in 1,-1,0 on both platforms. So, despite what the docs say, what seems to happen on both platforms is: 1. toString() is called. 2. new RegExp() is being called with the result of that. 3. The result of #2 is being used as the parameter for m

Re: [FlexJS] String.match()

Right. That’s why I was suggesting wrapping the call in a try/catch and returning null/-1 from the catch. Additionally, the array returned from String.match() is a non-standard one. It has input and index properties. > On Jul 20, 2017, at 8:52 PM, yishayw wrote: > > I think there would still

Re: [FlexJS] String.match()

rui wrote: > > I'm confused. Doesn't Yishay's example use syntax that Harbs claimed > threw an error? > > Anyway, I can believe the three steps Harbs listed are correct for JS > since step 1 might just happen via implicit type coercion. I suppose > someone cou

Re: [FlexJS] String.match()

anything. The use of such a RegExp in the first place can only be described as a bug. “Fixing” the JS behavior to match the Flash behavior is the wrong thing to do. > On Jul 20, 2017, at 10:34 PM, Harbs wrote: > > new RegExp({}) > returns: > /[object Object]/ > > I think th

Re: [FlexJS] String.match()

lid RegExp and call match() or use > indexOf() and compute the same result. It should not always return null. > Then I think it would completely implement how it worked in Flash and the > users won't have to figure out how to regex-ify the strings in the apps > they are porting.

Re: [FlexJS] stopImmediatePropagation

Yes. That’s the same issue that Alex has pointed out. > On Jul 21, 2017, at 8:44 AM, piotrz wrote: > > Hi Harbs, > > I just take a look into your branch and unfortunately something is wrong. > Our Tab component in MDL application stopped working. I see currentTarget is >

Re: [FlexJS] findPopupHost issue

Bubbling does not work very well in FlexJS in general. When you can rely on native browser event bubbling, it usually works okay, but custom events don’t bubble. > On Jul 21, 2017, at 1:49 AM, Justin Mclean wrote: > > Hi, > >> The issue was that the TitleBar was dispatching "close" with bubbl

Re: [FlexJS] stopImmediatePropagation

Yes. I need to copy the code from BrowserEvent. Interestingly, goog.Events does not distinguish between target and currentTarget. That does not seem very useful: * Target of the event. * @type {Object|undefined} */ this.target = opt_target; /** * Object that had the listener atta

Re: [FlexJS] String.match()

nonsensical. There’s no legitimate reason to use a regex which does nothing. The JS behavior which throws an error makes much more sense, so I’m currently of the opinion that we shouldn’t be fixing this at all. Harbs > On Jul 21, 2017, at 5:13 PM, Alex Harui wrote: > > My email tota

Re: [FlexJS] stopImmediatePropagation

> On Jul 21, 2017, at 5:18 PM, Alex Harui wrote: > > I think other goog code updates currentTarget as needed. They are the > same when no capture or bubbling, IIRC. > > -Alex > > On 7/20/17, 11:52 PM, "Harbs" wrote: > >> Yes. I need to copy

[FlexJS]TileLayout

JS output in ContainerTest. It’s probably worth looking into the rest of those issues as well… Harbs

Re: git commit: [flex-asjs] [refs/heads/feature/browser-event] - goog.Event assumes the getter can be called on the event. Default to the super getter if wrappedEvent is not set (yet).

> Branch: refs/heads/feature/browser-event > Commit: 3b2a8feb763771d6d3e371d89b251068d0cca4fc > Parents: f53e941 > Author: Harbs > Authored: Sun Jul 23 11:36:48 2017 +0300 > Committer: Harbs > Committed: Sun Jul 23 11:36:48 2017 +0300 > >

Re: [FlexJS]TileLayout

youtWithFlexStart, TileLayoutWithStretch, and > TileLayoutWithAlignContent with a property that allows you to set it. > > Peter may remember why he chose "stretch". > > -Alex > > On 7/23/17, 1:28 AM, "Harbs" wrote: > >> I just discovered something which is

Re: [FlexJS] stopImmediatePropagation

21, 2017, at 6:06 PM, Harbs wrote: > > Yes. That seems to be the case: > https://github.com/google/closure-library/blob/608e0eaaa42bb5f041a7f067f254907d47edf7d1/closure/goog/events/eventtarget.js#L371 > > <https://github.com/google/closure-library/blob/608e0eaaa42bb5f041a

[FlexJS]E4X filter functions

words' + keywords + '')); } The work-around is to use “child(‘key)” instead of “key” in the filter, but if this valid use of E4X could be worked out, that would be great. Harbs

[FlexJS] PAYG and dataGroups

his problem? Harbs

Re: [FlexJS] stopImmediatePropagation

Bah! I just discovered another issue with this branch. The goog.BrowserEvent “event_” property is renamed when the code is minified. Without hacking the goog code, using that property is not gonna work… > On Jul 23, 2017, at 1:44 PM, Harbs wrote: > > I feel like I went down the ra

Re: [FlexJS] stopImmediatePropagation

Oh.It seems like there’s an official way to do this: BrowserEvent.prototpye.getBrowserEvent() > On Jul 24, 2017, at 12:34 AM, Harbs wrote: > > Bah! > > I just discovered another issue with this branch. > > The goog.BrowserEvent “event_” property is renamed when

Re: [FlexJS] stopImmediatePropagation

Good. I confirmed that this survives minification. > On Jul 24, 2017, at 12:41 AM, Harbs wrote: > > Oh.It seems like there’s an official way to do this: > BrowserEvent.prototpye.getBrowserEvent() > >> On Jul 24, 2017, at 12:34 AM, Harbs > <mailto:harbs.li...@gm

Re: git commit: [flex-asjs] [refs/heads/feature/browser-event] - goog.Event assumes the getter can be called on the event. Default to the super getter if wrappedEvent is not set (yet).

(this); > On Jul 23, 2017, at 12:25 PM, Alex Harui wrote: > > It may not be a getter in goog.Event and just a var instead. It might be > ok to modify the typedefs to make it a getter. > > HTH, > -Alex > > On 7/23/17, 1:59 AM, "Harbs" <mailto:harbs.li

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

additional eyeballs on this. I did not see any tests for this, and I don’t have the time right now to write one. Thanks, Harbs > On Jul 24, 2017, at 1:29 PM, ha...@apache.org wrote: > > Repository: flex-asjs > Updated Branches: > refs/heads/develop 2458fe559 -> 61ef18b9a > &g

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

Good call. I noticed that I can simplify the code a bit as well. I added this to the other notifier classes too. > On Jul 24, 2017, at 1:37 PM, Piotr Zarzycki wrote: > > Hi Harbs, > > I think this line should be outside "if": > > var object:Object = docume

Re: [FlexJS] PAYG and dataGroups

() has range checking, so there’s no reaosn for the view to do it’s own range checking. A simple null check on the results is enough (which the selected handler was already doing). So better safety with less code. An all-around win. :-) > On Jul 24, 2017, at 10:12 AM, piotrz wrote: > >

Re: [FlexJS] PAYG and dataGroups

I’m not sure what you mean. If you mean braces for single-line statements, I actually use those in my personal projects, but I leave them out in Flex code because that’s alway been the convention in the Flex Framework. Thanks, Harbs > On Jul 24, 2017, at 2:32 PM, piotrz wrote: > >

Re: [FlexJS] PAYG and dataGroups

Framework convention is generally to leave out the braces and indent the line like this: if (ir) ir.selected = true; > On Jul 24, 2017, at 2:54 PM, piotrz wrote: > > I meant this kind of lines somewhere inside method: > > ir = dataGroup.getItemRendererForIndex(listModel.selectedIndex) as > I

Re: [FlexJS]TileLayout

be the default > TileLayout to simplify migration and other options would have longer names. > > No matter what, if SWF and HTML don't currently match, we should fix it so > they do. > > My 2 cents, > -Alex > > On 7/24/17, 7:13 AM, "Peter Ent" wrote: > >>

Re: [FlexJS] MouseEvent

branch for my attempt to make MouseEvents and KeyboardEvents behave the way you’d expect. I’m currently struggling with figuring out how to make artificially created MouseEvents behave properly. Maybe we should compare notes… Harbs > On Jul 25, 2017, at 9:49 PM, Peter Ent wrote: > >

Re: Adobe has announced the end-of-life of the Flash Player

tml/3257d429b573baad48e401e01e4fda5a3ef02557f7640d4c9becd274@%3Cdev.flex.apache.org%3E> Harbs > On Jul 26, 2017, at 8:40 AM, Chris Velevitch > wrote: > > I think it would be great if the flex compiler could generate wasm ( > webassembly.org) binary format output (a W3C standard). That way, we could > benefit from keepin

Re: [FlexJS] End-of-life of the Flash Player

a real lack. Thanks, Harbs > On Jul 26, 2017, at 12:31 PM, Olaf Krueger wrote: > > Hi, > I would like to ask if the FP EOL announcement has any effects on FlexJS?! > Do you think it is still worth to follow the conditional compiling approach > or is it maybe time to > ab

Re: [FlexJS] MouseEvent

well right now and it should address all of these issues. Thanks, Harbs > On Jul 26, 2017, at 12:27 AM, Peter Ent wrote: > > I feel like I'm not grasping some concept. Seems to be that > > a) you would want at least two points in a MouseEvent: the screen position > and the

[FalconJX] Weird issue with override in getter

I just ran into an interesting one: https://issues.apache.org/jira/browse/FLEX-35345

Re: [FlexJS] MouseEvent

x and y properties as opposed to Flash which has only y scrolling. That brings up some implementation questions, but nothing major. > On Jul 26, 2017, at 12:51 PM, Harbs wrote: > > I agree with everything you write. > > I think BrowserEvent was created to just be a proxy to th

Re: [FlexJS] MouseEvent

Sure. No rush. > On Jul 26, 2017, at 4:22 PM, piotrz wrote: > > Harbs, > > Give me some time, cause I wanted to test it before you merge. > > Thanks, > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this messa

Re: [FlexJS] MouseEvent

latest builds of Falcon to use wheel events in MXML at the least.) Thanks, Harbs > On Jul 26, 2017, at 4:22 PM, piotrz wrote: > > Harbs, > > Give me some time, cause I wanted to test it before you merge. > > Thanks, > Piotr > > > > - > Apache Flex PMC

Re: Help with 0.8

I know Yishay changed the version of Java in his FB installation, but I don’t remember the details. Is this helpful? https://www.experts-exchange.com/questions/28699151/how-can-flash-builder-4-X-version-make-use-of-java-8.html

Re: [FlexJS] MouseEvent

It looks like you are missing my commit revert in typedefs. > On Jul 26, 2017, at 9:16 PM, piotrz wrote: > > Harbs, > > My local Maven build is failing and I'm actually not sure why... [1] > > [1] https://paste.apache.org/hHHU > > Piotr > > >

Re: [FlexJS] MouseEvent

amples don't need it, so I'm wondering if wheel support should > be separated out or not. > > Thoughts? > -Alex > > On 7/26/17, 9:27 AM, "Harbs" <mailto:harbs.li...@gmail.com>> wrote: > >> While you’re at it, if you could write a test for

MDL and Material Components Web (was Re: Help with 0.8)

FYI, Material Components Web is the replacement for MDL. It has the advantage of being simpler and ultimately more capable. I’ve been keeping half an eye on it, and it’s getting pretty far along. The roadmap looks very good too.[2] At some point, some ambitious souls might want to make a compon

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

ontent that might overflow, the percentage should be set to 0. It could be there are cases where the entire OnFlexibleLayout should be fit when smaller and expand (and not scroll) when bigger. In that case, the current behavior might be correct. Thoughts? Harbs > On May 23, 2017, at 10:1

<    1   2   3   4   5   6   7   8   9   10   >