[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @upthewaterspout: > Add the final_app and output directories to the rat excludes, so people don't have rat failures after building the docs. Excellent suggestion.

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @metatype 1. Running `bundle install` in the final_app dir isn't something I'm familiar with. We don't usually have to do it, and I'm currently able to build and `rackup`

[GitHub] incubator-geode pull request #259: Feature/geode 1952 2

Github user joeymcallister commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/259#discussion_r83350443 --- Diff: geode-docs/README.md --- @@ -1,93 +1,53 @@ -# Project Geode End-User Documentation +# Apache Geode End-User Documentation

Re: GEODE-1466: geode.properties

Yeah, introducing a new more focused prefix constant just for properties would be better. Sounds like consensus so far though is to just hold off for a fix that refactors DistributionConfigImpl enough to make a good clean change to look for both properties files. -Kirk On Thu, Oct 13, 2016 at

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @upthewaterspout Bookbinder requires the "book" directory to be at the same dir level as the content, so a subdirectory wouldn't work here. If the goal is to clean up the top level,

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user upthewaterspout commented on the issue: https://github.com/apache/incubator-geode/pull/259 I think geode-docs should be a subdirectory of geode-book so we don't have two unrelated directories for these docks. It should probably output to a directory called build

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 I think the README could use a few clarifications: 1) You also need to run `bundle install` in the final_app dir. 2) How do we take the generated html site and merge it into the

[GitHub] incubator-geode pull request #259: Feature/geode 1952 2

Github user upthewaterspout commented on a diff in the pull request: https://github.com/apache/incubator-geode/pull/259#discussion_r83334338 --- Diff: geode-docs/README.md --- @@ -1,93 +1,53 @@ -# Project Geode End-User Documentation +# Apache Geode End-User Documentation

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user karensmolermiller commented on the issue: https://github.com/apache/incubator-geode/pull/259 +1 I built with bookbinder and viewed with rackup, per the README.md instructions. Running `./gradlew rat` passed the license check: no licensing issues. --- If your

[GitHub] incubator-geode pull request #260: Added TemporaryFileRule JUnit rule for te...

GitHub user jaredjstewart opened a pull request: https://github.com/apache/incubator-geode/pull/260 Added TemporaryFileRule JUnit rule for tests that need to create file… …s in a particular directory. You can merge this pull request into a Git repository by running: $ git

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 @sbawaska Commit 2b6fec8 corrects the license issues and I was able to build successfully. --- If your project is set up for it, you can reply to this email and have your reply

Re: GEODE-1466: geode.properties

PROPERTY_FILE_PREFIX ? On Thu, Oct 13, 2016 at 3:05 PM, John Blum wrote: > -1 for introducing this change as well. > > Also -1 for introducing any additional constants/workarounds. Either fix > it the way it should be fixed or do nothing at all. > > On Thu, Oct 13, 2016 at

Re: Starting the server, prompt for username/password

member can provide an auth-init method to get those credentials instead of explicitly specify username/password as well. So you will need to check for that as well. On Thu, Oct 13, 2016 at 3:20 PM, Kevin Duling wrote: > security-username and security-password appear to be

Re: Starting the server, prompt for username/password

security-username and security-password appear to be the properties most commonly set/checked. I could base prompting off of their existence and null value. On Thu, Oct 13, 2016 at 2:55 PM, Kirk Lund wrote: > I think we should avoid using an exception for normal flow control.

Re: GEODE-1466: geode.properties

-1 for introducing this change as well. Also -1 for introducing any additional constants/workarounds. Either fix it the way it should be fixed or do nothing at all. On Thu, Oct 13, 2016 at 2:45 PM, Kirk Lund wrote: > -1 at this point I'm against making this change for 1.0.0

Re: Starting the server, prompt for username/password

I think we should avoid using an exception for normal flow control. I'd provide a link to Ward Cunningham's wiki but his wiki is currently down. There should be a way to determine if the user has credentials before trying to connect. -Kirk On Thu, Oct 13, 2016 at 2:50 PM, Kevin Duling

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user davebarnes97 commented on the issue: https://github.com/apache/incubator-geode/pull/259 +1 Bookbinder publishing procedure worked for me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Starting the server, prompt for username/password

I'm working on GEODE-1959 and the use case goes like this: Create your gemfire.properites with a security manager. For example: > security-manager=org.apache.geode.security.templates.SampleSecurityManage But do not provide a username and

Re: GEODE-1466: geode.properties

-1 at this point I'm against making this change for 1.0.0 I'll still work towards fixing GEODE-1466 properly but it'll be fixed on develop within the next week or so. -Kirk On Thu, Oct 13, 2016 at 2:26 PM, Udo Kohlmeyer wrote: > If such a change is to be introduced..

Re: GEODE-1466: geode.properties

-1 for including any of this in the 1.0 release. Let's get that release out the door! -Dan On Thu, Oct 13, 2016 at 2:26 PM, Udo Kohlmeyer wrote: > If such a change is to be introduced.. maybe we call it `SYSTEM_PREFIX` or > something more generic that we could use within

Re: GEODE-1466: geode.properties

If such a change is to be introduced.. maybe we call it `SYSTEM_PREFIX` or something more generic that we could use within the Geode. Then we could hopefully cover many to most `gemfire` vs `geode` renaming. But I agree with @Anthony, if we aren't 100% certain about a change then we should

Re: GEODE-1466: geode.properties

How about introducing a new GEMFIRE_FILE_PREFIX attribute that will default to "geode" while leaving GEMFIRE_PREFIX default to "gemfire"? Is this something that will work? On Thu, Oct 13, 2016 at 1:48 PM, Anthony Baker wrote: > Hmmm, you would think it would be easier to

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user joeymcallister commented on the issue: https://github.com/apache/incubator-geode/pull/259 `geode-book` is a source directory containing the pieces (e.g., the `config.yml` that points Bookbinder to content, and the `geode-subnav.erb` that provides the book's table of

Re: GEODE-1466: geode.properties

Hmmm, you would think it would be easier to change a file name :-) I don’t think we should be pushing destabilizing changes into a release branch. If the changes aren’t ready now we always pick them up for the next release. Anthony > On Oct 13, 2016, at 1:13 PM, Kirk Lund

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user metatype commented on the issue: https://github.com/apache/incubator-geode/pull/259 Is `geode-book` a generated dir or a source directory? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: [GitHub] incubator-geode issue #259: Feature/geode 1952 2

Hi Swapnil, Yes, I'm working on that right now and will resubmit. Joey On Thu, Oct 13, 2016 at 1:40 PM sbawaska wrote: > Github user sbawaska commented on the issue: > > https://github.com/apache/incubator-geode/pull/259 > > Hi @joeymcallister The CI failed

[GitHub] incubator-geode issue #259: Feature/geode 1952 2

Github user sbawaska commented on the issue: https://github.com/apache/incubator-geode/pull/259 Hi @joeymcallister The CI failed because the new files are missing the Apache License header. Can you please fix this and re-submit the pull request? ``` 71 Unknown Licenses

GEODE-1466: geode.properties

I'm currently working with Jared and we have spent a few days working on GEODE-1466. We've been trying to get geode to the point where it can automatically search for, find and use either geode.properties or gemfire.properties (preferring geode.properties if both are found). We were intending to

Re: Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52836/#review152567 --- Ship it! Ship It! - Udo Kohlmeyer On Oct. 13, 2016, 4:26

Re: Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52836/#review152565 --- Ship it! Ship It! - Bruce Schuchardt On Oct. 13, 2016, 4:26

Re: Build failed in Jenkins: Geode-nightly #621

Thank you, I will add a hook so this doesn’t happen again. - Jared > On Oct 13, 2016, at 10:16 AM, Dan Smith wrote: > > Yet one more reason to run ./gradlew build *before* pushing changes to > develop > > You can automate this by adding a pre-push trigger to your git repo.

Re: Coding practices/standards

I agree that the formatter needs fixing up. Our wiki says that we follow the Google Java Style guide, but that is not actually what’s in our formatter templates. I pushed a new branch

Re: Build failed in Jenkins: Geode-nightly #621

Yet one more reason to run ./gradlew build *before* pushing changes to develop You can automate this by adding a pre-push trigger to your git repo. This will only do the push if the build succeeds: echo "./gradlew build" > .git/hooks/pre-push chmod u+x .git/hooks/pre-push You can do git push

Re: Coding practices/standards

+1 for adding this to ./gradlew build But I think we might want to fix up the formatter a bit before reformatting the code. I tried running spotlessApply, and it did some unfortunate reformatting of code to make it less readable. One problem is with method chaining. We have a few different

Re: Coding practices/standards

Given that, +1 from me! On Thu, Oct 13, 2016 at 9:51 AM, Jared Stewart wrote: > The task is fully suppressible with -x spotlessCheck. Also, if you have > any formatter errors you can automatically fix them with 'gradle > spotlessApply’. > > > On Oct 13, 2016, at 9:40 AM,

Re: Coding practices/standards

The task is fully suppressible with -x spotlessCheck. Also, if you have any formatter errors you can automatically fix them with 'gradle spotlessApply’. > On Oct 13, 2016, at 9:40 AM, Kevin Duling wrote: > > If we made formatting a warning, then people would probably

Re: Review Request 52759: GEODE-1991: Removing sleeps from HARegionQueueJUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52759/#review152525 ---

Re: Coding practices/standards

If we made formatting a warning, then people would probably quickly ignore it. If we made formatting an error, we need to be sure we don't get in to the situation where 's formatter is not in agreement with the build's checker. I can live with an additional 17 seconds as well. And Jared's

Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52836/ --- Review request for geode, Bruce Schuchardt and Udo Kohlmeyer. Repository:

Re: Build failed in Jenkins: Geode-nightly #621

This file was accidentally committed in GEODE-999. Jinmei removed it from develop this morning after we saw the RAT failed last night. I haven’t figured out yet what generated the file in the first place. > On Oct 13, 2016, at 9:04 AM, Anthony Baker wrote: > > Anyone know

Fwd: Build failed in Jenkins: Geode-nightly #621

Anyone know why this file was generated by the build? It shows up in the rat report. !? /home/jenkins/jenkins-slave/workspace/Geode-nightly/artifacts-jstewartgeode999/test/gemfire-jstewartgeode999-files.tgz Anthony > Begin forwarded message: > > From: Apache Jenkins Server

Build failed in Jenkins: Geode-nightly #621

See Changes: [jiliao] GEODE-1986: correctly set the flag indicating if cluster configuration [jiliao] GEODE-1979: refactor SecurityClusterConfig to remove the flakiness. [jiliao] GEODE-999: Converted from Firefox driver to PhantomJS

Re: jVSD

Hello Dor, jVSD doesn't read statistics in runtime from Geode, it only opens and presents statistics stored in files. You need to use GFSH commands to manage and monitor Geode in runtime. Best regards. On Thu, Oct 13, 2016 at 10:54 AM, Dor Ben Dov wrote: > Hi, > > Can

RE: jVSD

Thanks Juan for the quick response. Dor -Original Message- From: Juan José Ramos [mailto:jra...@pivotal.io] Sent: יום ה 13 אוקטובר 2016 17:33 To: dev@geode.incubator.apache.org Subject: Re: jVSD Hello Dor, jVSD doesn't read statistics in runtime from Geode, it only opens and presents

jVSD

Hi, Can one tell me how the data being read by the jVSD on runtime from Geode / Gemfire? Is this above being saved also or exported / can it be saved ? Regards, Dor This message and the information contained herein is proprietary and confidential and subject to the Amdocs policy statement,