Re: [DISCUSS] Graduation

+1 On Tue, Oct 25, 2016 at 5:25 PM, Roman Shaposhnik wrote: > inactive > microsoft.com (Ashvin) > :-(

Re: Review Request 47675: GEODE-1389, GEODE-1012: Cleaning up some persistence tests in LuceneIndexRecoveryHAIntegrationTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47675/#review134211 --- Ship it! Looks good to me. - Ashvin A On May 20, 2016, 10

Re: Review Request 45820: Minor clarity changes for Lucene dunit test

/gemstone/gemfire/cache/lucene/internal/distributed/LuceneFunctionReadPathDUnitTest.java <https://reviews.apache.org/r/45820/#comment190685> My bad. Thanks for fixing this :-) - Ashvin A On April 6, 2016, 5:35 p.m., Jason Huynh

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

queueSize method on AbstractGatewaySender could be added. - Ashvin A On Dec. 17, 2015, 2:43 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 41332: Add CacheObserver for ShutdownAll and also let WAN to return CancelException

/tier/sockets/command/GatewayReceiverCommand.java (line 74) <https://reviews.apache.org/r/41332/#comment170092> This check captures shutdownAll scenario. What if only this cache is closing? - Ashvin A On Dec. 14, 2015, 1:06 a.m., xiaojian zhou

Re: Review Request 41332: Add CacheObserver for ShutdownAll and also let WAN to return CancelException

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41332/#review110276 --- Ship it! Ship It! - Ashvin A On Dec. 14, 2015, 1:06 a.m

Re: Review Request 41058: GEODE-637: Additional tests for AsyncEventQueues

/gemfire/internal/cache/wan/AsyncEventQueueTestBase.java (line 75) <https://reviews.apache.org/r/41058/#comment168703> Do these test classes need to be put in a test category? - Ashvin A On Dec. 7, 2015, 11:24 p.m., Dan Smith

Re: Review Request 40846: GEODE-617: Change xsd namespace for lucene to geode.apache.org

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40846/#review108680 --- Ship it! Ship It! - Ashvin A On Dec. 2, 2015, 12:43 a.m., Dan

Re: Review Request 40516: GEODE-581: LoadProbe that balances based on bucket count

de. It will work as there is only one load probe per cache. So all buckets (across regions) will be compared uniformly. - Ashvin A On Nov. 20, 2015, 12:57 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail.

Re: Apache Geode & Yarn

Hi Sandesh, If I remember correctly, Geode on YARN has not been tried yet. It sure sounds interesting and useful. If you are thinking of using this, could you please provide additional details and share your use case. Thanks, Ashvin On Tue, Nov 17, 2015 at 11:15 AM, Sandesh Hegde wrote: > Hel

Re: Review Request 40272: GEODE-546: Resetting stats when AbstractGatewaySender is stopped

/gemfire/cache/asyncqueue/internal/SerialAsyncEventQueueImplJUnitTest.java (line 15) <https://reviews.apache.org/r/40272/#comment165195> Should this test be categorized as IntegrationTest? - Ashvin A On Nov. 13, 2015, 1:45 a.m., Dan Smith

Is Geode-nightly stuck?

Hi, It seems build #276 has been executing for 1 day 14 hr now. https://builds.apache.org/job/Geode-nightly/276/ -ashvin

Merge Text/Lucene search branch into develop

Hi, As part of GEODE-11, we added ability to create Lucene indexes and execute text search queries on GEODE Regions. Currently, we have implemented the core classes and a basic end-to-end flow. We think it is a good time to introduce this feature to the community and let the use cases drive future

Re: Review Request 40097: Merge GEODE-11 into develop

gemfire-lucene/src/test/resources/com/gemstone/gemfire/cache/lucene/internal/xml/LuceneIndexXmlParserIntegrationJUnitTest.parseIndex.cache.xml PRE-CREATION settings.gradle 5cc0e30 Diff: https://reviews.apache.org/r/40097/diff/ Testing --- Thanks, Ashvin A

Review Request 40097: Merge GEODE-11 into develop

) - Merge GEODE-11 into develop Repository: geode Description (updated) --- These changes will be committed on develop when GEODE-11 is merged Diffs - Diff: https://reviews.apache.org/r/40097/diff/ Testing --- Thanks, Ashvin A

Review Request 40096: GEODE-11: Mark Lucene API as experimental

94931a4c879d1643bcdec6826173e155016a32f9 Diff: https://reviews.apache.org/r/40096/diff/ Testing --- Thanks, Ashvin A

Review Request 40095: GEODE-11: ADD Apache License header

/LuceneIndexXmlParserJUnitTest.java ff271ddb389ce46af107cfe9450f5958bb2476de Diff: https://reviews.apache.org/r/40095/diff/ Testing --- Thanks, Ashvin A

Review Request 40094: GEODE-11: Move Lucene dependency version info to versions file

--- See commit dc5d343 or GEODE 227 for additional details. Diffs - gemfire-lucene/build.gradle 3303a6931b8e52e8155dd76b9385ea78144d63c5 gradle/dependency-versions.properties PRE-CREATION Diff: https://reviews.apache.org/r/40094/diff/ Testing --- Thanks, Ashvin A

Re: Delete feature/GEODE-409?

AM, Darrel Schneider < > dschnei...@pivotal.io > > > > > > wrote: > > > > > > > +1 > > > > > > > > On Thu, Nov 5, 2015 at 11:24 AM, Ashvin A wrote: > > > > > > > > > Hi, > > > > > > > &g

Delete feature/GEODE-409?

Hi, Branch 'feature/GEODE-409' was merged into develop 2 days ago. I fixed a failing test and committed the change on feature/409 after the merge. It should have been committed on develop instead. I will need to merge the branch again. I am thinking we should delete feature/409 as we are not worki

Re: Review Request 39956: GEODE-526: Fix oplog unit test race condition

------ On Nov. 4, 2015, 9:58 p.m., Ashvin A wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39956/ > --

Review Request 39956: GEODE-526: Fix oplog unit test race condition

f0b33f1622f9c2cb094458759bdebe5756b2df29 gemfire-core/src/test/java/com/gemstone/gemfire/internal/cache/OplogJUnitTest.java 1fc39bfb873d1b5e91a01316ba12b1a6b786dbda Diff: https://reviews.apache.org/r/39956/diff/ Testing --- Thanks, Ashvin A

Re: JIRA Resolved vs Closed

+1 Using Closed state for change log makes sense. Will the release manager make the transition from Resolved to Closed state after a release? Thanks, Ashvin On Mon, Nov 2, 2015 at 2:19 PM, Anthony Baker wrote: > Echoing the logic: > > http://mail-archives.apache.org/mod_mbox/db-jdo-dev/200605.

Review Request 39765: GEODE-454: Fix HAInterestPart1DUnitTest by adding expected exceptions

/tier/sockets/HAInterestPart1DUnitTest.java ba6e30f666c4d67d9c6a359da924d39c9d59a139 Diff: https://reviews.apache.org/r/39765/diff/ Testing --- Thanks, Ashvin A

Re: Review Request 39726: GEODE-504 - Removing MaxPermSize parameter

726/#comment162576> Do we need to replace PermSize limit with Metaspace limit? I am not sure if limiting Metaspace is a good idea or not. - Ashvin A On Oct. 28, 2015, 6:19 p.m., William Markito wrote: > > --- > This is a

Review Request 39485: GEODE-429: Disable creation of hdfs regions

://reviews.apache.org/r/39485/diff/ Testing --- Thanks, Ashvin A

Re: Review Request 39329: Requiring lucene index to be created before the region

ionListeners will always perform this check. Would it be better if the listener could be added to a regionPath itself? That ways listener will be invoked incase of a match only? - Ashvin A On Oct. 14, 2015, 9:21 p.m., Dan Smith wrote: > > --

Review Request 39159: Fix index recovery after rebalance

renames checkpoint file. The fileSystem was updating the file object but not updating it in the fileRegion. Hence the updates were getting lost. On recovery path, empty file was causing failures. GEODE-11: Fix index recovery after rebalance Thanks, Ashvin A

Re: Review Request 39020: GEODE-244: Fixing race in testRecoverRedundancyWithOfflinePersistenceSimulation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39020/#review101537 --- Ship it! Ship It! - Ashvin A On Oct. 5, 2015, 9:40 p.m., Dan

Re: Review Request 38647: Changing how PartitionRepositoryManager handles destroyed buckets

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38647/#review100073 --- Ship it! Ship It! - Ashvin A On Sept. 22, 2015, 9:30 p.m., Dan

Review Request 38581: Make text function related objects serializable

, Ashvin A

Review Request 38513: GEODE-11: Add LuceneQueryProvider

Diff: https://reviews.apache.org/r/38513/diff/ Testing --- Thanks, Ashvin A

Re: Apache Geode is....

Hi Greg, I pretty much like the short description you provided. I would like to add "high concurrency" in the mix for completeness. Which would make it (22+2) < 25 words. Apache Geode is a distributed, in-memory data grid and integrated messaging queue built to support low latency *high concurren

Review Request 38320: Search Function ResultCollector

--- Thanks, Ashvin A

Re: Releasing Geode (was Re: September 2015 Report)

hanks Roman and Greg for the opportunity/ challenge! Happy to help > with > >> the initial release if the group agrees to it, and with your guidance/ > >> support, of course. > >>> When do we start!? > >>> Best, > >>> Nitin > >>>

Re: Releasing Geode (was Re: September 2015 Report)

http://www.apache.org/dev/release-publishing.html#release_manager *"The common practice at Apache is for a single individual to take responsibility for the mechanics of a release. That individual is called the 'release manager.' Release managers take care of shepherding a release from an ini

Re: Releasing Geode (was Re: September 2015 Report)

+1 to both suggestions; alpha-1 release and Jira for tracking this release. Thanks, Ashvin On Mon, Sep 7, 2015 at 12:39 PM, Anthony Baker wrote: > As Justin mentioned, we need to make progress towards our first Geode > release. If we define that initial release as an alpha-quality artifact > t

Re: Review Request 37970: Making binary keys work properly with the lucene index

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37970/#review97364 --- Ship it! Ship It! - Ashvin A On Aug. 31, 2015, 10:01 p.m., Dan

Re: Review Request 37822: Adding an AsyncEventListener to write events to Lucene

elated to key and not to remove all documents containing the term. - Ashvin A On Aug. 27, 2015, 12:13 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 37720: Lucene: GEODE-11-Add-a-basic-score-based-aggregator

; Is is possible to lose a document if two keys have the same hash code? > > If so, this risks losing a doc. If not, why include this hashcode > > comparison? Probably better to leave it out and just test adding docs with > > duplicate scores. I believe priority queue

Re: Review Request 37720: Lucene: GEODE-11-Add-a-basic-score-based-aggregator

ny doc. I will add a test for duplicate keys for coverage. Thanks ! - Ashvin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37720/#review96205 --------

Review Request 37720: Lucene: GEODE-11-Add-a-basic-score-based-aggregator

-CREATION Diff: https://reviews.apache.org/r/37720/diff/ Testing --- Thanks, Ashvin A

There was no nightly build yesterday?

Hi, I was expecting to see build 191 results today morning. It seems the nightly build did not happen or is stuck. There is no build mail or build activity on https://builds.apache.org/job/Geode-nightly/. Anyone knows more about it? Thank you, Ashvin

Can GEODE-63 (Establish Contribution workflow) be closed?

Hi, I am going through some of the unassigned issues (50 as of now). One of the issue is related to contribution process, GEODE-63. I am trying to understand the pending actions for this issue. Or if all the actions are completed, can we close the issue? Thank you, Ashvin

Re: Review Request 37598: GEODE-229: Fixed javadoc for DiskStoreFactory.setCompactionThreshold

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37598/#review95884 --- Ship it! Ship It! - Ashvin A On Aug. 19, 2015, 1:01 a.m., Dan

Re: Review Request 37619: GEODE-228: fix intermittent failures in NanoTimer tests

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37619/#review95878 --- Ship it! Ship It! - Ashvin A On Aug. 19, 2015, 6:35 p.m

Investigate test failures: Build 189

Hi, The latest nightly build is reporting 4 test failures. These tests do not fail when I run them locally. Based on a quick search it also seems these tests failed for the first time and are not related to recent code changes. 1. c.g.g.i.c.ClientServerTransactionDUnitTest.testClientCommitFunc

Re: Review Request 36662: GEODE-124: Auto Rebalancer

/main/java/com/gemstone/gemfire/cache/util/AutoBalancer.java PRE-CREATION gemfire-rebalancer/src/test/java/com/gemstone/gemfire/cache/util/AutoBalancerJUnitTest.java PRE-CREATION settings.gradle 7f6ed61 Diff: https://reviews.apache.org/r/36662/diff/ Testing --- Thanks, Ashvin A

Re: Review Request 36662: GEODE-124: Auto Rebalancer

://reviews.apache.org/r/36662/diff/ Testing --- Thanks, Ashvin A

Re: Review Request 36694: Re-introduce 4 dunit tests that were exclude earlier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36694/#review92601 --- Ship it! Ship It! - Ashvin A On July 22, 2015, 4:02 p.m., Amogh

Re: Review Request 36397: HdfsStore API refactoring

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36397/#review91467 ------- On July 10, 2015, 8:45 p.m., Ashvin A wrote: > > -

Re: Review Request 36397: HdfsStore API refactoring

javadoc. - Ashvin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36397/#review91345 --- On July 10, 2015, 8:45

Re: Review Request 36397: HdfsStore API refactoring

spatcher threads. Do you see any issues / differences? > On July 13, 2015, 6:25 p.m., Darrel Schneider wrote: > > gemfire-core/src/main/java/com/gemstone/gemfire/cache/hdfs/HDFSStore.java, > > line 261 > > <https://reviews.apache.org/r/36397/diff/1/?file=1008296#file1008296li

Re: Nightly build test failures

Seems builds fails on ubuntu hosts :-? Build ↑ Duration Slave

Re: Review Request 36397: HdfsStore API refactoring

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36397/#review91485 ------- On July 10, 2015, 8:45 p.m., Ashvin A wrote: > > ---

Review Request 36397: HdfsStore API refactoring

mfire/management/internal/cli/functions/CreateHDFSStoreFunctionJUnitTest.java a20297b gemfire-core/src/test/java/com/gemstone/gemfire/management/internal/cli/functions/DescribeHDFSStoreFunctionJUnitTest.java fe630fe Diff: https://reviews.apache.org/r/36397/diff/ Testing --- Thanks, Ashvin A

LogMarker guidelines

Hi, I can use log4j configuration to change log levels by specific packages and classes. I noticed sizable usable of LogMarkers in the code for additional filtering. I guess markers are used for cases beyond trace level logging and across package boundaries. I was wondering if their are any guidel

Re: geode contribution process proposal

Hi, We need a fast verification method for testing any changes, I agree. I think test categories/groups is a step in the correct direction. Then as a developer, I can quickly verify my changes at the module level. As Kirk said, we will invest in writing new tests and also identifying and fixing te

Re: [VOTE] Grandfathering forgotten Geode contributors

Should Mak (Makarand) be part of this list? On Jun 9, 2015 10:51 PM, "Anthony Baker" wrote: > Sounds like a reasonable approach to me. > > Anthony > > > On Jun 9, 2015, at 9:33 PM, William A Rowe Jr > wrote: > > > > On Tue, Jun 9, 2015 at 7:18 PM, Roman Shaposhnik > > wrote: > > > >> Hi! > >> >

Re: Our JIRA is fully functional now

jira id: ashvin Ashvin Agrawal On Wed, May 6, 2015 at 9:35 AM, Dick Cavender wrote: > dcavender > > > On 5/5/2015 4:35 PM, Roman Shaposhnik wrote: > >> https://issues.apache.org/jira/browse/GEODE-1 >> >> Please make sure to register accounts there >> and reply back to this thread with your IDs

Verify impact of a pull request

Hi, We are working on finalizing the dev process and I may be jumping on this question sooner. If so, please ignore my mail. I saw a couple of pull requests today. As a committer, how will I know if the contributor has executed all the unit tests and the patch is well tested? Will the infrastruct