Review Request 53743: CI Failure: GMSHealthMonitorJUnitTest.testHMNextNeighborAfterTimeout

2016-11-14 Thread Bruce Schuchardt
che.org/r/53743/diff/ Testing --- Thousands of runs of the test, which only takes 1 second to execute. I also ran the whole set of tests in this class over 200 times. Thanks, Bruce Schuchardt

Re: GMSJoinLeaveJUnitTest format is broken?

2016-11-14 Thread Bruce Schuchardt
This is fixed now. I will not apologize for breaking the build though. I formatted the code that I checked in with the provided formatter configuration for Idea and that should pass the spotlessCheck task. We should turn off spotlessCheck until the IDE formatters conform to the

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Bruce Schuchardt
e-core/src/test/java/org/apache/geode/cache30/ClientServerCCEDUnitTest.java 7cf632f850098c178d4cf23bf116292d89220738 Diff: https://reviews.apache.org/r/53652/diff/ Testing --- New unit test, precheckin Thanks, Bruce Schuchardt

Re: Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53652/#review155638 --- On Nov. 10, 2016, 4:47 p.m., Bruce Schuchardt

Review Request 53652: GEODE-2089 entry-idle-time setting on the client side cache is not working as expected

2016-11-10 Thread Bruce Schuchardt
Testing --- New unit test, precheckin Thanks, Bruce Schuchardt

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-09 Thread Bruce Schuchardt
So, no I don't agree with putting it in PdxInstanceImpl. - Bruce --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155238 ---------

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-08 Thread Bruce Schuchardt
ou leave it with > > just a simple equals check you should document that in the case of pdx the > > value-constraint needs to exactly match (i.e. no instanceof support). > > Bruce Schuchardt wrote: > In the case of Rest objects there are no classes to perform this kin

Re: Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-08 Thread Bruce Schuchardt
--------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53557/#review155241 --- On Nov. 7, 2016, 10:13 p.m., Bruce Schuchardt wrote: > > -

Review Request 53557: GEODE-2080 Rest POST put call not working with region valueConstrain

2016-11-07 Thread Bruce Schuchardt
9a9680a7e14ddec91f005fa0f0c6c3da8d033df2 Diff: https://reviews.apache.org/r/53557/diff/ Testing --- new test, precheckin Thanks, Bruce Schuchardt

Re: more spotless problems on Windows

2016-11-04 Thread Bruce Schuchardt
, at 12:07 PM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: Udo and I tried that & it didn't work. Maybe you'll have better luck. Le 11/4/2016 à 11:59 AM, Jared Stewart a écrit : From the spotless devs: Git is not a pure content store, it mucks with line endings. Regardless of

Re: more spotless problems on Windows

2016-11-04 Thread Bruce Schuchardt
we seriously have to look at using .gitattributes for this... As I initially said, it should be a no brainer.. it should just automatically just work. --Udo On 4/11/16 9:00 am, Bruce Schuchardt wrote: It's been working on my Windows 7 machine under a cygwin shell. I just ran it again using &q

Re: more spotless problems on Windows

2016-11-03 Thread Bruce Schuchardt
formatting error on each file. In my opinion the issue still exists. It will be awesome if someone else can verify if the issue still exists by running the build steps on a different windows machine. Regards Nabarun On Mon, Oct 24, 2016 at 3:50 PM Bruce Schuchardt <bschucha...@pivo

Re: Review Request 53410: GEODE-2064 Added check for system shutdown while handlling connect exception.

2016-11-03 Thread Bruce Schuchardt
run splitBrain/splitBrain.bt and splitBrain/networkPartition3Hosts.bt - Bruce Schuchardt On Nov. 2, 2016, 11:41 p.m., anilkumar gingade wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: PMC nomination

2016-11-02 Thread Bruce Schuchardt
Great - thanks Greg Le 11/2/2016 à 11:31 AM, Gregory Chase a écrit : I saw your post to @private. On Wed, Nov 2, 2016 at 11:27 AM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: I've been trying to join the private email list all morning & self-nominate for the PMC if it's not too late

PMC nomination

2016-11-02 Thread Bruce Schuchardt
I've been trying to join the private email list all morning & self-nominate for the PMC if it's not too late

Review Request 53388: GEODE-2059 client SSL handshake attempts do not time out

2016-11-02 Thread Bruce Schuchardt
/test/java/org/apache/geode/internal/net/SSLSocketIntegrationTest.java d5a947cf40295328039159df2b5af5292cef724c Diff: https://reviews.apache.org/r/53388/diff/ Testing --- precheckin, new unit test Thanks, Bruce Schuchardt

Re: Review Request 53360: GEODE-2050 Remove doc of statistics no longer present

2016-11-02 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53360/#review154565 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 1, 2016, 11:55

Re: Review Request 53331: GEODE-2047 Document change to enable-network-partition-detection

2016-11-01 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53331/#review154423 --- Ship it! Ship It! - Bruce Schuchardt On Nov. 1, 2016, 4:02

Re: Fwd: Build failed in Jenkins: Geode-nightly #636

2016-10-28 Thread Bruce Schuchardt
Someone should look into this test and the previously run Auth tests to see what caused this OOME org.apache.geode.internal.statistics.DiskSpaceLimitIntegrationTest.sameKeepsOneFile

Re: CI failures due to JMX client heartbeat thread

2016-10-27 Thread Bruce Schuchardt
:03.891 PDT tid=0x18d] (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -Dan On Wed, Oct 26, 2016 at 4:50 PM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: We have 23 CI failure tickets concerning suspect strings from "JMX client heartbeat"

Re: CI failures due to JMX client heartbeat thread

2016-10-27 Thread Bruce Schuchardt
a couple of these bugs, these are fatal level errors. Do you know what is causing them or what affect this might have? [fatal 2016/09/29 12:12:03.891 PDT tid=0x18d] (tid=397 msgId=39) No longer connected to cc6-co6.gemstone.com[27162]. -Dan On Wed, Oct 26, 2016 at 4:50 PM, Bruce Schuchardt <bsc

CI failures due to JMX client heartbeat thread

2016-10-26 Thread Bruce Schuchardt
We have 23 CI failure tickets concerning suspect strings from "JMX client heartbeat" threads. I think we should add this to ExpectedStrings.java and close these tickets. The suspect strings are coming from javax.management.remote.rmi.RMIConnector and I don't think there's anything we can do

Review Request 53199: GEODE-2000 ClientMemberShipListener at client should see server-bind-address in event memberId

2016-10-26 Thread Bruce Schuchardt
/UniversalMembershipListenerAdapterDUnitTest.java 019bd0f2acc76e2cffec342868f221bdf55b431c geode-core/src/test/java/org/apache/geode/test/fake/Fakes.java aaf3e281c7fba82f2ab437122af66373ce967494 Diff: https://reviews.apache.org/r/53199/diff/ Testing --- precheckin, new unit test Thanks, Bruce

Re: [DISCUSS] Graduation

2016-10-26 Thread Bruce Schuchardt
+1 Le 10/25/2016 à 5:25 PM, Roman Shaposhnik a écrit : Hi! with the 1.0.0-incubating release officially out (huge kudos to the team!) I think it is time we officially start our graduation discussion. Process-wise graduation consists of drafting a board resolution, getting it approved by the

Re: more spotless problems on Windows

2016-10-24 Thread Bruce Schuchardt
tFile > "${rootProject.projectDir}/etc/eclipse-java-google-style.xml" > > > On Mon, Oct 24, 2016 at 2:50 PM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > > > Running geode-core:spotlessCheck complains that all of the .java files > > have f

more spotless problems on Windows

2016-10-24 Thread Bruce Schuchardt
Running geode-core:spotlessCheck complains that all of the .java files have format violations * What went wrong: Execution failed for task ':geode-core:spotlessJavaCheck'. > Format violations were found. Run 'gradlew spotlessApply' to fix them.

Re: Coding practices/standards

2016-10-24 Thread Bruce Schuchardt
ri, Oct 21, 2016 at 9:03 AM, Kenneth Howe <kh...@pivotal.io> wrote: +1 On Oct 21, 2016, at 8:27 AM, Bruce Schuchardt < bschucha...@pivotal.io> wrote: +1 Le 10/20/2016 à 5:13 PM, Udo Kohlmeyer a écrit : +1 On 20/10/16 4:56 pm, Mark Bretl wrote: +1 as well... - Pulled chan

Re: Review Request 53094: GEODE-706 race condition between expiry thread and other user thread.

2016-10-21 Thread Bruce Schuchardt
That's a better comment. You should replace the one you have with it. Le 10/21/2016 à 4:03 PM, Hitesh Khamesra a écrit : This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53094/ On October 21st, 2016, 10:36 p.m. UTC, *Bruce Schuchardt* wrote

Re: Review Request 53094: GEODE-706 race condition between expiry thread and other user thread.

2016-10-21 Thread Bruce Schuchardt
/AbstractRegionMap.java (line 1516) <https://reviews.apache.org/r/53094/#comment223014> I don't understand this comment. There doesn't seem to be a check for concurrency-checks being enabled & you've removed the check for a tombstone. - Bruce Schuchardt On Oct. 21, 2016, 6:41 p.

Re: Review Request 53092: GEODE-2011 Client clears pdx registry needs synchronization

2016-10-21 Thread Bruce Schuchardt
? PdxClientServerDUnitTest.testNonPersistentServerRestartAutoSerializer ran into the problem but seems to be marked Flaky. Can you modify that test to always hit the problem and remove the Flaky label? - Bruce Schuchardt On Oct. 21, 2016, 6:52 p.m., Hitesh Khamesra wrote

Re: Coding practices/standards

2016-10-21 Thread Bruce Schuchardt
o make one large commit to format all existing code before turning this on. Mark - Thank you for the information about the existing setup. Mark, Darrel, Kevin - Given all of your comments, I think it might make more sense to add the flag to enable it in Travis CI rather than as part of

Re: Removal of nonSingleHopCount stat from client

2016-10-19 Thread Bruce Schuchardt
+1 for removing it It's redundant, we've rarely used client statistics and I hear that people generally have stats turned off in clients anyway. Le 10/19/2016 à 12:55 PM, Udo Kohlmeyer a écrit : Hi there Guys, I've created https://issues.apache.org/jira/browse/GEODE-2017 to track the

Review Request 53034: GEODE-1927 backward compatibility support

2016-10-19 Thread Bruce Schuchardt
://reviews.apache.org/r/53034/diff/ Testing --- Thanks, Bruce Schuchardt

Review Request 53001: GEODE-1927: more protection from seeing com.gemstone.gemfire packaged objects

2016-10-18 Thread Bruce Schuchardt
Thanks, Bruce Schuchardt

Re: Review Request 52933: GEODE-1874: setNextNeighbor method allocates a HashSet on every p2p message received

2016-10-17 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52933/#review152910 --- Ship it! Ship It! - Bruce Schuchardt On Oct. 17, 2016, 5:18

Re: Review Request 52896: GEODE-706 Fixed race condition between expiry thread and put thread.

2016-10-17 Thread Bruce Schuchardt
/LocalRegion.java (line 8721) <https://reviews.apache.org/r/52896/#comment222071> It would be a lot better to have two different methods, one that takes an expiryTask parameter and another that doesn't. - Bruce Schuchardt On Oct. 14, 2016, 9:05 p.m., Hitesh Khamesra

Re: Coding practices/standards

2016-10-14 Thread Bruce Schuchardt
all code would already be formatted, there would no longer be any reformatting commits except for single large commits when the code style file was updated. On Oct 12, 2016, at 11:01 AM, Bruce Schuchardt < bschucha...@pivotal.io wrote: I like the idea of doing this but I don't th

Re: Review Request 52836: GEODE-2000 ClientMemberShipListener at client should return hostname on which cacheserver is listening(i.e. server-bind-address)

2016-10-13 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52836/#review152565 --- Ship it! Ship It! - Bruce Schuchardt On Oct. 13, 2016, 4:26

Re: Coding practices/standards

2016-10-12 Thread Bruce Schuchardt
I like the idea of doing this but I don't think Checkstyle should be enabled until all of the code is reformatted. Also, last time I checked there was still a problem with the IntelliJ auto-format settings. It still used wildcard imports, which I believe we don't allow. I've manually

Re: Deprecate DynamicRegionFactory

2016-10-12 Thread Bruce Schuchardt
+1 Le 10/12/2016 à 6:36 AM, Jens Deppe a écrit : +1 to remove it On Tue, Oct 11, 2016 at 9:33 PM, John Blum wrote: +1 - forget deprecated; delete it. On Tue, Oct 11, 2016 at 8:22 PM, Udo Kohlmeyer wrote: +1 - I see no real benefit for this. On

Re: Review Request 52641: GEODE-1914 removed old versions of dtds

2016-10-07 Thread Bruce Schuchardt
ache.xml (line 19) <https://reviews.apache.org/r/52641/#comment220401> This should be 7.0//EN geode-spark-connector/geode-spark-connector/src/it/resources/test-regions.xml (line 20) <https://reviews.apache.org/r/52641/#comment220402> This should be 7.0//EN geode-spark-connec

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Bruce Schuchardt
l need to provide the creds as part of the pull. Are you instead using dist.gemstone.com for the older jars which is the original repo that lives in the spring s3 repo On 10/6/2016 7:48 AM, Bruce Schuchardt wrote: Thanks Anthony. I thought there was some interest in supporting old GemFire c

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Bruce Schuchardt
. Are you instead using dist.gemstone.com for the older jars which is the original repo that lives in the spring s3 repo On 10/6/2016 7:48 AM, Bruce Schuchardt wrote: Thanks Anthony. I thought there was some interest in supporting old GemFire clients and WAN. Is there no way to download

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-06 Thread Bruce Schuchardt
would need to be explored as well. How would you feel about testing backwards compatibility against 1.0.0-incubating.M3? Anthony [1] http://commercial-repo.pivotal.io On Oct 5, 2016, at 4:17 PM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: We now have a backward-compatibility

backward compatibility testing against GemFire 8.x WAN/clients

2016-10-05 Thread Bruce Schuchardt
We now have a backward-compatibility module but it's not well tested. I'd like to add tests to this module that run against GemFire jars downloaded from the Pivotal maven repository. I've already implemented the framework and some smoke tests but want to know how people feel about the tests

Re: Review Request 52271: GEODE-1938: Big Snapshot File Read Exception via SnapshotReader API

2016-10-05 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52271/#review151541 --- Ship it! Ship It! - Bruce Schuchardt On Oct. 5, 2016, 12:36

Review Request 52524: GEODE-1927 backward compatibility support

2016-10-04 Thread Bruce Schuchardt
://reviews.apache.org/r/52524/diff/ Testing --- Integration tests (pending checkin) Thanks, Bruce Schuchardt

Re: Review Request 52363: GEODE-1947: Renaming SSL_HTTP_SERVICE_REQUIRE_AUTHENTICATION to SSL_WEB_SERVICE_REQUIRE_AUTHENTICATION

2016-09-28 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52363/#review150757 --- Ship it! Ship It! - Bruce Schuchardt On Sept. 28, 2016, 7

Re: security properties in the cluster config

2016-09-28 Thread Bruce Schuchardt
pecify those properties in your normal > properties file. > > On Tue, Sep 27, 2016 at 4:47 PM, Bruce Schuchardt <bschucha...@pivotal.io> > wrote: > > > Isn't cluster-configuration optional? If I restart a locator and it > > doesn't have a persistent cluster configura

support for old clients

2016-09-23 Thread Bruce Schuchardt
I'm creating a new subproject for supporting old GemFire clients and WAN sites and need a name for it. All of the current ones are prefixed with "geode-". How about geode-gemfire-support?

Re: security properties in the cluster config

2016-09-23 Thread Bruce Schuchardt
SSL settings and the new UDP dhAlgo setting can't be in the cluster config. The cluster config is received over TCP/IP so you would have to use unsecured information to retrieve the settings, and you'd have to do it before the cache is created. Does the security-manager have any role to play

Review Request 52172: GEODE-1927: add support for old GemFire remote sites (WAN)

2016-09-22 Thread Bruce Schuchardt
/ Testing --- precheckin. New tests are being developed for gemfire<->geode WAN and client/server interactions but these won't be part of the Geode repo. Thanks, Bruce Schuchardt

Re: Error loading cluster config serialized prior to repackage

2016-09-20 Thread Bruce Schuchardt
The repackage broke those two methods. The oldPackage needs to replace "org.apache" with "com.gemstone". It allows interaction with a locator from WAN sites and clients running GemFire. I'll fix that problem. Le 9/20/2016 à 11:53 AM, Kirk Lund a écrit : If current develop attempts to read

Re: Review Request 51666: GEODE-1729: Configuration consistency in SSL configuration

2016-09-06 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51666/#review147918 --- Ship it! Ship It! - Bruce Schuchardt On Sept. 6, 2016, 8:43

Re: Nightly Build still failing with BindExceptions

2016-09-06 Thread Bruce Schuchardt
This test is not using AvailablePort. There are two test cases in this class that alway use port . Le 9/6/2016 à 8:00 AM, Anthony Baker a écrit : How could we fix AvailablePort so we don’t try to use in-use ports? Anthony On Sep 3, 2016, at 10:29 PM, Kirk Lund wrote:

please close your submitted and discarded RB reviews

2016-08-26 Thread Bruce Schuchardt
My dashboard has 105 items from other engineers on it and I know they're mostly old reviews that are no longer needed. It just takes a minute to close them. Go to the dashboard, click on "Outgoing - Open" to bring up your reviews. Click on the check-boxes of the ones you're done with and

Re: Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

2016-08-26 Thread Bruce Schuchardt
/internal/ClientPartitionAdvisor.java (line 120) <https://reviews.apache.org/r/51461/#comment213915> I'm going to change this to use the new "random" instance variable. - Bruce Schuchardt On Aug. 26, 2016, 4:21 p.m., Bruce

Review Request 51461: GEODE-1803 Inefficient code in ClientMetadataService.getServerToFilterMap()

2016-08-26 Thread Bruce Schuchardt
d3b0cf3204b2d295b362544425a3f08a83090974 Diff: https://reviews.apache.org/r/51461/diff/ Testing --- precheckin Thanks, Bruce Schuchardt

Re: Review Request 51394: GEODE-1372 Geode UDP communications are not secure when SSL is configured

2016-08-24 Thread Bruce Schuchardt
ne/gemfire/distributed/internal/membership/gms/messenger/JGroupsMessenger.java (line 898) <https://reviews.apache.org/r/51394/#comment213336> It would be a lot nicer and somewhat faster to add an interface like Messag

Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Bruce Schuchardt
> On Aug. 24, 2016, 8:27 p.m., Bruce Schuchardt wrote: > > While it's okay to synchronize like that in checkExistingCache() I think it > > might be more appropriate to synchronize on CacheFactory.class in > > basicCreate() and fold the checkExistingClass() method into t

Re: Review Request 51385: GEODE-900 test endup uding old cache

2016-08-24 Thread Bruce Schuchardt
() outside of synchronization. It used to be that there was only one path to basicCreate() and that method synchronized on CacheFactory.class, but now there appear to be other paths to it, like client-cache creation, that don't synchronize. - Bruce Schuchardt On Aug. 24, 2016, 6:30 p.m., Hites

Re: Review Request 51340: Added vmkind field in InterbalDistributedMember' wrtieEssentialData/readEssentialData method

2016-08-23 Thread Bruce Schuchardt
by JGroupsMessenger if it can't find a corresponding ID in the membership views? Either that or get rid of the assertion in InternalDistributedMember. Adding an extra byte to every message transmitted seems like a big price to pay just to avoid this assertion failure. - Bruce Schuchardt On Aug

Re: Review Request 51340: Added vmkind field in InterbalDistributedMember' wrtieEssentialData/readEssentialData method

2016-08-23 Thread Bruce Schuchardt
. - Bruce Schuchardt On Aug. 23, 2016, 4:25 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 51227: GEODE-420: Locator SSL

2016-08-19 Thread Bruce Schuchardt
avoid confusion they should all point to your new properties. See SERVER_SSL_CIPHERS, for instance. ReviewBoard has really made a mess of your diffs. There are also a large number of formatting changes to wade through. Can you do a walkthrough for us? - Bruce Schuchardt On Aug. 18, 2016, 11:

Re: Review Request 51208: GEODE-1761 Clients don't fail back when servers are bounced

2016-08-18 Thread Bruce Schuchardt
/internal/ClientMetadataService.java (line 625) <https://reviews.apache.org/r/51208/#comment212466> I'm missing a statistics update here - I'll add it. - Bruce Schuchardt On Aug. 18, 2016, 3:54 p.m., Bruce Schuchardt

Re: git commit messages

2016-08-18 Thread Bruce Schuchardt
I've found that a lot of CI failure JIRA titles don't conform to the width limit, and I like to use those in my commit message title. Otherwise I have no problem with this. Le jeudi 18 août 2016, Kenneth Howe a écrit : > +1 to Kirk’s proposal > > > On Aug 17, 2016, at 6:09

Re: Flaky tests failing with BindException

2016-08-17 Thread Bruce Schuchardt
ver Caused by: java.net.BindException: Failed to create server socket on null[60,026] Caused by: java.net.BindException: Address already in use 193 tests completed, 1 failed, 6 skipped On Thu, Aug 4, 2016 at 10:38 AM, Bruce Schuchardt <bs

IntelliJ project dependencies

2016-08-16 Thread Bruce Schuchardt
Has something changed in project dependencies recently? I rebuilt my IntelliJ project last Friday and found that there were missing dependencies that broke my build. The modules geode-web_test, geode-cq_test, geode-lucene_test, etc, did not have a dependency on geode-core_test. That gave

Re: Revised SSL properties failure scenario advice.

2016-08-10 Thread Bruce Schuchardt
+1 for ssl-default-alias and failing Le 8/10/2016 à 3:36 PM, Udo Kohlmeyer a écrit : Hi there guys, As per the proposal for the revision of the SSL configuration , I'm nearing the completion of this feature. What I

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-08-10 Thread Bruce Schuchardt
in JoinLeave to NetMember so that we don't tie this interface to the implementation classes. Fix it, then ship it! - Bruce Schuchardt On Aug. 10, 2016, 9:25 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generat

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-08-08 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49962/#review145138 --- Ship it! Ship It! - Bruce Schuchardt On août 5, 2016, 4:52

Review Request 50856: GEODE-225 excessive CPU utilization and garbage collection strain for JSON processing

2016-08-05 Thread Bruce Schuchardt
performance is determined to not be affected. Diffs - geode-core/src/main/java/com/gemstone/gemfire/pdx/internal/PdxInstanceImpl.java d759c49155f2c098b0d7ad48129045c4eb819ea8 Diff: https://reviews.apache.org/r/50856/diff/ Testing --- precheckin Thanks, Bruce Schuchardt

Re: Flaky tests failing with BindException

2016-08-04 Thread Bruce Schuchardt
I've pushed the port-range changes that I described in my last email on this subject. Le 8/1/2016 à 5:33 PM, Kirk Lund a écrit : I think that the changes mentioned by Jens and Bruce obviate the need to do what I was proposing. -Kirk On Fri, Jul 29, 2016 at 3:41 PM, Bruce Schuchardt

Review Request 50798: GEODE-1727 NPE in JGroups during shutdown

2016-08-04 Thread Bruce Schuchardt
2ba319de69df0e82f996c212adbf6ae200e36fe8 Diff: https://reviews.apache.org/r/50798/diff/ Testing --- Thanks, Bruce Schuchardt

Re: Build failed in Jenkins: Geode-nightly #549

2016-08-03 Thread Bruce Schuchardt
The port-range test failure is due to my checkin yesterday. I'm looking into it. Le 8/3/2016 à 7:28 AM, Apache Jenkins Server a écrit : See Changes: [jdeppe] GEODE-1666: Bump Gradle from 2.12 to 2.14.1 [klund] GEODE-1682: Adding

Re: Flaky tests failing with BindException

2016-07-29 Thread Bruce Schuchardt
I'm making another change that will help. One of the problems with these tests is that they will choose a random port for a Cache Server or some other component and only use the port after opening a cache. Doing that allows the communications/membership component to grab two ports.

Re: Review Request 50587: Merge from 82 and couple of other perf related improvements

2016-07-29 Thread Bruce Schuchardt
ire/internal/cache/tier/sockets/Part.java (line 191) <https://reviews.apache.org/r/50587/#comment210155> We should change this to limit it to 16-bit integers. I don't see any uses of it that would cause memory bloat in the current code base but that could change in the future. - Bruc

geode-core distributedTest statistics

2016-07-29 Thread Bruce Schuchardt
Here are some stats on the run-time of our geode-core distributedTests. There are 7431 geode-core distributedTests. On my last run these took 280 minutes to execute. 5% of the tests run for over 10 seconds and are taking 50% of the time (140 minutes). 2.5% run for over 20 seconds and are

Re: Review Request 50607: Update of cq stats causing disk read

2016-07-29 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50607/#review144124 --- Ship it! Ship It! - Bruce Schuchardt On July 29, 2016, 4:58

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC6

2016-07-28 Thread Bruce Schuchardt
commit 4c5a699490b2702d6abe3a40e5d74a7e2f6b5acf Author: Bruce Schuchardt <bschucha...@pivotal.io> Date: Tue Jul 26 13:49:00 2016 -0700 fixes flakyTest target to allow it to run Rest API tests diff --git a/geode-assembly/build.gradle b/geode-assembly/build.gradle index fdd6e25..4

Re: Build failed in Jenkins: Geode-release #18

2016-07-28 Thread Bruce Schuchardt
This is a problem in the geode-assembly build.gradle configuration. The flakyTest task needs to depend on the installed product, like distributedTest does. I've fixed that on the develop branch. Le 7/28/2016 à 10:45 AM, Apache Jenkins Server a écrit :

Re: Build failed in Jenkins: Geode-release #17

2016-07-28 Thread Bruce Schuchardt
to create an INFRA ticket. --Mark On Thu, Jul 28, 2016 at 8:58 AM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: Do we have any information on the ulimit settings in the account running the tests? This may just be an issue with how the account is configured. Le 7/27/2016 à 9:21 AM, K

Re: Build failed in Jenkins: Geode-release #17

2016-07-28 Thread Bruce Schuchardt
Do we have any information on the ulimit settings in the account running the tests? This may just be an issue with how the account is configured. Le 7/27/2016 à 9:21 AM, Kirk Lund a écrit : Looks like OutOfMemory is the cause of this failure. Do we need to increase heap size for Jenkins or is

Review Request 50538: GEODE-1619 PartitionedRegionSingleHopWithServerGroupDUnitTest.test_SingleHopWithServerGroupTwoClientServerGroup

2016-07-27 Thread Bruce Schuchardt
://reviews.apache.org/r/50538/diff/ Testing --- Thanks, Bruce Schuchardt

Re: Renaming GeodePermission

2016-07-27 Thread Bruce Schuchardt
ResourcePermission seems better to me. "Permission" seems like the name of an interface. Le 7/27/2016 à 9:54 AM, Kirk Lund a écrit : I'm looking at renaming GeodePermission to Permission (see GEODE-1701). There are a number classes in Geode which import GeodePermission and Shiro's Permission

Re: Build failed in Jenkins: Geode-nightly #541

2016-07-26 Thread Bruce Schuchardt
. -Kirk On Tue, Jul 26, 2016 at 10:19 AM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: It looks like the flakyTest target isn't configured to run Rest API tests. Does anyone know how to fix this? Le 7/26/2016 à 7:31 AM, Apache Jenkins Server

Re: Build failed in Jenkins: Geode-nightly #541

2016-07-26 Thread Bruce Schuchardt
It looks like the flakyTest target isn't configured to run Rest API tests. Does anyone know how to fix this? Le 7/26/2016 à 7:31 AM, Apache Jenkins Server a écrit : :geode-assembly:flakyTest com.gemstone.gemfire.rest.internal.web.controllers.RestAPIsOnMembersFunctionExecutionDUnitTest >

Re: use-cluster-configuration/cache.xml/reconnect

2016-07-25 Thread Bruce Schuchardt
But as John pointed out, you shouldn't use auto-reconnect with Spring. Spring has injected references to the old cache and regions into applications and they won't know about the new cache. Auto-reconnect doesn't rebuild the old cache - it creates a new one with its own identity. Le

Re: Build failed in Jenkins: Geode-nightly #537

2016-07-22 Thread Bruce Schuchardt
If we disable the other tests in that class it's possible that Jenkins would capture enough output for us to figure out what's happening. On the other hand maybe we should just delete this whole test class. Le 7/22/2016 à 9:39 AM, Kirk Lund a écrit : ConsoleDistributionManagerDUnitTest seems

Re: Javadoc warnings

2016-07-20 Thread Bruce Schuchardt
The @guarded.By in GMSMembershipManager came from the old JGroupsMembershipManager and has been there for a very long time. Do we need to do a search and scrub out all of these tags? Le 7/20/2016 à 3:37 PM, Kirk Lund a écrit : Reminder: please watch for javadoc warnings in your code before

Re: Review Request 50089: GEODE-1669: Performance issue with Interest registration with impact on client side event processing

2016-07-19 Thread Bruce Schuchardt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50089/#review142878 --- Ship it! Ship It! - Bruce Schuchardt On July 19, 2016, 11

Re: Build failed in Jenkins: Geode-release #14

2016-07-19 Thread Bruce Schuchardt
The ConsoleDistributionManagerDUnitTest failure isn't a PDX problem. The admin distributed system is being shut down for some reason before the test attempts to send an admin request message. Build-artifacts don't have any useful information on why that is happening. Unfortunately the test

Re: Review Request 50089: GEODE-1669: Performance issue with Interest registration with impact on client side event processing

2016-07-15 Thread Bruce Schuchardt
set of keys. I think you need something more like this: keysRegistered = new HashSet(keys); keysRegistered.removeAll(interestList.getSnapshot()); interestList.addAll(keys); - Bruce Schuchardt On July 15, 2016, 10:14 p.m., anilkumar gingade wrote

Re: GMSAuthenticator

2016-07-12 Thread Bruce Schuchardt
I think we should get rid of that. It's a hack that the engineer who implemented the old AUTH protocol used because he didn't know how to get hold of the DistributionConfig. GMSAuthenticator can get at the config through services.getConfig().getDistributionConfig(). Le 7/12/2016 à 2:36 PM,

Re: Trouble with AnalyzeSerializablesJUnitTest

2016-07-12 Thread Bruce Schuchardt
How did an actualSerializables.dat file come to be in the geode-core directory? It should be in the geode-core/build/integrationTest directory. Verify that the sanctionedSerializables.txt file has the Redis classes in it. If that's not the problem I can look into it with you. Le 7/12/2016

Re: Review Request 49962: Removed extra fields from distributedmember while serialization/de

2016-07-12 Thread Bruce Schuchardt
); - Bruce Schuchardt On July 12, 2016, 4:52 p.m., Hitesh Khamesra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Client Cache Behavior after ForcedDisconnectException

2016-07-11 Thread Bruce Schuchardt
You won't be able to fish for the old cache like this. Once it is disrupted with a ForceDisconnectException the old cache won't be returned by CacheFactory.getAnyInstance(). You'll need to retain a reference to the old cache in the test and use that instead. Client caches shouldn't need to

Re: Review Request 49901: GEODE-1642 Add conveniance method isCancelInProgress to CancelCriterion

2016-07-11 Thread Bruce Schuchardt
fa90e889c55a115a66c1030b71d63e82ee4fb41b geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java b1781927974eabf871aaf0e138a8a25c3ffcbbf8 Diff: https://reviews.apache.org/r/49901/diff/ Testing --- Precheckin Thanks, Bruce Schuchardt

Re: Review Request 49901: GEODE-1642 Add conveniance method isCancelInProgress to CancelCriterion

2016-07-11 Thread Bruce Schuchardt
/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java b1781927974eabf871aaf0e138a8a25c3ffcbbf8 Diff: https://reviews.apache.org/r/49901/diff/ Testing --- Precheckin Thanks, Bruce Schuchardt

Review Request 49901: GEODE-1642 Add conveniance method isCancelInProgress to CancelCriterion

2016-07-11 Thread Bruce Schuchardt
://reviews.apache.org/r/49901/diff/ Testing --- Precheckin Thanks, Bruce Schuchardt

  1   2   3   4   >