Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

/AbstractGatewaySenderEventProcessor.java b41ace4 geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java 97cfac7 Diff: https://reviews.apache.org/r/53745/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySenderEventProcessor.java e953c0c geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ff36e06 Diff: https://reviews.apache.org/r/53745/diff/ Testing (updated) --- Thanks, xiaojian zhou

Re: Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

edgeOldThreadsPerVM = 1 nPutThreads=10 nPutKeyRange=10 version1=default version2=822 Thanks, xiaojian zhou

Review Request 53745: when a sender was stopped before becoming a primary, the wait thread should be closed

/apache/geode/internal/cache/wan/GatewaySenderAdvisor.java ff36e06 Diff: https://reviews.apache.org/r/53745/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 53401: GEODE-1932: Protected use of global variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53401/#review154643 --- Ship it! Ship It! - xiaojian zhou On Nov. 2, 2016, 8:14 p.m

Re: [DISCUSS] Graduation

+1 On Mon, Oct 31, 2016 at 4:12 PM, Jianxia Chen wrote: > +1 > > On Mon, Oct 31, 2016 at 2:47 PM, Anilkumar Gingade > wrote: > > > +1 > > > > On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre > > wrote: > > > > > +1 > > > > > > On Sat,

Re: Review Request 52759: GEODE-1991: Removing sleeps from HARegionQueueJUnitTest

pache.org/r/52759/#comment221549> This should be 4 seconds geode-core/src/test/java/org/apache/geode/internal/cache/ha/HARegionQueueJUnitTest.java (line 467) <https://reviews.apache.org/r/52759/#comment221552> This should be >=, not > - xiaojian zhou On Oct. 11, 201

Review Request 52699: while accessor is a diskstore for now, there's race that vm_0 only hosted 1 primary bucket.

--- Thanks, xiaojian zhou

Re: CI bugs

GEODE-933 and GEODE-977 are not reproducible either after run 30+ times. So they are not flaky and can be closed for now. On Sat, Oct 1, 2016 at 11:30 PM, Xiaojian Zhou <gz...@pivotal.io> wrote: > 1011, 1062, 1066, 1147 have been run 30+ times without reproduce. So it's > not flaky

Re: CI bugs

1011, 1062, 1066, 1147 have been run 30+ times without reproduce. So it's not flaky. I think we can close them. If reproduced someday, we can re-open. On Sat, Oct 1, 2016 at 5:09 PM, Anthony Baker wrote: > I reviewed a bunch of CI failures today. I closed out duplicates and

Re: Review Request 52176: GEODE-1926: Modification of peedAhead() function check if heapCopy is successful before adding the key to peekedIds

; > (Updated Sept. 23, 2016, 9:58 p.m.) > > > Review request for geode, Barry Oglesby, Eric Shu, Jason Huynh, Dan Smith, > and xiaojian zhou. > > > Repository: geode > > > Description > --- > > Before my changes: > 1. peek ca

Review Request 52179: There's race condition that the AckReader thread got the read lock and waitng for ack, but the stopSender() kicks in

/GatewaySenderEventRemoteDispatcher.java 6beb0ee046d7e0cae5985b6430a390dd68f1351a Diff: https://reviews.apache.org/r/52179/diff/ Testing --- Thanks, xiaojian zhou

Review Request 51585: let getId() return unique name

://reviews.apache.org/r/51585/diff/ Testing --- geode-lucene:precheckin Thanks, xiaojian zhou

Review Request 51567: should save the reference of serverlocation in case it was destroyed by another thread

- geode-wan/src/main/java/com/gemstone/gemfire/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java 2625ad2 Diff: https://reviews.apache.org/r/51567/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 50420: there is a race that cache is still initializing, some components are not ready

, xiaojian zhou

Re: Review Request 50420: there is a race that cache is still initializing, some components are not ready

/lucene/test/LuceneTestUtilities.java da281ff Diff: https://reviews.apache.org/r/50420/diff/ Testing --- Thanks, xiaojian zhou

Review Request 50420: there is a race that cache is still initializing, some components are not ready

--- Thanks, xiaojian zhou

Review Request 50316: add support to lucene's raw Directory (RAMDirectory or NIOFSDirectory)

-lucene tests passed. Thanks, xiaojian zhou

Review Request 50315: Refactor curret Index/RepositoryManager/Repository to use index reference, add support to RawDirectory

/repository/IndexRepositoryImplPerformanceTest.java 3155aaf geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/IndexRepositorySpy.java 0b66f55 Diff: https://reviews.apache.org/r/50315/diff/ Testing --- added junit test and all the geode-lucene tests passed. Thanks, xiaojian

Re: Review Request 49966: GEODE-11 Adding tests of closing a cache during index updates

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49966/#review141994 --- Ship it! Update and ship it. - xiaojian zhou On July 12

Re: How to commit the chinese documents to apache geode site?

If you don't have authority to add the page into geode's wiki, you can send it to me. On Tue, Jul 12, 2016 at 9:58 AM, Xiaojian Zhou <gz...@pivotal.io> wrote: > You can add a wiki page for geode with chinese characters. I just did some > test. > > > https://cwiki.apache.o

Re: How to commit the chinese documents to apache geode site?

wrote: > Yeah, xiaojian. > > > > 2016-07-12 23:53 GMT+08:00 Xiaojian Zhou [via Apache Geode (Incubating) > Developers Forum] <ml-node+s70738n7128...@n6.nabble.com>: > > > Do you mean to publish into geode wiki or check into geode source code? > > > > On T

Re: How to commit the chinese documents to apache geode site?

Do you mean chinese file name or content in a PDF or text file? On Tue, Jul 12, 2016 at 3:28 AM, theseusyang wrote: > Hi All, > > I have translated some chinese documents about geode installation, > deployment,features. > Now the main question is that How to put the

Re: How to commit the chinese documents to apache geode site?

Do you mean to publish into geode wiki or check into geode source code? On Tue, Jul 12, 2016 at 9:05 AM, Xiaojian Zhou <gz...@pivotal.io> wrote: > Do you mean chinese file name or content in a PDF or text file? > > On Tue, Jul 12, 2016 at 3:28 AM, theseusyang <theseusy...@

Re: Review Request 49772: CI failure: LuceneQueriesClientDUnitTest.entriesFlushedToIndexAfterWaitForFlushCalled

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49772/#review141227 --- Ship it! Ship It! - xiaojian zhou On July 7, 2016, 10:39

Review Request 49481: summarize the investigation results on numeric field range query into a integration test case

/java/com/gemstone/gemfire/cache/lucene/internal/LuceneQueryFactoryImpl.java 62b4f56 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 988e4f5 Diff: https://reviews.apache.org/r/49481/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 48965: add a test case to run query on client

/gemfire/cache/lucene/LuceneQueriesBase.java 26cd4aa Diff: https://reviews.apache.org/r/48965/diff/ Testing --- Thanks, xiaojian zhou

Review Request 48965: add a test case to run query on client

/gemstone/gemfire/cache/lucene/LuceneQueriesBase.java 26cd4aa Diff: https://reviews.apache.org/r/48965/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 48701: add a test to query json object from geode-lucene

geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java 0cf8953 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/TestObject.java a2b249e Diff: https://reviews.apache.org/r/48701/diff/ Testing --- Thanks, xiaojian zhou

Review Request 48701: add a test to query json object from geode-lucene

/LuceneTestUtilities.java 0cf8953 Diff: https://reviews.apache.org/r/48701/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48432/#review137430 --- Ship it! Ship It! - xiaojian zhou On June 9, 2016, 6:41 p.m

Re: Proposal - provide a callback to compute statistics

what's the difference btw supplier and sampler? On Wed, Jun 1, 2016 at 4:12 PM, Dan Smith wrote: > Hi, > > I'd like to add some new methods to the Statistics interface to compute > statistics using callbacks. My original motivation for this is to make it > easy to record

Re: Review Request 48145: GEODE-11: Adding a method to LuceneIndexImpl to dump indexes

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48145/#review135848 --- Ship it! Ship It! - xiaojian zhou On June 1, 2016, 6:34 p.m

Re: Review Request 48138: GEODE-11 Adding stats for the lucene file system.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48138/#review135838 --- Ship it! Ship It! - xiaojian zhou On June 1, 2016, 5:52 p.m

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

<dsm...@pivotal.io> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48086/ > > On May 31st, 2016, 11:01 p.m. UTC, *xiaojian zhou* wrote: > > > geode-lucene/src/test/java/com/gemstone/gemfire/cach

Re: Review Request 48086: GEODE-11: Adding a tool to dump the lucene index files

IndexImpl to do this function execution. Then I can call: myIndex.convertToFile(diskDir) without know the detail syntax of FunctionService. BTW, I think it can be shipped. My above suggestion can be done in step2 after checked in current code. - xiaojian zhou On

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

to check if haContainer == null in HARegionQueue.java? - xiaojian zhou On May 26, 2016, 8:34 p.m., Jianxia Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 47912: GEODE-11: Adding stats for lucene index updates and queries

ence it in other classes, such as RepositoryManager. - xiaojian zhou On May 26, 2016, 6:26 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 47911: GEODE-11: Adding a test of queries with redundancy

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47911/#review135037 --- Ship it! Ship It! - xiaojian zhou On May 26, 2016, 6:22 p.m

Re: Review Request 47908: GEODE-1460 RemoveAll fails with NPE in com.gemstone.gemfire.internal.cache.tier.sockets.CacheClientNotifier.checkAndRemoveFromClientMsgsRegion()

/tier/sockets/CacheClientNotifier.java (line 86) <https://reviews.apache.org/r/47908/#comment28> You should get rid of "synchronized" on the methods. Others look good. Fit it and ship it. - xiaojian zhou On May 26, 2016, 5:23 p.m., Ji

Review Request 47803: field value could be null, need to handle this case

/lucene/internal/repository/serializer/PdxFieldMapperJUnitTest.java 278e818 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/repository/serializer/ReflectionFieldMapperJUnitTest.java c187022 Diff: https://reviews.apache.org/r/47803/diff/ Testing --- Thanks, xiaojian

Re: Review Request 47675: GEODE-1389, GEODE-1012: Cleaning up some persistence tests in LuceneIndexRecoveryHAIntegrationTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47675/#review134436 --- Ship it! Ship It! - xiaojian zhou On May 20, 2016, 10:18

Re: Review Request 47712: test perfield analyzer

--- Thanks, xiaojian zhou

Review Request 47712: test perfield analyzer

-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/LuceneQueriesIntegrationTest.java 15f5747 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/test/LuceneTestUtilities.java 571049c Diff: https://reviews.apache.org/r/47712/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 47503: GEODE-357: Remove third server from testInitiateFailoverByCacheOperationThreads_Secondary

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47503/#review133694 --- Ship it! Ship It! - xiaojian zhou On May 17, 2016, 11:58

Re: Review Request 47004: a quick solution to wait for entry flushed into index

://reviews.apache.org/r/47004/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 47004: a quick solution to wait for entry flushed into index

/cache/lucene/LuceneQueriesBase.java c467a18 geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneIndexImplJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/47004/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 47327: Fixing compile errors in eclipse

for resources) in tomcat7. That's good. - xiaojian zhou On May 13, 2016, 12:14 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 47254: GEODE-1183: when there're 2 cacheserver on the same jvm, it will keep recreating or reinitializing the proxy

.java PRE-CREATION Diff: https://reviews.apache.org/r/47254/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 47220: This is bug in test code

/wan/Simple2CacheServerDUnitTest.java 4fdd88d Diff: https://reviews.apache.org/r/47220/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 47148: GEODE-11: Adding package level javadocs for lucene

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47148/#review132530 --- Ship it! Ship It! - xiaojian zhou On May 10, 2016, 1:13 a.m

Re: Review Request 47083: transfer the system property for log4j from gradle to unit test framework

://reviews.apache.org/r/47083/diff/ Testing --- Thanks, xiaojian zhou

Review Request 47083: transfer the system property for log4j from gradle to unit test framework

/dunit/standalone/DUnitLauncher.java be459b9 geode-core/src/test/java/com/gemstone/gemfire/test/dunit/standalone/ProcessManager.java dd532c4 gradle/test.gradle 2dd7521 Diff: https://reviews.apache.org/r/47083/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 47046: The test code needs to be enhanced

/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java 684660b Diff: https://reviews.apache.org/r/47046/diff/ Testing --- Thanks, xiaojian zhou

Review Request 47046: The test code needs to be enhanced

Diff: https://reviews.apache.org/r/47046/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/46625/diff/ Testing --- Thanks, xiaojian zhou

Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

/sockets/CacheClientNotifier.java 1ba2294 geode-wan/src/test/java/com/gemstone/gemfire/internal/cache/wan/CacheClientNotifierDUnitTest.java 8bf819c Diff: https://reviews.apache.org/r/46625/diff/ Testing --- Thanks, xiaojian zhou

Re: Review Request 46239: UnitTest for LuceneIndexForPartitionedRegion

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46239/#review129067 --- Ship it! Ship It! - xiaojian zhou On April 15, 2016, 12:16

Re: [VOTE] RC2: Apache Geode (Incubating) second Milestone release - v1.0.0-incubating.M2

+1 On Wed, Apr 13, 2016 at 3:55 PM, Dan Smith wrote: > This is second release candidate for Apache Geode, version > 1.0.0-incubating.M1. > > *** Please download, test and vote by Monday, Apr 18, 0800 PST > > If you are wondering why you didn't see RC1, it's because I caught a

Re: Review Request 46065: clean up the lucene index support code for RR

geode-lucene/src/test/java/com/gemstone/gemfire/cache/lucene/internal/LuceneServiceImplJUnitTest.java 159fd46 Diff: https://reviews.apache.org/r/46065/diff/ Testing --- Thanks, xiaojian zhou

Review Request 46065: clean up the lucene index support code for RR

, xiaojian zhou

Re: Review Request 45880: Added Lucene Index creation on RR expects exception test. Minor refactoring

ut it's ok either way. It's good. - xiaojian zhou On April 7, 2016, 5:22 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revi

Re: Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

new dunit test. - precheckin - regression tests: Thanks, xiaojian zhou

Re: Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

- regression tests: Thanks, xiaojian zhou

Review Request 45336: GEODE-920: Not to create CCN for gateway receiver

/CacheClientNotifierDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/45336/diff/ Testing --- - introduced new dunit test. - precheckin - regression tests: Thanks, xiaojian zhou

Review Request 44601: revoke the unnecessary code change in DistributedTestCase which caused side-effect

Diff: https://reviews.apache.org/r/44601/diff/ Testing --- Thanks, xiaojian zhou

Review Request 44540: add junit test for procesChunk of FetchEntriesMessage

/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessage.java fda15c4 geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/FetchEntriesMessageJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/44540/diff/ Testing --- Thanks, xiaojian zhou

Review Request 44412: specify logLevel in command line of geode for running dunit test

gradle/test.gradle d8af4ba Diff: https://reviews.apache.org/r/44412/diff/ Testing --- precheckin and some dunit tests Thanks, xiaojian zhou

Review Request 44306: shadowPR's entries do not have version tag

/FetchEntriesMessage.java 0342164 Diff: https://reviews.apache.org/r/44306/diff/ Testing --- precheckin the failed test itself Thanks, xiaojian zhou

Review Request 44118: add more junt tests case to BucketRegionJUnitTest and introduce DistributedRegionJUnitTest

/test/java/com/gemstone/gemfire/test/fake/Fakes.java ffb4896 Diff: https://reviews.apache.org/r/44118/diff/ Testing --- junit tests Thanks, xiaojian zhou

Re: Review Request 43674: GEODE-969: Decreases WAN dunit log file size

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43674/#review119533 --- Ship it! Ship It! - xiaojian zhou On Feb. 17, 2016, 8:44

Re: Review Request 43129: GEODE-898: Fixing a race in SerialWANStatsDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43129/#review117577 --- Ship it! Ship It! - xiaojian zhou On Feb. 3, 2016, 1:51 a.m

Re: Review Request 43016: GEODE-869 / 883

diff, you did not remove "testOutput {...}" section from open/build.gradle. We still need it? - xiaojian zhou On Jan. 30, 2016, 5:45 p.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 42892: GEODE-873: Allowing for possible retry in testParallelPregationHA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42892/#review116687 --- Ship it! Ship It! - xiaojian zhou On Jan. 28, 2016, 1:47

Re: Review Request 42889: GEODE-865: CI Failure: ConcurrentParallelGatewaySenderOperation_2_DUnitTest.testParallelGatewaySenders_SingleNode_UserPR_localDestroy_RecreateRegion

/wan/concurrent/ConcurrentParallelGatewaySenderOperation_2_DUnitTest.java (line 526) <https://reviews.apache.org/r/42889/#comment177762> I have been thinking of make this method more generic to be shared by all the WAN test cases and AEQ test cases. Others look good. - xiaojia

Re: Review Request 42886: GEODE-867: Ignore secondaries in waitForDispatcherToPause

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42886/#review116680 --- Ship it! Ship It! - xiaojian zhou On Jan. 28, 2016, 12:46

Re: Review Request 42885: GEODE-872: Removing duplicate code from ConcurrentSerialGatewaySenderOperationsDUnitTest

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42885/#review116669 --- Ship it! Ship It! - xiaojian zhou On Jan. 28, 2016, 12:43

Re: Review Request 42822: GEODE-864: Waiting for conflation thread in conflation tests

/wan/WANTestBase.java (line 2165) <https://reviews.apache.org/r/42822/#comment177495> There is a pauseSender() and pauseSenderAndWaitForDispatcherToPause(). You just made the 2 methods identical. Was that purposely using pauseSender() here? Others look good. - xiaojia

Re: Lambdas in dunits! Time to remove string invoke?

+1 It saved a lot of trouble in tracing the method. And introduced a simple interface can make such a big difference. On Tue, Jan 26, 2016 at 3:22 PM, Kenneth Howe wrote: > +1 > > Ken > >

Re: Review Request 42039: GEODE-716: Getting the bucket creation lock when setting the CacheLoader

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42039/#review115467 --- Ship it! Ship It! - xiaojian zhou On Jan. 15, 2016, 1:55 a.m

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41492/#review115474 --- Ship it! Ship It! - xiaojian zhou On Jan. 16, 2016, 1:45 a.m

Re: Review Request 42465: refactoring RegionVersionHolder.recordVersion()

I am wrong. Just so that you can take a look. Thanks! > > > - Jinmei > > On January 18th, 2016, 6:29 p.m. UTC, Bruce Schuchardt wrote: > Review request for geode, Dan Smith and xiaojian zhou. > By Bruce Schuchardt. > > *Updated Jan. 18, 2016, 6:29 p.m.* > *Reposit

Re: Review Request 42099: Fix for 52550 issue

java/com/gemstone/gemfire/internal/cache/DistributedRegion.java 92b585a Diff: https://reviews.apache.org/r/42099/diff/ Testing --- The in-house hydra test to reproduce it. precheckin. A lot of wan hydra tests. Thanks, xiaojian zhou

Review Request 42099: Fix for Garmin issue

f: https://reviews.apache.org/r/42099/diff/ Testing --- The in-house hydra test to reproduce it. precheckin. A lot of wan hydra tests. Thanks, xiaojian zhou

Re: Review Request 41492: GEODE-681: Measuring event queue size without using the stat for gfsh

/internal/beans/stats/StatsKey.java <https://reviews.apache.org/r/41492/#comment170910> You removed this stats "eventQueueSize", vsd cannot show it any more. How about fix the size in stats too? - xiaojian zhou On Dec. 17, 2015, 2:43 a.m.,

Re: Review Request 41332: Add CacheObserver for ShutdownAll and also let WAN to return CancelException

t; seems like there might be other code that is expecting to find a region > that previously existed, and the only reason that it is gone is because of > a shut down all. > > - Dan Smith > > > On Dec. 14, 2015, 1:06 a.m., xiaojian zhou wrote: > > > >

Review Request 39763: need to add expected exception for the exception test

/PRClientServerRegionFunctionExecutionSingleHopDUnitTest.java c0b0d3c Diff: https://reviews.apache.org/r/39763/diff/ Testing --- the dunit test case Thanks, xiaojian zhou

Re: Review Request 39763: need to add expected exception for the exception test

crashed. Scheduling recovery. So the disconnecting is expected. - xiaojian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39763/#review104474 ---

Review Request 39747: tombstone GC did not finished at the same time on different member

: https://reviews.apache.org/r/39747/diff/ Testing --- the dunit test Thanks, xiaojian zhou

Re: Review Request 39329: Requiring lucene index to be created before the region

for DR. - xiaojian zhou On Oct. 14, 2015, 9:21 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 39020: GEODE-244: Fixing race in testRecoverRedundancyWithOfflinePersistenceSimulation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39020/#review101605 --- Ship it! Ship It! - xiaojian zhou On Oct. 5, 2015, 9:40 p.m

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

current DS is disconnecting. Diffs (updated) - gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java b7b2cd8 Diff: https://reviews.apache.org/r/38572/diff/ Testing --- precheckin Thanks, xiaojian zhou

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

java b7b2cd8 Diff: https://reviews.apache.org/r/38572/diff/ Testing --- precheckin Thanks, xiaojian zhou

Re: Review Request 38572: Fix CI failure for ShutdownAllDUnitTest

- gemfire-core/src/main/java/com/gemstone/gemfire/distributed/DistributedSystem.java b7b2cd8 Diff: https://reviews.apache.org/r/38572/diff/ Testing --- precheckin Thanks, xiaojian zhou

Re: Weird networking behavior on Amazon EC via OSv deployment

No. ALL does not count. I remembered that I have to manually specify the range. On Mon, Aug 17, 2015 at 6:06 PM, Roman Shaposhnik ro...@shaposhnik.org wrote: On Mon, Aug 17, 2015 at 5:40 PM, Xiaojian Zhou gz...@pivotal.io wrote: This error msg actually is not the root cause of the issue