Re: Open source the integrated development framework for geode/gemfire!

2016-11-11 Thread Anthony Baker
Cool, I’m very interested to learn more! Anthony > On Nov 11, 2016, at 8:27 AM, theseusyang wrote: > > Hi All, > > I plan to open source a integrated development framework for geode/gemfire > at next month. > > this framework has already been used successfully in12306

Re: Review Request 53632: added script that will generate AbstractRegionEntry subclass source files

2016-11-09 Thread Anthony Baker
this into the build script? - Anthony Baker On Nov. 9, 2016, 11:11 p.m., Darrel Schneider wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 53596: GEODE-1808 Remove broken check for jdk1.7.0_72

2016-11-09 Thread Anthony Baker
This shows up when trying to run with a jdk9 jvm. - Anthony --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53596/#review155455 ----------

Re: classpath in geode release

2016-11-08 Thread Anthony Baker
> On Nov 8, 2016, at 1:09 AM, Gal Palmery wrote: > > Actually I do see them in the lib dir, after running the build, inside the > zip in the distributions: > > geode-assembly\build\distributions\apache-geode-1.0.0-incubating.zip\apache-geode-1.0.0-incubating\lib

Review Request 53566: GEODE-2078: Fix manifest classpath

2016-11-07 Thread Anthony Baker
/r/53566/diff/ Testing --- Thanks, Anthony Baker

Re: classpath in geode release

2016-11-07 Thread Anthony Baker
ven / gradle dependencies to pull in the correct jars. > Thanks, > Gal > > > -Original Message- > From: Anthony Baker [mailto:aba...@pivotal.io] > Sent: Monday, November 07, 2016 01:20 > To: geode > Subject: Re: classpath in geode release > > >>

Re: classpath in geode release

2016-11-06 Thread Anthony Baker
> On Nov 6, 2016, at 7:47 AM, Gal Palmery wrote: > > Clarification - > This is in the geode-dependencies.jar and gfsh-dependencies.jar that were > created by the local build that I run on my PC. > I downloaded the 1.0.0-incubating release and built it using the

Re: Gfsh Parsing

2016-11-04 Thread Anthony Baker
Wes, I think it would be interesting if we added a new option ‘--output=json’ to better handle the use case you described. Then you could pipe the gfsh command through a json parser like jq. Anthony > On Nov 4, 2016, at 9:51 AM, Real Wes wrote: > > I call the GFSH

Review Request 53335: GEODE-2028: Fix license issues from 1.0.0-incubating release

2016-10-31 Thread Anthony Baker
: https://reviews.apache.org/r/53335/diff/ Testing --- Thanks, Anthony Baker

Re: Docker image for Geode 1.0.0-incubating - Please evaluate

2016-10-31 Thread Anthony Baker
Nice! What about tagging it with 'latest'? Anthony > On Oct 31, 2016, at 12:13 PM, William Markito Oliveira > wrote: > > I've just updated our Docker image with 1.0.0-incubating bits, please > evaluate. > > There is also a pull request for review updating our

Re: Build failed in Jenkins: Geode-nightly #639

2016-10-31 Thread Anthony Baker
I updated the geode-examples dependency to 1.0.0-incubating. Anthony > On Oct 31, 2016, at 8:54 AM, Apache Jenkins Server > wrote: > > See > > -- > [...truncated 476

Review Request 53290: GEODE-2034: Clean up old releases

2016-10-29 Thread Anthony Baker
d42e5143e47887dd13d26c8bf3999f60b1290ca3 Diff: https://reviews.apache.org/r/53290/diff/ Testing --- Thanks, Anthony Baker

Re: Improving release notes

2016-10-29 Thread Anthony Baker
, +1. > > Also, it doesn't hurt to list the significant/critical dependency updates > in a subsection. > > -j > > On Thu, Oct 27, 2016 at 3:10 PM, Anthony Baker <aba...@pivotal.io> wrote: > >> The release notes [1] from the latest release announcement [2] includ

Improving release notes

2016-10-27 Thread Anthony Baker
The release notes [1] from the latest release announcement [2] included a long list of all the JIRA’s associated with the release. Having a curated list that highlights the most interesting changes would make the release more approachable and easy to understand. What do you think about

Re: [CONF] Geode > Release Steps

2016-10-27 Thread Anthony Baker
Since homebrew and macports are external to ASF I don’t think we should call them out in the release steps. I do think it makes sense to inform contributors in other communities (like homebrew, YCSB, Zeppelin, Spring, etc) and help them upgrade to new releases. Anthony > On Oct 27, 2016, at

Re: GEODE-2036 and documentation practices and procedures

2016-10-26 Thread Anthony Baker
Great! I’m much more comfortable with describing the process as CTR. Anthony > On Oct 26, 2016, at 12:31 PM, Karen Miller wrote: > > I would also like to add that the C-T-R model for small doc changes such as > typo corrections > sounds like a good model to follow. So,

Review Request 53190: [GEODE-2037] Update documentation links

2016-10-26 Thread Anthony Baker
17e22598e2e549d8f1bbda6935799ca4e2102d5e geode-pulse/src/main/webapp/regionDetail.html 98404cbf1a95f633b62b17a4b5f9c6795b637c72 geode-site/website/content/releases/index.html 63f685e43b5d9c7ccce487f5c6caeca61f070a8f Diff: https://reviews.apache.org/r/53190/diff/ Testing --- Thanks, Anthony Baker

Re: GEODE-2036 and documentation practices and procedures

2016-10-25 Thread Anthony Baker
What I _think_ you are suggesting is using C-T-R (commit-then-review) [1] for reasonably well-defined documentation-related changes. Do you agree? Here’s why we tag commits with a JIRA: - we can better understand the reason for a code change by looking at the associated JIRA - we can scope

Re: [DISCUSS] Graduation

2016-10-25 Thread Anthony Baker
A quick update to the JIRA stats: 2035 issues created 1364 issues closed > On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik wrote: > > 1900 issues created > 1230 issues resolved

Re: [DISCUSS] Graduation

2016-10-25 Thread Anthony Baker
+1 > On Oct 25, 2016, at 5:25 PM, Roman Shaposhnik wrote: > > Unless somebody objects strongly to my #2 and #3 proposals I'm going > to kick of this thread on private@.

Re: [GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-25 Thread Anthony Baker
Looks like the only common (previous) dependency is the core jquery library which is used by pulse and the geode-site. > On Oct 25, 2016, at 11:27 AM, Kevin Duling wrote: > > None of these are related to pulse, that lives > in geode-web, not geode-web-api.

Re: [GitHub] incubator-geode pull request #265: GEODE-2014: Upgrade Swagger libraries

2016-10-25 Thread Anthony Baker
I missed these changes in the original pull request: delete mode 100644 geode-web-api/src/main/webapp/docs/css/reset.css delete mode 100644 geode-web-api/src/main/webapp/docs/css/screen.css delete mode 100755 geode-web-api/src/main/webapp/docs/images/explorer_icons.png delete mode 100755

Re: 2.0 release in JIRA

2016-10-25 Thread Anthony Baker
+1 > On Oct 25, 2016, at 9:44 AM, Dan Smith wrote: > > It looks like we already have both a 1.1 and a 2.0 version in JIRA. Do we > need that 2.0 version yet? The only things I see assigned to it seem to be > assigned to it by mistake. Is it ok to delete that version until

Re: Coding practices/standards

2016-10-21 Thread Anthony Baker
> On Wed, Oct 12, 2016 at 9:58 PM, William Markito < >>>>>>>>> wmark...@pivotal.io> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>&

Hosting the docs (was Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2)

2016-10-17 Thread Anthony Baker
Since the geode docs have now been merged to the develop branch, let’s start hosting them on http://geode.apache.org. Thoughts? Anthony > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar wrote: > > > The documentation on how to install and use Apache Geode are hosted >

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-16 Thread Anthony Baker
+1 * Verified sha’s * Verified signatures * Verified tag signature * Build and run from src distro * Checked src distro for binaries * Run some examples from mvn repo * Reviewed LICENSE and NOTICE Anthony > On Oct 15, 2016, at 5:51 PM, Swapnil Bawaskar wrote: > > All, >

Re: Review Request 52889: GEODE-1993: refactor tests to use rules rather than abstract classes

2016-10-14 Thread Anthony Baker
Review board requests can be updated and you can see the changes between diffs. Anthony > On Oct 14, 2016, at 10:42 AM, Jared Stewart wrote: > > If we used github PRs instead of review board, your second set of changes > could show up in this same review request! > > >

Re: GEODE-1466: geode.properties

2016-10-13 Thread Anthony Baker
Hmmm, you would think it would be easier to change a file name :-) I don’t think we should be pushing destabilizing changes into a release branch. If the changes aren’t ready now we always pick them up for the next release. Anthony > On Oct 13, 2016, at 1:13 PM, Kirk Lund

Fwd: Build failed in Jenkins: Geode-nightly #621

2016-10-13 Thread Anthony Baker
Anyone know why this file was generated by the build? It shows up in the rat report. !? /home/jenkins/jenkins-slave/workspace/Geode-nightly/artifacts-jstewartgeode999/test/gemfire-jstewartgeode999-files.tgz Anthony > Begin forwarded message: > > From: Apache Jenkins Server

Re: Coding practices/standards

2016-10-12 Thread Anthony Baker
Source code with a consistent look-and-feel makes it easier for people to join the project community and contribute. Let’s continue to keep reformatting commits separate from logic changes—otherwise it’s too hard to review. Anthony > On Oct 12, 2016, at 10:06 AM, Dan Smith

Review Request 52700: Add more tests to flaky category based on recent CI failures

2016-10-10 Thread Anthony Baker
3451b51a16ec8a100d6e27096979dadf60cb5ed2 geode-wan/src/test/java/org/apache/geode/internal/cache/wan/concurrent/ConcurrentWANPropagation_1_DUnitTest.java e2461392e2b2e2d57b7d4fd78de19ca3de9abc38 Diff: https://reviews.apache.org/r/52700/diff/ Testing --- Thanks, Anthony Baker

Re: incubator-geode git commit: GEODE-1956: fix the race condition that cause the vm only hosts 1 primary bucket

2016-10-10 Thread Anthony Baker
Just reverted. Thanks for catching this Mark. Anthony > On Oct 10, 2016, at 11:26 AM, Mark Bretl wrote: > > Not sure why this got into master, but probably needs to be reverted. > > --Mark > -- Forwarded message -- > From: > Date:

Re: Review Request 52698: GEODE-1972: Move Geode Hibernate module to a feature branch

2016-10-10 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52698/#review152021 --- Ship it! Ship It! - Anthony Baker On Oct. 10, 2016, 5:36

Re: Review Request 52571: GEODE-1570: upgrade spring libraries

2016-10-06 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52571/#review151712 --- NOTICE changes look good! - Anthony Baker On Oct. 6, 2016, 6

Re: backward compatibility testing against GemFire 8.x WAN/clients

2016-10-05 Thread Anthony Baker
Given that the official Pivotal maven repo [1] is locked behind a login and a EULA I think this might not work so well. The license compatibility issues would need to be explored as well. How would you feel about testing backwards compatibility against 1.0.0-incubating.M3? Anthony [1]

Re: Assert usage in geode-core

2016-10-05 Thread Anthony Baker
Dan did some work on this: commit 71eb6bfbc429e7cc226671c99f682ec4fb31115d Author: Dan Smith Date: Fri Sep 23 16:40:15 2016 -0700 GEODE-1934: Removing spring-core dependencies from geode-core Remving the spring-core usage in geode-core classes that are not

Re: Limiting scope for Geode 1.0

2016-10-05 Thread Anthony Baker
>>>>> +1 for creating branch now to prevent feature creep. >>>>> >>>>> On Thu, Sep 29, 2016 at 2:10 PM Kirk Lund <kl...@apache.org> wrote: >>>>> >>>>>> I think we should propose creating that release branch sooner (now?) >

Re: Podling Report Reminder - October 2016

2016-10-05 Thread Anthony Baker
Looks good! I think the next step is uploading the report onto the wiki and getting mentor signoff. Anthony > On Oct 3, 2016, at 4:08 PM, Dan Smith wrote: > > Thanks Anthony and Swap! Updated draft: > > > Geode > > Geode is a data management platform

Re: Limiting scope for Geode 1.0

2016-10-04 Thread Anthony Baker
eep. >>>> >>>> On Thu, Sep 29, 2016 at 2:10 PM Kirk Lund <kl...@apache.org> wrote: >>>> >>>>> I think we should propose creating that release branch sooner (now?) >> so >>> we >>>>> can minimize unplanned change

Re: CI bugs

2016-10-04 Thread Anthony Baker
PM, Anthony Baker <aba...@pivotal.io> wrote: > > I reviewed a bunch of CI failures today. I closed out duplicates and added > the ‘CI’ label to JIRA tickets that were missing it. I just posted a big > review to add the FlakyTest category to bugs with non-reproducible > failure

Re: Podling Report Reminder - October 2016

2016-10-03 Thread Anthony Baker
Third? > On Oct 3, 2016, at 1:31 PM, Dan Smith wrote: > > - We had our fourth public release 1.0.0-incubating.M3 signature.asc Description: Message signed with OpenPGP using GPGMail

Re: Review Request 52468: Add FlakyTest category to tests with open bugs

2016-10-03 Thread Anthony Baker
r/52468/#review151189 --- On Oct. 2, 2016, 12:07 a.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Geode docs: location of donated source files

2016-10-01 Thread Anthony Baker
Did you mean a new top-level dir (e.g. geode-docs) or a subdir of geode-core? Since the docs could cover multiple components I’m not sure it makes sense to put them under geode-core. Anthony > > I think we should just go ahead and create a feature branch off of the the > current geode

CI bugs

2016-10-01 Thread Anthony Baker
I reviewed a bunch of CI failures today. I closed out duplicates and added the ‘CI’ label to JIRA tickets that were missing it. I just posted a big review to add the FlakyTest category to bugs with non-reproducible failures—pretty much any CI bug that is currently open. Your comments are

Review Request 52468: Add FlakyTest category to tests with open bugs

2016-10-01 Thread Anthony Baker
/TestRemoteClusterDUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/52468/diff/ Testing --- Thanks, Anthony Baker

Re: 1.0 release branch

2016-10-01 Thread Anthony Baker
Thanks Swapnil! I bumped the version on develop to 1.1.0-incubating. Can someone with JIRA karma could create the corresponding JIRA version? As we resolve issues on the develop branch we should set the Fix Version as 1.1.0-incubating. I also removed the -SNAPSHOT qualifier from the

[ANNOUNCE] Donation of Geode documentation

2016-09-29 Thread Anthony Baker
I am pleased to announce the donation of Geode documentation to the Geode community. The documentation provides a complete user guide for Geode. This donation includes the source necessary to build the documentation site currently hosted by Pivotal [1]. The documentation source has been converted

Re: Review Request 52410: GEODE-1949: Adding geode-rebalancer to the binary distribution

2016-09-29 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52410/#review150975 --- Ship it! Ship It! - Anthony Baker On Sept. 29, 2016, 10:56

Re: Previous versions dtds

2016-09-29 Thread Anthony Baker
have Internet access. The schema resolver first looks in the class path > then to the web. > > -Jake > > > On Thu, Sep 29, 2016 at 2:24 PM Anthony Baker <aba...@pivotal.io> wrote: > >> Any active dtd's or schema’s should be hosted near to >> http://geod

Re: Previous versions dtds

2016-09-29 Thread Anthony Baker
Any active dtd's or schema’s should be hosted near to http://geode.apache.org/schema/cache/. If you follow the directions [1] to update the website it’s not too hard. Can we remove the pivotal.io schema from source?

Re: Limiting scope for Geode 1.0

2016-09-29 Thread Anthony Baker
Using the gitflow approach, we cut a release/1.0.0 branch to isolate the release branch from ongoing development. For past releases we have waited as long as possible to cut the branch to minimize overhead. Perhaps this time we should create the branch earlier. JIRA shows the open issues for

Re: GEODE-1949 - Adding auto-balancer and spring-expression to geode-dependencies.jar

2016-09-29 Thread Anthony Baker
Looks like we’ve been including geode-rebalancer with the official source release, just not the binary convenience artifacts. +1 Anthony > On Sep 29, 2016, at 11:17 AM, Dan Smith wrote: > > Hi, > > The geode-rebalancer jar is not currently shipped with the geode binary.

Set the group on review requests

2016-09-29 Thread Anthony Baker
I was trying to trace the history of a git commit and realized something: if the group on a review request is not set to ‘geode’ the review information is not communicated to the dev list. This is really important because: a) a change is being proposed and all are invited to participate in

Re: From Incubation to TLP

2016-09-28 Thread Anthony Baker
://markmail.org/message/7qkbdjsrddtp6q7y > [3] http://markmail.org/message/fh4azdjqfhkdugpn > > Niall > > On Wed, Sep 28, 2016 at 5:41 PM, Anthony Baker <aba...@pivotal.io> wrote: > >> Hi Dor, >> >> Take a look at the maturity assessment for geode: >>

Re: Hibernate module and Geode 1.0 ?

2016-09-23 Thread Anthony Baker
Likewise! Geode provides an L2 cache for Hibernate. That is, an application that is using Hibernate could plug in Geode for caching. Specifically, we implement Hibernate’s cache interfaces like CacheProvider, RegionFactory, etc. There are build-time dependencies on several hibernate jars

Re: Build failed in Jenkins: Geode-spark-connector #78

2016-09-23 Thread Anthony Baker
Yep, I’m seeing failures on any client app that doesn’t explicitly include spring as dependency. Exception in thread "main" java.lang.NoClassDefFoundError: org/springframework/util/StringUtils at

Re: support for old clients

2016-09-23 Thread Anthony Baker
What about geode-client-support? Or geode-client-compatibility? I think that expresses intent to support backwards compatibility for prior client versions accordingly to the policies in the wiki [1]. Anthony [1] https://cwiki.apache.org/confluence/display/GEODE/Managing+Backward+Compatibility

Re: jvsd

2016-09-22 Thread Anthony Baker
When the first instruction is `git checkout feature/GEODE-78` I think it’s clear the target audience is not end users. Beyond that, it feels to early to document a feature whose final form may look significantly different than it does today. Anthony > On Sep 22, 2016, at 5:06 PM, Kirk Lund

Re: Hibernate module and Geode 1.0 ?

2016-09-22 Thread Anthony Baker
By remove, do you mean “put it on a feature branch awaiting contributions?” hibernate-3.5.5 was released in 2010 and has undergone significant changes since then. Seems reasonable to put this feature on hold until can be brought current. Anthony > On Sep 22, 2016, at 3:31 PM, Udo Kohlmeyer

Re: jvsd

2016-09-20 Thread Anthony Baker
Hi Gal, This page talks about the goals and status for jvsd: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61309918 Here’s another thread which discussed options for moving forward:

Re: Review Request 52019: GEODE-1513: Remove duplicate jars from war files

2016-09-20 Thread Anthony Baker
Diffs > - > > geode-assembly/build.gradle 3ed864ba5dd2e9589d5cb8313fe59747b76a91b0 > geode-pulse/build.gradle e53a698700f0de62088b3ac50cb96d4841315124 > geode-web-api/build.gradle 388dbba7c9c0bc9134dbd5818c49edb9d0eae7a6 > geode-web/build.gradle 75844d39678c5acc617e70f9cfa77c1049ca9d69 > > Diff: https://reviews.apache.org/r/52019/diff/ > > > Testing > --- > > > Thanks, > > Anthony Baker > >

Review Request 52076: GEODE-1511: Remove test dependencies from pom file

2016-09-19 Thread Anthony Baker
classpath. Diffs - gradle/publish.gradle 8a579c2f166d42d980fec9bf01a2ecb2364ddacf Diff: https://reviews.apache.org/r/52076/diff/ Testing --- Thanks, Anthony Baker

Re: M3 is out - New release manager for 1.0 ?

2016-09-19 Thread Anthony Baker
> On Sep 17, 2016, at 5:29 PM, Swapnil Bawaskar wrote: > > So, my proposal for issues to be targeted for 1.0 is: > GEODE-136 Fix possible NullPointerException in Gfsh's 'list regions' > command's GetRegionsFunction > GEODE-1466 Branding: rename gemfire.properties file to

Updated maturity assessment

2016-09-16 Thread Anthony Baker
I annotated the Geode podling maturity assessment to incorporate supporting details and references. Please review and let me know what you think. Thanks, Anthony [1] https://cwiki.apache.org/confluence/display/GEODE/Geode+Podling+Maturity+Assessment signature.asc Description: Message signed

Re: GEODE-37 (Hold your checkins in develop)

2016-09-14 Thread Anthony Baker
Thanks Hitesh! Are your changes available on a feature branch where we could review and comment? Anthony > On Sep 13, 2016, at 3:30 PM, Hitesh Khamesra > wrote: > > As part of GEODE-37, I am changing com.gemstone.gemfire package name to > org.apache.geode. >

Re: M3 is out - New release manager for 1.0 ?

2016-09-09 Thread Anthony Baker
Thanks for starting this thread. There are a few recent conversations on this topic [1][2]. My thought is that we should bear down and focus on the issues that help geode become “graduation-ready”. Here’s a candidate list: v1.0.0-incubating: - GEODE-37 (package renaming) GEODE-1791

Re: securing geode components

2016-09-09 Thread Anthony Baker
If we are protecting resources >> (CLUSTER and DATA), it should be protected no matter which way user is >> trying to access it. I guess I'll leave this to the PMs to decide. >> >> On Thu, Sep 8, 2016 at 7:37 PM, Anthony Baker <aba...@pivotal.io> wrote: >>

Re: Review Request 51728: GEODE-1570: upgrade spring libraries and fix tests

2016-09-08 Thread Anthony Baker
> On Sept. 8, 2016, 8:49 p.m., Anthony Baker wrote: > > -1 Need to update LICENSE files (both in root and in geode-assembly) with > > version changes. Can you also describe how the library updates are needed > > for the security work? I couldn't make that con

Re: json-path-assert for json related unit tests

2016-09-08 Thread Anthony Baker
Speaking of jackson, anyone know why we’re not using v2.2.0 for the scala module? This is a dependency of geode-web-api. jackson.version = 2.2.0 jackson-module-scala_2.10.version = 2.1.5 Anthony > On Sep 8, 2016, at 10:32 AM, John Blum wrote: > > +1 to standardizing Geode

Review Request 51549: GEODE-1809: Improve error handling

2016-08-30 Thread Anthony Baker
8369d1fc4da8337edb9f27e822f955dba154f3c6 Diff: https://reviews.apache.org/r/51549/diff/ Testing --- Thanks, Anthony Baker

Review Request 51380: GEODE-1809: Refactor GemFireVersion

2016-08-24 Thread Anthony Baker
/internal/GemFireVersionJUnitTest.java fc4ab1b3c1c46bcb5c8f0e66f64c926fc37db789 geode-core/src/test/java/com/gemstone/gemfire/internal/VersionJUnitTest.java PRE-CREATION Diff: https://reviews.apache.org/r/51380/diff/ Testing --- Thanks, Anthony Baker

Re: Brew formulae for geode

2016-08-24 Thread Anthony Baker
Bumping this old thread: I’ve updated the brew formula with the 1.0.0-incubating.M3 release and renamed it to apache-geode. `brew install apache-geode` Anthony > On Apr 27, 2016, at 6:51 AM, Anthony Baker <aba...@pivotal.io> wrote: > > There’s a clarification thread here [1].

[ANNOUNCE] Apache Geode 1.0.0-incubating.M3 released

2016-08-23 Thread Anthony Baker
The Apache Geode team is proud to announce Apache Geode release 1.0.0-incubating.M3. Apache Geode (incubating) is a data management platform that provides a database-like consistency model, reliable transaction processing and a shared-nothing architecture to maintain very low latency performance

Re: M3 vs. M2 dependencies

2016-08-22 Thread Anthony Baker
I think the findbugs-annotations dependency can be optional—we don’t need to ship this jar with the binary distribution. Anthony > On Aug 22, 2016, at 5:38 PM, Dan Smith wrote: > > I was comparing our required dependencies of geode-core for the M3 vs. M2 > release (Anything

Re: Review Request 51308: GEODE-1811: Marking runtime dependencies as optional in the pom

2016-08-22 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51308/#review146460 --- Ship it! Ship It! - Anthony Baker On Aug. 23, 2016, 12:13

Re: Trying to upgrade spring-security

2016-08-16 Thread Anthony Baker
Not sure if this is related to your error, but it looks like that version of spring-security would at least require moving to spring framework 4.3.1 and possibly more dep updates as well. You should be able to run some gradle commands (dependencies, dependencyInsight, dumpDependencies) to help

Re: Experimental features for 1.0

2016-08-11 Thread Anthony Baker
I think that is the relevant point. We are making releases from develop, not from WIP branches. @John, HDFS was moved to a WIP branch. Anthony > On Aug 11, 2016, at 9:31 AM, Kirk Lund wrote: > > JVSD is not on develop, so maybe not. We probably only need to annotate and >

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-05 Thread Anthony Baker
+1 * Verified she’s * Verified signatures * Verified tag signature * Build from tag * Build and run from src distro * Checked src distro for binaries * Run from binary distro * Run some examples from mvn repo Anthony > On Aug 5, 2016, at 10:34 AM, Jason Huynh wrote: > > +1

GEMFIRE env var

2016-08-02 Thread Anthony Baker
I was looking at the geode-assembly build script and noticed this: tasks.withType(Test){ environment 'GEMFIRE', "$buildDir/install/${distributions.main.baseName}/lib” } … // Create a configuration closure to configure test targets with the install directory def dependOnInstalledProduct = {

Re: Review Request 50604: GEODE-1666: Bump Gradle from 2.12 to 2.14

2016-08-01 Thread Anthony Baker
in gradle.properties? - Anthony Baker On July 29, 2016, 2:50 p.m., Jens Deppe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC6

2016-07-28 Thread Anthony Baker
The failure is due to a build ordering issue, not a product or test bug. Let’s pull in the fix and respin. If you do see an issue please speak up ASAP so we get this release out. Thanks, Anthony > On Jul 28, 2016, at 2:58 PM, Darrel Schneider wrote: > > flaky tests

Re: Build failed in Jenkins: Geode-nightly #543

2016-07-28 Thread Anthony Baker
300M seems like a lot for a dunit test. Anthony > On Jul 28, 2016, at 9:28 AM, Apache Jenkins Server > wrote: > >Caused by: >java.lang.OutOfMemoryError: Failed creating 314572800 bytes of > off-heap memory during cache creation. signature.asc

Re: Review Request 50522: GEODE-64: Add SonarQube Plugin And Initial Configuration

2016-07-27 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50522/#review143845 --- Ship it! Ship It! - Anthony Baker On July 27, 2016, 6:10

Re: Review Request 50462: GEODE-1385: mark testShutDownForTIMEOUT with FlakyTest category

2016-07-26 Thread Anthony Baker
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50462/#review143613 --- Ship it! Ship It! - Anthony Baker On July 26, 2016, 8:53

Re: Build failed in Jenkins: Geode-nightly #541

2016-07-26 Thread Anthony Baker
Doh! Thanks for catching that one. Anthony > On Jul 26, 2016, at 1:48 PM, Bruce Schuchardt <bschucha...@pivotal.io> wrote: > > I think I have it fixed. It needs to have "flakyTests > dependsOnInstalledProduct" > > Le 7/26/2016 à 1:43 PM, Anthony Bake

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

2016-07-26 Thread Anthony Baker
> On July 26, 2016, 5:02 p.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? > > Anthony Baker wrote: > A

Re: Build failed in Jenkins: Geode-nightly #541

2016-07-26 Thread Anthony Baker
This stuff in geode-assembly/build.gradle configures tests that run in the assembly subproject: test { // test from the actual classpath not the gradle classpath dependsOn installDist // @TODO: this doesn't seem to be working need to get basename first. classpath += files

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

2016-07-26 Thread Anthony Baker
> On July 26, 2016, 5:02 p.m., Dan Smith wrote: > > Looks good - but this does mean that the build id will always be 0 unless > > someone sets it, whereas before it was the current date. Will that be an > > issue? > > Anthony Baker wrote: > A

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

2016-07-26 Thread Anthony Baker
On July 26, 2016, 4:56 p.m., Anthony Baker wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50436/ > -

Re: Review Request 50436: GEODE-1695: Parameterize build metadata

2016-07-26 Thread Anthony Baker
4acb4da8a8a3da686d6ba10a8a8d57ac7fa375be Diff: https://reviews.apache.org/r/50436/diff/ Testing --- Thanks, Anthony Baker

Re: [GitHub] incubator-geode pull request #199: GEODE-88: code fixes for c++ client

2016-07-26 Thread Anthony Baker
Based on my reading of [1] and [2] I don’t think the comment is necessary and should be removed. Any other opinions? Anthony [1] http://www.apache.org/legal/src-headers.html [2] http://www.apache.org/dev/apply-license.html#contributor-copyright > On Jul 26, 2016, at 12:38 AM, doribd

Review Request 50436: GEODE-1695: Parameterize build metadata

2016-07-25 Thread Anthony Baker
0fa3765d1b49b7c7f193d8fcb05c328e594a3f11 gradle/java.gradle 4acb4da8a8a3da686d6ba10a8a8d57ac7fa375be Diff: https://reviews.apache.org/r/50436/diff/ Testing --- Thanks, Anthony Baker

Re: Unit testing classes that depend on static collaborators

2016-07-20 Thread Anthony Baker
Great discussion! I’ve got two questions: 1) What do you think of Bytes.java (:geode-core:com.gemstone.gemfire.internal.util)? Is it a reasonable use of the Helper / Utility class pattern? If not, how would you change it? Creating a new instance for each use seems inefficient and using a

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC3

2016-07-19 Thread Anthony Baker
release/1.0.0-incubating.M3 > On Jul 19, 2016, at 10:10 AM, Kirk Lund wrote: > > I'll take a look at ConsoleDistributionManagerDUnitTest. What's the branch > name I need to checkout? > > -Kirk > > > On Sun, Jul 17, 2016 at 10:03 PM, William Markito >

Re: test failures on develop

2016-07-18 Thread Anthony Baker
Thanks for the quick update! > On Jul 18, 2016, at 11:14 AM, Jinmei Liao <jil...@pivotal.io> wrote: > > I'll revert it. I ran precheckin on concourse, and it doesn't show me that > failure Maybe I wasn't doing it right...? > > On Mon, Jul 18, 2016 at 11:0

test failures on develop

2016-07-18 Thread Anthony Baker
I’m seeing some unit test failures on the head of /develop: :geode-core:test com.gemstone.gemfire.distributed.internal.membership.gms.auth.GMSAuthenticatorJUnitTest > testGetCredentialNormal FAILED com.gemstone.gemfire.security.GemFireSecurityException: java.lang.IllegalAccessException:

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC2

2016-07-15 Thread Anthony Baker
My bad. Fixed. Anthony > On Jul 15, 2016, at 1:20 PM, Dan Smith wrote: > > -0 > > The gradle wrapper in the source distribution is now broken. I filed > GEODE-1668. I think we probably should fix that and roll another RC, but I > suppose we could also just include a

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC2

2016-07-14 Thread Anthony Baker
+1 + Verified tag signature, built from tag + Checked hashes and signature + Built from source distribution + Ran from binary distribution + Reviewed maven repo + Ran replication example (after modifying geode version / maven url) + Checked against a few sample apps [1] [2] + Reviewed changes in

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3

2016-07-14 Thread Anthony Baker
Fixed GEODE-1664 and GEODE-1665. Let's cancel this vote and move on to RC2. Anthony > On Jul 13, 2016, at 9:31 PM, Anthony Baker <aba...@pivotal.io> wrote: > > geode-assembly/src/main/dist/LICENSE changes needed: > > 1) Add aopalliance 1.0 (public domain) > 2) Update

Review Request 50043: GEODE-1665: Remove bundled jar from source distribution

2016-07-14 Thread Anthony Baker
/r/50043/diff/ Testing --- Thanks, Anthony Baker

  1   2   3   4   >