Re: Review Request 53596: GEODE-1808 Remove broken check for jdk1.7.0_72

2016-11-09 Thread anilkumar gingade
> On Nov. 9, 2016, 5:36 p.m., anilkumar gingade wrote: > > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java, > > line 1189 > > <https://reviews.apache.org/r/53596/diff/1/?file=1558982#file1558982line1189> > > > > Th

Re: Review Request 53596: GEODE-1808 Remove broken check for jdk1.7.0_72

2016-11-09 Thread anilkumar gingade
/GemFireCacheImpl.java <https://reviews.apache.org/r/53596/#comment225432> This is verifying java version when cache is getting created and warns the user if its not compatible version...I think we should keep this instead of removing it... - anilkumar gingade On Nov. 9, 2016, 5:08 a.m., A

Re: Review Request 53442: GEODE-1740: Correct potential region inconsistencies with concurrent clear and transaction commit

2016-11-07 Thread anilkumar gingade
/TXState.java (line 514) <https://reviews.apache.org/r/53442/#comment225040> What if one of the region is destroyed while iterating over the regions? Can we still operate on version vector (in lockRegionForAtomicTX())...Do we need to have some error handlling code? - anilkumar gingade On

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

2016-11-04 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53355/#review154953 --- Ship it! Ship It! - anilkumar gingade On Nov. 4, 2016, 5:58

Review Request 53410: GEODE-2064 Added check for system shutdown while handlling connect exception.

2016-11-02 Thread anilkumar gingade
/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java bae1ddc Diff: https://reviews.apache.org/r/53410/diff/ Testing --- Added new unit test. Verified the test without my change and with the change. With change test looks for DistributedSystemDisconnectedException to be thrown. Thanks, anilkumar gingade

Re: Review Request 53355: fix deadlock caused by how the GemFireCacheImpl class synchronization is done

2016-11-02 Thread anilkumar gingade
after the create is completed. This will impact all the methods calling "isCacheAtShutdownAll". - anilkumar gingade On Nov. 1, 2016, 11:25 p.m., Darrel Schneider wrote: > > --- > This is an automatically generat

Re: Backwards compatibility for 1.1

2016-11-02 Thread Anilkumar Gingade
Right, to be enterprise class software product, it needs to be backward compatible...We also need to consider rolling upgrade of the system Thanks, Dan, Bruce for the write-up and frame-work... -Anil. On Wed, Nov 2, 2016 at 10:37 AM, William Markito Oliveira < william.mark...@gmail.com>

Re: [DISCUSS] Graduation

2016-10-31 Thread Anilkumar Gingade
+1 On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre wrote: > +1 > > On Sat, Oct 29, 2016 at 8:40 AM, yang theseus > wrote: > > > +1! > > > > 2016-10-28 7:07 GMT+08:00 Nitin Lamba : > > > > > +1! > > > > > > On Wed, Oct 26, 2016 at

Re: [97/98] [abbrv] incubator-geode git commit: GEODE-2043: change makeTombstone to handle exception

2016-10-28 Thread Anilkumar Gingade
I am seeing build failures with: *** FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':geode-core:spotlessJavaCheck'. > Format violations were found. Run 'gradlew spotlessApply' to fix them.

Re: [ANNOUNCE] Donation of Geode documentation

2016-10-24 Thread Anilkumar Gingade
I don't see any "search" option with docs? Did we miss it... http://geode.incubator.apache.org/docs/guide/about_geode.html -Anil. On Thu, Sep 29, 2016 at 8:27 PM, Anthony Baker wrote: > I am pleased to announce the donation of Geode documentation to the > Geode community.

Re: Review Request 53071: GEODE-2021: Get on non colocated keys in a transaction does not throw TransactionDataNotColocatedException

2016-10-21 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53071/#review153568 --- Ship it! Ship It! - anilkumar gingade On Oct. 21, 2016, 5

Re: Review Request 52891: GEODE-538: Add check for persistent data recovery

2016-10-18 Thread anilkumar gingade
/apache/geode/cache/query/Query.java (line 92) <https://reviews.apache.org/r/52891/#comment222410> Wemay have to add this to other flavors of execute(*)... - anilkumar gingade On Oct. 17, 2016, 11:15 p.m., Ken Howe

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Anilkumar Gingade
+1 for release... On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade <aging...@pivotal.io> wrote: > Hi Karen, > > The fix still keeps the doc stating: > "a client will need to set its credential, composed of the two properties > `security-username` and `security-

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating - RC2

2016-10-17 Thread Anilkumar Gingade
Hi Karen, The fix still keeps the doc stating: "a client will need to set its credential, composed of the two properties `security-username` and `security-password`." What i see is, additional doc about setting the auth properties using callbacks Am i missing anything? -Anil. On Mon,

Re: Review Request 52891: GEODE-538: Add check for persistent data recovery

2016-10-17 Thread anilkumar gingade
- > > (Updated Oct. 14, 2016, 10:39 p.m.) > > > Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu, > Scott Jewell, and Dan Smith. > > > Repository: geode > > > Description > --- > > PartitionedRegion.getNodeForB

Re: Review Request 52619: GEODE-1967 Old key are not removed from the removedKeyValuesEntries after it was removed from Compact Range Indexes

2016-10-07 Thread anilkumar gingade
/index/CompactMapRangeIndex.java (line 144) <https://reviews.apache.org/r/52619/#comment220471> Is this safe to remove entry here...The backing map looks like just hash map (not concurrent)... - anilkumar gingade On Oct. 7, 2016, 5:48 p.m., nabarun nag

Re: Limiting scope for Geode 1.0

2016-10-05 Thread Anilkumar Gingade
If fixing flaky tests are not in the release plan, its a good idea to move this from release job...As you said it helps to keep the run clean and makes it easy to track unexpected failures. -Anil. On Wed, Oct 5, 2016 at 2:58 PM, Swapnil Bawaskar wrote: > Some of tests

Re: Review Request 51875: GEODE-1885: Removed call to check readiness (region check) after the offheap region entry is released.

2016-09-15 Thread anilkumar gingade
g/r/51875/#review148993 --- On Sept. 14, 2016, 12:22 a.m., anilkumar gingade wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 51831: change EntryEventImpl code that does instanceof StoredObject checks

2016-09-15 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51831/#review149101 --- Ship it! Ship It! - anilkumar gingade On Sept. 14, 2016, 10

Review Request 51875: GEODE-1885: Removed call to check readiness (region check) after the offheap region entry is released.

2016-09-13 Thread anilkumar gingade
/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java 08953d5 Diff: https://reviews.apache.org/r/51875/diff/ Testing --- Reproduced the missing create event with the submitted test. And verified with the fix. pre-checkin. Thanks, anilkumar gingade

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
71614#file1471614line189> > > > > Will this dir and clusterConfigDir get cleaned up after the test is > > run? Should this use a TemporaryFolder rule or something else? > > anilkumar gingade wrote: > It uses the TemporaryFolder...yes it clears the config dir...Without th

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-12 Thread anilkumar gingade
71614#file1471614line189> > > > > Will this dir and clusterConfigDir get cleaned up after the test is > > run? Should this use a TemporaryFolder rule or something else? > > anilkumar gingade wrote: > It uses the TemporaryFolder...yes it clears the config dir...Without th

Re: Review Request 51010: GEODE-11 Test for Cluster Configuration changes for Lucene index.

2016-08-11 Thread anilkumar gingade
ir...Without this i was having problem with the second test, where it was loading the cluster config from previous test... - anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51010/#review145572

Re: Review Request 50962: GEODE-1742: Fixing synchronization of cqListeners in CqAttributesImpl

2016-08-10 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50962/#review145401 --- Ship it! Ship It! - anilkumar gingade On Aug. 10, 2016, 6

Re: Review Request 50903: GEODE-1583: Always pass the keep alive flag when destroying a connection

2016-08-10 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50903/#review145399 --- Ship it! Ship It! - anilkumar gingade On Aug. 10, 2016, 8

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3 - RC7

2016-08-08 Thread Anilkumar Gingade
+1 On Mon, Aug 8, 2016 at 5:12 PM, Kirk Lund wrote: > +1 > > - built and ran unit tests > - started GFSH > - launched Locator and Server > > -Kirk > > On Monday, August 8, 2016, Swapnil Bawaskar wrote: > > > +1 > > > > - compiled from source > > -

Re: Review Request 50903: GEODE-1583: Always pass the keep alive flag when destroying a connection

2016-08-08 Thread anilkumar gingade
on why destroy is called here...If thats not the case (the close doesn;t take long time) then its fine... - anilkumar gingade On Aug. 8, 2016, 6:02 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 50538: GEODE-1619 PartitionedRegionSingleHopWithServerGroupDUnitTest.test_SingleHopWithServerGroupTwoClientServerGroup

2016-07-27 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50538/#review143848 --- Ship it! Ship It! - anilkumar gingade On July 27, 2016, 10

Re: Review Request 50361: GEODE-1687: NPE during CqStatusListener method invocation.

2016-07-26 Thread anilkumar gingade
en initialized at this time... - anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50361/#review143288 ------- On July

Review Request 50361: GEODE-1687: NPE during CqStatusListener method invocation.

2016-07-22 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50361/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh

Re: Review Request 50089: GEODE-1669: Performance issue with Interest registration with impact on client side event processing

2016-07-19 Thread anilkumar gingade
dd2 Diff: https://reviews.apache.org/r/50089/diff/ Testing --- Thanks, anilkumar gingade

Re: Recovering large data for persisted regions

2016-07-15 Thread Anilkumar Gingade
Nilkanth, One reasons I can think of; during recovery system may be consuming more memory than (during the shutdown); the reason could be relating to how data is recovered from the disk (reading krf, drf files first, and then crf files)...The memory may be used up by the data-structures that are

Re: Review Request 50089: GEODE-1669: Performance issue with Interest registration with impact on client side event processing

2016-07-15 Thread anilkumar gingade
Your suggestion looks much better...I will make those changes... - anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50089/#review142456 --------

Review Request 50089: GEODE-1669: Performance issue with Interest registration with impact on client side event processing

2016-07-15 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50089/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt

Re: [VOTE] Release Apache Geode (incubating) 1.0.0-incubating.M3

2016-07-13 Thread Anilkumar Gingade
+1 - One more milestone... -Anil. On Wed, Jul 13, 2016 at 10:39 AM, William Markito wrote: > All, > > This is the first release candidate Apache Geode, version > 1.0.0-incubating.M3. > Thanks to all the community members to drive towards this milestone! > > It fixes the

Re: Review Request 49904: GEODE-1644 ClassCastException is thrown with in queries against a map index

2016-07-11 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49904/#review141776 --- Ship it! Ship It! - anilkumar gingade On July 11, 2016, 5

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-07-07 Thread anilkumar gingade
again... - anilkumar gingade On July 6, 2016, 8:42 p.m., Jason Huynh wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Valid characters in region names?

2016-06-30 Thread Anilkumar Gingade
Here is what GemFire docs states about region names: http://gemfire.docs.pivotal.io/docs-gemfire/latest/basic_config/data_regions/region_naming.html But again, we have supported other chars as part of region names... The Query engine allows/detects region name with: "_", “+”, “-“, “:”, “#”,

Re: Review Request 49102: WAN Ack reader thread needs to be shut down before sending a close connection

2016-06-29 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49102/#review140051 --- Ship it! Nice to have unit test for this. - anilkumar gingade

Re: Review Request 48757: GEODE-11: Cleaning up old IndexRepositoryImpls when buckets move

2016-06-23 Thread anilkumar gingade
ds can still execute this concurrently...Will that be an issue? - anilkumar gingade On June 21, 2016, 5:40 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 48889: GEODE-1493: config/gemfire.properties that is shipped with the geode distribution contains user specific info

2016-06-20 Thread anilkumar gingade
, it may affect existing customers/users... The bug title talks about user specific info, are these changes related...Sorry i was unable to access the ticket... - anilkumar gingade On June 17, 2016, 11:48 p.m., Sai B

Re: Some proposed changes to the geode lucene search API

2016-06-20 Thread Anilkumar Gingade
+1 To be clear we are removing "search()" and replacing this with methods that reflect the return types... E.g: findKeys() - Returns only the region keys for matched query. This provides applications flexibility of working with only keys or to fetch region values as required. -Anil. On Mon,

Re: Review Request 48865: GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events (by setting the flag forwardExpirationDestroy()).

2016-06-17 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48865/ --- (Updated June 17, 2016, 6:53 p.m.) Review request for geode, anilkumar gingade

Re: update website for WAN, CQ and native client

2016-06-17 Thread Anilkumar Gingade
John is Right...WAN is more than just a replication of data...In order to highlight and meaningful we have described this as Muti Site (WAN) Topology in GemFire docs... -Anil. On Fri, Jun 17, 2016 at 11:15 AM, Swapnil Bawaskar wrote: > Well, you can can replicate

Review Request 48865: GEODE-11: Added changes to Lucene AEQ, to propagate expiration destroy events (by setting the flag forwardExpirationDestroy()).

2016-06-17 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48865/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh

Re: Review Request 48757: GEODE-11: Cleaning up old IndexRepositoryImpls when buckets move

2016-06-15 Thread anilkumar gingade
/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java (line 139) <https://reviews.apache.org/r/48757/#comment203083> Synchronization...To avoid multiple threads creating the repo. - anilkumar gingade On June 15, 2016, 9:36 p.m., Dan Smith

Re: Review Request 48738: GEODE-1209 Changes to ignoreEvictionAndExpiration AEQ attribute based on the new proposal (changing ignoreEvictionAndExpiration to forwardExpirationDestroy)

2016-06-15 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48738/ --- (Updated June 15, 2016, 5:42 p.m.) Review request for geode, anilkumar gingade

Review Request 48738: GEODE-1209 Changes to ignoreEvictionAndExpiration AEQ attribute based on the new proposal (chagning ignoreEvictionAndExpiration to forwardExpirationDestroy)

2016-06-15 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48738/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider

Re: Review Request 48432: GEODE-1494: Allowing stats to be measured with callbacks

2016-06-10 Thread anilkumar gingade
main/java/com/gemstone/gemfire/internal/StatSamplerStats.java (line 69) <https://reviews.apache.org/r/48432/#comment202199> Good one... - anilkumar gingade On June 9, 2016, 6:41 p.m., Dan Smith wrote: > > --- > This i

Re: Review Request 48525: GEODE-1422: Removing check to skip enqueuing temp events

2016-06-10 Thread anilkumar gingade
/gemstone/gemfire/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java (line 112) <https://reviews.apache.org/r/48525/#comment202191> Something may be wrong with our IDE formatters, they are adding spaces with new line...I did see this with my eclipse IDE... - anilkumar g

Re: add 'ZeroCopy' functions into geode

2016-06-09 Thread Anilkumar Gingade
As i know we try to avoid copying as much as possibleWhen we read from socket to storing in cache...Its mostly the reference pointer that is passed around...Someone can correct me if i am wrong I am interested to see how adopting techniques to reduce cache-miss rates (L1/L2) will help

Re: Review Request 48431: GEODE-1494: Changing stats list to be a CopyOnWriteArrayList

2016-06-08 Thread anilkumar gingade
as we talked in our meeting, these are legacy code refactoring...We need to do it step by step :) - anilkumar gingade On June 8, 2016, 6:06 p.m., Dan Smith wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: new wiki content

2016-06-07 Thread Anilkumar Gingade
Agree with Dan, its more about troubleshooting/fixing issue. Will it be a good idea to organize them as: Troubleshooting: - When system encounters OOM - When critical heap... When i read it as design, i was expecting, system design instruction based on certain requirement. Just my thoughts...

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-06 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/ --- (Updated June 6, 2016, 8:26 p.m.) Review request for geode, anilkumar gingade

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-03 Thread anilkumar gingade
anilkumar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/#review136116 --- On June 3, 2016, 12:49 a.m., anilkumar ging

Re: Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-03 Thread anilkumar gingade
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/#review136115 ------- On June 3, 2016, 12:49 a.m., anilkumar gingade wrote: > > --

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-03 Thread Anilkumar Gingade
> *I will wait for other feedbacks/comments, if there is no objection i > willchange it to "forwardExpirationDestroy" with default value set to > true.* > > think you meant to say default value to set false :-) > > On Fri, Jun 3, 2016 at 11:47 AM, Anilkumar Gingade <

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-03 Thread Anilkumar Gingade
> property to be false. That was the case when it was forwardXXX. But now > that it has changed to ignoreXXX the default has become true. I'd vote for > it being named something whose default can be false. > > > On Thu, Jun 2, 2016 at 11:10 AM, Anilkumar Gingade <aging...@pivotal.io> > w

Re: build error with development branch...

2016-06-02 Thread Anilkumar Gingade
ss build? I would recommend >> running with a later version of java 8. >> >> -Dan >> >> On Thu, Jun 2, 2016 at 2:41 PM, Anilkumar Gingade <aging...@pivotal.io> >> wrote: >> >> If gradle is using the java installed/set in my environment, then it is: >&

Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).

2016-06-02 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47686/#review134641 ------- On May 24, 2016, 12:05 a.m., anilkumar gingade wrote: > >

Review Request 48188: GEODE-1495: Changes are made to remove the cached destroyed token/events from the CQ.

2016-06-02 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48188/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt

Re: build error with development branch...

2016-06-02 Thread Anilkumar Gingade
ormally, it could be either a > callable or a runnable. > > What JDK and what revision are you building with? Maybe some newer JDK is > complaining about this? > > -Dan > > -Dan > > On Thu, Jun 2, 2016 at 1:58 PM, Anilkumar Gingade <aging...@pivotal.io> &g

build error with development branch...

2016-06-02 Thread Anilkumar Gingade
Hi Devs, Anyone seeing this issue: :geode-core:compileTestJava/export/india1/users/agingade/src/gemfire/open/geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java:62: error: reference to invokeAsync is ambiguous AsyncInvocation vm1Invoke =

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-06-02 Thread Anilkumar Gingade
ExpirationDestroy"... Currently we are planning to support "ignoreExpirationDestroy", and add "ignoreEvictionDestroy" once GEODE-1472 is fixed... Looking for comments on this... Thanks, -Anil. https://issues.apache.org/jira/browse/GEODE-1472 On Tue, Apr 12, 2016 at 6:0

Re: Review Request 47803: field value could be null, need to handle this case

2016-05-25 Thread anilkumar gingade
looks like there is a ISNULL option in Lucene, we need to invistage to see how we can store null and allow users to query null values... https://forums.alfresco.com/forum/developer-discussions/other-apis/solved-empty-or-null-description-lucene-query-05052014-1521 - anilkumar gingade On

Re: Index management

2016-05-23 Thread Anilkumar Gingade
Agree The indexes are operated using api/xml at a peer/server node level; there is no client-server index operation command; one reason index destroy is supported on member, to simulate what api is supported...As you mentioned it may not make sense to have it from Gfsh. -Anil. On Mon, May

Re: Review Request 47686: GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).

2016-05-23 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47686/ --- (Updated May 24, 2016, 12:05 a.m.) Review request for geode, anilkumar gingade

Review Request 47686: GEODE-11: Added changes to Lucene AEQ, to propagate destroy events due to eviction and expiration (by setting the flag ignoreEvictionAndExpiration()).

2016-05-20 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47686/ --- Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan

Write up on adding Gfsh commands.

2016-05-20 Thread Anilkumar Gingade
Hi Team, I have created wiki on adding new gfsh command. If you have any additional information or additional comments, please add it to the wiki page or let me know. https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+commands Thanks, -Anil.

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

2016-05-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47615/ --- (Updated May 19, 2016, 10:54 p.m.) Review request for geode, anilkumar gingade

Re: Review Request 47606: GEODE-1412: ignore-eviction-expiration flag was not used in the http controller

2016-05-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47606/#review134061 --- Ship it! Ship It! - anilkumar gingade On May 19, 2016, 5:14

Re: Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that b

2016-05-19 Thread anilkumar gingade
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47615/#review134056 --- On May 19, 2016, 9:47 p.m., anilkumar gingade wrote: > > -

Review Request 47615: GEODE-988: Added wait for events to arrive on stopped CQ before it is stopped. The test stops the CQ and verifies no events are recieved in stopped state; it was doing that by ch

2016-05-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47615/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider

Re: [ANNOUNCE] Donation of GemFire native client code

2016-05-19 Thread Anilkumar Gingade
Thats a great newsIt opens up all our client code accessible to community... -Anil. On Thu, May 19, 2016 at 8:56 AM, Anthony Baker wrote: > I am pleased to announce the donation of additional GemFire client drivers > to the Geode community. This source code donation

Re: would anyone mind if I...

2016-05-18 Thread Anilkumar Gingade
+1 I am assuming there will be some marking between two cache instances... Do they include xml and properties info too? if so it will be nice to have some way to print those during debugging... -Anil. On Wed, May 18, 2016 at 3:12 PM, Bruce Schuchardt wrote: > Would

Re: Review Request 47496: Adding transaction tests for lucene indexes

2016-05-17 Thread anilkumar gingade
306) <https://reviews.apache.org/r/47496/#comment198233> How about moving these puts into region initialization method? - anilkumar gingade On May 17, 2016, 10:54 p.m., Jason Huynh wrote: > > --- > This is an automatically

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-16 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46243/ --- (Updated May 16, 2016, 11 p.m.) Review request for geode, anilkumar gingade

Re: Review Request 47004: a quick solution to wait for entry flushed into index

2016-05-16 Thread anilkumar gingade
lieve in our group session we passed two arguments. 1. Max wait time 1. Unit of sleep (iunstead of hard coded 200 mili sec) - anilkumar gingade On May 16, 2016, 5:39 a.m., xiaojian zhou wrote: > > --- > This is an automatically genera

Re: Review Request 47378: GEODE-11: Split out lucene tests of persistence and off heap

2016-05-16 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47378/#review133389 --- Ship it! Ship It! - anilkumar gingade On May 14, 2016, 12

Review Request 47372: GEODE-1209: Added gfsh support to set ignoreEvictionAndExpiration attribute for create AEQ command.

2016-05-13 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47372/ --- Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider

Re: Review Request 47253: GEODE-430: Fixing races in UpdatePropegationDUnitTest

2016-05-12 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47253/#review132966 --- Ship it! Ship It! - anilkumar gingade On May 11, 2016, 8:11

Re: Review Request 47276: GEODE-1381: Tests of indexes on regions with overflow, eviction, expiration

2016-05-12 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47276/#review132965 --- Ship it! Ship It! - anilkumar gingade On May 12, 2016, 12

Re: Review Request 47220: This is bug in test code

2016-05-11 Thread anilkumar gingade
test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java (line 83) <https://reviews.apache.org/r/47220/#comment196964> From the above it looks like we are not sure which one is the primary queue server...Are we expecting to close primary queue server or any s

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-05 Thread anilkumar gingade
> > > This is not a unit test if it's creating a cache. Should be marked as > > an integration test. You are right, i will change this as integration test. - anilkumar --- This is an automatically generated e-mail. T

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-05 Thread anilkumar gingade
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46243/#review129453 ------- On May 6, 2016, 12:45 a.m., anilkumar gingade wrote: > > --- > This is a

Re: Review Request 46916: GEODE-641: Adding default methods to the Function interface

2016-05-05 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46916/#review131934 --- Ship it! Ship It! - anilkumar gingade On May 2, 2016, 10:55

Re: Review Request 46243: GEODE-1209: Added new attribute to forward eviction/expiration to AEQ. Tested with manual testing.

2016-05-03 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46243/ --- (Updated May 4, 2016, 1:09 a.m.) Review request for geode, anilkumar gingade

User Defined Aggregate (UDA) function support in Geode OQL

2016-04-27 Thread Anilkumar Gingade
Hi Geode Devs, To enhance Geode query functionalities; we had started initiative to support Aggregate and UDA functionalities using a common frame work. The spec for this can be found at: https://cwiki.apache.org/confluence/display/GEODE/OQL+Aggregate+functions+and+UDA As part of first phase

Its been a year....

2016-04-27 Thread Anilkumar Gingade
Hi Geode, Thought of sharing this milestone... Wow...Its been a year...In last year ApacheCON (Apr 2015) we announced open sourcing Geode, we made the Geode source available to the Apache community...Its been a great journey from that point... The geode community is growing and contributing to

Re: Review Request 46625: when there're multiple cache servers on the same jvm, keep the first proxy for the each client

2016-04-25 Thread anilkumar gingade
server (and there are multiple servers running on this JVM) - anilkumar gingade On April 25, 2016, 6:01 a.m., xiaojian zhou wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: M2 release update

2016-04-22 Thread Anilkumar Gingade
Great... Thanks Dan; for being the release manager and successfully getting the release out...good work... -Anil. On Fri, Apr 22, 2016 at 11:24 AM, Dan Smith wrote: > Quick update on the M2 release. It passed the vote on the incubator general > list, we're just working on

Re: Review Request 46354: GEODE-1072: Removing HDFS related code

2016-04-19 Thread anilkumar gingade
(line 1147) <https://reviews.apache.org/r/46354/#comment193125> Is this HDFS/custome eviction specific? - anilkumar gingade On April 19, 2016, 12:35 a.m., Dan Smith wrote: > > --- > This is an automatically generated e-

Re: Review Request 46356: GEODE-978: Increasing the port range used in CacheXmlGateway tests

2016-04-19 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46356/#review129571 --- Ship it! Ship It! - anilkumar gingade On April 19, 2016, 12

Re: Review Request 46239: UnitTest for LuceneIndexForPartitionedRegion

2016-04-15 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46239/#review129176 --- Ship it! Ship It! - anilkumar gingade On April 15, 2016, 12

Re: Review Request 46240: GEODE-336: Make Function extends Identifiable

2016-04-15 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46240/#review129174 --- Ship it! Ship It! - anilkumar gingade On April 15, 2016, 12

Re: [VOTE] RC2: Apache Geode (Incubating) second Milestone release - v1.0.0-incubating.M2

2016-04-14 Thread Anilkumar Gingade
+1. Great work Dan... Downloaded "apache-geode-src-1.0.0-incubating.M2.tar.gz" Did a clean and build on my mac: BUILD SUCCESSFUL Total time: 5 mins 38.668 secs Thanks, -Anil. On Wed, Apr 13, 2016 at 3:55 PM, Dan Smith wrote: > This is second release candidate for Apache

Re: Review Request 45711: GEODE-1044: Not initializing query array for every test, code clean up

2016-04-14 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45711/#review128930 --- Ship it! Ship It! - anilkumar gingade On April 4, 2016, 10

Re: Review Request 46154: GEODE-1018: Retrieve queues only once gateway listener to avoid a race

2016-04-13 Thread anilkumar gingade
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46154/#review128712 --- Ship it! Ship It! - anilkumar gingade On April 13, 2016, 5

Re: Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-04-12 Thread Anilkumar Gingade
conjunction > > > > -Kirk > > > > > > On Tue, Apr 12, 2016 at 5:25 PM, Anthony Baker <aba...@pivotal.io> > wrote: > > > >> I’d prefer to insert a conjunction to clarify the meaning: > >> > >> forwardEvictionAndExpiration

Proposal to allow eviction and expiration operations/events with AsyncEventQueue.

2016-04-12 Thread Anilkumar Gingade
Hi Team, The AEQ implementation in Geode currently does not support distribution of eviction or expiration operations...This makes the external source maintained using AEQ to be out of sync with data that has been removed/invalidated through eviction and expiration. Jira ticket:

  1   2   >