> On Nov. 9, 2016, 5:36 p.m., anilkumar gingade wrote:
> > geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java,
> > line 1189
> > <https://reviews.apache.org/r/53596/diff/1/?file=1558982#file1558982line1189>
> >
> > Th
/GemFireCacheImpl.java
<https://reviews.apache.org/r/53596/#comment225432>
This is verifying java version when cache is getting created and warns the
user if its not compatible version...I think we should keep this instead of
removing it...
- anilkumar gingade
On Nov. 9, 2016, 5:08 a.m., A
/TXState.java (line 514)
<https://reviews.apache.org/r/53442/#comment225040>
What if one of the region is destroyed while iterating over the regions?
Can we still operate on version vector (in lockRegionForAtomicTX())...Do we
need to have some error handlling code?
- anilkumar gingade
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53355/#review154953
---
Ship it!
Ship It!
- anilkumar gingade
On Nov. 4, 2016, 5:58
/distributed/internal/membership/gms/mgr/GMSMembershipManagerJUnitTest.java
bae1ddc
Diff: https://reviews.apache.org/r/53410/diff/
Testing
---
Added new unit test. Verified the test without my change and with the change.
With change test looks for DistributedSystemDisconnectedException to be thrown.
Thanks,
anilkumar gingade
after the create is completed. This will impact all the methods calling
"isCacheAtShutdownAll".
- anilkumar gingade
On Nov. 1, 2016, 11:25 p.m., Darrel Schneider wrote:
>
> ---
> This is an automatically generat
Right, to be enterprise class software product, it needs to be backward
compatible...We also need to consider rolling upgrade of the system
Thanks, Dan, Bruce for the write-up and frame-work...
-Anil.
On Wed, Nov 2, 2016 at 10:37 AM, William Markito Oliveira <
william.mark...@gmail.com>
+1
On Fri, Oct 28, 2016 at 10:23 PM, Avinash Dongre wrote:
> +1
>
> On Sat, Oct 29, 2016 at 8:40 AM, yang theseus
> wrote:
>
> > +1!
> >
> > 2016-10-28 7:07 GMT+08:00 Nitin Lamba :
> >
> > > +1!
> > >
> > > On Wed, Oct 26, 2016 at
I am seeing build failures with:
***
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':geode-core:spotlessJavaCheck'.
> Format violations were found. Run 'gradlew spotlessApply' to fix them.
I don't see any "search" option with docs? Did we miss it...
http://geode.incubator.apache.org/docs/guide/about_geode.html
-Anil.
On Thu, Sep 29, 2016 at 8:27 PM, Anthony Baker wrote:
> I am pleased to announce the donation of Geode documentation to the
> Geode community.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53071/#review153568
---
Ship it!
Ship It!
- anilkumar gingade
On Oct. 21, 2016, 5
/apache/geode/cache/query/Query.java (line 92)
<https://reviews.apache.org/r/52891/#comment222410>
Wemay have to add this to other flavors of execute(*)...
- anilkumar gingade
On Oct. 17, 2016, 11:15 p.m., Ken Howe
+1 for release...
On Mon, Oct 17, 2016 at 2:54 PM, Anilkumar Gingade <aging...@pivotal.io>
wrote:
> Hi Karen,
>
> The fix still keeps the doc stating:
> "a client will need to set its credential, composed of the two properties
> `security-username` and `security-
Hi Karen,
The fix still keeps the doc stating:
"a client will need to set its credential, composed of the two properties
`security-username` and `security-password`."
What i see is, additional doc about setting the auth properties using
callbacks
Am i missing anything?
-Anil.
On Mon,
-
>
> (Updated Oct. 14, 2016, 10:39 p.m.)
>
>
> Review request for geode, anilkumar gingade, Darrel Schneider, Eric Shu,
> Scott Jewell, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> ---
>
> PartitionedRegion.getNodeForB
/index/CompactMapRangeIndex.java
(line 144)
<https://reviews.apache.org/r/52619/#comment220471>
Is this safe to remove entry here...The backing map looks like just hash
map (not concurrent)...
- anilkumar gingade
On Oct. 7, 2016, 5:48 p.m., nabarun nag
If fixing flaky tests are not in the release plan, its a good idea to move
this from release job...As you said it helps to keep the run clean and
makes it easy to track unexpected failures.
-Anil.
On Wed, Oct 5, 2016 at 2:58 PM, Swapnil Bawaskar
wrote:
> Some of tests
g/r/51875/#review148993
---
On Sept. 14, 2016, 12:22 a.m., anilkumar gingade wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51831/#review149101
---
Ship it!
Ship It!
- anilkumar gingade
On Sept. 14, 2016, 10
/test/java/com/gemstone/gemfire/internal/cache/ClientServerTransactionDUnitTest.java
08953d5
Diff: https://reviews.apache.org/r/51875/diff/
Testing
---
Reproduced the missing create event with the submitted test. And verified with
the fix.
pre-checkin.
Thanks,
anilkumar gingade
71614#file1471614line189>
> >
> > Will this dir and clusterConfigDir get cleaned up after the test is
> > run? Should this use a TemporaryFolder rule or something else?
>
> anilkumar gingade wrote:
> It uses the TemporaryFolder...yes it clears the config dir...Without th
71614#file1471614line189>
> >
> > Will this dir and clusterConfigDir get cleaned up after the test is
> > run? Should this use a TemporaryFolder rule or something else?
>
> anilkumar gingade wrote:
> It uses the TemporaryFolder...yes it clears the config dir...Without th
ir...Without this i was
having problem with the second test, where it was loading the cluster config
from previous test...
- anilkumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51010/#review145572
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50962/#review145401
---
Ship it!
Ship It!
- anilkumar gingade
On Aug. 10, 2016, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50903/#review145399
---
Ship it!
Ship It!
- anilkumar gingade
On Aug. 10, 2016, 8
+1
On Mon, Aug 8, 2016 at 5:12 PM, Kirk Lund wrote:
> +1
>
> - built and ran unit tests
> - started GFSH
> - launched Locator and Server
>
> -Kirk
>
> On Monday, August 8, 2016, Swapnil Bawaskar wrote:
>
> > +1
> >
> > - compiled from source
> > -
on why destroy is called here...If thats
not the case (the close doesn;t take long time) then its fine...
- anilkumar gingade
On Aug. 8, 2016, 6:02 p.m., Dan Smith wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50538/#review143848
---
Ship it!
Ship It!
- anilkumar gingade
On July 27, 2016, 10
en
initialized at this time...
- anilkumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50361/#review143288
-------
On July
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50361/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh
dd2
Diff: https://reviews.apache.org/r/50089/diff/
Testing
---
Thanks,
anilkumar gingade
Nilkanth,
One reasons I can think of; during recovery system may be consuming more
memory than (during the shutdown); the reason could be relating to how data
is recovered from the disk (reading krf, drf files first, and then crf
files)...The memory may be used up by the data-structures that are
Your suggestion looks much better...I will make those changes...
- anilkumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50089/#review142456
--------
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50089/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt
+1 - One more milestone...
-Anil.
On Wed, Jul 13, 2016 at 10:39 AM, William Markito
wrote:
> All,
>
> This is the first release candidate Apache Geode, version
> 1.0.0-incubating.M3.
> Thanks to all the community members to drive towards this milestone!
>
> It fixes the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49904/#review141776
---
Ship it!
Ship It!
- anilkumar gingade
On July 11, 2016, 5
again...
- anilkumar gingade
On July 6, 2016, 8:42 p.m., Jason Huynh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Here is what GemFire docs states about region names:
http://gemfire.docs.pivotal.io/docs-gemfire/latest/basic_config/data_regions/region_naming.html
But again, we have supported other chars as part of region names...
The Query engine allows/detects region name with: "_", “+”, “-“, “:”, “#”,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49102/#review140051
---
Ship it!
Nice to have unit test for this.
- anilkumar gingade
ds can still execute this concurrently...Will that be an
issue?
- anilkumar gingade
On June 21, 2016, 5:40 p.m., Dan Smith wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
, it may
affect existing customers/users...
The bug title talks about user specific info, are these changes
related...Sorry i was unable to access the ticket...
- anilkumar gingade
On June 17, 2016, 11:48 p.m., Sai B
+1
To be clear we are removing "search()" and replacing this with methods that
reflect the return types...
E.g: findKeys() - Returns only the region keys for matched query.
This provides applications flexibility of working with only keys or to
fetch region values as required.
-Anil.
On Mon,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48865/
---
(Updated June 17, 2016, 6:53 p.m.)
Review request for geode, anilkumar gingade
John is Right...WAN is more than just a replication of data...In order to
highlight and meaningful we have described this as Muti Site (WAN) Topology
in GemFire docs...
-Anil.
On Fri, Jun 17, 2016 at 11:15 AM, Swapnil Bawaskar
wrote:
> Well, you can can replicate
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48865/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Jason Huynh
/com/gemstone/gemfire/cache/lucene/internal/PartitionedRepositoryManager.java
(line 139)
<https://reviews.apache.org/r/48757/#comment203083>
Synchronization...To avoid multiple threads creating the repo.
- anilkumar gingade
On June 15, 2016, 9:36 p.m., Dan Smith
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48738/
---
(Updated June 15, 2016, 5:42 p.m.)
Review request for geode, anilkumar gingade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48738/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider
main/java/com/gemstone/gemfire/internal/StatSamplerStats.java
(line 69)
<https://reviews.apache.org/r/48432/#comment202199>
Good one...
- anilkumar gingade
On June 9, 2016, 6:41 p.m., Dan Smith wrote:
>
> ---
> This i
/gemstone/gemfire/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java
(line 112)
<https://reviews.apache.org/r/48525/#comment202191>
Something may be wrong with our IDE formatters, they are adding spaces with
new line...I did see this with my eclipse IDE...
- anilkumar g
As i know we try to avoid copying as much as possibleWhen we read from
socket to storing in cache...Its mostly the reference pointer that is
passed around...Someone can correct me if i am wrong
I am interested to see how adopting techniques to reduce cache-miss rates
(L1/L2) will help
as we talked in our meeting, these are legacy code refactoring...We
need to do it step by step :)
- anilkumar gingade
On June 8, 2016, 6:06 p.m., Dan Smith wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
Agree with Dan, its more about troubleshooting/fixing issue.
Will it be a good idea to organize them as:
Troubleshooting:
- When system encounters OOM
- When critical heap...
When i read it as design, i was expecting, system design instruction based
on certain requirement. Just my thoughts...
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48188/
---
(Updated June 6, 2016, 8:26 p.m.)
Review request for geode, anilkumar gingade
anilkumar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48188/#review136116
---
On June 3, 2016, 12:49 a.m., anilkumar ging
omatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48188/#review136115
-------
On June 3, 2016, 12:49 a.m., anilkumar gingade wrote:
>
> --
> *I will wait for other feedbacks/comments, if there is no objection i
> willchange it to "forwardExpirationDestroy" with default value set to
> true.*
>
> think you meant to say default value to set false :-)
>
> On Fri, Jun 3, 2016 at 11:47 AM, Anilkumar Gingade <
> property to be false. That was the case when it was forwardXXX. But now
> that it has changed to ignoreXXX the default has become true. I'd vote for
> it being named something whose default can be false.
>
>
> On Thu, Jun 2, 2016 at 11:10 AM, Anilkumar Gingade <aging...@pivotal.io>
> w
ss build? I would recommend
>> running with a later version of java 8.
>>
>> -Dan
>>
>> On Thu, Jun 2, 2016 at 2:41 PM, Anilkumar Gingade <aging...@pivotal.io>
>> wrote:
>>
>> If gradle is using the java installed/set in my environment, then it is:
>&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/#review134641
-------
On May 24, 2016, 12:05 a.m., anilkumar gingade wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48188/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Bruce Schuchardt
ormally, it could be either a
> callable or a runnable.
>
> What JDK and what revision are you building with? Maybe some newer JDK is
> complaining about this?
>
> -Dan
>
> -Dan
>
> On Thu, Jun 2, 2016 at 1:58 PM, Anilkumar Gingade <aging...@pivotal.io>
&g
Hi Devs,
Anyone seeing this issue:
:geode-core:compileTestJava/export/india1/users/agingade/src/gemfire/open/geode-core/src/test/java/com/gemstone/gemfire/management/internal/security/MultiUserDUnitTest.java:62:
error: reference to invokeAsync is ambiguous
AsyncInvocation vm1Invoke =
ExpirationDestroy"...
Currently we are planning to support "ignoreExpirationDestroy", and add
"ignoreEvictionDestroy" once GEODE-1472 is fixed...
Looking for comments on this...
Thanks,
-Anil.
https://issues.apache.org/jira/browse/GEODE-1472
On Tue, Apr 12, 2016 at 6:0
looks like there is a ISNULL option in Lucene, we need to invistage to
see how we can store null and allow users to query null values...
https://forums.alfresco.com/forum/developer-discussions/other-apis/solved-empty-or-null-description-lucene-query-05052014-1521
- anilkumar gingade
On
Agree
The indexes are operated using api/xml at a peer/server node level; there
is no client-server index operation command; one reason index destroy is
supported on member, to simulate what api is supported...As you mentioned
it may not make sense to have it from Gfsh.
-Anil.
On Mon, May
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/
---
(Updated May 24, 2016, 12:05 a.m.)
Review request for geode, anilkumar gingade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47686/
---
Review request for geode, anilkumar gingade, Barry Oglesby, nabarun nag, Dan
Hi Team,
I have created wiki on adding new gfsh command. If you have any additional
information or additional comments, please add it to the wiki page or let
me know.
https://cwiki.apache.org/confluence/display/GEODE/Adding+Gfsh+commands
Thanks,
-Anil.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/
---
(Updated May 19, 2016, 10:54 p.m.)
Review request for geode, anilkumar gingade
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47606/#review134061
---
Ship it!
Ship It!
- anilkumar gingade
On May 19, 2016, 5:14
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/#review134056
---
On May 19, 2016, 9:47 p.m., anilkumar gingade wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47615/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider
Thats a great newsIt opens up all our client code accessible to
community...
-Anil.
On Thu, May 19, 2016 at 8:56 AM, Anthony Baker wrote:
> I am pleased to announce the donation of additional GemFire client drivers
> to the Geode community. This source code donation
+1
I am assuming there will be some marking between two cache instances...
Do they include xml and properties info too? if so it will be nice to have
some way to print those during debugging...
-Anil.
On Wed, May 18, 2016 at 3:12 PM, Bruce Schuchardt
wrote:
> Would
306)
<https://reviews.apache.org/r/47496/#comment198233>
How about moving these puts into region initialization method?
- anilkumar gingade
On May 17, 2016, 10:54 p.m., Jason Huynh wrote:
>
> ---
> This is an automatically
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46243/
---
(Updated May 16, 2016, 11 p.m.)
Review request for geode, anilkumar gingade
lieve in our group session we passed two arguments. 1. Max wait time 1.
Unit of sleep (iunstead of hard coded 200 mili sec)
- anilkumar gingade
On May 16, 2016, 5:39 a.m., xiaojian zhou wrote:
>
> ---
> This is an automatically genera
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47378/#review133389
---
Ship it!
Ship It!
- anilkumar gingade
On May 14, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47372/
---
Review request for geode, anilkumar gingade, Barry Oglesby, Darrel Schneider
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47253/#review132966
---
Ship it!
Ship It!
- anilkumar gingade
On May 11, 2016, 8:11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47276/#review132965
---
Ship it!
Ship It!
- anilkumar gingade
On May 12, 2016, 12
test/java/com/gemstone/gemfire/internal/cache/wan/Simple2CacheServerDUnitTest.java
(line 83)
<https://reviews.apache.org/r/47220/#comment196964>
From the above it looks like we are not sure which one is the primary queue
server...Are we expecting to close primary queue server or any s
>
> > This is not a unit test if it's creating a cache. Should be marked as
> > an integration test.
You are right, i will change this as integration test.
- anilkumar
---
This is an automatically generated e-mail. T
automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46243/#review129453
-------
On May 6, 2016, 12:45 a.m., anilkumar gingade wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46916/#review131934
---
Ship it!
Ship It!
- anilkumar gingade
On May 2, 2016, 10:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46243/
---
(Updated May 4, 2016, 1:09 a.m.)
Review request for geode, anilkumar gingade
Hi Geode Devs,
To enhance Geode query functionalities; we had started initiative to
support Aggregate and UDA functionalities using a common frame work.
The spec for this can be found at:
https://cwiki.apache.org/confluence/display/GEODE/OQL+Aggregate+functions+and+UDA
As part of first phase
Hi Geode,
Thought of sharing this milestone...
Wow...Its been a year...In last year ApacheCON (Apr 2015) we announced open
sourcing Geode, we made the Geode source available to the Apache
community...Its been a great journey from that point...
The geode community is growing and contributing to
server (and there are multiple servers running on this JVM)
- anilkumar gingade
On April 25, 2016, 6:01 a.m., xiaojian zhou wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Great...
Thanks Dan; for being the release manager and successfully getting the
release out...good work...
-Anil.
On Fri, Apr 22, 2016 at 11:24 AM, Dan Smith wrote:
> Quick update on the M2 release. It passed the vote on the incubator general
> list, we're just working on
(line 1147)
<https://reviews.apache.org/r/46354/#comment193125>
Is this HDFS/custome eviction specific?
- anilkumar gingade
On April 19, 2016, 12:35 a.m., Dan Smith wrote:
>
> ---
> This is an automatically generated e-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46356/#review129571
---
Ship it!
Ship It!
- anilkumar gingade
On April 19, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46239/#review129176
---
Ship it!
Ship It!
- anilkumar gingade
On April 15, 2016, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46240/#review129174
---
Ship it!
Ship It!
- anilkumar gingade
On April 15, 2016, 12
+1. Great work Dan...
Downloaded "apache-geode-src-1.0.0-incubating.M2.tar.gz"
Did a clean and build on my mac:
BUILD SUCCESSFUL
Total time: 5 mins 38.668 secs
Thanks,
-Anil.
On Wed, Apr 13, 2016 at 3:55 PM, Dan Smith wrote:
> This is second release candidate for Apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45711/#review128930
---
Ship it!
Ship It!
- anilkumar gingade
On April 4, 2016, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46154/#review128712
---
Ship it!
Ship It!
- anilkumar gingade
On April 13, 2016, 5
conjunction
> >
> > -Kirk
> >
> >
> > On Tue, Apr 12, 2016 at 5:25 PM, Anthony Baker <aba...@pivotal.io>
> wrote:
> >
> >> I’d prefer to insert a conjunction to clarify the meaning:
> >>
> >> forwardEvictionAndExpiration
Hi Team,
The AEQ implementation in Geode currently does not support distribution of
eviction or expiration operations...This makes the external source
maintained using AEQ to be out of sync with data that has been
removed/invalidated through eviction and expiration.
Jira ticket:
1 - 100 of 187 matches
Mail list logo