[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r191107001 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,71 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

Re: 1.0.0 Release?

2018-05-27 Thread Mike Jumper
On Sat, May 26, 2018 at 9:46 AM, Nick Couchman wrote: >> >>> I'll recheck open JIRA issues and PRs in a bit, but the above are what >>> come >>> to mind. >> > Hey, everyone, > Circling back on this 1.0.0 release, I'm going to propose that we fix the > release to include

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r191081345 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,63 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r191081186 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r191081131 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r189494122 --- Diff: src/protocols/rdp/rdp_settings.c --- @@ -822,6 +838,32 @@ guac_rdp_settings* guac_rdp_parse_args(guac_user* user

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r189494030 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r189492258 --- Diff: src/common-ssh/ssh.c --- @@ -414,7 +415,8 @@ static int guac_common_ssh_authenticate(guac_common_ssh_session* common_session

[GitHub] guacamole-server pull request #164: GUACAMOLE-527: Implement SSH host key ch...

2018-05-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/164#discussion_r189492193 --- Diff: src/common-ssh/ssh.c --- @@ -518,6 +520,64 @@ guac_common_ssh_session* guac_common_ssh_create_session(guac_client* client

[GitHub] guacamole-server pull request #132: GUACAMOLE-470: Make terminal colors conf...

2018-05-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/132#discussion_r189474404 --- Diff: src/terminal/terminal.c --- @@ -255,53 +260,252 @@ void* guac_terminal_thread(void* data) { } -guac_terminal

[GitHub] guacamole-server pull request #166: GUACAMOLE-564: Hide APC escape sequence.

2018-05-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/166#discussion_r189180014 --- Diff: src/terminal/terminal_handlers.c --- @@ -1373,3 +1377,22 @@ int guac_terminal_ctrl_func(guac_terminal* term, unsigned char c

[GitHub] guacamole-server pull request #166: GUACAMOLE-564: Hide APC escape sequence.

2018-05-18 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/166#discussion_r189178815 --- Diff: src/terminal/terminal_handlers.c --- @@ -1373,3 +1377,22 @@ int guac_terminal_ctrl_func(guac_terminal* term, unsigned char c

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r189082729 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -184,6

[GitHub] guacamole-client pull request #280: GUACAMOLE-152: Allow zoom/scale to be ma...

2018-05-16 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/280#discussion_r188524055 --- Diff: guacamole/src/main/webapp/app/client/templates/client.html --- @@ -151,7 +151,12 @@ {{'CLIENT.SECTION_HEADER_DISPLAY' | translate

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187868053 --- Diff: extensions/guacamole-auth-quickconnect/src/test/java/org/apache/guacamole/auth/quickconnect/utility/QCParserTest.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-14 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187867376 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-11 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r187763295 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectionGroup.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r186855115 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectDirectory.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r186844828 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-05-08 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r186840042 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectUserContext.java

[GitHub] guacamole-client pull request #285: GUACAMOLE-220: Expose user groups, group...

2018-05-04 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/285 GUACAMOLE-220: Expose user groups, group membership, and group permissions via REST. This change adds the REST service side of the base API support for user groups added via #274

[GitHub] guacamole-client pull request #284: GUACAMOLE-220: Rely on managementButtons...

2018-05-04 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/284 GUACAMOLE-220: Rely on managementButtons directive to handle redirect after save. Redirecting the user back to the user list is handled automatically by the `managementButtons

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-04 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185999873 --- Diff: guacamole/src/main/webapp/app/manage/directives/connectionPermissionEditor.js --- @@ -0,0 +1,406 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-04 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r18525 --- Diff: guacamole/src/main/webapp/app/manage/directives/connectionPermissionEditor.js --- @@ -0,0 +1,406 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #283: GUACAMOLE-559: Add support for reading/w...

2018-05-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/283 GUACAMOLE-559: Add support for reading/writing clipboard contents using the Asynchronous Clipboard API. Finally: the Holy Grail. https://developers.google.com/web/updates

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185389504 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageConnectionController.js --- @@ -157,205 +137,178 @@ angular.module('manage

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185389485 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageConnectionController.js --- @@ -157,205 +137,178 @@ angular.module('manage

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185388716 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageConnectionController.js --- @@ -157,205 +137,178 @@ angular.module('manage

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185388553 --- Diff: guacamole/src/main/webapp/app/manage/templates/manageConnection.html --- @@ -41,7 +41,7

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185388396 --- Diff: guacamole/src/main/webapp/app/manage/templates/manageConnection.html --- @@ -41,7 +41,7

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/282#discussion_r185388275 --- Diff: guacamole/src/main/webapp/app/manage/controllers/manageConnectionController.js --- @@ -157,205 +137,178 @@ angular.module('manage

[GitHub] guacamole-client pull request #282: GUACAMOLE-220: Extract common base for m...

2018-05-01 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/282 GUACAMOLE-220: Extract common base for management UI. A necessary basis for the user group management interface (which adds yet another management tab), these changes extract

[GitHub] guacamole-client pull request #281: GUACAMOLE-526: Use toArray as necessary ...

2018-04-30 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/281 GUACAMOLE-526: Use toArray as necessary for orderBy. The `toArray` filter is necessary wherever `orderBy` is being used to iterate over an object, as iterating over an object

[GitHub] guacamole-client pull request #279: GUACAMOLE-526: Invoke logout() for the c...

2018-04-29 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/279 GUACAMOLE-526: Invoke logout() for the cached token BEFORE storing new token. The changes introduced via #278 incorrectly invalidate the cached auth token after having already

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-29 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r184893989 --- Diff: extensions/guacamole-auth-quickconnect/src/licenses/LICENSE --- @@ -0,0 +1,221 @@ + + Apache

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-27 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r184813371 --- Diff: extensions/guacamole-auth-quickconnect/src/licenses/bundled/aopalliance-1.0/LICENSE --- @@ -0,0 +1,4 @@ +From http

[GitHub] guacamole-client pull request #278: GUACAMOLE-526: Handle absolutely all pro...

2018-04-27 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/278 GUACAMOLE-526: Handle absolutely all promise rejections. This change addresses the new "possibly unhandled rejection" error by adding handling for absolutely *all* promise

Re: Build failed in Jenkins: guacamole-client-master » JDK 1.8 (latest) #37

2018-04-26 Thread Mike Jumper
On Thu, Apr 26, 2018 at 9:57 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See jdk=JDK%201.8%20(latest)/37/display/redirect> > > -- > Started by upstream project

[GitHub] guacamole-client pull request #277: GUACAMOLE-549: Update to latest version ...

2018-04-25 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/277 GUACAMOLE-549: Update to latest version of webjar-servlet-2.x. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mike-jumper

Re: Setting up Guacamole inside Docker containers

2018-04-25 Thread Mike Jumper
On Wed, Apr 25, 2018 at 2:03 PM, Tezarin wrote: > Hi all, > I noticed I am not able to connect to any of my CentOS remote devices but > Windows are find. The log shows: > > "o.a.g.t.h.RestrictedGuacamoleHTTPTunnelServlet - Using HTTP tunnel (not > WebSocket).

[GitHub] guacamole-client pull request #276: GUACAMOLE-549: Do not automatically crea...

2018-04-25 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/276 GUACAMOLE-549: Do not automatically create HttpSession. If an extension truly needs an `HttpSession`, it should create it manually via the `HttpServletRequest`. You can merge

[GitHub] guacamole-client pull request #265: GUACAMOLE-526: Update webapp to angular ...

2018-04-25 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/265#discussion_r183948571 --- Diff: guacamole/src/main/webapp/index.html --- @@ -61,15 +61,16

[GitHub] guacamole-client pull request #265: GUACAMOLE-526: Update webapp to angular ...

2018-04-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/265#discussion_r183614711 --- Diff: guacamole/src/main/webapp/app/rest/services/requestService.js --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] guacamole-client pull request #265: GUACAMOLE-526: Update webapp to angular ...

2018-04-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/265#discussion_r183612310 --- Diff: guacamole/src/main/webapp/app/rest/services/requestService.js --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] guacamole-client pull request #265: GUACAMOLE-526: Update webapp to angular ...

2018-04-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/265#discussion_r183616301 --- Diff: guacamole/src/main/webapp/app/rest/services/requestService.js --- @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] guacamole-client pull request #265: GUACAMOLE-526: Update webapp to angular ...

2018-04-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/265#discussion_r183612504 --- Diff: guacamole/src/main/webapp/app/index/filters/arrayFilter.js --- @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

Re: Build failed in Jenkins: guacamole-client-master » JDK 1.8 (latest) #33

2018-04-23 Thread Mike Jumper
Opened an issue with Infra for this: https://issues.apache.org/jira/browse/INFRA-16422 Presumably H24 is out of disk space. - Mike On Mon, Apr 23, 2018 at 7:57 AM, Apache Jenkins Server < jenk...@builds.apache.org> wrote: > See

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183219692 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/UserGroup.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183219605 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/sharingprofile/SharingProfileResource.java --- @@ -103,11 +104,13 @@ public

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183219541 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/directory/DirectoryResource.java --- @@ -143,13 +144,14 @@ public

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183219535 --- Diff: guacamole/src/main/java/org/apache/guacamole/rest/connection/ConnectionResource.java --- @@ -119,11 +120,13 @@ public

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183219467 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/simple/SimpleRelatedObjectSet.java --- @@ -0,0 +1,88

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-21 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183217172 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/UserGroup.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-20 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/274#discussion_r183188493 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/UserGroup.java --- @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache

[GitHub] guacamole-client pull request #274: GUACAMOLE-220: Add base extension API su...

2018-04-19 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/274 GUACAMOLE-220: Add base extension API support for user groups. This change adds the base classes necessary for exposing user groups via extensions, and for declaring the permissions

[GitHub] guacamole-client pull request #273: GUACAMOLE-549: Migrate to localStorage f...

2018-04-19 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/273 GUACAMOLE-549: Migrate to localStorage for storage of auth token. This change: * Adds a new service, `localStorageService` / `localStorageServiceProvider`, which abstracts

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182214035 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182208615 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182206171 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnection.java --- @@ -0,0 +1,87

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182212844 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182208675 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/controllers/quickconnectController.js --- @@ -0,0 +1,75

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182206999 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182202689 --- Diff: extensions/guacamole-auth-quickconnect/src/licenses/NOTICE --- @@ -0,0 +1,5 @@ +Apache Guacamole +Copyright 2017 The Apache

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182206011 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectUserContext.java

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182205689 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182210966 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-04-17 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r182210507 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/services/quickConnectService.js --- @@ -0,0 +1,66

[GitHub] guacamole-website pull request #58: Point users to the new security@guacamol...

2018-04-13 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-website/pull/58 Point users to the new secur...@guacamole.apache.org list for reporting issues with potential security implications. You can merge this pull request into a Git repository by running

[GitHub] guacamole-server pull request #165: GUACAMOLE-482: Allow encoding to proceed...

2018-04-12 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/165 GUACAMOLE-482: Allow encoding to proceed despite invalid instructions. guacenc should not fail the encoding process in cases where `Guacamole.Client` would not drop the connection

[GitHub] guacamole-client pull request #271: GUACAMOLE-542: Add AbstractUserContext a...

2018-04-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/271#discussion_r181227238 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractAuthenticationProvider.java --- @@ -0,0 +1,157

[GitHub] guacamole-client pull request #271: GUACAMOLE-542: Add AbstractUserContext a...

2018-04-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/271#discussion_r181179697 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractAuthenticationProvider.java --- @@ -0,0 +1,157

[GitHub] guacamole-client pull request #271: GUACAMOLE-542: Add AbstractUserContext a...

2018-04-12 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/271#discussion_r181179068 --- Diff: guacamole-ext/src/main/java/org/apache/guacamole/net/auth/AbstractAuthenticationProvider.java --- @@ -0,0 +1,157

[GitHub] guacamole-client pull request #272: GUACAMOLE-541: Prioritize classes define...

2018-04-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/272 GUACAMOLE-541: Prioritize classes defined within extensions over classes inherited from the webapp. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] guacamole-client pull request #271: GUACAMOLE-542: Add AbstractUserContext a...

2018-04-11 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/271 GUACAMOLE-542: Add AbstractUserContext and AbstractAuthenticationProvider base classes. Note that these changes also involved improving `SimpleDirectory` and, as a result

Re: User group schema (sanity check)

2018-04-11 Thread Mike Jumper
On Wed, Apr 4, 2018 at 10:08 AM, Nick Couchman wrote: > ... > > > > Good question. The LDAP changes are definitely in scope, and it was my > > original intent to try to tackle those. Assuming these changes are > > part of 1.0.0, I can understand limiting the scope to just the >

Re: Setting up Guacamole inside Docker containers

2018-04-04 Thread Mike Jumper
On Tue, Apr 3, 2018 at 12:24 PM, Tezarin wrote: > Hi all, > I am new to Guacamole and decided to set that up inside Docker. I followed > a couple of instructions, i.e. https://guacamole.apache. > org/doc/gug/guacamole-docker.html > And > >

User group schema (sanity check)

2018-04-03 Thread Mike Jumper
the delete to the user/group) - Retrieving the name of a user/group will always involve a join against the entity table The WIP schema changes themselves (I'm working strictly with Postgres until everything is set in stone): https://github.com/mike-jumper/guacamole-cli

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178615175 --- Diff: src/protocols/ssh/ttymode.h --- @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178614942 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,64 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-02 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178614574 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +299,17 @@ void* ssh_client_thread(void* data) { } +/* Set up

[GitHub] guacamole-server pull request #163: GUACAMOLE-533: Wait at most 5 seconds fo...

2018-04-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-server/pull/163 GUACAMOLE-533: Wait at most 5 seconds for connection processes to terminate following disconnect. This change refactors guacd such that `guac_client_free()` is invoked in a dedicated

[GitHub] guacamole-client pull request #269: GUACAMOLE-529: Apply database-specific a...

2018-04-02 Thread mike-jumper
GitHub user mike-jumper opened a pull request: https://github.com/apache/guacamole-client/pull/269 GUACAMOLE-529: Apply database-specific account restrictions depending on context. In addition to inherently correcting the behavior of the "disabled" flag, this als

[GitHub] guacamole-server pull request #154: GUACAMOLE-445: Make Printer Name Configu...

2018-04-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/154#discussion_r178485119 --- Diff: src/protocols/rdp/guac_rdpdr/rdpdr_printer.c --- @@ -141,18 +143,25 @@ static void guac_rdpdr_device_printer_announce_handler

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178482718 --- Diff: src/protocols/ssh/ttymode.c --- @@ -0,0 +1,58 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] guacamole-server pull request #156: GUACAMOLE-269: Allow backspace key behav...

2018-04-01 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-server/pull/156#discussion_r178482474 --- Diff: src/protocols/ssh/ssh.c --- @@ -296,9 +301,15 @@ void* ssh_client_thread(void* data) { } +/* Set up

Re: guacd protocol-specific configuration

2018-03-29 Thread Mike Jumper
On Sun, Mar 25, 2018 at 1:26 PM, Nick Couchman wrote: > I was looking at some possible ways to implement changes needed for > GUACAMOLE-527, dealing with SSH known hosts, and one of the possible routes > would be to add a parameter to the guacd configuration file to

Re: 1.0.0 Release?

2018-03-28 Thread Mike Jumper
On Wed, Mar 28, 2018 at 4:29 AM, Nick Couchman wrote: > ... > > > > > > > From JIRA, the following look like good (potential) candidates to me: > > > > > > (?) GUACAMOLE-407: Use Ubuntu for docker images instead of CentOS > > > > > > > > We're running with an Ubuntu base image.

Re: IMPORTANT : Getting ERRORs in TOMCAT

2018-03-26 Thread Mike Jumper
On Sun, Mar 25, 2018 at 9:22 PM, Amarjeet Singh wrote: > Hi Team, > > I am unable to use Guacamole because of the above situation. > > Hi Amarjeet, The error you note (regarding the thread pool leak) is a known bug in Guice and doesn't actually have any effect with respect

Re: Extension... showing VM status?

2018-03-25 Thread Mike Jumper
On Sun, Mar 25, 2018 at 4:56 PM, Vlad CopyLove wrote: > From http://apache-guacamole-general-user-mailing-list. > 2363388.n4.nabble.com/Extension-showing-VM-status-td2955.html > > ... mess of a discussion, it seems that the definition of Extension you > guys at >

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920446 --- Diff: extensions/guacamole-auth-quickconnect/pom.xml --- @@ -0,0 +1,209 @@ + + +http://maven.apache.org/POM/4.0.0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920168 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/templates/quickconnectField.html --- @@ -0,0 +1,9

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176919853 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920497 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectAuthenticationProvider.java

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920363 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/rest/QuickConnectREST.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176919957 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920476 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectAuthenticationProvider.java

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920091 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/utility/QCParser.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920196 --- Diff: extensions/guacamole-auth-quickconnect/src/main/resources/styles/quickconnect.css --- @@ -0,0 +1,48 @@ +/* + * Licensed

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920341 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/rest/QuickConnectREST.java --- @@ -0,0

[GitHub] guacamole-client pull request #181: GUACAMOLE-38: Implement on-demand connec...

2018-03-24 Thread mike-jumper
Github user mike-jumper commented on a diff in the pull request: https://github.com/apache/guacamole-client/pull/181#discussion_r176920563 --- Diff: extensions/guacamole-auth-quickconnect/src/main/java/org/apache/guacamole/auth/quickconnect/QuickConnectConnectionGroup.java

<    1   2   3   4   5   6   7   8   >