Re: Core vs client

2018-12-04 Thread Gary Gregory
On Tue, Dec 4, 2018 at 12:54 PM Ryan Schmitt wrote: > My concern with the core/client split is that I think it exposes tons of > additional API surface area which will become a liability post-release. My > recent changes for TLS handshake timeouts are a good example of this: in > order to use the

Fwd: [4/4] httpcomponents-core git commit: Added openjdk10 to Travis-CI build matrix

2018-12-07 Thread Gary Gregory
I think we can skip Java 9 and 10 and instead test Java 11. After all only Java 8 and 11 have LTS ATM. Gary -- Forwarded message - From: Date: Fri, Dec 7, 2018 at 8:53 AM Subject: [4/4] httpcomponents-core git commit: Added openjdk10 to Travis-CI build matrix To: Added openjd

Re: HttpClient 5.0-beta3

2018-12-10 Thread Gary Gregory
I am available over the holidays, go for it :-) Gary On Mon, Dec 10, 2018, 06:41 Oleg Kalnichevski Folks > > I would like to cut HttpClient 5.0-beta3 soon, before Christmas for > sure. > > Any objections to that? Any blockers? > > Will there be enough people to vote on the release? > > Oleg > >

Re: [VOTE] Release HttpClient 5.0-beta3 based on RC1

2018-12-11 Thread Gary Gregory
+1 Testing from RC git tag. Building 'mvn clean package' with: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T12:41:47-06:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 12-ea, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-12 Default lo

Re: Fwd: [NOTICE] Mandatory relocation of Apache git repositories on git-wip-us.apache.org

2018-12-12 Thread Gary Gregory
On Wed, Dec 12, 2018 at 2:14 PM Oleg Kalnichevski wrote: > On Wed, 2018-12-12 at 19:22 +0100, Roy Lenferink wrote: > > Hi folks, > > > > Does anyone have a problem with starting the process to migrate the > > existing HttpComponents git-wip-us repos [1-5] to gitbox? > > This means integrated acce

Re: JSON message processors for HttpComponents 5.0

2019-01-01 Thread Gary Gregory
Why not make this an http-component module? Gary On Tue, Jan 1, 2019, 10:57 Oleg Kalnichevski Folks > > I had some idle time on my hands I could not put to a better use, so I > built a JSON message processing library for HttpComponents 5.0 based on > Jackson JSON processor. > > https://github.co

Re: [VOTE] Release HttpCore 4.4.11 based on RC1

2019-01-16 Thread Gary Gregory
+1 Building from the Git tag with 'mvn clean package -P!use-toolchains' and Oracle Java 8 and 11 on Windows 10: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 1.8.0_192, vendor: Oracle Corporatio

Re: [VOTE] Release HttpClient 4.5.7 based on RC1

2019-01-20 Thread Gary Gregory
+1 Building from the git RC tag on Windows 10 with Oracle Java 8 and 11 using: mvn -V clean package -P!use-toolchains -Dmaven.javadoc.skip=true Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. *Java version: 1.

Re: httpcore5 5.0-beta7 release?

2019-01-23 Thread Gary Gregory
On Wed, Jan 23, 2019 at 4:43 PM Ryan Schmitt wrote: > Would anyone be opposed to releasing another beta of httpcore5 soon? I have > some unfinished business on the client side (improved support for TLS > handshake timeouts), and that work depends on corresponding changes in core > that just barel

Re: Add Content-Disposition header to org.apache.http.HttpHeaders

2019-01-25 Thread Gary Gregory
https://github.com/apache/httpcomponents-core Gary On Fri, Jan 25, 2019 at 7:52 AM Oleg Kalnichevski wrote: > On Fri, 2019-01-25 at 10:49 +0100, Frédéric Fays wrote: > > Hi, > > Could you please add the Content-Disposition header, c.f. RFC 6266, > > to the > > org.apache.http.HttpHeaders class,

Re: HttpCore 5.0-beta7 release notes

2019-01-29 Thread Gary Gregory
* org.apache.hc.core5.reactor.IOSession: Deprecate lock() in favor of > getLock(). Add missing @Override. > Contributed by Gary Gregory > > * HTTPCORE-563: client support for SOCKS version 5 > Contributed by David Maplesden > > * Delay i/o operations on non-blocking SSL

Re: HttpCore 5.0-beta7 release notes

2019-01-29 Thread Gary Gregory
"no pending ask" should have been "no pending Tasks" Gary On Tue, Jan 29, 2019 at 6:12 PM Gary Gregory wrote: > I have no pending ask ATM aside from more stress testing which has been on > pause for me since late 2018. Another beta will give me another reason to

Re: HC 5.0 related projects

2019-02-03 Thread Gary Gregory
Sounds good to me. Gary On Sat, Feb 2, 2019 at 4:48 AM Oleg Kalnichevski wrote: > Folks > > I would like to add a reference to a HC 5.0 related project I maintain > outside ASF to our project web site. > > At some point of time I also would like to add references to HttpClient > 5.0 migration g

Re: HttpCore 5.0 BETA7?

2019-02-06 Thread Gary Gregory
I have a new feature I'd like to discuss which I'd love to see in Beta 7, I am writing the Jira now which we can discuss in a sec... Gary On Tue, Feb 5, 2019 at 4:29 PM Ryan Schmitt wrote: > https://issues.apache.org/jira/browse/HTTPCORE-568 > > On Tue, Feb 5, 2019 at 6:39 AM Oleg Kalnichevski

Re: HttpCore 5.0 BETA7?

2019-02-06 Thread Gary Gregory
Please see: - https://issues.apache.org/jira/browse/HTTPCORE-569 and branch HTTPCORE-569 - https://issues.apache.org/jira/browse/HTTPCORE-570 and branch HTTPCORE-570 Gary On Wed, Feb 6, 2019 at 2:39 PM Gary Gregory wrote: > I have a new feature I'd like to discuss which I'd love t

Re: HttpCore 5.0 BETA7?

2019-02-06 Thread Gary Gregory
2019 at 4:14 PM Gary Gregory wrote: > Please see: > - https://issues.apache.org/jira/browse/HTTPCORE-569 and branch > HTTPCORE-569 > - https://issues.apache.org/jira/browse/HTTPCORE-570 and branch > HTTPCORE-570 > Gary > > On Wed, Feb 6, 2019 at 2:39 PM Gary Gregory > wrote

Re: [httpcomponents-core] branch master updated: [HTTPCORE-569] Re-implement feature correctly in a separate class.

2019-02-07 Thread Gary Gregory
On Thu, Feb 7, 2019 at 2:28 PM Oleg Kalnichevski wrote: > On Thu, 2019-02-07 at 19:25 +, ggreg...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > ggregory pushed a commit to branch master > > in repository > > https://gitbox.apache.org/repos/a

Clean up worth a branch?

2019-02-08 Thread Gary Gregory
Hi All: There is a bit of clean up left from a previous branch: diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestHandlerRegistry.java b/httpcore5/src/main/java/org/apache/hc/core5/http/protocol/RequestHandlerRegistry.java index 61ced60..6618806 100644 --- a/httpcore5/

Re: Clean up worth a branch?

2019-02-09 Thread Gary Gregory
On Sat, Feb 9, 2019 at 5:27 AM Oleg Kalnichevski wrote: > On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote: > > Hi All: > > > > There is a bit of clean up left from a previous branch: > > > > ... > > > > > Is this OK to commit to master or

Re: Clean up worth a branch?

2019-02-09 Thread Gary Gregory
On Sat, Feb 9, 2019 at 10:46 AM Oleg Kalnichevski wrote: > On Sat, 2019-02-09 at 09:45 -0500, Gary Gregory wrote: > > On Sat, Feb 9, 2019 at 5:27 AM Oleg Kalnichevski > > wrote: > > > > > On Fri, 2019-02-08 at 22:04 -0500, Gary Gregory wrote: > > > >

Move Examples into a package in the test folder

2019-02-13 Thread Gary Gregory
Hi All: I think it would be better if our examples lived in a .examples. package under the src/test folder. The advantages are: - Examples would always be compiled by Maven and IDEs - Examples would end up living in the test jar, which would be handy for testing certain use-cases. In my case, te

Re: Move Examples into a package in the test folder

2019-02-13 Thread Gary Gregory
ote: > On Wed, 2019-02-13 at 07:46 -0500, Gary Gregory wrote: > > Hi All: > > > > I think it would be better if our examples lived in a .examples. > > package > > under the src/test folder. The advantages are: > > > > - Examples would always be compiled b

Re: Formal code reviews and PRs

2019-02-14 Thread Gary Gregory
That sounds nice. Can we agree to add trivial changes to master directly, for example, if I want to Javadoc a previously undocumented method? Gary On Wed, Feb 13, 2019 at 11:08 AM Oleg Kalnichevski wrote: > Folks > > Since HttpComponents migration to GitBox I have been committing all my > code

Re: HttpCore 5.0 BETA7?

2019-02-15 Thread Gary Gregory
On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory wrote: > Oleg and all: > > Would you please take a look > at > org.apache.hc.core5.http.impl.bootstrap.CustomAsyncServerBootstrap.createRequestHandlerRegistry() > in the branch HTTPCORE-570. > > The TODO comment, I believe s

Re: HttpCore 5.0 BETA7?

2019-02-16 Thread Gary Gregory
On Fri, Feb 15, 2019 at 5:31 PM Oleg Kalnichevski wrote: > On Fri, 2019-02-15 at 16:06 -0500, Gary Gregory wrote: > > On Wed, Feb 6, 2019 at 7:49 PM Gary Gregory > > wrote: > > > > > Oleg and all: > > > > > > Would you pleas

Re: HttpCore 5.0 BETA7?

2019-02-16 Thread Gary Gregory
On Sat, Feb 16, 2019 at 9:11 AM Oleg Kalnichevski wrote: > On Sat, 2019-02-16 at 08:45 -0500, Gary Gregory wrote: > > > > ... > > > > This is what Eclipse says for one of the call sites: > > > > Description Resource Path Location Type > > > >

Re: [httpcomponents-client] branch 4.5.x updated: HTTPCLIENT-1968: Make normalization of URI paths optional

2019-02-16 Thread Gary Gregory
On these below, the @since are off. Gary On Sat, Feb 16, 2019 at 5:55 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > olegk pushed a commit to branch 4.5.x > in repository > https://gitbox.apache.org/repos/asf/httpcomponents-client.git > > > The following com

Re: HttpCore 5.0 BETA7?

2019-02-22 Thread Gary Gregory
Let's fire up the new beta! :-) Gary On Sat, Feb 16, 2019, 09:26 Oleg Kalnichevski On Sat, 2019-02-16 at 09:18 -0500, Gary Gregory wrote: > > > > ... > > > I get a compiler error with the above patch: > > > > Description Resource Path Location Typ

Re: HttpClient 5.0 migration guide

2019-02-22 Thread Gary Gregory
The docs look really nice. I just started looking and I hope to be able to read through the whole site over the next week. CloseableHttpClient instances should be closed when no longer needed or about to go out of score. We should also say that this can be used in a try-with-resources statement.

Re: [VOTE] Release HttpCore 5.0-beta7 based on RC1

2019-02-27 Thread Gary Gregory
I think VOTE emails should/must refer to sources on Apache repositories (Git-Wip/GitBox) as opposed to GitHub. May you please update this VOTE thread with such references? Gary On Wed, Feb 27, 2019 at 3:01 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpCore 5.0-bet

Re: [VOTE] Release HttpCore 5.0-beta7 based on RC1

2019-02-27 Thread Gary Gregory
+1 >From the git tag and running with: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 11.0.2, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk-11.0.2 Default locale: en_US, platfor

Re: [httpcomponents-client] branch master updated: HTTPCLIENT-1969: Filter out weak cipher suites

2019-03-07 Thread Gary Gregory
On Thu, Mar 7, 2019 at 10:36 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > olegk pushed a commit to branch master > in repository > https://gitbox.apache.org/repos/asf/httpcomponents-client.git > > > The following commit(s) were added to refs/heads/master by

Re: GitHub navigation - create httpcomponents container repo?

2019-03-10 Thread Gary Gregory
What about better docs front and center on the site? Another repo seems confusing if all it is is links. It does not help that ALL Apache projects are all under one roof on GitHub. Gary On Sun, Mar 10, 2019 at 10:21 AM sebb wrote: > The HC project has lots of independent Git repos. > It's not p

Re: HttpClient 4.5.8 and 5.0-beta4 releases?

2019-03-18 Thread Gary Gregory
Sounds good. Gary On Mon, Mar 18, 2019, 17:36 Oleg Kalnichevski wrote: > Folks > > Any objections to releasing HttpClient 4.5.8 and 5.0-beta4 this month? > > Cheers > > Oleg > > > - > To unsubscribe, e-mail: dev-unsubscr...@hc.

Re: [VOTE] Release HttpClient 4.5.8 based on RC1

2019-03-27 Thread Gary Gregory
+1 >From src zip: ASC OK SHA512 OK RAT check OK: mvn apache-rat:check Clirr check OK: mvn clirr:check -P!use-toolchains OK testing 'mvn clean package -V -P!use-toolchain' with Oracle Java 8: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\

Re: [VOTE] Release HttpClient 4.5.8 based on RC1

2019-03-29 Thread Gary Gregory
Ping for another vote from the PMC... Gary On Tue, Mar 26, 2019 at 10:38 AM Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 4.5.8. > The vote is open for the at least 72 hours, and only votes from > HttpComponents PMC members are binding. The vote passes if at l

Re: [jira] [Created] (HTTPCLIENT-1979) HttpComponents SVN tags missing

2019-03-31 Thread Gary Gregory
The project migrated to git a while ago. Gary On Sun, Mar 31, 2019, 14:36 Marek Sebera (JIRA) wrote: > Marek Sebera created HTTPCLIENT-1979: > > > Summary: HttpComponents SVN tags missing > Key: HTTPCLIENT-1979 >

[httpcore] offer more information on bind exceptions

2019-04-04 Thread Gary Gregory
Hi All: Whenever I get a socket bind error, the JRE does not tell me which socket and port I am dealing with. Is anyone objected to a PR that would do this: diff --git a/httpcore5/src/main/java/org/apache/hc/core5/reactor/SingleCoreListeningIOReactor.java b/httpcore5/src/main/java/org/apache/hc/c

Re: [VOTE] Release HttpClient 5.0-beta4 based on RC1

2019-04-04 Thread Gary Gregory
+1 Tested with the RC tag. RAT check OK. Building and testing on Oracle Java 8 OK with 'mvn clean package': Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T14:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 1.8.0_202, vendor: Oracle Corporation,

Re: [VOTE] Release HttpClient 5.0-beta4 based on RC1

2019-04-04 Thread Gary Gregory
4:41:47-04:00) Maven home: C:\Java\apache-maven-3.6.0\bin\.. Java version: 13-ea, vendor: Oracle Corporation, runtime: C:\Program Files\Java\openjdk\jdk-13 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: &q

Re: [httpcore] offer more information on bind exceptions

2019-04-04 Thread Gary Gregory
On Thu, Apr 4, 2019 at 9:09 AM Oleg Kalnichevski wrote: > On Thu, 2019-04-04 at 08:52 -0400, Gary Gregory wrote: > > Hi All: > > > > Whenever I get a socket bind error, the JRE does not tell me which > > socket > > and port I am dealing with. Is anyone object

Re: 5.0 API freeze (5.0 GA)

2019-04-05 Thread Gary Gregory
I do not have anything pending. Gary On Thu, Apr 4, 2019 at 3:50 AM Oleg Kalnichevski wrote: > Folks > > I have a feeling that delaying 5.0 API freeze much longer does us > little good. > > There is a vast group of people who (regrettably) will not touch > anything with BETA in its release vers

Re: 5.0 API freeze (5.0 GA)

2019-04-05 Thread Gary Gregory
Once 5.0 is out we cannot break binary compatibility at all. That would be for a 6.0 which would also require a package name change. Gary On Fri, Apr 5, 2019, 20:53 Ryan Schmitt wrote: > I doubt I will; I'm completely overwhelmed with work right now. I mentioned > the idea for completeness as s

Re: [httpcomponents-client] 01/01: HTTPCLIENT-1981: disallow TRACE requests with an enclosed entity

2019-04-10 Thread Gary Gregory
Oleg, > StandardMethods.TRACE.name () + "requests may not include an entity." I think you are missing a space before "request": StandardMethods.TRACE.name () + " requests may not include an entity." Gary On Wed, Apr 10, 20

[HttpCore5] Accessing the HTTP entity for reading and writing in a NIO proxy

2019-04-25 Thread Gary Gregory
Hi Oleg and All: It's seems clear to me, and correct me if I am wrong, that if I want my custom async proxy to manipulate an HTTP body/entity, I have to do it in org.apache.hc.core5.http.nio.AsyncDataConsumer.streamEnd(List), for example here: https://github.com/apache/httpcomponents-core/blob/ma

Re: [HttpCore5] Accessing the HTTP entity for reading and writing in a NIO proxy

2019-04-30 Thread Gary Gregory
On Fri, Apr 26, 2019 at 3:21 AM Oleg Kalnichevski wrote: > On Thu, 2019-04-25 at 18:46 -0400, Gary Gregory wrote: > > Hi Oleg and All: > > > > It's seems clear to me, and correct me if I am wrong, that if I want > > my > > custom async proxy to manipulat

[HttpCore 5] BasicClassicHttpRequest fluent setters

2019-05-09 Thread Gary Gregory
Hi All: Would you all be OK if the setters in BasicClassicHttpRequest and friends were fluent? Gary

Re: HC 5.0 GA soon?

2019-05-30 Thread Gary Gregory
Not from my POV. It would be nice to flush out the current code as another beta just so folks can use that as 'stable' before 5.0 which would ideally then just be a label change. Gary On Thu, May 30, 2019, 06:37 Oleg Kalnichevski wrote: > Folks > > Is there any point delaying the 5.0 GA release

Re: [httpcomponents-core] branch message-support updated (d31f4ff -> 1a3aff6)

2019-05-31 Thread Gary Gregory
Unless I am missing something, this kind of large change set tells me we are not quite ready for 5.0 but at least one or two more betas will be a good thing. Gary On Fri, May 31, 2019 at 1:51 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > olegk pushed a chan

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC1

2019-06-06 Thread Gary Gregory
Testing on Java 11.0.3 gives me a stack overflow error: mvn clean install -V -P!use-toolchains Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\Progr

HTTP Warning header

2019-06-06 Thread Gary Gregory
Hi All, I need to generate HTTP Warning headers and I was wondering if a formatting utility would be in scope for HTTP code since the formatting is a bit tedious: https://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html [] Something like HttpWarning.format(warnCode, warnAgent, warnText, warnD

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC1

2019-06-07 Thread Gary Gregory
On Fri, Jun 7, 2019 at 8:53 AM Oleg Kalnichevski wrote: > On Thu, 2019-06-06 at 20:16 -0400, Gary Gregory wrote: > > Testing on Java 11.0.3 gives me a stack overflow error: > > > > mvn clean install -V -P!use-toolchains > > > > Gary, > > Before I proceed

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC1

2019-06-07 Thread Gary Gregory
How about renaming H1Config for this beta? Gary On Fri, Jun 7, 2019, 12:07 Oleg Kalnichevski wrote: > On Fri, 2019-06-07 at 10:44 -0400, Gary Gregory wrote: > > On Fri, Jun 7, 2019 at 8:53 AM Oleg Kalnichevski > > wrote: > > > > > On Thu, 2019-06-06 at 2

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC1

2019-06-07 Thread Gary Gregory
(Using not so great email app, sorry for top posting) See other thread where I had suggested Http1Config. HttpConfig would be Ok as well. Gary On Fri, Jun 7, 2019, 12:26 Oleg Kalnichevski wrote: > On Fri, 2019-06-07 at 12:09 -0400, Gary Gregory wrote: > > How about renaming H1Config

Mix of prefix for type names WAS: [httpcomponents-core] 02/02: Improved protocol I/O logging

2019-06-07 Thread Gary Gregory
Hi All: Looking at this commit reminds me that: - Sometimes we have names that start with H2 like H2RequesterBootstrap - Sometimes we have names that start with Http2 like Http2StreamListener I find the mix not a good thing and confusing. Same for "H1", see other email thread. Gary On Fri, Jun

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC1

2019-06-07 Thread Gary Gregory
I will propose a PR today. Gary On Fri, Jun 7, 2019 at 12:39 PM Oleg Kalnichevski wrote: > On Fri, 2019-06-07 at 12:30 -0400, Gary Gregory wrote: > > (Using not so great email app, sorry for top posting) > > > > See other thread where I had suggested Http1Config. HttpC

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC1

2019-06-07 Thread Gary Gregory
On Fri, Jun 7, 2019 at 1:15 PM Gary Gregory wrote: > I will propose a PR today. > PR is here https://github.com/apache/httpcomponents-core/pull/129 Gary > > Gary > > On Fri, Jun 7, 2019 at 12:39 PM Oleg Kalnichevski > wrote: > >> On Fri, 2019-06-07 at 1

Re: [VOTE] Release HttpClient 4.5.9 based on RC1

2019-06-10 Thread Gary Gregory
+1 Apache RAT check OK. Apache CLIRR check OK. Ran ' mvn clean site -V -P!use-toolchains' OK with: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: 11.0.3, vendor: Oracle Corporation, runtime: C:\

Re: [VOTE] Release HttpClient 4.5.9 based on RC1

2019-06-10 Thread Gary Gregory
On Mon, Jun 10, 2019 at 12:00 PM Gary Gregory wrote: > +1 > > Apache RAT check OK. > Apache CLIRR check OK. > > Ran ' mvn clean site -V -P!use-toolchains' OK with: > > Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; > 2019-04-04T15:00:29-04:0

Http2, H2, Http, Http, H1

2019-06-11 Thread Gary Gregory
Hi All: Here are two PRs for http-core and http-client for Http2* -> H2* https://github.com/apache/httpcomponents-core/pull/130 https://github.com/apache/httpcomponents-client/pull/152 If you look at these, the next item that stands out are the Http1* types which feel (to me) should be renamed t

Re: Http2, H2, Http, Http, H1

2019-06-11 Thread Gary Gregory
On Tue, Jun 11, 2019 at 5:37 PM Oleg Kalnichevski wrote: > On Tue, 2019-06-11 at 16:48 -0400, Gary Gregory wrote: > > Hi All: > > > > Here are two PRs for http-core and http-client for Http2* -> H2* > > > > https://github.com/apache/httpcomponents-core/pu

Re: Http2, H2, Http, Http, H1

2019-06-12 Thread Gary Gregory
On Wed, Jun 12, 2019 at 3:23 AM Oleg Kalnichevski wrote: > On Tue, 2019-06-11 at 20:39 -0400, Gary Gregory wrote: > > On Tue, Jun 11, 2019 at 5:37 PM Oleg Kalnichevski > > wrote: > > > ... > > > > > I think should start by merging the two PRs above. This w

Re: Http2, H2, Http, Http, H1

2019-06-12 Thread Gary Gregory
On Wed, Jun 12, 2019 at 3:19 AM Michael Osipov wrote: > Am 2019-06-12 um 02:39 schrieb Gary Gregory: > > On Tue, Jun 11, 2019 at 5:37 PM Oleg Kalnichevski > wrote: > > > >> On Tue, 2019-06-11 at 16:48 -0400, Gary Gregory wrote: > >>> Hi All: > >>

Re: Http2, H2, Http, Http, H1

2019-06-12 Thread Gary Gregory
ich started this set of threads. I then wonder and hope that all classes that start with Http* are generic to either H1 or H2. What the truth there? Gary On Wed, Jun 12, 2019 at 9:02 AM Gary Gregory wrote: > On Wed, Jun 12, 2019 at 3:19 AM Michael Osipov > wrote: > >> Am 2019-06-1

Backport org.apache.hc.core5.http.URIScheme to HC 4

2019-06-14 Thread Gary Gregory
Hi All: I have to maintain code bases that use HCore 4 and HCore 5. It would help some of my code look similar if I we had an HC 4 version of org.apache.hc.core5.http.URIScheme. Any thoughts on doing so? Gary

[CSV] Broken build

2019-06-15 Thread Gary Gregory
The current master build yields: [ERROR] CSVFormatTest.testHashCodeAndWithIgnoreHeaderCase:523 [ERROR] CSVFormatTest.testWithHeaderComments:972 I do not think it is OK to push fixes that break the build. Gary

Re: Http2, H2, Http, Http, H1

2019-06-15 Thread Gary Gregory
On Wed, Jun 12, 2019 at 9:05 AM Gary Gregory wrote: > I will now refresh this thread with some questions from my initial post: > > If you look the PRs (Http2 -> H2), the next item that stands out are the > Http1* types which feel (to me) should be renamed to H1* for _consist

Re: [CSV] Broken build

2019-06-15 Thread Gary Gregory
Oops On Sat, Jun 15, 2019, 08:35 wrote: > Commons dev mailing list? ;) > > Best regards. > > On 15/06/2019 13:22, Gary Gregory wrote: > > The current master build yields: > > > > [ERROR] CSVFormatTest.testHashCodeAndWithIgnoreHeaderCase:523 > > [ERROR]

Re: HttpCore 5.0-beta8 release blocked

2019-06-20 Thread Gary Gregory
Hi Oleg, - Thank you for your patience. - My PR is https://github.com/apache/httpcomponents-core/pull/130 and consists of two commits (see below.) The PR was in conflict due to this weeks changes on master and is now caught up. - "Http2" prefixes have been renamed to "H2" such that most HTTP/2 cl

Re: HttpCore 5.0-beta8 release blocked

2019-06-20 Thread Gary Gregory
On Thu, Jun 20, 2019 at 12:41 PM Oleg Kalnichevski wrote: > On Thu, 2019-06-20 at 09:32 -0400, Gary Gregory wrote: > > Hi Oleg, > > > > > > ... > > > - Shouldn't Conscrypt support be in its own module to avoid Maven > > sucking > > in tha

Re: [httpcomponents-client] 01/01: Logging of multihome connect operations

2019-06-27 Thread Gary Gregory
On Thu, Jun 27, 2019 at 2:22 PM wrote: > This is an automated email from the ASF dual-hosted git repository. > > olegk pushed a commit to branch improved-logging > in repository > https://gitbox.apache.org/repos/asf/httpcomponents-client.git > > commit a0aa438be8f42d3401455f8bfc4716cb534b6e45 > A

Re: [httpcomponents-core] 01/01: HTTPCORE-581: Wrong deadline calculation for non-blocking i/o operations

2019-06-28 Thread Gary Gregory
On Fri, Jun 28, 2019 at 10:12 AM wrote: > This is an automated email from the ASF dual-hosted git repository. > > olegk pushed a commit to branch HTTPCORE-581 > in repository https://gitbox.apache.org/repos/asf/httpcomponents-core.git > > commit cef0c10d969ef7627b034578cd85e7fd05c8bccd > Author:

Re: HttpCore 5.0-beta8 RC2 tomorrow

2019-07-05 Thread Gary Gregory
Oleg, On the one hand, yes, another beta is great, since the changes over the last week are large and complex. I am also looking forward to a new HttpClient to test down the line. On the other hand, I am baffled by your silence on my repeated questions surrounding Http2/H2/Http1/H1 naming PR. I wo

Re: HttpCore 5.0-beta8 RC2 tomorrow

2019-07-06 Thread Gary Gregory
On Sat, Jul 6, 2019 at 4:57 AM Oleg Kalnichevski wrote: > On Fri, 2019-07-05 at 19:31 +0200, Oleg Kalnichevski wrote: > > On Fri, 2019-07-05 at 13:26 -0400, Gary Gregory wrote: > > > Oleg, > > > > > > On the one hand, yes, another beta is great, since the ch

Re: HttpCore 5.0-beta8 RC2 tomorrow

2019-07-06 Thread Gary Gregory
Running 'mvn -V clean install -P !use-toolchains' passes with: - Oracle Java 1.8.0_212 - Oracle Java 11.0.3 - OpenJDK 13-ea - OpenJDK 14-ea Gary On Fri, Jul 5, 2019 at 12:23 PM Oleg Kalnichevski wrote: > Folks > > There have been a number of important bug fixes that we need to make > available

Re: [VOTE] Release HttpCore 5.0-beta8 based on RC2

2019-07-12 Thread Gary Gregory
+1 RAT check OK. Builds from the RC git tag succeeds with: mvn -V clean install -P!use-toolchains Using the following JDKs: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version:* 1.8.0_212, vendor: O

Re: [VOTE] Release HttpClient 5.0-beta5 based on RC1

2019-07-18 Thread Gary Gregory
The changelog in the release note should mention the HttpCore update to beta 8. I will review in full later today. Gary On Thu, Jul 18, 2019, 06:41 Oleg Kalnichevski wrote: > Please vote on releasing these packages as HttpClient 5.0-beta5. > The vote is open for the at least 72 hours, and only

Re: [VOTE] Release HttpClient 5.0-beta5 based on RC1

2019-07-18 Thread Gary Gregory
+1 Based on the tag: Apache RAT check OK Running: mvn -V clean install -P !use-toolchains Using the following JDKs: Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T15:00:29-04:00) Maven home: C:\Java\apache-maven-3.6.1\bin\.. Java version: *1.7.0_80, vendor: Oracle Corpo

Re: Next HttpCore 4.4 and HttpCore 5.0 releases

2019-08-23 Thread Gary Gregory
I think it would be ideal to go GA after one Beta cycle where no public APIs or significant implementation areas have changed in master for a time period of... one month? Two months? Gary On Fri, Aug 23, 2019, 06:23 Oleg Kalnichevski wrote: > Folks > > I would like to cut new releases of HttpCo

Re: svn commit: r1865743 - /httpcomponents/httpasyncclient/branches/4.1.x/httpasyncclient/src/main/java/org/apache/http/impl/nio/client/PipeliningClientExchangeHandlerImpl.java

2019-08-23 Thread Gary Gregory
Svn? Gary On Fri, Aug 23, 2019, 07:07 wrote: > Author: olegk > Date: Fri Aug 23 11:07:41 2019 > New Revision: 1865743 > > URL: http://svn.apache.org/viewvc?rev=1865743&view=rev > Log: > Bug fix: PipeliningClientExchangeHandlerImpl to fail result future in case > of an execution failure > > Modi

Re: Next HttpCore 4.4 and HttpCore 5.0 releases

2019-08-23 Thread Gary Gregory
On Fri, Aug 23, 2019 at 7:32 AM Oleg Kalnichevski wrote: > On Fri, 2019-08-23 at 07:09 -0400, Gary Gregory wrote: > > I think it would be ideal to go GA after one Beta cycle where no > > public > > APIs or significant implementation areas have changed in master for a &

Re: Stale release branches

2019-08-23 Thread Gary Gregory
On Fri, Aug 23, 2019 at 7:40 AM Oleg Kalnichevski wrote: > Folks > > There is a number of release branches that we will never ever release > from any more. They cause no harm but sometimes get in the way. > > I would like to delete them unless someone objects very loudly. > > https://github.com/a

Re: Stale release branches

2019-08-24 Thread Gary Gregory
On Fri, Aug 23, 2019 at 8:57 AM Oleg Kalnichevski wrote: > On Fri, 2019-08-23 at 08:26 -0400, Gary Gregory wrote: > > On Fri, Aug 23, 2019 at 7:40 AM Oleg Kalnichevski > > wrote: > > > > > Folks > > > > > > There is a number of release branches

Re: HttpCore 4.4.12 release preparation

2019-08-31 Thread Gary Gregory
Thanks for the heads-up Oleg. I fixed a few nits. Gary On Sat, Aug 31, 2019 at 5:07 AM Oleg Kalnichevski wrote: > Folks > > I am preparing HttpCore 4.4.12 release. Please find the release notes > below and see if I have missed anything. Feel free to tweak the notes. > > > https://github.com/apa

Re: [VOTE] Release HttpCore 4.4.12 based on RC1

2019-09-01 Thread Gary Gregory
+1 Not a blocker but should be fixed: The Apache CLIRR check incorrectly compares to version 4.4 instead of 4.4.11. CLIRR check passes against version 4.4. Apache RAT OK. Building 'mvn clean package' with a toolchain pointing to Oracle Java 1.7.0_80 OK: Building 'mvn -P !use-toolchains' clean p

Re: [httpcomponents-client] branch 4.5.x updated: Remove extra parens.

2019-09-05 Thread Gary Gregory
; https://gitbox.apache.org/repos/asf/httpcomponents-client.git > > > > > > The following commit(s) were added to refs/heads/4.5.x by this push: > > new c6a9c75 Remove extra parens. > > c6a9c75 is described below > > > > commit c6a9c7568170b6df12b63396ba

Re: [VOTE] Release HttpClient 4.5.10 based on RC1

2019-09-05 Thread Gary Gregory
+1 >From the git tag: - Apache RAT check OK - Apache CLIRR check OK - Java 8 with toolchains pointing to Java 7 OK: mvn -V clean package - Java 8 with toolchains disabled OK: mvn -V clean package -P !use-toolchains - Java 11 breaks on many Javadoc comments (not listed here) - Java 11 with doclink

Tagging releases

2019-09-09 Thread Gary Gregory
I was just made aware over at Apache Commons that Apache Infra will protect/preserve tags under "rel/" such that these cannot be deleted and should be used for the purpose of tagging releases. Please see below. -- Forwarded message - From: David Nalley Date: Sun, 10 Jan 2016 at 18

Re: Tagging releases

2019-09-09 Thread Gary Gregory
On Mon, Sep 9, 2019 at 9:33 AM Oleg Kalnichevski wrote: > On Mon, 2019-09-09 at 08:17 -0400, Gary Gregory wrote: > > I was just made aware over at Apache Commons that Apache Infra will > > protect/preserve tags under "rel/" such that these cannot be deleted > >

Re: TLS/SSL NIO improvements / 5.0 GA likely delayed

2019-09-12 Thread Gary Gregory
That all makes sense. It would be good to have another beta once this non-trivial work is done. Gary On Thu, Sep 12, 2019, 10:32 Oleg Kalnichevski wrote: > Folks > > I have decided to revisit the NIO based TLS/SSL implementation and see > if I could resolve the issue with internal data bufferin

Re: Tagging releases

2019-09-27 Thread Gary Gregory
On Fri, Sep 27, 2019 at 10:08 AM Oleg Kalnichevski wrote: > On Mon, 2019-09-09 at 15:33 +0200, Oleg Kalnichevski wrote: > > On Mon, 2019-09-09 at 08:17 -0400, Gary Gregory wrote: > > > I was just made aware over at Apache Commons that Apache Infra will > > > prote

Re: [VOTE] Release HttpCore 5.0-beta9 based on RC1

2019-10-01 Thread Gary Gregory
+1 Tested using the RC tag. Apache RAT check OK. All builds using Maven: - Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T11:06:16-04:00) - Maven home: C:\Java\apache-maven-3.6.2\bin\.. - Default locale: en_US, platform encoding: Cp1252 - OS name: "windows 10", version:

Re: HttpClient 5.0-beta6 release notes

2019-10-05 Thread Gary Gregory
Done. Thank you Oleg for shepherding another RC. Gary On Fri, Oct 4, 2019 at 10:03 AM Oleg Kalnichevski wrote: > Folks > > Please review / amend release notes for HttpClient 5.0-beta6 release. > > > https://github.com/apache/httpcomponents-client/blob/release-preparation/RELEASE_NOTES.txt > > O

Re: [VOTE] Release HttpClient 5.0-beta6 based on RC1

2019-10-06 Thread Gary Gregory
+1 Based on the git tag. Apache RAT check OK Building OK with 'mvn -V clean package' and: Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T11:06:16-04:00) Maven home: C:\Java\apache-maven-3.6.2\bin\.. Java version: 1.8.0_221, vendor: Oracle Corporation, runtime: C:\Progr

Re: HttpCore 5.0 & 4.4 releases soon

2019-10-24 Thread Gary Gregory
I will be available :-) On Thu, Oct 24, 2019 at 9:26 AM Oleg Kalnichevski wrote: > Folks > > There has been a number of important fixes in master and 4.4.x branch. > I would like to cut new versions from both branches sometime next week. > > Will there be enough people to cast votes? > > Cheers

Re: Extending DefaultServiceUnavailableRetryStrategy

2019-10-28 Thread Gary Gregory
On Mon, Oct 28, 2019 at 7:10 AM Michael Osipov wrote: > Am 2019-10-28 um 10:00 schrieb Oleg Kalnichevski: > > On Sun, 2019-10-27 at 12:30 +0100, Michael Osipov wrote: > >> Am 2019-10-23 um 09:35 schrieb Oleg Kalnichevski: > >>> On Tue, 2019-10-22 at 19:47 +0200, Michael Osipov wrote: > Am 20

Re: Extending DefaultServiceUnavailableRetryStrategy

2019-10-28 Thread Gary Gregory
On Mon, Oct 28, 2019 at 9:02 AM Oleg Kalnichevski wrote: > On Mon, 2019-10-28 at 12:10 +0100, Michael Osipov wrote: > > ... > > > We are still in beta, why not? Or make a generic interface > > RetryStrategy > > and make ServiceUnavailableRetryStrategy extend it with marked as > > deprecated. I wa

Re: [VOTE] Release HttpCore 5.0-beta10 based on RC1

2019-10-29 Thread Gary Gregory
Apache RAT check OK Building generates Javadoc WARNING messages. Building with 'mvn clean package -V -P!use-toolchains' succeeds using: Apache Maven 3.6.2 (40f52333136460af0dc0d7232c0dc0bcf0d9e117; 2019-08-27T11:06:16-04:00) Maven home: C:\Java\apache-maven-3.6.2\bin\.. Java version: *1.8.0_231*,

Re: [VOTE][RESULT] Release HttpComponents Core 5.0-beta10 based on RC1

2019-10-31 Thread Gary Gregory
I thought I had voted... oh well. On a different note, I see here https://search.maven.org/search?q=g:org.apache.httpcomponents.core5%20AND%20a:httpcore5&core=gav that Beta10 is listed as released 3 days ago. How can that be? Gary On Thu, Oct 31, 2019 at 8:31 AM Oleg Kalnichevski wrote: > The v

Re: [VOTE][RESULT] Release HttpComponents Core 5.0-beta10 based on RC1

2019-10-31 Thread Gary Gregory
On Thu, Oct 31, 2019 at 10:04 AM Oleg Kalnichevski wrote: > On Thu, 2019-10-31 at 10:03 -0400, Gary Gregory wrote: > > I thought I had voted... oh well. On a different note, I see here > > > > https://search.maven.org/search?q=g:org.apache.httpcomponents.core5%20AND%2

<    5   6   7   8   9   10   11   12   13   14   >