[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309488415 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309488603 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309488920 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309489105 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309487463 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309489253 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309488692 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r309479179 ## File path:

[GitHub] [helix] i3wangyi opened a new pull request #369: Add the workaround fix for assigning partitions when instance weight …

i3wangyi opened a new pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369 **Issues** fix #368 **Description** - Added the unit test to cover the existing assignment calculations - Added the

[GitHub] [helix] i3wangyi opened a new issue #368: Set instance_weight = 0 in config doesn't mean no partition assigned to the instance

i3wangyi opened a new issue #368: Set instance_weight = 0 in config doesn't mean no partition assigned to the instance URL: https://github.com/apache/helix/issues/368 **Problem** The issue is raised by our internal client who sets the instance_weight = 0 in instance/config. Instead of

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309483162 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309481796 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309482207 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309481980 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307853541 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309482357 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307854632 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309479577 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientFactory.java

[GitHub] [helix] i3wangyi commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

i3wangyi commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r309479407 ## File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309477945 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientFactory.java

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309477094 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309476679 ## File path: helix-rest/src/test/java/org/apache/helix/rest/client/TestCustomRestClient.java

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309476373 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309475749 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309475493 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-517060382 This would really help as you guys know the use case better and how this api is used . I believe we should optimize it and trade off

[GitHub] [helix] narendly commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

narendly commented on issue #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#issuecomment-517059657 @pkuwm Good progress, but I have alternative thoughts on how this should be implemented. This is a simple list call in the Helix

[GitHub] [helix] narendly commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

narendly commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r309471472 ## File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309470178 ## File path: helix-rest/src/test/java/org/apache/helix/rest/client/TestCustomRestClient.java

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309470235 ## File path: helix-rest/src/test/java/org/apache/helix/rest/client/TestCustomRestClient.java

[GitHub] [helix] narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

narendly commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309469352 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309467486 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309466643 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientFactory.java

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309462916 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309460673 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r309458304 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r309455471 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r308992497 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] i3wangyi opened a new pull request #367: Add transient cache for CustomRestClient implementation

i3wangyi opened a new pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367 Related to #366 The first step to add cache support for CustomRestClient //TODO will update the description in more detail.

[GitHub] [helix] i3wangyi opened a new issue #366: Not run in parallel and a waste of duplicate rest requests in `getParallelStoppableInstances`

i3wangyi opened a new issue #366: Not run in parallel and a waste of duplicate rest requests in `getParallelStoppableInstances` URL: https://github.com/apache/helix/issues/366 The implementation of the method

[GitHub] [helix] jiajunwang merged pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang merged pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308951044 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308948035 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308945519 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308924138 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308923135 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308896237 ## File path:

[GitHub] [helix] jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516551473 Thanks for reviewing. About the ConcurrentHashMap, I agree this becomes an overkill with this change. But the next move

[GitHub] [helix] Jackie-Jiang commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

Jackie-Jiang commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516543932 > > There are two ways of solving the race condition by using atomic operations, either use ConcurrentHashMap or

[GitHub] [helix] i3wangyi commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

i3wangyi commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516538608 > There are two ways of solving the race condition by using atomic operations, either use ConcurrentHashMap or

[GitHub] [helix] i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308872667 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308872076 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

lei-xia commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308836082 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308554643 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308553871 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308553465 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308553465 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308553206 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308552201 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308549588 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

jiajunwang commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308548892 ## File path:

[GitHub] [helix] jiajunwang commented on issue #331: CallbackHandler async re-subscribe watcher can potentially miss events

jiajunwang commented on issue #331: CallbackHandler async re-subscribe watcher can potentially miss events URL: https://github.com/apache/helix/issues/331#issuecomment-516272475 @Jackie-Jiang Could you please help to take a look at the proposed fix? Thanks.

[GitHub] [helix] jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308541153 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308503841 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308503841 ## File path:

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-516210666 Thanks for the comments, I have addressed most of them today. I will work on the tests and re-construct the commits before converting

[GitHub] [helix] kaisun2000 commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

kaisun2000 commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308489309 ## File path:

[GitHub] [helix] jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516194738 > I think a unit test for verifying the race condition of propertyChangedMap is still needed. To manipulate the

[GitHub] [helix] i3wangyi commented on a change in pull request #359: Dynamically change the processor thread name when consuming event

i3wangyi commented on a change in pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#discussion_r308470742 ## File path: helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java

[GitHub] [helix] jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308461347 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308460992 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308460856 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308455916 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308446844 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308441158 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache.

i3wangyi commented on a change in pull request #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#discussion_r308443459 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308446959 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308446959 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r308442057 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r308438347 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r308437350 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308436226 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308436117 ## File path:

[GitHub] [helix] jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516160362 Re-run the test with the latest update: [ERROR] Failures: [ERROR]

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308434992 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308434250 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

i3wangyi commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308433322 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308428467 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308423912 ## File path:

[GitHub] [helix] pkuwm commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

pkuwm commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308392249 ## File path:

[GitHub] [helix] jiajunwang edited a comment on issue #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang edited a comment on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516107112 @i3wangyi After tried to add the test, I found the test case that we discussed just tests for the specific

[GitHub] [helix] jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

jiajunwang commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516107112 @i3wangyi After tried to add the test, I found the test case that we discussed just tests for the specific design that

[GitHub] [helix] i3wangyi commented on issue #363: Fix the race condition while Helix refresh cluster status cache.

i3wangyi commented on issue #363: Fix the race condition while Helix refresh cluster status cache. URL: https://github.com/apache/helix/pull/363#issuecomment-516104476 Can you add a test case? This is an automated message

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308356887 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308356706 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308356245 ## File path: helix-core/src/main/java/org/apache/helix/spectator/RoutingTableProvider.java

[GitHub] [helix] lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

lei-xia commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r308355503 ## File path:

[GitHub] [helix] kaisun2000 opened a new pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

kaisun2000 opened a new pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365 **Issue**: #364 CurrentStateCache updating snapshot would miss all the existing partitions that having state change.

[GitHub] [helix] pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

pkuwm commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r307987847 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver.

pkuwm commented on a change in pull request #357: [WIP] Add getWorkflows(long timeout) to TaskDriver. URL: https://github.com/apache/helix/pull/357#discussion_r307947633 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ## @@ -115,14 +155,58 @@

<    1   2   3   4   5   6   7   >