[GitHub] [helix] dasahcc commented on issue #339: Implementation of stateModelDef modification in REST 2.0

dasahcc commented on issue #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#issuecomment-513421460 Let's use Helix template formatter in the intellij to do the work. We have our own style.

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r305560790 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r305560683 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r305560464 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r305560424 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r305560371 ## File path: helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java ##

[GitHub] [helix] pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0

pkuwm commented on a change in pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339#discussion_r305560197 ## File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java

[GitHub] [helix] pkuwm commented on issue #338: Implementation of StateModelDef access in rest 2.0

pkuwm commented on issue #338: Implementation of StateModelDef access in rest 2.0 URL: https://github.com/apache/helix/issues/338#issuecomment-513419608 I saw the diff right after leaving the comment. Thanks. This is an

[GitHub] [helix] pkuwm commented on issue #338: Implementation of StateModelDef access in rest 2.0

pkuwm commented on issue #338: Implementation of StateModelDef access in rest 2.0 URL: https://github.com/apache/helix/issues/338#issuecomment-513419178 @kaisun2000 Are you working on this? If not, I am considering to contribute to this ticket. Thanks.

[GitHub] [helix] alirezazamani closed pull request #347: Read Failure while reading non-existent znode.

alirezazamani closed pull request #347: Read Failure while reading non-existent znode. URL: https://github.com/apache/helix/pull/347 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] alirezazamani opened a new pull request #347: Read Failure while reading non-existent znode.

alirezazamani opened a new pull request #347: Read Failure while reading non-existent znode. URL: https://github.com/apache/helix/pull/347 In this commit, when we encounter NoNodeException while reading data from a znode that does not exist, we catch NoNodeException and do not increase

[GitHub] [helix] alirezazamani opened a new pull request #346: Unwanted logs have been removed.

alirezazamani opened a new pull request #346: Unwanted logs have been removed. URL: https://github.com/apache/helix/pull/346 In this commit unwanted logs which were written for NPE testing have been removed. Test Results: [INFO] Tests run: 834, Failures: 0, Errors: 0, Skipped: 0,

[GitHub] [helix] alirezazamani opened a new issue #345: Read failure while reading/accessing a non-existent Zookeeper node

alirezazamani opened a new issue #345: Read failure while reading/accessing a non-existent Zookeeper node URL: https://github.com/apache/helix/issues/345 In Zookeeper client, when a znode doesn't exist (NoNodeException) a readFailure will be reported which shouldn't happen.

[GitHub] [helix] jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305213226 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305213080 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305210626 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305209113 ## File path:

[GitHub] [helix] dasahcc commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

dasahcc commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305171886 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305170919 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305170560 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305170167 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305169653 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305169085 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305168825 ## File path:

[GitHub] [helix] i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#issuecomment-513032668 The latest commit added the integration test. The test verifies at most 1 ST occurs at a time on any instance when

[GitHub] [helix] jiajunwang commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-513003050 Modified the commit, now we only have the interface defined. Please review and we can start from this commit.

[GitHub] [helix] dasahcc commented on issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica

dasahcc commented on issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica URL: https://github.com/apache/helix/issues/343#issuecomment-513000467 @i3wangyi We need dynamically type change of ST. For example, if you have one load balance ST Offline - Slave

[GitHub] [helix] alirezazamani opened a new pull request #344: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm.

alirezazamani opened a new pull request #344: Changing IllegalStateException to Helix Exception for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/344 In this commit ComputerPartitionAssignment function throws Helix Exception instead of

[GitHub] [helix] narendly commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

narendly commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512932453 How about checking it into a separate branch? Would that be an option? Hunter ⁣Sent from BlueMail ​

[GitHub] [helix] lei-xia commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

lei-xia commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512931683 If you are only looking for temporary repo to park the half-baked code, can we use our internal repo instead? We

[GitHub] [helix] narendly commented on issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica

narendly commented on issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica URL: https://github.com/apache/helix/issues/343#issuecomment-512928795 The root cause for this problem is because we throttle things at partition granularity. For example, if Helix

[GitHub] [helix] i3wangyi commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

i3wangyi commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512928626 I'm not that worried about checking in a bunch of commits into a separate branch. Given that - The change

[GitHub] [helix] i3wangyi commented on issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica

i3wangyi commented on issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica URL: https://github.com/apache/helix/issues/343#issuecomment-512924648 I feel like we need to put more background knowledge and context on the topic. For example, why Helix will

[GitHub] [helix] narendly commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

narendly commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512915444 What do you think about maybe squashing them into 5-6 PRs (by component, for example) and linking them all in

[GitHub] [helix] lei-xia commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

lei-xia commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512914106 Then is it possible for you to break them into small PRs, it will not be possible to review 25 commits in a

[GitHub] [helix] jiajunwang commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512911218 Yes, these are not officially reviewed before. Most of the code was done by Neal. But for integration, I

[GitHub] [helix] lei-xia commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

lei-xia commented on issue #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#issuecomment-512907487 This is a giant change list, are you supposing some of us to review it?

[GitHub] [helix] dasahcc opened a new issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica

dasahcc opened a new issue #343: Fine-grained state transition throttling and respect MIN_ACTIVE replica URL: https://github.com/apache/helix/issues/343 MIN_ACTIVE replica is only applied in DelayAutoRebalancer and not respected by throttling logic in Helix. Thus if preference list for

[GitHub] [helix] dasahcc merged pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

dasahcc merged pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] dasahcc closed issue #334: Invoke rebalance by "touching" IdealState/ResourceConfig

dasahcc closed issue #334: Invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/issues/334 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [helix] jiajunwang opened a new issue #342: Kickoff for the Weight Aware Globally Even Distribute Rebalancer

jiajunwang opened a new issue #342: Kickoff for the Weight Aware Globally Even Distribute Rebalancer URL: https://github.com/apache/helix/issues/342 We will soon start the development of the new rebalancer.

[GitHub] [helix] jiajunwang opened a new pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer

jiajunwang opened a new pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341 This PR includes the very basic implementation based on the refined code of our previous constraint-based rebalance algorithm.

[GitHub] [helix] dasahcc commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…

dasahcc commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu… URL: https://github.com/apache/helix/pull/340#issuecomment-512512243 Why you need this? We do have metrics "Controller Pipeline Queued Time" to understand the events staying the queue.

[GitHub] [helix] narendly commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…

narendly commented on issue #340: Log the enqueue time of clusterEvent, used to measure the blocking qu… URL: https://github.com/apache/helix/pull/340#issuecomment-512508441 I'm afraid this might overwhelm the log? Would be fine to do this in a testing environment where load is simulated,

[GitHub] [helix] i3wangyi opened a new pull request #340: Log the enqueue time of clusterEvent, used to measure the blocking qu…

i3wangyi opened a new pull request #340: Log the enqueue time of clusterEvent, used to measure the blocking qu… URL: https://github.com/apache/helix/pull/340 When investigating the prod issue, I found now it lacks logs of when a ClusterEvent gets pushed into the queue. I've added the

[GitHub] [helix] alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r304500966 ## File path:

[GitHub] [helix] kaisun2000 opened a new pull request #339: Implementation of stateModelDef modification in REST 2.0

kaisun2000 opened a new pull request #339: Implementation of stateModelDef modification in REST 2.0 URL: https://github.com/apache/helix/pull/339 **Issues** My PR addresses the following Helix issues and references them in the PR title: #338 **Description** Current

[GitHub] [helix] dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304187661 ## File path: helix-core/src/test/java/org/apache/helix/util/TestRebalanceScheduler.java

[GitHub] [helix] lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r304178961 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304178598 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@

[GitHub] [helix] i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi commented on issue #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#issuecomment-512043664 Add the mvn test result. ``` Shut down zookeeper at port 2183 in thread main [ERROR] Tests run: 837,

[GitHub] [helix] alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r304162514 ## File path:

[GitHub] [helix] alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

alirezazamani commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r304162259 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r304160372 ## File path:

[GitHub] [helix] lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

lei-xia commented on a change in pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337#discussion_r304160164 ## File path:

[GitHub] [helix] kaisun2000 opened a new issue #338: Implementation of StateModelDef access in rest 2.0

kaisun2000 opened a new issue #338: Implementation of StateModelDef access in rest 2.0 URL: https://github.com/apache/helix/issues/338 Current implementation of Rest 2.0 does not support stateModelDef modification. Here, we will implement delete -- remove the stateModelDef with

[GitHub] [helix] dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

dasahcc commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304050227 ## File path: helix-core/src/test/java/org/apache/helix/util/TestRebalanceScheduler.java

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304026926 ## File path: helix-core/src/test/java/org/apache/helix/util/TestRebalanceScheduler.java

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304026414 ## File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java ## @@

[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r304025056 ## File path:

[GitHub] [helix] alirezazamani opened a new pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm.

alirezazamani opened a new pull request #337: Fixing IllegalStateException for CRUSH based rebalance strategy algorithm. URL: https://github.com/apache/helix/pull/337 In CRUSH based rebalance strategy, when there is no eligible instance for the controller to use, it shows an exception

[GitHub] [helix] jiajunwang commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

jiajunwang commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig URL: https://github.com/apache/helix/pull/336#discussion_r303740523 ## File path:

[GitHub] [helix] i3wangyi opened a new pull request #333: Fix issue when client only sets ANY at cluster level throttle config

i3wangyi opened a new pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333 **Issues** (fixes #332 Issue when client ONLY sets cluster level ANY throttle config ) **Description** The fix will

[GitHub] [helix] i3wangyi opened a new issue #332: Issue when client ONLY sets cluster level ANY throttle config

i3wangyi opened a new issue #332: Issue when client ONLY sets cluster level ANY throttle config URL: https://github.com/apache/helix/issues/332 The current implementation has a loophole when 1. When client **ONLY** sets cluster level ANY throttle config (no specific type throttle)

[GitHub] [helix] Jackie-Jiang opened a new issue #331: CallbackHandler async re-subscribe watcher can potentially miss events

Jackie-Jiang opened a new issue #331: CallbackHandler async re-subscribe watcher can potentially miss events URL: https://github.com/apache/helix/issues/331 In CallbackHandler, the re-subscription of the watcher for CALLBACK happens asynchronously. If the re-subscription happens after the

[GitHub] [helix] dasahcc commented on issue #327: Change the way Helix triggers rebalance in purgeExpiredJobs

dasahcc commented on issue #327: Change the way Helix triggers rebalance in purgeExpiredJobs URL: https://github.com/apache/helix/issues/327#issuecomment-510685974 There is a race condition if user update the ResourceConfig at same time. Say original p1 has preference list: [1, 2, 3].

[GitHub] [helix] dasahcc opened a new issue #330: AutoFallbackPropertyStore make cache path to be null

dasahcc opened a new issue #330: AutoFallbackPropertyStore make cache path to be null URL: https://github.com/apache/helix/issues/330 Current AutoFallbackPropertyStore instantiation mark the zkCachePath to be null. So the caching functionality is not work for this type of ProertyStore.

[GitHub] [helix] dasahcc commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks

dasahcc commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329#issuecomment-510239011 > 5 tests fails, should we fix the tests? There is only 1 test is unstable. We will try to fix it. I run it locally again,

[GitHub] [helix] lei-xia commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks

lei-xia commented on issue #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329#issuecomment-510227742 5 tests fails, should we fix the tests? This is an automated

[GitHub] [helix] dasahcc closed issue #328: Exclude ANY_INSTANCE for customized sibling checks

dasahcc closed issue #328: Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/issues/328 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [helix] dasahcc commented on issue #328: Exclude ANY_INSTANCE for customized sibling checks

dasahcc commented on issue #328: Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/issues/328#issuecomment-509931085 Fixed This is an automated message from the Apache Git Service. To

[GitHub] [helix] dasahcc merged pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks

dasahcc merged pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] dasahcc opened a new pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks

dasahcc opened a new pull request #329: #328 Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/pull/329 Current Helix HealthCheck API checks the ANY_INSTANCE resources, which is not necessary. Since ANY_INSTANCE resources only have single partition

[GitHub] [helix] dasahcc opened a new issue #328: Exclude ANY_INSTANCE for customized sibling checks

dasahcc opened a new issue #328: Exclude ANY_INSTANCE for customized sibling checks URL: https://github.com/apache/helix/issues/328 Current Helix HealthCheck API checks the ANY_INSTANCE resources, which is not necessary. Since ANY_INSTANCE resources only have single partition with 1

[GitHub] [helix] narendly opened a new issue #327: Change the way we trigger rebalance in purgeExpiredJobs

narendly opened a new issue #327: Change the way we trigger rebalance in purgeExpiredJobs URL: https://github.com/apache/helix/issues/327 Currently, we use ResourceConfigs to trigger a rebalance. But this is causing Helix to write a ResourceConfig back to ZK, which is not desirable when

[GitHub] [helix] narendly opened a new issue #326: Add getWorkflow(long timeout) in TaskDriver

narendly opened a new issue #326: Add getWorkflow(long timeout) in TaskDriver URL: https://github.com/apache/helix/issues/326 Sometimes ZK hangs in the getWorkflow() call, and we could provide an API with a timeout to handle this at the application level. AC: 1. Add

[GitHub] [helix] jiajunwang opened a new issue #325: We should use system provided thread Id instead of using a self maintained integer

jiajunwang opened a new issue #325: We should use system provided thread Id instead of using a self maintained integer URL: https://github.com/apache/helix/issues/325

[GitHub] [helix] narendly opened a new issue #324: Change logging level in CallbackHandler

narendly opened a new issue #324: Change logging level in CallbackHandler URL: https://github.com/apache/helix/issues/324 Go through the logs and change some debug logs to info logs since they might help with debugging. This

[GitHub] [helix] jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505184521 Great! Thanks for confirming! This is an

[GitHub] [helix] jiajunwang edited a comment on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

jiajunwang edited a comment on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505180440 Thanks for the information, @jackjlli. So you are more concerned about the verbose log, right? We

[GitHub] [helix] jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505180440 Thanks for the information, @jackjlli. So you are more concerned about the verbose log, right? We can

[GitHub] [helix] jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config

jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323#issuecomment-505162329 @DImuthuUpe, by supporting both sides configuration, we definitely cover more use cases. I think it's very nice to

[GitHub] [helix] DImuthuUpe commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config

DImuthuUpe commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323#issuecomment-505127003 @jiajunwang Good question. We can add tags to instances as much as we want. But the problem is, is it scalable?

[GitHub] [helix] jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

jackjlli commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505109075 Hi @jiajunwang , basically we recently added a resource called `leadControllerResource` in Pinot and set the

[GitHub] [helix] jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

jiajunwang commented on issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322#issuecomment-505104174 This is an error log. Could you please share the test case? What was complained is lacking an eligible

[GitHub] [helix] jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config

jiajunwang commented on issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323#issuecomment-505100927 What's the difference between using multiple instance group tags and defining a new tag that includes the

[GitHub] [helix] narendly opened a new issue #323: [HELIX-817] Support for multiple instance group tags for Job config

narendly opened a new issue #323: [HELIX-817] Support for multiple instance group tags for Job config URL: https://github.com/apache/helix/issues/323 Currently we can set only one instance group tag for a job. jobCfg.setInstanceGroupTag("INSTANCEGROUPTAG"); It will be

[GitHub] [helix] jackjlli opened a new issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled.

jackjlli opened a new issue #322: java.lang.IllegalStateException: null is thrown when resource is disabled. URL: https://github.com/apache/helix/issues/322 When CRUSH based rebalance strategy algorithm is used, if the related resource isn't enabled yet, Helix will throw

[GitHub] [helix] narendly closed issue #321: Issue testing

narendly closed issue #321: Issue testing URL: https://github.com/apache/helix/issues/321 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [helix] narendly opened a new issue #321: Issue testing

narendly opened a new issue #321: Issue testing URL: https://github.com/apache/helix/issues/321 Test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [helix] alexgreenbar commented on issue #320: Fix compile error on master branch.

alexgreenbar commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-491238706 I still got the same compile error after I did below actions 1. upgrade my maven from 3.3.1 to 3.6.1, which is the latest version 2. run

[GitHub] [helix] narendly commented on issue #320: Fix compile error on master branch.

narendly commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-491007976 I've tried on 2 different machines and it seems to work fine on both. I don't have a problem with bumping up the dependency version, but at this point,

[GitHub] [helix] alexgreenbar removed a comment on issue #320: Fix compile error on master branch.

alexgreenbar removed a comment on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490741308 > Did it not compile on the old version? Yes, I will paste more details.

[GitHub] [helix] alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r282336490 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@

[GitHub] [helix] alexgreenbar commented on issue #320: Fix compile error on master branch.

alexgreenbar commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490770796 > Did it not compile on the old version? I've provided more details on PR description.

[GitHub] [helix] alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r282358381 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@

[GitHub] [helix] alexgreenbar commented on issue #320: Fix compile error on master branch.

alexgreenbar commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490741308 > Did it not compile on the old version? Yes, I will paste more details.

[GitHub] [helix] alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

alexgreenbar commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r282336490 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@

[GitHub] [helix] jiajunwang commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release.

jiajunwang commented on a change in pull request #319: Fix long version of quickstart guide of helix 0.8.4 release. URL: https://github.com/apache/helix/pull/319#discussion_r281770856 ## File path: website/0.8.4/src/site/markdown/Quickstart.md ## @@ -406,7 +406,55 @@ Now,

[GitHub] [helix] narendly commented on issue #320: Fix compile error on master branch.

narendly commented on issue #320: Fix compile error on master branch. URL: https://github.com/apache/helix/pull/320#issuecomment-490186774 Did it not compile on the old version? This is an automated message from the Apache

<    1   2   3   4   5   6   7   >