[GitHub] [helix] mcvsubbu opened a new issue #377: Multiple problems with 0.9.0

2019-08-05 Thread GitBox
mcvsubbu opened a new issue #377: Multiple problems with 0.9.0 URL: https://github.com/apache/helix/issues/377 We see the following issues in Pinot deployment: 1. Controller callback does not happen on a PARTICIPANT helix manager when leadership changes. 2. Other participants

[GitHub] [helix] i3wangyi opened a new pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

2019-08-05 Thread GitBox
i3wangyi opened a new pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue URL: https://github.com/apache/helix/pull/376 TODO, will update everything later This is an automated message from the

[GitHub] [helix] narendly opened a new issue #375: Drop all tasks whose requested state is DROPPED

2019-08-05 Thread GitBox
narendly opened a new issue #375: Drop all tasks whose requested state is DROPPED URL: https://github.com/apache/helix/issues/375 Upon a Participant disconnect, the Participant would carry over from the last session. This would copy all previous task states to the current session and set

[GitHub] [helix] kaisun2000 commented on issue #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on issue #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#issuecomment-518453741 Resolved all the review request. Also passing the test. Next step is to merge into trunk

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310841129 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310838708 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310838708 ## File path:

[GitHub] [helix] dasahcc commented on issue #374: Stablize the REST tests in helix-rest

2019-08-05 Thread GitBox
dasahcc commented on issue #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374#issuecomment-518443325 > A lot of duplicate prints, can you check testng's BeforeMethod and AfterMethod annotations >

[GitHub] [helix] dasahcc commented on issue #374: Stablize the REST tests in helix-rest

2019-08-05 Thread GitBox
dasahcc commented on issue #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374#issuecomment-518442369 > A lot of duplicate prints, can you check testng's BeforeMethod and AfterMethod annotations >

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310832882 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310832625 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310832401 ## File path:

[GitHub] [helix] kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
kaisun2000 commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310831810 ## File path:

[GitHub] [helix] dasahcc opened a new pull request #374: Stablize the REST tests in helix-rest

2019-08-05 Thread GitBox
dasahcc opened a new pull request #374: Stablize the REST tests in helix-rest URL: https://github.com/apache/helix/pull/374 ### Issues For test stabilizing, not create an issue. ### Description - [ ] Here are some details about my PR, including screenshots of any UI

[GitHub] [helix] i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518406925 > > > The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants

[GitHub] [helix] dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518402635 > > The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants

[GitHub] [helix] i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
i3wangyi commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518397174 > The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants

[GitHub] [helix] i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
i3wangyi commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r310786737 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java

[GitHub] [helix] dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
dasahcc commented on issue #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#issuecomment-518390345 The parallel request still need to be considered. Say you are implementing the locking by keys. We need 100 participants partition

[GitHub] [helix] dasahcc merged pull request #359: Dynamically change the processor thread name when consuming event

2019-08-05 Thread GitBox
dasahcc merged pull request #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] i3wangyi commented on issue #359: Dynamically change the processor thread name when consuming event

2019-08-05 Thread GitBox
i3wangyi commented on issue #359: Dynamically change the processor thread name when consuming event URL: https://github.com/apache/helix/pull/359#issuecomment-518348999 This PR is ready to be merged, approved by @lei-xia

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r310212588 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation

2019-08-05 Thread GitBox
dasahcc commented on a change in pull request #367: Add transient cache for CustomRestClient implementation URL: https://github.com/apache/helix/pull/367#discussion_r310212407 ## File path: helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientImpl.java ##

[GitHub] [helix] narendly closed issue #358: removing DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from clusterconfig

2019-08-05 Thread GitBox
narendly closed issue #358: removing DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from clusterconfig URL: https://github.com/apache/helix/issues/358 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] narendly merged pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358

2019-08-05 Thread GitBox
narendly merged pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358 URL: https://github.com/apache/helix/pull/373 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] narendly commented on issue #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358

2019-08-05 Thread GitBox
narendly commented on issue #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358 URL: https://github.com/apache/helix/pull/373#issuecomment-518325951 This PR is ready to be merged, approved by @alirezazamani

[GitHub] [helix] narendly opened a new pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358

2019-08-05 Thread GitBox
narendly opened a new pull request #373: Remove DEFAULT_VIEW_CLUSTER_REFRESH_PERIOD from ClusterConfig #358 URL: https://github.com/apache/helix/pull/373 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: #358 ###

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310622237 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310619356 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310624803 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310621901 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310623149 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug

2019-08-05 Thread GitBox
narendly commented on a change in pull request #365: Fix RoutingTableProvider statePropagationLatency metric reporting bug URL: https://github.com/apache/helix/pull/365#discussion_r310623904 ## File path:

[GitHub] [helix] jiajunwang commented on issue #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-05 Thread GitBox
jiajunwang commented on issue #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#issuecomment-518101703 I just notice the title, this is not a workaround. Please remove this to avoid confusion.

[GitHub] [helix] jiajunwang commented on issue #342: Kickoff for the Weight Aware Globally Even Distribute Rebalancer

2019-08-02 Thread GitBox
jiajunwang commented on issue #342: Kickoff for the Weight Aware Globally Even Distribute Rebalancer URL: https://github.com/apache/helix/issues/342#issuecomment-517893119 The foundation of the new rebalancer has been built after the interface/cluster model checked in. I'm closing this

[GitHub] [helix] jiajunwang closed issue #342: Kickoff for the Weight Aware Globally Even Distribute Rebalancer

2019-08-02 Thread GitBox
jiajunwang closed issue #342: Kickoff for the Weight Aware Globally Even Distribute Rebalancer URL: https://github.com/apache/helix/issues/342 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [helix] jiajunwang merged pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang merged pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517892944 This PR is ready to be merged, approved by @narendly. I will do the merge.

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310338335 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336821 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336903 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336872 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336640 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336694 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336640 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310336585 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableNode.java

[GitHub] [helix] jiajunwang opened a new issue #372: Implement the Cluster Model data provider for the WAGED rebalancer

2019-08-02 Thread GitBox
jiajunwang opened a new issue #372: Implement the Cluster Model data provider for the WAGED rebalancer URL: https://github.com/apache/helix/issues/372 Please find the design doc here:

[GitHub] [helix] jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517854427 Thanks for your hard work of reviewing. I know it is a huge PR. Mainly because it is new classes that are built from scratch, even

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310284240 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310279995 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310280122 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310278490 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310277680 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310277478 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310277080 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310276844 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310249111 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310248906 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310246676 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310245795 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310244594 ## File path:

[GitHub] [helix] jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
jiajunwang commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310244369 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310237287 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310238349 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310239674 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310236475 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310237911 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310239447 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310239990 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310239874 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310239254 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310239855 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310236475 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310234688 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310234688 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310233448 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight …

2019-08-02 Thread GitBox
narendly commented on a change in pull request #369: Add the workaround fix for assigning partitions when instance weight … URL: https://github.com/apache/helix/pull/369#discussion_r310233448 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

2019-08-02 Thread GitBox
narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310232277 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

2019-08-02 Thread GitBox
narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310232277 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

2019-08-02 Thread GitBox
narendly commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310230832 ## File path:

[GitHub] [helix] i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config

2019-08-02 Thread GitBox
i3wangyi commented on a change in pull request #333: Fix issue when client only sets ANY at cluster level throttle config URL: https://github.com/apache/helix/pull/333#discussion_r310226396 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309939372 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310213495 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310218704 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310212807 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310170701 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310223885 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309921368 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310213728 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310214870 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309939522 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310217077 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310216570 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310216339 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310214018 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310162365 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310215326 ## File path:

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309939616 ## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModel.java

[GitHub] [helix] narendly commented on issue #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on issue #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#issuecomment-517781121 This is a big PR! I think it would be a good idea to keep the size of PRs smaller if possible.

[GitHub] [helix] narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation

2019-08-02 Thread GitBox
narendly commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r310221038 ## File path:

  1   2   3   4   5   6   7   >