[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630042 ## File path: heron/stmgr/src/cpp/manager/stmgr-server.cpp ## @@

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631017 ## File path: heron/tmaster/src/cpp/manager/stateful-controller.cpp ##

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179628026 ## File path: heron/instance/src/cpp/boltimpl/bolt-instance.cpp ## @@

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631595 ## File path: heron/stmgr/src/cpp/manager/stmgr.cpp ## @@ -282,7

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179627565 ## File path: heron/common/src/cpp/network/client.h ## @@ -245,7

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630977 ## File path: heron/tmaster/src/cpp/manager/stateful-restorer.cpp ##

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631445 ## File path: heron/stmgr/src/cpp/manager/stmgr.cpp ## @@ -1085,7

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630646 ## File path: heron/tmaster/src/cpp/manager/tmaster.cpp ## @@ -116,7

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179632002 ## File path: heron/stmgr/src/cpp/manager/stmgr-clientmgr.cpp ## @@

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179631189 ## File path: heron/stmgr/src/cpp/util/xor-manager.cpp ## @@ -59,17

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179626993 ## File path: heron/common/src/cpp/network/baseconnection.cpp ## @@

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179630500 ## File path: heron/tmaster/src/cpp/manager/tmaster.cpp ## @@ -758,7

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179628759 ## File path: heron/statemgrs/src/cpp/statemgr/heron-zkstatemgr.cpp ##

[GitHub] Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more …

Yaliang commented on a change in pull request #2847: Replace CHECK() with CHECK_*() so that when a check is failing, more … URL: https://github.com/apache/incubator-heron/pull/2847#discussion_r179627824 ## File path: heron/common/src/cpp/zookeeper/zkclient.cpp ## @@