Re: Review Request 58454: HIVE-16449 BeeLineDriver should handle query result sorting

ssing class to the enum; it would > > enable the cleanup of some switched > > > > ``` > > SORT_QUERY_RESULTS(SortAndDigestPrintStream.class) > > ``` Please check the changes. I am not sure I understood your comment. - Peter --- This is an automatical

Re: Review Request 58454: HIVE-16449 BeeLineDriver should handle query result sorting

://reviews.apache.org/r/58454/diff/5/ Changes: https://reviews.apache.org/r/58454/diff/4-5/ Testing --- Checked the output changes of the existing BeeLineDriver tests Thanks, Peter Vary

[jira] [Created] (HIVE-16487) Serious Zookeeper exception is logged when a race condition happens

Peter Vary created HIVE-16487: - Summary: Serious Zookeeper exception is logged when a race condition happens Key: HIVE-16487 URL: https://issues.apache.org/jira/browse/HIVE-16487 Project: Hive

[jira] [Created] (HIVE-16468) BeeLineDriver should be able to run tests against an externally created cluster

Peter Vary created HIVE-16468: - Summary: BeeLineDriver should be able to run tests against an externally created cluster Key: HIVE-16468 URL: https://issues.apache.org/jira/browse/HIVE-16468 Project

Re: Review Request 58454: HIVE-16449 BeeLineDriver should handle query result sorting

--- Checked the output changes of the existing BeeLineDriver tests Thanks, Peter Vary

[jira] [Created] (HIVE-16467) Flaky test: TestCliDriver.testCliDriver[vector_order_null]

Peter Vary created HIVE-16467: - Summary: Flaky test: TestCliDriver.testCliDriver[vector_order_null] Key: HIVE-16467 URL: https://issues.apache.org/jira/browse/HIVE-16467 Project: Hive Issue Type

[jira] [Created] (HIVE-16466) Flaky test: TestJdbcDriver2.testSelectExecAsync2

Peter Vary created HIVE-16466: - Summary: Flaky test: TestJdbcDriver2.testSelectExecAsync2 Key: HIVE-16466 URL: https://issues.apache.org/jira/browse/HIVE-16466 Project: Hive Issue Type: Sub-task

Re: Review Request 58454: HIVE-16449 BeeLineDriver should handle query result sorting

--- Checked the output changes of the existing BeeLineDriver tests Thanks, Peter Vary

[jira] [Created] (HIVE-16451) Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer

Peter Vary created HIVE-16451: - Summary: Race condition between HiveStatement.getQueryLog and HiveStatement.runAsyncOnServer Key: HIVE-16451 URL: https://issues.apache.org/jira/browse/HIVE-16451 Project

Review Request 58454: HIVE-16449 BeeLineDriver should handle query result sorting

/test/results/clientpositive/beeline/smb_mapjoin_3.q.out 6c9b8e4 Diff: https://reviews.apache.org/r/58454/diff/1/ Testing --- Checked the output changes of the existing BeeLineDriver tests Thanks, Peter Vary

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

e/cli/session/HiveSessionImpl.java 7df4563 Diff: https://reviews.apache.org/r/57693/diff/3/ Changes: https://reviews.apache.org/r/57693/diff/2-3/ Testing --- Added a new simple query file from CLI driver, and checked that the generated output is the same Thanks, Peter Vary

[jira] [Created] (HIVE-16449) BeeLineDriver should handle query result sorting

Peter Vary created HIVE-16449: - Summary: BeeLineDriver should handle query result sorting Key: HIVE-16449 URL: https://issues.apache.org/jira/browse/HIVE-16449 Project: Hive Issue Type

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

a f62ee4e service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 418f453 Diff: https://reviews.apache.org/r/57693/diff/2/ Testing --- Added a new simple query file from CLI driver, and checked that the generated output is the same Thanks, Peter Vary

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

ile=1666204#file1666204line31> > > > > Does this need to be abstract? With the rework this change is removed - Peter ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57693/#revie

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

> On March 17, 2017, 12:37 a.m., Zoltan Haindrich wrote: > > itests/util/src/main/java/org/apache/hive/beeline/qfile/QFile.java > > Lines 66-73 (original) > > <https://reviews.apache.org/r/57693/diff/1/?file=1666199#file1666199line66> > > > > where

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

iff: https://reviews.apache.org/r/57693/diff/2/ Changes: https://reviews.apache.org/r/57693/diff/1-2/ Testing --- Added a new simple query file from CLI driver, and checked that the generated output is the same Thanks, Peter Vary

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

e review! Changed the default value to 100 - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58086/#review171207 ------

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

/ Testing --- Added new unit test to test the truncation Updated the existing unit tests Thanks, Peter Vary

Re: Review Request 58203: HIVE-16345 BeeLineDriver should be able to run qtest files which are using default database tables

same name. So we archive the separation by using different databases, and we have put extra effort into running the tests with the default tables. - Peter ------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58

Re: Review Request 58203: HIVE-16345 BeeLineDriver should be able to run qtest files which are using default database tables

parameter Thanks, Peter Vary

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

unit test to test the truncation Updated the existing unit tests Thanks, Peter Vary

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

he truncation limit, thanks for the suggestion Sahil and Vihang! - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58086/#review171132 --- On April 5, 2017, 5:21 p.m., Peter Vary wrot

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

eviews.apache.org/r/58086/#review171135 --- On April 5, 2017, 5:21 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

--- Added new unit test to test the truncation Updated the existing unit tests Thanks, Peter Vary

[jira] [Created] (HIVE-16382) Find a way to store the query string only once in ZooKeeper locks

Peter Vary created HIVE-16382: - Summary: Find a way to store the query string only once in ZooKeeper locks Key: HIVE-16382 URL: https://issues.apache.org/jira/browse/HIVE-16382 Project: Hive

Review Request 58203: HIVE-16345 BeeLineDriver should be able to run qtest files which are using default database tables

rce.tables - runs with true, or without it, fails when set to false - junit.parallel.threads - runs with 1, or without this parameter Thanks, Peter Vary

Re: Review Request 58085: HIVE-16061: Some of console output is not printed to the beeline console

) - Peter Vary On March 30, 2017, 9:01 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58085/ > --

Re: Review Request 58085: HIVE-16061: Some of console output is not printed to the beeline console

> > Seems that is what it does. Can't think of anything else. > > Peter Vary wrote: > // Constants of the key strings for the log4j MDC. > > Maybe? > > Aihua Xu wrote: > They are the same thing. Actually Log4J uses ThreadContext. See &g

[jira] [Created] (HIVE-16345) BeeLineDriver should be able to run qtest files which are using default database tables

Peter Vary created HIVE-16345: - Summary: BeeLineDriver should be able to run qtest files which are using default database tables Key: HIVE-16345 URL: https://issues.apache.org/jira/browse/HIVE-16345

Re: Review Request 58085: HIVE-16061: Some of console output is not printed to the beeline console

> On March 30, 2017, 8:41 p.m., Aihua Xu wrote: > > common/src/java/org/apache/hadoop/hive/common/LogUtils.java > > Lines 52 (patched) > > > > > > Any suggestions? > > > > Seems that is what it does. Can't t

Re: Review Request 58085: HIVE-16061: Some of console output is not printed to the beeline console

art to log in EXECUTE level, since that is the default HIVE_SERVER2_LOGGING_OPERATION_LEVEL. Just a guess, I did not have time to try it out :) - Peter Vary On March 30, 2017, 4:54 p.m., Aihua Xu wrote: > > --- > This

Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

://reviews.apache.org/r/58086/diff/1/ Testing --- Added new unit test to test the truncation Updated the existing unit tests Thanks, Peter Vary

[jira] [Created] (HIVE-16334) Query lock contains the query string, which can cause OOM on ZooKeeper

Peter Vary created HIVE-16334: - Summary: Query lock contains the query string, which can cause OOM on ZooKeeper Key: HIVE-16334 URL: https://issues.apache.org/jira/browse/HIVE-16334 Project: Hive

[jira] [Created] (HIVE-16313) Flaky test: TestBeeLineDriver[drop_with_concurrency]

Peter Vary created HIVE-16313: - Summary: Flaky test: TestBeeLineDriver[drop_with_concurrency] Key: HIVE-16313 URL: https://issues.apache.org/jira/browse/HIVE-16313 Project: Hive Issue Type: Sub

Re: Review Request 57772: HIVE-16242 Run BeeLine tests parallel

allel. Thanks, Peter Vary

Re: Review Request 57772: HIVE-16242 Run BeeLine tests parallel

93 Diff: https://reviews.apache.org/r/57772/diff/4/ Changes: https://reviews.apache.org/r/57772/diff/3-4/ Testing --- Manually run the tests several times. Validated that the tests are running in parallel. Thanks, Peter Vary

Re: Review Request 57772: HIVE-16242 Run BeeLine tests parallel

that the tests are running in parallel. Thanks, Peter Vary

Review Request 57772: HIVE-16242 Run BeeLine tests parallel

/diff/1/ Testing --- Manually run the tests several times. Validated that the tests are running in parallel. Thanks, Peter Vary

[jira] [Created] (HIVE-16242) Run BeeLine tests parallel

Peter Vary created HIVE-16242: - Summary: Run BeeLine tests parallel Key: HIVE-16242 URL: https://issues.apache.org/jira/browse/HIVE-16242 Project: Hive Issue Type: Improvement

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

above. I think I understand your concern, and it is the same issue as the comment above. - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57693/#review169228 ---

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

quot; since only the value is anonymized. hiddenConf will be "hidden" which will match the URL. To tell the truth, I run the tests and found out about it only when there was a failure :) - Peter Vary On March 17, 2017, 9:14 a.

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On March 16, 2017, 9:27 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java > > Lines 423-426 (patched) > > <https://reviews.apache.org/r/56763/diff/3-4/?file=1665965#file1665965line423> > > > > I think you will kick me aro

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

uld be removed. jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java Lines 102 (patched) <https://reviews.apache.org/r/56763/#comment241548> This test is Parameterized. So this test will be run 9 times in a row. I suggest to move this test to a new test class. - Peter Vary On M

Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

output is the same Thanks, Peter Vary

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

rect, but it might be worth to put another name/value pair into the test url and validate that it was not removed, ensuring that if somebody changes the original method it will not accidentally hide everything :). What do you think? - Peter Vary On March 16, 2017, 2:51 a.m., Vaibhav Gu

Re: Review Request 57586: HIVE-16183: Fix potential thread safety issues with static variables

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57586/#review169102 --- Ship it! Ship It! - Peter Vary On March 15, 2017, 10:03 p.m

Re: Review Request 57586: HIVE-16183: Fix potential thread safety issues with static variables

l/exec/vector/mapjoin/fast/CommonFastHashTable.java Line 38 (original), 38 (patched) <https://reviews.apache.org/r/57586/#comment241369> As far as I know random.nextInt is threadsafe, so I think we might not have to change this method to synchronized. Or am I missing something here? - Pet

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

Congratulations! :) 2017. márc. 15. 7:05 ezt írta ("Vaibhav Gumashta" ): > Congrats Eugene! > > > On 3/14/17, 11:03 PM, "Rajesh Balamohan" wrote: > > >Congrats Eugene!! :) > > > >~Rajesh.B > > > >On Wed, Mar 15, 2017 at 11:21 AM, Pengcheng Xiong > >wrote: > > > >> Congrats! Well deserved! > >>

Review Request 57599: HIVE-16152 TestBeeLineDriver logging improvements

various fail cases. Collected the output in the jira Thanks, Peter Vary

Green unit test results

Hi, Congratulations for everyone who have helped taking care of the unit test failures! I have got my first green run! :) If any of you interested in: https://builds.apache.org/job/PreCommit-HIVE-Build/4049/testReport/ :) Gr

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

ne70> > > > > i don't think this should be asserted...if you run your jvm without -ea > > this method is not even invoked Surefire plugin set this to true by default, and we do not change it in our pom. Doublechecked with an actual failure and with our current setti

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

the result is not changed. Added one more test to check the separation is done correctly. Thanks, Peter Vary

[jira] [Created] (HIVE-16152) TestBeeLineDriver logging improvements

Peter Vary created HIVE-16152: - Summary: TestBeeLineDriver logging improvements Key: HIVE-16152 URL: https://issues.apache.org/jira/browse/HIVE-16152 Project: Hive Issue Type: Improvement

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

if there is a pacakge-info for every new package. Since I have created this package I created the package-info.java file which is used for generating the package.html when generating the javadoc. As an owner of HIVE-15051, I feel obliged to write code without checkstyle errors :D - Pe

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

will take the extra parameters and can be reused. - Peter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57343/#review168135 ----

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

://reviews.apache.org/r/57343/diff/2/ Changes: https://reviews.apache.org/r/57343/diff/1-2/ Testing --- Used the previosly generated test to validate that the result is not changed. Added one more test to check the separation is done correctly. Thanks, Peter Vary

[jira] [Created] (HIVE-16146) If possible find a better way to filter the TestBeeLineDriver output

Peter Vary created HIVE-16146: - Summary: If possible find a better way to filter the TestBeeLineDriver output Key: HIVE-16146 URL: https://issues.apache.org/jira/browse/HIVE-16146 Project: Hive

Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

PRE-CREATION Diff: https://reviews.apache.org/r/57343/diff/1/ Testing --- Used the previosly generated test to validate that the result is not changed. Added one more test to check the separation is done correctly. Thanks, Peter Vary

[jira] [Created] (HIVE-16127) Separate database initialization from actual query run in TestBeeLineDriver

Peter Vary created HIVE-16127: - Summary: Separate database initialization from actual query run in TestBeeLineDriver Key: HIVE-16127 URL: https://issues.apache.org/jira/browse/HIVE-16127 Project: Hive

[jira] [Created] (HIVE-16101) QTest failure BeeLine escape_comments after HIVE-16045

Peter Vary created HIVE-16101: - Summary: QTest failure BeeLine escape_comments after HIVE-16045 Key: HIVE-16101 URL: https://issues.apache.org/jira/browse/HIVE-16101 Project: Hive Issue Type

[jira] [Created] (HIVE-16057) SchemaTool ignores --passWord argument if hadoop.security.credential.provider.path is configured

Peter Vary created HIVE-16057: - Summary: SchemaTool ignores --passWord argument if hadoop.security.credential.provider.path is configured Key: HIVE-16057 URL: https://issues.apache.org/jira/browse/HIVE-16057

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Diff: https://reviews.apache.org/r/52978/diff/ Testing --- Manually on my computer several runs. Waiting for the QA tests Thanks, Peter Vary

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

! LGTM (non binding) - Peter Vary On Feb. 24, 2017, 7:20 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

result.add(p); } } But I have tried, and your version is performed better on local fs with 10k files, 4 depth (year/month/day/job). 2800 ms vs. 3000 ms I still think that my version is more readable, but speed is speed :D

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

ng what the filter regex is doing to > > make it easier to understand? > > Peter Vary wrote: > Will do - This is for removing the timestamp from the begining of the log > lines Done > On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > >

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

tests Thanks, Peter Vary

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Not sure why we need this? Can you please add some comment to help us > > understand > > Peter Vary wrote: > To be honest, I was aiming for the minimal change, and did not try to run > without it. Will check - my guess is that the HiveServer configured to use ZK > cl

[jira] [Created] (HIVE-16007) When the query does not complie the LogRunnable never stops

Peter Vary created HIVE-16007: - Summary: When the query does not complie the LogRunnable never stops Key: HIVE-16007 URL: https://issues.apache.org/jira/browse/HIVE-16007 Project: Hive Issue

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

Is it possible to use miniHS2 instead? > > Peter Vary wrote: > This is a very good idea! I think we should do that... > The same applies here as above - tried to keep my changes minimal - Shall > we change this here, or in a followup jira to separate the changes? Checked

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On Feb. 22, 2017, 10:20 a.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java, lines 398-400 > > <https://reviews.apache.org/r/56763/diff/1-2/?file=1637751#file1637751line398> > > > > As far as I know the Java String is immutable, whi

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

thm for removing passwords it might be a good idea to have a test for it. Thanks, Peter - Peter Vary On Feb. 21, 2017, 9:01 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail.

Re: [ANNOUNCE] New committer: Zoltan Haindrich

Congratulations Zoltan! Well done! :) > On Feb 22, 2017, at 7:00 AM, Zoltan Haindrich wrote: > > Thank you everyone! > > It's really an honor to be associated with this project! > > About me: I've a pretty broad spectrum of interest in general, I always want > to clearly understand the big pi

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

ter --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52978/#review166031 --- On Oct. 19, 2016, 1:39 p.m., Peter V

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

t a question: Why we are removing the message? Was it missleading in some case? - Peter Vary On Feb. 16, 2017, 6:22 p.m., Vaibhav Gumashta wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

[jira] [Created] (HIVE-15963) When the token renewal period is short MapRedLocalTask might fail with "token (...) is expired"

Peter Vary created HIVE-15963: - Summary: When the token renewal period is short MapRedLocalTask might fail with "token (...) is expired" Key: HIVE-15963 URL: https://issues.apache.org/jira/browse/

Re: Review Request 56290: HIVE-15795: Add Accumulo Index Table Support

ve/accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java: Recompile with -Xlint:unchecked for details. Thanks, Peter - Peter Vary On Feb. 6, 2017, 4:51 p.m., Mike Fagan wrote: > > -

Re: Review Request 56334: HIVE-12767: Implement table property to address Parquet int96 timestamp bug

g/r/56334/#comment236253> nit: indentation? ql/src/test/org/apache/hadoop/hive/ql/io/parquet/serde/TestParquetTimestampUtils.java (line 226) <https://reviews.apache.org/r/56334/#comment236256> Would not be this flaky? At least dependent on the tester local settings? What happens wh

Re: Missing ASF license headers

Hi, The patch is waiting for review, commit. Could someone take a look at it? https://issues.apache.org/jira/browse/HIVE-15749 <https://issues.apache.org/jira/browse/HIVE-15749> Thanks, Peter > On Jan 27, 2017, at 9:28 PM, Peter Vary wrote: > > Thanks Owen, I will do t

Re: Review Request 56025: HIVE-15723 Hive should report a warning about missing table/column statistics to user.

did not found any new problems. Thanks for the patch! Peter - Peter Vary On Jan. 30, 2017, 10:30 a.m., Remus Rusanu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 55816: HIVE-15680: Incorrect results when hive.optimize.index.filter=true and same ORC table is referenced twice in query

pr == null ) {:38: warning: ')' is preceded with whitespace. Running Findbugs, ASF header check, etc did not found any new problems. Thanks for the patch! Peter - Peter Vary On Jan. 28, 2017, 9:41 p.m., Anthony Hsu wrote: > > --

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

> On Jan. 27, 2017, 3:37 p.m., Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > f

Re: Missing ASF license headers

Thanks Owen, I will do that! Peter 2017. jan. 27. 19:02 ezt írta ("Owen O'Malley" ): > Just file a jira with the patch that adds the headers. > > .. Owen > > On Fri, Jan 27, 2017 at 8:08 AM, Peter Vary wrote: > > > Hi, > > > > I am working

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

> On jan. 27, 2017, 3:37 du, Peter Vary wrote: > > Hi Sergio, > > > > Looking through the patch I did not find anything useful to enhance what > > you did :) > > > > I did run the yetus pre-commit stuff on it (author, checkstyle, javadoc, > > find

Missing ASF license headers

Hi, I am working on enabling YETUS pre-commit test so it can help in the reviews. I was running the ASF license check, and I have found the following files are missing the ASF header: common/src/java/org/apache/hadoop/hive/common/classification/RetrySemantics.java druid-handler/src/java/org/apac

Re: Review Request 55994: HIVE-15736: Add unit tests to Utilities.getInputSummary() method for multi-threading cases

ine is longer than 100 characters (found 136). I do not think that we are able to keep files shorter than 2000 lines in Hive, so I will remove that check, but AFAIK we try to keep the line length to 100. Or should I change that too? Thanks, Peter - Peter Vary On Jan. 26, 2017, 8:09 p.m.,

Re: Review Request 55932: HIVE-15387: NPE in HiveServer2 webUI Historical SQL Operations section

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55932/#review162964 --- Ship it! Ship It! - Peter Vary On Jan. 25, 2017, 3:03 p.m

[jira] [Created] (HIVE-15726) Reenable indentation checks to checkstyle

Peter Vary created HIVE-15726: - Summary: Reenable indentation checks to checkstyle Key: HIVE-15726 URL: https://issues.apache.org/jira/browse/HIVE-15726 Project: Hive Issue Type: Improvement

[jira] [Created] (HIVE-15725) Make it possible to run checkstyle for a specific module

Peter Vary created HIVE-15725: - Summary: Make it possible to run checkstyle for a specific module Key: HIVE-15725 URL: https://issues.apache.org/jira/browse/HIVE-15725 Project: Hive Issue Type

Re: Review Request 55846: HIVE-15604: Improve contents of qfile test output

iews.apache.org/r/55846/#comment234169> Why do we change the error aggregation here? - Peter Vary On Jan. 23, 2017, 4:13 p.m., Barna Zsombor Klara wrote: > > --- > This is an automatically generate

[jira] [Created] (HIVE-15679) Some metastore metrics always contains column=null (write_column_statistics, write_partition_column_statistics)

Peter Vary created HIVE-15679: - Summary: Some metastore metrics always contains column=null (write_column_statistics, write_partition_column_statistics) Key: HIVE-15679 URL: https://issues.apache.org/jira/browse/HIVE

Re: Review Request 55498: HIVE-15538: Test HIVE-13884 with more complex query predicates

the accepted 100 character, but this is the only nit I could find :) About the actual queries, I do not know this part of the code enough to help here. Someone with more knowledge is needed there. Thanks for the patch! - Peter Vary On Jan. 13, 2017, 11:58 a.m., Marta Kuczora wrote

Re: [ANNOUNCE] New Hive Committer - Rajesh Balamohan

Congratulations Rajesh! > On Dec 15, 2016, at 6:40 AM, Rui Li wrote: > > Congratulations :) > > On Thu, Dec 15, 2016 at 6:50 AM, Gunther Hagleitner < > ghagleit...@hortonworks.com> wrote: > >> Congrats Rajesh! >> >> From: Jimmy Xiang >> Sent: Wednesday

Re: Review Request 54065: HIVE-15282: Different modification times are used when an index is built and when its staleness is checked

. Thansk for tracking this issue dowm! ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 978) <https://reviews.apache.org/r/54065/#comment227393> We might want to use the dataLocation local variable here - Peter Vary On Nov. 24, 2016, 3:17 p.m., Marta Kuczora

Re: Review Request 54066: HIVE-15283: Index is dropped from wrong table in the index_auto_mult_tables.q and index_auto_mult_tables_compact.q tests

! :) - Peter Vary On Nov. 24, 2016, 3:59 p.m., Marta Kuczora wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: [DISCUSS] Yetus pre-commit tests

it possible to start this from within ptest as a > parallel phase? The ptest server doesn't do much while tests are running. > Running the regular ptest flow, and this set of checks could be > parallelized there. > > Thank you for taking this up. > > Sid > >

[jira] [Created] (HIVE-15184) Add the possibility to separate recoverable and not recoverable errors in DeletagionTokenStore

Peter Vary created HIVE-15184: - Summary: Add the possibility to separate recoverable and not recoverable errors in DeletagionTokenStore Key: HIVE-15184 URL: https://issues.apache.org/jira/browse/HIVE-15184

[DISCUSS] Yetus pre-commit tests

Hi there,Previously we discussed that it would be good to integrate some automated checks to the pre-commit flow.Alan Gates suggested Apache Yetus and I checked what it can do for us (Yetus 0.3.0).The good things that I have found:Several existing tests (asflicense, author, checkstyle, findbugs, ja

Re: Review Request 53646: HIVE-15176: Small typo in hiveserver2 webui

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53646/#review155575 --- Ship it! Ship It! - Peter Vary On Nov. 10, 2016, 1:28 p.m

Re: Review Request 53609: HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53609/#review155572 --- Ship it! Thanks for the patch! - Peter Vary On nov. 10

Re: Review Request 53609: HIVE-15168: Flaky test: TestSparkClient.testJobSubmission (still flaky)

mment to match the new signature spark-client/src/test/java/org/apache/hive/spark/client/rpc/TestRpc.java (line 39) <https://reviews.apache.org/r/53609/#comment225411> nit: Is this import is used after this change? - Peter Vary On Nov. 9, 2016, 3:20 p.m., B

<    2   3   4   5   6   7   8   9   >