Hey all!
Around friday I've made a small change: and enabled daily repo scanning of apache/hive; it picked up ~80 pending prs for testruns - during the weekeng it was able to finish
with all of them :)
The periodic repo scanning adds an extra safety net which could help mitigate
issues in
Hello,
On 6/17/20 12:33 AM, Justin Mclean wrote:
Sadly I think there is not much we can do for contributions >1 year - those
patches will be likely outdated already - and the contributor have probably
abandoned it.
Another point of view would be that the project has failed to either review,
Hi Justin,
I agree with you that this behavior is not encouraging for new contributors,
and we have to improve on :(
Sadly it is really dependent on the way how we review the incoming pull
requests, and if a pull request is old then it is even more unlikely that it
will get a review.
IMHO
Hi,
> Sadly I think there is not much we can do for contributions >1 year - those
> patches will be likely outdated already - and the contributor have probably
> abandoned it.
Another point of view would be that the project has failed to either review,
merge or encourage the committer to
Hey David!
Sadly I think there is not much we can do for contributions >1 year - those
patches will be likely outdated already - and the contributor have probably
abandoned it.
I think all of us was on the other side as well: it's somewhat demoralizing to
create patches which are not being
Hey Zoltan,
I think this stale bot is too aggressive. The Apache Druid program marks
stale after 200+ days and closes 4 weeks after that. I've found a few
interesting PRs that are old, and are being closed, but I just haven't
gotten around to them and with such a big backlog, there needs to be
No need to respond, just want to document somewhere:
Part of the process involved enabling 2FA on my Github account. After
that, pushing to repositories failed with an authentication error. After
2FA, it is required to use a access token instead of a password:
Hello Zoltan
I just got access. Not sure if this was a manual process performed by
someone on this thread or something automated, but I got an email
acknowledging.
I'm starting to close some old PRs.
Thanks.
On Thu, Jun 4, 2020 at 5:20 PM David Mollitor wrote:
> Zoltan,
>
>
>
Zoltan,
https://cwiki.apache.org/confluence/display/OPENWHISK/Accessing+Apache+GitHub+as+a+Committer
That did it for me. Thanks so much,... I'll try to remember to get this in
our Hive docs.
I still however cannot close or merge anything. I get the warning:
"Only those with write access to
Hey Zoltan,
Thanks again for putting this together.
The original topic was dealing with a big pile of PRs. I'm starting to
work through them and pair them down a bit before we kick in something
automated (agree that we should eventually). However, I'm hampered by my
ability to not be able to
Hey David!
> I'm trying to run the tests again and hopefully commit. Github has me
> listed as a "contributor" and lists Zoltan as a "Member of The Apache
> Software Foundation". Do you know how that list of members is managed?
I don't know; maybe you should re-link your account? You could
Hey Zoltan,
Any idea how I can get to be a part of "member" group so I can merge some
PRs?
Thanks!
On Thu, Jun 4, 2020 at 11:40 AM Zoltan Haindrich wrote:
> Hey Stamatis!
>
> Yes, right now we should put the contributor's name into the commit
> message/etc - but in case we are using PRs that
Hey Stamatis!
Yes, right now we should put the contributor's name into the commit message/etc - but in case we are using PRs that info is also present on the PR (or we could change the
PR label to conform to our rules)
Thank for the reference - I've just seen that there is also a "bot" to
Hmm, OK, working through this PR:
https://github.com/apache/hive/pull/1052
I'm trying to run the tests again and hopefully commit. Github has me
listed as a "contributor" and lists Zoltan as a "Member of The Apache
Software Foundation". Do you know how that list of members is managed?
Hello Zoltan,
Regarding auto-close in JIRA. Take a look at Apache Avro project. I've
contributed there a little bit and I think they have this capability.
Thanks.
On Tue, Jun 2, 2020 at 8:00 PM Stamatis Zampetakis
wrote:
> Hello,
>
> I am very happy working with the new system. Many thanks
Hello,
I am very happy working with the new system. Many thanks Zoltan!
I find the bot a good idea and I think its worth trying it out.
One thing to watch out is the case where contributors are willing to push
their work forward but there are no available reviewers to look to each
case.
I think
On 6/2/20 9:15 PM, David Mollitor wrote:
I use a personal account for GitHub and it's not synced with my official
Apache account. How do I go about registering my Apache account with
GitHub so I can merge through their interface?
IIRC I've linked my account by using this interface:
Hey Zoltan,
I use a personal account for GitHub and it's not synced with my official
Apache account. How do I go about registering my Apache account with
GitHub so I can merge through their interface?
In the meanwhile, can you assist with a merge here? :)
On 6/2/20 3:10 PM, David Mollitor wrote:
I think we might want to take one manual pass across the board. It will
most likely take more than 7 days to get through them all, so it may be
closing things that are legitimate.
yeah...a manual pass would be good; I went thru around 10 or so
Hey,
I think we might want to take one manual pass across the board. It will
most likely take more than 7 days to get through them all, so it may be
closing things that are legitimate.
One low hanging fruit (that applied to one of my PRs). The JIRA it was
associated with was already closed.
I think to use "probot" we would need to ask infra to configure the "probot"
github app.
It seems to me that the stale plugin from github actions provides almost the same functionaluty - as they seem to be more or less identical in features I would go with the
latter.
I've opened a pr to
How about using stalebot : https://github.com/probot/stale ?
On Mon, Jun 1, 2020 at 12:20 PM Zoltán Haindrich wrote:
>
>
> Hey David,
>
> On June 1, 2020 3:52:05 PM GMT+02:00, David Mollitor
> wrote:
> >Any idea how long it will take to run precomit on all existing PRs?
> >
> I'm not entirely
Hey David,
On June 1, 2020 3:52:05 PM GMT+02:00, David Mollitor wrote:
>Any idea how long it will take to run precomit on all existing PRs?
>
I'm not entirely sure, but a rough estimate could be:
* not every pr is mergeable; there are many which was already
merged/outdated/etc...lets
Any idea how long it will take to run precomit on all existing PRs?
On Mon, Jun 1, 2020 at 9:49 AM Panos Garefalakis wrote:
> Same here, however, there are still ~ 430 PRs pending on master.
> Thanks Zoltan for this great initiative!
>
> Cheers,
> Panagiotis
>
> On Mon, Jun 1, 2020 at 2:33 PM
Same here, however, there are still ~ 430 PRs pending on master.
Thanks Zoltan for this great initiative!
Cheers,
Panagiotis
On Mon, Jun 1, 2020 at 2:33 PM David Mollitor wrote:
> Thanks so much for the work on this.
>
> Just cleaned up mine.
>
> On Sat, May 30, 2020 at 10:16 AM Zoltan
Thanks so much for the work on this.
Just cleaned up mine.
On Sat, May 30, 2020 at 10:16 AM Zoltan Haindrich wrote:
> Hey All,
>
> The new test executor will pick up any PR which doesn't yet have a test
> result - now that the patch is on the master; every PR which is mergeable
> with the
Hey All,
The new test executor will pick up any PR which doesn't yet have a test result - now that the patch is on the master; every PR which is mergeable with the master branch is
a good candidate - so the right move would be to clean up our PR backlog.
I would like to ask everyone to look
27 matches
Mail list logo
