Re: reverting test-breaking changes

+1 Commenting on JIRA and giving a 24hr heads-up (excluding weekends) would be good. On Thu, Feb 22, 2018 at 10:19 AM, Alan Gates wrote: > +1. > > Alan. > > On Thu, Feb 22, 2018 at 8:25 AM, Thejas Nair > wrote: > > > +1 > > I agree, this makes sense. The number of failures keeps increasing. > >

information_schema in metastore

I recently noticed the work done in HIVE-16946 related to information schema. Based on what I understand so far, it uses JdbcSerDe to create hive tables similar to metastore db tables. It looks like an interesting idea. Can someone share how is it

Re: HMS API testing and direct SQL

Direct SQL is controlled by configs metastore.try.direct.sql and metastore.try.direct.sql.ddl which are enabled by default. So I am guessing the API tests will cover the direct SQL enabled path only unless the tests override the default configs (I don't think they do). On Fri, Mar 2, 2018 at 10:51

Re: how beeline operations going to same thread in HiveMetaStore

What version of Hive are you using? I am actually surprised that set metaconf:fs.s3a.access.key=xx; works from beeline. Based on my knowledge this config is not settable in metastore which is why I had created this JIRA HIVE-16913 some time bac

Re: Hive 3.0 release

+1 on releasing Hive 3.0.0. This would be useful for standalone-metastore work as well. On Wed, Mar 21, 2018 at 8:49 AM, Gunther Hagleitner < ghagleit...@hortonworks.com> wrote: > +1 > > Thank you, > Gunther > > > > On Tue, Mar 20, 2018 at 11:07 PM -0700, "Thejas Nair" < > thejas.n...@gmail.com

Re: PTest stuck

Yeah. Looks like there was something wrong since the job was running over 5 hrs. I aborted the job and updated that JIRA informing the author about the same. Lets monitor if the issue happens with other jobs as well. On Wed, Mar 21, 2018 at 5:46 PM, Prasanth Jayachandran < pjayachand...@hortonwork

Re: PTest stuck

> >> > >>Thanks, > >>Peter > >> > >>> On Mar 22, 2018, at 9:29 AM, Prasanth Jayachandran < > >> pjayachand...@hortonworks.com> wrote: > >>> > >>> The tests aren’t run

Re: Hive broken master branch?

Are you using derby for the backing DB for HMS? If yes, what is the value of datanucleus.autoCreateTables and datanucleus.autoCreateSchema? This looks like the schema is not updated for some reason. Can you confirm if you have the latest schema (or try re-initializing the schema)? On Tue, Mar 27,

Re: Documenting standalone metastore

+1 for having a separate wiki page for standalone metastore. Would be good to link it to the existing document. On Mon, Apr 2, 2018 at 9:47 PM, Lefty Leverenz wrote: > Agreed. > > In the last 3 years there were only 7 changes to the metastore admin doc, > so maintaining parallel docs might not b

Re: reverting test-breaking changes

y tests, and creates a continuos, > updated list of them. > > On Feb 23, 2018, at 6:55 PM, Sahil Takiar > wrote: > > +1 > > Does anyone have suggestions about how to efficiently identify which > commit > is breaking a test? Is it just git-bisect or is there an easier wa

Re: Apache Hive 3.0.0 release preparation

Hi Vineet, I created a profile on ptest-server so that tests can be run on branch-3. It is the same as branch-2 patches. You will need to include branch-3 in the patch name. Eg. HIVE-1234.01-branch-3.patch -Vihang On Mon, Apr 9, 2018 at 4:35 PM, Vineet Garg wrote: > I have created an umbrell

Re: Build page not accessible

This page is working for me https://builds.apache.org/job/PreCommit-HIVE-Build/. Is that the one which you are looking to confirm? On Wed, Apr 18, 2018 at 12:13 PM, Deepak Jaiswal wrote: > Hi all, > > I am not able to access the Hive Jenkins page. Is that happening to others > too? > > Regards,

Re: switching HiveQA to manual submission?

I saw patches getting disappeared also. I know the patch for HIVE-17824 was not run since last 1 week. When we looked into this yesterday I found that for some reason the jenkins server was restarted overnight and we lose the pending queue. Does anyone know why this might be happening? Does jenkins

Re: switching HiveQA to manual submission?

I had sent an email to bui...@apache.org (not sure if that is the right list). Also created this JIRA https://issues.apache.org/jira/browse/INFRA-16478 to see if there is some response. On Thu, May 3, 2018 at 2:21 PM, Vihang Karajgaonkar wrote: > I saw patches getting disappeared also. I k

Re: switching HiveQA to manual submission?

investigating them: https://twitter.com/infrabot > On Thu, May 3, 2018 at 2:41 PM, Vihang Karajgaonkar wrote: > I had sent an email to bui...@apache.org (not sure if that is the right > list). Also created this JIRA https://issues.apache. > org/jira/browse/INFRA-16478 to see if there

Re: switching HiveQA to manual submission?

, Vihang On Thu, May 3, 2018 at 4:35 PM, Vihang Karajgaonkar wrote: > In case you didn't see the latest comment on the JIRA, here is the > response I got from the builds team: > > Unfortunately we've been running into some bugs with Jenkins which is >> causing us to

Re: Apache Hive 3.0.0 release preparation

h-3 please fix it > as soon as you can. > > Thanks, > Vineet Garg > > On Apr 13, 2018, at 12:36 PM, Vihang Karajgaonkar <mailto:vih...@cloudera.com>> wrote: > > Hi Vineet, > > I created a profile on ptest-server so that tests can be run on branch-3. > It is the sam

Re: Apache Hive 3.0.0 release preparation

> > On Mon, May 7, 2018 at 11:58 AM, Vihang Karajgaonkar > wrote: > > How do we handle the cases where a patch needs to go in branch-2? I think > > the reason of the commits are going in branch-3 is because you don't want > > have a intermediate version where a

precommit-admin job stuck again

Looks like precommit-admin job is stuck for some reason which is preventing all the precommit jobs for Hive (also for Hadoop, Hbase etc) https://builds.apache.org/job/PreCommit-Admin/ https://issues.apache.org/jira/browse/INFRA-16492

Re: precommit-admin job stuck again

Meanwhile the committers can submit the job manually on https://builds.apache.org/job/PreCommit-HIVE-Build/ On Mon, May 7, 2018 at 2:01 PM, Vihang Karajgaonkar wrote: > Looks like precommit-admin job is stuck for some reason which is > preventing all the precommit jobs for Hive (also for

Re: My Hive QA job failed with "No space left on device (28)"

usually happens if some patch adds a super-verbose debug log. On Wed, May 9, 2018 at 3:41 PM, Vihang Karajgaonkar wrote: > Hi Matt, > > Thanks for reporting the issue. Where do you see this error message? I > tried to find it but couldn't search for this in the console output. >

Re: My Hive QA job failed with "No space left on device (28)"

spewing at such a high frequency? On Wed, May 9, 2018 at 4:05 PM, Vihang Karajgaonkar wrote: > Adding the correct dev list. > > It looks like we are generating a lot more logs than usual. Each precommit > is generating ~22G of logs and the disk eventually ran out. I had to delete > log

Re: [DISCUSS] Unsustainable situation with ptests

+1 There are many problems with the test infrastructure and in my opinion it has not become number one bottleneck for the project. I was looking at the infrastructure yesterday and I think the current infrastructure (even its own set of problems) is still under-utilized. I am planning to increase t

Re: [DISCUSS] Unsustainable situation with ptests

correction in my email below. I meant "in my opinion it *has now* become number one bottleneck for the project" (worst place for a typo I guess) On Fri, May 11, 2018 at 1:46 PM, Vihang Karajgaonkar wrote: > +1 There are many problems with the test infrastructure and in my opinion

Re: [DISCUSS] Unsustainable situation with ptests

ativeCliDriver - did not produce a TEST-*.xml file (likely > timed out) > > TestNonCatCallsWithCatalog - did not produce a TEST-*.xml file (likely > timed out) > > TestSequenceFileReadWrite - did not produce a TEST-*.xml file (likely > timed out) > > TestTxnExI

Re: [DISCUSS] Unsustainable situation with ptests

ably disable (and remember in a jira to reenable then at later point) > tests that are flaky to get repetitive green test runs. > > Thanks > Prasanth > > > > On Mon, May 14, 2018 at 2:15 AM -0700, "Rui Li" <mailto:lirui.fu...@gmail.com>> wrote: &

Re: [VOTE] Stricter commit guidelines

Can we also define a standard process to identify a flaky test and thereby making it eligible to be disabled? I am worried that the intermittent the flaky ones will stall the patches when we restart allowing the commits. On Tue, May 15, 2018 at 10:50 AM, Vineet Garg wrote: > +1 > > > On May 15,

Re: [VOTE] Stricter commit guidelines

ronment issues, e.g., I see > this a > >lot with > >TestTriggersMoveWorkloadManager. If their logic cannot be > rewritten, a > >possible > >solution is to add a max number of retries selectively for those > tests > >(surefire

Re: DB install and upgrade scripts in the brave new world of multiple release lines

Historically speaking, once we cut out a branch for a certain release line, most of the development shifts to master and only critical bug fixes are made in release specific branches. This happened when branch-2 was cut out too. Fortunately (or not) we always have had some minor releases on the lat

Re: [ANNOUNCE] New Hive Committer - Rajesh Balamohan

Congrats Rajesh! On Wed, Dec 14, 2016 at 1:54 AM, Jesus Camacho Rodriguez < jcamachorodrig...@hortonworks.com> wrote: > Congrats Rajesh, well deserved! :) > > -- > Jesús > > > > > On 12/14/16, 8:41 AM, "Lefty Leverenz" wrote: > > >Congratulations Rajesh! > > > >-- Lefty > > > > > >On Tue, Dec 13

Re: Naveen Gangam has become a Hive Committer

Congratulations Naveen! On Sat, Dec 17, 2016 at 11:36 PM, Sharath Babu Basavaraja < sharathfe...@gmail.com> wrote: > Congrats Naveen! > > --Sharath > > On Sat, Dec 17, 2016 at 11:16 PM Lefty Leverenz > wrote: > >> Congratulations Naveen! >> >> -- Lefty >> >> >> >> >> On Fri, Dec 16, 2016 at 10:1

Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION Diff: https://reviews.apache.org/r/54997/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

, everything looks good. I agree. I will remove it and post it again. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54997/#review160014 -------

Re: Review Request 54997: HIVE-14956 : Parallelize TestHCatLoader

/java/org/apache/hive/hcatalog/pig/TestSequenceFileHCatLoader.java PRE-CREATION hcatalog/hcatalog-pig-adapter/src/test/java/org/apache/hive/hcatalog/pig/TestTextFileHCatLoader.java PRE-CREATION Diff: https://reviews.apache.org/r/54997/diff/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 56095: HIVE-15754 exchange partition is not generating notifications

clause when success is true. Is there a reason this is different? - Vihang Karajgaonkar On Feb. 7, 2017, 9:32 p.m., Nachiket Vaidya wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 56118: DROP TABLE in hive doesn't Throw Error

that stale data unusable anyways without the metadata. If we want to notify such cases to the client, I think it should be a warning at best and not an error. - Vihang Karajgaonkar On Feb. 3, 2017, 2:22 p.m., Adam Szita wrote: > > ---

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

vailable in the run time (I think miniHS2 instantiates on a available port at the run time) - Vihang Karajgaonkar On Oct. 19, 2016, 1:39 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visi

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

> On Feb. 18, 2017, 11:17 p.m., Vihang Karajgaonkar wrote: > > itests/util/src/main/java/org/apache/hadoop/hive/cli/control/CoreBeeLineDriver.java, > > line 116 > > <https://reviews.apache.org/r/52978/diff/3/?file=1541464#file1541464line116> > > > > Ha

Re: [ANNOUNCE] New committer: Zoltan Haindrich

Congrats Zoltan! On Tue, Feb 21, 2017 at 4:16 PM, Vaibhav Gumashta wrote: > Congrats Zoltan! > > On 2/21/17, 4:16 PM, "Jimmy Xiang" wrote: > > >Congrats, Zoltan!! > > > >On Tue, Feb 21, 2017 at 4:15 PM, Sushanth Sowmyan > >wrote: > >> Congrats, Zoltan! > >> > >> Welcome aboard. :) > >> > >> On

Re: Review Request 56688: HIVE-15881: Use new thread count variable name instead of mapred.dfsclient.parallelism.max

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56688/#review166274 --- LGTM. Thanks for the patch Sergio! - Vihang Karajgaonkar On

Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

7c94c95f00492467ba27dedc9ce513e13c85ea61 ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveMetaStoreChecker.java 35f52cd522e0e48a333e30966245bec65cc2ec9c Diff: https://reviews.apache.org/r/56995/diff/ Testing --- Tested using existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56687: Intern strings in various critical places to reduce memory consumption.

148) <https://reviews.apache.org/r/56687/#comment238558> Do you think we should intern the keys as well? In case of a table with 1000s of partitions, they partition keys for all the partionSpecs will be the same. So interning them probably makes sense as well. - Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

35f52cd522e0e48a333e30966245bec65cc2ec9c Diff: https://reviews.apache.org/r/56995/diff/ Testing --- Tested using existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

/ql/metadata/HiveMetaStoreChecker.java (line 546) <https://reviews.apache.org/r/56995/#comment238990> I just replicated what the previous code was throwing. Agreed, better to throw new HiveException(e). Changed. - Vihang Karajgaonkar On Feb. 24, 2017, 7:20 p.m., Vihang

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

using existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56995/#review166898 --- On Feb. 27, 2017, 6:44 p.m., Vihang Karajgaonkar wrote: > > --

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

using existing and newly added test cases Thanks, Vihang Karajgaonkar

Re: Review Request 56995: HIVE-15879 : Fix HiveMetaStoreChecker.checkPartitionDirs method

le declartion be `Queue`, same for the other > > declarations below. > > Vihang Karajgaonkar wrote: > We can declare it as a Queue, but the implementation of the queue needs > to be thread-safe since multiple threads are going to operate on the queue at > the same t

Re: Review Request 52978: HIVE-14459 TestBeeLineDriver - migration and re-enable

tests - Vihang Karajgaonkar On Feb. 24, 2017, 12:21 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Pre-commit job failing - No disk space

Hi Sergio, Looks like the pre-commit jobs are failing due to disk space issues. Can you please help or let me know how can I fix it? Thanks, Vihang

Re: Pre-commit job failing - No disk space

>> 212KPreCommit-HIVE-Build-3880 >> 188KPreCommit-HIVE-Build-3901 >> 156KPreCommit-HIVE-Build-3885 >> 148KPreCommit-HIVE-Build-3884 >> 96K PreCommit-HIVE-Build-3882 >> 88K PreCommit-HIVE-Build-3886 >> 84K PreCommit-HIVE-Build-3881 >> 80K PreCommit-HIVE-Build-3883 >> 60K PreCommit-HIVE-Build-3879 >> 56K PreCommit-HIVE-Build-3908 >> >> - Sergio >> >> On Fri, Mar 3, 2017 at 12:03 PM, Vihang Karajgaonkar > > wrote: >> >>> Hi Sergio, >>> >>> Looks like the pre-commit jobs are failing due to disk space issues. Can >>> you please help or let me know how can I fix it? >>> >>> Thanks, >>> Vihang >>> >> >> >

Re: Review Request 57343: HIVE-16127 Separate database initialization from actual query run in TestBeeLineDriver

eviews.apache.org/r/57343/#comment240317> Not sure I understand this file.. - Vihang Karajgaonkar On March 7, 2017, 3:14 p.m., Peter Vary wrote: > > --- > This is an automatically gene

Re: Review Request 57503: HIVE-16024: MSCK Repair Requires nonstrict hive.mapred.mode

.org/r/57503/ > --- > > (Updated March 10, 2017, 10:36 a.m.) > > > Review request for hive, Peter Vary, Sergio Pena, Sahil Takiar, and Vihang > Karajgaonkar. > > > Repository: hive-git > > > Description > --- > > HIVE-16024: MSCK Repair Requires nonstr

Re: Green unit test results

One thing which could be done by each author of a patch is to do a search on the HiveQA test failures. If there are flaky tests which fail on the HiveQA run may be should create a JIRA for each of them and link it to the JIRA. The JIRA could have useful information like stacktraces or attaching the

Re: [ANNOUNCE] New PMC Member : Eugene Koifman

Congratulations Eugene! On Wed, Mar 15, 2017 at 9:23 AM, Wei Zheng wrote: > Congrats! > > Thanks, > Wei > > On 3/15/17, 08:58, "Chaoyu Tang" wrote: > > Congratulations Eugene! > > On Wed, Mar 15, 2017 at 11:52 AM, Jimmy Xiang > wrote: > > > Congrats!! > > > > On Wed, Mar 15

Re: Review Request 57599: HIVE-16152 TestBeeLineDriver logging improvements

gt; Isn't the command which errored out (lastSucessfulCommand + 1)? - Vihang Karajgaonkar On March 14, 2017, 2:14 p.m., Peter Vary wrote: > > --- > This is an automatically generated e-m

Re: Review Request 57693: HIVE-16146 If possible find a better way to filter the TestBeeLineDriver outpu

comments so that it is easier to understand? Is it because BOUNDING_CHAR is both at the starting and the ending of the message? ql/src/java/org/apache/hadoop/hive/ql/hooks/PrinterHook.java Lines 31 (patched) <https://reviews.apache.org/r/57693/#comment242161> Does this need to be ab

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

ws.apache.org/r/57632/#comment242375> Can you add additional testcases to verify that older config gets used when the newer one is not set? - Vihang Karajgaonkar On March 21, 2017, 4:05 p.m., Sunitha Beeram wrote: > > --- &

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

> On March 22, 2017, 8:31 p.m., Vihang Karajgaonkar wrote: > > common/src/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java > > Line 392 (original), 381 (patched) > > <https://reviews.apache.org/r/57632/diff/4/?file=1670926#file1670926line395>

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

/CodahaleMetrics.java Lines 394 (patched) <https://reviews.apache.org/r/57632/#comment242436> Nit, please use the Hive coding conventions. We prefer using the curly braces. There is IDE formatter available in dev-support/ if you want to use that. - Vihang Karajgaonkar On March 21, 2

Re: INSERT OVERWRITE TABLE with IF NOT EXISTS

I am not a 100% sure but looks like it means that do not overwrite the table/partition if it exists which is kinda of weird since we already provide "OVERWRITE" in the query. On Mon, Mar 27, 2017 at 8:40 AM, Eugene Koifman wrote: > Hi, > According to https://cwiki.apache.org/confluence/display/H

Re: Review Request 58085: HIVE-16061: Some of console output is not printed to the beeline console

<https://reviews.apache.org/r/58085/#comment243523> isnt this already done at line 107? - Vihang Karajgaonkar On March 30, 2017, 9:01 p.m., Aihua Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 58091: HIVE-16299 : MSCK REPAIR TABLE should enforce partition key order when adding unknown partitions

/TestHiveMetaStoreChecker.java 21bc8eed06c8fcd99d1e4eee3b5e5f8a4fb812be ql/src/test/queries/clientnegative/msck_repair_4.q PRE-CREATION ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58091/diff/1/ Testing --- Thanks, Vihang

Re: Review Request 58091: HIVE-16299 : MSCK REPAIR TABLE should enforce partition key order when adding unknown partitions

ql/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58091/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 58091: HIVE-16299 : MSCK REPAIR TABLE should enforce partition key order when adding unknown partitions

/src/test/results/clientnegative/msck_repair_4.q.out PRE-CREATION Diff: https://reviews.apache.org/r/58091/diff/2/ Changes: https://reviews.apache.org/r/58091/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 57632: HIVE-16206: Provide wrapper classes for current metrics reporters to allow uniform instantiation through reflection

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57632/#review170787 --- Ship it! Thanks for the changes. LGTM - Vihang Karajgaonkar

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

looks good. Couple of suggestions below common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 1774 (patched) <https://reviews.apache.org/r/58086/#comment244025> Do you think we should use a large value for the default instead of -1? - Vihang Karajgaonkar On March 30, 2017, 6:

Re: Review Request 58086: HIVE-16334 Query lock contains the query string, which can cause OOM on ZooKeeper

> On April 5, 2017, 4:11 p.m., Sahil Takiar wrote: > > ql/src/test/org/apache/hadoop/hive/ql/lockmgr/TestHiveLockObject.java > > Lines 57 (patched) > > > > > > Would be nice to have a test case where the query is exac

Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

6b217516bc74c612348b8edeca077dfbdbdb1a40 Diff: https://reviews.apache.org/r/58516/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

://reviews.apache.org/r/58516/diff/2/ Changes: https://reviews.apache.org/r/58516/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: ptest is taking 8h

Looks like PtestServer is not responding. org.apache.hive.ptest.api.client.PTestClient --command testStart --outputDir /home/jenkins/jenkins-slave/workspace/PreCommit-HIVE-Build/hive/build/hive/testutils/ptest2/target --password '[***]' --testHandle PreCommit-HIVE-Build-4795 --endpoint http://

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

apache.org/r/58516/#review172590 --- On April 20, 2017, 10:01 p.m., Vihang Karajgaonkar wrote: > > --- > This is an automatically generated e-mail. To reply, vi

Re: Review Request 58516: HIVE-16213 : ObjectStore can leak Queries when rollbackTransaction throws an exception

: https://reviews.apache.org/r/58516/diff/2-3/ Testing --- Thanks, Vihang Karajgaonkar

Re: ptest is taking 8h

7;m taking a look at this now. There is something wrong on the server. > > > > On Fri, Apr 21, 2017 at 10:27 AM, Vihang Karajgaonkar < > vih...@cloudera.com > > > wrote: > > > >> Looks like PtestServer is not responding. > >> > >> org.apache.

Re: ptest not running?

I see that builds are getting picked up at https://builds.apache.org/ job/PreCommit-HIVE-Build/ The PTest server was restarted a couple of days back. If you had a patch in the queue around that time, may be it was lost due to restart. You may have to re-attach the patch on the upstream JIRA if that

Re: ptest not running?

t of the flow that triggers the > build > > automatically. > > In the meantime, if you log in with apache credentials, and go to “Build > > with Parameters” > > you can manually launch the test by entering the bug number: just the > > digits, skip the “HIVE-“ part > >

Re: ptest not running?

I see some builds queued up on the pre-commit job. Were these submitted manually? On Tue, Apr 25, 2017 at 2:00 PM, Thejas Nair wrote: > Thanks for the update Vihang! > > > On Tue, Apr 25, 2017 at 12:54 PM, Vihang Karajgaonkar > > wrote: > > > This seems to be related

Re: ptest not running?

; JIRA or manual build could not trigger the tests. > > On Tue, Apr 25, 2017 at 11:31 PM, Eugene Koifman > > wrote: > > > I see HIVE-16445 in it – it was picked up automatically > > > > On 4/25/17, 5:44 PM, "Vihang Karajgaonkar" wrote: > > > >

Re: ptest not running?

, Sergio Pena wrote: > This seems a problem with the Jenkins slave resources. We'll need to wait > until Jenkins reserves a executor for Hive. > > On Wed, Apr 26, 2017 at 3:18 PM, Vihang Karajgaonkar > wrote: > >> Does anyone have access to https://builds.apache.or

Review Request 58936: HIVE-16143 : Improve msck repair batching

/msck_repair_batchsize.q.out ba99024163a1f2c59d59e9ed7ea276c154c99d24 ql/src/test/results/clientpositive/repair.q.out c1834640a35500c521a904a115a718c94546df10 Diff: https://reviews.apache.org/r/58936/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 58501: HIVE-16469: Parquet timestamp table property is not always taken into account

/MapredParquetInputFormat.java Lines 115-120 (patched) <https://reviews.apache.org/r/58501/#comment246789> Should logs here be warning? - Vihang Karajgaonkar On May 3, 2017, 12:59 p.m., Barna Zsombor Klara wrote: > > --- > This is a

Re: [VOTE] Apache Hive 2.3.0 Release Candidate 0

I think we need to fix HIVE-16577 before releasing 2.3.0. The metastore schema initialization script for mssql is broken since 2.2.0. Also, I noticed that JIRA shows 2.2.0 as unreleased. Does anyone know how to fix it? On Wed, May 3, 2017 at 8:48 AM, Sergio Pena wrote: > Thanks Rui. > > Pengche

Review Request 58994: HIVE-16556 : Modify schematool scripts to initialize and create METASTORE_DB_PROPERTIES table

. Manually tested against Oracle and MSSQL databases 3. Added unit-test to cover derby as well. Thanks, Vihang Karajgaonkar

Re: Problems running tests in Jenkins

I see your patch in the queue on the precommit-hive job. Its build number in the queue is 5051. It should get picked up when the other patches before yours in the queue are processed. On Thu, May 4, 2017 at 1:42 PM, Juan Rodríguez Hortalá < jua

Re: Problems running tests in Jenkins

ld number > corresponds to a patch? > > Greetings, > > Juan > > On Thu, May 4, 2017 at 1:48 PM, Vihang Karajgaonkar > wrote: > > > I see your patch in the queue on the precommit-hive > > <https://builds.apache.org/job/PreCommit-HIVE-Build/> job. Its bu

Re: Review Request 58994: HIVE-16556 : Modify schematool scripts to initialize and create METASTORE_DB_PROPERTIES table

e surrounding "". Changing the > > column name as suggested above should solve this as well. Renamed the column to DESCRIPTION for all the databases - Vihang --- This is an automatically generated e-mai

Re: Review Request 58994: HIVE-16556 : Modify schematool scripts to initialize and create METASTORE_DB_PROPERTIES table

against postgres, mysql and derby database. 2. Manually tested against Oracle and MSSQL databases 3. Added unit-test to cover derby as well. Thanks, Vihang Karajgaonkar

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

the order can change leading to flakiness. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/#review173989 --- On May 2, 2017, 1

Re: Welcome new Hive committer, Zhihai Xu

Congratulations Zhihai! On Fri, May 5, 2017 at 10:19 AM, Jimmy Xiang wrote: > Congrats!! > > On Fri, May 5, 2017 at 10:15 AM, Chinna Rao Lalam > wrote: > > Congratulations Zhihai... > > > > On Fri, May 5, 2017 at 10:22 PM, Xuefu Zhang wrote: > >> > >> Hi all, > >> > >> I'm very please to annou

Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_uuid

91d8c2af67ae1e49f8d41f16d8eee361b3b2abf9 Diff: https://reviews.apache.org/r/59070/diff/1/ Testing --- Thanks, Vihang Karajgaonkar

Re: [Announce] New committer: Vineet Garg

Congrats Vineet! On Tue, May 9, 2017 at 4:29 PM, Sergey Shelukhin wrote: > Congrats! > > On 17/5/9, 16:11, "Chaoyu Tang" wrote: > > >Congratulations Vineet! > > > >On Tue, May 9, 2017 at 6:34 PM, Vaibhav Gumashta > > > >wrote: > > > >> Congrats Vineet. > >> > >> ‹Vaibhav > >> > >> On 5/9/17, 1:

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

ike this. Thats a good suggestion. Added maximum retries. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/#review174216 ------

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

tps://github.com/rholder/guava-retrying > > Sahil Takiar wrote: > look into* > > Vihang Karajgaonkar wrote: > Thanks for the pointer. Took a quick look. It has some interesting ideas > but it doesn't seem to support reducing the workload size exponentially. It

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

dea. Added the max retries. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58936/#review174367 ------- On May 2, 2017

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

/src/test/results/clientpositive/repair.q.out c1834640a35500c521a904a115a718c94546df10 Diff: https://reviews.apache.org/r/58936/diff/2/ Changes: https://reviews.apache.org/r/58936/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_uuid

/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java 91d8c2af67ae1e49f8d41f16d8eee361b3b2abf9 Diff: https://reviews.apache.org/r/59070/diff/2/ Changes: https://reviews.apache.org/r/59070/diff/1-2/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_uuid

the metastore database which is being used to store all the metadata. - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59070/#review174521 ------

Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_uuid

t; to match the table column name in the > > schema? good catch. Will fix that - Vihang --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59070/#review174514 --

Re: Review Request 58936: HIVE-16143 : Improve msck repair batching

/repair.q.out c1834640a35500c521a904a115a718c94546df10 Diff: https://reviews.apache.org/r/58936/diff/3/ Changes: https://reviews.apache.org/r/58936/diff/2-3/ Testing --- Thanks, Vihang Karajgaonkar

Re: Review Request 59070: HIVE-16555 : Add a new thrift API call for get_metastore_db_uuid

org/r/59070/diff/3/ Changes: https://reviews.apache.org/r/59070/diff/2-3/ Testing --- Thanks, Vihang Karajgaonkar

<    1   2   3   4   5   6   >