Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169276 --- Huhhh.. this is starting to get too long... I hope you do not

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On March 16, 2017, 9:27 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java > > Lines 423-426 (patched) > > > > > > I think you will kick me around after this. Most probably I was not > >

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/ --- (Updated March 17, 2017, 9:14 a.m.) Review request for hive, Peter Vary and

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/ --- (Updated March 17, 2017, 8:12 a.m.) Review request for hive, Peter Vary and

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On March 16, 2017, 9:27 p.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java > > Lines 423-426 (patched) > > > > > > I think you will kick me around after this. Most probably I was not > >

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169212 --- Thanks, and sorry for the extra rounds. Peter

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/ --- (Updated March 16, 2017, 7:51 p.m.) Review request for hive, Peter Vary and

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169107 --- Thanks for the changes Vaibhav! Good catch with the BeeLine

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/ --- (Updated March 16, 2017, 2:51 a.m.) Review request for hive, Peter Vary and

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On Feb. 22, 2017, 10:20 a.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java > > Lines 398-400 (patched) > > > > > > As far as I know the Java String is immutable, which might cause > >

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

> On Feb. 22, 2017, 10:20 a.m., Peter Vary wrote: > > jdbc/src/java/org/apache/hive/jdbc/Utils.java, lines 398-400 > > > > > > As far as I know the Java String is immutable, which might cause > > problems here. >

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review166345 --- Thanks for the change!

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/ --- (Updated Feb. 21, 2017, 9:01 p.m.) Review request for hive, Peter Vary and

Re: Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review165914 --- Thanks for the patch! As discussed in the jira it would be good

Review Request 56763: HIVE-15931: JDBC: Improve logging when using ZooKeeper

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/ --- Review request for hive, Peter Vary and Thejas Nair. Bugs: HIVE-15931