OK, please let us know when and if you see it again.
I see that there were quite a few changes since the last A-T release,
any volunteers to wear the Release Manager cap and get a new version out?
I'll do it, once the need_* functions have been implemented (which I'll do
as well :)
--Geoff
hi all
ok, attached is a patch that implements the new need variants and alters the
old have variants. basically, all I did was a global rename of have to
need, then implement the have routines in terms of need with the AutoLoader.
I thought this made a bit more sense than redefining all of
Geoffrey Young wrote:
hi all
ok, attached is a patch that implements the new need variants and alters the
old have variants. basically, all I did was a global rename of have to
need, then implement the have routines in terms of need with the AutoLoader.
I thought this made a bit more sense than
Geoffrey Young wrote:
OK, please let us know when and if you see it again.
I see that there were quite a few changes since the last A-T release,
any volunteers to wear the Release Manager cap and get a new version out?
I'll do it, once the need_* functions have been implemented (which I'll do
as
I'd suggest to simply explain that there are have_ and need_ functions
at the beginning of that section that explains need_* ones. And one
should use need_* inside plan(), because of the skip messages. Otherwise
use have_*.
ok, done.
Please don't commit w/o the docs. Once it's committed,
David Wheeler wrote:
On Jul 31, 2004, at 5:04 PM, Stas Bekman wrote:
I guess losing the skip message by making need_ functions that
replace the existing have_ functions is okay. It's most important
that tests continue to pass...
They will.
Then I say we go with need.
I kind of
As part of my smart filtering proposal, I'm looking to tidy up protocol
handling. We have several loose ends to deal with:
* Zero-length responses setting bogus Content-length or unsetting it
(e.g. bug 18757, mod_deflate compressing empty bodies).
* Failing to respect no-transform in a
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Some more work, analysis, and tests yielded apr_file_gets() and MD5 as two
more bottlenecks.
I've
* [EMAIL PROTECTED] wrote:
niq 2004/08/02 04:28:04
Modified:docs/conf httpd-std.conf.in
Log:
Fix Bug 22684 and add some additional charsets.
Provides a better workaround for Bug 23421.
Now we have your additional charsets twice...
nd
--
Winnetous Erbe:
On Mon, 2 Aug 2004, [ISO-8859-15] Andr Malo wrote:
Now we have your additional charsets twice...
Erk! So we do. I guess the best fix is just another update to chop the
duplicates?
--
Nick Kew
* Nick Kew [EMAIL PROTECTED] wrote:
On Mon, 2 Aug 2004, [ISO-8859-15] Andr_ Malo wrote:
Now we have your additional charsets twice...
Erk! So we do. I guess the best fix is just another update to chop the
duplicates?
Sounds like a good idea ;-)
nd
--
Das Verhalten von Gates hatte mir
Our shipping with AddDefaultCharset preconfigured is causing lots of
pages to be served with a bogus charset, typically where authors
rely on meta http-equiv ... and either don't know how to fix it
or lack permission.
Bundling AddDefaultCharsets help users fix this. But really we need
to do two
* [EMAIL PROTECTED] wrote:
niq 2004/08/02 05:23:44
Modified:docs/conf httpd-std.conf.in
Log:
Remove duplicate AddCharsets (both old and new:-)
I'm sorry to nitpick again... Though I have no personal experience with this
kind of case sensitivy, I think we should respect
Justin Erenkrantz wrote:
3) Allow mod_disk_cache to use sendfile
This, in my experience is a huge gain. Another thing to consider is to
use normal open/read/close on the headers file. This saves a few
apr_alloc's and strdup's, which in turn saves some mutex locks. This
may not seem like
On Mon, 2 Aug 2004, [ISO-8859-15] André Malo wrote:
-# The set below does not map to a specific (iso) standard
-# but works on a fairly wide range of browsers. Note that
-# capitalization actually matters (it should not, but it
^^^
Justin Erenkrantz wrote:
-
static void mkdir_structure(disk_cache_conf *conf, char *file,
apr_pool_t *pool)
Another big speed-up may be to pre-make all of the directories. A simple script
could use CacheRoot, |CacheDirLength|, and |CacheDirLevels to create them all. Just
require that this
* Nick Kew [EMAIL PROTECTED] wrote:
Our shipping with AddDefaultCharset preconfigured is causing lots of
pages to be served with a bogus charset, typically where authors
rely on meta http-equiv ... and either don't know how to fix it
or lack permission.
*shrug*, removing AddDefaultCharset
On Mon, 2 Aug 2004, [ISO-8859-15] Andr Malo wrote:
* Nick Kew [EMAIL PROTECTED] wrote:
Our shipping with AddDefaultCharset preconfigured is causing lots of
pages to be served with a bogus charset, typically where authors
rely on meta http-equiv ... and either don't know how to fix it
or
On Mon, 02 Aug 2004 08:46:07 -0400, Brian Akins [EMAIL PROTECTED] wrote:
Justin Erenkrantz wrote:
-
static void mkdir_structure(disk_cache_conf *conf, char *file,
apr_pool_t *pool)
Another big speed-up may be to pre-make all of the directories. A simple script
could use CacheRoot,
On Mon, 2 Aug 2004 12:13:30 +0900 (JST), Tsuyoshi SASAMOTO
[EMAIL PROTECTED] wrote:
(b) I omitted the unrelated fix which was part of your patch; care to
provide an explanation?
Sorry...
--
body = strchr(iov.iov_base,
Jeff Trawick wrote:
Wouldn't assuming that the directory is already there be sufficient
(and then create the directory structure on the error path)? It looks
to me that we only assume the directory structure exists if we had
this very same file cached previously.
In a low traffic site, yes.
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/http/http_request.c (ap_internal_redirect): Call quick_handler
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/experimental/mod_cache.h: Always use atomics.
*
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
Bill Stoddard wrote:
/* Open the headers file */
-rc = apr_file_open(hfd, headers, APR_READ|APR_BINARY, 0, r-pool);
+rc = apr_file_open(hfd, headers, flags, 0, r-pool);
Should be something like this adapted from core:
core_dir_config *core_config;
core_config = (core_dir_config *)
At 05:10 AM 8/1/2004, you wrote:
--On Sunday, August 1, 2004 11:26 AM +0200 Mladen Turk [EMAIL PROTECTED] wrote:
-if ((rv = apr_socket_create(newsock, backend_addr-family,
+#if (APR_VERSION_MAJOR 0)
+if ((rv = apr_socket_create(
+#else
+if ((rv = apr_socket_create_ex(
At 02:35 PM 8/1/2004, Stas Bekman wrote:
John Rowe wrote:
Please define canonicalize
In the context of case-insensitive file systems, it's often the case
that a file is given the canonical name that it was created with
(MyFile) with all other capitalisations (myfile, myfilE) being
alternative
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
(This is probably the largest and most complicated one. At the bottom,
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/experimental/mod_cache.c: Delay no-store check until saving.
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/experimental/mod_cache.c: Reduce logging in mainline case.
These
Brian Akins wrote:
Bill Stoddard wrote:
/* Open the headers file */
-rc = apr_file_open(hfd, headers, APR_READ|APR_BINARY, 0, r-pool);
+rc = apr_file_open(hfd, headers, flags, 0, r-pool);
Should be something like this adapted from core:
core_dir_config *core_config;
core_config =
At 10:46 AM 8/2/2004, Bill Stoddard wrote:
EnableSendfile off is a global directive (?) so only need to check it once at startup
and save it in a static variable?
Oh, no!
Directory /fs1/shared/www
EnableSendfile Off
/Directory
kills sendfile for that mount.
Bill
Bill Stoddard wrote:
* modules/experimental/mod_cache.c: Reduce logging in mainline case.
These are debug messages so not sure why they are a problem.
While mod_cache is experimental, it may help to have more logging rather
than less. Are the logging functions that much of a performance problem
Justin Erenkrantz wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable
in 15
minute patches and I'll review them.
* modules/experimental/mod_disk_cache.c (load_headers): Only validate
William A. Rowe, Jr. wrote:
Oh, no!
Directory /fs1/shared/www
EnableSendfile Off
/Directory
kills sendfile for that mount.
Bill
However, in a quick handler, only the global config matters. Am I
correct? Because the per_dir has not been merged until map to storage
and Location is later.
On Mon, 02 Aug 2004 18:13:09 +0200, Graham Leggett [EMAIL PROTECTED] wrote:
Bill Stoddard wrote:
* modules/experimental/mod_cache.c: Reduce logging in mainline case.
These are debug messages so not sure why they are a problem.
While mod_cache is experimental, it may help to have more
--On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
-1, Need to check for EnableSendfile off.
No, core_output_filter does that check. Modules don't have that information
whether
--On Monday, August 2, 2004 11:44 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
These are debug messages so not sure why they are a problem.
+0
The logging code is expensive to call for every request like that as many
times as it does. IMHO, there's no benefit to such a verbose log. More
Justin Erenkrantz wrote:
--On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
* modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies.
-1, Need to check for EnableSendfile off.
No, core_output_filter does that check. Modules don't have that
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Thanks for the review! I've committed all of the non-contentious ones (i.e.
sendfile and logging).
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Here's another patch that was hidden in my earlier one. I think 'read' and
'write' are awful terms
--On Monday, August 2, 2004 1:05 PM -0400 Bill Stoddard [EMAIL PROTECTED]
wrote:
I should amend my vote a -.5. The patch should work as you've coded it but
opening a file for use with apr_sendfile causes the file to be opened for
overlapped i/o on Windows. I expect some of the codepaths will
William A. Rowe, Jr. wrote:
At 02:35 PM 8/1/2004, Stas Bekman wrote:
John Rowe wrote:
Please define canonicalize
In the context of case-insensitive file systems, it's often the case
that a file is given the canonical name that it was created with
(MyFile) with all other capitalisations (myfile,
Justin Erenkrantz wrote:
--On Monday, August 2, 2004 1:05 PM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
I should amend my vote a -.5. The patch should work as you've coded it
but
opening a file for use with apr_sendfile causes the file to be opened for
overlapped i/o on Windows. I expect
--On Monday, August 2, 2004 8:46 AM -0400 Brian Akins [EMAIL PROTECTED]
wrote:
Another big speed-up may be to pre-make all of the directories. A simple
script could use CacheRoot, |CacheDirLength|, and |CacheDirLevels to create
them all. Just require that this script be ran before starting a
--On Monday, August 2, 2004 9:21 AM -0400 Brian Akins [EMAIL PROTECTED]
wrote:
In a low traffic site, yes. In a very high traffic site, with lots of
objects, the mkdir's kill you. After a while, most of the directories
will be created. However, bringing up a fresh server behind a very busy
Justin Erenkrantz wrote:
post_config's not a bad place for that. But, I've yet to get a good
handle on my thoughts for the storage mechanism that mod_disk_cache is
using. My hunch so far is that it's really inefficient. (The reading
of the headers one-byte at a time with the brain-dead
--On Monday, August 2, 2004 10:55 AM -0700 Justin Erenkrantz
[EMAIL PROTECTED] wrote:
--On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
Too many changes in one patch. Break this up into multiple consumable in 15
minute patches and I'll review them.
Here's another
Justin Erenkrantz wrote:
mod_cache isn't doing anything stupid or damaging
performance-wise, I'd like to start being more aggressive about what we
can cache. From my perspective, these patches I've posted (and started
to commit) are just the beginning of trying to get mod_cache on more
solid
Justin Erenkrantz wrote:
The other bottleneck I looked at was MD5 as the on-disk naming
scheme. I think MD5 is a poor choice here because it's not very
fast. Ideally, switching to a variant of the times-33 hash might
work out better. *shrug*
How to handle collisions?
--
Brian Akins
Senior
Bill Stoddard wrote:
To get mod_cache/mod_mem_cache (I know little or nothing about
mod_disk_cache) really performing competatively against best-of-breed
caches will require bypassing output filters
Yes.
(and prebuilding headers)
Is there a way to send pre built headers? mod_asis uses
--On Monday, August 2, 2004 2:54 PM -0400 Brian Akins
[EMAIL PROTECTED] wrote:
The other bottleneck I looked at was MD5 as the on-disk naming
scheme. I think MD5 is a poor choice here because it's not very
fast. Ideally, switching to a variant of the times-33 hash might
work out better.
--On Monday, August 2, 2004 3:01 PM -0400 Brian Akins
[EMAIL PROTECTED] wrote:
(and prebuilding headers)
Is there a way to send pre built headers? mod_asis uses
ap_scan_script_header_er which is fairly slow.
That was what I fixed with apr_file_gets() last night. The code there was
really
--On Monday, August 2, 2004 2:49 PM -0400 Bill Stoddard
[EMAIL PROTECTED] wrote:
To get mod_cache/mod_mem_cache (I know little or nothing about
mod_disk_cache) really performing competatively against best-of-breed
caches will require bypassing output filters (and prebuilding headers)
and
On 1-Aug-04, at 4:41 PM, Justin Erenkrantz wrote:
Instead, what mod_proxy could do is expose a user directive that says
'no representation transformation allowed' and act accordingly: bypass
all filters except for the network filters.
In fact, if the filter chain cannot optimise byte ranges,
Justin Erenkrantz wrote:
MD5 has the possibility for collisions, too. What do squid or other
proxies do?
True. I'll see what others do.
On one hand, I think doing MD5 is sort of silly - just use the URL
itself. *shrug* -- justin
With mod_disk_cache, how about urls such as:
Hello,
I'm working with Apache 1.3.29 and while testing with a self-build
http-client, I noticed that Apache doesn't respond correctly according
to the accept-encoding header. The RFCs say, that if the Accept-Encoding
header is empty or if Accept-Encoding header is identity, no coding
shall be
* Marten Lehmann [EMAIL PROTECTED] wrote:
I'm working with Apache 1.3.29 and while testing with a self-build
http-client, I noticed that Apache doesn't respond correctly according
to the accept-encoding header. The RFCs say, that if the Accept-Encoding
header is empty or if Accept-Encoding
Justin Erenkrantz wrote:
MD5 has the possibility for collisions, too.
Any reason md4 was not used in mod_cache? In my ad hoc tests, it seems
much faster. I do not know the in-and-outs of encryption, but is there
any compelling reason to use md5 over md4 in this case? We don't care
if
On Mon, Aug 02, 2004 at 04:54:07PM -0400, Brian Akins wrote:
Any reason md4 was not used in mod_cache? In my ad hoc tests, it seems
much faster. I do not know the in-and-outs of encryption, but is there
any compelling reason to use md5 over md4 in this case? We don't care
if someone
Brian Akins wrote:
On one hand, I think doing MD5 is sort of silly - just use the URL
itself. *shrug* -- justin
One of the goals of the new mod_cache was to support the caching of URL
variants.
I actually have somewhat of a solution:
URL encode the uri and any vary elements:
Mads Toftum wrote:
On Mon, Aug 02, 2004 at 04:54:07PM -0400, Brian Akins wrote:
Any reason md4 was not used in mod_cache? In my ad hoc tests, it seems
much faster. I do not know the in-and-outs of encryption, but is there
any compelling reason to use md5 over md4 in this case? We don't care
Bill Stoddard wrote:
To get mod_cache/mod_mem_cache (I know little or nothing about
mod_disk_cache) really performing competatively against best-of-breed
caches will require bypassing output filters (and prebuilding headers)
and possibly bypassing or at least reworking input filters.
The
* [EMAIL PROTECTED] wrote:
I'm trying to process apache logs to find the total of transferred data for
each member. The files are large and downloads are often stopped and
resumed, downloaded in segments, etc...
I noticed that %b directive in CustomLog *should* mean Bytes sent,
excluding
On Monday, August 2, 2004, at 10:55 AM, Justin Erenkrantz wrote:
Avoid confusion when reading mod_cache code. write_ and read_ often
imply
network code; save_ and load_ are more understandable prefixes in this
context.
Hmm, IIRC, loading a cache means writing to it, not reading from it.
Why
On Mon, 2 Aug 2004, Roy T.Fielding wrote:
Hmm, IIRC, loading a cache means writing to it, not reading from it.
Doh. That does ring a bell in the back of my (usually lousy) memory. :)
Why not just change them to cache_write and cache_read?
Or store and recall?
store and recall seem
--On Monday, August 2, 2004 5:11 PM -0700 Roy T. Fielding
[EMAIL PROTECTED] wrote:
Hmm, IIRC, loading a cache means writing to it, not reading from it.
Why not just change them to cache_write and cache_read?
Or store and recall?
store and recall work, too. *shrug* (I share rbb's inability to
--On Monday, August 2, 2004 8:18 PM -0400 Cliff Woolley
[EMAIL PROTECTED] wrote:
Yeah, it's really good to see the interest in this picking back up. This
seems like a really good way to get us motivated to do a 2.2 release
Sometime Soon. :)
How 'bout 2.2 GA for ApacheCon? Seems reasonable to
Justin Erenkrantz wrote:
--On Monday, August 2, 2004 8:18 PM -0400 Cliff Woolley
[EMAIL PROTECTED] wrote:
Yeah, it's really good to see the interest in this picking back up. This
seems like a really good way to get us motivated to do a 2.2 release
Sometime Soon. :)
How 'bout 2.2 GA for
On Mon, 2 Aug 2004, Bill Stoddard wrote:
How 'bout 2.2 GA for ApacheCon? Seems reasonable to me. ;-) -- justin
+1, sounds like a good target to shoot for.
+1
attached patch looks a bit simpler; does it look okay to you?
Yes, it looks good and smart.
# I wonder about intention of the original code `if (!body)`;
# in what case could it occur... recvmsg() could fail?
# If so, rather return value of the recvmsg() should be checked...
Tsuyoshi SASAMOTO
71 matches
Mail list logo
