On Thu, Sep 27, 2007 at 11:58:01AM +0100, Nick Kew wrote:
On Thu, 27 Sep 2007 08:51:50 +0200
Ruediger Pluem [EMAIL PROTECTED] wrote:
On 09/27/2007 12:42 AM, Nick Kew wrote:
* Chunked response with too big chunks: the response is
lost completely.
Verdict: serious bug!!!
What do
On Fri, Sep 21, 2007 at 12:19:27AM +0100, Sriskanthaverl wrote:
The following simple fix on t/modules/include.t make the test pass
through. Can I have your comments and get it committed. Thankyou.
A few people have complained about this breaking; it seems to work just
as well here so I've
On Thu, Sep 13, 2007 at 09:08:26AM -0500, William Rowe wrote:
Joe Orton wrote:
On Mon, Sep 10, 2007 at 09:47:24PM +0200, Ruediger Pluem wrote:
On 09/10/2007 08:40 AM, Plüm wrote:
That was the goal of my diagnostic patch: Finding out if we have a pool
issue. Looks like we have. I guess
On Fri, Sep 07, 2007 at 02:59:10PM -0500, William Rowe wrote:
FYI - this bug appears to be the root of several modules no longer
behaving as expected on Win32 platforms.
It takes me back to a question I raised on apr quite a while ago,
what does *unix* do with an unset
On Wed, Sep 12, 2007 at 10:47:03AM -, William Rowe wrote:
Author: wrowe
Date: Wed Sep 12 03:47:02 2007
New Revision: 574884
URL: http://svn.apache.org/viewvc?rev=574884view=rev
Log:
Resolve storage of process-lifespan version strings for OpenSSL,
while using request-lifespan copies
On Mon, Sep 10, 2007 at 09:47:24PM +0200, Ruediger Pluem wrote:
On 09/10/2007 08:40 AM, Plüm wrote:
That was the goal of my diagnostic patch: Finding out if we have a pool
issue. Looks like we have. I guess the right fix is as you say
to use the parent pool (process scope).
Not 100%
On Fri, Aug 24, 2007 at 04:32:32PM +0100, Mark Drayton wrote:
...
Issue #40064 has a patch for Apache 2.2 which changes etag_ulong_to_hex() to
etag_uint64_to_hex() and avoids casting the mtime to an (arch-dependent)
unsigned long. We can't move to 2.2 at the moment so instead I patched
2.0.59
]
+
+ *) SECURITY: CVE-2007-3304 (cve.mitre.org)
+ prefork, worker, event MPMs: Ensure that the parent process cannot
+ be forced to kill processes outside its process group.
+ [Joe Orton, Jim Jagielski]
+
+ *) SECURITY: CVE-2006-5752 (cve.mitre.org)
+ mod_status: Fix a possible XSS attack
On Mon, Aug 20, 2007 at 03:36:59PM -0500, William Rowe wrote:
The crux of the problem is that we create processes without a full host
of three fd's. Then we inflict them against sh. Linux/bash doesn't seem
to mind, but solaris sh, and I'm guessing aix and hpux stock /bin/sh are
not going to
+1 for the 2.2.5 tarball: good signature, test suite passes on
Linux/x86_64, looks sane from manual inspection.
joe
On Fri, Jul 27, 2007 at 01:18:08PM -0400, David Jones wrote:
zOS needs to compile with extra CFLAGS in order to link correctly.
After revisions 153273/153266 to ./Makefile.in there is no ability to add
any flags as buildmark.c is made without them directly using compile, i.e:
On Wed, Aug 01, 2007 at 12:58:21AM -, [EMAIL PROTECTED] wrote:
Author: niq
Date: Tue Jul 31 17:58:20 2007
New Revision: 561616
URL: http://svn.apache.org/viewvc?view=revrev=561616
Log:
Fix buffer overflow in date handling
PR 41144 (Davi Arnaut)
This appears to be a buffer over-read,
On Sun, Jul 29, 2007 at 01:37:20PM +0200, Ruediger Pluem wrote:
And BTW, as the order of the encodings in Content-Encoding must be the
order in which they have been applied, don't we need to ensure that
gzip needs to be at the *end* of the content encoding string, as we
have to decode
On Tue, Jul 24, 2007 at 09:25:45AM -0400, Jeff Trawick wrote:
On 7/20/07, Jeff Trawick [EMAIL PROTECTED] wrote:
On 7/20/07, Sander Temme [EMAIL PROTECTED] wrote:
On Jul 20, 2007, at 7:30 AM, Jeff Trawick wrote:
Index: src/modules/standard/mod_status.c
+1, it's the same stuff we did
On Sun, Jul 22, 2007 at 09:18:49AM -0400, Eric Covener wrote:
On 7/22/07, Mike [EMAIL PROTECTED] wrote:
Greetings.
apxs accepts only *.c files as its input. For other extensions it
doesn't invoke libtool in compile mode and several different issues
leading to empty Apache module creation.
On Thu, Jul 19, 2007 at 08:30:37AM -0400, Jeff Trawick wrote:
On 7/14/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Author: sctemme
Date: Sat Jul 14 10:03:18 2007
New Revision: 556298
URL: http://svn.apache.org/viewvc?view=revrev=556298
Log:
Backport of 2.0.x PID table problem fix
+
On Thu, Jul 19, 2007 at 09:06:39AM -0400, Jeff Trawick wrote:
On 7/19/07, Joe Orton [EMAIL PROTECTED] wrote:
On Thu, Jul 19, 2007 at 08:30:37AM -0400, Jeff Trawick wrote:
assert(
CVE-2007-3304 does not apply to 2.0.x. This commit is a fix in the
same general area as the 2.2.x
On Wed, Jul 18, 2007 at 08:25:59AM -0400, Jeff Trawick wrote:
On 6/20/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote:
Author: jorton
Date: Wed Jun 20 10:29:24 2007
New Revision: 549159
URL: http://svn.apache.org/viewvc?view=revrev=549159
Log:
Fix CVE-2006-5752:
*
On Thu, Jul 12, 2007 at 02:06:02AM -, Paul Querna wrote:
Author: pquerna
Date: Wed Jul 11 19:06:01 2007
New Revision: 555458
URL: http://svn.apache.org/viewvc?view=revrev=555458
Log:
Fix VPATH builds of httpd with the apr_memcache backend for ssl
sessions, when APR and APR-Util are
On Thu, Jun 28, 2007 at 12:50:37PM -0400, Jim Jagielski wrote:
On Jun 28, 2007, at 7:56 AM, Joe Orton wrote:
So, final comments on this? If there's consensus that this is the
approach to take I'll revert the pidtable stuff out of trunk, commit
this there, and propose the backport.
Don't
On Mon, Jun 25, 2007 at 02:42:26PM -, Jean-Frederic Clere wrote:
Author: jfclere
Date: Mon Jun 25 07:42:25 2007
New Revision: 550519
URL: http://svn.apache.org/viewvc?view=revrev=550519
Log:
Add sticky_path to solve PR41897.
...
if (!strcasecmp(key, stickysession)) {
+
On Wed, Jun 27, 2007 at 04:42:38PM -0400, Jim Jagielski wrote:
I might be missing this (just did a quick scan) but
what about ap_reclaim_child_processes/reclaim_one_pid()?
Here we trust the pid in the scoreboard and
send signals.
I'd said in the other thread that this wasn't an attack vector
On Thu, Jun 28, 2007 at 02:54:39PM -0400, Brian J. France wrote:
Here is a patch that will allow SIGTERM to work with -X
http://www.brianfrance.com/software/apache/httpd.signal.diff
Without the patch running httpd on the command line with -X and
trying to stop it can only be done by
On Wed, Jun 27, 2007 at 09:38:10PM +0200, Ruediger Pluem wrote:
+/* Ensure the given pid is greater than zero; passing waitpid() a
+ * zero or negative pid has different semantics. */
Ok, it seems as I am trying to become the king of all nitpickers :-):
Style of comment.
Happy
On Thu, Jun 28, 2007 at 02:42:35PM +0200, Plüm, Rüdiger, VF-Group wrote:
The problem is that waitpid() does not distinguish between child
already reaped (ignorable error) and child not in process group
(something bad) so that will mean some unnecessary log spam in some
cases.
I
On Tue, Jun 26, 2007 at 11:03:41PM +0200, Ruediger Pluem wrote:
On 06/26/2007 08:37 PM, Joe Orton wrote:
My summary: I've still not seen any argument why it presents a security
risk for a malicious child to be able to kill a piped logger or other
non-MPM-spawned process, so:
What about
Here's the updated (and simpler) version of my patch which uses
apr_proc_wait() to determine whether a pid is a valid child. Simplifies
the MPM logic a bit since the pid != 0 check is moved into
ap_mpm_safe_kill().
Tested for both prefork and worker (on Linux) to fix the vulnerability
using
My summary: I've still not seen any argument why it presents a security
risk for a malicious child to be able to kill a piped logger or other
non-MPM-spawned process, so:
1) for 2.2.x and 1.3.x apr_proc_wait()/waitpid() can be used instead of
getpgid(pid) == getpgrp() to determine whether the
On Thu, Jun 21, 2007 at 11:22:09PM +0200, Ruediger Pluem wrote:
On 06/21/2007 06:51 PM, Joe Orton wrote:
Secondly: I think this approach is unnecessarily complex. I think it's
sufficient to simply check whether the target process is in the right
process group before sending a signal, i.e
Looking at this further:
I can't actually see any exploit path here at all in 2.0.x prefork:
PSNC folks; in your report, PoC #3 SIGUSR1 killer #1 (Apache 2.x)
concerns the graceful shutdown code, which is only present in 2.2.x,
not 2.0.x.
The ap_reclaim_child_processes() path changed in SVN
On Sat, Jun 16, 2007 at 09:29:25PM -, Jim Jagielski wrote:
Author: jim
Date: Sat Jun 16 14:29:24 2007
New Revision: 547987
URL: http://svn.apache.org/viewvc?view=revrev=547987
Log:
PID table impl: parent process keeps a local table store of
Apache child process PIDs and uses that to
On Thu, Jun 21, 2007 at 06:18:59PM +0100, Colm MacCarthaigh wrote:
On Thu, Jun 21, 2007 at 05:51:34PM +0100, Joe Orton wrote:
On Sat, Jun 16, 2007 at 09:29:25PM -, Jim Jagielski wrote:
Secondly: I think this approach is unnecessarily complex. I think it's
sufficient to simply check
On Tue, May 29, 2007 at 06:36:07PM -0500, William Rowe wrote:
I'm retracting my two proposed choices and going with Option #3 :) Does
anyone object to Jeff's weird proposal below? I think it's the best of
both worlds.
*Guessing* whether the user wants to use a shell based on some syntactic
On Wed, May 23, 2007 at 06:39:48PM -0500, William Rowe wrote:
While I'm working on a solution to permit cmd.exe to be launched from
a service process within Win32, I'm still struck by the inefficiency
here and feel we need to resolve the core issue.
...
[ ] Revert to |foo to invoke foo, and
On Mon, Apr 30, 2007 at 06:16:07PM -, Greg Ames wrote:
Author: gregames
Date: Mon Apr 30 11:16:06 2007
New Revision: 533820
URL: http://svn.apache.org/viewvc?view=revrev=533820
Log:
check_pipeline: use AP_MODE_SPECULATIVE to check for data in the input
filters
to accomodate
On Tue, Apr 24, 2007 at 10:56:15AM -, Martin Kraemer wrote:
Author: martin
Date: Tue Apr 24 03:56:14 2007
New Revision: 531875
URL: http://svn.apache.org/viewvc?view=revrev=531875 Log: Add
forgotten '||true' to prevent 'make install-man' from returning an
error if rsync is not
On Thu, Apr 12, 2007 at 10:05:06AM -0400, Jeff Trawick wrote:
I wonder why Error in ProxyErrorOverride doesn't match the meaning
of ap_is_HTTP_ERROR(), as in the attached patch (with doc).
Great, +1
1xx isn't something the user should see/react to either.
Forwarding 1xx responses is actually
On Wed, Apr 04, 2007 at 10:34:31PM +0100, Stuart Children wrote:
Behaviour *has already been broken* from 2.0.x to 2.2.x - I've given
evidence of this. Our work systems heavily rely on the 2.0 behaviour.
Maybe someone else would like to repeat my tests - it's possible
it's not as simple as
On Mon, Mar 26, 2007 at 02:26:28PM -0400, Michael B Allen wrote:
However, from searching the archives I recall some comments that it was
perhaps inappropriate to use anything but the C locale because globally
changing the locale might yield non-determinisitic behavior. Is that
true? Or is it
On Thu, Mar 22, 2007 at 09:14:32PM +0100, Mladen Turk wrote:
Guenter Knauf wrote:
Hi,
Should we add a cert-creation .sh and .vbs script to support/ for this
purpose (on any platform)? Sounds like a great idea to me!
+1 from me.
If you find my vbs useful then I will contribute it.
I've
On Mon, Mar 19, 2007 at 10:15:03PM +0100, Ruediger Pluem wrote:
[on passing empty brigades and mod_cache]
Once we detect that we have a fresh content entity in the cache, the
quick handler of mod_cache starts the filter chain by calling
ap_pass_brigade(r-output_filters, out);
where out is
Thanks a lot for the review!
On Sat, Mar 17, 2007 at 04:30:24PM +0100, Ruediger Pluem wrote:
Some comments from my side:
- Passing empty brigades: While I agree that a filter should never create
an empty brigade and pass it down the chain, I think it actually should
pass an empty
Again, thanks for the review!
On Sat, Mar 17, 2007 at 07:44:02AM -0400, Jeff Trawick wrote:
I guess I'm confused about the up/down direction convention for output
filters? I thought passing the next output filter is down and
returning to the prior input filter is up?
My confusion - I always
http://people.apache.org/~jorton/output-filters.html
How does this look? Anything missed out, anything that doesn't make
sense? I think this covers most of the major problems in output filters
which keep coming up.
I'd also like to add a simple buffering filter which does things right
and
On Tue, Mar 13, 2007 at 09:24:25AM -0400, Jim Jagielski wrote:
There have been times when having a simple sed filter in Apache
would be useful... I used to use just ext_filter to do this,
but this got more and more painful the more I used it. So awhile
ago I made mod_sed_filter which I find
On Wed, Mar 14, 2007 at 03:01:53PM +, Nick Kew wrote:
On Wed, 14 Mar 2007 14:32:13 +
Joe Orton [EMAIL PROTECTED] wrote:
1) the filtering logic is broken and will consume RAM proportional to
response size.
I must've missed that when I looked. I thought it used the
same logic
On Wed, Mar 14, 2007 at 03:45:05PM +, Nick Kew wrote:
Nope. Just one brigades worth at a time. And the most likely case
for that to be an entire document is when it's a static file, and
document == brigade == bucket.
I'm not sure what you're saying here. Which do you agree with:
a)
On Wed, Mar 14, 2007 at 06:38:48PM +, Nick Kew wrote:
Now, what leads you to suppose mod_line_edit uses RAM proportional
to content size? Other than when the entire contents arrive in a
single bucket?
Because it implements the naive filter implementation, equivalent to:
e =
On Mon, Mar 12, 2007 at 09:38:34PM +0100, Ruediger Pluem wrote:
On 03/12/2007 04:05 PM, [EMAIL PROTECTED] wrote:
...
+ * (basically a faster version of 'sprintf(%llx)')
*/
#define HEX_DIGITS 0123456789abcdef
-static char *etag_ulong_to_hex(char *next, unsigned long u)
+static char
On Tue, Mar 06, 2007 at 12:50:18AM +0100, Ruediger Pluem wrote:
Author: jorton
Date: Mon Mar 5 15:21:31 2007
New Revision: 514915
URL: http://svn.apache.org/viewvc?view=revrev=514915
Log:
* support/logresolve.c (main): Fix potential NULL pointer dereference,
found by Coverity
On Mon, Mar 05, 2007 at 09:33:56PM +0100, Ruediger Pluem wrote:
On 03/03/2007 05:47 AM, Karl Chen wrote:
present. Also other issues like noise in the log file. I've also
seen people complaining that GET / might incur the cost of
dynamic content generation for /.
Hm. Just thinking loud.
On Mon, Mar 05, 2007 at 01:40:46PM -0600, William Rowe wrote:
I'm planning to rename
http://svn.apache.org/repos/asf/httpd/sandbox/fips-dev/
to
http://svn.apache.org/repos/asf/httpd/sandbox/Gaithersburg/
just to prevent anyone from mis-understanding the current state of
that
On Sun, Mar 04, 2007 at 01:13:08PM +0100, Ruediger Pluem wrote:
On 03/04/2007 01:53 AM, Kevin wrote:
I guess redhat has applied some sort of patch. Does anyone know abou
I don't think so. Joe?
For the record, no, we don't use anything different to the upstream code
here.
Also
On Mon, Feb 05, 2007 at 08:46:01PM -, [EMAIL PROTECTED] wrote:
Author: rpluem
Date: Mon Feb 5 12:46:01 2007
New Revision: 503863
URL: http://svn.apache.org/viewvc?view=revrev=503863
Log:
* Add missing Changelog entry for PR41056 / PR 19954. This was fixed in
r480135.
It looks like
On Tue, Feb 06, 2007 at 05:35:00PM +0100, Ruediger Pluem wrote:
On 02/06/2007 04:49 PM, Jim Jagielski wrote:
Joe, can you see if the below fixes it:
Index: http_filters.c
===
--- http_filters.c (revision 504180)
+++
On Mon, Feb 05, 2007 at 09:26:25PM +0100, Ruediger Pluem wrote:
Would the following change in mod_cache.h require a major bump or would a
minor bump be enough?
...
Or do we need no bump at all as we currently do not install
mod_cache.h in the includes directory and thus all things defined in
On Wed, Jan 31, 2007 at 09:45:12PM +0100, Dr. Peter Poeml wrote:
Users have a problem with directory listings generated by mod_autoindex:
It is not possible to control the character setting which which the
response is marked.
AddDefaultCharset does allow this already as you mention in the bug.
On Thu, Jan 11, 2007 at 10:11:18PM -0800, Sander Temme wrote:
On Jan 11, 2007, at 1:40 PM, Ruediger Pluem wrote:
A week sounds good to me. I guess some of them are my fault as I only
set them to resolved fixed and never visited them again as I thought
that they reached their final state.
Hi Marc,
On Mon, Jan 08, 2007 at 02:15:44PM +0100, Marc Stern - Approach wrote:
1. The current idea is to trap validation-related errors, like
certificate expiration/revocation.
Shouldn't we also trap negotiation errors, like incompatible
ciphersuites and protocols between browser and
On Sun, Jan 07, 2007 at 06:09:38PM -0600, William Rowe wrote:
There is a very slick feature in perl, burried quite deeply, that
might be useful for our users of ./configure (and apr's as well.)
loclibpth/locincpth define the system search order
They don't, though. The *toolchain* defines
On Wed, Jan 03, 2007 at 07:25:59PM -0800, Chris Darroch wrote:
Thanks -- we have a crusty old gcc on one machine, so I didn't notice
these. Also, I see that the p variable in dbd_param() is unused in the
non-threaded version and throws up a warning as well. With luck this
should fix the
On Wed, Jan 03, 2007 at 04:54:59PM -0500, Tim Olsen wrote:
Hello,
I'm not very familiar with autoconf so forgive me if I'm wrong, but it
looks like AC_MSG_NOTICE is not in autoconf 2.13 but it is being used
by buildconf which specifies an AC_PREREQ(2.13)
Thanks for the report - I've fixed
On Tue, Jan 02, 2007 at 01:19:22AM -, [EMAIL PROTECTED] wrote:
Author: chrisd
Date: Mon Jan 1 17:19:21 2007
New Revision: 491729
URL: http://svn.apache.org/viewvc?view=revrev=491729
Log:
Rename functions and variables for consistency, and move some functions
around for readability,
On Wed, Dec 13, 2006 at 01:02:52AM -0600, William Rowe wrote:
William A. Rowe, Jr. wrote:
LIBTOOL = /bin/sh /usr/local/apache20/build/libtool --silent
SH_LIBTOOL = /bin/sh /usr/local/apache20/build/libtool --silent
I don't know where it came up with that nonsense...
APR APR-UTIL
On Wed, Dec 13, 2006 at 01:16:35PM +0100, Paul Fee wrote:
The RPATH is slightly different.
The only way to avoid the RPATH (in general) is to link APR/APR-util
statically; which can only be achieved by not building the shared
libraries. So passing --disable-shared to configure may work,
Forwarded and closed since there is no apreq product in bugzilla, let
infra know if you want one :)
(this -lipv6api doesn't come from API so I presume it comes form apreq?)
- Forwarded message from [EMAIL PROTECTED] -
From: [EMAIL PROTECTED]
Reply-To: Apache HTTPD Bugs Notification
On Wed, Dec 06, 2006 at 02:15:50AM -0800, Philip M. Gollucci wrote:
CFLAGS=-g3 -fno-strict-aliasing -O0 -DAP_UNSAFE_ERROR_LOG_UNESCAPED
./configure \
--prefix=$S/httpd/2.2.3/prefork \
--with-apr=$S/apr/1.2.7/bin/apr-1-config \
On Wed, Dec 06, 2006 at 01:30:26PM +0100, Lars Eilebrecht wrote:
According to Jeff:
A lot of opinions were offered back in August. Some were negative but
I don't see anything that looks like a veto.
I voted -1 at that time which is a veto.
My opinion hasn't changed and I still think
On Wed, Dec 06, 2006 at 09:15:15AM -0800, Paul Querna wrote:
Justin Erenkrantz wrote:
On 12/6/06, Frank [EMAIL PROTECTED] wrote:
My question is: How does this interfere with my module? How can I ensure
that only one of us (mod_ssl or my module) is calling these both
functions? I cannot
On Wed, Dec 06, 2006 at 06:20:55PM +, Darryl Miles wrote:
Joe Orton wrote:
What I do with OpenSSL in neon is to check that the existing callback is
NULL before registering a new callback; and likewise to check that the
ID callback is the one neon previously registered before un
On Tue, Dec 05, 2006 at 06:39:30AM -0500, Jeff Trawick wrote:
A lot of opinions were offered back in August. Some were negative but
I don't see anything that looks like a veto.
(http://mail-archives.apache.org/mod_mbox/httpd-dev/200608.mbox/[EMAIL
PROTECTED])
A concern with the logging
On Tue, Nov 28, 2006 at 05:36:55PM -, Jim Jagielski wrote:
Author: jim
Date: Tue Nov 28 09:36:45 2006
New Revision: 480135
URL: http://svn.apache.org/viewvc?view=revrev=480135
Log:
Apply patch for PR 41056 (19954) to fix chunk
filter. Now flushes work better.
This looks wrong to me.
On Wed, Nov 22, 2006 at 06:41:07AM -0600, William Rowe wrote:
Offhand, doesn't ctx pool span the connection?
...
@@ -1469,8 +1468,7 @@
* containing a setaside pool and a brigade which constrain the
* lifetime of the buffered data. */
ctx = apr_palloc(r-pool, sizeof
On Wed, Nov 22, 2006 at 02:15:06PM +0100, François wrote:
On Debian Sarge 3.1 rev2, httpd compiled with external libpcre 4.x and some
RewriteRules segfault occurs every time we start the daemon.
2.0.x doesn't support use of external PCRE, this should be reported to
Debian directly since it's
On Thu, Nov 16, 2006 at 07:45:08AM -0500, Jeff Trawick wrote:
On 10/16/06, Eric Covener [EMAIL PROTECTED] wrote:
Patch below logs the path to the config file just before ap_mpm_run()
Can help clear up some mysteries when posthumously analyzing an ErrorLog
as a further aid, is it practical
On Wed, Nov 08, 2006 at 12:27:31PM -0500, Jim Jagielski wrote:
Mladen Turk wrote:
Jim Jagielski wrote:
Looking over CHANGES and STATUS, I think we should
start thinking about a 2.2.4 release. Comments?
I would like to propose the backport of proxy alternate
is_socket_connected.
On Mon, Oct 30, 2006 at 10:13:09PM +0100, Ruediger Pluem wrote:
2) keep the interface as-is, but read buckets in mod_cache and partition
the brigade manually; only pass a small brigade with known-length
buckets to the provider. (so no morphing and no arbitrary memory
consumption)
As far
On Mon, Oct 30, 2006 at 02:56:24PM -0700, Justin Erenkrantz wrote:
On 10/30/06, Nick Kew [EMAIL PROTECTED] wrote:
What does that [#1] break?
Seems an easy/low-level solution. Does the provider return a
status value to say I have/haven't passed this stuff down the
chain? It has the feel of
On Tue, Oct 31, 2006 at 01:49:10PM +0200, Graham Leggett wrote:
On Tue, October 31, 2006 12:59 pm, Joe Orton wrote:
I very much sympathise with this argument. But it does mean that the
storage provider cannot break any of the assumptions mentioned in the
other thread: it enforces
On Tue, Oct 31, 2006 at 02:11:47PM +0200, Graham Leggett wrote:
On Tue, October 31, 2006 2:02 pm, Joe Orton wrote:
Being able to determine writability from the output filter chain means
redesigning the output filtering interface, there is nothing simple
about it at all.
This seems
On Tue, Oct 31, 2006 at 10:59:49AM +, Joe Orton wrote:
On Mon, Oct 30, 2006 at 02:56:24PM -0700, Justin Erenkrantz wrote:
On 10/30/06, Nick Kew [EMAIL PROTECTED] wrote:
What does that [#1] break?
Seems an easy/low-level solution. Does the provider return a
status value to say I
On Tue, Oct 31, 2006 at 03:17:18PM +0200, Graham Leggett wrote:
On Tue, October 31, 2006 2:31 pm, Joe Orton wrote:
To determine writability of the output filter chain is not as simple as
exposing writability of the socket. An output filter may block on
writes because it is blocked
Thanks Roy. So, the goals for mod_disk_cache as I see it:
A simple general-purpose disk cache which makes no assumptions about
speed of backend, speed of storage or speed of clients; is
single-threaded and does not involve any multi-process synchronisation
beyond open/O_EXCL. Specifically:
On Mon, Oct 30, 2006 at 12:18:30PM +0200, Graham Leggett wrote:
On Mon, October 30, 2006 12:07 pm, Joe Orton wrote:
1) cannot write entire response to disk for any content type before
sending anything to the client; filter acts by writing to cache and
client synchronously
Justin vetoed
On Mon, Oct 30, 2006 at 09:51:30AM -0700, Justin Erenkrantz wrote:
It would make
custom 3rd party modules easier to write too; we could define, say 1
as PROVIDER_ID_CUSTOM, making it easier to write add-ons to modules
which use the provider interface to just write new providers with that
On Mon, Oct 30, 2006 at 10:26:18AM -0700, Justin Erenkrantz wrote:
On 10/30/06, Joe Orton [EMAIL PROTECTED] wrote:
1) cannot write entire response to disk for any content type before
sending anything to the client; filter acts by writing to cache and
client synchronously
My concern
The existing 2.x store_body interface passed a brigade to the storage
provider's store_body() callback. It is impossible for the provider to
store all of such a brigade without consuming an arbitrary amount of
RAM, since the brigade may contain morphing buckets (a CGI/PIPE bucket
is the
On Fri, Oct 27, 2006 at 11:38:02AM -0300, Davi Arnaut wrote:
+/* Is our network connection still alive?
+ * If not, we must continue caching the file, so keep
looping.
+ * We will return the error at the end when caching is
done.
+
On Wed, Oct 25, 2006 at 10:21:26PM +0200, Graham Leggett wrote:
Joe Orton wrote:
There is no other acceptable solution AFAICS. Buffering the entire
brigade (either to disk, or into RAM as the current code does) before
writing to the client is not OK, polling on buckets is not possible
On Thu, Oct 26, 2006 at 11:02:40AM +0200, Graham Leggett wrote:
On Thu, October 26, 2006 10:50 am, Joe Orton wrote:
I'm not sure how that is relevant. The core output filter writes to the
socket directly - it can use non-blocking writes or whatever it likes to
do that. The cache must
On Thu, Oct 26, 2006 at 05:20:10PM +0200, Plüm, Rüdiger, VF EITO wrote:
Index: modules/cache/mod_disk_cache.c
===
--- modules/cache/mod_disk_cache.c (revision 450104)
+++ modules/cache/mod_disk_cache.c (working copy)
@@
On Wed, Oct 25, 2006 at 08:17:22AM +0200, Plüm, Rüdiger, VF EITO wrote:
I believe that the parent process, which is supposed to have a 7
second space between its own SIGTERM and SIGKILL, is getting the
SIGKILL before it has slept for 3 seconds *and* sent the final
SIGKILL to the
On Mon, Oct 23, 2006 at 02:45:45PM -0400, Jim Jagielski wrote:
[EMAIL PROTECTED] wrote:
Modified: httpd/httpd/trunk/modules/proxy/ajp.h
URL:
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/ajp.h?view=diffrev=467014r1=467013r2=467014
On Mon, Oct 23, 2006 at 10:11:58PM +0200, Graham Leggett wrote:
Brian Akins wrote:
Can someone please summarize the various patches for mod_disk_cache that
have been floating around in last couple weeks? I have looked at the
patches but wasn't real sure of the general
On Tue, Oct 24, 2006 at 02:47:09PM +0200, Graham Leggett wrote:
On Tue, October 24, 2006 2:22 pm, Joe Orton wrote:
Neither is it appropriate to have any process do the sleep and stat
loop waiting for some other process to finish writing a cache file.
Correct, thus a notify API
On Mon, Oct 02, 2006 at 05:01:51PM -0700, Roy T. Fielding wrote:
In any case, I prefer the style of C code that more directly reflects
the underlying assembly, even if an optimizing compiler would produce
the same assembler for both. It is just natural to read use the result
of this save
On Thu, Sep 28, 2006 at 08:15:44PM -, [EMAIL PROTECTED] wrote:
--- httpd/httpd/trunk/modules/generators/mod_cgi.c (original)
+++ httpd/httpd/trunk/modules/generators/mod_cgi.c Thu Sep 28 13:15:42 2006
@@ -837,6 +837,11 @@
APR_BLOCK_READ, HUGE_STRING_LEN);
On Tue, Sep 26, 2006 at 04:26:57PM -, Graham Leggett wrote:
Author: minfrin
Date: Tue Sep 26 09:26:56 2006
New Revision: 450105
URL: http://svn.apache.org/viewvc?view=revrev=450105
Log:
mod_disk_cache: Make caching of large files possible on 32bit machines
by determining whether the
On Wed, Sep 27, 2006 at 01:31:05PM +0200, Graham Leggett wrote:
On Wed, September 27, 2006 11:37 am, Joe Orton wrote:
I don't get it - as discussed, this approach is completely unsound.
There is no reason to assume it's possible to copy the entire content
into the cache before sending
On Wed, Sep 27, 2006 at 02:41:11PM +0200, Graham Leggett wrote:
On Wed, September 27, 2006 2:31 pm, Joe Orton wrote:
The new approach is exactly the same for other bucket types, FILE should
not be treated as special just to avoid that. Other bucket types will
cause the same memory
801 - 900 of 1532 matches
Mail list logo
