Re: mod_ftp, status and progress?

2007-05-03 Thread Niklas Edmundsson
On Wed, 2 May 2007, Jim Jagielski wrote: In fact, to be honest, it would be easier still to just update ftp_direntry_get() to use apr_fnmatch(), since we always want to support globing. ftp_direntry_get already does most of what makes apr_match_glob attractive in the 1st place. Should have a

Re: mod_ftp, status and progress?

2007-05-03 Thread William A. Rowe, Jr.
Niklas Edmundsson wrote: On Wed, 2 May 2007, Jim Jagielski wrote: In fact, to be honest, it would be easier still to just update ftp_direntry_get() to use apr_fnmatch(), since we always want to support globing. ftp_direntry_get already does most of what makes apr_match_glob attractive in

Re: mod_ftp, status and progress?

2007-05-03 Thread Niklas Edmundsson
On Thu, 3 May 2007, William A. Rowe, Jr. wrote: Another thing I noticed when we started to look at mod_ftp (looking at strace/truss-output trying to figure out why things didn't work) was that it stats all entries in a directory twice, first explicitly and then via the subreq. Wouldn't the

Re: mod_ftp, status and progress?

2007-05-03 Thread William A. Rowe, Jr.
Niklas Edmundsson wrote: This is a separate issue; we need to refactor out 90% of the subrequests and treat these at top level requests. OK. I was under the impression that those subrequests were made to filter out stuff you don't have access to from the directory listings, but I stand

Re: mod_ftp, status and progress?

2007-05-03 Thread Jim Jagielski
On May 3, 2007, at 4:37 AM, William A. Rowe, Jr. wrote: Niklas Edmundsson wrote: On Wed, 2 May 2007, Jim Jagielski wrote: In fact, to be honest, it would be easier still to just update ftp_direntry_get() to use apr_fnmatch(), since we always want to support globing. ftp_direntry_get already

Re: mod_ftp, status and progress?

2007-05-02 Thread Jim Jagielski
On Apr 28, 2007, at 1:40 PM, Jim Jagielski wrote: In fact, to be honest, it would be easier still to just update ftp_direntry_get() to use apr_fnmatch(), since we always want to support globing. ftp_direntry_get already does most of what makes apr_match_glob attractive in the 1st place.

Re: mod_ftp, status and progress?

2007-04-28 Thread Jim Jagielski
On Apr 27, 2007, at 5:18 PM, Niklas Edmundsson wrote: On Fri, 27 Apr 2007, Jim Jagielski wrote: I'm actually looking at removing the whole glob stuff and emulating it as regexes... Wouldn't apr_match_glob() be a better starting point? I don't really see the point of going via regexes... I

Re: mod_ftp, status and progress?

2007-04-28 Thread Jim Jagielski
On Apr 28, 2007, at 1:34 PM, Jim Jagielski wrote: On Apr 27, 2007, at 5:18 PM, Niklas Edmundsson wrote: On Fri, 27 Apr 2007, Jim Jagielski wrote: I'm actually looking at removing the whole glob stuff and emulating it as regexes... Wouldn't apr_match_glob() be a better starting point? I

Re: mod_ftp, status and progress?

2007-04-27 Thread Jim Jagielski
On Apr 26, 2007, at 5:39 PM, Niklas Edmundsson wrote: On Thu, 26 Apr 2007, Jim Jagielski wrote: I'm actually looking at removing the whole glob stuff and emulating it as regexes... Wouldn't apr_match_glob() be a better starting point? I don't really see the point of going via regexes...

Re: mod_ftp, status and progress?

2007-04-27 Thread Niklas Edmundsson
On Fri, 27 Apr 2007, Jim Jagielski wrote: I'm actually looking at removing the whole glob stuff and emulating it as regexes... Wouldn't apr_match_glob() be a better starting point? I don't really see the point of going via regexes... I was thinking for 2.0.x compatibility... Wouldn't it be

Re: mod_ftp, status and progress?

2007-04-26 Thread Jim Jagielski
On Apr 18, 2007, at 1:22 PM, Guenter Knauf wrote: Hi, the current code fails to build for Win32 target. This is because ftp_glob.c seems not APR-ised yet; I'm actually looking at removing the whole glob stuff and emulating it as regexes...

Re: mod_ftp, status and progress?

2007-04-26 Thread Niklas Edmundsson
On Thu, 26 Apr 2007, Jim Jagielski wrote: On Apr 18, 2007, at 1:22 PM, Guenter Knauf wrote: Hi, the current code fails to build for Win32 target. This is because ftp_glob.c seems not APR-ised yet; I'm actually looking at removing the whole glob stuff and emulating it as regexes...

Re: mod_ftp, status and progress?

2007-04-26 Thread Jim Jagielski
On Apr 26, 2007, at 8:55 AM, Niklas Edmundsson wrote: On Thu, 26 Apr 2007, Jim Jagielski wrote: On Apr 18, 2007, at 1:22 PM, Guenter Knauf wrote: Hi, the current code fails to build for Win32 target. This is because ftp_glob.c seems not APR-ised yet; I'm actually looking at removing the

Re: mod_ftp, status and progress?

2007-04-26 Thread Jim Jagielski
On Apr 26, 2007, at 9:22 AM, Jim Jagielski wrote: On Apr 26, 2007, at 8:55 AM, Niklas Edmundsson wrote: On Thu, 26 Apr 2007, Jim Jagielski wrote: On Apr 18, 2007, at 1:22 PM, Guenter Knauf wrote: Hi, the current code fails to build for Win32 target. This is because ftp_glob.c seems not

Re: mod_ftp, status and progress?

2007-04-26 Thread Niklas Edmundsson
On Thu, 26 Apr 2007, Jim Jagielski wrote: I'm actually looking at removing the whole glob stuff and emulating it as regexes... Wouldn't apr_match_glob() be a better starting point? I don't really see the point of going via regexes... I was thinking for 2.0.x compatibility... Wouldn't it

Re: mod_ftp, status and progress?

2007-04-26 Thread Guenter Knauf
Hi, Wouldn't it be better to focus on 2.2.x and onwards? OK, there's a lot of people still running 1.3 and 2.0, but that doesn't mean that we have to make it run on all of them... I'm all for focusing on getting it usable for 2.2+, and if people it compile and runs fine with 2.2.x at least on

Re: mod_ftp, status and progress?

2007-04-26 Thread Brad Nicholes
On 4/26/2007 at 4:16 PM, in message [EMAIL PROTECTED], Guenter Knauf [EMAIL PROTECTED] wrote: Hi, Wouldn't it be better to focus on 2.2.x and onwards? OK, there's a lot of people still running 1.3 and 2.0, but that doesn't mean that we have to make it run on all of them... I'm all for

Re: mod_ftp, status and progress?

2007-04-26 Thread William A. Rowe, Jr.
Niklas Edmundsson wrote: On Thu, 26 Apr 2007, Jim Jagielski wrote: I'm actually looking at removing the whole glob stuff and emulating it as regexes... Wouldn't apr_match_glob() be a better starting point? I don't really see the point of going via regexes... I was thinking for 2.0.x

Re: mod_ftp, status and progress?

2007-04-19 Thread Guenter Knauf
Hi Bill, You built from modules/ftp/mod_ftp.dsp, or built with modules/ftp/Makefile.apxs? Apologies! Was entirely my fault; I did self add the ftp_glob.c to mod_ftp.dsp cause I thought that was forgotten to add; sorry. Compiles now fine when I use original mod_ftp.dsp, at least for 2.2; for

Re: mod_ftp, status and progress?

2007-04-18 Thread Guenter Knauf
Hi, the current code fails to build for Win32 target. This is because ftp_glob.c seems not APR-ised yet; g_opendir() uses the DIR struct which is not available on Win32 AFAICT. Guenter.

Re: mod_ftp, status and progress?

2007-04-18 Thread William A. Rowe, Jr.
Guenter Knauf wrote: Hi, the current code fails to build for Win32 target. This is because ftp_glob.c seems not APR-ised yet; g_opendir() uses the DIR struct which is not available on Win32 AFAICT. You built from modules/ftp/mod_ftp.dsp, or built with modules/ftp/Makefile.apxs? For

Re: mod_ftp, status and progress?

2007-03-27 Thread Guenter Knauf
Hi, is it possible that with your last commit changes you forgot to update mod_ftp.h too? I tried to compile for NetWare, and needed this in order to get it compiled: --- mod_ftp.h.orig Tue Mar 27 13:27:22 2007 +++ mod_ftp.h Tue Mar 27 13:49:04 2007 @@ -250,6 +250,8 @@ const char

Re: mod_ftp, status and progress?

2007-03-27 Thread William A. Rowe, Jr.
Guenter Knauf wrote: Hi, is it possible that with your last commit changes you forgot to update mod_ftp.h too? Feh - yup. My bad - thanks! also want to ask if it is ok when I add NetWare makefiles? Be our guest :) Keep it mind it's ment to be built against installed httpd, or built in

Re: mod_ftp, status and progress?

2007-03-27 Thread Guenter Knauf
Hi, also want to ask if it is ok when I add NetWare makefiles? Be our guest :) Keep it mind it's ment to be built against installed httpd, or built in tree (within modules/ftp/) as desired. sorry, but for now only inside tree; anyway all NetWare compile is sort of cross-compile, and way

Re: mod_ftp, status and progress?

2007-03-26 Thread Niklas Edmundsson
On Fri, 23 Mar 2007, William A. Rowe, Jr. wrote: * Play well with mod_cache, if a file has been requested with HTTP a FTP request should reuse the cached copy. Last time I checked mod_ftp only did subrequests which mod_cache didn't act on. In terms of using 'top level' requests in lieu

Re: mod_ftp, status and progress?

2007-03-23 Thread William A. Rowe, Jr.
Niklas Edmundsson wrote: * Play well with mod_cache, if a file has been requested with HTTP a FTP request should reuse the cached copy. Last time I checked mod_ftp only did subrequests which mod_cache didn't act on. In terms of using 'top level' requests in lieu of subrequests, it's not

Re: mod_ftp, status and progress?

2007-03-23 Thread Ruediger Pluem
On 03/23/2007 04:59 PM, Niklas Edmundsson wrote: * Play well with mod_cache, if a file has been requested with HTTP a FTP request should reuse the cached copy. Last time I checked mod_ftp only did subrequests which mod_cache didn't act on. Of mod_cache works with subrequests as well.