Re: consider reopening 1.3

2003-11-16 Thread Bill Stoddard
Peter J. Cranstone wrote: In today's environment it's all about 2 words - price/performance. Show me that Apache 2.x can outperform 1.x by a factor 10 on the same box. Dig around... I posted a benchmark to this list early in 2.0 development showing a 10x improvement of threaded 2.0 over 1.3 on

Re: Antw: RE: consider reopening 1.3

2003-11-17 Thread Bill Stoddard
Colm MacCarthaigh wrote: On Mon, Nov 17, 2003 at 11:01:46AM -0700, Peter J. Cranstone wrote: Oh yes - forgot about v6... that's a must have for Apache. Is it available for 1.x? If not that would be the first feature to add. The KAME project has IPv6 patches for 1.3.* at

Re: Antw: RE: consider reopening 1.3

2003-11-17 Thread Bill Stoddard
Rasmus Lerdorf wrote: On Mon, 17 Nov 2003, Bill Stoddard wrote: Apache 1.4, an APR'ized version of Apache 1.3 (to pick up IPV6 and 64 bit support) with all the Windows specific code stripped out and source compatability (to the extent possible) with Apache 1.3 modules would probably see rapid

Re: Finding da fun.

2003-11-17 Thread Bill Stoddard
Ben Hyde wrote: Success stories that create a sense of safety. I know of some folks that use an Apache 2 derivitive (a -very- close derivitive) with the worker MPM to support nearly 10, concurrent clients with a -single- child process. Big honking complex third party module figures

Re: Bug in mod_cache?

2003-11-18 Thread Bill Stoddard
Brian Akins wrote: Matthieu Estrade wrote: mod_cache is not caching / because of negotiate problem, if i remember well. We discuss many times to why not caching, and never find really a good reason to not cache /. I see this in mod_cache.c /* DECLINE urls ending in / ??? EGP: why? */ if

Re: Apache + Windows

2003-11-18 Thread Bill Stoddard
Peter J. Cranstone wrote: Bill, Here is an interesting link to a problem someone encountered running Apache on Windows. If he's right there is little hope for Apache to ever run properly on newer versions of Windows. http://grumet.net/weblog/archives/2003/11/18/questions_about_windows_apache.

Re: Bug in mod_cache?

2003-11-20 Thread Bill Stoddard
Bill Stoddard wrote: Brian Akins wrote: Matthieu Estrade wrote: mod_cache is not caching / because of negotiate problem, if i remember well. We discuss many times to why not caching, and never find really a good reason to not cache /. I see this in mod_cache.c /* DECLINE urls ending

Re: Global keepalive count possible?

2003-11-24 Thread Bill Stoddard
Brian Akins wrote: I have been thinking about this and just wanted to see if it were possible. Say that MaxClients is 1024. Normally, with keepalives turned on, all 1024 of these threads (or proc's) can be busy doing keep alives which means that they could just be sitting around waiting for

Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm.h

2003-12-03 Thread Bill Stoddard
Cliff Woolley wrote: On Thu, 20 Nov 2003 [EMAIL PROTECTED] wrote: stoddard2003/11/20 11:44:19 Modified:.CHANGES server/mpm/winnt child.c mpm.h Log: Win32: Make Win32 MPM transaction pools honor MaxMemFree /* Create the tranaction pool */ -

Re: Regarding worker MPM and queue_push/pop

2003-12-04 Thread Bill Stoddard
MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) wrote: I sure would do that sometime today. The leader probably uses some apr_atomic stuff - and I'm trying to see if I can use IA64 native code to do the atomics. For people at ease with visual stuff, here's the CPU performance that I'm getting with worker

Re: mod_mem_cache pools

2003-12-09 Thread Bill Stoddard
Ian Holsman wrote: hi. I was wondering if the queue/hash routines in mod-mem-cache could be reverted to using the pool based ones, instead of the malloc-based ones. and possibly change some of the object creation to pool based as well. this would leave the headers/content as malloc'd 2

[PATCH] Create plog pool before pconf

2003-12-10 Thread Bill Stoddard
Check out this PR: http://nagoya.apache.org/bugzilla/show_bug.cgi?id=20462 plog is created after pconf which means that plog will be cleaned up before pconf during destroy_and_exit_process() called during shutdown. It is not uncommon for modules to register cleanups against pconf and log

Re: [PATCH] Create plog pool before pconf

2003-12-11 Thread Bill Stoddard
William A. Rowe, Jr. wrote: So you propose an inversion here? Won't that break as many modules making the (currently) correct assumptions, w.r.t. config data? Logs are created *from* values in the configuration, ergo they should go away *before* the values that created them are also destroyed.

Re: [PATCH] Page Fault in mod_mem_cache-steaming response

2003-12-11 Thread Bill Stoddard
Jean-Jacques Clar wrote: Bugzilla Defect #21285 This is a rework of the already posted patch. It address the following situation; 1- request comes in for streaming response 2- before that request could be completed, the entry is ejected from the cache 3- when completing the write body step,

Re: cvs commit: httpd-2.0/modules/experimental mod_charset_lite.c

2003-12-15 Thread Bill Stoddard
[EMAIL PROTECTED] wrote: martin 2003/12/15 06:24:31 Modified:modules/experimental mod_charset_lite.c Log: Flame bait: mod_charset_lite would decide in the mime checker phase whether a conversion was required, and would stick with that decision, even if a later handler (like CGI

Re: (detabifyied) Re: [PATCH] Page Fault in mod_mem_cache-steaming response

2003-12-15 Thread Bill Stoddard
Jean-Jacques Clar wrote: Just replaced tabs with spaces to follow guidelines. [EMAIL PROTECTED] 12/11/2003 5:00:31 PM Bugzilla Defect #21285 This is a rework of the already posted patch. It address the following situation; 1- request comes in for streaming response 2- before that request

Re: cvs commit: httpd-2.0/modules/experimental mod_charset_lite.c

2003-12-16 Thread Bill Stoddard
William A. Rowe, Jr. wrote: At 03:57 PM 12/15/2003, Bill Stoddard wrote: [EMAIL PROTECTED] wrote: martin 2003/12/15 06:24:31 Revision ChangesPath 1.67 +70 -0 httpd-2.0/modules/experimental/mod_charset_lite.c +#if #system(bs2000) This syntax causes a compile failure on Windows

Re: (detabifyied) Re: [PATCH] Page Fault in mod_mem_cache-steamingresponse

2003-12-18 Thread Bill Stoddard
Jean-Jacques Clar wrote: There is a memory leak with your patch when running my test. snip I need to do more investigation to find out which pieces of memory are leaking. No need. I was removing the object from the cache but never cleaning it up. Easy enough to fix. Bill

Re: Forensic Logging

2003-12-29 Thread Bill Stoddard
Ben Laurie wrote: Jeff Trawick wrote: Ben Laurie wrote: One of the problems that crops up depressingly often is that someone gets owned, and they can't find out why. This is generally because the offending request didn't get logged, because the server died before it logged it. far more

Re: Forensic Logging

2003-12-30 Thread Bill Stoddard
Ben Laurie wrote: Bill Stoddard wrote: Ben Laurie wrote: If it does nothing unless a file is specified, why not enable by default? Like Jeff, I am more interested in this for debugging process crashes that are not necessarily related to attacks. Might be useful to enable this function

Re: Forensic Logging

2003-12-30 Thread Bill Stoddard
Bill Stoddard wrote: Ben Laurie wrote: Bill Stoddard wrote: Ben Laurie wrote: If it does nothing unless a file is specified, why not enable by default? Like Jeff, I am more interested in this for debugging process crashes that are not necessarily related to attacks. Might be useful

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Bill Stoddard
Hi Jean-Jacques, What specific problem is this patch correcting? I committed a fix for 21287 prior to the holidays. The idea behind using atomic operators on refcount is to avoid the need to acquire the mutex when incrementing/decrementing refcount. Bill [EMAIL PROTECTED] wrote: clar

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Bill Stoddard
Here is the patch that fill fix the problem reported by 21287 http://cvs.apache.org/viewcvs.cgi/httpd-2.0/modules/experimental/mod_mem_cache.c?r1=1.99r2=1.100 Bill Hi Jean-Jacques, What specific problem is this patch correcting? I committed a fix for 21287 prior to the holidays. The idea behind

Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-08 Thread Bill Stoddard
Jean-Jacques Clar wrote: Bill, The patch you committed is only for 21285. My bet for 21287 (no mutex lock protection in decrement_refcount). from the bug description: /There are no mutex lock protection in decrement_refcount if it is defined USE_ATOMICS. I think you simply forgot the mutex in

Re: [PATCH] mod_proxy hangs on 304 from backend

2004-01-08 Thread Bill Stoddard
Richard Reiner wrote: mod_proxy hangs when both KeepAlive and ProxyErrorOverride are enabled, and a non-200 response without a body is generated by the backend server. Commited to 2.1 and called a vote to backport to 2.0. Thanks, Bill

Re: Reverting, WAS: Re: cvs commit: httpd-2.0/modules/experimental mod_mem_cache.c

2004-01-09 Thread Bill Stoddard
Sander Striker wrote: On Fri, 2004-01-09 at 03:48, Bill Stoddard wrote: Looks like 21287 it is not a valid defect based on your explanation. How do I rev back my changes? Here is how you can see the patch: cvs diff -u -r 1.102 -r 1.103 mod_mem_cache.c revison numbers are from cvs.apache.org

Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h

2004-01-13 Thread Bill Stoddard
Do you know of any cases that actually require mpm_state to be updated in ap_signal_parent()? Setting winnt_mpm_state to AP_MPMQ_STOPPING in child main should be sufficient unless I am missing something. Bill [EMAIL PROTECTED] wrote: trawick 2003/12/16 18:16:44 Modified:

Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h

2004-01-14 Thread Bill Stoddard
Jeff Trawick wrote: Bill Stoddard wrote: Do you know of any cases that actually require mpm_state to be updated in ap_signal_parent()? Setting winnt_mpm_state to AP_MPMQ_STOPPING in child main should be sufficient unless I am missing something. the code in service.c which shuts down

Re: [PATCH] Location block speed up

2004-01-16 Thread Bill Stoddard
WHat happens if the handler DECLINES the request and do we care? Bill [EMAIL PROTECTED] wrote: I'm interested in doing some scalability testing with worker on Linux to see what the O(1) scheduler and new pthread library buys us, and what happens with different values for ThreadsPerChild. I

Re: [PATCH] Location block speed up

2004-01-16 Thread Bill Stoddard
[EMAIL PROTECTED] wrote: Bill Stoddard wrote: WHat happens if the handler DECLINES the request My guess is that the default handler will be called, try to open a non-existant file and send back a 404. I'll find out. Make sure file 'silly' exists in documentroot and make sure it has access

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Bill Stoddard
Jeff Trawick wrote: Ben Laurie wrote: Jeff Trawick wrote: See http://www.apache.org/~trawick/exception_hook_13.html You should make the logged strings safe, like mod_log_forensic does, and I think the format should be compatible (which means no space after the colon). Thanks for taking a

Re: [1.3 PATCH] a different take on forensics

2004-01-22 Thread Bill Stoddard
if the code is always built into the server (with/without EnableExceptionHook setting), perhaps we should add the #define AP_ENABLE_EXCEPTION_HOOK in ap_config.h for platforms where we know it will work +1 Bill

Re: [PATCH 1.3] fix buglet in the 1.3.30-dev prctl() logic

2004-02-02 Thread Bill Stoddard
Jeff Trawick wrote: The buglet was that prctl() was issued always when available, when goal (to be consistent with httpd 2.x) was to only issue it if admin has coded CoreDumpDirectory. The buglet was due to a misunderstanding in the use of ap_coredump_dir[]. ap_coredump_dir_configured is not

Re: RTP/RTCP in Apache.

2004-02-11 Thread Bill Stoddard
GEORGE JOSEPH wrote: Hi all, Is the Apache server capable of Providing Streaming Media with RTP/RTCP or RTSP.Should I put up a different server for the RTP/RTCP.Or can it be used in some way to put up the stream for Video/Audio. Thanks, George. Try it (but be prepared for a fallback plan). I

Re: Time for 1.3.30??

2004-02-18 Thread Bill Stoddard
Jim Jagielski wrote: I'd like to float the idea of releasing 1.3.30 soonish. Not only are there enough changes to warrant a release, but also to coincide with the changeover to AL 2.0. +1 Bill

Re: Time for 1.3.30??

2004-02-19 Thread Bill Stoddard
Ben Laurie wrote: Jeff Trawick wrote: Jim Jagielski wrote: I'd like to float the idea of releasing 1.3.30 soonish. Not only are there enough changes to warrant a release, but also to coincide with the changeover to AL 2.0. one question: who would support putting the 1.3 versions of

Apache 2.0 FAQ

2004-02-19 Thread Bill Stoddard
what is the state of the Apache 2.0 FAQ? It's not clear to me how all the pieces, index.html, index.xml, all_in_one.xml, all_in_one.html, index.html.en, et.al. should fit together. For instance, faq/index.html.en has information that is -not- in faq/index.xml. Is this broken or do I just not

Re: apr/apr-util python dependence

2004-02-20 Thread Bill Stoddard
Roy T. Fielding wrote: However I completely disagree that Python (or Perl or PHP) is a good choice for use in build systems. As part of the configure process, I would agree with you, but as part of buildconf, I disagree--not everyone needs to run buildconf--only developers, and if

Re: Help required on Apache from scratch...

2004-02-25 Thread Bill Stoddard
Benedict DSilva wrote: Hi all, Just wanted to know about how does the Apache HTTP Server start, and all that it does with the modules (Initialization, Configuration etc). Explaining how Apache HTTPD works to the degree of detail you are looking for is a rather tall request to answer in an

Re: win32 on VC++ 5.0

2004-03-05 Thread Bill Stoddard
Geoffrey Young wrote: I seem to recall there being a perl script to convert the 6.0 project files to 5.0 format. If it exists, it will be in the source distribution. Perhaps it is in 1.3 distro? No time to check now. Bill

[EXPERIMENTAL PATCH] to mod_cache

2004-03-06 Thread Bill Stoddard
Configure mod_mem_cache to cache files in mem, set CacheExpiresMax 1 then turn ab loose fetching a single cachable static file and watch what happens. You get exploding memory usage in the subprocess_env serialized headers. The initial cache load caches whatever is in subprocess_env. On the

Re: cvs commit: httpd-2.0/server eoc_bucket.c Makefile.in connection.c core.c

2004-03-09 Thread Bill Stoddard
André Malo wrote: * Joe Orton [EMAIL PROTECTED] wrote: On Mon, Mar 08, 2004 at 08:32:30PM +0100, André Malo wrote: * [EMAIL PROTECTED] wrote: * include/http_connection.h: Declare eoc bucket interface. Shouldn't this be a minor MMN bump? I dunno, I don't really see the point in bumping the

Re: [PROPOSAL] Move httpd to the subversion repository

2004-03-15 Thread Bill Stoddard
Jim Jagielski wrote: I would +1 moving over after release of 2.0.49 and 1.3.30... :) +1 Bill

Re: 2.0.49 (rc2) tarballs available

2004-03-15 Thread Bill Stoddard
Jeff Trawick wrote: Sander Striker wrote: There are 2.0.49-rc2 tarballs available at: http://httpd.apache.org/dev/dist/ This is not a regression issue, but it is a storage corruption issue as well as a simple fix that should be easy to review: *) mod_cgid: Fix storage corruption caused by

Re: 2.0.49 (rc3) tarballs available, WAS: Re: 2.0.49 (rc2) tarballs available

2004-03-17 Thread Bill Stoddard
Sander Striker wrote: On Wed, 2004-03-17 at 20:16, Andre Breiler wrote: Hi, On Sat, 13 Mar 2004, Sander Striker wrote: Hi, There are 2.0.49-rc2 tarballs available at: http://httpd.apache.org/dev/dist/ I guess you didn't get around to do the -rc3 yet. Actually, I did :) You can find -rc3

Re: Win32DisableAcceptex

2004-03-22 Thread Bill Stoddard
Joshua Slive wrote: Didn't we decide in the move to 2.0 that all directives would take an argument? Maybe I wasn't paying attention. Win32DisableAcceptex seems to work just by being present in the config with no argument. True. Shouldn't it instead be Win32DisableAcceptex on|off To be more

Re: Win32DisableAcceptex

2004-03-22 Thread Bill Stoddard
William A. Rowe, Jr. wrote: At 08:42 AM 3/22/2004, Bill Stoddard wrote: Shouldn't it instead be Win32DisableAcceptex on|off To be more consistent with EnableSendFile on|off, et. al? Hadn't considered that but it makes sense. or easier to parse and consistant w/ mmap/sendfile

Re: [PATCH]: emulate_sendfile fix [WAS]: File buckets v. core_output_filter

2004-03-22 Thread Bill Stoddard
Bojan Smojver wrote: I think I finally found the culprit. At first I thought it was the core_output_filter, but it turns out that emulate_sendfile (incorrectly) assumes that it is at the beginning of the file even when it's not. The attached patch works here when I have the combo of buckets as

Re: Win32DisableAcceptex

2004-03-24 Thread Bill Stoddard
Tikka, Sami wrote: Rather than talk about what the name of the directive is, I'd like to raise the issue does workaround involved really work or not. I have a customer who runs a lightly loaded W2K server with Apache 2.0.45 + selected patches and every couple of hours it hangs for 10-15 minutes

Re: [PATCH]: emulate_sendfile fix [WAS]: File buckets v. core_output_filter

2004-03-24 Thread Bill Stoddard
Bojan Smojver wrote: I think I finally found the culprit. At first I thought it was the core_output_filter, but it turns out that emulate_sendfile (incorrectly) assumes that it is at the beginning of the file even when it's not. The attached patch works here when I have the combo of buckets as

Re: Performance of TransmitFile on Windows Servers with 2.0.49

2004-04-12 Thread Bill Stoddard
Philip Gladstone wrote: I noticed that the performance of TransmitFile (used when EnableSendFile On on Windows platforms) was significantly worse than EnableSendFile Off. It turns out that the way that TransmitFile is called is *without* the TF_WRITE_BEHIND flag. This means that TransmitFile does

Re: Performance of TransmitFile on Windows Servers with 2.0.49

2004-04-12 Thread Bill Stoddard
Bill Stoddard wrote: Philip Gladstone wrote: I noticed that the performance of TransmitFile (used when EnableSendFile On on Windows platforms) was significantly worse than EnableSendFile Off. It turns out that the way that TransmitFile is called is *without* the TF_WRITE_BEHIND flag. This means

Re: [STATUS] (httpd-2.1) Wed Apr 14 23:45:17 EDT 2004

2004-04-15 Thread Bill Stoddard
Pier Fumagalli wrote: On 15 Apr 2004, at 04:45, Rodent of Unusual Size wrote: * mod_proxy: Ability to run SSL over proxy gateway connections, encrypting (or reencrypting) at the proxy. Does this mean that in 2.1 the SSLProxyEngine on doesn't work anymore? Pier I think it means

Re: cvs commit: httpd-2.0/server core.c

2004-05-17 Thread Bill Stoddard
[EMAIL PROTECTED] wrote: jorton 2004/05/17 08:24:31 Modified:server core.c Log: * server/core.c (core_output_filter): Don't explicitly delete the EOC bucket, and don't buffer the brigade if it ends in an EOC. Won't this change result in a memory leak? Bill

Re: about time for another 2.0.x release?

2004-06-14 Thread Bill Stoddard
Jeff Trawick wrote: looks like 30-35 real fixes already in 2.0.50-dev and another several approved for backport, as well as a handful of enhancements +1 Bill

Re: huge memory leak in 2.0.x

2004-06-15 Thread Bill Stoddard
@@ -1340,7 +1343,7 @@ /* Run cleanups */ run_cleanups(pool-cleanups); -pool-cleanups = NULL; +pool-free_cleanups = pool-cleanups = NULL; /* If new child pools showed up, this is a reason to raise a flag */ if (pool-child) @@ -1886,7 +1889,13 @@ #endif /*

Re: huge memory leak in 2.0.x

2004-06-15 Thread Bill Stoddard
Bill Stoddard wrote: @@ -1340,7 +1343,7 @@ /* Run cleanups */ run_cleanups(pool-cleanups); -pool-cleanups = NULL; +pool-free_cleanups = pool-cleanups = NULL; /* If new child pools showed up, this is a reason to raise a flag */ if (pool-child) @@ -1886,7 +1889,13

Re: Windows HTTP API

2004-06-21 Thread Bill Stoddard
William A. Rowe, Jr. wrote: At 11:47 AM 6/21/2004, Bill Stoddard wrote: William A. Rowe, Jr. wrote: Thanks for the interesting references and citations. Apache HTTP server works at a lower level, below the layer exposed by this http.dll API. To actually use this interface would require a few

Re: interesting Win32 PR 23982: Apache 2.xx is incompatible with Winsock 2.0

2004-06-21 Thread Bill Stoddard
Jeff Trawick wrote: William A. Rowe, Jr. wrote: At 07:12 AM 6/21/2004, Jeff Trawick wrote: There is an explanation with enough detail to be interesting about why Apache 2.0 doesn't get along with layered service providers. See http://issues.apache.org/bugzilla/show_bug.cgi?id=23982 Can some

Re: interesting Win32 PR 23982: Apache 2.xx is incompatible with Winsock 2.0

2004-06-21 Thread Bill Stoddard
Playing with this patch... seems to work w/minimal performance penalty... Bill Index: sendrecv.c === RCS file: /home/cvs/apr/network_io/win32/sendrecv.c,v retrieving revision 1.64.2.1 diff -u -r1.64.2.1 sendrecv.c --- sendrecv.c 13

Re: Apache HTTP Server 2.0.50-rc2 tarballs available for testing

2004-06-23 Thread Bill Stoddard
I just commited a fix for this. Bill Andre Schild wrote: Hello, I have taken the sources as tagged in CSV and tried it to build under Windows 2000. It fails when compiling xlate.c to generate libaprutil xlate.c c:\Develop\Apache\httpd-2.0.50-rc1\srclib\apr-util\xlate\xlate.c(181) : error C2 198:

Re: [1.3 PATCH] restore failing errno for Win32 spawn errors

2004-06-25 Thread Bill Stoddard
+1 Looks like an oversite that this patch wasn't applied long ago. The pattern of saving the errno of an earlier operation then restoring it on error exit is repeated all over alloc.c. Bill eff Trawick wrote: When COMSPEC is unset or set to something bogus, trying to start Apache with a piped

[PATCH] mod_log_config %b should always log '-' rather than '0'

2004-06-30 Thread Bill Stoddard
The %b option is used to log the 'bytes_sent' in a reply. Unlike %B, %b should log a '-' rather than '0' if no body is sent on a reply. I recently ran across two cases where %b incorrectly logs '0': First case is when ap_set_byterange sets HTTP_RANGE_NOT_SATISFIABLE to the default_handler.

Re: Some Oprofile results

2004-07-06 Thread Bill Stoddard
Brian Akins wrote: I'm writing an optimized caching module. I've been using 2.0.50. Here are the top 50 from oprofile ( http://oprofile.sourceforge.net/ ): I submitted a patch to rework ap_rgetline/core_input_filter a year or so ago that provided some performance improvements. If you are

Re: Some Oprofile results

2004-07-07 Thread Bill Stoddard
Brian Akins wrote: Jean-Jacques Clar wrote: Would you please share with us some info on that optimized caching module. I'll say what I can. I'm hoping I can GPL it. Is mod_url_cache a modified copy of the current ones? No. It borrows some ideas from various other modules, including mod_cache

Re: Some Oprofile results

2004-07-07 Thread Bill Stoddard
Brian Akins wrote: Bill Stoddard wrote: I'd certainly be interested in knowing how much faster mod_url_cache is as compared to mod_cache/mod_mem_cache. The only way I can see to -dramatically- improve the performance of mod_cache/mod_mem_cache is to completely bypass i/o filters. I have some

Re: mod_cache: allowing urls ending in / to be cached

2004-07-16 Thread Bill Stoddard
Pier Fumagalli wrote: I don't understand why mod_cache forcedly avoids caching URLs ending with the / (slash) character. Apparently EGP (who's he?) agrees. Anyhow, it's several months that we're running with this patch in production, and nothing bad seems to be happening. Pier diff -U3 -wr

Re: [PATCH] mod_cache fixes

2004-08-01 Thread Bill Stoddard
Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. Bill

Re: [PATCH] mod_cache fixes: #1

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/http/http_request.c (ap_internal_redirect): Call quick_handler

Re: [PATCH] mod_cache fixes: #2

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_cache.h: Always use atomics. * modules

Re: [PATCH] mod_cache fixes: #3

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies

Re: [PATCH] mod_cache fixes: #4

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. (This is probably the largest and most complicated one. At the bottom

Re: [PATCH] mod_cache fixes: #5

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_cache.c: Delay no-store check until saving

Re: [PATCH] mod_cache fixes: #6

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_cache.c: Reduce logging in mainline case

Re: [PATCH] mod_cache fixes: #3

2004-08-02 Thread Bill Stoddard
Brian Akins wrote: Bill Stoddard wrote: /* Open the headers file */ -rc = apr_file_open(hfd, headers, APR_READ|APR_BINARY, 0, r-pool); +rc = apr_file_open(hfd, headers, flags, 0, r-pool); Should be something like this adapted from core: core_dir_config *core_config; core_config

Re: [PATCH] mod_cache fixes: #7

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Sunday, August 1, 2004 11:25 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: Too many changes in one patch. Break this up into multiple consumable in 15 minute patches and I'll review them. * modules/experimental/mod_disk_cache.c (load_headers): Only validate

Re: [PATCH] mod_cache fixes: #3

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Monday, August 2, 2004 10:35 AM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: * modules/experimental/mod_disk_cache.c: Allow sendfile on cache bodies. -1, Need to check for EnableSendfile off. No, core_output_filter does that check. Modules don't have

Re: [PATCH] mod_cache fixes: #3

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Monday, August 2, 2004 1:05 PM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: I should amend my vote a -.5. The patch should work as you've coded it but opening a file for use with apr_sendfile causes the file to be opened for overlapped i/o on Windows. I expect

Re: [PATCH] mod_cache fixes: #8

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: mod_cache isn't doing anything stupid or damaging performance-wise, I'd like to start being more aggressive about what we can cache. From my perspective, these patches I've posted (and started to commit) are just the beginning of trying to get mod_cache on more solid

Re: [PATCH] mod_cache fixes: #8

2004-08-02 Thread Bill Stoddard
Mads Toftum wrote: On Mon, Aug 02, 2004 at 04:54:07PM -0400, Brian Akins wrote: Any reason md4 was not used in mod_cache? In my ad hoc tests, it seems much faster. I do not know the in-and-outs of encryption, but is there any compelling reason to use md5 over md4 in this case? We don't care

Re: [PATCH] mod_cache fixes: #9

2004-08-02 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Monday, August 2, 2004 8:18 PM -0400 Cliff Woolley [EMAIL PROTECTED] wrote: Yeah, it's really good to see the interest in this picking back up. This seems like a really good way to get us motivated to do a 2.2 release Sometime Soon. :) How 'bout 2.2 GA for

Re: mod_cache performance

2004-08-03 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Monday, August 2, 2004 2:49 PM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: To get mod_cache/mod_mem_cache (I know little or nothing about mod_disk_cache) really performing competatively against best-of-breed caches will require bypassing output filters

Re: mod_cache performance

2004-08-03 Thread Bill Stoddard
Bill Stoddard wrote: Justin Erenkrantz wrote: --On Monday, August 2, 2004 2:49 PM -0400 Bill Stoddard [EMAIL PROTECTED] wrote: To get mod_cache/mod_mem_cache (I know little or nothing about mod_disk_cache) really performing competatively against best-of-breed caches will require bypassing

Re: mod_cache performance

2004-08-03 Thread Bill Stoddard
Mathihalli, Madhusudan wrote: : -Original Message- : From: Bill Stoddard [mailto:[EMAIL PROTECTED] [SNIP] : : Here's some comparative numbers to chew on. : : One client and one server on 100Mbps network (cheapy : 100Base-T switch); : 50 simulated users hitting 7 URLs 100 times

Re: mod_dir and mod_cache

2004-08-03 Thread Bill Stoddard
Brian Akins wrote: I think I missed the answer to this: Has the feature that prevents mod_cache from caching urls ending in / (as related to mod_dir) been fixed? If so, will this make it into 2.0? yes it has been fixed. I volunteer to help with the backport. Just need to get the votes to

Re: mod_dir and mod_cache

2004-08-03 Thread Bill Stoddard
Bill Stoddard wrote: Brian Akins wrote: I think I missed the answer to this: Has the feature that prevents mod_cache from caching urls ending in / (as related to mod_dir) been fixed? If so, will this make it into 2.0? yes it has been fixed. I volunteer to help with the backport. Just need

Re: mod_dir and mod_cache

2004-08-04 Thread Bill Stoddard
Jeff Trawick wrote: On Tue, 03 Aug 2004 23:47:21 -0500, William A. Rowe, Jr. [EMAIL PROTECTED] wrote: At 09:29 PM 8/3/2004, Bill Stoddard wrote: mod_cache, mod_mem_cache and mod_disk_cache are experimental modules in 2.0, so I am going to bypass the votes and just start backporting fixes. Please

Re: [PATCH] mod_disk cached fixed

2004-08-04 Thread Bill Stoddard
Brian Akins wrote: Should this: cache_in_filter_handle = ap_register_output_filter(CACHE_IN, cache_in_filter, NULL, AP_FTYPE_CONTENT_SET-1); Actually be this: cache_in_filter_handle =

ARM4 module for Apache 2, any interest?

2004-08-11 Thread Bill Stoddard
I've written a module to ARM4 instrument Apache 2. I'd like to donate this module to the ASF and ideally put it in the modules/experimental directory (or somewhere else in the ASF where we can place it under cvs control?). The ARM4 API headers are available from the Open Group website at

Re: ARM4 module for Apache 2, any interest?

2004-08-11 Thread Bill Stoddard
Paul Querna wrote: So, after a quick look at the website, it looks like ARM4 is some sort of SNMP on Steroids? Also, the License is quite important for any possibility of donating any module to the ASF I think that needs to be pinned down before any discussion can really move forward. The

Re: ARM4 module for Apache 2, any interest?

2004-08-11 Thread Bill Stoddard
Bill Stoddard wrote: Paul Querna wrote: So, after a quick look at the website, it looks like ARM4 is some sort of SNMP on Steroids? Also, the License is quite important for any possibility of donating any module to the ASF I think that needs to be pinned down before any discussion can really

Re: ARM4 module for Apache 2, any interest?

2004-08-11 Thread Bill Stoddard
William A. Rowe, Jr. wrote: Doesn't some de minimis treatment through the incubator still apply? There are two templates, one for a full project's incubation, one for a lightweight pass through IP vetting. ++1 here for submission to the incubator as a new httpd instrumentation subproject. Also

Re: [PATCH] use zlib-1.2.1 with mod_deflate on WIN32

2004-08-12 Thread Bill Stoddard
Mladen Turk wrote: Hi, Small patch that enables building against zlib-1.2.1 instead of ancient 1.1.4 version. Are there any compelling reasons to move from 1.1.4 to 1.2.1? Just curious and no time to investigate for myself right at the moment. Bill

Re: cvs commit: httpd-2.0/modules/generators mod_cgi.c

2004-08-24 Thread Bill Stoddard
André Malo wrote: * [EMAIL PROTECTED] wrote: stoddard2004/08/23 18:49:59 Modified:modules/generators mod_cgi.c Log: Escape bytes returned by the errfn because it might be from an untrusted source Could you ifndef AP_UNSAFE_ERROR_LOG_UNESCAPED it for those who don't want it? nd André,

Re: Time for 2.0.51 and 2.1.0

2004-08-26 Thread Bill Stoddard
Sander Striker wrote: Hi, I'm going to start a TR cycle for both 2.0 and 2.1 monday. Objections? Sander Got a few 2.0 backports from 2.1 I need to drum up support for but otherwise +1 Bill

Re: cvs commit: httpd-2.0/modules/experimental cache_storage.c cache_util.c mod_cache.c mod_cache.h mod_

2004-08-26 Thread Bill Stoddard
Jean-Jacques Clar wrote: Should the type for refcount be apr_atomic_t instead of apr_uint32_t? It does not build currently for NetWare. JJ [EMAIL PROTECTED] 08/26/04 10:59 AM stoddard2004/08/26 09:59:46 Index: mod_cache.h

Re: [PATCH] lingering close thread for worker

2004-08-26 Thread Bill Stoddard
Joe Schaefer wrote: Joe Schaefer [EMAIL PROTECTED] writes: The concept of multiplexing apache's lingering close comes from lingerd, but I thought it'd be interesting to try the same thing for worker with a dedicated closer thread. The patch is intended to improve worker's scaling

Re: Seg fault: Possible race conditions in mod_mem_cache.c

2004-09-06 Thread Bill Stoddard
Jean-Jacques Clar wrote: Testing 2.0 and 2.1 Head. I am running a test that requires frequent ejections of cache entities: max_cache_size and max_object_count are smaller than my sampling. 2 threads running at the concurrently on 2 CPUs. Thread1(T1): an entry is ejected from the cache in

Re: mod_cache 2 questions

2004-09-07 Thread Bill Stoddard
Justin Erenkrantz wrote: --On Tuesday, September 7, 2004 2:48 PM +1000 Ian Holsman [EMAIL PROTECTED] wrote: ok.. so I've started playing with mod-cache again, and I noticed the following: - there is no way to cache something with query-args which doesn't return a expires tag. proposal: add a

Re: [PATCH2] Re: Seg fault: race conditions in mod_mem_cache.c

2004-09-15 Thread Bill Stoddard
Not to knock over the apple cart or anything, but had a 15 second chat with Greg today and he had an idea that sounded good. His idea was to eliminate the cleanup bit entirely and fold the function it is providing into the refcount. With the code in HEAD right now, a cache object sitting in the

  1   2   3   4   5   6   7   8   >