Re: [Bug 51489] ProxyPassReverse adds an additional slash in load balancer setups

2012-08-17 Thread Micha Lenk
Hi Joe, as you are apparently not subscribed to Bugzilla PR 51489, I am answering to your comment on that PR via mail. Please apologize in case you now got my answer twice. On 08/17/2012 03:56 PM CEST +02:00, bugzi...@apache.org wrote: https://issues.apache.org/bugzilla/show_bug.cgi?id=51489

Re: [Bug 51489] ProxyPassReverse adds an additional slash in load balancer setups

2012-08-17 Thread Micha Lenk
Hi Joe, On 08/17/2012 05:00 PM CEST +02:00, Joe Orton wrote: On Fri, Aug 17, 2012 at 04:53:54PM +0200, Micha Lenk wrote: as you are apparently not subscribed to Bugzilla PR 51489, I am answering to your comment on that PR via mail. Please apologize in case you now got my answer twice

Re: Bug with ProxyPass / and mod_proxy_balancer + double-slashes (httpd-2.4.3)

2012-09-16 Thread Micha Lenk
Hi Zisis, Am 06.09.2012 08:07, schrieb Zisis Lianas: Tom, thanks for your feedback. The main difference between our configurations is that you do ProxyPassReverse the single BalancerMember (http://app05/...), which is also working for me - in my configuration I ProxyPassReverse the

[PATCH] mod_xml2enc eats end of file

2012-11-02 Thread Micha Lenk
Hi, I just debugged a case where Apache used as reverse proxy filters a text/javascript file through mod_proxy_html and mod_xml2enc. As mod_proxy_html sees no business in filtering that file, it removes itself from the filter chain, but mod_xml2enc still tries to do its job. In course of

Re: [PATCH] mod_xml2enc eats end of file

2012-11-05 Thread Micha Lenk
Hi Nick, On 11/02/2012 07:25 PM CEST +02:00, Nick Kew wrote: just debugged a case where Apache used as reverse proxy filters a text/javascript file through mod_proxy_html and mod_xml2enc. As mod_proxy_html sees no business in filtering that file, it removes itself from the filter chain, but

Re: [Bug 51489] ProxyPassReverse adds an additional slash in load balancer setups

2012-11-09 Thread Micha Lenk
Hi, On 11/09/2012 01:23 PM CEST +02:00, Mario A. del Riego wrote: Anyone knows about this bug but for Apache 2.2? or a workaround? I saw the patch for Apache 2.4 only. It should be easy to backport the fix for the httpd-2.2 branch. What is needed to get it done? Regards, Micha

Apache httpd at FOSDEM?

2013-01-29 Thread Micha Lenk
Hi all, I am going to attend (first time) the FOSDEM this year and would like to know if there is a chance to meet Apache httpd developers there. I didn't find a dedicated httpd event in the schedule. Is there any other typical event or occasion where to meet some of you? Regards, Micha

Re: [users@httpd] Proxy CONNECT HTTP version

2013-02-04 Thread Micha Lenk
Hi Pavel, On 01/30/2013 11:41 AM CEST +02:00, Pavel Mateja wrote: The wget package will be in next stable debian which sux because all CONNECT requests thru apache will fail. I just compiled wget from git (1.14.31-3be7) and the bug is still there. Any idea what to do? Should somebody fill bug

Documentation on mod_slotmem_shm

2013-02-05 Thread Micha Lenk
Hi all, I am currently working on an Apache module that needs to maintain some shared data that is used by all requests, on all workers. This data does not need to be persistent, so I thought about using shared memory for this task. Someone pointed me to mod_slotmem_shm (hi Rainer), but now I

Re: Documentation on mod_slotmem_shm

2013-02-06 Thread Micha Lenk
Hi Rainer, On 02/05/2013 08:04 PM CEST +02:00, Rainer Jung wrote: Example code using it: modules/cluster/mod_heartmonitor.c should be simplest, look for slotmem and SLOTMEM in there. That should at least show how to bootstrap and use slotmem. Okay, the longer I am reading anything related to

[PATCH] NTLM via Apache as reverse proxy [Bug 39673]

2013-02-26 Thread Micha Lenk
Hi all, I am currently working on bugzilla #39673. The issue here is that NTLM authentication as used in Microsoft products don't work. The reason is that the brilliant engineers at Microsoft who invented this authentication scheme assumed that subsequent client requests sent over a single

Re: [PATCH] NTLM via Apache as reverse proxy [Bug 39673]

2013-03-01 Thread Micha Lenk
Hi, On 02/26/2013 06:55 PM CEST +02:00, I wrote: I am currently working on bugzilla #39673. The issue here is that NTLM authentication as used in Microsoft products don't work. [...] Looking at how mod_proxy_ftp.c solves a similar problem, I tried to solve that issue with the attached patch

Re: mod_proxy_websocket

2013-03-06 Thread Micha Lenk
Hi Jim, On 03/06/2013 02:51 PM CEST +02:00, Jim Jagielski wrote: As trunk and commit watchers may have noticed, I've added a rough mod_proxy_websocket extension module to trunk. The basic idea was to have a simple tunnel that could be used to proxy websocket requests, and that's the design... I

Re: mod_proxy_websocket

2013-03-06 Thread Micha Lenk
Hi Jim, Am 06.03.2013 18:22, schrieb Jim Jagielski: How does your module handle [the mod_reqtimeout] timeouts? Still unanswered,,, Regards, Micha

Re: mod_proxy_websocket

2013-03-07 Thread Micha Lenk
Hi Jim, On 03/07/2013 11:45 AM CEST +02:00, Jim Jagielski wrote: Today, I think that I will actually rename it to mod_proxy_tunnel, which is a more accurate description of the module... I expect it will be used mostly to proxy tunnel websockets, but still, the new name is better. I would

Re: mod_proxy_websocket

2013-03-07 Thread Micha Lenk
Hi Jim, On 03/07/2013 03:08 PM CEST +02:00, Jim Jagielski wrote: It's an http* tunnel. Yet I bet it isn't able to tunnel RPC over HTTP, as described in Bugzilla #40029. If my humble opinion counts, please stick with mod_proxy_websocket. Micha

Re: mod_proxy seg faulting ?

2013-05-04 Thread Micha Lenk
Hi Stefan, Am 03.05.2013 14:09, schrieb Stefan Fritsch: On Thursday 02 May 2013, Thomas Eckert wrote: Lately, I've been seeing httpd/mod_proxy seg faulting in reverse proxy setups, frequency increasing. I am pretty sure that this is a thread-unsafe pool usage. create_proxy_config() puts

Re: URL scanning by bots

2013-05-04 Thread Micha Lenk
Hi, Am 03.05.2013 11:27, schrieb Dirk-Willem van Gulik: FWIIW - the same sentiments where expressed when 'greylisting[1]' in SMTP came in vogue. For small relays (speaking just from personal experience and from the vantage of my own private tiny MTA's) that has however not been the case.

Re: URL scanning by bots

2013-05-04 Thread Micha Lenk
Hi André Am 03.05.2013 14:37, schrieb André Warnier: Basically, after a few cycles like this, all his 100 pool connections will be waiting for a response, and it would have no choice between either waiting, or starting to kill the connections that have been waiting more than a certain amount

Re: mod_proxy, oooled backend connections and the keep-alive race condition

2013-10-01 Thread Micha Lenk
Hi all, Am 01.10.2013 14:36, schrieb Plüm, Rüdiger, Vodafone Group: That's time when the proxy *thinks* the connection is valid but the backend thinks the connection is idle. And in most reverse-proxy cases that prefetch is adding basically no value AFAICT - the backend is a known vintage

Re: mod_proxy, oooled backend connections and the keep-alive race condition

2013-10-03 Thread Micha Lenk
Hi Yann, Am 01.10.2013 17:08, schrieb Yann Ylavic: As far as I understand the issue, the main point of prefetch was to fix CVE-2005-2088, a HTTP Request Smuggling attack (see also http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2005-2088). This is discussed in PR40029 and is

Re: mod_proxy, oooled backend connections and the keep-alive race condition

2013-10-08 Thread Micha Lenk
Hi Yann, Am 03.10.2013 15:33, schrieb Yann Ylavic: On Thu, Oct 3, 2013 at 2:07 PM, Micha Lenk mi...@lenk.info wrote: Independent from how the HRS issue (CVE-2005-2088) was fixed at that time, I still believe that it is a bad idea in terms of security to flush the buffer and forward

Re: ap_proxy_location_reverse_map()

2013-11-27 Thread Micha Lenk
Hi, Am 27.11.2013 12:54, schrieb Jim Jagielski: [...] I'm guessing that if we standardized on using apr_uri_parse() instead of just trying to parse the stuff ourselves, we'd be better off. +1 Regards, Micha

Re: mod_proxy, oooled backend connections and the keep-alive race condition

2013-12-08 Thread Micha Lenk
Hi all, Am 05.12.2013 22:03, schrieb Yann Ylavic: I'm not talking about retrying requests but retrying writing on the socket after trying to re-open a connection. When mod_proxy tries to forward the client request to the backends and encounters a closed connection due to the

Re: make mod_auth_form tell you where the credentials came from

2013-12-08 Thread Micha Lenk
Hi Thomas, Am 03.12.2013 18:04, schrieb Thomas Eckert: Now suppose the following [...] 32 user fills in and submits form 32 custom auth provider receives the user credentials 33 custom auth provider looks up it's own session in it's module internal session cache 34 custom auth provider

Re: unsetting encrypted cookies when encryption key changes

2013-12-08 Thread Micha Lenk
Hi Thomas, Am 04.12.2013 10:53, schrieb Thomas Eckert: 1 user tries to browse protected resource 2 user is redirected to form 3 user fills in and submits form 4 user is redirected to AuthFormLoginSuccessLocation and receives encrypted session cookie (encrypted with key A) 5

Re: Reverse proxy, mod_security, segmentation fault

2013-12-12 Thread Micha Lenk
Hi Ewald, Am 12.12.2013 10:16, schrieb Ewald Dieterich: [...] Is this a bug or am I doing something wrong? I would consider the segmentation faults to be bugs. The question is whether they are bugs in httpd or in mod_security... Looking at the backtraces I noticed that most threads are busy in

Re: r-handler being overwritten with mime type

2013-12-12 Thread Micha Lenk
Hi Graham, Am 12.12.2013 14:28, schrieb Graham Leggett: Does anyone know offhand where I should be looking for something that sets a mime type? It seems that something is setting the handler without checking first to see if the handler has been set already, and this breaks form login. You

Re: mod_proxy, oooled backend connections and the keep-alive race condition

2013-12-16 Thread Micha Lenk
Hi Yann, Am 09.12.2013 00:30, schrieb Yann Ylavic: Now, if trying to send the first bytes of the request immediately fails because the socket isn't connected anymore (e.g. EPIPE), you *know* that exactly *none* bits of your current request reached the server. For this reason

[PATCH] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

2014-03-19 Thread Micha Lenk
Hi Apache developers, over the time I've accumulated some patches for mod_proxy_html which I would like to get reviewed, and get applied in SVN (best both, trunk and then backported to 2.4). This is something that I feel to owe the Apache httpd community. So, lets first start with a bug

[PATCH] mod_proxy_html sometimes adds random characters to HTML pages smaller than 4 bytes

2014-03-19 Thread Micha Lenk
Hi Apache developers, next is a bug that causes mod_proxy_html to add some random characters (+html code) to HTML pages, if the document is smaller than 4 bytes. (Thomas, Ewald, this is issue #18378 in our Mantis). It looks like the output is from some kind of uninitialized memory. The added

[PATCH] mod_proxy_html removes the !doctype tag and breaks XHTML documents

2014-03-19 Thread Micha Lenk
Hi Apache developers, the next patch fixes the behavior of mod_proxy_html to remove any !doctype tags from the beginning of HTML and XHTML documents. (Thomas, Ewald, this is issue #19803 in our Mantis). This !doctype tag is needed by some browsers to correctly render XHTML documents.

[PATCH ASF bugzilla #56284] Extend mod_proxy_html to rewrite URLs in CSS documents too

2014-03-19 Thread Micha Lenk
Hi Apache developers, next is a feature that extends mod_proxy_html to rewrite URLs in CSS documents too. This is done by applying the configured regex and string replacements for the content of HTML tags also on whole CSS documents, i.e. documents with Content-Type: text/css. The attached

How to do a sub-request from input filter?

2011-04-27 Thread Micha Lenk
Hi, I am using Apache as a reverse proxy to forward requests to a backend web server protected by some self-written Apache modules. Now I would like to do a sub-request to a different location from within an input filter. What is the easiest way to achieve this? Reading Nick Kew's excellent

Re: How to do a sub-request from input filter?

2011-04-27 Thread Micha Lenk
Hi Graham, On Wed, Apr 27, 2011 at 07:44:05PM +0200, Graham Leggett wrote: On 27 Apr 2011, at 7:07 PM, Micha Lenk wrote: I am using Apache as a reverse proxy to forward requests to a backend web server protected by some self-written Apache modules. Now I would like to do a sub-request

Re: How to do a internal redirect (was: sub-request) from input filter?

2011-04-28 Thread Micha Lenk
Hi Nick, On Wed, Apr 27, 2011 at 06:39:49PM +0100, Nick Kew wrote: You may be a little confused. Subrquests and internal redirects are not the same thing, and serve different purposes. [...] You're right, what I want is an internal redirect from within my input filter, not a subrequest. A

[PATCH 51489] ProxyPassReverse issue + patch

2011-07-08 Thread Micha Lenk
Hi Apache developers, I'm using Apache as a reverse proxy in a simple load balancer setup. I use ProxyPassReverse in order to re-write the backend server name in HTTP redirections (ie. in the Location header of the HTTP response). My configuration for the virtual host essentially looks like

Re: [PATCH 51489] ProxyPassReverse issue + patch

2011-07-11 Thread Micha Lenk
Hi Jim, Am 10.07.2011 16:57, schrieb Jim Jagielski: Try: Proxy balancer://196f045aca6adc82a0b6eea93ed286a1/ Thank you for your hint. I tried that, but it doesn't change anything. :( Micha

Re: [PATCH 51489] ProxyPassReverse issue + patch

2011-07-11 Thread Micha Lenk
Hi Nick, On 9 Jul 2011, at 11:16, Nick Kew wrote: On 8 Jul 2011, at 17:29, Micha Lenk wrote: I'm using Apache as a reverse proxy in a simple load balancer setup. I use ProxyPassReverse in order to re-write the backend server name in HTTP redirections (ie. in the Location header of the HTTP

Re: [PATCH 51489] ProxyPassReverse issue + patch

2011-08-22 Thread Micha Lenk
Hi Ruediger, sorry, things piled up recently... On 07/13/2011 06:36 PM CEST +02:00, Ruediger Pluem wrote: Try ProxyPassReverse balancer://196f045aca6adc82a0b6eea93ed286a1 instead. This results in an Internal Server Error: [warn] proxy: No protocol handler was valid for the URL request

Re: [PATCH 51489] ProxyPassReverse issue + patch

2011-08-22 Thread Micha Lenk
Hi Ruediger, On 08/22/2011 02:40 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: On 07/13/2011 06:36 PM CEST +02:00, Ruediger Pluem wrote: Try ProxyPassReverse balancer://196f045aca6adc82a0b6eea93ed286a1 instead. This results in an Internal Server Error: [warn] proxy: No protocol handler

With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi, I have configuration with two virtual hosts v1 and v2, both listening on the same IP address. The configuration for the virtual hosts basically looks like this: Listen: 10.0.0.1:80 http NameVirtualHost 10.0.0.1:80 VirtualHost 10.0.0.1:80 ServerName v1 DocumentRoot /srv/v1

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi Ruediger, On 08/22/2011 06:16 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: No, this works as designed and documented for ages. I guess your question is better suited for the us...@httpd.apache.org list. Sorry, I disagree. The documentation reads: Now when a request arrives, the

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi Rüdiger, On 08/22/2011 06:39 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: Sorry, I missed the ServerAlias for the IP in the second virtual host. So, yes in general the second virtual host should be hit. But using IP addresses as Serveralias is quite unusual and in this case the solution

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
Hi Nick, On 08/22/2011 06:45 PM CEST +02:00, Nick Kew wrote: On Mon, 22 Aug 2011 18:27:10 +0200 Micha Lenk mi...@lenk.info wrote: In the case I described earlier, *only* the virtual server v2 has a ServerName that matches the requested hostname. No it doesn't. ServerName or ServerAlias

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-22 Thread Micha Lenk
On 08/22/2011 06:57 PM CEST +02:00, Reindl Harald wrote: but why the fuck are you using hostnames there especially for Listen? I don't. This was just an example to show that the problem doesn't depend on the usage of IP addresses. Wheter I use a hostname or an IP address for 'Listen' is

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-23 Thread Micha Lenk
Hi, On 08/22/2011 07:05 PM CEST +02:00, Eric Covener wrote: Do you agree that this is something that needs to be fixed? If yes I could start to work on a patch... I was skeptical but it certainly looks busted for non-wildcard NVH'es (that can match the strcmp with the VH addr) like you've

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-08-23 Thread Micha Lenk
Hi, On 08/23/2011 10:42 AM CEST +02:00, Micha Lenk wrote: However, I believe the fix is yet incomplete. The function ap_matches_request_vhost() used by modules like mod_proxy seems to implement the virtual host check also in the wrong order. [...] I'll follow up with a patch

CVE-2011-3192 and mod_proxy

2011-08-30 Thread Micha Lenk
Hi, I've just installed the recent security update (package apache2 2.2.16-6+squeeze2) that Debian just released for fixing CVE-2011-3192. I made a short test request for a test document with exactly 10 bytes length and with a header Range: bytes=0-4,5-9,0-9 to test whether the patch works as

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-09-09 Thread Micha Lenk
Hi Rüdiger, On 08/23/2011 12:25 PM CEST +02:00, Plüm, Rüdiger, VF-Group wrote: IMHO the patch does not solve the issue mentioned in the comment and is not needed. Keep in mind the difference between ap_matches_request_vhost and check_host_alias: ap_matches_request_vhost checks only the

Re: With IP address in Host: header ServerName/ServerAlias doesn't work

2011-09-17 Thread Micha Lenk
Hi Rüdiger, Am 09.09.2011 11:45, schrieb Plüm, Rüdiger, VF-Group: Please update the bug report: 1. Declare the unneeded patch obsolete. 2. Update the needed patch to be against trunk. Done. See https://issues.apache.org/bugzilla/show_bug.cgi?id=51709 What else is needed to get it applied to

Re: [PATCH 51709] With IP address in Host: header ServerName/ServerAlias doesn't work

2011-09-17 Thread Micha Lenk
Hi, Am 09.09.2011 11:45, schrieb Plüm, Rüdiger, VF-Group: 2. Update the needed patch to be against trunk. Once again with attached patch for issue 51709, ready for review. Please review it and consider it for commit. Thanks, Micha Index: httpd-trunk/server/vhost.c

Re: mod_proxy_html

2011-10-14 Thread Micha Lenk
Hi, Am 11.10.2011 00:37, schrieb Aaron Bannert: I've been working with mod_proxy_html for the last few months, and I think this would be a good addition to HTTPD. mod_proxy_html could also benefit from some better collaboration, and I personally have some bug fixes and improvements lined up

Re: [PATCH] mod_proxy_html removes the !doctype tag and breaks XHTML documents

2014-03-19 Thread Micha Lenk
Hi all, just for the records: I've just filed this in the ASF bugzilla as issue #56285. Regards, Micha

Re: [PATCH] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

2014-03-19 Thread Micha Lenk
Hi, Just for the records, I've just filed this issue in ASF bugzilla as issue #56286. Regards, Micha On 19.03.2014 20:40, Micha Lenk wrote: Hi Apache developers, over the time I've accumulated some patches for mod_proxy_html which I would like to get reviewed, and get applied in SVN (best

Re: [PATCH] mod_proxy_html deletes wrong data from HTML when meta http-equiv tag specifies Content-Type behind other meta http-equiv tag

2014-03-19 Thread Micha Lenk
Hi again, Err, #56287 that is. Regards, Micha On 19.03.2014 22:05, Micha Lenk wrote: Just for the records, I've just filed this issue in ASF bugzilla as issue #56286.

Re: [PATCH] mod_proxy_html sometimes adds random characters to HTML pages smaller than 4 bytes

2014-03-19 Thread Micha Lenk
Hi, On 19.03.2014 21:19, Jim Jagielski wrote: It's always best, imo, to follow-up with a bugzilla entry with description and patch. Ok, this issue is now filed in ASF bugzilla as #56286. Regards, Micha

[PATCH ASF bugzilla #56288] mod_proxy_html could rewrite URLs in HTML style attributes too

2014-03-19 Thread Micha Lenk
Hi Apache developers, In HTML you can have div tags that have a background image by providing a style attribute. E.g. this can be done by something fancy like this: div style=background:url(http://www.example.com/fancy-background.png) right 0px no-repeat; height:325px; Currently

[PATCH ASF bugzilla #56289] Buffer overflow in mod_proxy_html's string replacement can cause a segfault

2014-03-19 Thread Micha Lenk
Hi developers, The attached patch fixes a buffer overflow in at least one of the six string replacement implementations in mod_proxy_html. Unfortunately I don't remember anymore how to reproduce the issue properly, but I know that some long time ago I fixed a segfault with this patch. The

Re: [PATCH ASF bugzilla #56288] mod_proxy_html could rewrite URLs in HTML style attributes too

2014-03-20 Thread Micha Lenk
Hi, the patch was missing in my previous mail. See attachment. Regards, Micha On 19.03.2014 22:26, Micha Lenk wrote: Hi Apache developers, In HTML you can have div tags that have a background image by providing a style attribute. E.g. this can be done by something fancy like this: div

Re: mod_proxy's aside connections proposal

2014-09-30 Thread Micha Lenk
Hi, On 30.09.2014 16:47, Yann Ylavic wrote: Do you think this can/should (not) be applied to httpd? I would love to see this applied to httpd. Regards, Micha

Re: Differentiating incoming/outgoing connections from pre_connection hook

2015-01-30 Thread Micha Lenk
Hi all again, Am 30.01.2015 14:28, schrieb Micha Lenk: Now, how do I avoid executing the code hooked into the pre_connection hook more than once? I just realized that I can check the scoreboard handle (.sbh) in conn_rec to achive that. Proxy connections are not associated to a scoreboard

Re: Reverse proxy: invalid Content-Length leads to 413 + 400 errors mixed up

2015-01-09 Thread Micha Lenk
Sorry, this shouldn't have gone to dev@httpd.apache.org.

Re: Reverse proxy: invalid Content-Length leads to 413 + 400 errors mixed up

2015-01-09 Thread Micha Lenk
Hi Ewald, zunächst mal ein gutes neues Jahr! Am 08.01.2015 um 17:29 schrieb Ewald Dieterich: On 01/08/2015 04:15 PM, Yann Ylavic wrote: Can you test this (attached) patch please (without yours applied)? Or with yours and just changing return ap_map_http_request_error(status,

Re: Time for 2.4.11

2015-01-09 Thread Micha Lenk
Hi, Am 08.01.2015 um 12:11 schrieb Jim Jagielski: Let's shoot for a TR next week. The work will keep me warm :) Can we please get another vote on this? * core: Fix -D[efined] or Define[d] variables lifetime accross restarts. PR 57328. trunk patch: http://svn.apache.org/r1643825

Re: Time for 2.4.11

2015-01-13 Thread Micha Lenk
Hi Jeff, Am 10.01.2015 18:30, schrieb Jeff Trawick: On Fri, Jan 9, 2015 at 4:35 PM, Micha Lenk mi...@lenk.info wrote: Hi, Am 08.01.2015 um 12:11 schrieb Jim Jagielski: Let's shoot for a TR next week. The work will keep me warm :) Can we please get another vote on this? * core: Fix -D

Differentiating incoming/outgoing connections from pre_connection hook

2015-01-30 Thread Micha Lenk
Hi all, I am currently investigating why and how to cope with the pre_connection hook is called twice for a single request. As I understand it, the reason is that the module in question handles also reverse proxy requests. And ap_run_pre_connection() is not only called by the core in

Segfault on graceful reload with OCSP stapling enabled?

2015-12-18 Thread Micha Lenk
Hi all, I am currently observing a httpd segfault that is triggered on my system by every second graceful reload (i.e. SIGUSR1). Unfotunately I won't be able to trace this down before Monday, so this is merely a heads-up for those interested. Is anybody able to reproduce this behavior?

Re: Segfault on graceful reload with OCSP stapling enabled?

2015-12-21 Thread Micha Lenk
Hi all, Am 18.12.2015 12:35, schrieb Micha Lenk: I am currently observing a httpd segfault that is triggered on my system by every second graceful reload (i.e. SIGUSR1). Unfotunately I won't be able to trace this down before Monday, so this is merely a heads-up for those interested. Is anybody

Re: AddOutputFilterByType in Apache 2.4 inserts filters as AP_FTYPE_RESOURCE

2016-01-14 Thread Micha Lenk
Hi Nick, Am 13.01.2016 22:44, schrieb Nick Kew: PROBLEM DESCRIPTION This is probably worth a bugzilla entry. Done. https://bz.apache.org/bugzilla/show_bug.cgi?id=58856 Nick, would you mind to provide some insights on these comments from my initial mail: For setups with both,

AddOutputFilterByType in Apache 2.4 inserts filters as AP_FTYPE_RESOURCE

2016-01-13 Thread Micha Lenk
Hi, The directive AddOutputFilterByType can be used to insert filters to the output filter chain depending on the content type of the HTTP response. So far so good. PROBLEM DESCRIPTION I observed that the behavior of this directive changed in Apache 2.4 for filters. Starting with Apache

Re: AddOutputFilterByType in Apache 2.4 inserts filters as AP_FTYPE_RESOURCE

2016-01-20 Thread Micha Lenk
Hi Nick, if the patch looks good, as you wrote, what is needed to get it applied to trunk and backported to 2.4.x? Have you seen my follow-up questions in the other mail? Best regards, Micha Am 13.01.2016 22:44, schrieb Nick Kew: On Wed, 2016-01-13 at 17:59 +0100, Micha Lenk wrote: Hi

Re: Experimental C unit test suite available for hacking

2018-05-23 Thread Micha Lenk
e CI setup to implicitly build it as well. Yes, no?! Does the target 'test/httpdunit' not get build in your local builds? Cheers, Micha Lenk

Re: Experimental C unit test suite available for hacking

2018-05-23 Thread Micha Lenk
Hi Joe, On 05/23/2018 04:21 PM, Joe Orton wrote: On Wed, May 23, 2018 at 04:14:39PM +0200, Micha Lenk wrote: Hi Eric, On 05/23/2018 02:59 PM, Eric Covener wrote: I guess the CI setup needs to be updated to at least build the unit tests? I did not configure the build explicitly to run

Re: Experimental C unit test suite available for hacking

2018-05-24 Thread Micha Lenk
On 05/23/2018 10:21 PM, Christophe Jaillet wrote: I can reproduce the issue if I don't pass any --enable-mpms-shared paramater to ./configure. Having --with-mpm=xx only also triggers the building issue. What is your ./configure command line? The initial ./configure command line was:

Re: Experimental C unit test suite available for hacking

2018-05-24 Thread Micha Lenk
Hi Yann, On 05/24/2018 10:41 AM, Yann Ylavic wrote: ./configure --prefix=/home/mlenk/Upstream/Apache/target --with-apr=/home/mlenk/Upstream/Apache/target --with-apr-util=/home/mlenk/Upstream/Apache/target --with-mpm=worker --with-mpms-shared=all --enable-mods-static=most

Re: Experimental C unit test suite available for hacking

2018-05-24 Thread Micha Lenk
Hi Yann, On 05/24/2018 11:23 AM, Yann Ylavic wrote: Yes, for me too, except that the linker problem with undefined symbols now seems to shift to the modules. I had to disable a few modules (--enable-mods-static=most --disable-apreq --disable-proxy-fcgi --disable-session-cookie

Re: Experimental C unit test suite available for hacking

2018-05-24 Thread Micha Lenk
Hi Yann, On 05/24/2018 10:41 AM, Yann Ylavic wrote: --- Makefile.in (revision 1832123) +++ Makefile.in (working copy) @@ -7,9 +7,9 @@ PROGRAM_SOURCES = modules.c PROGRAM_LDADD= buildmark.o $(HTTPD_LDFLAGS) $(PROGRAM_DEPENDENCIES) $(HTTPD_LIBS) $(EXTRA_LIBS) $(AP_LIBS) $(LIBS)

Re: Experimental C unit test suite available for hacking

2018-05-24 Thread Micha Lenk
Hi Yann, FWIW I've found a very good explanation of what's going on during linking and why the library order in static linking is so important. https://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking On 05/24/2018 12:00 PM, Yann Ylavic wrote: Looks like the right order to

Re: Experimental C unit test suite available for hacking

2018-05-24 Thread Micha Lenk
Hi Yann, On 05/24/2018 12:31 PM, Yann Ylavic wrote: Well, first things first. Let's first fix trunk to be buildable again on build systems that really only link the needed symbols and thus rely on the correct library order during linking. I think this is*the* dependency issue, the order in

mod_proxy_html and special characters

2018-05-25 Thread Micha Lenk
Hi all, I'm currently facing an issue where the directive ProxyHTMLURLMap does not work. And I am not sure whether that is by design or not, and where I would appreciate some feedback. Let's assume an imaginary backend server delivers a HTML page that contains a link like this:

Re: Experimental C unit test suite available for hacking

2018-05-23 Thread Micha Lenk
Am 23.05.2018 um 20:18 schrieb Marion et Christophe JAILLET: > Could you please try to 'make clean' and 'make' to see if you still have > the build issue? No change. :( Regards, Micha

Re: [apache/httpd] Add Option to generate multiple error logs of different format in Apache 2.4.x (#52)

2018-06-06 Thread Micha Lenk
Hi all, on Github the pull request #52 https://github.com/apache/httpd/pull/52 looks like it has gone wild, receiving new commits from asfgit every once in a while. The pull request itself looks unusable. Does anybody know who created it and who is updating it? Regards, Micha On

Re: mod_proxy_html and special characters

2018-05-28 Thread Micha Lenk
Hi Eric, On 05/25/2018 06:57 PM, Eric Covener wrote: http://internal/!%22%23$/;>A link with special characters >> ProxyHTMLURLMap "http://internal/!\"#$/; "http://external/!\"#$/; Is it reasonable to expect mod_proxy_html to rewrite URL encoded URLs as well? > IMO no, I don't think the

Re: [VOTE] Allow for defect fix releases at httpd

2018-05-02 Thread Micha Lenk
Hi Graham, On 05/01/2018 04:33 PM, Graham Leggett wrote: What has been missing is input from the major distributors of our software (Fedora, Ubuntu, Redhat, Debian, Apple, Windows, Linux from Scratch, etc), who I believe are probably going “httpd is a mature project, we have nothing to worry

Re: [VOTE] Allow for defect fix releases at httpd

2018-05-03 Thread Micha Lenk
On Wed, May 02, 2018 at 02:56:03PM -0400, Jim Jagielski wrote: > On May 2, 2018, at 10:45 AM, Micha Lenk <mi...@lenk.info> wrote: > > On 05/01/2018 04:33 PM, Graham Leggett wrote: > >> What has been missing is input from the major distributors of our > >> softwar

Re: Wherefor 2.4.36?

2018-08-07 Thread Micha Lenk
On 08/06/2018 07:37 PM, William A Rowe Jr wrote: It appears 2.4.34 is unusable [...] BTW: How usable is it compared to trunk? Regards, Micha ... poking for a 2.6 release.

Re: [PATCH 62186] POST request getting logged as GET request

2018-04-10 Thread Micha Lenk
This is a kind reminder that I still didn't get any response yet. Is there any additional information needed from my side? On 03/29/2018 09:09 PM, Micha Lenk wrote: Hi Apache httpd committers, I think I've found a bug which triggers under following conditions: * Apache is configured

Re: Revisit Versioning? (Was: 2.4.3x regression w/SSL vhost configs)

2018-04-20 Thread Micha Lenk
Hi all, On 04/20/2018 01:34 PM, Jim Jagielski wrote: But why does it matter that h2 was added in 2.4.x instead of a 2.6.0? Because it sets a bad precedence (or even continues to do so)? Every new feature must bump the minor? Even if there is no corresponding ABI issue? Why not? In my

Re: Start using RCs (Was: Re: So... when should we do 2.4.34? [WAS: Re: Revisit Versioning? (Was: 2.4.3x regression w/SSL vhost configs)])

2018-04-20 Thread Micha Lenk
Hi Jim, On 04/20/2018 01:46 PM, Jim Jagielski wrote: Where numbers and versioning DOES matter is how it affects distributors and vendors of httpd and the entire module eco-system. No, it doesn't. There are way too many variants of versioning schemes out there in use by so many OSS projects

Re: A proposal...

2018-04-23 Thread Micha Lenk
Just a side node, some days ago I just realized that the source package of the apache2 package in Debian seems to include the test suite for the purpose of running it as part of the continuous integration test 'run-test-suite': https://ci.debian.net/packages/a/apache2/ In my recently provided

Re: Revisit Versioning? (Was: 2.4.3x regression w/SSL vhost configs)

2018-04-23 Thread Micha Lenk
On Fri, Apr 20, 2018 at 08:14:16AM -0400, Jim Jagielski wrote: > On Apr 20, 2018, at 8:04 AM, Micha Lenk <mi...@lenk.info> wrote: > > [...], I value the ability to distinguish between bugfix-only > > releases and feature addition releases. > > I understand that, thx. I

Re: Start using RCs

2018-04-23 Thread Micha Lenk
Hi Jim, On Fri, Apr 20, 2018 at 08:54:09AM -0400, Jim Jagielski wrote: > We have a history, as well as a published "agreement" on what minor > version numbering means. Just to make sure I am on the same page, would you mind to make that explicit? Where is that published? > Our module

Re: Start using RCs

2018-04-23 Thread Micha Lenk
On 04/23/2018 06:33 PM, William A Rowe Jr wrote: On Mon, Apr 23, 2018 at 11:12 AM, Micha Lenk <mi...@lenk.info> wrote: On Fri, Apr 20, 2018 at 08:54:09AM -0400, Jim Jagielski wrote: We have a history, as well as a published "agreement" on what minor version numbering means. J

Re: Start using RCs

2018-04-24 Thread Micha Lenk
On 04/23/2018 07:24 PM, Paul Querna wrote: https://svn.apache.org/repos/asf/httpd/httpd/trunk/VERSIONING Contains a much more verbose... non-semver versioning scheme. Interesting. Did you realize this already covers the recently suggested use of release candidates? Even on the 2.4.x

[PATCH 62186] POST request getting logged as GET request

2018-03-29 Thread Micha Lenk
Hi Apache httpd committers, I think I've found a bug which triggers under following conditions: * Apache is configured to serve a local customized error page, e.g. using something like "ErrorDocument 404 /var/www/errors/404.html" * Apache is configured to log the original request's method,

Exposing SSL certificates on SNI mismatch

2018-11-08 Thread Micha Lenk
Hi all, I have a customer asking about whether the SSL handshake can be made to fail in case the SNI from the "Client Hello" message doesn't match at all any server name of the configured virtual hosts. E.g. consider a setup like this DNS records: domain-a.tld resolves to domain-b.tld also

Segfault in mod_include (PR 62855)

2018-11-21 Thread Micha Lenk
Hi all, a few weeks ago Ewald was filing this Bugzilla but didn't get any reaction yet. https://bz.apache.org/bugzilla/show_bug.cgi?id=62855 As this looks like it is easy to fix, could someone please take a look? Regards, Micha

How to wait on a global lock with timeout

2014-09-29 Thread Micha Lenk
Hi, in an Apache module I am in the need to wait for a global lock (e.g. an apr_global_mutex_t), but in theory the lock might not get released by the other process in a timely manner, so I would like to limit the time to wait for the lock. What do you suggest me to do? Any suggestions are

Re: How to wait on a global lock with timeout

2014-09-30 Thread Micha Lenk
Hi Yann, On 30.09.2014 18:16, Yann Ylavic wrote: On Tue, Sep 30, 2014 at 5:30 PM, Yann Ylavic ylavic@gmail.com wrote: I have been working on a patch to provide apr_[thread/proc]_mutex_timedlock() in APR, [...] I think that is exactly what I was looking for... Your idea to use the native

  1   2   >