Re: 2.4 (Was: Re: Configuration Issues to Address [was Re: Dynamic configuration for the hackathon?])

2008-04-03 Thread Nick Kew
is active (so method is available as an env var). Certainly on the radar. is of course a crusty old relative. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Configuration Issues to Address [was Re: Dynamic configuration for the hackathon?]

2008-04-03 Thread Nick Kew
dir config. > Maybe no need for Directory, location, etc, either... > I'm thinking more of displacing tortuous mod_rewrite-based configs than any of the old containers (except possibly the much-misunderstood-and-abused ). -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: 2.4 (Was: Re: Configuration Issues to Address [was Re: Dynamic configuration for the hackathon?])

2008-04-03 Thread Nick Kew
#x27;ve got. I don't see any such vision in this discussion. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r644253 - in /httpd/httpd/trunk: docs/manual/mod/core.xml include/ap_mmn.h include/http_core.h server/core.c server/request.c

2008-04-03 Thread Nick Kew
l need to do the previous check. No. The other check applies to / sections, whose code path I've hijacked for . The two are mutually exclusive. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Apache support for form authentication

2008-04-04 Thread Nick Kew
s there before I go, I'll take a look en route. See you at the hackathon? One more point. Stepping up a level, the session management wants to be unified with other logins, even those that don't need it. Especially those popular amongst SSO folks, like LDAP. Hopefully that'll come

Re: Solaris sed based apache filtering module (mod_sed)

2008-04-09 Thread Nick Kew
nicely as an apr_sed module. But that's a whole other discussion. Please have a look into the code and provide your comments. Well, I've had a preview of this, and it's good :-) -- Nick Kew

Re: svn commit: r646281 - in /httpd/httpd/trunk: CHANGES include/http_protocol.h modules/http/http_filters.c

2008-04-10 Thread Nick Kew
#x27;s being dropped into httpd. -- Nick Kew

Re: Solaris sed based apache filtering module (mod_sed)

2008-04-10 Thread Nick Kew
gets there first, I might try that myself when I've recovered from the apachecon backlog. As for sed-vs-simple-substitution, if the performance is no worse than a tie, then sed looks like a winner by virtue of power and versatility. -- Nick Kew

Re: Ship 1.3.0 apr in httpd 2.2.9

2008-04-11 Thread Nick Kew
n 1.3 that falls way short of what wants to go into a packaged products. Example: apr_dbd_freetds is wide open to SQL injection if used as you would use AN Other driver, because of the prepared statements implementation. -- Nick Kew

Re: mod_deflate Vary header tweak

2008-04-28 Thread Nick Kew
the response will not be compressed, regardless of the Accept-Encoding header. So it doesn't vary. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: apache mod_dbd/htaccess

2008-05-01 Thread Nick Kew
database engines, and in some cases are not good for once-only use. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: apache mod_dbd/htaccess (SUP)

2008-05-01 Thread Nick Kew
ng them on > another box the reason we have members on this one is so the darn box > actually does some work :) Can you devise a single statement you could set at top-level for all your hosts? Perhaps with the hostname as an argument to the SQL query. If that doesn't work as-is, then a

Re: 2.2.9

2008-05-06 Thread Nick Kew
runk version of docs). APR-UTIL 1.2 excludes the dangerous driver; 1.3 includes it. Can we enumerate other potentially-serious issues? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: 2.2.9

2008-05-06 Thread Nick Kew
es the need for further review. What is unclear about ¨The underlying library doesn't support prepared statements, so the driver emulates them, and the untrusted input is merged into the SQL statement.¨ ? -- Nick Kew

Re: mod_proxy race condition bug #37770

2008-05-12 Thread Nick Kew
TED] ("apr_reslist semantics"). This could enable you to configure apache to avoid this problem without sacrificing backend keepalives altogether. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

2008-05-17 Thread Nick Kew
ib/apr-util/apu-${apu_version}-config" > > Intentional? > Nope, must've been in my local version without knowing it. Bah. Seeing that reminds me there was some bug with srcdir/srclib. The above was either an uncommitted fix or an experiment that should've been rever

Re: svn commit: r657354 - in /httpd/httpd/trunk: CHANGES configure.in

2008-05-18 Thread Nick Kew
w I remember: I'd test-driven the patch, and tried to ping the original reporter (who is a regular on IRC) to clarify things before committing. But pinging him failed, and I forgot about it. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r660461 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2008-05-27 Thread Nick Kew
ocument it references. I guess that's the trouble with supporting elasticated specs. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r660461 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2008-05-27 Thread Nick Kew
ent is in the patch > for mod_rewrite.xml (which can be easily fixed of course). > So what is your exact point of concern now? Comparing not to "HttpOnly" but to "true" and "1". AKA cut&paste. ObPedant - strcasecomp for "1" seems OTT. -- N

Re: svn commit: r660749 - /httpd/httpd/branches/2.2.x/STATUS

2008-05-28 Thread Nick Kew
... CONFORMING TO SVr4, SVID, 4.4BSD, X/OPEN. How many unix platforms support none of the above? Would #ifdef HAVE_UNISTD_H be an appropriate wrapper for this, or could you have a unistd without chroot? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: PR42829

2008-05-30 Thread Nick Kew
he's not the only one doing that, and our license clearly allows it. Licenses that restrict such things seem to be widely disliked: c.f. DJB/qmail. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r660461 - /httpd/httpd/trunk/modules/mappers/mod_rewrite.c

2008-06-05 Thread Nick Kew
"secure") and "HttpOnly"? If so, that's probably the best option. Descriptive values are nice and less easy to confuse, but rejecting spec values true/1 would seem perverse. Ugh. But (2) would be fine. As would (true|1) and HttpOnly. IMHO. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Using hash tables globally ...

2008-06-09 Thread Nick Kew
s own cache, which is less efficient than you hoped, but only by O(1). Note that you shouldn't use pconf when processing a request. Your module can create its own private pool. You'll still need to take care with memory use and thread-safety when using it. -- Nick Kew Application Dev

in test framework

2008-06-11 Thread Nick Kew
31 33.33% 3 Investigating those. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: in test framework

2008-06-11 Thread Nick Kew
On Wed, 11 Jun 2008 22:33:47 +0100 Nick Kew <[EMAIL PROTECTED]> wrote: > Failed TestStat Wstat Total Fail Failed List of > Failed > --- > t/security/CVE-2004-0959.t2 512??

Re: [VOTE] Release Apache HTTP Server 2.2.9

2008-06-12 Thread Nick Kew
sor suite shows three new failures (note - failures mean tests that don't complete successfully; protocol violations are a different classification altogether). These are tests involving sending 17 interim responses, which we now reject, so I'm satisfied it's not a regression. -- Ni

buildconf and apr source

2008-06-13 Thread Nick Kew
If you try building from svn, buildconf complains of no apr/apr-util source. Why does buildconf actually need the sources? Shouldn't an installed version be sufficient? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: [PROPOSAL] merge mod_limitipconn into httpd

2008-06-18 Thread Nick Kew
ning it (insofar as noone else steps forward)? I could be a provisional +1, if IP and maintenance are sorted. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: [PROPOSAL] merge mod_limitipconn into httpd

2008-06-20 Thread Nick Kew
ere is to avoid creating a useless fork. If the original developer is still doing active development on the module, we should either merge that effort with ours or leave well alone. In practice, a merge would imply development moving to this list. If David is happy to subscribe to this list

Re: module memory allocation and threads

2008-06-23 Thread Nick Kew
w? Are you putting yourself at risk of it consuming all your memory over time? > 3. Is there a better way? Chapter 4. Or memcache, if your overhead is so big as to merit it. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Accessing the request stream with out dechunking

2008-07-01 Thread Nick Kew
re incompatible with your module. BTW, I think this belongs more on the modules list than here. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Dynamic modification of rules when using mod_proxy

2008-07-01 Thread Nick Kew
rg/message/43rw3yi5nxj6bqbs ). And also there is a > mention of such kind of a feature in the future releases of Apache in > this article : > http://people.apache.org/~mturk/docs/article/ftwai.html. 2.2.9 supports variable interpolation in proxy configuration. Now please use the users list in

mod_rewrite cookies

2008-07-19 Thread Nick Kew
ldn't it guard against this by reporting a syntax error if secure (or indeed httponly) is set to an unrecognised value? Or have I just been staring at a screen for too long? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r678179 - /httpd/httpd/branches/2.2.x/STATUS

2008-07-21 Thread Nick Kew
an just register a different authn_provider > struct and not put a reference to its own own get_realm_hash() in it) As Rüdiger just said, Hmm? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r678179 - /httpd/httpd/branches/2.2.x/STATUS

2008-07-21 Thread Nick Kew
On Mon, 21 Jul 2008 08:51:54 -0400 "Eric Covener" <[EMAIL PROTECTED]> wrote: > On Mon, Jul 21, 2008 at 8:37 AM, Nick Kew <[EMAIL PROTECTED]> wrote: > > On Mon, 21 Jul 2008 08:09:23 -0400 > > "Eric Covener" <[EMAIL PROTECTED]> wrote: > >

Re: svn commit: r683465 - /httpd/httpd/branches/2.2.x/STATUS

2008-08-06 Thread Nick Kew
- Trunk version of patch(es) works > - +1: tdonovan That's actually different: only the first patch was already proposed. Maybe you'd like to clarify? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r683465 - /httpd/httpd/branches/2.2.x/STATUS

2008-08-07 Thread Nick Kew
On Thu, 07 Aug 2008 08:09:56 -0400 Tom Donovan <[EMAIL PROTECTED]> wrote: > Nick Kew wrote: > > On Thu, 07 Aug 2008 01:30:49 - > > [EMAIL PROTECTED] wrote: > > > >> remove proposal accidentally added twice > > > > I was about to ask whether

Re: svn commit: r686809 - /httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2008-08-19 Thread Nick Kew
gurable: e.g. add a const char *sep argument to the function. -- Nick Kew

Re: SNI in 2.2.x (Re: Time for 2.2.10?)

2008-08-20 Thread Nick Kew
sonableVO rely). Not sure about Mandriva, but it's surely better than nothing. It seems clear that users *really* want it. I'd say that adds weight to the argument for including it and taking the risk. It might be worth a --with-SNI configuration option, which would label it as an experim

Dropping mod_sed into /trunk/ ?

2008-08-20 Thread Nick Kew
entry/using_mod_sed_to_filter I happen to know that Basant and Sun will be happy for us to adopt mod_sed, and I think that with that blog entry reworked into a howto doc, it'll add real value to httpd. Any thoughts on dropping it in to trunk, with a view to including it as standard in 2.4 in due course? --

Re: DO NOT REPLY [Bug 45023] DEFLATE preventing 304 NOT MODIFIED response

2008-08-21 Thread Nick Kew
e request headers (that's what processing hooks are for), and the sysop shouldn't have to configure it. Does something bad happen if you put the check in a post_read_request hook instead? -- Nick Kew

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Nick Kew
what substitute provides seems to be a strict subset of mod_sed ? That's a decision that can wait for 2.4, by which time we should have more user feedback to base it on. -- Nick Kew

Re: svn commit: r686809 - /httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2008-08-21 Thread Nick Kew
assuming I understand your meaning aright) -- Nick Kew

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Nick Kew
On 21 Aug 2008, at 13:28, Jim Jagielski wrote: On Aug 20, 2008, at 6:53 PM, Nick Kew wrote: A little while ago, Basant Kukreja published mod_sed under the Apache license. He's now also written a blog entry that could become the basis for a tutorial into how mod_sed is much more than a

Re: mod_limitipconn merge - try2

2008-08-22 Thread Nick Kew
kind-of describe it, but as of now it would seem lonely there. I wonder if there's a case for modules/misc/ ? -- Nick Kew

Re: dtrace patches.

2008-08-26 Thread Nick Kew
atches, the lower the barrier to those round tuits. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r689224 - /httpd/httpd/trunk/modules/database/mod_dbd.c

2008-08-26 Thread Nick Kew
On Tue, 26 Aug 2008 23:31:25 +0200 Ruediger Pluem <[EMAIL PROTECTED]> wrote: > [chop] Bah. Thanks for spotting that. Just trying to clean up my repo here - going through differences between /trunk/ and mine and either committing or abandoning local variants. -- Nick Kew Ap

Re: Adding full environment variable support to mod_proxy_ajp

2008-08-28 Thread Nick Kew
- were propagated to the backend appserver? If so, I'd think that a nicer solution than a new directive. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Adding full environment variable support to mod_proxy_ajp

2008-09-04 Thread Nick Kew
ement a different > interface, if a suitable one can be found. There isn't a problem with new directives. I merely suggested an alternative that I think makes sense in this instance. Evidently not everyone agrees. Bottom line: if you're doing the work, then you decide what approach you prefer. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: svn commit: r691418 [1/2] - in /httpd/httpd/trunk: ./ docs/manual/mod/ modules/filters/

2008-09-04 Thread Nick Kew
esp regarding efficient use of buckets, > is lacking in mod_sed... Anecdotal and benchmark data suggest that it's competitive in performance terms. Now that it's in svn, we can further improve it. Ruediger's comments look like a start on that. -- Nick Kew Applicati

Re: interim responses

2008-09-05 Thread Nick Kew
On Fri, 5 Sep 2008 11:07:25 +0100 "Armando Oliveira" <[EMAIL PROTECTED]> wrote: > Hello > > > In the context of CVE-2008-2364 what is the meaning of interim > responses ? How can this affect apache ? Section 10.1 of RFC2616. -- Nick Kew Application Devel

Re: svn commit: r693697 - in /httpd/sandbox/mod_valid_utf8: ./ README mod_valid_utf8.c

2008-09-10 Thread Nick Kew
k_pre_connection(utf8_pre_conn, NULL, NULL, > APR_HOOK_MIDDLE); + > +ap_register_input_filter(utf8_filter_name, utf8_in_filter, NULL, > + AP_FTYPE_NETWORK - 1); Huh? Isn't that before mod_ssl, let alone mod_deflate, mod_charset? And no excape path

Re: mod_proxy race condition bug #37770

2008-09-20 Thread Nick Kew
right. The justification for the RFC-breaking connection drop is IIRC that it's merely propagating the same from the backend to the client. That doesn't apply in the case of a timeout. -- Nick Kew

Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/

2008-09-20 Thread Nick Kew
ikely huge problems with this, but I would like to see how far we can push the Event MPM, figure out what to do better, if there is anything, and then really dive into the 3.0 development before ApacheCon. Damn. I'll hafta try & look at this. -- Nick Kew

Re: Environment confusion

2008-10-20 Thread Nick Kew
doing mass hosting. We have a start on enabling this with the expression parser, which enables configuration sections to be applied conditionally on an expression evaluated at runtime. That's work-in-progress and needs revisiting, but it can use env vars in its expression evaluation, and templating with them should be a natural future direction. (and of course, you can always use mod_rewrite). -- Nick Kew

Re: svn commit: r697357 - in /httpd/httpd/trunk: include/ modules/http/ modules/test/ server/ server/mpm/experimental/event/

2008-10-20 Thread Nick Kew
ATE_WRITE_COMPLETION; -check_pipeline(c); -if (ap_extended_status) -ap_time_process_request(c->sbh, STOP_PREQUEST); +return ap_process_request_after_handler(r); } This is a compile error in a void function. What exactly was intended here? -- Nick Kew

Re: Memory leak in mod_proxy_http and in mpm_event components.

2008-10-22 Thread Nick Kew
hing with attached patch. At a glance, this looks like more than one patch. The proxy_http patch looks straightforward, but does the event MPM fix do anything? I mean, does the scoreboard allocate memory per-request within a connection? And if so, how does this affect other MPMs? -- Nick Kew

Re: Help: Extending an add on module

2008-10-28 Thread Nick Kew
ry that exports the symbols you need. For future reference, the modules-dev list would be more on-topic for this kind of question. You might also want to check whether mod_session and family could be relevant to your needs. -- Nick Kew Application Development with Apache - the Apache Mo

Re: Simple MPM is in trunk

2008-10-28 Thread Nick Kew
s, and whatever is the equivalent on other platforms. But is there any reason we shouldn't replace *each of* the above functions with a hook? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Broken trunk build

2008-10-29 Thread Nick Kew
status: 1 rebuilding configure NONE:0: m4: ERROR: EOF in string autom4te: m4 failed with exit status: 1 A bit of googling suggests the culprit may be unbalanced brackets or quotes somewhere in the M4, but I'm struggling to find out where to look. Any clues for hunting down the cause of this? -- Nick Kew

Re: Broken trunk build

2008-10-29 Thread Nick Kew
and it was local to me. I had a modified server/mpm/config.m4 which I´d used for my own MPM. ¨svn up¨ with Paul´s changes broke it. When svn up breaks a source file, at least you get a meaningful error message pointing to exactly what needs fixing. This m4 is nasty! -- Nick Kew

Introducing modules/system

2008-10-29 Thread Nick Kew
if we adopt mpm-simple we´ll want comparable system modules for non-unixlike platforms there too. -- Nick Kew

Re: Broken trunk build

2008-10-30 Thread Nick Kew
on over whether everything goes into the module, or some stuff remains in the old unixd. Just about to look at Paul's update to that. Simple MPM was just a good cue to actually do something. When simple told me the "User" directive in httpd.conf was unrecognised -- Nick Kew

Re: mod_unixd troubs?

2008-11-03 Thread Nick Kew
doing for the prefork/worker/event MPMs. Hacking on it now, but breakage is likely for a while longer. -- Nick Kew

Re: mod_unixd troubs?

2008-11-03 Thread Nick Kew
On Tue, 4 Nov 2008 00:27:24 + Nick Kew <[EMAIL PROTECTED]> wrote: > On Mon, 03 Nov 2008 14:49:21 -0800 > Chris Darroch <[EMAIL PROTECTED]> wrote: > > > Hi -- > > > >I've been trying to get trunk to compile and run today, and > > if I com

Re: svn commit: r711234 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2008-11-04 Thread Nick Kew
gt; the userid / groupid. I deliberately avoided that, because I'm planning updates that may not apply to mod_cgid. But on further thought, I can work around that, and it's cleaner to take it out of unixd.h as you've just done. -- Nick Kew Application Development

Re: svn commit: r708462 - in /httpd/httpd/trunk/server/mpm: ./ simple/

2008-11-04 Thread Nick Kew
work with a new conventional module under arch/unix instead. At least, that's the general idea. -- Nick Kew

Re: svn commit: r711146 - in /httpd/httpd/trunk: modules/arch/unix/mod_unixd.c os/unix/unixd.c os/unix/unixd.h server/mpm/experimental/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/work

2008-11-05 Thread Nick Kew
that, what remains in os/unix is just whatever doesn't belong in mod_unixd. -- Nick Kew

Re: svn commit: r711146 - in /httpd/httpd/trunk: modules/arch/unix/mod_unixd.c os/unix/unixd.c os/unix/unixd.h server/mpm/experimental/event/event.c server/mpm/prefork/prefork.c server/mpm/worker/work

2008-11-05 Thread Nick Kew
lternatives to mod_unixd, that can either work alongside it (additional functions) or replace it entirely (other platforms under simple MPM, or alternative security models such as perchild). -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Introducing mod_privileges for Apache HTTPD

2008-11-14 Thread Nick Kew
dules/arch/unix/mod_privileges.c http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/mod/mod_privileges.xml -- Nick Kew Title: mod_privileges - Apache HTTP Server Modules | Directives | FAQ | Glossary | Sitemap Apache HTTP Server Version 2.3 Apache > HTTP Server > Documentation &g

Re: Introducing mod_privileges for Apache HTTPD

2008-11-14 Thread Nick Kew
hen you find time :-) > Before I jump in too deep, Nick is there any particular reason that > you think that a backport should NOT be attempted? No reason at all ... see above. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Introducing mod_privileges for Apache HTTPD

2008-11-17 Thread Nick Kew
ork privileges > enforced by operating system is more worthwhile feature. > > A security focused MPM is a key facility to enable the idea. > I assume it does not give first priority for performances, > but it enables to resolves some kinds of security nightmares. Thanks for telling us

Fw: Intent to Roll 2.3.0-alpha

2008-11-29 Thread Nick Kew
Not sure what happened to this yesterday ... reposting. Begin forwarded message: Date: Fri, 28 Nov 2008 17:32:50 + From: Nick Kew <[EMAIL PROTECTED]> To: dev@httpd.apache.org Subject: Re: Intent to Roll 2.3.0-alpha Paul Querna wrote: > Hi dev@, > > FYI, I intend to roll 2

Handling AP_FILTER_ERROR

2008-11-30 Thread Nick Kew
rror bucket when we encounter it in ap_http_header_filter. But I wonder if there are any other edge-cases that might arise from that? If so, we could perhaps _only_ delete a bucket if it is an AP_FILTER_ERROR. Thoughts? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Handling AP_FILTER_ERROR

2008-11-30 Thread Nick Kew
On Sun, 30 Nov 2008 18:22:39 -0500 "Eric Covener" <[EMAIL PROTECTED]> wrote: > On Sun, Nov 30, 2008 at 5:20 PM, Nick Kew <[EMAIL PROTECTED]> wrote: > > In practice, the proposed fix looks good, and I want to > > vote +1. I'm just a little concerned over

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Nick Kew
chain] { log this type = HTTP_INTERNAL_SERVER_ERROR; } else { return; } } That looks good, too. But do you see any objection to the (IMHO simpler) fix of removing error buckets as we detect them? -- Nick Kew

Re: new modules in trunk

2008-12-01 Thread Nick Kew
On 1 Dec 2008, at 08:17, Paul Querna wrote: I've committed a few new modules to trunk tonight: Interesting. Are we expecting docs anytime soon? -- Nick Kew

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Nick Kew
apr_bucket_delete(e); continue; } /* -- Nick Kew

Re: Handling AP_FILTER_ERROR

2008-12-01 Thread Nick Kew
On 1 Dec 2008, at 10:19, Ruediger Pluem wrote: if (eb) { -ap_die(eb->status, r); +int status; + +status = eb->status; +apr_brigade_cleanup(b); +ap_die(status, r); return AP_FILTER_ERROR; } Good call. +1 to that. -- Nick Kew

Re: svn commit: r722213 - /httpd/httpd/trunk/modules/http/http_request.c

2008-12-02 Thread Nick Kew
nk I've figured out more in trying to reply than I had before :-) -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: Intent to Roll 2.3.0-alpha

2008-12-03 Thread Nick Kew
raising it. -- Nick Kew

Re: [RFC] Merge wombat-integration into trunk

2008-12-05 Thread Nick Kew
bout some ballpark figures for the footprint - both disc and memory - of this proposal? That is, mod_wombat taken together with lua and any other dependencies like apreq if used. -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: modules.conf

2008-12-07 Thread Nick Kew
, as a complete replacement for mod_unixd. Seems like they would be good general statically linked defaults. It needs to know there is *some* system privileges scheme in operation and isn't running as unprotected root. But that's all. -- Nick Kew

Re: [VOTE] Release Apache HTTP server 2.3.0-alpha

2008-12-08 Thread Nick Kew
*plog, apr_pool_t *ptemp) { win_nt = (osver.dwPlatformId != VER_PLATFORM_WIN32_WINDOWS); +ap_sys_privileges_handlers(1); return OK; } -- Nick Kew

Re: mod_fcgid incubation?

2008-12-09 Thread Nick Kew
with him? Contact other contributors as a courtesy, but not let it worry us if some of them prove uncontactable, only if someone actually objects? -- Nick Kew Application Development with Apache - the Apache Modules Book http://www.apachetutor.org/

Re: mod_fcgid incubation?

2008-12-09 Thread Nick Kew
On Tue, 9 Dec 2008 21:56:43 + Nick Kew <[EMAIL PROTECTED]> wrote: > Does anyone have a complete list of people who have made nontrivial > contributions, such that their IP might be affected? Ignore that - I meant to chop those lines when I read (as opposed to skimmed) t

Re: todos for 2.3.1-alpha

2008-12-12 Thread Nick Kew
}_core. > - rename mod_wombat to mod_luau > - more documentation :) > > Anything else anyone thinks would be good to get in? Ensure non-*X platforms not only compile, but stand some chance of running. As noted in http://marc.info/?l=apache-httpd-dev&m=122878524712562&w=2 -- Nick Kew

Re: mod_fcgid license questions

2008-12-20 Thread Nick Kew
ile to show every modification to > > every ChangeLog entry. (If anyone think any change is major, please > > let me know) > >On a quick skim-through, what looks like the only large patch here > belongs to Nick Kew, who's also an active httpd committer. Hmmm, I know I'

Re: svn commit: r691418 [1/2] - in /httpd/httpd/trunk: ./

2008-12-25 Thread Nick Kew
nal one, and managed to commit the wrong one in r729438 (I blame the lurgy - just on the mend). Fixed in r729439. mod_sed is shaping up to be one of the best new goodies in 2.4! -- Nick Kew

Re: svn commit: r729579 - in /httpd/httpd/trunk: CHANGES modules/generators/mod_cgid.c

2008-12-27 Thread Nick Kew
some users, then on balance it's a Good Thing. -- Nick Kew

Re: mod_fcgid license questions

2008-12-31 Thread Nick Kew
a CLA or software grant. +1. This is in the same ballpark as third-party patches we routinely accept, e.g. from reports in bugzilla. -- Nick Kew

Re: svn commit: r731358 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ext_filter.xml modules/filters/mod_ext_filter.c

2009-01-05 Thread Nick Kew
ntation or the code is wrong. Fixed in r731388, which is included in the backport proposal. Thanks for reviewing. -- Nick Kew

Re: svn commit: r731358 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_ext_filter.xml modules/filters/mod_ext_filter.c

2009-01-05 Thread Nick Kew
Ruediger Pluem wrote: On 01/05/2009 02:16 PM, Nick Kew wrote: Ruediger Pluem wrote: Hm. I am slightly confused here. The documentation states that "abort" should be the default behaviour (that is the else branch), but if nothing is set in the config onfail defaults to -1 which woul

Re: svn commit: r731965 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2009-01-06 Thread Nick Kew
struct iovec { char *iov_base; size_t iov_len; }; #endif -- Nick Kew

Re: svn commit: r731965 - /httpd/httpd/trunk/modules/generators/mod_cgid.c

2009-01-06 Thread Nick Kew
rpose. Sorry, yes, Jeff was right. Looking at what gets passed to the vararg-consuming function, that's apr_size_t. Jeff, you have my +1 to add r731965 to my backport proposal in STATUS. -- Nick Kew

Re: svn commit: r729586 - in /httpd/httpd/trunk: CHANGES server/util_script.c

2009-01-07 Thread Nick Kew
m the upstream server or application." r732504 -- Nick Kew

Re: svn commit: r729586 - in /httpd/httpd/trunk: CHANGES server/util_script.c

2009-01-08 Thread Nick Kew
nal Server Error. But a script that generates garbage is an External Server Error, and a 502 response would be in order. It would be no bad thing to point the finger of blame at broken scripts rather than confuse the authors with "internal" errors. -- Nick Kew

Re: accept mod_fcgid codebase into httpd project

2009-01-12 Thread Nick Kew
traw...@gmail.com wrote: [+1] Accept mod_fcgid into httpd +1 And "Thanks!" to the mod_fcgid author and contributors! +1 to that, too. -- Nick Kew

Re: svn commit: r733702 - /httpd/httpd/branches/2.2.x/STATUS

2009-01-12 Thread Nick Kew
n.apache.org/viewvc?rev=733219&view=rev -2.2.x: - trunk works -+1: covener, niq, rpluem -- Nick Kew

Re: mod_backtrace and mod_whatkilledus to trunk?

2009-01-15 Thread Nick Kew
be affected and misleading? -- Nick Kew

<    5   6   7   8   9   10   11   12   13   14   >